pennmarc 0.0.2 → 1.0.0

data/spec/lib/pennmarc/helpers/location_spec.rb

@@ -11,9 +11,9 @@ describe 'PennMARC::Location' do
       let(:record) { marc_record(fields: [marc_field(tag: 'itm', subfields: { g: 'stor' })]) }
 
       it 'returns expected value' do
-        expect(helper.location(record: record, location_map: mapping,
+        expect(helper.location(record: record, location_mapping: mapping,
                                display_value: :library)).to contain_exactly('LIBRA')
-        expect(helper.location(record:, location_map: mapping,
+        expect(helper.location(record: record, location_mapping: mapping,
                                display_value: 'specific_location')).to contain_exactly('LIBRA')
       end
     end
@@ -22,9 +22,9 @@ describe 'PennMARC::Location' do
       let(:record) { marc_record(fields: [marc_field(tag: 'hld', subfields: { c: 'stor' })]) }
 
       it 'returns expected value' do
-        expect(helper.location(record: record, location_map: mapping,
+        expect(helper.location(record: record, location_mapping: mapping,
                                display_value: :library)).to contain_exactly('LIBRA')
-        expect(helper.location(record: record, location_map: mapping,
+        expect(helper.location(record: record, location_mapping: mapping,
                                display_value: 'specific_location')).to contain_exactly('LIBRA')
       end
     end
@@ -34,8 +34,9 @@ describe 'PennMARC::Location' do
         marc_record(fields: [marc_field(tag: 'itm', subfields: { g: 'stor' }),
                              marc_field(tag: 'hld', subfields: { c: 'dent' })])
       end
+
       it 'returns item location' do
-        expect(helper.location(record: record, location_map: mapping,
+        expect(helper.location(record: record, location_mapping: mapping,
                                display_value: :library)).to contain_exactly('LIBRA')
       end
     end
@@ -44,7 +45,7 @@ describe 'PennMARC::Location' do
       let(:record) { marc_record(fields: [marc_field(tag: 'itm', subfields: { g: %w[dent] })]) }
 
       it 'returns expected value' do
-        expect(helper.location(record: record, location_map: mapping,
+        expect(helper.location(record: record, location_mapping: mapping,
                                display_value: :library)).to contain_exactly('Health Sciences Libraries',
                                                                             'Levy Dental Medicine Library')
       end
@@ -54,7 +55,7 @@ describe 'PennMARC::Location' do
       let(:record) { marc_record(fields: [marc_field(tag: '852', subfields: { g: 'stor' })]) }
 
       it 'returns expected value' do
-        expect(helper.location(record: record, location_map: mapping, display_value: :library)).to be_empty
+        expect(helper.location(record: record, location_mapping: mapping, display_value: :library)).to be_empty
       end
     end
 
@@ -62,7 +63,7 @@ describe 'PennMARC::Location' do
       let(:record) { marc_record(fields: [marc_field(tag: 'itm', subfields: { g: 'stor' }), marc_field(tag: 'prt')]) }
 
       it 'returns expected value' do
-        expect(helper.location(record: record, location_map: mapping,
+        expect(helper.location(record: record, location_mapping: mapping,
                                display_value: :library)).to contain_exactly('LIBRA', 'Online library')
       end
     end

data/spec/lib/pennmarc/helpers/note_spec.rb

@@ -199,7 +199,7 @@ describe 'PennMARC::Note' do
 
     let(:fields) do
       [
-        marc_field(tag: '545', subfields: { a: 'A Creator', b: 'Additional Info', 'u': 'URI' }),
+        marc_field(tag: '545', subfields: { a: 'A Creator', b: 'Additional Info', u: 'URI' }),
         marc_field(tag: '880', subfields: { a: 'Alt Bio', b: 'Alt Info', u: 'Alt URI', '6': '545' })
       ]
     end
@@ -217,7 +217,7 @@ describe 'PennMARC::Note' do
 
     let(:fields) do
       [
-        marc_field(tag: '520', subfields: { a: 'An Abstract', b: 'Additional Summary', 'c': 'ProQuest' }),
+        marc_field(tag: '520', subfields: { a: 'An Abstract', b: 'Additional Summary', c: 'ProQuest' }),
         marc_field(tag: '880', subfields: { a: 'Alt Abstract', b: 'Alt Additional Summary', c: 'Alt ProQuest',
                                             '6': '520' })
       ]
@@ -229,5 +229,70 @@ describe 'PennMARC::Note' do
       expect(values).to contain_exactly('An Abstract Additional Summary ProQuest',
                                         'Alt Abstract Alt Additional Summary Alt ProQuest')
     end
+
+    describe '.arrangement_show' do
+      let(:record) { marc_record(fields: fields) }
+
+      let(:fields) do
+        [
+          marc_field(tag: '351', subfields: { a: 'Organized into five subseries', b: 'Arrangement pattern', c: 'Series',
+                                              '3': 'materials' }),
+          marc_field(tag: '880', subfields: { a: 'Alt organization', b: 'Alt arrangement', c: 'Alt hierarchical level',
+                                              '3': 'Alt materials', '6': '351' })
+        ]
+      end
+
+      let(:values) { helper.arrangement_show(record) }
+
+      it 'returns expected values from 351 and its linked alternate' do
+        expect(values).to contain_exactly('Organized into five subseries Arrangement pattern Series materials',
+                                          'Alt organization Alt arrangement Alt hierarchical level Alt materials')
+      end
+    end
+
+    describe '.system_details_show' do
+      let(:record) { marc_record(fields: fields) }
+
+      let(:fields) do
+        [
+          marc_field(tag: '538', subfields: { a: 'Blu-ray, region A, 1080p High Definition, full screen (1.33:1)',
+                                              i: 'display text for URI', u: 'http://www.universal.resource/locator ',
+                                              '3': ['Blu-ray disc.', '2015'] }),
+          marc_field(tag: '344', subfields: { a: 'digital', b: 'optical', c: '1.4 m/s', g: 'stereo',
+                                              h: 'digital recording', '3': 'audio disc' }),
+          marc_field(tag: '345', subfields: { a: '1 film reel (25 min.)', b: '24 fps', '3': 'Polyester print' }),
+          marc_field(tag: '346', subfields: { a: 'VHS', b: 'NTSC', '3': 'original videocassette' }),
+          marc_field(tag: '347', subfields: { a: 'video file', b: 'DVD video', e: 'region', '3': 'DVD' }),
+          marc_field(tag: '880', subfields: { a: 'Alt system details', i: 'Alternative display text', u: 'Alt URI',
+                                              '3': 'Alt materials.', '6': '538' }),
+          marc_field(tag: '880', subfields: { a: 'Alt recording', b: 'Alt medium', c: 'Alt playing speed',
+                                              g: 'Alt channel',
+                                              h: 'Alt characteristic', '3': 'Alt materials.',
+                                              '6': '344' }),
+          marc_field(tag: '880', subfields: { a: 'Alt presentation format', b: 'Alt projection speed',
+                                              '3': 'Alt materials.', '6': '345' }),
+          marc_field(tag: '880', subfields: { a: 'Alt video format', b: 'Alt broadcast', '3': 'Alt materials.',
+                                              '6': '346' }),
+          marc_field(tag: '880', subfields: { a: 'Alt file type', b: 'Alt encoding', '3': 'Alt materials.',
+                                              '6': 'Alt region' })
+
+        ]
+      end
+
+      let(:values) { helper.system_details_show(record) }
+
+      it 'returns expected from 5xx and 3xx fields and their linked alternates' do
+        expect(values).to contain_exactly(
+          'Blu-ray disc: 2015 Blu-ray, region A, 1080p High Definition, full screen (1.33:1) display
+text for URI http://www.universal.resource/locator'.squish,
+          'audio disc digital optical 1.4 m/s stereo digital recording', 'Polyester print 1 film reel (25 min.) 24 fps',
+          'original videocassette VHS NTSC', 'DVD video file DVD video region',
+          'Alt materials Alt system details Alternative display text Alt URI',
+          'Alt materials Alt recording Alt medium Alt playing speed Alt channel Alt characteristic',
+          'Alt materials Alt presentation format Alt projection speed',
+          'Alt materials Alt video format Alt broadcast'
+        )
+      end
+    end
   end
 end

data/spec/lib/pennmarc/helpers/series_spec.rb

@@ -0,0 +1,54 @@
+# frozen_string_literal: true
+
+describe 'PennMARC::Series' do
+  include MarcSpecHelpers
+
+  let(:helper) { PennMARC::Series }
+  let(:mapping) { { aut: 'Author' } }
+  let(:record) do
+    marc_record fields: [marc_field(tag: '490', subfields: { a: 'Teachings of the feathered pillow' }),
+                         marc_field(tag: '880', subfields: { '6': '490', a: 'Учения пернатой подушки' }),
+                         marc_field(tag: '800', subfields: { a: 'Bean Bagatolvski', d: '1997-', v: 'bk. 1' }),
+                         marc_field(tag: '780', subfields: { a: 'National Comfort Association' }),
+                         marc_field(tag: '785', subfields: { a: 'NCA quarterly comfortology bulletin' })]
+  end
+  let(:empty_record) do
+    marc_record fields: [marc_field(tag: '666', subfields: { a: 'test' })]
+  end
+
+  describe '.show' do
+    it 'returns the series' do
+      expect(helper.show(record, mapping)).to contain_exactly('Bean Bagatolvski 1997- bk. 1',
+                                                              'Teachings of the feathered pillow',
+                                                              'Учения пернатой подушки')
+    end
+  end
+
+  describe '.values' do
+    it 'returns the values' do
+      expect(helper.values(record, mapping)).to contain_exactly('Bean Bagatolvski 1997- bk. 1.')
+    end
+  end
+
+  describe '.search' do
+    it 'returns the search values' do
+      expect(helper.search(record)).to contain_exactly('Bean Bagatolvski 1997- bk. 1')
+    end
+
+    it 'returns an empty array if no values are found' do
+      expect(helper.search(empty_record)).to be_empty
+    end
+  end
+
+  describe '.get_continues_display' do
+    it 'gets continues for display' do
+      expect(helper.get_continues_display(record)).to contain_exactly('National Comfort Association')
+    end
+  end
+
+  describe '.get_continued_by_display' do
+    it 'gets continued by display' do
+      expect(helper.get_continued_by_display(record)).to contain_exactly('NCA quarterly comfortology bulletin')
+    end
+  end
+end

data/spec/lib/pennmarc/helpers/subject_spec.rb

@@ -61,11 +61,11 @@ describe 'PennMARC::Subject' do
   end
 
   describe '.facet' do
-    let(:record) { marc_record fields: }
+    let(:record) { marc_record fields: fields }
     let(:values) { helper.facet(record) }
 
     # TODO: find some more inspiring examples in the corpus
-    context 'for a record with poorly-coded heading values' do
+    context 'with a record with poorly-coded heading values' do
       let(:fields) { [marc_field(tag: '650', indicator2: '0', subfields: { a: 'Subject -   Heading' })] }
 
       it 'properly normalizes the heading value' do
@@ -73,7 +73,7 @@ describe 'PennMARC::Subject' do
       end
     end
 
-    context 'for a record with 650 headings with a ǂa that starts with PRO or CHR' do
+    context 'with a record with 650 headings with a ǂa that starts with PRO or CHR' do
       let(:fields) do
         [marc_field(tag: '650', indicator2: '4', subfields: { a: '%CHR 1998', '5': 'PU' }),
          marc_field(tag: '650', indicator2: '4', subfields: { a: 'PRO Potok, Adena (donor) (Potok Collection copy)',
@@ -85,7 +85,7 @@ describe 'PennMARC::Subject' do
       end
     end
 
-    context 'for a record with an indicator2 value of 3, 5 or 6' do
+    context 'with a record with an indicator2 value of 3, 5 or 6' do
       let(:fields) do
         [marc_field(tag: '650', indicator2: '3', subfields: { a: 'Nope' }),
          marc_field(tag: '650', indicator2: '5', subfields: { a: 'Nope' }),
@@ -97,7 +97,7 @@ describe 'PennMARC::Subject' do
       end
     end
 
-    context 'for a record with a valid tag, indicator2 and source specified' do
+    context 'with a record with a valid tag, indicator2 and source specified' do
       let(:fields) do
         [marc_field(tag: '650', indicator2: '7',
                     subfields: {
@@ -129,7 +129,7 @@ describe 'PennMARC::Subject' do
   end
 
   describe '.show' do
-    let(:record) { marc_record fields: }
+    let(:record) { marc_record fields: fields }
     let(:values) { helper.facet(record) }
 
     context 'with a variety of headings' do
@@ -145,8 +145,8 @@ describe 'PennMARC::Subject' do
       end
 
       it 'shows all valid subject headings without duplicates' do
-        expect(helper.show(record)).to match_array ['Nephrology--Periodicals', 'Nephrology',
-                                                    'Kidney Diseases', 'Local Heading']
+        expect(helper.show(record)).to contain_exactly('Nephrology--Periodicals', 'Nephrology', 'Kidney Diseases',
+                                                       'Local Heading')
       end
     end
 

data/spec/lib/pennmarc/helpers/title_spec.rb

@@ -20,7 +20,9 @@ describe 'PennMARC::Title' do
     end
   end
 
-  xdescribe '.search_aux'
+  describe '.search_aux' do
+    it 'returns search aux values', pending: 'Not implemented yet'
+  end
 
   describe '.show' do
     let(:record) { marc_record fields: [marc_field(tag: '245', subfields: subfields)] }

data/spec/lib/pennmarc/marc_util_spec.rb

@@ -20,11 +20,11 @@ describe 'PennMARC::Util' do
     let(:field) { marc_field subfields: { a: '123' } }
 
     it 'returns true if the specified subfield value matches the regex' do
-      expect(util.subfield_value?(field, 'a', /123/)).to be_truthy
+      expect(util).to be_subfield_value(field, 'a', /123/)
     end
 
     it 'returns false if the subfield value does not match the regex' do
-      expect(util.subfield_value?(field, 'a', /\D/)).to be_falsey
+      expect(util).not_to be_subfield_value(field, 'a', /\D/)
     end
   end
 
@@ -66,12 +66,12 @@ describe 'PennMARC::Util' do
     let(:field) { marc_field subfields: { a: 'Defined' } }
 
     it 'returns true if subfield is present on a field' do
-      expect(util.subfield_defined?(field, :a)).to be_truthy
-      expect(util.subfield_defined?(field, 'a')).to be_truthy
+      expect(util).to be_subfield_defined(field, :a)
+      expect(util).to be_subfield_defined(field, 'a')
     end
 
     it 'returns false if a subfield is not present on a field' do
-      expect(util.subfield_defined?(field, :b)).to be_falsey
+      expect(util).not_to be_subfield_defined(field, :b)
     end
   end
 
@@ -79,12 +79,12 @@ describe 'PennMARC::Util' do
     let(:field) { marc_field subfields: { a: 'Defined' } }
 
     it 'returns true if subfield is not present on a field' do
-      expect(util.subfield_undefined?(field, :b)).to be_truthy
-      expect(util.subfield_undefined?(field, 'b')).to be_truthy
+      expect(util).to be_subfield_undefined(field, :b)
+      expect(util).to be_subfield_undefined(field, 'b')
     end
 
     it 'returns false if a subfield is present on a field' do
-      expect(util.subfield_undefined?(field, :a)).to be_falsey
+      expect(util).not_to be_subfield_undefined(field, :a)
     end
   end
 
@@ -173,6 +173,7 @@ describe 'PennMARC::Util' do
 
   describe '.remove_paren_value_from_subfield_i' do
     let(:field) { marc_field(tag: '666', subfields: { i: 'Test(Remove).' }) }
+
     it 'removes the parentheses value from subfield i' do
       expect(util.remove_paren_value_from_subfield_i(field)).to eq('Test')
     end

data/spec/lib/pennmarc/parser_spec.rb

@@ -3,10 +3,10 @@
 describe PennMARC::Parser do
   include MarcSpecHelpers
 
-  let(:record) { record_from 'test.xml' }
-
   subject(:parser) { described_class.new }
 
+  let(:record) { record_from 'test.xml' }
+
   it 'delegates to helper modules properly' do
     expect { parser.title_show(record) }.not_to raise_exception
   end

data/spec/spec_helper.rb

@@ -2,7 +2,7 @@
 
 $LOAD_PATH.unshift(__dir__) unless $LOAD_PATH.include?(__dir__)
 
-Dir[File.join(__dir__, 'support', '**', '*.rb')].sort.each { |f| require f }
+Dir[File.join(__dir__, 'support', '**', '*.rb')].each { |f| require f }
 
 require 'pennmarc'
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pennmarc
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 1.0.0
 platform: ruby
 authors:
 - Mike Kanning
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-07-17 00:00:00.000000000 Z
+date: 2023-07-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -68,20 +68,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.15'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.12'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.12'
 description: |-
   This gem provides methods for parsing a Penn Libraries MARCXML record into string, array and date
                      objects for use in discovery or preservation applications.
@@ -92,6 +78,8 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
+- ".rubocop_todo.yml"
 - ".ruby-version"
 - Gemfile
 - Gemfile.lock
@@ -141,6 +129,7 @@ files:
 - spec/lib/pennmarc/helpers/note_spec.rb
 - spec/lib/pennmarc/helpers/production_spec.rb
 - spec/lib/pennmarc/helpers/relation_spec.rb
+- spec/lib/pennmarc/helpers/series_spec.rb
 - spec/lib/pennmarc/helpers/subject_spec.rb
 - spec/lib/pennmarc/helpers/title_spec.rb
 - spec/lib/pennmarc/marc_util_spec.rb
@@ -150,7 +139,8 @@ files:
 homepage: https://gitlab.library.upenn.edu/dld/catalog/pennmarc
 licenses:
 - MIT
-metadata: {}
+metadata:
+  rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options: []
 require_paths: