pennmarc 0.0.2 → 1.0.0

data/lib/pennmarc/helpers/subject.rb

@@ -30,10 +30,10 @@ module PennMARC
       # including any linked 880 fields. Fields must have an indicator2 value in {SEARCH_SOURCE_INDICATORS}.
       # @todo this includes subfields that may not be desired like 1 (uri) and 2 (source code) but this might be OK for
       #       a search (non-display) field?
-      # @param [Hash] relator_map
+      # @param [Hash] relator_mapping
       # @param [MARC::Record] record
       # @return [Array] array of all subject values for search
-      def search(record, relator_map)
+      def search(record, relator_mapping = relator_map)
         subject_fields(record, type: :search).filter_map do |field|
           subj_parts = field.filter_map do |subfield|
             # TODO: use term hash here? pro/chr would be rejected...
@@ -48,7 +48,7 @@ module PennMARC
               # TODO: use relation mapping method from Title helper? for potential URI support?
               # sf 4 should contain a 3-letter code or URI "that specifies the relationship from the entity described
               # in the record to the entity referenced in the field"
-              "#{subfield.value} #{relator_map[subfield.value.to_sym]}".strip
+              "#{subfield.value} #{relator_mapping[subfield.value.to_sym]}".strip
             else
               subfield.value
             end
@@ -79,12 +79,12 @@ module PennMARC
       # @param [MARC::Record] record
       # @return [Array] array of all subject values for display
       def show(record)
-        subject_fields(record, type: :all).filter_map do |field|
+        subject_fields(record, type: :all).filter_map { |field|
           term_hash = build_subject_hash(field)
           next if term_hash.blank? || term_hash[:count]&.zero?
 
           format_term type: :display, term: term_hash
-        end.uniq
+        }.uniq
       end
 
       # Get Subjects from "Children" ontology
@@ -93,12 +93,12 @@ module PennMARC
       # @return [Array] array of children's subject values for display
       def childrens_show(record)
         subject_fields(record, type: :display, options: { tags: DISPLAY_TAGS, indicator2: '1' })
-          .filter_map do |field|
+          .filter_map { |field|
             term_hash = build_subject_hash(field)
             next if term_hash.blank? || term_hash[:count]&.zero?
 
             format_term type: :display, term: term_hash
-          end.uniq
+          }.uniq
       end
 
       # Get Subjects from "MeSH" ontology
@@ -107,12 +107,12 @@ module PennMARC
       # @return [Array] array of MeSH subject values for display
       def medical_show(record)
         subject_fields(record, type: :display, options: { tags: DISPLAY_TAGS, indicator2: '2' })
-          .filter_map do |field|
+          .filter_map { |field|
             term_hash = build_subject_hash(field)
             next if term_hash.blank? || term_hash[:count]&.zero?
 
             format_term type: :display, term: term_hash
-          end.uniq
+          }.uniq
       end
 
       # Get Subject values from {DISPLAY_TAGS} where indicator2 is 4 and {LOCAL_TAGS}. Do not include any values where
@@ -123,14 +123,14 @@ module PennMARC
       def local_show(record)
         local_fields = subject_fields(record, type: :display, options: { tags: DISPLAY_TAGS, indicator2: '4' }) +
                        subject_fields(record, type: :local)
-        local_fields.filter_map do |field|
+        local_fields.filter_map { |field|
           next if subfield_value?(field, '2', /penncoi/)
 
           term_hash = build_subject_hash(field)
           next if term_hash.blank? || term_hash[:count]&.zero?
 
           format_term type: :display, term: term_hash
-        end.uniq
+        }.uniq
       end
 
       private

data/lib/pennmarc/helpers/title.rb

@@ -82,7 +82,7 @@ module PennMARC
       def sort(record)
         title_field = record.fields('245').first
         # attempt to get number of non-filing characters present, default to 0
-        offset = if title_field.indicator2 =~ /^[0-9]$/
+        offset = if /^[0-9]$/.match?(title_field.indicator2)
                    title_field.indicator2.to_i
                  else
                    0

data/lib/pennmarc/parser.rb

@@ -18,7 +18,9 @@ require_relative 'helpers/relation'
 require_relative 'helpers/production'
 require_relative 'helpers/edition'
 require_relative 'helpers/note'
+require_relative 'helpers/series'
 
+# Top level gem namespace
 module PennMARC
   attr_accessor :mappings
 
@@ -50,105 +52,6 @@ module PennMARC
       "PennMARC::#{helper.titleize}".constantize.public_send(meth, opts)
     end
 
-    # @todo does this fit in an existing helper?
-    # @param [MARC::Record] record
-    # @return [Object]
-    def cartographic_show(record)
-      record.fields(%w{255 342}).map do |field|
-        join_subfields(field, &subfield_not_6_or_8)
-      end
-    end
-
-    # @todo move to Identifier helper
-    # @param [MARC::Record] record
-    # @return [Object]
-    def fingerprint_show(record)
-      record.fields('026').map do |field|
-        join_subfields(field, &subfield_not_in(%w{2 5 6 8}))
-      end
-    end
-
-    # @todo does this fit in an existing helper?
-    # @param [MARC::Record] record
-    # @return [Object]
-    def arrangement_show(record)
-      get_datafield_and_880(record, '351')
-    end
-
-    # @param [MARC::Record] record
-    # @return [Object]
-    def system_details_show(record)
-      acc = []
-      acc += record.fields('538').map do |field|
-        get_sub3_and_other_subs(field, &subfield_in(%w{a i u}))
-      end
-      acc += record.fields('344').map do |field|
-        get_sub3_and_other_subs(field, &subfield_in(%w{a b c d e f g h}))
-      end
-      acc += record.fields(%w{345 346}).map do |field|
-        get_sub3_and_other_subs(field, &subfield_in(%w{a b}))
-      end
-      acc += record.fields('347').map do |field|
-        get_sub3_and_other_subs(field, &subfield_in(%w{a b c d e f}))
-      end
-      acc += record.fields('880')
-                .select { |f| has_subfield6_value(f, /^538/) }
-                .map do |field|
-        get_sub3_and_other_subs(field, &subfield_in(%w{a i u}))
-      end
-      acc += record.fields('880')
-                .select { |f| has_subfield6_value(f, /^344/) }
-                .map do |field|
-        get_sub3_and_other_subs(field, &subfield_in(%w{a b c d e f g h}))
-      end
-      acc += record.fields('880')
-                .select { |f| has_subfield6_value(f, /^(345|346)/) }
-                .map do |field|
-        get_sub3_and_other_subs(field, &subfield_in(%w{a b}))
-      end
-      acc += record.fields('880')
-                .select { |f| has_subfield6_value(f, /^347/) }
-                .map do |field|
-        get_sub3_and_other_subs(field, &subfield_in(%w{a b c d e f}))
-      end
-      acc
-    end
-
-    # @todo the legacy code here is a hot mess for a number of reasons, what do we need this field to do?
-    # @note port the needed parts from get_offsite_display, don't return HTML
-    # @param [MARC::Record] record
-    # @return [Object]
-    def offsite_show(record); end
-
-    # @todo move this to Creator helper
-    # @param [MARC::Record] record
-    # @return [Object]
-    def contributor_show(record)
-      acc = []
-      acc += record.fields(%w{700 710})
-                   .select { |f| ['', ' ', '0'].member?(f.indicator2) }
-                   .select { |f| f.none? { |sf| sf.code == 'i' } }
-                   .map do |field|
-        contributor = join_subfields(field, &subfield_in(%w{a b c d j q}))
-        contributor_append = field.select(&subfield_in(%w{e u 3 4})).map do |sf|
-          if sf.code == '4'
-            ", #{relator_codes[sf.value]}"
-          else
-            " #{sf.value}"
-          end
-        end.join
-        { value: contributor, value_append: contributor_append, link_type: 'author_creator_xfacet2' }
-      end
-      acc += record.fields('880')
-                   .select { |f| has_subfield6_value(f, /^(700|710)/) && (f.none? { |sf| sf.code == 'i' }) }
-                   .map do |field|
-        contributor = join_subfields(field, &subfield_in(%w{a b c d j q}))
-        contributor_append = join_subfields(field, &subfield_in(%w{e u 3}))
-        { value: contributor, value_append: contributor_append, link_type: 'author_creator_xfacet2' }
-      end
-      acc
-    end
-
     # Load language map from YAML and memoize in @mappings hash
     # @return [Hash]
     def language_map

data/lib/pennmarc/util.rb

@@ -9,10 +9,10 @@ module PennMARC
     # @param [MARC::DataField] field
     # @param [Proc] selector
     # @return [String]
-    def join_subfields(field, &selector)
-      field.select { |v| selector.call(v) }.filter_map { |sf|
+    def join_subfields(field, &)
+      field.select(&).filter_map { |sf|
         value = sf.value&.strip
-        next unless value.present?
+        next if value.blank?
 
         value
       }.join(' ').squish
@@ -88,7 +88,7 @@ module PennMARC
       field.filter_map do |sf|
         next unless sf.code == subfield.to_s
 
-        next unless sf.value.present?
+        next if sf.value.blank?
 
         sf.value
       end
@@ -126,11 +126,11 @@ module PennMARC
     # @param [String|Array] subfield6_value either a string to look for in sub6 or an array of them
     # @param selector [Proc] takes a subfield as argument, returns a boolean
     # @return [Array] array of linked alternates
-    def linked_alternate(record, subfield6_value, &selector)
+    def linked_alternate(record, subfield6_value, &)
       record.fields('880').filter_map do |field|
         next unless subfield_value?(field, '6', /^#{Array.wrap(subfield6_value).join('|')}/)
 
-        field.select { |sf| selector.call(sf) }.map(&:value).join(' ')
+        field.select(&).map(&:value).join(' ')
       end
     end
     alias get_880 linked_alternate
@@ -152,9 +152,9 @@ module PennMARC
     # @param [String] tag
     # @return [Array] acc
     def datafield_and_linked_alternate(record, tag)
-      record.fields(tag).filter_map do |field|
+      record.fields(tag).filter_map { |field|
         join_subfields(field, &subfield_not_in?(%w[6 8]))
-      end + linked_alternate_not_6_or_8(record, tag)
+      } + linked_alternate_not_6_or_8(record, tag)
     end
 
     # Get the substring of a string up to a given target character
@@ -186,7 +186,7 @@ module PennMARC
     # @param [MARC::Field] field
     # @return [String] subfield i without parentheses value
     def remove_paren_value_from_subfield_i(field)
-      val = field.filter_map do |sf|
+      val = field.filter_map { |sf|
         next unless sf.code == 'i'
 
         match = /\((.+?)\)/.match(sf.value)
@@ -195,7 +195,7 @@ module PennMARC
         else
           sf.value
         end
-      end.first || ''
+      }.first || ''
       trim_trailing(:colon, trim_trailing(:period, val))
     end
 
@@ -205,7 +205,7 @@ module PennMARC
     # @param [Hash] mapping
     # @return [String, NilClass] full relator string
     def translate_relator(relator_code, mapping)
-      return unless relator_code.present?
+      return if relator_code.blank?
 
       mapping[relator_code.to_sym]
     end

data/pennmarc.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |s|
   s.name        = 'pennmarc'
-  s.version     = '0.0.2'
+  s.version     = '1.0.0'
   s.summary     = 'Penn Libraries Catalog MARC parsing wisdom for cross-project usage'
   s.description = 'This gem provides methods for parsing a Penn Libraries MARCXML record into string, array and date
                    objects for use in discovery or preservation applications.'
@@ -19,5 +19,5 @@ Gem::Specification.new do |s|
   s.add_dependency 'marc', '~> 1.2'
   s.add_dependency 'nokogiri', '~> 1.15'
 
-  s.add_development_dependency 'rspec', '~> 3.12'
+  s.metadata['rubygems_mfa_required'] = 'true'
 end

data/spec/lib/pennmarc/helpers/citation_spec.rb

@@ -17,11 +17,10 @@ describe 'PennMARC::Citation' do
   end
 
   describe '.cite_as_show' do
-    let(:record) { marc_record fields: [marc_field(tag: '524', subfields: {a: 'Perkins Historical Archive, Box 2'})] }
+    let(:record) { marc_record fields: [marc_field(tag: '524', subfields: { a: 'Perkins Historical Archive, Box 2' })] }
 
     it 'returns expected citation values' do
       expect(helper.cite_as_show(record)).to contain_exactly('Perkins Historical Archive, Box 2')
     end
   end
 end
-

data/spec/lib/pennmarc/helpers/creator_spec.rb

@@ -9,7 +9,7 @@ describe 'PennMARC::Creator' do
   describe '.search' do
     let(:record) { marc_record fields: fields }
 
-    context 'for a single author record' do
+    context 'with a single author record' do
       let(:fields) do
         [marc_field(tag: '100', subfields: { a: 'Surname, Name', '0': 'http://cool.uri/12345',
                                              e: 'author', d: '1900-2000' }),
@@ -23,7 +23,7 @@ describe 'PennMARC::Creator' do
       end
     end
 
-    context 'for a corporate author record' do
+    context 'with a corporate author record' do
       let(:fields) do
         [marc_field(tag: '110', subfields: { a: 'Group of People', b: 'Annual Meeting', '4': 'aut' }),
          marc_field(tag: '880', subfields: { '6': '110', a: 'Alt. Group Name', b: 'Alt. Annual Meeting' })]
@@ -39,7 +39,7 @@ describe 'PennMARC::Creator' do
   describe '.values' do
     let(:record) { marc_record fields: fields }
 
-    context 'for a single author record' do
+    context 'with a single author record' do
       let(:fields) do
         [marc_field(tag: '100', subfields: { a: 'Author', c: 'Fancy', d: 'active 24th century AD', '4': 'aut' }),
          marc_field(tag: '880', subfields: { '6': '100', a: 'Alt Author', c: 'Alt Fanciness' })]
@@ -52,7 +52,7 @@ describe 'PennMARC::Creator' do
       end
     end
 
-    context 'for a corporate author record' do
+    context 'with a corporate author record' do
       let(:fields) do
         [marc_field(tag: '110', subfields: { a: 'Annual Report', b: 'Leader', e: 'author', '4': 'aut' })]
       end
@@ -66,12 +66,13 @@ describe 'PennMARC::Creator' do
   describe '.show' do
     let(:record) { marc_record fields: fields }
 
-    context 'for a single author record' do
+    context 'with a single author record' do
       let(:fields) do
         [marc_field(tag: '100', subfields: { a: 'Surname, Name', '0': 'http://cool.uri/12345', d: '1900-2000',
                                              e: 'author', '4': 'http://cool.uri/vocabulary/relators/aut' }),
          marc_field(tag: '880', subfields: { a: 'Surname, Alternative', '6': '100' })]
       end
+
       it 'returns single author values with no URIs anywhere' do
         values = helper.show(record)
         expect(values).to contain_exactly 'Surname, Name 1900-2000', 'Surname, Alternative'
@@ -79,11 +80,12 @@ describe 'PennMARC::Creator' do
       end
     end
 
-    context 'for a corporate author record' do
+    context 'with a corporate author record' do
       let(:fields) do
         [marc_field(tag: '110', subfields: { a: 'Group of People', b: 'Annual Meeting', '4': 'aut' }),
          marc_field(tag: '880', subfields: { '6': '110', a: 'Alt. Group Name', b: 'Alt. Annual Meeting' })]
       end
+
       it 'returns corporate author values with no URIs anywhere' do
         values = helper.show(record)
         expect(values).to contain_exactly 'Alt. Group Name Alt. Annual Meeting', 'Group of People Annual Meeting'
@@ -110,7 +112,7 @@ describe 'PennMARC::Creator' do
     let(:record) { marc_record fields: fields }
     let(:values) { helper.facet(record) }
 
-    context 'for a single author record' do
+    context 'with a single author record' do
       let(:fields) do
         [marc_field(tag: '100', subfields: { a: 'Author, Great', d: '1900-2000' }),
          marc_field(tag: '700', subfields: { a: 'Co-Author, Great', d: '1900-2000' }),
@@ -121,7 +123,8 @@ describe 'PennMARC::Creator' do
         expect(values).to contain_exactly 'Author, Added', 'Author, Great 1900-2000', 'Co-Author, Great 1900-2000'
       end
     end
-    context 'for a corporate author record' do
+
+    context 'with a corporate author record' do
       let(:fields) do
         [marc_field(tag: '110', subfields: { a: 'Group of People', b: 'Annual Meeting' }),
          marc_field(tag: '710', subfields: { a: 'A Publisher', e: 'publisher' }),
@@ -134,7 +137,8 @@ describe 'PennMARC::Creator' do
                                           'Group of People Annual Meeting'
       end
     end
-    context 'for a meeting author record' do
+
+    context 'with a meeting author record' do
       let(:fields) do
         [marc_field(tag: '111', subfields: { a: 'Conference on Things', c: 'Earth' }),
          marc_field(tag: '711', subfields: { a: 'Thing Institute', j: 'sponsoring body' }),
@@ -178,6 +182,37 @@ describe 'PennMARC::Creator' do
     end
   end
 
-  xdescribe '.conference_search'
-  xdescribe '.search_aux'
+  describe '.contributor_show' do
+    let(:record) do
+      marc_record fields: [
+        marc_field(tag: '700', subfields: { a: 'Name', b: 'I', c: 'laureate', d: '1968', e: 'author',
+                                            j: 'pseud', q: 'Fuller Name', u: 'affiliation', '3': 'materials',
+                                            '4': 'aut' }),
+        marc_field(tag: '700', subfields: { a: 'Ignore' }, indicator2: '1'),
+        marc_field(tag: '700', subfields: { i: 'Ignore' }),
+        marc_field(tag: '710', subfields: { a: 'Corporation', b: 'A division', c: 'Office', d: '1968', e: 'author',
+                                            u: 'affiliation', '3': 'materials',
+                                            '4': 'aut' }),
+        marc_field(tag: '880', subfields: {  '6': '700', a: 'Alt Name', b: 'Alt num', c: 'Alt title',
+                                             d: 'Alt date', e: 'Alt relator', j: 'Alt qualifier', q: 'Alt Fuller Name',
+                                             u: 'Alt affiliation', '3': 'Alt materials' }),
+        marc_field(tag: '880', subfields: { '6': '710', a: 'Alt Corp Name', b: 'Alt unit', c: 'Alt location',
+                                            d: 'Alt date', e: 'Alt relator', u: 'Alt Affiliation',
+                                            '3': 'Alt materials' }),
+        marc_field(tag: '880', subfields: { i: 'Ignore', '6': '700' })
+      ]
+    end
+
+    it 'returns expected contributor values' do
+      expect(helper.contributor_show(record, mapping)).to contain_exactly(
+        'Name I laureate 1968 pseud Fuller Name author affiliation materials, Author',
+        'Corporation A division Office 1968 author affiliation materials, Author',
+        'Alt Name Alt num Alt title Alt date Alt qualifier Alt Fuller Name Alt relator Alt affiliation Alt materials',
+        'Alt Corp Name Alt unit Alt location Alt date Alt relator Alt Affiliation Alt materials'
+      )
+    end
+  end
+
+  # describe '.conference_search'
+  # describe '.search_aux'
 end

data/spec/lib/pennmarc/helpers/date_spec.rb

@@ -27,7 +27,7 @@ describe 'PennMARC::Date' do
   end
 
   describe '.added' do
-    context "with date formatted '%Y-%m-%d' " do
+    context "with date formatted '%Y-%m-%d'" do
       let(:fields) { [marc_field(tag: 'itm', subfields: { q: '2023-06-28' })] }
 
       it 'returns expected value' do
@@ -70,9 +70,9 @@ describe 'PennMARC::Date' do
       end
 
       it 'outputs error message' do
-        expect do
+        expect {
           helper.added(record)
-        end.to output("Error parsing date in date added subfield: invalid date - invalid date\n").to_stdout
+        }.to output("Error parsing date in date added subfield: invalid date - invalid date\n").to_stdout
       end
     end
   end
@@ -96,9 +96,9 @@ describe 'PennMARC::Date' do
       end
 
       it 'outputs error message' do
-        expect do
+        expect {
           helper.last_updated(record)
-        end.to output("Error parsing last updated date: invalid date - invalid date\n").to_stdout
+        }.to output("Error parsing last updated date: invalid date - invalid date\n").to_stdout
       end
     end
   end

data/spec/lib/pennmarc/helpers/edition_spec.rb

@@ -10,7 +10,7 @@ describe 'PennMARC::Edition' do
                          marc_field(tag: '880', subfields: { '6': '250', b: 'رمستر' }),
                          marc_field(tag: '775', subfields: { i: 'Other Edition (Remove)',
                                                              h: 'Cool Book',
-                                                             t: 'aut'}),
+                                                             t: 'aut' }),
                          marc_field(tag: '880', subfields: { '6': '775', i: 'Autre Editione' })]
   end
 
@@ -33,6 +33,3 @@ describe 'PennMARC::Edition' do
     end
   end
 end
-
-
-

data/spec/lib/pennmarc/helpers/format_spec.rb

@@ -9,7 +9,7 @@ describe 'PennMARC::Format' do
     let(:map) { location_map }
     let(:formats) { helper.facet(record, map) }
 
-    context 'for an "Archive"' do
+    context 'with an "Archive"' do
       let(:map) do
         { musearch: { specific_location: 'Penn Museum Archives',
                       library: 'Penn Museum Archives',
@@ -19,7 +19,7 @@ describe 'PennMARC::Format' do
                       display: 'Barbara Bates Center for History of Nursing - Fagin Hall 2U' } }
       end
 
-      context 'for a record in "Penn Museum Archives (musearch)"' do
+      context 'with a record in "Penn Museum Archives (musearch)"' do
         let(:record) { marc_record fields: [marc_field(tag: 'hld', subfields: { c: 'musearch' })] }
 
         it 'returns format values of "Archive" for a record with holdings located in "musearch"' do
@@ -27,7 +27,7 @@ describe 'PennMARC::Format' do
         end
       end
 
-      context 'for a record in "Nursing Archives (nursarch)"' do
+      context 'with a record in "Nursing Archives (nursarch)"' do
         let(:record) { marc_record fields: [marc_field(tag: 'hld', subfields: { c: 'nursarch' })] }
 
         it 'returns format values of without "Archive" for a record with a holding in "nursarch"' do
@@ -36,7 +36,7 @@ describe 'PennMARC::Format' do
       end
     end
 
-    context 'for a "Newspaper"' do
+    context 'with a "Newspaper"' do
       let(:record) do
         marc_record leader: '      as',
                     fields: [marc_control_field(tag: '008', value: '                     n')]
@@ -50,7 +50,7 @@ describe 'PennMARC::Format' do
     # TODO: confirm this as desired functionality
     # Inspired by https://franklin.library.upenn.edu/catalog/FRANKLIN_999444703503681
     # which appears to be a thesis on microfilm, but only has microfilm as a format.
-    context 'for a "Thesis" on "Microfilm"' do
+    context 'with a "Thesis" on "Microfilm"' do
       let(:record) do
         marc_record leader: '      tm',
                     fields: [
@@ -65,7 +65,7 @@ describe 'PennMARC::Format' do
       end
     end
 
-    context 'for Microformats as determined by the holding call numbers' do
+    context 'with Microformats as determined by the holding call numbers' do
       let(:record) do
         marc_record fields: [marc_field(tag: 'hld', subfields: { h: 'AB123', i: '.456 Microfilm' })]
       end
@@ -75,7 +75,7 @@ describe 'PennMARC::Format' do
       end
     end
 
-    context 'for a "Book"' do
+    context 'with a "Book"' do
       let(:record) do
         marc_record leader: '      aa',
                     fields: [marc_field(tag: '245', subfields: { k: 'blah' })]
@@ -86,7 +86,7 @@ describe 'PennMARC::Format' do
       end
     end
 
-    context 'for a "Projected Graphic"' do
+    context 'with a "Projected Graphic"' do
       let(:record) do
         marc_record leader: '      gm',
                     fields: [marc_control_field(tag: '007', value: 'go hkaaa ')]
@@ -180,8 +180,28 @@ describe 'PennMARC::Format' do
     end
   end
 
+  describe 'cartographic_show' do
+    let(:record) do
+      marc_record fields: [marc_field(tag: '255', subfields: {
+                                        a: ' Scale 1:2,534,400. 40 mi. to an in.', b: 'polyconic projection',
+                                        c: '(E 74⁰--E 84⁰/N 20⁰--N 12⁰).', d: 'Declination +90° to -90°',
+                                        e: 'equinox 1950, epoch 1949-1958'
+                                      }),
+                           marc_field(tag: '342', subfields: { a: 'Polyconic', g: '0.9996', h: '0', i: '500,000',
+                                                               j: '0' })]
+    end
+
+    it 'returns expected cartographic values' do
+      expect(helper.cartographic_show(record)).to contain_exactly(
+        'Polyconic 0.9996 0 500,000 0',
+        'Scale 1:2,534,400. 40 mi. to an in. polyconic projection (E 74⁰--E 84⁰/N 20⁰--N 12⁰). Declination +90° to
+         -90° equinox 1950, epoch 1949-1958'.squish
+      )
+    end
+  end
+
   describe '.includes_manuscript?' do
-    context 'with a manuscript location incldued' do
+    context 'with a manuscript location included' do
       let(:locations) { ['Van Pelt', 'Kislak Center for Special Collections - Manuscripts Storage'] }
 
       it 'returns true' do

data/spec/lib/pennmarc/helpers/genre_spec.rb

@@ -49,7 +49,7 @@ describe 'PennMARC::Genre' do
         vanp: { specific_location: 'Van Pelt' } }
     end
 
-    context 'for a non-video, non-manuscript record' do
+    context 'with a non-video, non-manuscript record' do
       let(:fields) do
         [marc_control_field(tag: '007', value: 'x'),
          marc_field(tag: 'hld', subfields: { c: 'vanp' }),
@@ -61,7 +61,7 @@ describe 'PennMARC::Genre' do
       end
     end
 
-    context 'for a video record' do
+    context 'with a video record' do
       let(:fields) do
         [marc_control_field(tag: '007', value: 'v'),
          marc_field(tag: 'hld', subfields: { c: 'vanp' }),
@@ -74,7 +74,7 @@ describe 'PennMARC::Genre' do
       end
     end
 
-    context 'for a manuscript-located record' do
+    context 'with a manuscript-located record' do
       let(:fields) do
         [marc_control_field(tag: '007', value: 'x'),
          marc_field(tag: 'hld', subfields: { c: 'manu' }),

data/spec/lib/pennmarc/helpers/identifer_spec.rb

@@ -84,6 +84,7 @@ describe 'PennMARC::Identifier' do
         marc_field(tag: '880', subfields: { a: '006680200B', b: 'Island', '6': '028' })
       ]
     end
+
     it 'returns expected show values' do
       expect(helper.publisher_number_show(record)).to contain_exactly('602537854325',
                                                                       'B002086600 Island Def Jam Music Group',
@@ -98,8 +99,22 @@ describe 'PennMARC::Identifier' do
         marc_field(tag: '028', subfields: { a: 'B002086600', b: 'Island Def Jam Music Group' })
       ]
     end
+
     it 'returns expected search values' do
       expect(helper.publisher_number_search(record)).to contain_exactly('602537854325', 'B002086600')
     end
   end
+
+  describe '.fingerprint_show' do
+    let(:record) do
+      marc_record fields: [
+        marc_field(tag: '026', subfields: { a: 'dete nkck', b: 'vess lodo', c: 'Anno Domini MDCXXXVI', d: '3',
+                                            '2': 'fei', '5': 'penn' })
+      ]
+    end
+
+    it 'returns expected fingerprint values' do
+      expect(helper.fingerprint_show(record)).to contain_exactly('dete nkck vess lodo Anno Domini MDCXXXVI 3')
+    end
+  end
 end