peddler 2.0.4 → 2.1.0

data/test/unit/mws/test_recommendations_client.rb

@@ -8,7 +8,7 @@ class TestMWSRecommendationsClient < MiniTest::Test
     @client = MWS::Recommendations::Client.new
   end
 
-  def test_gets_last_updated_time_for_recommendations
+  def test_getting_last_updated_time_for_recommendations
     operation = {
       'Action' => 'GetLastUpdatedTimeForRecommendations',
       'MarketplaceId' => '1'
@@ -21,7 +21,7 @@ class TestMWSRecommendationsClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_lists_recommendations
+  def test_listing_recommendations
     operation = {
       'Action' => 'ListRecommendations',
       'CategoryQueryList.CategoryQuery.1.FilterOptions.FilterOption.1.Foo' => '1',
@@ -35,7 +35,7 @@ class TestMWSRecommendationsClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_lists_recommendations_by_next_token
+  def test_listing_recommendations_by_next_token
     operation = {
       'Action' => 'ListRecommendationsByNextToken',
       'NextToken' => '1'
@@ -48,7 +48,7 @@ class TestMWSRecommendationsClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_gets_service_status
+  def test_getting_service_status
     operation = {
       'Action' => 'GetServiceStatus'
     }

data/test/unit/mws/test_reports_client.rb

@@ -8,7 +8,7 @@ class TestMWSReportsClient < MiniTest::Test
     @client = MWS::Reports::Client.new
   end
 
-  def test_requests_report
+  def test_requesting_report
     operation = {
       'Action' => 'RequestReport',
       'ReportType' => 'foo',
@@ -22,7 +22,7 @@ class TestMWSReportsClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_gets_report_request_list
+  def test_getting_report_request_list
     operation = {
       'Action' => 'GetReportRequestList',
       'ReportRequestIdList.Id.1' => '1',
@@ -41,7 +41,7 @@ class TestMWSReportsClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_gets_report_request_list_by_next_token
+  def test_getting_report_request_list_by_next_token
     operation = {
       'Action' => 'GetReportRequestListByNextToken',
       'NextToken' => '1'
@@ -54,7 +54,7 @@ class TestMWSReportsClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_gets_report_request_count
+  def test_getting_report_request_count
     operation = {
       'Action' => 'GetReportRequestCount',
       'ReportTypeList.Type.1' => '1',
@@ -71,7 +71,7 @@ class TestMWSReportsClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_cancels_report_requests
+  def test_canceling_report_requests
     operation = {
       'Action' => 'CancelReportRequests',
       'ReportTypeList.Type.1' => '1',
@@ -88,7 +88,7 @@ class TestMWSReportsClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_gets_report_list
+  def test_getting_report_list
     operation = {
       'Action' => 'GetReportList',
       'ReportTypeList.Type.1' => '1',
@@ -105,7 +105,7 @@ class TestMWSReportsClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_gets_report_list_by_next_token
+  def test_getting_report_list_by_next_token
     operation = {
       'Action' => 'GetReportListByNextToken',
       'NextToken' => '1'
@@ -118,7 +118,7 @@ class TestMWSReportsClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_gets_report_count
+  def test_getting_report_count
     operation = {
       'Action' => 'GetReportCount',
       'ReportTypeList.Type.1' => '1'
@@ -133,7 +133,7 @@ class TestMWSReportsClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_gets_report
+  def test_getting_report
     operation = {
       'Action' => 'GetReport',
       'ReportId' => '1'
@@ -146,7 +146,7 @@ class TestMWSReportsClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_manages_report_schedule
+  def test_managing_report_schedule
     operation = {
       'Action' => 'ManageReportSchedule',
       'ReportType' => '1',
@@ -160,7 +160,7 @@ class TestMWSReportsClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_gets_report_schedule_list
+  def test_getting_report_schedule_list
     operation = {
       'Action' => 'GetReportScheduleList',
       'ReportTypeList.Type.1' => '1',
@@ -174,13 +174,13 @@ class TestMWSReportsClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_gets_report_schedule_list_by_next_token
+  def test_getting_report_schedule_list_by_next_token
     assert_raises NotImplementedError do
       @client.get_report_schedule_list_by_next_token
     end
   end
 
-  def test_gets_report_schedule_count
+  def test_getting_report_schedule_count
     operation = {
       'Action' => 'GetReportScheduleCount',
       'ReportTypeList.Type.1' => '1'
@@ -193,7 +193,7 @@ class TestMWSReportsClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_updates_report_acknowledgements
+  def test_updating_report_acknowledgements
     operation = {
       'Action' => 'UpdateReportAcknowledgements',
       'Acknowledged' => true,

data/test/unit/mws/test_sellers_client.rb

@@ -8,7 +8,7 @@ class TestMWSSellersClient < MiniTest::Test
     @client = MWS::Sellers::Client.new
   end
 
-  def test_lists_marketplace_participations
+  def test_listing_marketplace_participations
     operation = {
       'Action' => 'ListMarketplaceParticipations'
     }
@@ -20,7 +20,7 @@ class TestMWSSellersClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_lists_marketplace_participations_by_next_token
+  def test_listing_marketplace_participations_by_next_token
     operation = {
       'Action' => 'ListMarketplaceParticipationsByNextToken',
       'NextToken' => '1'
@@ -33,7 +33,7 @@ class TestMWSSellersClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_gets_service_status
+  def test_getting_service_status
     operation = {
       'Action' => 'GetServiceStatus'
     }

data/test/unit/mws/test_subscriptions_client.rb

@@ -8,7 +8,7 @@ class TestMWSSubscriptionsClient < MiniTest::Test
     @client = MWS::Subscriptions::Client.new
   end
 
-  def test_registers_destination
+  def test_registering_destination
     operation = {
       'Action' => 'RegisterDestination',
       'MarketplaceId' => '321',
@@ -24,7 +24,7 @@ class TestMWSSubscriptionsClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_deregisters_destination
+  def test_deregistering_destination
     operation = {
       'Action' => 'DeregisterDestination',
       'MarketplaceId' => '123',
@@ -40,7 +40,7 @@ class TestMWSSubscriptionsClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_deregisters_destination_with_alternate_marketplace
+  def test_deregistering_destination_with_alternate_marketplace
     operation = {
       'Action' => 'DeregisterDestination',
       'MarketplaceId' => '321',
@@ -56,7 +56,7 @@ class TestMWSSubscriptionsClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_lists_registered_destinations
+  def test_listing_registered_destinations
     operation = {
       'Action' => 'ListRegisteredDestinations',
       'MarketplaceId' => '321'
@@ -69,7 +69,7 @@ class TestMWSSubscriptionsClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_sends_test_notification_to_destination
+  def test_sending_test_notification_to_destination
     operation = {
       'Action' => 'SendTestNotificationToDestination',
       'MarketplaceId' => '321',
@@ -85,7 +85,7 @@ class TestMWSSubscriptionsClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_creates_subscription
+  def test_creating_subscription
     operation = {
       'Action' => 'CreateSubscription',
       'MarketplaceId' => '321',
@@ -103,7 +103,7 @@ class TestMWSSubscriptionsClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_gets_subscription
+  def test_getting_subscription
     operation = {
       'Action' => 'GetSubscription',
       'MarketplaceId' => '321',
@@ -120,7 +120,7 @@ class TestMWSSubscriptionsClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_deletes_subscription
+  def test_deleting_subscription
     operation = {
       'Action' => 'DeleteSubscription',
       'MarketplaceId' => '321',
@@ -137,7 +137,7 @@ class TestMWSSubscriptionsClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_lists_subscriptions
+  def test_listing_subscriptions
     operation = {
       'Action' => 'ListSubscriptions',
       'MarketplaceId' => '321'
@@ -150,7 +150,7 @@ class TestMWSSubscriptionsClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_updates_subscription
+  def test_updating_subscription
     operation = {
       'Action' => 'UpdateSubscription',
       'MarketplaceId' => '321',
@@ -168,7 +168,7 @@ class TestMWSSubscriptionsClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_gets_service_status
+  def test_getting_service_status
     operation = {
       'Action' => 'GetServiceStatus'
     }

data/test/unit/peddler/errors/test_builder.rb

@@ -28,15 +28,15 @@ class TestPeddlerErrorsBuilder < MiniTest::Test
       super
     end
 
-    def test_generates_custom_error
+    def test_custom_error
       assert_includes @error.class.name, @code
     end
 
-    def test_provides_message
+    def test_message
       assert_equal @message, @error.message
     end
 
-    def test_provides_cause
+    def test_cause
       assert_equal @cause, @error.cause
     end
   end
@@ -58,7 +58,7 @@ class TestPeddlerErrorsBuilder < MiniTest::Test
       super
     end
 
-    def test_returns_nothing
+    def test_that_it_returns_nothing
       assert_nil @error
     end
   end

data/test/unit/peddler/errors/test_class_generator.rb

@@ -4,7 +4,7 @@ require 'helper'
 require 'peddler/errors/class_generator'
 
 class TestPeddlerErrorsClassGenerator < MiniTest::Test
-  def test_builds_error_class
+  def test_building_an_error_class
     Peddler::Errors::ClassGenerator.call('Foo')
     assert Peddler::Errors::Foo
   end

data/test/unit/peddler/errors/test_error.rb

@@ -9,25 +9,25 @@ class TestPeddlerErrorsError < MiniTest::Test
     @error = Peddler::Errors::Error.new('message', @cause)
   end
 
-  def test_sets_message
+  def test_message
     assert_equal 'message', @error.message
   end
 
-  def test_sets_cause
+  def test_cause
     assert_equal @cause, @error.cause
   end
 
-  def test_defines_common_errors
+  def test_that_it_defines_common_errors
     Peddler::Errors::CODES.each do |name|
       assert ::Peddler::Errors.const_defined?(name)
     end
   end
 
-  def test_allows_nil_arguments
+  def test_that_it_allows_nil_arguments
     Peddler::Errors::Error.new
   end
 
-  def test_delegates_response_to_cause
+  def test_that_it_delegates_response_to_cause
     assert_equal @cause.response, @error.response
   end
 end

data/test/unit/peddler/errors/test_parser.rb

@@ -26,19 +26,19 @@ class TestPeddlerErrorsParser < MiniTest::Test
     @parser = Peddler::Errors::Parser.new(res)
   end
 
-  def test_parses_data
+  def test_parsing_data
     assert @parser.parse
   end
 
-  def test_has_a_message
+  def test_message
     assert @parser.message
   end
 
-  def test_has_code
+  def test_code
     assert @parser.code
   end
 
-  def test_has_type
+  def test_type
     assert @parser.type
   end
 end

data/test/unit/peddler/test_client.rb

@@ -24,27 +24,27 @@ class TestPeddlerClient < MiniTest::Test
       super
     end
 
-    def test_has_user_agent
+    def test_user_agent
       assert @client.connection.data[:headers].key?('User-Agent')
     end
 
-    def test_inherits_parents_params
+    def test_inheritance_of_parents_params
       assert_equal Peddler::Client.params, @klass.params
     end
 
-    def test_params_include_seller_id
+    def test_that_params_include_seller_id
       assert @klass.params.key?('SellerId')
     end
 
-    def test_params_include_auth_token
+    def test_that_params_include_auth_token
       @klass.params.key?('MWSAuthToken')
     end
 
-    def test_inherits_parents_parser
+    def test_inheritance_of_parents_parser
       assert_equal @klass.parser, Class.new(@klass).parser
     end
 
-    def test_sets_marketplace
+    def test_setting_marketplace
       marketplace = Peddler::Marketplace.find('US')
       @client.marketplace = 'US'
       assert_equal marketplace, @client.marketplace
@@ -52,19 +52,19 @@ class TestPeddlerClient < MiniTest::Test
       assert_equal marketplace, @client.marketplace
     end
 
-    def test_configures_when_initialising
+    def test_configuring_when_initialising
       client = @klass.new(aws_access_key_id: '123')
       assert_equal '123', client.aws_access_key_id
     end
 
-    def test_sets_content_type_header_for_latin_flat_file
+    def test_setting_content_type_header_for_latin_flat_file
       @client.body = 'foo'
       content_type = @client.headers.fetch('Content-Type')
 
       assert_equal 'text/tab-separated-values; charset=CP1252', content_type
     end
 
-    def test_sets_content_type_header_for_chinese_flat_file
+    def test_setting_content_type_header_for_chinese_flat_file
       @client.marketplace = 'CN'
       @client.body = 'foo'
       content_type = @client.headers.fetch('Content-Type')
@@ -72,7 +72,7 @@ class TestPeddlerClient < MiniTest::Test
       assert_equal 'text/tab-separated-values; charset=UTF-16', content_type
     end
 
-    def test_sets_content_type_header_for_japanese_flat_file
+    def test_setting_content_type_header_for_japanese_flat_file
       @client.marketplace = 'JP'
       @client.body = 'foo'
       content_type = @client.headers.fetch('Content-Type')
@@ -80,42 +80,42 @@ class TestPeddlerClient < MiniTest::Test
       assert_equal 'text/tab-separated-values; charset=Windows-31J', content_type
     end
 
-    def test_sets_content_type_header_for_xml
+    def test_setting_content_type_header_for_xml
       @client.body = '<?xml version="1.0"?><Foo></Foo>'
       content_type = @client.headers.fetch('Content-Type')
 
       assert_equal 'text/xml', content_type
     end
 
-    def test_encodes_body_for_latin_flat_file
+    def test_encoding_body_for_latin_flat_file
       @client.body = 'foo'
       assert_equal 'Windows-1252', @client.body.encoding.to_s
     end
 
-    def test_encodes_body_for_chinese_flat_file
+    def test_encoding_body_for_chinese_flat_file
       @client.marketplace = 'CN'
       @client.body = 'foo'
       assert_equal 'UTF-16', @client.body.encoding.to_s
     end
 
-    def test_encodes_body_for_japanese_flat_file
+    def test_encoding_body_for_japanese_flat_file
       @client.marketplace = 'JP'
       @client.body = 'foo'
       assert_equal 'Windows-31J', @client.body.encoding.to_s
     end
 
-    def test_runs_a_request
+    def test_running_a_request
       res = @client.run
       assert_equal @response_body, res.body
     end
 
-    def test_clears_body_when_run_succeeds
+    def test_clearing_body_when_run_succeeds
       @client.body = 'foo'
       @client.run
       assert_nil @client.body
     end
 
-    def test_streams_response
+    def test_streaming_response
       chunks = ''
       streamer = ->(chunk, _, _) { chunks += chunk }
       @client.run(&streamer)
@@ -136,7 +136,7 @@ class TestPeddlerClient < MiniTest::Test
       @events = {}
     end
 
-    def test_request_preserves_user_agent
+    def test_that_request_preserves_user_agent
       @client.defaults.update(instrumentor: Instrumentor)
       @client.run
       headers = Instrumentor.events['excon.request'][:headers]
@@ -164,7 +164,7 @@ class TestPeddlerClient < MiniTest::Test
       end
     end
 
-    def test_does_not_clear_body_when_run_fails
+    def test_it_does_not_clear_body_when_run_fails
       @client.body = 'foo'
       assert_raises Peddler::Errors::RequestThrottled do
         @client.run
@@ -192,7 +192,7 @@ class TestPeddlerClient < MiniTest::Test
       end
     end
 
-    def test_does_not_clear_body_when_run_fails
+    def test_it_does_not_clear_body_when_run_fails
       @client.body = 'foo'
       assert_raises Excon::Error::InternalServerError do
         @client.run