peddler 2.0.4 → 2.1.0

data/test/integration/test_multibyte_queries.rb

@@ -6,7 +6,7 @@ require 'mws/products'
 class TestMultibyteQueries < IntegrationTest
   use 'Products'
 
-  def test_posts_multibyte_queries_properly
+  def test_posting_multibyte_queries_properly
     ret = clients.map do |client|
       res = client.list_matching_products(client.marketplace.id, 'félix guattari machinic eros')
       res.body.force_encoding 'UTF-8' if defined? Ox # Ox workaround

data/test/integration/test_mws_headers.rb

@@ -6,7 +6,7 @@ require 'mws/products'
 class TestMWSHeaders < IntegrationTest
   use 'Products'
 
-  def test_parses_headers
+  def test_parsing_headers
     clients.each do |client|
       res = client.get_lowest_priced_offers_for_asin(client.marketplace.id,
                                                      '1780935374', 'New')

data/test/integration/test_off_amazon_payments.rb

@@ -4,7 +4,7 @@ require 'integration_helper'
 require 'mws/off_amazon_payments'
 
 class TestOffAmazonPayments < IntegrationTest
-  def test_gets_service_status
+  def test_getting_service_status
     clients.each do |client|
       res = client.get_service_status
       refute_empty res.parse

data/test/integration/test_orders.rb

@@ -4,7 +4,7 @@ require 'integration_helper'
 require 'mws/orders'
 
 class TestOrders < IntegrationTest
-  def test_gets_orders
+  def test_getting_orders
     clients.each do |client|
       order_ids = client.list_orders(client.marketplace.id,
                                      created_after: Date.new(2015),
@@ -21,7 +21,7 @@ class TestOrders < IntegrationTest
     end
   end
 
-  def test_gets_service_status
+  def test_getting_service_status
     clients.each do |client|
       res = client.get_service_status
       refute_empty res.parse

data/test/integration/test_products.rb

@@ -4,56 +4,56 @@ require 'integration_helper'
 require 'mws/products'
 
 class TestProducts < IntegrationTest
-  def test_lists_matching_products
+  def test_listing_matching_products
     clients.each do |client|
       res = client.list_matching_products(client.marketplace.id, 'architecture')
       refute_empty res.parse
     end
   end
 
-  def test_gets_matching_product
+  def test_getting_matching_product
     clients.each do |client|
       res = client.get_matching_product(client.marketplace.id, '1780935374')
       refute_empty res.parse
     end
   end
 
-  def test_gets_matching_product_for_id
+  def test_getting_matching_product_for_id
     clients.each do |client|
       res = client.get_matching_product_for_id(client.marketplace.id, 'ISBN', '9781780935379')
       refute_empty res.parse
     end
   end
 
-  def test_gets_competitive_pricing_for_asin
+  def test_getting_competitive_pricing_for_asin
     clients.each do |client|
       res = client.get_competitive_pricing_for_asin(client.marketplace.id, '1780935374')
       refute_empty res.parse
     end
   end
 
-  def test_gets_lowest_offer_listings_for_asin
+  def test_getting_lowest_offer_listings_for_asin
     clients.each do |client|
       res = client.get_lowest_offer_listings_for_asin(client.marketplace.id, '1780935374')
       refute_empty res.parse
     end
   end
 
-  def test_gets_lowest_priced_offers_for_asin
+  def test_getting_lowest_priced_offers_for_asin
     clients.each do |client|
       res = client.get_lowest_priced_offers_for_asin(client.marketplace.id, '1780935374', 'New')
       refute_empty res.parse
     end
   end
 
-  def test_gets_product_categories_for_asin
+  def test_getting_product_categories_for_asin
     clients.each do |client|
       res = client.get_product_categories_for_asin(client.marketplace.id, '1780935374')
       refute_empty res.parse
     end
   end
 
-  def test_gets_my_fees_estimate
+  def test_getting_my_fees_estimate
     clients.each do |client|
       res = client.get_my_fees_estimate(
         marketplace_id: client.marketplace.id,
@@ -72,7 +72,7 @@ class TestProducts < IntegrationTest
     end
   end
 
-  def test_gets_service_status
+  def test_getting_service_status
     clients.each do |client|
       res = client.get_service_status
       refute_empty res.parse
@@ -83,12 +83,12 @@ class TestProducts < IntegrationTest
 
   CURRENCY_CODES = {
     'A2EUQ1WTGCTBG2' => 'CAD',
-    'AAHKV2X7AFYLW'  => 'CNY',
+    'AAHKV2X7AFYLW' => 'CNY',
     'A1F83G8C2ARO7P' => 'GBP',
-    'A21TJRUUN4KGV'  => 'INR',
+    'A21TJRUUN4KGV' => 'INR',
     'A1VC38T7YXB528' => 'JPY',
     'A1AM78C64UM0Y8' => 'MXN',
-    'ATVPDKIKX0DER'  => 'USD'
+    'ATVPDKIKX0DER' => 'USD'
   }.freeze
 
   def currency_code_for(marketplace_id)

data/test/integration/test_recommendations.rb

@@ -4,14 +4,14 @@ require 'integration_helper'
 require 'mws/recommendations'
 
 class TestRecommendations < IntegrationTest
-  def test_lists_recommendations
+  def test_listing_recommendations
     clients.each do |client|
       res = client.list_recommendations(client.marketplace.id)
       refute_empty res.parse
     end
   end
 
-  def test_gets_service_status
+  def test_getting_service_status
     clients.each do |client|
       res = client.get_service_status
       refute_empty res.parse

data/test/integration/test_reports.rb

@@ -4,42 +4,42 @@ require 'integration_helper'
 require 'mws/reports'
 
 class TestReports < IntegrationTest
-  def test_gets_report_request_count
+  def test_getting_report_request_count
     clients.each do |client|
       res = client.get_report_request_count
       refute_empty res.parse
     end
   end
 
-  def test_gets_report_request_list
+  def test_getting_report_request_list
     clients.each do |client|
       res = client.get_report_request_list
       refute_empty res.parse
     end
   end
 
-  def test_gets_report_schedule_count
+  def test_getting_report_schedule_count
     clients.each do |client|
       res = client.get_report_schedule_count
       refute_empty res.parse
     end
   end
 
-  def test_lists_report_schedules
+  def test_listing_report_schedules
     clients.each do |client|
       res = client.get_report_schedule_list
       refute_empty res.parse
     end
   end
 
-  def test_gets_report_count
+  def test_getting_report_count
     clients.each do |client|
       res = client.get_report_count
       refute_empty res.parse
     end
   end
 
-  def test_gets_report
+  def test_getting_report
     clients.each do |client|
       res = client.get_report_list(max_count: 1)
       id = res.parse['ReportInfo']['ReportId']

data/test/integration/test_sellers.rb

@@ -4,7 +4,7 @@ require 'integration_helper'
 require 'mws/sellers'
 
 class TestSellers < IntegrationTest
-  def test_gets_service_status
+  def test_getting_service_status
     clients.each do |client|
       res = client.get_service_status
       refute_empty res.parse

data/test/integration/test_subscriptions.rb

@@ -4,21 +4,21 @@ require 'integration_helper'
 require 'mws/subscriptions'
 
 class TestSubscriptions < IntegrationTest
-  def test_lists_registered_destinations
+  def test_listing_registered_destinations
     clients.each do |client|
       res = client.list_registered_destinations(client.marketplace.id)
       refute_empty res.parse
     end
   end
 
-  def test_lists_subscriptions
+  def test_listing_subscriptions
     clients.each do |client|
       res = client.list_subscriptions(client.marketplace.id)
       refute_empty res.parse
     end
   end
 
-  def test_gets_service_status
+  def test_getting_service_status
     clients.each do |client|
       res = client.get_service_status
       refute_empty res.parse

data/test/integration_helper.rb

@@ -13,16 +13,17 @@ class IntegrationTest < MiniTest::Test
     end
 
     def clients
-      @clients ||= build_clients
+      klass = MWS.const_get("#{current_endpoint}::Client")
+      ::Credentials.to_a.shuffle.each_with_object([]) do |credentials, memo|
+        client = klass.new(credentials)
+        country_code = client.marketplace.country_code
+        memo.define_singleton_method(country_code.downcase) { client }
+        memo << client
+      end
     end
 
     private
 
-    def build_clients
-      klass = MWS.const_get("#{current_endpoint}::Client")
-      ::Credentials.map { |credentials| klass.new(credentials) }.shuffle
-    end
-
     def current_endpoint
       @current_endpoint ||= name.sub('Test', '')
     end
@@ -38,7 +39,8 @@ end
 VCR.configure do |c|
   c.before_record do |interaction|
     %w[
-      BuyerName BuyerEmail Name AddressLine1 PostalCode Phone Amount
+      BuyerName BuyerEmail Name AddressLine1 City StateOrProvinceCode PostalCode
+      Phone Amount AmazonOrderId SellerOrderId
     ].each do |key|
       interaction.response.body.gsub!(/<#{key}>[^<]+</, "<#{key}>FILTERED<")
     end

data/test/unit/mws/test_feeds_client.rb

@@ -8,7 +8,7 @@ class TestMWSFeedsClient < MiniTest::Test
     @client = MWS::Feeds::Client.new(marketplace: 'GB')
   end
 
-  def test_submits_feed
+  def test_submitting_feed
     operation = {
       'Action' => 'SubmitFeed',
       'FeedType' => 'type',
@@ -22,7 +22,7 @@ class TestMWSFeedsClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_gets_feed_submission_list
+  def test_getting_feed_submission_list
     operation = {
       'Action' => 'GetFeedSubmissionList',
       'FeedSubmissionIdList.Id.1' => '1',
@@ -41,7 +41,7 @@ class TestMWSFeedsClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_gets_feed_submission_list_by_next_token
+  def test_getting_feed_submission_list_by_next_token
     operation = {
       'Action' => 'GetFeedSubmissionListByNextToken',
       'NextToken' => '1'
@@ -54,7 +54,7 @@ class TestMWSFeedsClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_gets_feed_submission_count
+  def test_getting_feed_submission_count
     operation = {
       'Action' => 'GetFeedSubmissionCount',
       'FeedTypeList.Type.1' => '1',
@@ -71,7 +71,7 @@ class TestMWSFeedsClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_cancels_feed_submissions
+  def test_canceling_feed_submissions
     operation = {
       'Action' => 'CancelFeedSubmissions',
       'FeedTypeList.Type.1' => '1',
@@ -88,7 +88,7 @@ class TestMWSFeedsClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_gets_feed_submission_result
+  def test_getting_feed_submission_result
     operation = {
       'Action' => 'GetFeedSubmissionResult',
       'FeedSubmissionId' => '1'

data/test/unit/mws/test_finances_client.rb

@@ -8,7 +8,7 @@ class TestMWSFinancesClient < MiniTest::Test
     @client = MWS::Finances::Client.new
   end
 
-  def test_lists_financial_event_groups
+  def test_listing_financial_event_groups
     operation = {
       'Action' => 'ListFinancialEventGroups',
       'FinancialEventGroupStartedAfter' => '2015-01-01'
@@ -21,7 +21,7 @@ class TestMWSFinancesClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_lists_financial_event_groups_by_next_token
+  def test_listing_financial_event_groups_by_next_token
     operation = {
       'Action' => 'ListFinancialEventGroupsByNextToken',
       'NextToken' => '1'
@@ -34,7 +34,7 @@ class TestMWSFinancesClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_lists_financial_events
+  def test_listing_financial_events
     operation = {
       'Action' => 'ListFinancialEvents',
       'AmazonOrderId' => '123'
@@ -47,7 +47,7 @@ class TestMWSFinancesClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_lists_financial_events_by_next_token
+  def test_listing_financial_events_by_next_token
     operation = {
       'Action' => 'ListFinancialEventsByNextToken',
       'NextToken' => '1'
@@ -60,7 +60,7 @@ class TestMWSFinancesClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_gets_service_status
+  def test_getting_service_status
     operation = {
       'Action' => 'GetServiceStatus'
     }

data/test/unit/mws/test_fulfillment_inbound_shipment_client.rb

@@ -8,7 +8,7 @@ class TestMWSFulfillmentInboundShipmentClient < MiniTest::Test
     @client = MWS::FulfillmentInboundShipment::Client.new
   end
 
-  def test_gets_inbound_guidance_for_sku
+  def test_getting_inbound_guidance_for_sku
     operation = {
       'Action' => 'GetInboundGuidanceForSKU',
       'MarketplaceId' => 'ATVPDKIKX0DER',
@@ -22,7 +22,7 @@ class TestMWSFulfillmentInboundShipmentClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_gets_inbound_guidance_for_asin
+  def test_getting_inbound_guidance_for_asin
     operation = {
       'Action' => 'GetInboundGuidanceForASIN',
       'MarketplaceId' => 'ATVPDKIKX0DER',
@@ -36,7 +36,7 @@ class TestMWSFulfillmentInboundShipmentClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_creates_inbound_shipment_plan
+  def test_creating_inbound_shipment_plan
     operation = {
       'Action' => 'CreateInboundShipmentPlan',
       'LabelPrepPreference' => 'SELLER_LABEL',
@@ -87,7 +87,7 @@ class TestMWSFulfillmentInboundShipmentClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_creates_inbound_shipment
+  def test_creating_inbound_shipment
     operation = {
       'Action' => 'CreateInboundShipment',
       'ShipmentId' => '1',
@@ -102,7 +102,7 @@ class TestMWSFulfillmentInboundShipmentClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_updates_inbound_shipment
+  def test_updating_inbound_shipment
     operation = {
       'Action' => 'UpdateInboundShipment',
       'ShipmentId' => '1',
@@ -117,7 +117,7 @@ class TestMWSFulfillmentInboundShipmentClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_gets_preorder_info
+  def test_getting_preorder_info
     operation = {
       'Action' => 'GetPreorderInfo',
       'ShipmentId' => '1'
@@ -130,7 +130,7 @@ class TestMWSFulfillmentInboundShipmentClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_confirms_preorder
+  def test_confirming_preorder
     operation = {
       'Action' => 'ConfirmPreorder',
       'ShipmentId' => '1',
@@ -144,7 +144,7 @@ class TestMWSFulfillmentInboundShipmentClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_gets_prep_instructions_for_sku
+  def test_getting_prep_instructions_for_sku
     operation = {
       'Action' => 'GetPrepInstructionsForSKU',
       'ShipToCountryCode' => 'US',
@@ -158,7 +158,7 @@ class TestMWSFulfillmentInboundShipmentClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_gets_prep_instructions_for_asin
+  def test_getting_prep_instructions_for_asin
     operation = {
       'Action' => 'GetPrepInstructionsForASIN',
       'ShipToCountryCode' => 'US',
@@ -173,7 +173,23 @@ class TestMWSFulfillmentInboundShipmentClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_puts_transport_content_with_package_list
+  def test_handling_bug_when_getting_prep_instructions_for_asin
+    first_run = true
+    callable = lambda {
+      if first_run
+        first_run = false
+        raise Peddler::Errors::Error, "Value null at 'asinList'"
+      end
+    }
+    @client.stub(:run, callable) do
+      @client.get_prep_instructions_for_asin('US', 'B00005N5PF')
+    end
+
+    refute @client.operation.key?('ASINList.Id.1')
+    assert @client.operation.key?('AsinList.Id.1')
+  end
+
+  def test_putting_transport_content_with_package_list
     transport_details = {
       parcel_data: {
         package_list: [
@@ -199,7 +215,7 @@ class TestMWSFulfillmentInboundShipmentClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_puts_transport_content_with_pallet_list
+  def test_putting_transport_content_with_pallet_list
     transport_details = {
       parcel_data: {
         pallet_list: [
@@ -225,7 +241,7 @@ class TestMWSFulfillmentInboundShipmentClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_estimates_transport_request
+  def test_estimating_transport_request
     operation = {
       'Action' => 'EstimateTransportRequest',
       'ShipmentId' => '1'
@@ -238,7 +254,7 @@ class TestMWSFulfillmentInboundShipmentClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_gets_transport_request
+  def test_getting_transport_request
     operation = {
       'Action' => 'GetTransportContent',
       'ShipmentId' => '1'
@@ -251,7 +267,7 @@ class TestMWSFulfillmentInboundShipmentClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_confirms_transport_request
+  def test_confirming_transport_request
     operation = {
       'Action' => 'ConfirmTransportRequest',
       'ShipmentId' => '1'
@@ -264,7 +280,7 @@ class TestMWSFulfillmentInboundShipmentClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_voids_transport_request
+  def test_voiding_transport_request
     operation = {
       'Action' => 'VoidTransportRequest',
       'ShipmentId' => '1'
@@ -277,7 +293,7 @@ class TestMWSFulfillmentInboundShipmentClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_gets_package_labels
+  def test_getting_package_labels
     operation = {
       'Action' => 'GetPackageLabels',
       'ShipmentId' => '1',
@@ -291,7 +307,7 @@ class TestMWSFulfillmentInboundShipmentClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_gets_unique_package_labels
+  def test_getting_unique_package_labels
     operation = {
       'Action' => 'GetUniquePackageLabels',
       'ShipmentId' => 'FBAQFGQZ',
@@ -313,7 +329,7 @@ class TestMWSFulfillmentInboundShipmentClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_gets_pallet_labels
+  def test_getting_pallet_labels
     operation = {
       'Action' => 'GetPalletLabels',
       'ShipmentId' => 'FBAQFGQZ',
@@ -328,7 +344,7 @@ class TestMWSFulfillmentInboundShipmentClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_gets_bill_of_lading
+  def test_getting_bill_of_lading
     operation = {
       'Action' => 'GetBillOfLading',
       'ShipmentId' => '1'
@@ -341,7 +357,7 @@ class TestMWSFulfillmentInboundShipmentClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_lists_inbound_shipments
+  def test_listing_inbound_shipments
     operation = {
       'Action' => 'ListInboundShipments',
       'ShipmentStatusList.member.1' => 'Foo',
@@ -358,7 +374,7 @@ class TestMWSFulfillmentInboundShipmentClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_lists_inbound_shipments_by_next_token
+  def test_listing_inbound_shipments_by_next_token
     operation = {
       'Action' => 'ListInboundShipmentsByNextToken',
       'NextToken' => '1'
@@ -371,7 +387,7 @@ class TestMWSFulfillmentInboundShipmentClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_lists_inbound_shipment_items
+  def test_listing_inbound_shipment_items
     operation = {
       'Action' => 'ListInboundShipmentItems'
     }
@@ -383,7 +399,7 @@ class TestMWSFulfillmentInboundShipmentClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_lists_inbound_shipment_items_by_next_token
+  def test_listing_inbound_shipment_items_by_next_token
     operation = {
       'Action' => 'ListInboundShipmentItemsByNextToken',
       'NextToken' => '1'
@@ -396,7 +412,7 @@ class TestMWSFulfillmentInboundShipmentClient < MiniTest::Test
     assert_equal operation, @client.operation
   end
 
-  def test_gets_service_status
+  def test_getting_service_status
     operation = {
       'Action' => 'GetServiceStatus'
     }