paper_trail 7.1.0 → 7.1.1

data/spec/models/car_spec.rb

@@ -1,13 +0,0 @@
-require "spec_helper"
-
-RSpec.describe Car, type: :model do
-  it { is_expected.to be_versioned }
-
-  describe "changeset", versioning: true do
-    it "has the expected keys (see issue 738)" do
-      car = Car.create!(name: "Alice")
-      car.update_attributes(name: "Bob")
-      assert_includes car.versions.last.changeset.keys, "name"
-    end
-  end
-end

data/spec/models/custom_primary_key_record_spec.rb

@@ -1,18 +0,0 @@
-require "spec_helper"
-
-RSpec.describe CustomPrimaryKeyRecord, type: :model do
-  it { is_expected.to be_versioned }
-
-  describe "#versions" do
-    it "returns instances of CustomPrimaryKeyRecordVersion", versioning: true do
-      custom_primary_key_record = described_class.create!
-      custom_primary_key_record.update_attributes!(name: "bob")
-      version = custom_primary_key_record.versions.last
-      expect(version).to be_a(CustomPrimaryKeyRecordVersion)
-      version_from_db = CustomPrimaryKeyRecordVersion.last
-      expect(version_from_db.reify).to be_a(CustomPrimaryKeyRecord)
-      custom_primary_key_record.destroy
-      expect(CustomPrimaryKeyRecordVersion.last.reify).to be_a(CustomPrimaryKeyRecord)
-    end
-  end
-end

data/spec/models/document_spec.rb

@@ -1,57 +0,0 @@
-require "spec_helper"
-
-RSpec.describe Document, type: :model, versioning: true do
-  describe "have_a_version_with matcher" do
-    it "works with custom versions association" do
-      document = Document.create!(name: "Foo")
-      document.update_attributes!(name: "Bar")
-      expect(document).to have_a_version_with(name: "Foo")
-    end
-  end
-
-  describe "have_a_version_with_changes matcher" do
-    it "works with custom versions association" do
-      document = Document.create!(name: "Foo")
-      document.update_attributes!(name: "Bar")
-      expect(document).to have_a_version_with_changes(name: "Bar")
-    end
-  end
-
-  describe "#paper_trail.next_version" do
-    it "returns the expected document" do
-      doc = Document.create
-      doc.update_attributes(name: "Doc 1")
-      reified = doc.paper_trail_versions.last.reify
-      expect(doc.name).to(eq(reified.paper_trail.next_version.name))
-    end
-  end
-
-  describe "#paper_trail.previous_version" do
-    it "returns the expected document" do
-      doc = Document.create
-      doc.update_attributes(name: "Doc 1")
-      doc.update_attributes(name: "Doc 2")
-      expect(doc.paper_trail_versions.length).to(eq(3))
-      expect(doc.paper_trail.previous_version.name).to(eq("Doc 1"))
-    end
-  end
-
-  describe "#paper_trail_versions" do
-    it "returns the expected version records" do
-      doc = Document.create
-      doc.update_attributes(name: "Doc 1")
-      expect(doc.paper_trail_versions.length).to(eq(2))
-      expect(doc.paper_trail_versions.map(&:event)).to(
-        match_array(%w[create update])
-      )
-    end
-  end
-
-  describe "#versions" do
-    it "does not respond to versions method" do
-      doc = Document.create
-      doc.update_attributes(name: "Doc 1")
-      expect(doc).not_to respond_to(:versions)
-    end
-  end
-end

data/spec/models/gadget_spec.rb

@@ -1,63 +0,0 @@
-require "spec_helper"
-
-RSpec.describe Gadget, type: :model do
-  it { is_expected.to be_versioned }
-
-  let(:gadget) { Gadget.create!(name: "Wrench", brand: "Acme") }
-
-  describe "updates", versioning: true do
-    it "generates a version for updates to `name` attribute" do
-      expect { gadget.update_attribute(:name, "Hammer") }.to(change { gadget.versions.size }.by(1))
-    end
-
-    it "ignores for updates to `brand` attribute" do
-      expect { gadget.update_attribute(:brand, "Stanley") }.not_to(change { gadget.versions.size })
-    end
-
-    it "still generates a version when only the `updated_at` attribute is updated" do
-      # Plus 1 second because MySQL lacks sub-second resolution
-      expect {
-        gadget.update_attribute(:updated_at, Time.now + 1)
-      }.to(change { gadget.versions.size }.by(1))
-    end
-  end
-
-  describe "#changed_notably?", versioning: true do
-    context "new record" do
-      it "returns true" do
-        g = Gadget.new(created_at: Time.now)
-        expect(g.paper_trail.changed_notably?).to eq(true)
-      end
-    end
-
-    context "persisted record without update timestamps" do
-      it "only acknowledges non-ignored attrs" do
-        subject = Gadget.create!(created_at: Time.now)
-        subject.name = "Wrench"
-        expect(subject.paper_trail.changed_notably?).to be true
-      end
-
-      it "does not acknowledge ignored attr (brand)" do
-        subject = Gadget.create!(created_at: Time.now)
-        subject.brand = "Acme"
-        expect(subject.paper_trail.changed_notably?).to be false
-      end
-    end
-
-    context "persisted record with update timestamps" do
-      it "only acknowledges non-ignored attrs" do
-        subject = Gadget.create!(created_at: Time.now)
-        subject.name = "Wrench"
-        subject.updated_at = Time.now
-        expect(subject.paper_trail.changed_notably?).to be true
-      end
-
-      it "does not acknowledge ignored attrs and timestamps only" do
-        subject = Gadget.create!(created_at: Time.now)
-        subject.brand = "Acme"
-        subject.updated_at = Time.now
-        expect(subject.paper_trail.changed_notably?).to be false
-      end
-    end
-  end
-end

data/spec/models/joined_version_spec.rb

@@ -1,41 +0,0 @@
-require "spec_helper"
-
-RSpec.describe JoinedVersion, type: :model, versioning: true do
-  let(:widget) { Widget.create!(name: FFaker::Name.name) }
-  let(:version) { JoinedVersion.first }
-
-  describe "default_scope" do
-    it { expect(JoinedVersion.default_scopes).not_to be_empty }
-  end
-
-  describe "VersionConcern::ClassMethods" do
-    before { widget } # persist a widget
-
-    describe "#subsequent" do
-      it "does not raise error when there is a default_scope that joins" do
-        JoinedVersion.subsequent(version).first
-      end
-    end
-
-    describe "#preceding" do
-      it "does not raise error when there is a default scope that joins" do
-        JoinedVersion.preceding(version).first
-      end
-    end
-
-    describe "#between" do
-      it "does not raise error when there is a default scope that joins" do
-        JoinedVersion.between(Time.now, 1.minute.from_now).first
-      end
-    end
-  end
-
-  describe "#index" do
-    it { is_expected.to respond_to(:index) }
-
-    it "does not raise error when there is a default scope that joins" do
-      widget # persist a widget
-      version.index
-    end
-  end
-end

data/spec/models/json_version_spec.rb

@@ -1,101 +0,0 @@
-require "spec_helper"
-
-# The `json_versions` table tests postgres' `json` data type. So, that
-# table is only created when testing against postgres and ActiveRecord >= 4.
-if JsonVersion.table_exists?
-  RSpec.describe JsonVersion, type: :model do
-    it "includes the VersionConcern module" do
-      expect(described_class).to include(PaperTrail::VersionConcern)
-    end
-
-    describe "Methods" do
-      describe "Class" do
-        describe "#where_object" do
-          it { expect(described_class).to respond_to(:where_object) }
-
-          it "escapes values" do
-            f = Fruit.create(name: "Bobby")
-            expect(
-              f.
-                versions.
-                where_object(name: "Robert'; DROP TABLE Students;--").
-                count
-            ).to eq(0)
-          end
-
-          context "invalid arguments" do
-            it "raises an error" do
-              expect { described_class.where_object(:foo) }.to raise_error(ArgumentError)
-              expect { described_class.where_object([]) }.to raise_error(ArgumentError)
-            end
-          end
-
-          context "valid arguments", versioning: true do
-            let(:fruit_names) { %w[apple orange lemon banana lime coconut strawberry blueberry] }
-            let(:fruit) { Fruit.new }
-            let(:name) { "pomegranate" }
-            let(:color) { FFaker::Color.name }
-
-            before do
-              fruit.update_attributes!(name: name)
-              fruit.update_attributes!(name: fruit_names.sample, color: color)
-              fruit.update_attributes!(name: fruit_names.sample, color: FFaker::Color.name)
-            end
-
-            it "locates versions according to their `object` contents" do
-              expect(described_class.where_object(name: name)).to eq([fruit.versions[1]])
-              expect(described_class.where_object(color: color)).to eq([fruit.versions[2]])
-            end
-          end
-        end
-
-        describe "#where_object_changes" do
-          it { expect(described_class).to respond_to(:where_object_changes) }
-
-          it "escapes values" do
-            f = Fruit.create(name: "Bobby")
-            expect(
-              f.
-                versions.
-                where_object_changes(name: "Robert'; DROP TABLE Students;--").
-                count
-            ).to eq(0)
-          end
-
-          context "invalid arguments" do
-            it "raises an error" do
-              expect { described_class.where_object_changes(:foo) }.to raise_error(ArgumentError)
-              expect { described_class.where_object_changes([]) }.to raise_error(ArgumentError)
-            end
-          end
-
-          context "valid arguments", versioning: true do
-            let(:color) { %w[red green] }
-            let(:fruit) { Fruit.create!(name: name[0]) }
-            let(:name) { %w[banana kiwi mango] }
-
-            before do
-              fruit.update_attributes!(name: name[1], color: color[0])
-              fruit.update_attributes!(name: name[2], color: color[1])
-            end
-
-            it "finds versions according to their `object_changes` contents" do
-              expect(
-                fruit.versions.where_object_changes(name: name[0])
-              ).to match_array(fruit.versions[0..1])
-              expect(
-                fruit.versions.where_object_changes(color: color[0])
-              ).to match_array(fruit.versions[1..2])
-            end
-
-            it "finds versions with multiple attributes changed" do
-              expect(
-                fruit.versions.where_object_changes(color: color[0], name: name[0])
-              ).to match_array([fruit.versions[1]])
-            end
-          end
-        end
-      end
-    end
-  end
-end

data/spec/models/kitchen/banana_spec.rb

@@ -1,14 +0,0 @@
-require "spec_helper"
-
-module Kitchen
-  RSpec.describe Banana, type: :model do
-    it { is_expected.to be_versioned }
-
-    describe "#versions" do
-      it "returns instances of Kitchen::BananaVersion", versioning: true do
-        banana = described_class.create!
-        expect(banana.versions.first).to be_a(Kitchen::BananaVersion)
-      end
-    end
-  end
-end

data/spec/models/legacy_widget_spec.rb

@@ -1,40 +0,0 @@
-require "spec_helper"
-
-RSpec.describe LegacyWidget, type: :model, versioning: true do
-  describe "#custom_version" do
-    it "knows which version it came from" do
-      widget = described_class.create(name: "foo", version: 2)
-      %w[bar baz].each { |name| widget.update_attributes(name: name) }
-      version = widget.versions.last
-      reified = version.reify
-      expect(reified.custom_version).to(eq(version))
-    end
-  end
-
-  describe "#previous_version" do
-    it "return its previous self" do
-      widget = described_class.create(name: "foo", version: 2)
-      %w[bar baz].each { |name| widget.update_attributes(name: name) }
-      version = widget.versions.last
-      reified = version.reify
-      expect(reified.paper_trail.previous_version).to(eq(reified.versions[-2].reify))
-    end
-  end
-
-  describe "#update_attributes" do
-    it "does not create a PT version record because the updated column is ignored" do
-      described_class.create.update_attributes(version: 1)
-      expect(PaperTrail::Version.count).to(eq(1))
-    end
-  end
-
-  describe "#version" do
-    it "is a normal attribute and has nothing to do with PT" do
-      widget = described_class.create(name: "foo", version: 2)
-      expect(widget.versions.size).to(eq(1))
-      expect(widget.version).to(eq(2))
-      widget.update_attributes(version: 3)
-      expect(widget.version).to(eq(3))
-    end
-  end
-end

data/spec/models/not_on_update_spec.rb

@@ -1,22 +0,0 @@
-require "spec_helper"
-
-RSpec.describe NotOnUpdate, type: :model do
-  describe "#touch_with_version", versioning: true do
-    let!(:record) { described_class.create! }
-
-    it "creates a version, regardless" do
-      expect { record.paper_trail.touch_with_version }.to change {
-        PaperTrail::Version.count
-      }.by(+1)
-    end
-
-    it "increments the `:updated_at` timestamp" do
-      before = record.updated_at
-      # Travel 1 second because MySQL lacks sub-second resolution
-      Timecop.travel(1) do
-        record.paper_trail.touch_with_version
-      end
-      expect(record.updated_at).to be > before
-    end
-  end
-end

data/spec/models/on/create_spec.rb

@@ -1,27 +0,0 @@
-require "spec_helper"
-require_dependency "on/create"
-
-module On
-  RSpec.describe Create, type: :model, versioning: true do
-    describe "#versions" do
-      it "only have a version for the create event" do
-        record = described_class.create(name: "Alice")
-        record.update_attributes(name: "blah")
-        record.destroy
-        expect(record.versions.length).to(eq(1))
-        expect(record.versions.last.event).to(eq("create"))
-      end
-    end
-
-    context "#paper_trail_event" do
-      it "rembembers the custom event name" do
-        record = described_class.new
-        record.paper_trail_event = "banana"
-        record.update_attributes(name: "blah")
-        record.destroy
-        expect(record.versions.length).to(eq(1))
-        expect(record.versions.last.event).to(eq("banana"))
-      end
-    end
-  end
-end

data/spec/models/on/destroy_spec.rb

@@ -1,27 +0,0 @@
-require "spec_helper"
-require_dependency "on/destroy"
-
-module On
-  RSpec.describe Destroy, type: :model, versioning: true do
-    describe "#versions" do
-      it "only creates one version record, for the destroy event" do
-        record = described_class.create(name: "Alice")
-        record.update_attributes(name: "blah")
-        record.destroy
-        expect(record.versions.length).to(eq(1))
-        expect(record.versions.last.event).to(eq("destroy"))
-      end
-    end
-
-    context "#paper_trail_event" do
-      it "rembembers the custom event name" do
-        record = described_class.create(name: "Alice")
-        record.paper_trail_event = "banana"
-        record.update_attributes(name: "blah")
-        record.destroy
-        expect(record.versions.length).to(eq(1))
-        expect(record.versions.last.event).to(eq("banana"))
-      end
-    end
-  end
-end

data/spec/models/on/empty_array_spec.rb

@@ -1,30 +0,0 @@
-require "spec_helper"
-require_dependency "on/empty_array"
-
-module On
-  RSpec.describe EmptyArray, type: :model, versioning: true do
-    describe "#create" do
-      it "does not create any version records" do
-        record = described_class.create(name: "Alice")
-        expect(record.versions.length).to(eq(0))
-      end
-    end
-
-    describe "#touch_with_version" do
-      it "creates a version record" do
-        record = described_class.create(name: "Alice")
-        record.paper_trail.touch_with_version
-        expect(record.versions.length).to(eq(1))
-        expect(record.versions.first.event).to(eq("update"))
-      end
-    end
-
-    describe "#update_attributes" do
-      it "does not create any version records" do
-        record = described_class.create(name: "Alice")
-        record.update_attributes(name: "blah")
-        expect(record.versions.length).to(eq(0))
-      end
-    end
-  end
-end