paper_trail 7.1.0 → 7.1.1

data/spec/generators/install_generator_spec.rb

@@ -1,88 +0,0 @@
-require "spec_helper"
-require "generator_spec/test_case"
-require File.expand_path("../../../lib/generators/paper_trail/install_generator", __FILE__)
-
-RSpec.describe PaperTrail::InstallGenerator, type: :generator do
-  include GeneratorSpec::TestCase
-  destination File.expand_path("../tmp", __FILE__)
-
-  after(:all) { prepare_destination } # cleanup the tmp directory
-
-  describe "no options" do
-    before(:all) do
-      prepare_destination
-      run_generator
-    end
-
-    it "generates a migration for creating the 'versions' table" do
-      expected_parent_class = lambda {
-        old_school = "ActiveRecord::Migration"
-        ar_version = ActiveRecord::VERSION
-        if ar_version::MAJOR >= 5
-          format("%s[%d.%d]", old_school, ar_version::MAJOR, ar_version::MINOR)
-        else
-          old_school
-        end
-      }.call
-      expected_create_table_options = lambda {
-        if described_class::MYSQL_ADAPTERS.include?(ActiveRecord::Base.connection.class.name)
-          ', { options: "ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_general_ci" }'
-        else
-          ""
-        end
-      }.call
-      expect(destination_root).to(
-        have_structure {
-          directory("db") {
-            directory("migrate") {
-              migration("create_versions") {
-                contains("class CreateVersions < " + expected_parent_class)
-                contains "def change"
-                contains "create_table :versions#{expected_create_table_options}"
-              }
-            }
-          }
-        }
-      )
-    end
-  end
-
-  describe "`--with-changes` option set to `true`" do
-    before(:all) do
-      prepare_destination
-      run_generator %w[--with-changes]
-    end
-
-    it "generates a migration for creating the 'versions' table" do
-      expect(destination_root).to(
-        have_structure {
-          directory("db") {
-            directory("migrate") {
-              migration("create_versions") {
-                contains "class CreateVersions"
-                contains "def change"
-                contains "create_table :versions"
-              }
-            }
-          }
-        }
-      )
-    end
-
-    it "generates a migration for adding the 'object_changes' column to the 'versions' table" do
-      expect(destination_root).to(
-        have_structure {
-          directory("db") {
-            directory("migrate") {
-              migration("add_object_changes_to_versions") {
-                contains "class AddObjectChangesToVersions"
-                contains "def change"
-                contains "add_column :versions, :object_changes, :text"
-              }
-            }
-          }
-        }
-      )
-    end
-  end
-end

data/spec/models/animal_spec.rb

@@ -1,61 +0,0 @@
-require "spec_helper"
-
-RSpec.describe Animal, type: :model, versioning: true do
-  it "baseline test setup" do
-    expect(Animal.new).to be_versioned
-    expect(Animal.inheritance_column).to eq("species")
-  end
-
-  it "works with custom STI inheritance column" do
-    animal = Animal.create(name: "Animal")
-    animal.update_attributes(name: "Animal from the Muppets")
-    animal.update_attributes(name: "Animal Muppet")
-    animal.destroy
-    dog = Dog.create(name: "Snoopy")
-    dog.update_attributes(name: "Scooby")
-    dog.update_attributes(name: "Scooby Doo")
-    dog.destroy
-    cat = Cat.create(name: "Garfield")
-    cat.update_attributes(name: "Garfield (I hate Mondays)")
-    cat.update_attributes(name: "Garfield The Cat")
-    cat.destroy
-    expect(PaperTrail::Version.count).to(eq(12))
-    expect(animal.versions.count).to(eq(4))
-    expect(animal.versions.first.reify).to(be_nil)
-    animal.versions[(1..-1)].each do |v|
-      expect(v.reify.class.name).to(eq("Animal"))
-    end
-    dog_versions = PaperTrail::Version.where(item_id: dog.id).order(:created_at)
-    expect(dog_versions.count).to(eq(4))
-    expect(dog_versions.first.reify).to(be_nil)
-    expect(dog_versions.map { |v| v.reify.class.name }).to eq(%w[NilClass Dog Dog Dog])
-    cat_versions = PaperTrail::Version.where(item_id: cat.id).order(:created_at)
-    expect(cat_versions.count).to(eq(4))
-    expect(cat_versions.first.reify).to(be_nil)
-    expect(cat_versions.map { |v| v.reify.class.name }).to eq(%w[NilClass Cat Cat Cat])
-  end
-
-  it "allows the inheritance_column (species) to be updated" do
-    cat = Cat.create!(name: "Leo")
-    cat.update_attributes(name: "Spike", species: "Dog")
-    dog = Animal.find(cat.id)
-    expect(dog).to be_instance_of(Dog)
-  end
-
-  context "with callback-methods" do
-    context "when only has_paper_trail set in super class" do
-      let(:callback_cat) { Cat.create(name: "Markus") }
-
-      it "trails all events" do
-        callback_cat.update_attributes(name: "Billie")
-        callback_cat.destroy
-        expect(callback_cat.versions.collect(&:event)).to eq %w[create update destroy]
-      end
-
-      it "does not break reify" do
-        callback_cat.destroy
-        expect { callback_cat.versions.last.reify }.not_to raise_error
-      end
-    end
-  end
-end

data/spec/models/article_spec.rb

@@ -1,186 +0,0 @@
-require "spec_helper"
-
-RSpec.describe Article, type: :model, versioning: true do
-  describe ".create" do
-    it "also creates a version record" do
-      expect { described_class.create }.to(
-        change { PaperTrail::Version.count }.by(+1)
-      )
-    end
-  end
-
-  context "which updates an ignored column" do
-    it "not change the number of versions" do
-      article = described_class.create
-      article.update_attributes(title: "My first title")
-      expect(PaperTrail::Version.count).to(eq(1))
-    end
-  end
-
-  context "which updates an ignored column with truly Proc" do
-    it "not change the number of versions" do
-      article = described_class.create
-      article.update_attributes(abstract: "ignore abstract")
-      expect(PaperTrail::Version.count).to(eq(1))
-    end
-  end
-
-  context "which updates an ignored column with falsy Proc" do
-    it "change the number of versions" do
-      article = described_class.create
-      article.update_attributes(abstract: "do not ignore abstract!")
-      expect(PaperTrail::Version.count).to(eq(2))
-    end
-  end
-
-  context "which updates an ignored column, ignored with truly Proc and a selected column" do
-    it "change the number of versions" do
-      article = described_class.create
-      article.update_attributes(
-        title: "My first title",
-        content: "Some text here.",
-        abstract: "ignore abstract"
-      )
-      expect(PaperTrail::Version.count).to(eq(2))
-      expect(article.versions.size).to(eq(2))
-    end
-
-    it "have stored only non-ignored attributes" do
-      article = described_class.create
-      article.update_attributes(
-        title: "My first title",
-        content: "Some text here.",
-        abstract: "ignore abstract"
-      )
-      expected = { "content" => [nil, "Some text here."] }
-      expect(article.versions.last.changeset).to(eq(expected))
-    end
-  end
-
-  context "which updates an ignored column, ignored with falsy Proc and a selected column" do
-    it "change the number of versions" do
-      article = described_class.create
-      article.update_attributes(
-        title: "My first title",
-        content: "Some text here.",
-        abstract: "do not ignore abstract"
-      )
-      expect(PaperTrail::Version.count).to(eq(2))
-      expect(article.versions.size).to(eq(2))
-    end
-
-    it "stores only non-ignored attributes" do
-      article = described_class.create
-      article.update_attributes(
-        title: "My first title",
-        content: "Some text here.",
-        abstract: "do not ignore abstract"
-      )
-      expected = {
-        "content" => [nil, "Some text here."],
-        "abstract" => [nil, "do not ignore abstract"]
-      }
-      expect(article.versions.last.changeset).to(eq(expected))
-    end
-  end
-
-  context "which updates a selected column" do
-    it "change the number of versions" do
-      article = described_class.create
-      article.update_attributes(content: "Some text here.")
-      expect(PaperTrail::Version.count).to(eq(2))
-      expect(article.versions.size).to(eq(2))
-    end
-  end
-
-  context "which updates a non-ignored and non-selected column" do
-    it "not change the number of versions" do
-      article = described_class.create
-      article.update_attributes(abstract: "Other abstract")
-      expect(PaperTrail::Version.count).to(eq(1))
-    end
-  end
-
-  context "which updates a skipped column" do
-    it "not change the number of versions" do
-      article = described_class.create
-      article.update_attributes(file_upload: "Your data goes here")
-      expect(PaperTrail::Version.count).to(eq(1))
-    end
-  end
-
-  context "which updates a skipped column and a selected column" do
-    it "change the number of versions" do
-      article = described_class.create
-      article.update_attributes(
-        file_upload: "Your data goes here",
-        content: "Some text here."
-      )
-      expect(PaperTrail::Version.count).to(eq(2))
-    end
-
-    it "show the new version in the model's `versions` association" do
-      article = described_class.create
-      article.update_attributes(
-        file_upload: "Your data goes here",
-        content: "Some text here."
-      )
-      expect(article.versions.size).to(eq(2))
-    end
-
-    it "have stored only non-skipped attributes" do
-      article = described_class.create
-      article.update_attributes(
-        file_upload: "Your data goes here",
-        content: "Some text here."
-      )
-      expect(
-        article.versions.last.changeset
-      ).to(eq("content" => [nil, "Some text here."]))
-    end
-
-    context "and when updated again" do
-      it "have removed the skipped attributes when saving the previous version" do
-        article = described_class.create
-        article.update_attributes(
-          file_upload: "Your data goes here",
-          content: "Some text here."
-        )
-        article.update_attributes(
-          file_upload: "More data goes here",
-          content: "More text here."
-        )
-        old_article = article.versions.last
-        expect(
-          PaperTrail.serializer.load(old_article.object)["file_upload"]
-        ).to(be_nil)
-      end
-
-      it "have kept the non-skipped attributes in the previous version" do
-        article = described_class.create
-        article.update_attributes(
-          file_upload: "Your data goes here",
-          content: "Some text here."
-        )
-        article.update_attributes(
-          file_upload: "More data goes here",
-          content: "More text here."
-        )
-        old_article = article.versions.last
-        expect(
-          PaperTrail.serializer.load(old_article.object)["content"]
-        ).to(eq("Some text here."))
-      end
-    end
-  end
-
-  context "#destroy" do
-    it "creates a version record" do
-      article = described_class.create
-      article.destroy
-      expect(PaperTrail::Version.count).to(eq(2))
-      expect(article.versions.size).to(eq(2))
-      expect(article.versions.map(&:event)).to(match_array(%w[create destroy]))
-    end
-  end
-end

data/spec/models/boolit_spec.rb

@@ -1,41 +0,0 @@
-require "spec_helper"
-require "support/custom_json_serializer"
-
-RSpec.describe Boolit, type: :model, versioning: true do
-  subject { Boolit.create! }
-
-  before { subject.update_attributes!(name: FFaker::Name.name) }
-
-  it "has two versions" do
-    expect(subject.versions.size).to eq(2)
-  end
-
-  it "can be reified and persisted" do
-    expect { subject.versions.last.reify.save! }.not_to raise_error
-  end
-
-  context "Instance falls out of default scope" do
-    before { subject.update_attributes!(scoped: false) }
-
-    it "is NOT scoped" do
-      expect(Boolit.first).to be_nil
-    end
-
-    it "still can be reified and persisted" do
-      expect { subject.paper_trail.previous_version.save! }.not_to raise_error
-    end
-
-    context "with `nil` attributes on the live instance" do
-      before do
-        PaperTrail.serializer = CustomJsonSerializer
-        subject.update_attributes!(name: nil)
-        subject.update_attributes!(name: FFaker::Name.name)
-      end
-      after { PaperTrail.serializer = PaperTrail::Serializers::YAML }
-
-      it "does not overwrite that attribute during the reification process" do
-        expect(subject.paper_trail.previous_version.name).to be_nil
-      end
-    end
-  end
-end

data/spec/models/callback_modifier_spec.rb

@@ -1,92 +0,0 @@
-require "spec_helper"
-
-RSpec.describe CallbackModifier, type: :model, versioning: true do
-  describe "paper_trail_on_destroy" do
-    it "adds :destroy to paper_trail_options[:on]" do
-      modifier = NoArgDestroyModifier.create!(some_content: FFaker::Lorem.sentence)
-      expect(modifier.paper_trail_options[:on]).to eq([:destroy])
-    end
-
-    context "when :before" do
-      it "creates the version before destroy" do
-        modifier = BeforeDestroyModifier.create!(some_content: FFaker::Lorem.sentence)
-        modifier.test_destroy
-        expect(modifier.versions.last.reify).not_to be_flagged_deleted
-      end
-    end
-
-    context "when :after" do
-      it "creates the version after destroy" do
-        modifier = AfterDestroyModifier.create!(some_content: FFaker::Lorem.sentence)
-        modifier.test_destroy
-        expect(modifier.versions.last.reify).to be_flagged_deleted
-      end
-    end
-
-    context "when no argument" do
-      it "defaults to before destroy" do
-        modifier = NoArgDestroyModifier.create!(some_content: FFaker::Lorem.sentence)
-        modifier.test_destroy
-        expect(modifier.versions.last.reify).not_to be_flagged_deleted
-      end
-    end
-  end
-
-  describe "paper_trail_on_update" do
-    it "adds :update to paper_trail_options[:on]" do
-      modifier = UpdateModifier.create!(some_content: FFaker::Lorem.sentence)
-      expect(modifier.paper_trail_options[:on]).to eq [:update]
-    end
-
-    it "creates a version" do
-      modifier = UpdateModifier.create!(some_content: FFaker::Lorem.sentence)
-      modifier.update_attributes! some_content: "modified"
-      expect(modifier.versions.last.event).to eq "update"
-    end
-  end
-
-  describe "paper_trail_on_create" do
-    it "adds :create to paper_trail_options[:on]" do
-      modifier = CreateModifier.create!(some_content: FFaker::Lorem.sentence)
-      expect(modifier.paper_trail_options[:on]).to eq [:create]
-    end
-
-    it "creates a version" do
-      modifier = CreateModifier.create!(some_content: FFaker::Lorem.sentence)
-      expect(modifier.versions.last.event).to eq "create"
-    end
-  end
-
-  context "when no callback-method used" do
-    it "sets paper_trail_options[:on] to [:create, :update, :destroy]" do
-      modifier = DefaultModifier.create!(some_content: FFaker::Lorem.sentence)
-      expect(modifier.paper_trail_options[:on]).to eq %i[create update destroy]
-    end
-
-    it "tracks destroy" do
-      modifier = DefaultModifier.create!(some_content: FFaker::Lorem.sentence)
-      modifier.destroy
-      expect(modifier.versions.last.event).to eq "destroy"
-    end
-
-    it "tracks update" do
-      modifier = DefaultModifier.create!(some_content: FFaker::Lorem.sentence)
-      modifier.update_attributes! some_content: "modified"
-      expect(modifier.versions.last.event).to eq "update"
-    end
-
-    it "tracks create" do
-      modifier = DefaultModifier.create!(some_content: FFaker::Lorem.sentence)
-      expect(modifier.versions.last.event).to eq "create"
-    end
-  end
-
-  context "when only one callback-method" do
-    it "does only track the corresponding event" do
-      modifier = CreateModifier.create!(some_content: FFaker::Lorem.sentence)
-      modifier.update_attributes!(some_content: "modified")
-      modifier.test_destroy
-      expect(modifier.versions.collect(&:event)).to eq ["create"]
-    end
-  end
-end