packaging 0.99.0

data/spec/lib/packaging/util/misc_spec.rb

@@ -0,0 +1,31 @@
+# -*- ruby -*-
+require 'spec_helper'
+
+describe 'Pkg::Util::Misc' do
+  context "#search_and_replace" do
+    let(:orig_string) { "#!/bin/bash\necho '__REPO_NAME__'" }
+    let(:updated_string) { "#!/bin/bash\necho 'abcdefg'" }
+    let(:good_replacements) do
+      { __REPO_NAME__: Pkg::Paths.repo_name }
+    end
+    let(:warn_replacements) do
+      { __REPO_NAME__: nil }
+    end
+
+    it 'replaces the token with the Pkg::Config variable' do
+      Pkg::Config.config_from_hash({:project => "foo", :repo_name => 'abcdefg'})
+      Pkg::Util::Misc.search_and_replace(orig_string, good_replacements).should eq(updated_string)
+    end
+
+    it 'does no replacement if the Pkg::Config variable is not set' do
+      Pkg::Config.config_from_hash({:project => 'foo',})
+      Pkg::Util::Misc.search_and_replace(orig_string, good_replacements).should eq(orig_string)
+    end
+
+    it 'warns and continues if the Pkg::Config variable is unknown to packaging' do
+      Pkg::Config.config_from_hash({:project => 'foo',})
+      Pkg::Util::Misc.should_receive(:warn).with("replacement value for '#{warn_replacements.keys.first}' probably shouldn't be nil")
+      Pkg::Util::Misc.search_and_replace(orig_string, warn_replacements).should eq(orig_string)
+    end
+  end
+end

data/spec/lib/packaging/util/net_spec.rb

@@ -0,0 +1,239 @@
+require 'spec_helper'
+require 'socket'
+require 'open3'
+
+describe "Pkg::Util::Net" do
+  let(:target)     { "/tmp/placething" }
+  let(:target_uri) { "http://google.com" }
+  let(:content)    { "stuff" }
+  let(:rsync)      { "/bin/rsync" }
+  let(:ssh)        { "/usr/local/bin/ssh" }
+  let(:s3cmd)      { "/usr/local/bin/s3cmd" }
+
+  describe "#fetch_uri" do
+    context "given a target directory" do
+      it "does nothing if the directory isn't writable" do
+        File.stub(:writable?).with(File.dirname(target)) { false }
+        File.should_receive(:open).never
+        Pkg::Util::Net.fetch_uri(target_uri, target)
+      end
+
+      it "writes the content of the uri to a file if directory is writable" do
+        File.should_receive(:writable?).once.with(File.dirname(target)) { true }
+        File.should_receive(:open).once.with(target, 'w')
+        Pkg::Util::Net.fetch_uri(target_uri, target)
+      end
+    end
+  end
+
+  describe "hostname utils" do
+
+    describe "hostname" do
+      it "should return the hostname of the current host" do
+        Socket.stub(:gethostname) { "foo" }
+        Pkg::Util::Net.hostname.should eq("foo")
+      end
+    end
+
+    describe "check_host" do
+      context "with required :true" do
+        it "should raise an exception if the passed host does not match the current host" do
+          Socket.stub(:gethostname) { "foo" }
+          Pkg::Util::Net.should_receive(:check_host).and_raise(RuntimeError)
+          expect{ Pkg::Util::Net.check_host("bar", :required => true) }.to raise_error(RuntimeError)
+        end
+      end
+
+      context "with required :false" do
+        it "should return nil if the passed host does not match the current host" do
+          Socket.stub(:gethostname) { "foo" }
+          Pkg::Util::Net.check_host("bar", :required => false).should be_nil
+        end
+      end
+    end
+  end
+
+  describe "remote_ssh_cmd" do
+    it "should fail if ssh is not present" do
+      Pkg::Util::Tool.stub(:find_tool).with("ssh") { fail }
+      Pkg::Util::Tool.should_receive(:check_tool).with("ssh").and_raise(RuntimeError)
+      expect{ Pkg::Util::Net.remote_ssh_cmd("foo", "bar") }.to raise_error(RuntimeError)
+    end
+
+    it "should be able to not fail fast" do
+        Pkg::Util::Tool.should_receive(:check_tool).with("ssh").and_return(ssh)
+        Kernel.should_receive(:system).with("#{ssh}  -t foo 'bar'")
+        Pkg::Util::Execution.should_receive(:success?).and_return(true)
+        Pkg::Util::Net.remote_ssh_cmd("foo", "bar", false, '', false)
+     end
+
+    context "without output captured" do
+      it "should execute a command :foo on a host :bar using Kernel" do
+        Pkg::Util::Tool.should_receive(:check_tool).with("ssh").and_return(ssh)
+        Kernel.should_receive(:system).with("#{ssh}  -t foo 'set -e; bar'")
+        Pkg::Util::Execution.should_receive(:success?).and_return(true)
+        Pkg::Util::Net.remote_ssh_cmd("foo", "bar")
+      end
+
+      it "should escape single quotes in the command" do
+        Pkg::Util::Tool.should_receive(:check_tool).with("ssh").and_return(ssh)
+        Kernel.should_receive(:system).with("#{ssh}  -t foo 'set -e; b'\\''ar'")
+        Pkg::Util::Execution.should_receive(:success?).and_return(true)
+        Pkg::Util::Net.remote_ssh_cmd("foo", "b'ar")
+      end
+
+      it "should raise an error if ssh fails" do
+        Pkg::Util::Tool.should_receive(:check_tool).with("ssh").and_return(ssh)
+        Kernel.should_receive(:system).with("#{ssh}  -t foo 'set -e; bar'")
+        Pkg::Util::Execution.should_receive(:success?).and_return(false)
+        expect{ Pkg::Util::Net.remote_ssh_cmd("foo", "bar") }.to raise_error(RuntimeError, /Remote ssh command failed./)
+      end
+    end
+
+    context "with output captured" do
+      it "should execute a command :foo on a host :bar using Pkg::Util::Execution.capture3" do
+        Pkg::Util::Tool.should_receive(:check_tool).with("ssh").and_return(ssh)
+        Pkg::Util::Execution.should_receive(:capture3).with("#{ssh}  -t foo 'set -e; bar'")
+        Pkg::Util::Execution.should_receive(:success?).and_return(true)
+        Pkg::Util::Net.remote_ssh_cmd("foo", "bar", true)
+      end
+
+      it "should escape single quotes in the command" do
+        Pkg::Util::Tool.should_receive(:check_tool).with("ssh").and_return(ssh)
+        Pkg::Util::Execution.should_receive(:capture3).with("#{ssh}  -t foo 'set -e; b'\\''ar'")
+        Pkg::Util::Execution.should_receive(:success?).and_return(true)
+        Pkg::Util::Net.remote_ssh_cmd("foo", "b'ar", true)
+      end
+
+      it "should raise an error if ssh fails" do
+        Pkg::Util::Tool.should_receive(:check_tool).with("ssh").and_return(ssh)
+        Pkg::Util::Execution.should_receive(:capture3).with("#{ssh}  -t foo 'set -e; bar'")
+        Pkg::Util::Execution.should_receive(:success?).and_return(false)
+        expect{ Pkg::Util::Net.remote_ssh_cmd("foo", "bar", true) }.to raise_error(RuntimeError, /Remote ssh command failed./)
+      end
+    end
+  end
+
+  describe "#rsync_to" do
+    defaults = "--recursive --hard-links --links --verbose --omit-dir-times --no-perms --no-owner --no-group"
+    it "should fail if rsync is not present" do
+      Pkg::Util::Tool.stub(:find_tool).with("rsync") { fail }
+      Pkg::Util::Tool.should_receive(:check_tool).with("rsync").and_raise(RuntimeError)
+      expect{ Pkg::Util::Net.rsync_to("foo", "bar", "boo") }.to raise_error(RuntimeError)
+    end
+
+    it "should rsync 'thing' to 'foo@bar:/home/foo' with flags '#{defaults} --ignore-existing'" do
+      Pkg::Util::Tool.should_receive(:check_tool).with("rsync").and_return(rsync)
+      Pkg::Util::Execution.should_receive(:capture3).with("#{rsync} #{defaults} --ignore-existing thing foo@bar:/home/foo", true)
+      Pkg::Util::Net.rsync_to("thing", "foo@bar", "/home/foo")
+    end
+
+    it "rsyncs 'thing' to 'foo@bar:/home/foo' with flags that don't include --ignore-existing" do
+      Pkg::Util::Tool.should_receive(:check_tool).with("rsync").and_return(rsync)
+      Pkg::Util::Execution.should_receive(:capture3).with("#{rsync} #{defaults} thing foo@bar:/home/foo", true)
+      Pkg::Util::Net.rsync_to("thing", "foo@bar", "/home/foo", extra_flags: [])
+    end
+
+    it "rsyncs 'thing' to 'foo@bar:/home/foo' with flags that don't include arbitrary flags" do
+      Pkg::Util::Tool.should_receive(:check_tool).with("rsync").and_return(rsync)
+      Pkg::Util::Execution.should_receive(:capture3).with("#{rsync} #{defaults} --foo-bar --and-another-flag thing foo@bar:/home/foo", true)
+      Pkg::Util::Net.rsync_to("thing", "foo@bar", "/home/foo", extra_flags: ["--foo-bar", "--and-another-flag"])
+    end
+  end
+
+  describe "#s3sync_to" do
+    it "should fail if s3cmd is not present" do
+      Pkg::Util::Tool.should_receive(:find_tool).with('s3cmd', :required => true).and_raise(RuntimeError)
+      Pkg::Util::Execution.should_not_receive(:capture3).with("#{s3cmd} sync  'foo' s3://bar/boo/")
+      expect{ Pkg::Util::Net.s3sync_to("foo", "bar", "boo") }.to raise_error(RuntimeError)
+    end
+
+    it "should fail if ~/.s3cfg is not present" do
+      Pkg::Util::Tool.should_receive(:check_tool).with("s3cmd").and_return(s3cmd)
+      Pkg::Util::File.should_receive(:file_exists?).with(File.join(ENV['HOME'], '.s3cfg')).and_return(false)
+      expect{ Pkg::Util::Net.s3sync_to("foo", "bar", "boo") }.to raise_error(RuntimeError, /does not exist/)
+    end
+
+    it "should s3 sync 'thing' to 's3://foo@bar/home/foo/' with no flags" do
+      Pkg::Util::Tool.should_receive(:check_tool).with("s3cmd").and_return(s3cmd)
+      Pkg::Util::File.should_receive(:file_exists?).with(File.join(ENV['HOME'], '.s3cfg')).and_return(true)
+      Pkg::Util::Execution.should_receive(:capture3).with("#{s3cmd} sync  'thing' s3://foo@bar/home/foo/")
+      Pkg::Util::Net.s3sync_to("thing", "foo@bar", "home/foo")
+    end
+
+    it "should s3 sync 'thing' to 's3://foo@bar/home/foo/' with --delete-removed and --acl-public" do
+      Pkg::Util::Tool.should_receive(:check_tool).with("s3cmd").and_return(s3cmd)
+      Pkg::Util::File.should_receive(:file_exists?).with(File.join(ENV['HOME'], '.s3cfg')).and_return(true)
+      Pkg::Util::Execution.should_receive(:capture3).with("#{s3cmd} sync --delete-removed --acl-public 'thing' s3://foo@bar/home/foo/")
+      Pkg::Util::Net.s3sync_to("thing", "foo@bar", "home/foo", ["--delete-removed", "--acl-public"])
+    end
+  end
+
+  describe "#rsync_from" do
+    defaults = "--recursive --hard-links --links --verbose --omit-dir-times --no-perms --no-owner --no-group"
+    it "should fail if rsync is not present" do
+      Pkg::Util::Tool.stub(:find_tool).with("rsync") { fail }
+      Pkg::Util::Tool.should_receive(:check_tool).with("rsync").and_raise(RuntimeError)
+      expect{ Pkg::Util::Net.rsync_from("foo", "bar", "boo") }.to raise_error(RuntimeError)
+    end
+
+    it "should not include the flags '--ignore-existing' by default" do
+      Pkg::Util::Tool.should_receive(:check_tool).with("rsync").and_return(rsync)
+      Pkg::Util::Execution.should_receive(:capture3).with("#{rsync} #{defaults} foo@bar:thing /home/foo", true)
+      Pkg::Util::Net.rsync_from("thing", "foo@bar", "/home/foo")
+    end
+
+    it "should rsync 'thing' from 'foo@bar' to '/home/foo' with flags '#{defaults}'" do
+      Pkg::Util::Tool.should_receive(:check_tool).with("rsync").and_return(rsync)
+      Pkg::Util::Execution.should_receive(:capture3).with("#{rsync} #{defaults} foo@bar:thing /home/foo", true)
+      Pkg::Util::Net.rsync_from("thing", "foo@bar", "/home/foo")
+    end
+
+    it "rsyncs 'thing' from 'foo@bar:/home/foo' with flags that don't include arbitrary flags" do
+      Pkg::Util::Tool.should_receive(:check_tool).with("rsync").and_return(rsync)
+      Pkg::Util::Execution.should_receive(:capture3).with("#{rsync} #{defaults} --foo-bar --and-another-flag foo@bar:thing /home/foo", true)
+      Pkg::Util::Net.rsync_from("thing", "foo@bar", "/home/foo", extra_flags: ["--foo-bar", "--and-another-flag"])
+    end
+  end
+
+  describe "#curl_form_data" do
+    let(:curl) {"/bin/curl"}
+    let(:form_data) {["name=FOO"]}
+    let(:options) { {:quiet => true} }
+
+    it "should return false on failure" do
+      Pkg::Util::Tool.should_receive(:check_tool).with("curl").and_return(curl)
+      Pkg::Util::Execution.should_receive(:capture3).with("#{curl} -i '#{target_uri}'").and_return(['stdout', 'stderr', 1])
+      Pkg::Util::Net.curl_form_data(target_uri).should eq(['stdout', 1])
+    end
+
+
+    it "should curl with just the uri" do
+      Pkg::Util::Tool.should_receive(:check_tool).with("curl").and_return(curl)
+      Pkg::Util::Execution.should_receive(:capture3).with("#{curl} -i '#{target_uri}'")
+      Pkg::Util::Net.curl_form_data(target_uri)
+    end
+
+    it "should curl with the form data and uri" do
+      Pkg::Util::Tool.should_receive(:check_tool).with("curl").and_return(curl)
+      Pkg::Util::Execution.should_receive(:capture3).with("#{curl} -i #{form_data[0]} '#{target_uri}'")
+      Pkg::Util::Net.curl_form_data(target_uri, form_data)
+    end
+
+    it "should curl with form data, uri, and be quiet" do
+      Pkg::Util::Tool.should_receive(:check_tool).with("curl").and_return(curl)
+      Pkg::Util::Execution.should_receive(:capture3).with("#{curl} -i #{form_data[0]} '#{target_uri}'").and_return(['stdout', 'stderr', 0])
+      Pkg::Util::Net.curl_form_data(target_uri, form_data, options).should eq(['', 0])
+    end
+
+  end
+
+  describe "#print_url_info" do
+    it "should output correct formatting" do
+      Pkg::Util::Net.should_receive(:puts).with("\n////////////////////////////////////////////////////////////////////////////////\n\n
+  Build submitted. To view your build progress, go to\n#{target_uri}\n\n
+////////////////////////////////////////////////////////////////////////////////\n\n")
+      Pkg::Util::Net.print_url_info(target_uri)
+    end
+  end
+end

data/spec/lib/packaging/util/os_spec.rb

@@ -0,0 +1,31 @@
+require 'spec_helper'
+
+describe Pkg::Util::OS do
+  def as_host_os(platform, &block)
+    old = RbConfig::CONFIG['host_os']
+    RbConfig::CONFIG['host_os'] = platform
+    begin
+      yield
+    ensure
+      RbConfig::CONFIG['host_os'] = old
+    end
+  end
+
+  it "detects windows when host_os contains mingw" do
+    as_host_os('mingw32') do
+      expect(Pkg::Util::OS).to be_windows
+    end
+  end
+
+  it "detects windows when host_os contains mswin60" do
+    as_host_os('mswin60') do
+      expect(Pkg::Util::OS).to be_windows
+    end
+  end
+
+  it "does not detect windows when host_os contains darwin" do
+    as_host_os('darwin12.5.0') do
+      expect(Pkg::Util::OS).to_not be_windows
+    end
+  end
+end

data/spec/lib/packaging/util/rake_utils_spec.rb

@@ -0,0 +1,70 @@
+require 'spec_helper'
+
+describe "Pkg::Util::RakeUtils" do
+  let(:foo_defined?) { Rake::Task.task_defined?(:foo) }
+  let(:bar_defined?) { Rake::Task.task_defined?(:bar) }
+  let(:define_foo)   { body = proc{}; Rake::Task.define_task(:foo, &body) }
+  let(:define_bar)   { body = proc{}; Rake::Task.define_task(:bar, &body) }
+
+  before(:each) do
+    if foo_defined?
+      Rake::Task[:foo].clear_prerequisites
+    end
+  end
+
+  describe "#task_defined?" do
+    context "given a Rake::Task task name" do
+      it "should return true if the task exists" do
+        Rake::Task.stub(:task_defined?).with(:foo) {true}
+        expect(Pkg::Util::RakeUtils.task_defined?(:foo)).to be_true
+      end
+      it "should return false if the task does not exist" do
+        Rake::Task.stub(:task_defined?).with(:foo) {false}
+        expect(Pkg::Util::RakeUtils.task_defined?(:foo)).to be_false
+      end
+    end
+  end
+
+  describe "#get_task" do
+    it "should return a task object for a named task" do
+      foo = nil
+      if !foo_defined?
+        foo = define_foo
+      else
+        foo = Rake::Task[:foo]
+      end
+      task = Pkg::Util::RakeUtils.get_task(:foo)
+      expect(task).to be_a(Rake::Task)
+      expect(task).to be(foo)
+    end
+  end
+
+  describe "#add_dependency" do
+    it "should add a dependency to a given rake task" do
+      foo = nil
+      bar = nil
+      if !foo_defined?
+        foo = define_foo
+      else
+        foo = Rake::Task[:foo]
+      end
+      if !bar_defined?
+        bar = define_bar
+      else
+        bar = Rake::Task[:bar]
+      end
+      Pkg::Util::RakeUtils.add_dependency(foo, bar)
+      expect(Rake::Task["foo"].prerequisites).to include(bar)
+    end
+  end
+
+  describe "#evaluate_pre_tasks" do
+    context "Given a data file with :pre_tasks defined" do
+      it "should, for each k=>v pair, add v as a dependency to k" do
+        Pkg::Config.config_from_yaml(File.join(FIXTURES, 'util', 'pre_tasks.yaml'))
+        expect(Pkg::Util::RakeUtils).to receive(:add_dependency)
+        Pkg::Util::RakeUtils.evaluate_pre_tasks
+      end
+    end
+  end
+end

data/spec/lib/packaging/util/ship_spec.rb

@@ -0,0 +1,117 @@
+require 'spec_helper'
+
+describe '#Pkg::Util::Ship' do
+  describe '#collect_packages' do
+    msi_pkgs = [
+      'pkg/windows/puppet5/puppet-agent-1.4.1.2904.g8023dd1-x86.msi',
+      'pkg/windows/puppet5/puppet-agent-x86.msi'
+    ]
+    swix_pkgs = [
+      'pkg/eos/puppet5/4/i386/puppet-agent-1.4.1.2904.g8023dd1-1.eos4.i386.swix',
+      'pkg/eos/puppet5/4/i386/puppet-agent-1.4.1.2904.g8023dd1-1.eos4.i386.swix.asc',
+    ]
+
+    it 'returns an array of packages found on the filesystem' do
+      allow(Dir).to receive(:glob).with('pkg/**/*.swix*').and_return(swix_pkgs)
+      expect(Pkg::Util::Ship.collect_packages(['pkg/**/*.swix*'])).to eq(swix_pkgs)
+    end
+
+    describe 'define excludes' do
+      before :each do
+        allow(Dir).to receive(:glob).with('pkg/**/*.msi').and_return(msi_pkgs)
+      end
+      it 'correctly excludes any packages that match a passed excludes argument' do
+        expect(Pkg::Util::Ship.collect_packages(['pkg/**/*.msi'], ['puppet-agent-x(86|64).msi'])).not_to include('pkg/windows/puppet5/puppet-agent-x86.msi')
+      end
+      it 'correctly includes packages that do not match a passed excluded argument' do
+        expect(Pkg::Util::Ship.collect_packages(['pkg/**/*.msi'], ['puppet-agent-x(86|64).msi'])).to include('pkg/windows/puppet5/puppet-agent-1.4.1.2904.g8023dd1-x86.msi')
+      end
+    end
+
+    it 'fails when it cannot find any packages at all' do
+      allow(Dir).to receive(:glob).with('pkg/**/*.html').and_return([])
+      expect(Pkg::Util::Ship.collect_packages(['pkg/**/*.html'])).to be_empty
+    end
+  end
+
+local_pkgs = [
+  'pkg/deb/cumulus/puppet5/puppet-agent_1.4.1.2904.g8023dd1-1cumulus_amd64.deb',
+  'pkg/deb/wheezy/puppet5/puppet-agent_1.4.1.2904.g8023dd1-1wheezy_i386.deb',
+  'pkg/el/5/puppet5/x86_64/puppet-agent-1.4.1.2904.g8023dd1-1.el5.x86_64.rpm',
+  'pkg/sles/11/puppet5/i386/puppet-agent-1.4.1.2904.g8023dd1-1.sles11.i386.rpm',
+  'pkg/mac/10.10/puppet5/x86_64/puppet-agent-1.4.1.2904.g8023dd1-1.osx10.10.dmg',
+  'pkg/eos/4/puppet5/i386/puppet-agent-1.4.1.2904.g8023dd1-1.eos4.i386.swix',
+  'pkg/eos/4/puppet5/i386/puppet-agent-1.4.1.2904.g8023dd1-1.eos4.i386.swix.asc',
+  'pkg/windows/puppet5/puppet-agent-1.4.1.2904.g8023dd1-x86.msi',
+]
+new_pkgs = [
+  'pkg/cumulus/puppet5/puppet-agent_1.4.1.2904.g8023dd1-1cumulus_amd64.deb',
+  'pkg/wheezy/puppet5/puppet-agent_1.4.1.2904.g8023dd1-1wheezy_i386.deb',
+  'pkg/puppet5/el/5/x86_64/puppet-agent-1.4.1.2904.g8023dd1-1.el5.x86_64.rpm',
+  'pkg/puppet5/sles/11/i386/puppet-agent-1.4.1.2904.g8023dd1-1.sles11.i386.rpm',
+  'pkg/mac/puppet5/10.10/x86_64/puppet-agent-1.4.1.2904.g8023dd1-1.osx10.10.dmg',
+  'pkg/eos/puppet5/4/i386/puppet-agent-1.4.1.2904.g8023dd1-1.eos4.i386.swix',
+  'pkg/eos/puppet5/4/i386/puppet-agent-1.4.1.2904.g8023dd1-1.eos4.i386.swix.asc',
+  'pkg/windows/puppet5/puppet-agent-1.4.1.2904.g8023dd1-x86.msi',
+]
+
+  describe '#reorganize_packages' do
+    tmpdir = Dir.mktmpdir
+
+    before :each do
+      allow(Pkg::Paths).to receive(:repo_name).and_return('puppet5')
+      expect(FileUtils).to receive(:cp).at_least(:once)
+    end
+
+    it 'makes a temporary directory' do
+      expect(FileUtils).to receive(:mkdir_p).at_least(:once)
+      Pkg::Util::Ship.reorganize_packages(local_pkgs, tmpdir)
+    end
+
+    it 'leaves the old packages in place' do
+      orig = local_pkgs
+      Pkg::Util::Ship.reorganize_packages(local_pkgs, tmpdir)
+      expect(local_pkgs).to eq(orig)
+    end
+
+    it 'returns a list of packages that do not have the temp dir in the path' do
+      expect(Pkg::Util::Ship.reorganize_packages(local_pkgs, tmpdir)).to eq(new_pkgs)
+    end
+  end
+
+  describe '#ship_pkgs' do
+    test_staging_server = 'foo.delivery.puppetlabs.net'
+    test_remote_path = '/opt/repository/yum'
+
+    it 'ships the packages to the staging server' do
+      allow(Pkg::Util::Ship).to receive(:collect_packages).and_return(local_pkgs)
+      allow(Pkg::Util::Ship).to receive(:reorganize_packages).and_return(new_pkgs)
+      allow(Pkg::Util).to receive(:ask_yes_or_no).and_return(true)
+      # All of these expects must be called in the same block in order for the
+      # tests to work without actually shipping anything
+      expect(Pkg::Util::Net).to receive(:remote_ssh_cmd).with(test_staging_server, /#{test_remote_path}/).exactly(local_pkgs.count).times
+      expect(Pkg::Util::Net).to receive(:rsync_to).with(anything, test_staging_server, /#{test_remote_path}/, anything).exactly(local_pkgs.count).times
+      expect(Pkg::Util::Net).to receive(:remote_set_ownership).with(test_staging_server, 'root', 'release', anything).exactly(local_pkgs.count).times
+      expect(Pkg::Util::Net).to receive(:remote_set_permissions).with(test_staging_server, '775', anything).exactly(local_pkgs.count).times
+      expect(Pkg::Util::Net).to receive(:remote_set_permissions).with(test_staging_server, '0664', anything).exactly(local_pkgs.count).times
+      expect(Pkg::Util::Net).to receive(:remote_set_immutable).with(test_staging_server, anything).exactly(local_pkgs.count).times
+      Pkg::Util::Ship.ship_pkgs(['pkg/**/*.rpm'], test_staging_server, test_remote_path)
+    end
+
+    it 'ships packages containing the string `pkg` to the right place' do
+      allow(Pkg::Util::Ship).to receive(:collect_packages).and_return(['pkg/el/5/puppet5/x86_64/my-super-sweet-pkg-1.0.0-1.el5.x86_64.rpm' ])
+      allow(Pkg::Util::Ship).to receive(:reorganize_packages).and_return(['pkg/puppet5/el/5/x86_64/my-super-sweet-pkg-1.0.0-1.el5.x86_64.rpm'])
+      allow(Pkg::Util).to receive(:ask_yes_or_no).and_return(true)
+      allow(Dir).to receive(:mktmpdir).and_return('/tmp/test')
+      # All of these expects must be called in the same block in order for the
+      # tests to work without actually shipping anything
+      expect(Pkg::Util::Net).to receive(:remote_ssh_cmd).with(test_staging_server, /#{test_remote_path}/)
+      expect(Pkg::Util::Net).to receive(:rsync_to).with(anything, test_staging_server, /#{test_remote_path}/, anything)
+      expect(Pkg::Util::Net).to receive(:remote_set_ownership).with(test_staging_server, 'root', 'release', ['/opt/repository/yum/puppet5/el/5/x86_64', '/opt/repository/yum/puppet5/el/5/x86_64/my-super-sweet-pkg-1.0.0-1.el5.x86_64.rpm'])
+      expect(Pkg::Util::Net).to receive(:remote_set_permissions).with(test_staging_server, '775', anything)
+      expect(Pkg::Util::Net).to receive(:remote_set_permissions).with(test_staging_server, '0664', anything)
+      expect(Pkg::Util::Net).to receive(:remote_set_immutable).with(test_staging_server, anything)
+      Pkg::Util::Ship.ship_pkgs(['pkg/**/*.rpm'], test_staging_server, test_remote_path, excludes: ['puppet-agent'])
+    end
+  end
+end