packaging 0.99.0

data/spec/lib/packaging/deb/repo_spec.rb

@@ -0,0 +1,148 @@
+require 'spec_helper'
+
+describe "Pkg::Deb::Repo" do
+  let(:wget)          { "/opt/tools/bin/wget" }
+  let(:builds_server) { "saturn.puppetlabs.net" }
+  let(:project)       { "deb_repos" }
+  let(:ref)           { "1234abcd" }
+  let(:base_url)      { "http://#{builds_server}/#{project}/#{ref}" }
+  let(:cows)          { ["xenial", "jessie", "trusty", "stretch", ""] }
+  let(:wget_results)  { cows.map {|cow| "#{base_url}/repos/apt/#{cow}" }.join("\n") }
+  let(:wget_garbage)  { "\n and an index\nhttp://somethingelse.com/robots" }
+  let(:repo_configs)  { cows.reject {|cow| cow.empty?}.map {|dist| "pkg/repo_configs/deb/pl-#{project}-#{ref}-#{dist}.list" } }
+
+  # Setup and tear down for the tests
+  around do |example|
+    orig_server = Pkg::Config.builds_server
+    orig_host = Pkg::Config.distribution_server
+    orig_project = Pkg::Config.project
+    orig_ref = Pkg::Config.ref
+    orig_repo_path = Pkg::Config.jenkins_repo_path
+    Pkg::Config.builds_server = builds_server
+    Pkg::Config.project = project
+    Pkg::Config.ref = ref
+    example.run
+    Pkg::Config.builds_server = orig_server
+    Pkg::Config.distribution_server = orig_host
+    Pkg::Config.project = orig_project
+    Pkg::Config.ref = orig_ref
+    Pkg::Config.jenkins_repo_path = orig_repo_path
+  end
+
+  describe "#generate_repo_configs" do
+    it "fails if wget isn't available" do
+      Pkg::Util::Tool.should_receive(:find_tool).with("wget", {:required => true}).and_raise(RuntimeError)
+      expect {Pkg::Deb::Repo.generate_repo_configs}.to raise_error(RuntimeError)
+    end
+
+    it "warns if there are no deb repos available for the build" do
+      Pkg::Util::Tool.should_receive(:find_tool).with("wget", {:required => true}).and_return(wget)
+      Pkg::Util::Execution.should_receive(:capture3).with("#{wget} --spider -r -l 1 --no-parent #{base_url}/repos/apt/ 2>&1").and_raise(RuntimeError)
+      Pkg::Deb::Repo.should_receive(:warn).with("No debian repos available for #{project} at #{ref}.")
+      Pkg::Deb::Repo.generate_repo_configs
+    end
+
+    it "writes the expected repo configs to disk" do
+      Pkg::Util::Tool.should_receive(:find_tool).with("wget", {:required => true}).and_return(wget)
+      Pkg::Util::Execution.should_receive(:capture3).with("#{wget} --spider -r -l 1 --no-parent #{base_url}/repos/apt/ 2>&1").and_return(wget_results + wget_garbage)
+      FileUtils.should_receive(:mkdir_p).with("pkg/repo_configs/deb")
+      config = []
+      repo_configs.each_with_index do |repo_config, i|
+        config[i] = double(File)
+        File.should_receive(:open).with(repo_config, 'w').and_yield(config[i])
+        config[i].should_receive(:puts)
+      end
+      Pkg::Deb::Repo.generate_repo_configs
+    end
+  end
+
+  describe "#retrieve_repo_configs" do
+    it "fails if wget isn't available" do
+      Pkg::Util::Tool.should_receive(:find_tool).with("wget", {:required => true}).and_raise(RuntimeError)
+      expect {Pkg::Deb::Repo.generate_repo_configs}.to raise_error(RuntimeError)
+    end
+
+    it "warns if there are no deb repos available for the build" do
+      Pkg::Util::Tool.should_receive(:find_tool).with("wget", {:required => true}).and_return(wget)
+      FileUtils.should_receive(:mkdir_p).with("pkg/repo_configs").and_return(true)
+      Pkg::Util::Execution.should_receive(:capture3).with("#{wget} -r -np -nH --cut-dirs 3 -P pkg/repo_configs --reject 'index*' #{base_url}/repo_configs/deb/").and_raise(RuntimeError)
+      expect {Pkg::Deb::Repo.retrieve_repo_configs}.to raise_error(RuntimeError, /Couldn't retrieve deb apt repo configs/)
+    end
+  end
+
+  describe "#repo_creation_command" do
+    let(:prefix) { "thing" }
+    let(:artifact_directory) { ["/a/b/c/xenial"] }
+
+    it "returns a command to make repos" do
+      command = Pkg::Deb::Repo.repo_creation_command(prefix, artifact_directory)
+      command.should match(/reprepro/)
+      command.should match(/#{prefix}/)
+      command.should match(/#{artifact_directory}/)
+    end
+  end
+
+  describe "#create_repos" do
+    let(:command) { "/usr/bin/make some repos" }
+    let(:artifact_directory) { "/tmp/dir/thing" }
+    let(:pkg_directories) { ['place/to/deb/xenial', 'other/deb/trusty'] }
+
+    it "generates repo configs remotely and then ships them" do
+      File.stub(:join) {artifact_directory}
+      Pkg::Repo.should_receive(:directories_that_contain_packages).and_return(pkg_directories)
+      Pkg::Repo.should_receive(:populate_repo_directory)
+      Pkg::Deb::Repo.should_receive(:repo_creation_command).and_return(command)
+      Pkg::Util::Net.should_receive(:remote_ssh_cmd).with(Pkg::Config.distribution_server, command)
+      Pkg::Deb::Repo.should_receive(:generate_repo_configs)
+      Pkg::Deb::Repo.should_receive(:ship_repo_configs)
+      Pkg::Util::Net.should_receive(:remote_ssh_cmd).with(Pkg::Config.distribution_server, "rm -f #{artifact_directory}/repos/.lock" )
+      Pkg::Deb::Repo.create_repos
+    end
+  end
+
+  describe "#ship_repo_configs" do
+    it "warns if there are no repo configs to ship" do
+      File.should_receive(:exist?).with("pkg/repo_configs/deb").and_return(true)
+      Pkg::Util::File.should_receive(:empty_dir?).with("pkg/repo_configs/deb").and_return(true)
+      Pkg::Deb::Repo.should_receive(:warn).with("No repo configs have been generated! Try pl:deb_repo_configs.")
+      Pkg::Deb::Repo.ship_repo_configs
+    end
+
+    it "ships repo configs to the build server" do
+      File.should_receive(:exist?).with("pkg/repo_configs/deb").and_return(true)
+      Pkg::Config.jenkins_repo_path = "/a/b/c/d"
+      Pkg::Config.distribution_server = "a.host.that.wont.exist"
+      repo_dir = "#{Pkg::Config.jenkins_repo_path}/#{Pkg::Config.project}/#{Pkg::Config.ref}/repo_configs/deb"
+      Pkg::Util::File.should_receive(:empty_dir?).with("pkg/repo_configs/deb").and_return(false)
+      Pkg::Deb::Repo.should_receive(:invoke_task).with("pl:fetch")
+      Pkg::Util::Net.should_receive(:remote_ssh_cmd).with(Pkg::Config.distribution_server, "mkdir -p #{repo_dir}")
+      Pkg::Util::Execution.should_receive(:retry_on_fail).with(:times => 3)
+      Pkg::Deb::Repo.ship_repo_configs
+    end
+  end
+
+  describe "#sign_repos" do
+    it "fails without reprepro" do
+      Pkg::Util::Tool.should_receive(:find_tool).with('reprepro', {:required => true}).and_raise(RuntimeError)
+      expect { Pkg::Deb::Repo.sign_repos }.to raise_error(RuntimeError)
+    end
+
+    it "makes a repo for each dist" do
+      dists = cows.reject { |cow| cow.empty? }
+      distfiles = {}
+      reprepro = "/bin/reprepro"
+      Pkg::Util::File.should_receive(:directories).with("repos/apt").and_return(dists)
+      Pkg::Util::Tool.should_receive(:check_tool).with("reprepro").and_return(reprepro)
+      Pkg::Util::Execution.should_receive(:capture3).at_least(1).times.with("#{reprepro} -vvv --confdir ./conf --dbdir ./db --basedir ./ export")
+
+      dists.each do |dist|
+        distfiles[dist] = double
+        Dir.should_receive(:chdir).with("repos/apt/#{dist}").and_yield
+        File.should_receive(:open).with("conf/distributions", "w").and_yield(distfiles[dist])
+        distfiles[dist].should_receive(:puts)
+      end
+
+      Pkg::Deb::Repo.sign_repos
+    end
+  end
+end

data/spec/lib/packaging/deb_spec.rb

@@ -0,0 +1,52 @@
+# -*- ruby -*-
+require 'spec_helper'
+require 'packaging/deb'
+
+describe 'deb.rb' do
+  describe "#set_cow_envs" do
+    before(:each) do
+      reset_env(["DIST", "ARCH", "PE_VER", "BUILDMIRROR"])
+      Pkg::Config.deb_build_mirrors = nil
+      Pkg::Config.build_pe = nil
+      Pkg::Config.pe_version = nil
+    end
+
+    after(:all) do
+      reset_env(["DIST", "ARCH", "PE_VER", "BUILDMIRROR"])
+      Pkg::Config.deb_build_mirrors = nil
+      Pkg::Config.build_pe = nil
+      Pkg::Config.pe_version = nil
+    end
+
+    it "should always set DIST and ARCH correctly" do
+      Pkg::Deb.send(:set_cow_envs, "base-wheezy-i386.cow")
+      ENV["DIST"].should eq("wheezy")
+      ENV["ARCH"].should eq("i386")
+      ENV["PE_VER"].should be_nil
+      ENV["BUILDMIRROR"].should be_nil
+    end
+
+    it "should set BUILDMIRROR if Pkg::Config.deb_build_mirrors is set" do
+      Pkg::Config.deb_build_mirrors = ["deb http://pl-build-tools.delivery.puppetlabs.net/debian __DIST__ main", "deb http://debian.is.awesome/wait no it is not"]
+      Pkg::Deb.send(:set_cow_envs, "base-wheezy-i386.cow")
+      ENV["DIST"].should eq("wheezy")
+      ENV["ARCH"].should eq("i386")
+      ENV["PE_VER"].should be_nil
+      ENV["BUILDMIRROR"].should eq("deb http://pl-build-tools.delivery.puppetlabs.net/debian wheezy main | deb http://debian.is.awesome/wait no it is not")
+    end
+
+    it "should set PE_VER if Pkg::Config.build_pe is truthy" do
+      Pkg::Config.build_pe = true
+      Pkg::Config.pe_version = "3.2"
+      Pkg::Deb.send(:set_cow_envs, "base-wheezy-i386.cow")
+      ENV["DIST"].should eq("wheezy")
+      ENV["ARCH"].should eq("i386")
+      ENV["PE_VER"].should eq("3.2")
+      ENV["BUILDMIRROR"].should be_nil
+    end
+
+    it "should fail on a badly formatted cow" do
+      expect { Pkg::Deb.send(:set_cow_envs, "wheezy-i386") }.to raise_error(RuntimeError)
+    end
+  end
+end

data/spec/lib/packaging/paths_spec.rb

@@ -0,0 +1,153 @@
+require 'spec_helper'
+
+describe 'Pkg::Paths' do
+  describe '#arch_from_artifact_path' do
+    arch_transformations = {
+      ['artifacts/aix/6.1/PC1/ppc/puppet-agent-5.1.0.79.g782e03c-1.aix6.1.ppc.rpm', 'aix', '6.1'] => 'power',
+      ['pkg/el-7-x86_64/puppet-agent-4.99.0-1.el7.x86_64.rpm', 'el', '7'] => 'x86_64',
+      ['artifacts/ubuntu-16.04-i386/puppetserver_5.0.1-0.1SNAPSHOT.2017.07.27T2346puppetlabs1.debian.tar.gz', 'ubuntu', '16.04'] => 'source',
+      ['http://saturn.puppetlabs.net/deb_repos/1234abcd/repos/apt/xenial', 'ubuntu', '16.04'] => 'i386',
+      ['pkg/ubuntu-16.04-amd64/puppet-agent_4.99.0-1xenial_amd64.deb', 'ubuntu', '16.04'] => 'amd64',
+      ['artifacts/deb/jessie/PC1/puppetserver_5.0.1.master.orig.tar.gz', 'debian', '8'] => 'source',
+      ['artifacts/el/6/PC1/SRPMS/puppetserver-5.0.1.master-0.1SNAPSHOT.2017.08.18T0951.el6.src.rpm', 'el', '6'] => 'SRPMS'
+    }
+    arch_transformations.each do |path_array, arch|
+      it "should correctly return #{arch} for #{path_array[0]}" do
+        expect(Pkg::Paths.arch_from_artifact_path(path_array[1], path_array[2], path_array[0])).to eq(arch)
+      end
+    end
+  end
+
+  describe '#tag_from_artifact_path' do
+    path_tranformations = {
+      'artifacts/aix/6.1/PC1/ppc/puppet-agent-5.1.0.79.g782e03c-1.aix6.1.ppc.rpm' => 'aix-6.1-power',
+      'pkg/el-7-x86_64/puppet-agent-4.99.0-1.el7.x86_64.rpm' => 'el-7-x86_64',
+      'pkg/ubuntu-16.04-amd64/puppet-agent_4.99.0-1xenial_amd64.deb' => 'ubuntu-16.04-amd64',
+      'pkg/windows-x64/puppet-agent-4.99.0-x64.msi' => 'windows-2012-x64',
+      'artifacts/el/6/products/x86_64/pe-r10k-2.5.4.3-1.el6.x86_64.rpm' => 'el-6-x86_64',
+      'pkg/deb/trusty/pe-r10k_2.5.4.3-1trusty_amd64.deb' => 'ubuntu-14.04-amd64',
+      'pkg/pe/rpm/el-6-i386/pe-puppetserver-2017.3.0.3-1.el6.noarch.rpm' => 'el-6-i386',
+      'pkg/pe/deb/xenial/pe-puppetserver_2017.3.0.3-1puppet1_all.deb' => 'ubuntu-16.04-i386',
+      'pkg/pe/deb/xenial/super-trusty-package_1.0.0-1puppet1_all.deb' => 'ubuntu-16.04-i386',
+      'artifacts/deb/wheezy/PC1/puppetdb_4.3.1-1puppetlabs1_all.deb' => 'debian-7-i386',
+      'pkg/el/7/PC1/x86_64/puppetdb-4.3.1-1.el7.noarch.rpm' => 'el-7-x86_64',
+      'pkg/apple/10.11/PC1/x86_64/puppet-agent-1.9.0-1.osx10.11.dmg' => 'osx-10.11-x86_64',
+      'artifacts/mac/10.11/PC1/x86_64/puppet-agent-1.9.0-1.osx10.11.dmg' => 'osx-10.11-x86_64',
+      'artifacts/eos/4/PC1/i386/puppet-agent-1.9.0-1.eos4.i386.swix' => 'eos-4-i386',
+      'pkg/deb/cumulus/puppet5/puppet-agent_1.4.1.2904.g8023dd1-1cumulus_amd64.deb' => 'cumulus-2.2-amd64',
+      'pkg/windows/puppet-agent-1.9.0-x86.msi' => 'windows-2012-x86',
+      'artifacts/ubuntu-16.04-i386/puppetserver_5.0.1-0.1SNAPSHOT.2017.07.27T2346puppetlabs1.debian.tar.gz' => 'ubuntu-16.04-source',
+      'http://saturn.puppetlabs.net/deb_repos/1234abcd/repos/apt/xenial' => 'ubuntu-16.04-i386',
+      'http://builds.puppetlabs.lan/puppet-agent/0ce4e6a0448366e01537323bbab77f834d7035c7/repos/el/6/PC1/x86_64/' => 'el-6-x86_64',
+      'http://builds.puppetlabs.lan/puppet-agent/0ce4e6a0448366e01537323bbab77f834d7035c7/repos/el/6/PC1/x86_64/' => 'el-6-x86_64',
+      'pkg/pe/rpm/el-6-i386/pe-puppetserver-2017.3.0.3-1.el6.src.rpm' => 'el-6-SRPMS',
+      'pkg/pe/deb/xenial/pe-puppetserver_2017.3.0.3-1puppet1.orig.tar.gz' => 'ubuntu-16.04-source',
+      'pkg/puppet-agent-5.1.0.79.g782e03c.gem' => nil,
+      'pkg/puppet-agent-5.1.0.7.g782e03c.tar.gz' => nil,
+    }
+    path_tranformations.each do |pre, post|
+      it "should correctly return '#{post}' when given #{pre}" do
+        expect(Pkg::Paths.tag_from_artifact_path(pre)).to eq(post)
+      end
+    end
+
+    failure_cases = [
+      'pkg/pe/deb/preice',
+      'pkg/el-4-x86_64',
+      'a/package/that/sucks.rpm',
+    ]
+    failure_cases.each do |fail_path|
+      it "should fail gracefully if given '#{fail_path}'" do
+        expect { Pkg::Paths.tag_from_artifact_path(fail_path) }.to raise_error
+      end
+    end
+  end
+
+  describe '#repo_name' do
+
+    it 'should return repo_name for final version' do
+      allow(Pkg::Config).to receive(:repo_name).and_return('puppet5')
+      allow(Pkg::Util::Version).to receive(:final?).and_return(true)
+      expect(Pkg::Paths.repo_name).to eq('puppet5')
+    end
+
+    it 'should be empty string if repo_name is not set for final version' do
+      allow(Pkg::Config).to receive(:repo_name).and_return(nil)
+      allow(Pkg::Util::Version).to receive(:final?).and_return(true)
+      expect(Pkg::Paths.repo_name).to eq('')
+    end
+
+    it 'should return nonfinal_repo_name for non-final version' do
+      allow(Pkg::Config).to receive(:nonfinal_repo_name).and_return('puppet5-nightly')
+      allow(Pkg::Util::Version).to receive(:final?).and_return(false)
+      expect(Pkg::Paths.repo_name).to eq('puppet5-nightly')
+    end
+
+    it 'should return repo_name if nonfinal_repo_name is not set for non-final version' do
+      allow(Pkg::Config).to receive(:repo_name).and_return('puppet5')
+      allow(Pkg::Config).to receive(:nonfinal_repo_name).and_return(nil)
+      allow(Pkg::Util::Version).to receive(:final?).and_return(false)
+      expect(Pkg::Paths.repo_name).to eq('puppet5')
+    end
+  end
+
+  describe '#artifacts_path' do
+    before :each do
+      allow(Pkg::Paths).to receive(:repo_name).and_return('puppet5')
+    end
+
+    it 'should be correct for el7' do
+      expect(Pkg::Paths.artifacts_path('el-7-x86_64')).to eq('artifacts/puppet5/el/7/x86_64')
+    end
+
+    it 'should be correct for trusty' do
+      expect(Pkg::Paths.artifacts_path('ubuntu-14.04-amd64')).to eq('artifacts/trusty/puppet5')
+    end
+
+    it 'should be correct for solaris 11' do
+      expect(Pkg::Paths.artifacts_path('solaris-11-sparc')).to eq('artifacts/solaris/puppet5/11')
+    end
+
+    it 'should be correct for osx' do
+      expect(Pkg::Paths.artifacts_path('osx-10.10-x86_64')).to eq('artifacts/mac/puppet5/10.10/x86_64')
+    end
+
+    it 'should be correct for windows' do
+      expect(Pkg::Paths.artifacts_path('windows-2012-x64')).to eq('artifacts/windows/puppet5')
+    end
+
+    it 'should work on all current platforms' do
+      Pkg::Platforms.platform_tags.each do |tag|
+        expect { Pkg::Paths.artifacts_path(tag) }.not_to raise_error
+      end
+    end
+  end
+
+  describe '#repo_path' do
+    before :each do
+      allow(Pkg::Paths).to receive(:repo_name).and_return('puppet5')
+    end
+
+    it 'should be correct' do
+      expect(Pkg::Paths.repo_path('el-7-x86_64')).to eq('repos/puppet5/el/7/x86_64')
+    end
+
+    it 'should work on all current platforms' do
+      Pkg::Platforms.platform_tags.each do |tag|
+        expect { Pkg::Paths.repo_path(tag) }.not_to raise_error
+      end
+    end
+  end
+
+  describe '#repo_config_path' do
+    it 'should be correct' do
+      expect(Pkg::Paths.repo_config_path('el-7-x86_64')).to eq('repo_configs/rpm/*el-7-x86_64*.repo')
+    end
+
+    it 'should work on all current platforms' do
+      Pkg::Platforms.platform_tags.each do |tag|
+        expect { Pkg::Paths.repo_config_path(tag) }.not_to raise_error
+      end
+    end
+  end
+end

data/spec/lib/packaging/platforms_spec.rb

@@ -0,0 +1,153 @@
+require 'spec_helper'
+
+describe 'Pkg::Platforms' do
+  describe '#by_package_format' do
+    it 'should return an array of platforms that use a given format' do
+      deb_platforms = ['cumulus', 'debian', 'ubuntu']
+      rpm_platforms = ['aix', 'cisco-wrlinux', 'el', 'fedora', 'redhat-fips', 'sles']
+      expect(Pkg::Platforms.by_package_format('deb')).to match_array(deb_platforms)
+      expect(Pkg::Platforms.by_package_format('rpm')).to match_array(rpm_platforms)
+    end
+  end
+
+  describe '#formats' do
+    it 'should return all package formats' do
+      fmts = ['rpm', 'deb', 'swix', 'dmg', 'svr4', 'ips', 'msi']
+      expect(Pkg::Platforms.formats).to match_array(fmts)
+    end
+  end
+
+  describe '#supported_platforms' do
+    it 'should return all supported platforms' do
+      platforms = ['aix', 'cisco-wrlinux', 'cumulus', 'debian', 'el', 'eos', 'fedora', 'osx', 'redhat-fips', 'sles', 'solaris', 'ubuntu', 'windows']
+      expect(Pkg::Platforms.supported_platforms).to match_array(platforms)
+    end
+  end
+
+  describe '#versions_for_platform' do
+    it 'should return all supported versions for a given platform' do
+      expect(Pkg::Platforms.versions_for_platform('el')).to match_array(['5', '6', '7'])
+    end
+
+    it 'should raise an error if given a nonexistent platform' do
+      expect{Pkg::Platforms.versions_for_platform('notaplatform') }.to raise_error
+    end
+  end
+
+  describe '#codenames' do
+    it 'should return all codenames for a given platform' do
+      codenames = ['cumulus', 'wheezy', 'jessie', 'stretch', 'trusty', 'xenial']
+      expect(Pkg::Platforms.codenames).to match_array(codenames)
+    end
+  end
+
+  describe '#codename_to_platform_version' do
+    it 'should return the platform and version corresponding to a given codename' do
+      expect(Pkg::Platforms.codename_to_platform_version('xenial')).to eq(['ubuntu', '16.04'])
+    end
+
+    it 'should fail if given nil as a codename' do
+      expect{Pkg::Platforms.codename_to_platform_version(nil)}.to raise_error
+    end
+  end
+
+  describe '#codename_for_platform_version' do
+    it 'should return the codename corresponding to a given platform and version' do
+      expect(Pkg::Platforms.codename_for_platform_version('ubuntu', '16.04')).to eq('xenial')
+    end
+  end
+
+  describe '#arches_for_codename' do
+    it 'should return an array of arches corresponding to a given codename' do
+      expect(Pkg::Platforms.arches_for_codename('trusty')).to match_array(['i386', 'amd64'])
+    end
+  end
+
+  describe '#codename_to_tags' do
+    it 'should return an array of platform tags corresponding to a given codename' do
+      expect(Pkg::Platforms.codename_to_tags('trusty')).to match_array(['ubuntu-14.04-i386', 'ubuntu-14.04-amd64'])
+    end
+  end
+
+  describe '#arches_for_platform_version' do
+    it 'should return an array of arches for a given platform and version' do
+      expect(Pkg::Platforms.arches_for_platform_version('sles', '11')).to match_array(['i386', 'x86_64', 's390x'])
+    end
+  end
+
+  describe '#platform_tags' do
+    it 'should return an array of platform tags' do
+      tags = Pkg::Platforms.platform_tags
+      expect(tags).to be_instance_of(Array)
+      expect(tags.count).to be > 0
+    end
+
+    it 'should include a basic platform' do
+      tags = Pkg::Platforms.platform_tags
+      expect(tags).to include('el-7-x86_64')
+    end
+  end
+
+  describe '#platform_lookup' do
+    it 'should return a hash of platform info' do
+      expect(Pkg::Platforms.platform_lookup('osx-10.10-x86_64')).to be_instance_of(Hash)
+    end
+
+    it 'should include at least arch and package format keys' do
+      expect(Pkg::Platforms.platform_lookup('osx-10.10-x86_64').keys).to include(:architectures)
+      expect(Pkg::Platforms.platform_lookup('osx-10.10-x86_64').keys).to include(:package_format)
+    end
+  end
+
+  describe '#get_attribute' do
+    it 'returns info about a given platform' do
+      expect(Pkg::Platforms.get_attribute('el-6-x86_64', :signature_format)).to eq('v4')
+    end
+
+    it 'fails with a reasonable error when specified attribute is not defined' do
+      expect { Pkg::Platforms.get_attribute('eos-4-i386', :signature_format) }.to raise_error(/doesn't have information/)
+    end
+  end
+
+  describe '#package_format_for_tag' do
+    it 'should return the package format for a given platform tag' do
+      expect(Pkg::Platforms.package_format_for_tag('windows-2012-x86')).to eq('msi')
+    end
+  end
+
+  describe '#parse_platform_tag' do
+    test_cases = {
+      'debian-9-amd64' => ['debian', '9', 'amd64'],
+      'windows-2012-x86' => ['windows', '2012', 'x86'],
+      'el-7-x86_64' => ['el', '7', 'x86_64'],
+      'cisco-wrlinux-7-x86_64' => ['cisco-wrlinux', '7', 'x86_64'],
+      'cisco-wrlinux-7' => ['cisco-wrlinux', '7', ''],
+      'el-6' => ['el', '6', ''],
+      'xenial-amd64' => ['ubuntu', '16.04', 'amd64'],
+      'xenial' => ['ubuntu', '16.04', ''],
+      'windows-2012' => ['windows', '2012', ''],
+      'redhat-fips-7-x86_64' => ['redhat-fips', '7', 'x86_64'],
+    }
+
+    fail_cases = [
+      'debian-4-amd64',
+      'el-x86_64',
+      'nothing',
+      'windows-x86',
+      'el-7-notarch',
+      'debian-7-x86_64',
+    ]
+
+    test_cases.each do |platform_tag, results|
+      it "returns an array for #{platform_tag}" do
+        expect(Pkg::Platforms.parse_platform_tag(platform_tag)).to match_array(results)
+      end
+    end
+
+    fail_cases.each do |platform_tag|
+      it "fails out for #{platform_tag}" do
+        expect { Pkg::Platforms.parse_platform_tag(platform_tag)}.to raise_error
+      end
+    end
+  end
+end