packaging 0.88.77

data/spec/lib/packaging/deb/repo_spec.rb

@@ -0,0 +1,157 @@
+require 'spec_helper'
+
+describe "Pkg::Deb::Repo" do
+  let(:wget)          { "/opt/tools/bin/wget" }
+  let(:builds_server) { "saturn.puppetlabs.net" }
+  let(:project)       { "deb_repos" }
+  let(:ref)           { "1234abcd" }
+  let(:base_url)      { "http://#{builds_server}/#{project}/#{ref}" }
+  let(:cows)          { ["xenial", "jessie", "trusty", "stretch", ""] }
+  let(:wget_results)  { cows.map {|cow| "#{base_url}/repos/apt/#{cow}" }.join("\n") }
+  let(:wget_garbage)  { "\n and an index\nhttp://somethingelse.com/robots" }
+  let(:repo_configs)  { cows.reject {|cow| cow.empty?}.map {|dist| "pkg/repo_configs/deb/pl-#{project}-#{ref}-#{dist}.list" } }
+
+  # Setup and tear down for the tests
+  around do |example|
+    orig_server = Pkg::Config.builds_server
+    orig_host = Pkg::Config.distribution_server
+    orig_project = Pkg::Config.project
+    orig_ref = Pkg::Config.ref
+    orig_repo_path = Pkg::Config.jenkins_repo_path
+    Pkg::Config.builds_server = builds_server
+    Pkg::Config.project = project
+    Pkg::Config.ref = ref
+    example.run
+    Pkg::Config.builds_server = orig_server
+    Pkg::Config.distribution_server = orig_host
+    Pkg::Config.project = orig_project
+    Pkg::Config.ref = orig_ref
+    Pkg::Config.jenkins_repo_path = orig_repo_path
+  end
+
+  describe "#generate_repo_configs" do
+    it "fails if wget isn't available" do
+      Pkg::Util::Tool.should_receive(:find_tool).with("wget", {:required => true}).and_raise(RuntimeError)
+      expect {Pkg::Deb::Repo.generate_repo_configs}.to raise_error(RuntimeError)
+    end
+
+    it "warns if there are no deb repos available for the build" do
+      Pkg::Util::Tool.should_receive(:find_tool).with("wget", {:required => true}).and_return(wget)
+      Pkg::Util::Execution.should_receive(:capture3).with("#{wget} --spider -r -l 1 --no-parent #{base_url}/repos/apt/ 2>&1").and_raise(RuntimeError)
+      Pkg::Deb::Repo.should_receive(:warn).with("No debian repos available for #{project} at #{ref}.")
+      Pkg::Deb::Repo.generate_repo_configs
+    end
+
+    it "writes the expected repo configs to disk" do
+      Pkg::Util::Tool.should_receive(:find_tool).with("wget", {:required => true}).and_return(wget)
+      Pkg::Util::Execution.should_receive(:capture3).with("#{wget} --spider -r -l 1 --no-parent #{base_url}/repos/apt/ 2>&1").and_return(wget_results + wget_garbage)
+      FileUtils.should_receive(:mkdir_p).with("pkg/repo_configs/deb")
+      config = []
+      repo_configs.each_with_index do |repo_config, i|
+        config[i] = double(File)
+        File.should_receive(:open).with(repo_config, 'w').and_yield(config[i])
+        config[i].should_receive(:puts)
+      end
+      Pkg::Deb::Repo.generate_repo_configs
+    end
+  end
+
+  describe "#retrieve_repo_configs" do
+    it "fails if wget isn't available" do
+      Pkg::Util::Tool.should_receive(:find_tool).with("wget", {:required => true}).and_raise(RuntimeError)
+      expect {Pkg::Deb::Repo.generate_repo_configs}.to raise_error(RuntimeError)
+    end
+
+    it "warns if there are no deb repos available for the build" do
+      Pkg::Util::Tool.should_receive(:find_tool).with("wget", {:required => true}).and_return(wget)
+      FileUtils.should_receive(:mkdir_p).with("pkg/repo_configs").and_return(true)
+      Pkg::Util::Execution.should_receive(:capture3).with("#{wget} -r -np -nH --cut-dirs 3 -P pkg/repo_configs --reject 'index*' #{base_url}/repo_configs/deb/").and_raise(RuntimeError)
+      expect {Pkg::Deb::Repo.retrieve_repo_configs}.to raise_error(RuntimeError, /Couldn't retrieve deb apt repo configs/)
+    end
+  end
+
+  describe "#repo_creation_command" do
+    let(:prefix) { "thing" }
+    let(:artifact_directory) { ["/a/b/c/xenial"] }
+
+    it "returns a command to make repos" do
+      command = Pkg::Deb::Repo.repo_creation_command(prefix, artifact_directory)
+      command.should match(/reprepro/)
+      command.should match(/#{prefix}/)
+      command.should match(/#{artifact_directory}/)
+    end
+  end
+
+  describe "#create_repos" do
+    let(:command) { "/usr/bin/make some repos" }
+    let(:artifact_directory) { "/tmp/dir/thing" }
+    let(:pkg_directories) { ['place/to/deb/xenial', 'other/deb/trusty'] }
+
+    it "generates repo configs remotely and then ships them" do
+      File.stub(:join) {artifact_directory}
+      Pkg::Repo.should_receive(:directories_that_contain_packages).and_return(pkg_directories)
+      Pkg::Repo.should_receive(:populate_repo_directory)
+      Pkg::Deb::Repo.should_receive(:repo_creation_command).and_return(command)
+      Pkg::Util::Net.should_receive(:remote_execute).with(Pkg::Config.distribution_server, command)
+      Pkg::Deb::Repo.should_receive(:generate_repo_configs)
+      Pkg::Deb::Repo.should_receive(:ship_repo_configs)
+      Pkg::Util::Net.should_receive(:remote_execute).with(Pkg::Config.distribution_server, "rm -f #{artifact_directory}/repos/.lock" )
+      Pkg::Deb::Repo.create_repos
+    end
+  end
+
+  describe "#ship_repo_configs" do
+    it "warns if there are no repo configs to ship" do
+      File.should_receive(:exist?).with("pkg/repo_configs/deb").and_return(true)
+      Pkg::Util::File.should_receive(:empty_dir?).with("pkg/repo_configs/deb").and_return(true)
+      Pkg::Deb::Repo.should_receive(:warn).with("No repo configs have been generated! Try pl:deb_repo_configs.")
+      Pkg::Deb::Repo.ship_repo_configs
+    end
+
+    it "ships repo configs to the build server" do
+      File.should_receive(:exist?).with("pkg/repo_configs/deb").and_return(true)
+      Pkg::Config.jenkins_repo_path = "/a/b/c/d"
+      Pkg::Config.distribution_server = "a.host.that.wont.exist"
+      repo_dir = "#{Pkg::Config.jenkins_repo_path}/#{Pkg::Config.project}/#{Pkg::Config.ref}/repo_configs/deb"
+      Pkg::Util::File.should_receive(:empty_dir?).with("pkg/repo_configs/deb").and_return(false)
+      Pkg::Util::RakeUtils.should_receive(:invoke_task).with("pl:fetch")
+      Pkg::Util::Net.should_receive(:remote_execute).with(Pkg::Config.distribution_server, "mkdir -p #{repo_dir}")
+      Pkg::Util::Execution.should_receive(:retry_on_fail).with(:times => 3)
+      Pkg::Deb::Repo.ship_repo_configs
+    end
+  end
+
+  describe "#sign_repos" do
+    it "fails without reprepro" do
+      Pkg::Util::Tool.should_receive(:find_tool).with('reprepro', {:required => true}).and_raise(RuntimeError)
+      expect { Pkg::Deb::Repo.sign_repos }.to raise_error(RuntimeError)
+    end
+
+    it "makes a repo for each dist" do
+      # stub out start_keychain to prevent actual keychain starts.
+      Pkg::Util::Gpg.stub(:start_keychain)
+
+      dists = cows.reject { |cow| cow.empty? }
+      distfiles = {}
+      Pkg::Util::File.should_receive(:directories).with("repos/apt").and_return(dists)
+
+      # Let the keychain command happen if find_tool('keychain') finds it
+      keychain_command = "/usr/bin/keychain -k mine"
+      allow(Pkg::Util::Execution).to receive(:capture3) { keychain_command }
+
+      # Enforce reprepro
+      reprepro_command = "/bin/reprepro"
+      Pkg::Util::Tool.should_receive(:check_tool).with("reprepro").and_return(reprepro_command)
+      Pkg::Util::Execution.should_receive(:capture3).at_least(1).times.with("#{reprepro_command} -vvv --confdir ./conf --dbdir ./db --basedir ./ export")
+
+      dists.each do |dist|
+        distfiles[dist] = double
+        Dir.should_receive(:chdir).with("repos/apt/#{dist}").and_yield
+        File.should_receive(:open).with("conf/distributions", "w").and_yield(distfiles[dist])
+        distfiles[dist].should_receive(:puts)
+      end
+
+      Pkg::Deb::Repo.sign_repos
+    end
+  end
+end

data/spec/lib/packaging/deb_spec.rb

@@ -0,0 +1,52 @@
+# -*- ruby -*-
+require 'spec_helper'
+require 'packaging/deb'
+
+describe 'deb.rb' do
+  describe "#set_cow_envs" do
+    before(:each) do
+      reset_env(["DIST", "ARCH", "PE_VER", "BUILDMIRROR"])
+      Pkg::Config.deb_build_mirrors = nil
+      Pkg::Config.build_pe = nil
+      Pkg::Config.pe_version = nil
+    end
+
+    after(:all) do
+      reset_env(["DIST", "ARCH", "PE_VER", "BUILDMIRROR"])
+      Pkg::Config.deb_build_mirrors = nil
+      Pkg::Config.build_pe = nil
+      Pkg::Config.pe_version = nil
+    end
+
+    it "should always set DIST and ARCH correctly" do
+      Pkg::Deb.send(:set_cow_envs, "base-wheezy-i386.cow")
+      ENV["DIST"].should eq("wheezy")
+      ENV["ARCH"].should eq("i386")
+      ENV["PE_VER"].should be_nil
+      ENV["BUILDMIRROR"].should be_nil
+    end
+
+    it "should set BUILDMIRROR if Pkg::Config.deb_build_mirrors is set" do
+      Pkg::Config.deb_build_mirrors = ["deb http://pl-build-tools.delivery.puppetlabs.net/debian __DIST__ main", "deb http://debian.is.awesome/wait no it is not"]
+      Pkg::Deb.send(:set_cow_envs, "base-wheezy-i386.cow")
+      ENV["DIST"].should eq("wheezy")
+      ENV["ARCH"].should eq("i386")
+      ENV["PE_VER"].should be_nil
+      ENV["BUILDMIRROR"].should eq("deb http://pl-build-tools.delivery.puppetlabs.net/debian wheezy main | deb http://debian.is.awesome/wait no it is not")
+    end
+
+    it "should set PE_VER if Pkg::Config.build_pe is truthy" do
+      Pkg::Config.build_pe = true
+      Pkg::Config.pe_version = "3.2"
+      Pkg::Deb.send(:set_cow_envs, "base-wheezy-i386.cow")
+      ENV["DIST"].should eq("wheezy")
+      ENV["ARCH"].should eq("i386")
+      ENV["PE_VER"].should eq("3.2")
+      ENV["BUILDMIRROR"].should be_nil
+    end
+
+    it "should fail on a badly formatted cow" do
+      expect { Pkg::Deb.send(:set_cow_envs, "wheezy-i386") }.to raise_error(RuntimeError)
+    end
+  end
+end

data/spec/lib/packaging/gem_spec.rb

@@ -0,0 +1,86 @@
+require 'spec_helper'
+
+describe 'Pkg::Gem' do
+  describe '#shipped_to_rubygems?' do
+    let(:gem_data) {
+      [
+        {"authors"=>"Puppet Labs",
+         "built_at"=>"2018-12-17T00:00:00.000Z",
+         "created_at"=>"2018-12-18T17:31:50.852Z",
+         "description"=>"Puppet, an automated configuration management tool",
+         "downloads_count"=>32750,
+         "metadata"=>{},
+         "number"=>"6.1.0",
+         "summary"=>"Puppet, an automated configuration management tool",
+         "platform"=>"ruby",
+         "rubygems_version"=>"> 1.3.1",
+         "ruby_version"=>">= 2.3.0",
+         "prerelease"=>false,
+         "licenses"=>[],
+         "requirements"=>[],
+         "sha"=>"71ecec1f554cd7a7f23abf1523e4f0f15fb8ddbc973201234d0cc2a889566373"},
+        {"authors"=>"Puppet Labs",
+          "built_at"=>"2019-01-14T00:00:00.000Z",
+          "created_at"=>"2019-01-15T15:25:25.183Z",
+          "description"=>"Puppet, an automated configuration management tool",
+          "downloads_count"=>540,
+          "metadata"=>{},
+          "number"=>"6.0.5",
+          "summary"=>"Puppet, an automated configuration management tool",
+          "platform"=>"ruby",
+          "rubygems_version"=>"> 1.3.1",
+          "ruby_version"=>">= 2.3.0",
+          "prerelease"=>false,
+          "licenses"=>[],
+          "requirements"=>[],
+          "sha"=>"76811bcf4c5ab75470dd6ae5eea552347767748bd80136cac74261336b208916"},
+        {"authors"=>"Puppet Labs",
+          "built_at"=>"2018-10-31T00:00:00.000Z",
+          "created_at"=>"2018-11-01T17:07:19.274Z",
+          "description"=>"Puppet, an automated configuration management tool",
+          "downloads_count"=>71808,
+          "metadata"=>{},
+          "number"=>"6.0.4",
+          "summary"=>"Puppet, an automated configuration management tool",
+          "platform"=>"ruby",
+          "rubygems_version"=>"> 1.3.1",
+          "ruby_version"=>">= 2.3.0",
+          "prerelease"=>false,
+          "licenses"=>[],
+          "requirements"=>[],
+          "sha"=>"203e8b529d37260115ab7e804e607dde5e543144331b40c3c4a77c2d33445026"},
+        {"authors"=>"Puppet Labs",
+          "built_at"=>"2018-10-31T00:00:00.000Z",
+          "created_at"=>"2018-11-01T17:07:10.268Z",
+          "description"=>"Puppet, an automated configuration management tool",
+          "downloads_count"=>1179,
+          "metadata"=>{},
+          "number"=>"6.0.4",
+          "summary"=>"Puppet, an automated configuration management tool",
+          "platform"=>"x86-mingw32",
+          "rubygems_version"=>"> 1.3.1",
+          "ruby_version"=>">= 2.3.0",
+          "prerelease"=>false,
+          "licenses"=>[],
+          "requirements"=>[],
+          "sha"=>"e57ef7d537aaf66343615d7413d1ff759cc2b6ae95cc90514dd8f3caf0f08cb1"}
+      ]
+    }
+    it 'returns true if gem version has already been shipped' do
+      allow(JSON).to receive(:parse).and_return(gem_data)
+      expect(Pkg::Gem.shipped_to_rubygems?('puppet', '6.0.5', 'ruby')).to be true
+    end
+    it 'returns false if the platform doesn\'t match' do
+      allow(JSON).to receive(:parse).and_return(gem_data)
+      expect(Pkg::Gem.shipped_to_rubygems?('puppet', '6.0.5', 'x64-mingw32')).to be false
+    end
+    it 'returns false if gem version has not already been shipped' do
+      allow(JSON).to receive(:parse).and_return(gem_data)
+      expect(Pkg::Gem.shipped_to_rubygems?('puppet', '6.0.9', 'ruby')).to be false
+    end
+    it 'returns false if gem is not found at all on rubygems' do
+      expect { Pkg::Gem.shipped_to_rubygems?('totally-not-a-real-gem', '9.9.9', 'ruby') }.to_not raise_error
+      expect(Pkg::Gem.shipped_to_rubygems?('totally-not-a-real-gem', '9.9.9', 'ruby')).to be false
+    end
+  end
+end

data/spec/lib/packaging/paths_spec.rb

@@ -0,0 +1,418 @@
+require 'spec_helper'
+
+describe 'Pkg::Paths' do
+  describe '#arch_from_artifact_path' do
+    arch_transformations = {
+      ['pkg/el-8-x86_64/puppet-agent-6.9.0-1.el8.x86_64.rpm', 'el', '8'] => 'x86_64',
+      ['pkg/el/8/puppet6/aarch64/puppet-agent-6.5.0.3094.g16b6fa6f-1.el8.aarch64.rpm', 'el', '8'] => 'aarch64',
+      ['artifacts/fedora/32/puppet6/x86_64/puppet-agent-6.9.0-1.fc30.x86_64.rpm', 'fedora', '32'] => 'x86_64',
+      ['pkg/ubuntu-16.04-amd64/puppet-agent_4.99.0-1xenial_amd64.deb', 'ubuntu', '16.04'] => 'amd64',
+      ['artifacts/deb/focal/puppet6/puppet-agent_6.5.0.3094.g16b6fa6f-1focal_arm64.deb', 'ubuntu', '20.04'] => 'aarch64',
+
+      ['artifacts/ubuntu-16.04-i386/puppetserver_5.0.1-0.1SNAPSHOT.2017.07.27T2346puppetlabs1.debian.tar.gz', 'ubuntu', '16.04'] => 'source',
+      ['artifacts/deb/jessie/PC1/puppetserver_5.0.1.master.orig.tar.gz', 'debian', '8'] => 'source',
+      ['artifacts/el/6/PC1/SRPMS/puppetserver-5.0.1.master-0.1SNAPSHOT.2017.08.18T0951.el6.src.rpm', 'el', '6'] => 'SRPMS'
+    }
+    arch_transformations.each do |path_array, arch|
+      it "should correctly return #{arch} for #{path_array[0]}" do
+        expect(Pkg::Paths.arch_from_artifact_path(path_array[1], path_array[2], path_array[0]))
+          .to eq(arch)
+      end
+    end
+  end
+
+  describe '#tag_from_artifact_path' do
+    path_tranformations = {
+      'pkg/el-7-x86_64/puppet-agent-5.5.22-1.el8.x86_64.rpm' => 'el-7-x86_64',
+      'pkg/ubuntu-20.04-amd64/puppet-agent_5.5.22-1xenial_amd64.deb' => 'ubuntu-20.04-amd64',
+      'pkg/windows/puppet-agent-5.5.22-x86.msi' => 'windows-2012-x86',
+      'artifacts/el/6/products/x86_64/pe-r10k-2.5.4.3-1.el6.x86_64.rpm' => 'el-6-x86_64',
+      'pkg/pe/rpm/el-6-i386/pe-puppetserver-2017.3.0.3-1.el6.noarch.rpm' => 'el-6-i386',
+      'pkg/deb/bionic/pe-r10k_3.5.2.0-1bionic_amd64.deb' => 'ubuntu-18.04-amd64',
+      'pkg/deb/buster/pe-r10k_3.5.2.0-1buster_amd64.deb' => 'debian-10-amd64',
+      'pkg/pe/deb/bionic/pe-puppetserver_2019.8.2.32-1bionic_all.deb' => 'ubuntu-18.04-amd64',
+      'artifacts/deb/focal/puppet6/puppetdb_6.13.0-1focal_all.deb' => 'ubuntu-20.04-amd64',
+      'pkg/apple/10.15/puppet6/x86_64/puppet-agent-6.19.0-1.osx10.15.dmg' => 'osx-10.15-x86_64',
+      'pkg/apple/11/puppet6/x86_64/puppet-agent-6.19.0-1.osx11.dmg' => 'osx-11-x86_64',
+      'pkg/windows/puppet-agent-1.9.0-x86.msi' => 'windows-2012-x86',
+      'pkg/pe/rpm/el-6-i386/pe-puppetserver-2017.3.0.3-1.el6.src.rpm' => 'el-6-SRPMS',
+      'pkg/pe/deb/xenial/pe-puppetserver_2017.3.0.3-1puppet1.orig.tar.gz' => 'ubuntu-16.04-source',
+      'pkg/puppet-agent-5.1.0.79.g782e03c.gem' => nil,
+      'pkg/puppet-agent-5.1.0.7.g782e03c.tar.gz' => nil,
+    }
+    path_tranformations.each do |pre, post|
+      it "should correctly return '#{post}' when given #{pre}" do
+        expect(Pkg::Paths.tag_from_artifact_path(pre)).to eq(post)
+      end
+    end
+
+    failure_cases = [
+      'pkg/pe/deb/preice',
+      'pkg/el-4-x86_64',
+      'a/package/that/sucks.rpm',
+    ]
+    failure_cases.each do |fail_path|
+      it "should fail gracefully if given '#{fail_path}'" do
+        expect { Pkg::Paths.tag_from_artifact_path(fail_path) }.to raise_error
+      end
+    end
+  end
+
+  describe '#repo_name' do
+    it 'should return repo_name for final version' do
+      allow(Pkg::Config).to receive(:repo_name).and_return('puppet6')
+      expect(Pkg::Paths.repo_name).to eq('puppet6')
+    end
+
+    it 'should return repo_name for final version' do
+      allow(Pkg::Config).to receive(:repo_name).and_return('FUTURE-puppet7')
+      expect(Pkg::Paths.repo_name).to eq('FUTURE-puppet7')
+    end
+
+    it 'should be empty string if repo_name is not set for final version' do
+      allow(Pkg::Config).to receive(:repo_name).and_return(nil)
+      expect(Pkg::Paths.repo_name).to eq('')
+    end
+
+    it 'should return nonfinal_repo_name for non-final version' do
+      allow(Pkg::Config).to receive(:nonfinal_repo_name).and_return('puppet6-nightly')
+      expect(Pkg::Paths.repo_name(true)).to eq('puppet6-nightly')
+    end
+
+    it 'should fail if nonfinal_repo_name is not set for non-final version' do
+      allow(Pkg::Config).to receive(:repo_name).and_return('puppet6')
+      allow(Pkg::Config).to receive(:nonfinal_repo_name).and_return(nil)
+      expect { Pkg::Paths.repo_name(true) }.to raise_error
+    end
+  end
+
+  describe '#artifacts_path' do
+    context 'all puppet versions' do
+      before :each do
+        allow(Pkg::Config).to receive(:repo_name).and_return('puppet6')
+      end
+
+      it 'should work on all current platforms' do
+        Pkg::Platforms.platform_tags.each do |tag|
+          expect { Pkg::Paths.artifacts_path(tag) }.not_to raise_error
+        end
+      end
+    end
+
+    context 'for puppet 6 and prior' do
+      before :each do
+        allow(Pkg::Config).to receive(:repo_name).and_return('puppet6')
+      end
+
+      it 'should be correct for el7' do
+        expect(Pkg::Paths.artifacts_path('el-7-x86_64'))
+          .to eq('artifacts/puppet6/el/7/x86_64')
+      end
+
+      it 'should be correct for bionic' do
+        expect(Pkg::Paths.artifacts_path('ubuntu-18.04-amd64'))
+          .to eq('artifacts/bionic/puppet6')
+      end
+
+      it 'should be correct for solaris 11' do
+        expect(Pkg::Paths.artifacts_path('solaris-11-sparc'))
+          .to eq('artifacts/solaris/puppet6/11')
+      end
+
+      it 'should be correct for osx' do
+        expect(Pkg::Paths.artifacts_path('osx-10.15-x86_64'))
+          .to eq('artifacts/mac/puppet6/10.15/x86_64')
+      end
+
+      it 'should be correct for osx11' do
+        expect(Pkg::Paths.artifacts_path('osx-11-x86_64'))
+          .to eq('artifacts/mac/puppet6/11/x86_64')
+      end
+
+      it 'should be correct for windows' do
+        expect(Pkg::Paths.artifacts_path('windows-2012-x64'))
+          .to eq('artifacts/windows/puppet6')
+      end
+    end
+
+    context 'after puppet 7 apt changes' do
+      before :each do
+        allow(Pkg::Config).to receive(:repo_name).and_return('FUTURE-puppet7')
+      end
+
+      it 'should be correct for bionic' do
+        expect(Pkg::Paths.artifacts_path('ubuntu-18.04-amd64'))
+          .to eq('artifacts/FUTURE-puppet7/bionic')
+      end
+      it 'should be correct for focal' do
+        expect(Pkg::Paths.artifacts_path('ubuntu-20.04-amd64'))
+          .to eq('artifacts/FUTURE-puppet7/focal')
+      end
+    end
+  end
+
+  describe '#repo_path' do
+    before :each do
+      allow(Pkg::Config).to receive(:repo_name).and_return('puppet6')
+    end
+
+    it 'should be correct' do
+      expect(Pkg::Paths.repo_path('el-7-x86_64')).to eq('repos/puppet6/el/7/x86_64')
+    end
+
+    it 'should work on all current platforms' do
+      Pkg::Platforms.platform_tags.each do |tag|
+        expect { Pkg::Paths.repo_path(tag) }.not_to raise_error
+      end
+    end
+  end
+
+  describe '#repo_config_path' do
+    it 'should construct rpm/deb-specific repo configs' do
+      expect(Pkg::Paths.repo_config_path('el-7-x86_64'))
+        .to eq('repo_configs/rpm/*el-7-x86_64*.repo')
+      expect(Pkg::Paths.repo_config_path('ubuntu-18.04-amd64'))
+        .to eq('repo_configs/deb/*bionic*.list')
+    end
+
+    it 'should raise a RuntimeError with unfamilar repo configs' do
+      expect { Pkg::Paths.repo_config_path('bogus') }
+        .to raise_error(/Could not verify that 'bogus' is a valid tag/)
+    end
+
+    it 'should work on all current platforms' do
+      Pkg::Platforms.platform_tags.each do |tag|
+        expect { Pkg::Paths.repo_config_path(tag) }.not_to raise_error
+      end
+    end
+  end
+
+  describe '#apt_repo_name' do
+    it 'should return `Pkg::Config.repo_name` if set' do
+      allow(Pkg::Config).to receive(:repo_name).and_return('puppet6')
+      allow(Pkg::Config).to receive(:apt_repo_name).and_return('stuff')
+      expect(Pkg::Paths.apt_repo_name).to eq('puppet6')
+    end
+
+    it 'should return `Pkg::Config.apt_repo_name` if `Pkg::Config.repo_name` is not set' do
+      allow(Pkg::Config).to receive(:repo_name).and_return(nil)
+      allow(Pkg::Config).to receive(:apt_repo_name).and_return('puppet6')
+      expect(Pkg::Paths.apt_repo_name).to eq('puppet6')
+    end
+
+    it 'should return \'main\' if nothing is set' do
+      allow(Pkg::Config).to receive(:repo_name).and_return(nil)
+      allow(Pkg::Config).to receive(:apt_repo_name).and_return(nil)
+      expect(Pkg::Paths.apt_repo_name).to eq('main')
+    end
+
+    it 'should return nonfinal_repo_name for nonfinal version' do
+      allow(Pkg::Config).to receive(:repo_name).and_return('FUTURE-puppet7')
+      allow(Pkg::Config).to receive(:nonfinal_repo_name).and_return('FUTURE-puppet7-nightly')
+      expect(Pkg::Paths.apt_repo_name(true)).to eq('FUTURE-puppet7-nightly')
+    end
+
+    it 'should fail if nonfinal_repo_name is not set for non-final version' do
+      allow(Pkg::Config).to receive(:repo_name).and_return('FUTURE-puppet7')
+      allow(Pkg::Config).to receive(:nonfinal_repo_name).and_return(nil)
+      expect { Pkg::Paths.apt_repo_name(true) }.to raise_error
+    end
+  end
+
+  describe '#yum_repo_name' do
+    it 'should return `Pkg::Config.repo_name` if set' do
+      allow(Pkg::Config).to receive(:repo_name).and_return('puppet6')
+      allow(Pkg::Config).to receive(:yum_repo_name).and_return('stuff')
+      expect(Pkg::Paths.yum_repo_name).to eq('puppet6')
+    end
+
+    it 'should return `Pkg::Config.yum_repo_name` if `Pkg::Config.repo_name` is not set' do
+      allow(Pkg::Config).to receive(:repo_name).and_return(nil)
+      allow(Pkg::Config).to receive(:yum_repo_name).and_return('FUTURE-puppet7')
+      expect(Pkg::Paths.yum_repo_name).to eq('FUTURE-puppet7')
+    end
+
+    it 'should return \'products\' if nothing is set' do
+      allow(Pkg::Config).to receive(:repo_name).and_return(nil)
+      allow(Pkg::Config).to receive(:yum_repo_name).and_return(nil)
+      expect(Pkg::Paths.yum_repo_name).to eq('products')
+    end
+
+    it 'should return nonfinal_repo_name for nonfinal version' do
+      allow(Pkg::Config).to receive(:repo_name).and_return('FUTURE-puppet7')
+      allow(Pkg::Config).to receive(:nonfinal_repo_name).and_return('FUTURE-puppet7-nightly')
+      expect(Pkg::Paths.yum_repo_name(true)).to eq('FUTURE-puppet7-nightly')
+    end
+
+    it 'should fail if nonfinal_repo_name is not set for non-final version' do
+      allow(Pkg::Config).to receive(:repo_name).and_return('FUTURE-puppet7')
+      allow(Pkg::Config).to receive(:nonfinal_repo_name).and_return(nil)
+      expect { Pkg::Paths.yum_repo_name(true) }.to raise_error
+    end
+  end
+
+  describe '#remote_repo_base' do
+    fake_yum_repo_path = '/fake/yum'
+    fake_yum_nightly_repo_path = '/fake/yum-nightly'
+    fake_apt_repo_path = '/fake/apt'
+    fake_apt_nightly_repo_path = '/fake/apt-nightly'
+
+    before :each do
+      allow(Pkg::Config).to receive(:yum_repo_path).and_return(fake_yum_repo_path)
+      allow(Pkg::Config).to receive(:apt_repo_path).and_return(fake_apt_repo_path)
+      allow(Pkg::Config).to receive(:dmg_path).and_return('/opt/downloads/mac')
+      allow(Pkg::Config).to receive(:nonfinal_yum_repo_path).and_return(fake_yum_nightly_repo_path)
+      allow(Pkg::Config).to receive(:nonfinal_apt_repo_path).and_return(fake_apt_nightly_repo_path)
+    end
+    it 'returns yum_repo_path for rpms' do
+      expect(Pkg::Paths.remote_repo_base('el-7-x86_64'))
+        .to eq(fake_yum_repo_path)
+    end
+    it 'returns apt_repo_path for debs' do
+      expect(Pkg::Paths.remote_repo_base('ubuntu-18.04-amd64'))
+        .to eq(fake_apt_repo_path)
+    end
+    it 'returns nonfinal_yum_repo_path for nonfinal rpms' do
+      expect(Pkg::Paths.remote_repo_base('fedora-31-x86_64', nonfinal: true))
+        .to eq(fake_yum_nightly_repo_path)
+    end
+    it 'returns nonfinal_apt_repo_path for nonfinal debs' do
+      expect(Pkg::Paths.remote_repo_base('debian-9-amd64', nonfinal: true))
+        .to eq(fake_apt_nightly_repo_path)
+    end
+    it 'fails if neither tag nor package_format is provided' do
+      expect { Pkg::Paths.remote_repo_base }
+        .to raise_error(/Pkg::Paths.remote_repo_base must have/)
+    end
+
+    it 'returns /opt/downloads if the path is /opt/downloads/<something>' do
+      expect(Pkg::Paths.remote_repo_base(package_format: 'dmg')).to eq('/opt/downloads')
+    end
+
+    it 'fails for all other package formats' do
+      expect { Pkg::Paths.remote_repo_base('solaris-11-i386') }
+        .to raise_error(/Can't determine remote repo base path/)
+    end
+  end
+
+  describe '#apt_package_base_path' do
+    it 'fails for non-debian platforms' do
+      expect { Pkg::Paths.apt_package_base_path('el-7-x86_64', 'puppet6', 'puppet-agent') }
+        .to raise_error(/Can't determine path for non-debian platform/)
+    end
+
+    context 'for puppet 6 and prior' do
+      it 'returns the approprate apt repo path' do
+        allow(Pkg::Paths).to receive(:remote_repo_base).and_return('/opt/repository/apt')
+        expect(Pkg::Paths.apt_package_base_path('ubuntu-18.04-amd64', 'puppet6', 'puppet-agent'))
+          .to eq('/opt/repository/apt/pool/bionic/puppet6/p/puppet-agent')
+        expect(Pkg::Paths.apt_package_base_path('debian-9-amd64', 'puppet6', 'bolt-server'))
+          .to eq('/opt/repository/apt/pool/stretch/puppet6/b/bolt-server')
+
+
+      end
+      it 'returns the appropriate nonfinal repo path' do
+        allow(Pkg::Paths).to receive(:remote_repo_base).and_return('/opt/repository-nightlies/apt')
+        expect(Pkg::Paths.apt_package_base_path('ubuntu-18.04-amd64', 'puppet6-nightly',
+                                                'puppet-agent', true))
+          .to eq('/opt/repository-nightlies/apt/pool/bionic/puppet6-nightly/p/puppet-agent')
+        expect(Pkg::Paths.apt_package_base_path('debian-10-amd64', 'puppet6-nightly',
+                                                'pdk', true))
+          .to eq('/opt/repository-nightlies/apt/pool/buster/puppet6-nightly/p/pdk')
+      end
+    end
+
+    context 'for puppet 7 and after' do
+      it 'returns the approprate apt repo path' do
+        allow(Pkg::Paths).to receive(:remote_repo_base).and_return('/opt/repository/apt')
+        expect(Pkg::Paths.apt_package_base_path('ubuntu-18.04-amd64', 'FUTURE-puppet7', 'puppet-agent'))
+          .to eq('/opt/repository/apt/FUTURE-puppet7/pool/bionic/p/puppet-agent')
+        expect(Pkg::Paths.apt_package_base_path('ubuntu-20.04-amd64', 'FUTURE-puppet7', 'puppet-agent'))
+          .to eq('/opt/repository/apt/FUTURE-puppet7/pool/focal/p/puppet-agent')
+      end
+      it 'returns the appropriate nonfinal repo path' do
+        allow(Pkg::Paths).to receive(:remote_repo_base).and_return('/opt/repository-nightlies/apt')
+        expect(Pkg::Paths.apt_package_base_path('debian-10-amd64', 'FUTURE-puppet7-nightly', 'pdk', true))
+          .to eq('/opt/repository-nightlies/apt/FUTURE-puppet7-nightly/pool/buster/p/pdk')
+      end
+    end
+  end
+
+  describe '#release_package_link_path' do
+    context 'for puppet 6' do
+      repo_name = 'puppet6'
+      nonfinal_repo_name = 'puppet6-nightly'
+      yum_repo_path = '/opt/repository/yum'
+      apt_repo_path = '/opt/repository/apt'
+      nonfinal_yum_repo_path = '/opt/repository-nightlies/yum'
+      nonfinal_apt_repo_path = '/opt/repository-nightlies/apt'
+      before :each do
+        allow(Pkg::Config).to receive(:repo_name).and_return(repo_name)
+        allow(Pkg::Config).to receive(:nonfinal_repo_name).and_return(nonfinal_repo_name)
+        allow(Pkg::Config).to receive(:yum_repo_path).and_return(yum_repo_path)
+        allow(Pkg::Config).to receive(:apt_repo_path).and_return(apt_repo_path)
+        allow(Pkg::Config).to receive(:nonfinal_yum_repo_path).and_return(nonfinal_yum_repo_path)
+        allow(Pkg::Config).to receive(:nonfinal_apt_repo_path).and_return(nonfinal_apt_repo_path)
+      end
+      it 'returns the appropriate link path for rpm release packages' do
+        expect(Pkg::Paths.release_package_link_path('sles-12-ppc64le'))
+          .to eq("#{yum_repo_path}/#{repo_name}-release-sles-12.noarch.rpm")
+      end
+      it 'returns the appropriate link path for deb release packages' do
+        expect(Pkg::Paths.release_package_link_path('ubuntu-16.04-amd64'))
+          .to eq("#{apt_repo_path}/#{repo_name}-release-xenial.deb")
+      end
+      it 'returns the appropriate link path for nonfinal rpm release packages' do
+        expect(Pkg::Paths.release_package_link_path('el-7-x86_64', true))
+          .to eq("#{nonfinal_yum_repo_path}/#{nonfinal_repo_name}-release-el-7.noarch.rpm")
+      end
+      it 'returns the appropriate link path for nonfinal deb release packages' do
+        expect(Pkg::Paths.release_package_link_path('debian-9-i386', true))
+          .to eq("#{nonfinal_apt_repo_path}/#{nonfinal_repo_name}-release-stretch.deb")
+      end
+      it 'returns nil for package formats that do not have release packages' do
+        expect(Pkg::Paths.release_package_link_path('osx-10.15-x86_64')).to eq(nil)
+        expect(Pkg::Paths.release_package_link_path('osx-11-x86_64')).to eq(nil)
+        expect(Pkg::Paths.release_package_link_path('windows-2012-x86')).to eq(nil)
+      end
+    end
+
+    context 'for puppet 7' do
+      repo_name = 'FUTURE-puppet7'
+      nonfinal_repo_name = 'FUTURE-puppet7-nightly'
+      yum_repo_path = '/opt/repository/yum'
+      apt_repo_path = '/opt/repository/apt'
+      nonfinal_yum_repo_path = '/opt/repository-nightlies/yum'
+      nonfinal_apt_repo_path = '/opt/repository-nightlies/apt'
+      before :each do
+        allow(Pkg::Config).to receive(:repo_name).and_return(repo_name)
+        allow(Pkg::Config).to receive(:nonfinal_repo_name).and_return(nonfinal_repo_name)
+        allow(Pkg::Config).to receive(:yum_repo_path).and_return(yum_repo_path)
+        allow(Pkg::Config).to receive(:apt_repo_path).and_return(apt_repo_path)
+        allow(Pkg::Config).to receive(:nonfinal_yum_repo_path).and_return(nonfinal_yum_repo_path)
+        allow(Pkg::Config).to receive(:nonfinal_apt_repo_path).and_return(nonfinal_apt_repo_path)
+      end
+      it 'returns the appropriate link path for rpm release packages' do
+        expect(Pkg::Paths.release_package_link_path('sles-12-ppc64le'))
+          .to eq("#{yum_repo_path}/#{repo_name}-release-sles-12.noarch.rpm")
+      end
+      it 'returns the appropriate link path for deb release packages' do
+        expect(Pkg::Paths.release_package_link_path('ubuntu-20.04-amd64'))
+          .to eq("#{apt_repo_path}/#{repo_name}-release-focal.deb")
+      end
+      it 'returns the appropriate link path for nonfinal rpm release packages' do
+        expect(Pkg::Paths.release_package_link_path('el-8-x86_64', true))
+          .to eq("#{nonfinal_yum_repo_path}/#{nonfinal_repo_name}-release-el-8.noarch.rpm")
+      end
+      it 'returns the appropriate link path for nonfinal deb release packages' do
+        expect(Pkg::Paths.release_package_link_path('debian-10-i386', true))
+          .to eq("#{nonfinal_apt_repo_path}/#{nonfinal_repo_name}-release-buster.deb")
+      end
+      it 'returns nil for package formats that do not have release packages' do
+        expect(Pkg::Paths.release_package_link_path('osx-10.15-x86_64')).to eq(nil)
+        expect(Pkg::Paths.release_package_link_path('osx-11-x86_64')).to eq(nil)
+        expect(Pkg::Paths.release_package_link_path('windows-2012-x86')).to eq(nil)
+      end
+    end
+  end
+end