packaging 0.88.77

data/lib/packaging/util/tool.rb

@@ -0,0 +1,41 @@
+# Utility methods for handling system binaries
+
+module Pkg::Util::Tool
+
+  #   Set up utility methods for handling system binaries
+  #
+  class << self
+    def check_tool(tool)
+      find_tool(tool, :required => true)
+    end
+
+    def find_tool(tool, args = { :required => false })
+      ENV['PATH'].split(File::PATH_SEPARATOR).each do |root|
+        location = File.join(root, tool)
+
+        if Pkg::Util::OS.windows? && File.extname(location).empty?
+          exts = ENV['PATHEXT']
+          exts = exts ? exts.split(File::PATH_SEPARATOR) : %w(.EXE .BAT .CMD .COM)
+          exts.each do |ext|
+            locationext = File.expand_path(location + ext)
+
+            return '"' + locationext + '"' if FileTest.executable?(locationext)
+          end
+        end
+
+        return location if FileTest.executable? location
+      end
+      fail "#{tool} tool not found...exiting" if args[:required]
+      return nil
+    end
+
+    alias :has_tool :find_tool
+
+  end
+
+  #   Set up paths to system tools we use in the packaging repo
+  #   no matter what distribution we're packaging for.
+
+  GIT = Pkg::Util::Tool.check_tool('git')
+
+end

data/lib/packaging/util/version.rb

@@ -0,0 +1,334 @@
+require 'json'
+
+# Utility methods used for versioning projects for various kinds of packaging
+module Pkg::Util::Version
+  class << self
+    def uname_r
+      uname = Pkg::Util::Tool.find_tool('uname', required: true)
+      stdout, = Pkg::Util::Execution.capture3("#{uname} -r")
+      stdout.chomp
+    end
+
+    def pwd_version
+      Dir.pwd.split('.')[-1]
+    end
+
+    def debversion
+      base_pkg_version.join('-') << "#{Pkg::Config.packager}1"
+    end
+
+    def origversion
+      Pkg::Config.debversion.split('-')[0]
+    end
+
+    def rpmversion
+      base_pkg_version[0]
+    end
+
+    def rpmrelease
+      base_pkg_version[1]
+    end
+
+    # This is used to set Pkg::Config.version
+    # describe can return a number of potential formats
+    # 5.3.0
+    # 5.3.0-18-gfbddc8f
+    # 5.3.0-18-gfbddc8f-dirty
+    # 0.7.0-rc1
+    # 0.7.0-rc1-63-g51ccc51
+    # 0.7.0-rc1-63-g51ccc51-dirty
+    #
+    # we want all of it except the `gfbddc8f` part.
+    def dash_version
+      describe = Pkg::Util::Git.describe
+      info = describe.split('-')
+
+      if Pkg::Util::Git.ref_type == "tag"
+        describe
+      else
+        info.reject { |d| d.match(/^g.{7}/) }.join('-')
+      end
+    end
+
+    def extended_dash_version
+      Pkg::Util::Git.describe(['--tags', '--dirty', '--abbrev=7'])
+    end
+
+    # This version is used for gems and platform types that do not support
+    # dashes in the package version
+    def dot_version(version = Pkg::Config.version)
+      version.tr('-', '.')
+    end
+
+    def extended_dot_version
+      dot_version(extended_dash_version)
+    end
+
+    # Given a version, reformat it to be appropriate for a final package
+    # version. This means we need to add a `0.` before the release version
+    # for non-final builds
+    #
+    # This only applies to packages that are built with the automation in this
+    # repo. This is invalid for all other build automation, like vanagon
+    #
+    # Examples of output:
+    # 4.99.0.22.gf64bc49-1
+    # 4.4.1-0.1SNAPSHOT.2017.05.16T1005
+    # 4.99.0-1
+    # 4.99.0.29.g431768c-1
+    # 2.7.1-1
+    # 5.3.0.rc4-1
+    # 3.0.5.rc6.24.g431768c-1
+    #
+    # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
+    def base_pkg_version(version = Pkg::Config.version)
+      return "#{dot_version(version)}-#{Pkg::Config.release}".split('-') if final?(version) || Pkg::Config.vanagon_project
+
+      if version.include?('SNAPSHOT')
+        new_version = dot_version(version).sub(/\.SNAPSHOT/, "-0.#{Pkg::Config.release}SNAPSHOT")
+      elsif version.include?('rc')
+        rc_ver = dot_version(version).match(/\.?rc(\d+)/)[1]
+        new_version = dot_version(version).sub(/\.?rc(\d+)/, '') + "-0.#{Pkg::Config.release}rc#{rc_ver}"
+      else
+        new_version = dot_version(version) + "-0.#{Pkg::Config.release}"
+      end
+
+      if new_version.include?('dirty')
+        new_version = new_version.sub(/\.?dirty/, '') + 'dirty'
+      end
+
+      new_version.split('-')
+    end
+
+    # Determines if the version we are working with is or is not final
+    #
+    # The version here does not include the release version. Therefore, we
+    # assume that any version that includes a `-\d+` was not built from a tag
+    # and is a non-final version.
+    # Examples:
+    # Final
+    #   - 5.0.0
+    #   - 2016.5.6.7
+    # Nonfinal
+    #   - 4.99.0-22
+    #   - 1.0.0-658-gabc1234
+    #   - 5.0.0.master.SNAPSHOT.2017.05.16T1357
+    #   - 5.9.7-rc4
+    #   - 4.99.0-56-dirty
+    #
+    def final?(version = Pkg::Config.version)
+      case version
+      when /rc/
+        false
+      when /SNAPSHOT/
+        false
+      when /g[a-f0-9]{7}/
+        false
+      when /^(\d+\.)+\d+-\d+/
+        false
+      when /-dirty/
+        Pkg::Config.allow_dirty_tree
+      else
+        true
+      end
+    end
+
+    # This is to support packages that only burn-in the version number in the
+    # release artifact, rather than storing it two (or more) times in the
+    # version control system.  Razor is a good example of that; see
+    # https://github.com/puppetlabs/Razor/blob/master/lib/project_razor/version.rb
+    # for an example of that this looks like.
+    #
+    # If you invoke this the version will only be modified in the temporary copy,
+    # with the intent that it never change the official source tree.
+    #
+    # rubocop:disable Metrics/AbcSize
+    # rubocop:disable Metrics/CyclomaticComplexity
+    # rubocop:disable Metrics/PerceivedComplexity
+    def versionbump(workdir = nil)
+      version = ENV['VERSION'] || Pkg::Config.version.to_s.strip
+      new_version = '"' + version + '"'
+
+      version_file = "#{workdir ? workdir + '/' : ''}#{Pkg::Config.version_file}"
+
+      # Read the previous version file in...
+      contents = IO.read(version_file)
+
+      # Match version files containing 'VERSION = "x.x.x"' and just x.x.x
+      if contents =~ /VERSION =.*/
+        old_version = contents.match(/VERSION =.*/).to_s.split[-1]
+      else
+        old_version = contents
+      end
+
+      puts "Updating #{old_version} to #{new_version} in #{version_file}"
+      if contents =~ /@DEVELOPMENT_VERSION@/
+        contents.gsub!('@DEVELOPMENT_VERSION@', version)
+      elsif contents =~ /version\s*=\s*[\'"]DEVELOPMENT[\'"]/
+        contents.gsub!(/version\s*=\s*['"]DEVELOPMENT['"]/, "version = '#{version}'")
+      elsif contents =~ /VERSION = #{old_version}/
+        contents.gsub!("VERSION = #{old_version}", "VERSION = #{new_version}")
+      elsif contents =~ /#{Pkg::Config.project.upcase}VERSION = #{old_version}/
+        contents.gsub!("#{Pkg::Config.project.upcase}VERSION = #{old_version}", "#{Pkg::Config.project.upcase}VERSION = #{new_version}")
+      else
+        contents.gsub!(old_version, Pkg::Config.version)
+      end
+
+      # ...and write it back on out.
+      File.open(version_file, 'w') { |f| f.write contents }
+    end
+
+    # Human readable output for json tags reporting. This will load the
+    # input json file and output if it "looks tagged" or not
+    #
+    # @param json_data [hash] json data hash containing the ref to check
+    def report_json_tags(json_data) # rubocop:disable Metrics/AbcSize
+      puts 'component: ' + File.basename(json_data['url'])
+      puts 'ref: ' + json_data['ref'].to_s
+      if Pkg::Util::Git.remote_tagged?(json_data['url'], json_data['ref'].to_s)
+        tagged = 'Tagged? [ Yes ]'
+      else
+        tagged = 'Tagged? [ No  ]'
+      end
+      col_len = (ENV['COLUMNS'] || 70).to_i
+      puts format("\n%#{col_len}s\n\n", tagged)
+      puts '*' * col_len
+    end
+
+    ##########################################################################
+    # DEPRECATED METHODS
+    #
+    def git_co(ref)
+      Pkg::Util.deprecate('Pkg::Util::Version.git_co', 'Pkg::Util::Git.checkout')
+      Pkg::Util::Git.checkout(ref)
+    end
+
+    def git_tagged?
+      Pkg::Util.deprecate('Pkg::Util::Version.git_tagged?', 'Pkg::Util::Git.tagged?')
+      Pkg::Util::Git.tagged?
+    end
+
+    def git_describe
+      Pkg::Util.deprecate('Pkg::Util::Version.git_describe', 'Pkg::Util::Git.describe')
+      Pkg::Util::Git.describe
+    end
+
+    def git_sha(length = 40)
+      Pkg::Util.deprecate('Pkg::Util::Version.git_sha', 'Pkg::Util::Git.sha')
+      Pkg::Util::Git.sha(length)
+    end
+
+    def git_ref_type
+      Pkg::Util.deprecate('Pkg::Util::Version.git_ref_type', 'Pkg::Util::Git.ref_type')
+      Pkg::Util::Git.ref_type
+    end
+
+    def git_sha_or_tag(length = 40)
+      Pkg::Util.deprecate('Pkg::Util::Version.git_sha_or_tag', 'Pkg::Util::Git.sha_or_tag')
+      Pkg::Util::Git.sha_or_tag(length)
+    end
+
+    def is_git_repo?
+      Pkg::Util.deprecate('Pkg::Util::Version.is_git_repo?', 'Pkg::Util::Git.repo?')
+      Pkg::Util::Git.repo?
+    end
+
+    def git_project_name
+      Pkg::Util.deprecate('Pkg::Util::Version.git_project_name', 'Pkg::Util::Git.project_name')
+      Pkg::Util::Git.project_name
+    end
+
+    def git_describe_version
+      Pkg::Util.deprecate('Pkg::Util::Version.git_describe_version', 'Pkg::Util::Git.describe')
+      Pkg::Util::Git.describe
+    end
+
+    def run_git_describe_internal
+      Pkg::Util.deprecate('Pkg::Util::Version.git_describe_version', 'Pkg::Util::Git.describe')
+      Pkg::Util::Git.describe
+    end
+
+    def get_dash_version
+      Pkg::Util.deprecate('Pkg::Util::Version.get_dash_version', 'Pkg::Util::Version.dash_version')
+      Pkg::Util::Version.dash_version
+    end
+
+    def get_ips_version
+      raise "The IPS build tasks have been removed from puppetlabs/packaging. Please port all Solaris projects to vanagon (https://github.com/puppetlabs/vanagon)"
+    end
+
+    def get_dot_version
+      Pkg::Util.deprecate('Pkg::Util::Version.get_dot_version', 'Pkg::Util::Version.dot_version')
+      Pkg::Util::Version.dot_version
+    end
+
+    def get_pwd_version
+      Pkg::Util.deprecate('Pkg::Util::Version.get_pwd_version', 'Pkg::Util::Version.pwd_version')
+      Pkg::Util::Version.pwd_version
+    end
+
+    def get_base_pkg_version
+      Pkg::Util.deprecate('Pkg::Util::Version.get_base_pkg_version', 'Pkg::Util::Version.base_pkg_version')
+      Pkg::Util::Version.base_pkg_version
+    end
+
+    def get_debversion
+      Pkg::Util.deprecate('Pkg::Util::Version.get_debversion', 'Pkg::Util::Version.debversion')
+      Pkg::Util::Version.debversion
+    end
+
+    def get_origversion
+      Pkg::Util.deprecate('Pkg::Util::Version.get_origversion', 'Pkg::Util::Version.origversion')
+      Pkg::Util::Version.origversion
+    end
+
+    def get_rpmversion
+      Pkg::Util.deprecate('Pkg::Util::Version.get_rpmversion', 'Pkg::Util::Version.rpmversion')
+      Pkg::Util::Version.rpmversion
+    end
+
+    def get_rpmrelease
+      Pkg::Util.deprecate('Pkg::Util::Version.get_rpmrelease', 'Pkg::Util::Version.rpmrelease')
+      Pkg::Util::Version.rpmrelease
+    end
+
+    def source_dirty?
+      Pkg::Util.deprecate('Pkg::Util::Version.source_dirty?', 'Pkg::Util::Git.source_dirty?')
+      Pkg::Util::Git.source_dirty?
+    end
+
+    def fail_on_dirty_source
+      Pkg::Util.deprecate('Pkg::Util::Version.fail_on_dirty_source', 'Pkg::Util::Git.fail_on_dirty_source')
+      Pkg::Util::Git.fail_on_dirty_source
+    end
+
+    def is_final?
+      Pkg::Util.deprecate('Pkg::Util::Version.is_final?', 'Pkg::Util::Version.final?')
+      Pkg::Util::Version.final?
+    end
+
+    def is_rc?
+      Pkg::Util.deprecate('Pkg::Util::Version.is_rc?', 'Pkg::Util::Version.final?')
+      Pkg::Util::Version.final?
+    end
+
+    def is_odd?
+      Pkg::Util.deprecate('Pkg::Util::Version.is_odd?', 'Pkg::Util::Version.final?')
+      Pkg::Util::Version.final?
+    end
+
+    def is_less_than_one?
+      Pkg::Util.deprecate('Pkg::Util::Version.is_less_than_one?', 'Pkg::Util::Version.final?')
+      Pkg::Util::Version.final?
+    end
+
+    def el_version
+      raise "Pkg::Util::Version.el_version has been removed"
+    end
+
+    def tagged?(url, ref)
+      Pkg::Util.deprecate('Pkg::Util::Version.tagged?', 'Pkg::Util::Git.remote_tagged?')
+      Pkg::Util::Git.remote_tagged?(url, ref)
+    end
+  end
+end

data/spec/fixtures/config/ext/build_defaults.yaml

@@ -0,0 +1,2 @@
+---
+:apt_host: foo

data/spec/fixtures/config/ext/project_data.yaml

@@ -0,0 +1,2 @@
+---
+:apt_host: foo

data/spec/fixtures/configs/components/test_file.json

@@ -0,0 +1 @@
+{"url": "git://github.com/puppetlabs/leatherman.git", "ref": "refs/tags/0.6.2"}

data/spec/fixtures/configs/components/test_file_not_tagged.json

@@ -0,0 +1 @@
+{"url": "git://github.com/puppetlabs/leatherman.git", "ref": "4eef05389ebf418b62af17406c7f9f13fa51f975"}

data/spec/fixtures/util/pre_tasks.yaml

@@ -0,0 +1,4 @@
+---
+pre_tasks:
+  foo: 'bar'
+

data/spec/lib/packaging/artifactory_spec.rb

@@ -0,0 +1,221 @@
+# -*- ruby -*-
+require 'spec_helper'
+require 'packaging/artifactory'
+
+describe 'artifactory.rb' do
+
+  project = 'puppet-agent'
+  project_version = 'ashawithlettersandnumbers'
+  default_repo_name = 'testing'
+  artifactory_uri = 'https://artifactory.url'
+
+  let(:platform_data) {
+    {
+      'el-6-x86_64' => {
+        :artifact => "./el/6/PC1/x86_64/puppet-agent-5.3.1.34.gf65f9ef-1.el6.x86_64.rpm",
+        :repo_config => "../repo_configs/rpm/pl-puppet-agent-f65f9efbb727c3d2d72d6799c0fc345a726f27b5-el-6-x86_64.repo",
+        :additional_artifacts => ["./el/6/PC1/x86_64/puppet-agent-extras-5.3.1.34.gf65f9ef-1.el6.x86_64.rpm"],
+      },
+      'ubuntu-16.04-amd64' => {
+        :artifact => "./deb/xenial/PC1/puppet-agent_5.3.1.34.gf65f9ef-1xenial_amd64.deb",
+        :repo_config => "../repo_configs/deb/pl-puppet-agent-f65f9efbb727c3d2d72d6799c0fc345a726f27b5-xenial.list",
+        :additional_artifacts => ["./deb/xenial/PC1/puppet-agent-extras_5.3.1.34.gf65f9ef-1xenial_amd64.deb"],
+      },
+      'debian-10-amd64' => {
+        :artifact => "./deb/buster/PC1/puppetdb_5.3.1.34.gf65f9ef-1buster_all.deb",
+        :repo_config => "../repo_configs/deb/pl-puppetdb-f65f9efbb727c3d2d72d6799c0fc345a726f27b5-buster.list",
+        :additional_artifacts => ["./deb/buster/PC1/puppetdb-termini_5.3.1.34.gf65f9ef-1buster_all.deb"],
+      },
+      'windows-2012-x86' => {
+        :artifact => "./windows/puppet-agent-5.3.1.34-x86.msi",
+        :repo_config => '',
+        :additional_artifacts => ["./windows/puppet-agent-extras-5.3.1.34-x86.msi"],
+      },
+      'windowsfips-2012-x64' => {
+        :artifact => "./windowsfips/puppet-agent-5.3.1.34-x64.msi",
+        :repo_config => '',
+        :additional_artifacts => ["./windowsfips/puppet-agent-extras-5.3.1.34-x64.msi"],
+      },
+      'osx-10.15-x86_64' => {
+        :artifact => "./apple/10.15/PC1/x86_64/puppet-agent-5.3.1.34.gf65f9ef-1.osx10.15.dmg",
+        :repo_config => '',
+        :additional_artifacts => ["./apple/10.15/PC1/x86_64/puppet-agent-extras-5.3.1.34.gf65f9ef-1.osx10.15.dmg"],
+      },
+      'osx-11-x86_64' => {
+        :artifact => "./apple/11/PC1/x86_64/puppet-agent-5.3.1.34.gf65f9ef-1.osx11.dmg",
+        :repo_config => '',
+        :additional_artifacts => ["./apple/11/PC1/x86_64/puppet-agent-extras-5.3.1.34.gf65f9ef-1.osx11.dmg"],
+      },
+      'solaris-10-sparc' => {
+        :artifact => "./solaris/10/PC1/puppet-agent-5.3.1.34.gf65f9ef-1.sparc.pkg.gz",
+        :repo_config => '',
+      },
+    }
+  }
+
+  platform_tags = {
+    'el-6-x86_64' => {
+      :toplevel_repo => 'rpm',
+      :repo_subdirectories => "#{default_repo_name}/#{project}/#{project_version}/el-6-x86_64",
+      :package_format => 'rpm',
+      :package_name => 'path/to/a/el/6/package/puppet-agent-5.3.1.34.gf65f9ef-1.el6.x86_64.rpm',
+      :all_package_names => ['puppet-agent-5.3.1.34.gf65f9ef-1.el6.x86_64.rpm', 'puppet-agent-extras-5.3.1.34.gf65f9ef-1.el6.x86_64.rpm']
+    },
+    'ubuntu-16.04-amd64' => {
+      :toplevel_repo => 'debian__local',
+      :repo_subdirectories => "#{default_repo_name}/#{project}/#{project_version}/ubuntu-16.04",
+      :codename => 'xenial',
+      :arch => 'amd64',
+      :package_name => 'path/to/a/xenial/package/puppet-agent_5.3.1.34.gf65f9ef-1xenial_amd64.deb',
+      :all_package_names => ['puppet-agent_5.3.1.34.gf65f9ef-1xenial_amd64.deb', 'puppet-agent-extras_5.3.1.34.gf65f9ef-1xenial_amd64.deb']
+    },
+    'debian-10-amd64' => {
+      :toplevel_repo => 'debian__local',
+      :repo_subdirectories => "#{default_repo_name}/#{project}/#{project_version}/debian-10",
+      :codename => 'buster',
+      :arch => 'all',
+      :package_name => 'path/to/a/buster/package/puppetdb_5.3.1.34.gf65f9ef-1buster_all.deb',
+      :all_package_names => ['puppetdb_5.3.1.34.gf65f9ef-1buster_all.deb', 'puppetdb-termini_5.3.1.34.gf65f9ef-1buster_all.deb']
+    },
+    'windows-2012-x86' => {
+      :toplevel_repo => 'generic',
+      :repo_subdirectories => "#{default_repo_name}/#{project}/#{project_version}/windows-x86",
+      :package_name => 'path/to/a/windows/package/puppet-agent-5.3.1.34-x86.msi',
+      :all_package_names => ['puppet-agent-5.3.1.34-x86.msi','puppet-agent-extras-5.3.1.34-x86.msi']
+    },
+    'windowsfips-2012-x64' => {
+      :toplevel_repo => 'generic',
+      :repo_subdirectories => "#{default_repo_name}/#{project}/#{project_version}/windowsfips-x64",
+      :package_name => 'path/to/a/windowsfips/package/puppet-agent-5.3.1.34-x64.msi',
+      :all_package_names => ['puppet-agent-5.3.1.34-x64.msi','puppet-agent-extras-5.3.1.34-x64.msi']
+    },
+    'osx-10.15-x86_64' => {
+      :toplevel_repo => 'generic',
+      :repo_subdirectories => "#{default_repo_name}/#{project}/#{project_version}/osx-10.15-x86_64",
+      :package_name => 'path/to/an/osx/10.15/package/puppet-agent-5.3.1.34.gf65f9ef-1.osx10.15.dmg',
+      :all_package_names => ['puppet-agent-5.3.1.34.gf65f9ef-1.osx10.15.dmg', 'puppet-agent-extras-5.3.1.34.gf65f9ef-1.osx10.15.dmg']
+    },
+    'osx-11-x86_64' => {
+      :toplevel_repo => 'generic',
+      :repo_subdirectories => "#{default_repo_name}/#{project}/#{project_version}/osx-11-x86_64",
+      :package_name => 'path/to/an/osx/11/package/puppet-agent-5.3.1.34.gf65f9ef-1.osx11.dmg',
+      :all_package_names => ['puppet-agent-5.3.1.34.gf65f9ef-1.osx11.dmg', 'puppet-agent-extras-5.3.1.34.gf65f9ef-1.osx11.dmg']
+    },
+    'solaris-10-sparc' => {
+      :toplevel_repo => 'generic',
+      :repo_subdirectories => "#{default_repo_name}/#{project}/#{project_version}/solaris-10-sparc",
+      :package_name => 'path/to/a/solaris/10/package/puppet-agent-5.3.1.34.gf65f9ef-1.sparc.pkg.gz',
+      :all_package_names => ['puppet-agent-5.3.1.34.gf65f9ef-1.sparc.pkg.gz']
+    },
+  }
+
+  let(:artifact) { Pkg::ManageArtifactory.new(project, project_version, {:repo_base => default_repo_name, :artifactory_uri => artifactory_uri})}
+
+  around(:each) do |example|
+    original_artifactory_api_key = ENV['ARTIFACTORY_API_KEY']
+    ENV['ARTIFACTORY_API_KEY'] = 'anapikeythatdefinitelyworks'
+    example.run
+    ENV['ARTIFACTORY_API_KEY'] = original_artifactory_api_key
+  end
+
+  platform_tags.each do |platform_tag, platform_tag_data|
+    describe '#location_for' do
+      if platform_tag_data[:codename]
+        it 'returns the expected repo name and paths by default, prepending `pool` for debian-ish platforms' do
+          expect(artifact.location_for(platform_tag)).to match_array([
+            platform_tag_data[:toplevel_repo],
+            platform_tag_data[:repo_subdirectories],
+          ])
+        end
+      else
+        it 'returns the expected repo name and paths by default' do
+          expect(artifact.location_for(platform_tag)).to match_array([
+            platform_tag_data[:toplevel_repo],
+            platform_tag_data[:repo_subdirectories],
+          ])
+        end
+      end
+
+      it 'returns the correct paths for the passed in format' do
+        expect(artifact.location_for('generic')).to match_array([
+          'generic',
+          File.join(default_repo_name, project, project_version),
+        ])
+      end
+    end
+
+    describe '#package_name' do
+      it 'parses the retrieved yaml file and returns the correct package name' do
+        expect(artifact.package_name(platform_data, platform_tag)).to eq(File.basename(platform_tag_data[:package_name]))
+      end
+
+      it 'fails if it cannot find a valid platform name' do
+        new_platform_data = platform_data
+        new_platform_data.delete_if { |k| k.match(platform_tag) }
+        expect{artifact.package_name(new_platform_data, platform_tag)}.to raise_error
+      end
+    end
+
+    describe '#all_package_names' do
+      it 'parses the retrieved yaml file and returns the correct package name' do
+        all_package_names = artifact.all_package_names(platform_data, platform_tag)
+        all_package_names_data = [platform_tag_data[:additional_artifacts], platform_tag_data[:all_package_names]].flatten.compact
+        all_package_names.map! { |p| File.basename(p) }
+        all_package_names_data.map! { |p| File.basename(p) }
+        expect(all_package_names.size).to eq(all_package_names_data.size)
+        expect(all_package_names.sort).to eq(all_package_names_data.sort)
+      end
+
+      it 'fails if it cannot find a valid platform name' do
+        new_platform_data = platform_data
+        new_platform_data.delete_if { |k| k.match(platform_tag) }
+        expect{artifact.package_name(new_platform_data, platform_tag)}.to raise_error
+      end
+    end
+
+    describe '#deb_list_contents' do
+      it "returns the correct contents for the debian list file for #{platform_tag}" do
+        if platform_tag_data[:codename]
+          expect(artifact.deb_list_contents(platform_tag)).to eq("deb #{artifactory_uri}/#{platform_tag_data[:toplevel_repo].chomp('/pool')} #{platform_tag_data[:codename]} #{platform_tag_data[:repo_subdirectories]}")
+        else
+          expect{artifact.deb_list_contents(platform_tag)}.to raise_error
+        end
+      end
+    end
+
+    describe '#rpm_repo_contents' do
+      it "returns the correct contents for the rpm repo file for #{platform_tag}" do
+        if platform_tag_data[:package_format] == 'rpm'
+          expect(artifact.rpm_repo_contents(platform_tag)).to include("baseurl=#{artifactory_uri}\/#{platform_tag_data[:toplevel_repo]}\/#{platform_tag_data[:repo_subdirectories]}")
+        else
+          expect{artifact.rpm_repo_contents(platform_tag)}.to raise_error
+        end
+      end
+    end
+
+    describe '#deploy_properties' do
+      it "returns the correct contents for the deploy properties for #{platform_tag}" do
+        if platform_tag_data[:codename]
+          expect(artifact.deploy_properties(platform_tag, File.basename(platform_tag_data[:package_name]))).to include({
+            'deb.distribution' => platform_tag_data[:codename],
+            'deb.component' => platform_tag_data[:repo_subdirectories],
+            'deb.architecture' => platform_tag_data[:arch]
+          })
+        else
+          expect(artifact.deploy_properties(platform_tag, File.basename(platform_tag_data[:package_name]))).not_to include({
+            'deb.component' => platform_tag_data[:repo_subdirectories]
+          })
+        end
+      end
+    end
+  end
+
+  describe '#check_authorization' do
+    it 'fails gracefully if authorization is not set' do
+      original_artifactory_api_key = ENV['ARTIFACTORY_API_KEY']
+      ENV['ARTIFACTORY_API_KEY'] = nil
+      expect { artifact.deploy_package('path/to/el/7/x86_64/package.rpm') }.to raise_error
+      ENV['ARTIFACTORY_API_KEY'] = original_artifactory_api_key
+    end
+  end
+end