overcommit 0.46.0 → 0.47.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f55e18f8852d00b8732b915daab20a7b37c28e60ee38dd35caacb091e0d87873
-  data.tar.gz: c75636dd8144cb6022b0400d1d5e1615cc1c27e765d32432332ee7b2701b1f66
+  metadata.gz: 5cbfe83620ba468c0053d8303aa80350c50db1fe8a3d90028d0ae2794c219834
+  data.tar.gz: 9f3f6b7d8675cb83e65dc554d9ebe76de0f3287acfcb7f2161c3880ad315ceb9
 SHA512:
-  metadata.gz: d8f0d7599c440d4389d19b94b558292f531d2832adf4846a104e2c033e3f0e12866b2f4febc444690ddc26fd245bd4146ff443c2fab5d49d2b44bec15b5befc8
-  data.tar.gz: 977649b8287f01bb7871db881583eac0490b68687cb1ab671612bb1d41e116b3efe45d39dbdec30909ca8dd49da00a9678674b1d1512c7cf5e35d20e5f2ea99f
+  metadata.gz: a683f507f19caa0ab810b8b7635ddf4672d5daa3b2519090278bbc23da8e7662a3e1d95743dd61f2f12c1f308b1678fec6461c3d54bde8acfa4c89d2d03fc39b
+  data.tar.gz: 0b03b050b2e46d24e8d524de3d0b1b11c895173161d55f9e63224710191419a57f7d7bf8b8ae6e14f6d53f601ac2cecb85dd430e25105588e87b26b244047bc7

data/bin/overcommit

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 # Check if Overcommit should invoke a Bundler context for loading gems
 require 'yaml'

data/config/default.yml

@@ -230,6 +230,16 @@ PreCommit:
     install_command: 'npm install -g coffeelint'
     include: '**/*.coffee'
 
+  CookStyle:
+    enabled: false
+    description: 'Analyze with CookStyle'
+    required_executable: 'cookstyle'
+    flags: ['--format=emacs', '--force-exclusion', '--display-cop-names']
+    install_command: 'gem install cookstyle'
+    include:
+      - '**/*.rb'
+      - '**/*.erb'
+
   Credo:
     enabled: false
     description: 'Analyze with credo'
@@ -424,6 +434,13 @@ PreCommit:
     install_command: 'gem install json'
     include: '**/*.json'
 
+  KtLint:
+    enabled: false
+    description: 'Analyze with KtLint'
+    required_executable: 'ktlint'
+    flags: []
+    include: '**/*.kt'
+
   LicenseFinder:
     enabled: false
     description: 'Analyze with LicenseFinder'
@@ -612,7 +629,7 @@ PreCommit:
     enabled: false
     description: 'Analyze with Reek'
     required_executable: 'reek'
-    flags: ['--single-line', '--no-color']
+    flags: ['--single-line', '--no-color', '--force-exclusion']
     install_command: 'gem install reek'
     include:
       - '**/*.gemspec'
@@ -722,12 +739,27 @@ PreCommit:
       - '**/*.css'
       - '**/*.less'
 
+  SwiftLint:
+    enabled: false
+    description: 'Analyze with SwiftLint'
+    required_executable: 'swiftlint'
+    flags: ['lint', '--strict']
+    install_command: 'brew install swiftlint'
+    include: '**/*.swift'
+
+  TerraformFormat:
+    enabled: false
+    description: 'Analyze with Terraform'
+    required_executable: 'terraform'
+    flags: ['fmt', '-check=true', '-diff=false']
+    include: '**/*.tf'
+
   TsLint:
-      enabled: false
-      description: 'Analyze with TSLint'
-      required_executable: 'tslint'
-      install_command: 'npm install -g tslint typescript'
-      include: '**/*.ts'
+    enabled: false
+    description: 'Analyze with TSLint'
+    required_executable: 'tslint'
+    install_command: 'npm install -g tslint typescript'
+    include: '**/*.ts'
 
   TrailingWhitespace:
     enabled: false
@@ -769,7 +801,7 @@ PreCommit:
     description: 'Analyze with W3C HTML validation service'
     required_library: 'w3c_validators'
     install_command: 'gem install w3c_validators'
-    validator_uri: 'http://validator.w3.org/check'
+    validator_uri: 'https://validator.w3.org/nu'
     charset: 'utf-8'
     doctype: 'HTML5'
     include:
@@ -1143,6 +1175,20 @@ PostRewrite:
       - 'package.json'
       - 'yarn.lock'
 
+# Hooks that run during the `prepare-commit-msg` hook.
+PrepareCommitMsg:
+  ALL:
+    requires_files: false
+    required: false
+    quiet: false
+
+  ReplaceBranch:
+    enabled: false
+    description: 'Prepends the commit message with text based on the branch name'
+    branch_pattern: '\A.*\w+[-_](\d+).*\z'
+    replacement_text: '[#\1]'
+    on_fail: warn
+
 # Hooks that run during `git push`, after remote refs have been updated but
 # before any objects have been transferred.
 PrePush:

data/lib/overcommit.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/os'
 require 'overcommit/constants'
 require 'overcommit/exceptions'

data/lib/overcommit/command_splitter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit
   # Distributes a list of arguments over multiple invocations of a command.
   #

data/lib/overcommit/configuration.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'digest'
 require 'json'
 
@@ -41,7 +43,7 @@ module Overcommit
       @concurrency ||=
         begin
           cores = Overcommit::Utils.processor_count
-          content = @hash.fetch('concurrency', '%<processors>d')
+          content = @hash.fetch('concurrency') { '%<processors>d' }
           if content.is_a?(String)
             concurrency_expr = content % { processors: cores }
 
@@ -154,7 +156,7 @@ module Overcommit
     # environment variables.
     def apply_environment!(hook_context, env)
       skipped_hooks = "#{env['SKIP']} #{env['SKIP_CHECKS']} #{env['SKIP_HOOKS']}".split(/[:, ]/)
-      only_hooks = env.fetch('ONLY', '').split(/[:, ]/)
+      only_hooks = env.fetch('ONLY') { '' }.split(/[:, ]/)
       hook_type = hook_context.hook_class_name
 
       if only_hooks.any? || skipped_hooks.include?('all') || skipped_hooks.include?('ALL')
@@ -252,7 +254,7 @@ module Overcommit
     private
 
     def ad_hoc_hook?(hook_context, hook_name)
-      ad_hoc_conf = @hash.fetch(hook_context.hook_class_name, {}).fetch(hook_name, {})
+      ad_hoc_conf = @hash.fetch(hook_context.hook_class_name) { {} }.fetch(hook_name) { {} }
 
       # Ad hoc hooks are neither built-in nor have a plugin file written but
       # still have a `command` specified to be run
@@ -282,7 +284,7 @@ module Overcommit
           hook_context_or_type.hook_class_name
         end
 
-      individual_enabled = @hash[hook_type].fetch(hook_name, {})['enabled']
+      individual_enabled = @hash[hook_type].fetch(hook_name) { {} }['enabled']
       return individual_enabled unless individual_enabled.nil?
 
       all_enabled = @hash[hook_type]['ALL']['enabled']

data/lib/overcommit/configuration_loader.rb

@@ -65,7 +65,7 @@ module Overcommit
       config = self.class.load_from_file(file, default: false, logger: @log)
       config = self.class.default_configuration.merge(config)
 
-      if @options.fetch(:verify, config.verify_signatures?)
+      if @options.fetch(:verify) { config.verify_signatures? }
         verify_signatures(config)
       end
 

data/lib/overcommit/configuration_validator.rb

@@ -1,4 +1,6 @@
-# rubocop:disable Metrics/ClassLength, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity, Metrics/MethodLength, Metrics/LineLength
+# frozen_string_literal: true
+
+# rubocop:disable Metrics/ClassLength, Metrics/CyclomaticComplexity, Metrics/MethodLength
 module Overcommit
   # Validates and normalizes a configuration.
   class ConfigurationValidator
@@ -57,8 +59,8 @@ module Overcommit
       errors = []
 
       Overcommit::Utils.supported_hook_type_classes.each do |hook_type|
-        hash.fetch(hook_type, {}).each do |hook_name, hook_config|
-          hook_env = hook_config.fetch('env', {})
+        hash.fetch(hook_type) { {} }.each do |hook_name, hook_config|
+          hook_env = hook_config.fetch('env') { {} }
 
           unless hook_env.is_a?(Hash)
             errors << "#{hook_type}::#{hook_name} has an invalid `env` specified: " \
@@ -82,8 +84,10 @@ module Overcommit
       end
 
       if errors.any?
-        @log.error errors.join("\n") if @log
-        @log.newline if @log
+        if @log
+          @log.error errors.join("\n")
+          @log.newline
+        end
         raise Overcommit::Exceptions::ConfigurationError,
               'One or more hooks had an invalid `env` configuration option'
       end
@@ -95,7 +99,7 @@ module Overcommit
       errors = []
 
       Overcommit::Utils.supported_hook_type_classes.each do |hook_type|
-        hash.fetch(hook_type, {}).each_key do |hook_name|
+        hash.fetch(hook_type) { {} }.each_key do |hook_name|
           next if hook_name == 'ALL'
 
           unless hook_name =~ /\A[A-Za-z0-9]+\z/
@@ -107,8 +111,10 @@ module Overcommit
       end
 
       if errors.any?
-        @log.error errors.join("\n") if @log
-        @log.newline if @log
+        if @log
+          @log.error errors.join("\n")
+          @log.newline
+        end
         raise Overcommit::Exceptions::ConfigurationError,
               'One or more hooks had invalid names'
       end
@@ -122,7 +128,7 @@ module Overcommit
       any_warnings = false
 
       Overcommit::Utils.supported_hook_type_classes.each do |hook_type|
-        hash.fetch(hook_type, {}).each do |hook_name, hook_config|
+        hash.fetch(hook_type) { {} }.each do |hook_name, hook_config|
           next if hook_name == 'ALL'
 
           if hook_config['enabled'].nil?
@@ -143,8 +149,8 @@ module Overcommit
 
       errors = []
       Overcommit::Utils.supported_hook_type_classes.each do |hook_type|
-        hash.fetch(hook_type, {}).each do |hook_name, hook_config|
-          processors = hook_config.fetch('processors', 1)
+        hash.fetch(hook_type) { {} }.each do |hook_name, hook_config|
+          processors = hook_config.fetch('processors') { 1 }
           if processors > concurrency
             errors << "#{hook_type}::#{hook_name} `processors` value " \
                       "(#{processors}) is larger than the global `concurrency` " \
@@ -154,8 +160,10 @@ module Overcommit
       end
 
       if errors.any?
-        @log.error errors.join("\n") if @log
-        @log.newline if @log
+        if @log
+          @log.error errors.join("\n")
+          @log.newline
+        end
         raise Overcommit::Exceptions::ConfigurationError,
               'One or more hooks had invalid `processor` value configured'
       end
@@ -175,4 +183,4 @@ module Overcommit
     end
   end
 end
-# rubocop:enable Metrics/ClassLength, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity, Metrics/MethodLength, Metrics/LineLength
+# rubocop:enable Metrics/ClassLength, Metrics/CyclomaticComplexity, Metrics/MethodLength

data/lib/overcommit/exceptions.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Exceptions
   # Raised when a {Configuration} could not be loaded from a file.
   class ConfigurationError < StandardError; end

data/lib/overcommit/git_config.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/utils'
 
 module Overcommit

data/lib/overcommit/git_repo.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'iniparse'
 
 module Overcommit

data/lib/overcommit/git_version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Returns the version of the available git binary.
 #
 # This is intended to be used to conveniently execute code based on a specific

data/lib/overcommit/hook/base.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'forwardable'
 require 'overcommit/message_processor'
 
@@ -42,7 +44,7 @@ module Overcommit::Hook
       if output = check_for_requirements
         status = :fail
       else
-        result = Overcommit::Utils.with_environment(@config.fetch('env', {})) { run }
+        result = Overcommit::Utils.with_environment(@config.fetch('env') { {} }) { run }
         status, output = process_hook_return_value(result)
       end
 
@@ -66,7 +68,7 @@ module Overcommit::Hook
     end
 
     def processors
-      @config.fetch('processors', 1)
+      @config.fetch('processors') { 1 }
     end
 
     def quiet?
@@ -270,9 +272,9 @@ module Overcommit::Hook
     def transform_status(status)
       case status
       when :fail
-        @config.fetch('on_fail', :fail).to_sym
+        @config.fetch('on_fail') { :fail }.to_sym
       when :warn
-        @config.fetch('on_warn', :warn).to_sym
+        @config.fetch('on_warn') { :warn }.to_sym
       else
         status
       end

data/lib/overcommit/hook/commit_msg/base.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'forwardable'
 
 module Overcommit::Hook::CommitMsg

data/lib/overcommit/hook/commit_msg/capitalized_subject.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::CommitMsg
   # Ensures commit message subject lines start with a capital letter.
   class CapitalizedSubject < Base

data/lib/overcommit/hook/commit_msg/empty_message.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::CommitMsg
   # Checks that the commit message is not empty
   class EmptyMessage < Base

data/lib/overcommit/hook/commit_msg/gerrit_change_id.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::CommitMsg
   # Ensures a Gerrit Change-Id line is included in the commit message.
   #

data/lib/overcommit/hook/commit_msg/hard_tabs.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::CommitMsg
   # Checks for hard tabs in commit messages.
   class HardTabs < Base

data/lib/overcommit/hook/commit_msg/message_format.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::CommitMsg
   # Ensures the commit message follows a specific format.
   class MessageFormat < Base

data/lib/overcommit/hook/commit_msg/russian_novel.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::CommitMsg
   # Checks for long commit messages (not good or bad--just fun to point out)
   class RussianNovel < Base

data/lib/overcommit/hook/commit_msg/single_line_subject.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::CommitMsg
   # Ensures commit message subject lines are followed by a blank line.
   class SingleLineSubject < Base

data/lib/overcommit/hook/commit_msg/spell_check.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'tempfile'
 
 module Overcommit::Hook::CommitMsg

data/lib/overcommit/hook/commit_msg/text_width.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::CommitMsg
   # Ensures the number of columns the subject and commit message lines occupy is
   # under the preferred limits.

data/lib/overcommit/hook/commit_msg/trailing_period.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::CommitMsg
   # Ensures commit message subject lines do not have a trailing period
   class TrailingPeriod < Base

data/lib/overcommit/hook/post_checkout/base.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'forwardable'
 
 module Overcommit::Hook::PostCheckout

data/lib/overcommit/hook/post_checkout/bower_install.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/bower_install'
 
 module Overcommit::Hook::PostCheckout

data/lib/overcommit/hook/post_checkout/bundle_install.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/bundle_install'
 
 module Overcommit::Hook::PostCheckout

data/lib/overcommit/hook/post_checkout/composer_install.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/composer_install'
 
 module Overcommit::Hook::PostCheckout