overcommit 0.46.0 → 0.47.0

data/lib/overcommit/hook/pre_commit/haml_lint.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `haml-lint` against any modified HAML files.
   #

data/lib/overcommit/hook/pre_commit/hard_tabs.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Checks for hard tabs in files.
   class HardTabs < Base

data/lib/overcommit/hook/pre_commit/hlint.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `hlint` against any modified Haskell files.
   #

data/lib/overcommit/hook/pre_commit/html_hint.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `htmlhint` against any modified HTML files.
   #

data/lib/overcommit/hook/pre_commit/html_tidy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `tidy` against any modified HTML files.
   #

data/lib/overcommit/hook/pre_commit/image_optim.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Checks for images that can be optimized with `image_optim`.
   #

data/lib/overcommit/hook/pre_commit/java_checkstyle.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `checkstyle` against any modified Java files.
   #

data/lib/overcommit/hook/pre_commit/js_hint.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `jshint` against any modified JavaScript files.
   #

data/lib/overcommit/hook/pre_commit/js_lint.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `jslint` against any modified JavaScript files.
   #

data/lib/overcommit/hook/pre_commit/jscs.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `jscs` (JavaScript Code Style Checker) against any modified JavaScript
   # files.

data/lib/overcommit/hook/pre_commit/jsl.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `jsl` against any modified JavaScript files.
   #

data/lib/overcommit/hook/pre_commit/json_syntax.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Checks the syntax of any modified JSON files.
   class JsonSyntax < Base

data/lib/overcommit/hook/pre_commit/kt_lint.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+module Overcommit::Hook::PreCommit
+  # Runs `ktlint` against modified Kotlin files.
+  # @see https://github.com/shyiko/ktlint
+  class KtLint < Base
+    MESSAGE_REGEX = /((?<file>[^:]+):(?<line>\d+):(\d+):(?<message>.+))/
+
+    def run
+      result = execute(command, args: applicable_files)
+      return :pass if result.success?
+
+      extract_messages(
+        result.stdout.split("\n").grep(MESSAGE_REGEX),
+        MESSAGE_REGEX
+      )
+    end
+  end
+end

data/lib/overcommit/hook/pre_commit/license_finder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs LicenseFinder if any of your package manager declaration files have changed
   # See more about LicenseFinder at https://github.com/pivotal/LicenseFinder

data/lib/overcommit/hook/pre_commit/license_header.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Checks for license headers in source files
   class LicenseHeader < Base

data/lib/overcommit/hook/pre_commit/line_endings.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Checks for line endings in files.
   #

data/lib/overcommit/hook/pre_commit/local_paths_in_gemfile.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Checks for local paths in files and issues a warning
   class LocalPathsInGemfile < Base

data/lib/overcommit/hook/pre_commit/mdl.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `mdl` against any modified Markdown files
   #

data/lib/overcommit/hook/pre_commit/merge_conflicts.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Checks for unresolved merge conflicts
   class MergeConflicts < Base

data/lib/overcommit/hook/pre_commit/nginx_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `nginx -t` against any modified Nginx config files.
   #

data/lib/overcommit/hook/pre_commit/pep257.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `pep257` against any modified Python files.
   #

data/lib/overcommit/hook/pre_commit/pep8.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `pep8` against any modified Python files.
   #

data/lib/overcommit/hook/pre_commit/php_cs.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `phpcs` against any modified PHP files.
   class PhpCs < Base

data/lib/overcommit/hook/pre_commit/php_cs_fixer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `php-cs-fixer` against any modified PHP files.
   class PhpCsFixer < Base

data/lib/overcommit/hook/pre_commit/php_lint.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `php -l` against any modified PHP files.
   class PhpLint < Base

data/lib/overcommit/hook/pre_commit/php_stan.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `phpstan` against any modified PHP files.
   # For running `phpstan` with Laravel, it requires setup with `ide_helper`.

data/lib/overcommit/hook/pre_commit/pronto.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `pronto`
   #

data/lib/overcommit/hook/pre_commit/puppet_lint.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs 'puppet-lint' against any modified Puppet files.
   #

data/lib/overcommit/hook/pre_commit/puppet_metadata_json_lint.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   #
   # Run's the Puppet metadata linter. It has support for adding options

data/lib/overcommit/hook/pre_commit/pycodestyle.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `pycodestyle` against any modified Python files.
   #

data/lib/overcommit/hook/pre_commit/pydocstyle.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `pydocstyle` against any modified Python files.
   #

data/lib/overcommit/hook/pre_commit/pyflakes.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `pyflakes` against any modified Python files.
   #

data/lib/overcommit/hook/pre_commit/pylint.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `pylint` against any modified Python files.
   #

data/lib/overcommit/hook/pre_commit/python_flake8.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `flake8` against any modified Python files.
   #

data/lib/overcommit/hook/pre_commit/rails_best_practices.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit
   module Hook
     module PreCommit

data/lib/overcommit/hook/pre_commit/rails_schema_up_to_date.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Check to see whether the schema file is in line with the migrations. When a
   # schema file is present but a migration file is not, this is usually a

data/lib/overcommit/hook/pre_commit/rake_target.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/rake_target'
 
 module Overcommit::Hook::PreCommit

data/lib/overcommit/hook/pre_commit/reek.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `reek` against any modified Ruby files.
   #

data/lib/overcommit/hook/pre_commit/rst_lint.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `rst-lint` against any modified reStructuredText files
   #

data/lib/overcommit/hook/pre_commit/rubo_cop.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `rubocop` against any modified Ruby files.
   #

data/lib/overcommit/hook/pre_commit/ruby_lint.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `ruby-lint` against any modified Ruby files.
   #

data/lib/overcommit/hook/pre_commit/scalariform.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `scalariform` against any modified Scala files.
   #

data/lib/overcommit/hook/pre_commit/scalastyle.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `scalastyle` against any modified Scala files.
   #

data/lib/overcommit/hook/pre_commit/scss_lint.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `scss-lint` against any modified SCSS files.
   #

data/lib/overcommit/hook/pre_commit/semi_standard.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `semistandard` against any modified JavaScript files.
   #

data/lib/overcommit/hook/pre_commit/shell_check.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `shellcheck` against any modified shell script files.
   #

data/lib/overcommit/hook/pre_commit/slim_lint.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `slim-lint` against any modified Slim templates.
   #

data/lib/overcommit/hook/pre_commit/sqlint.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs 'sqlint' against any modified SQL files.
   #

data/lib/overcommit/hook/pre_commit/standard.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `standard` against any modified JavaScript files.
   #

data/lib/overcommit/hook/pre_commit/stylelint.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `stylelint` against any modified CSS file.
   #

data/lib/overcommit/hook/pre_commit/swift_lint.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+module Overcommit::Hook::PreCommit
+  # Runs `swiftlint lint` against modified Swift files.
+  # @see https://github.com/realm/SwiftLint
+  class SwiftLint < Base
+    MESSAGE_REGEX = /^(?<file>(?:\w:)?[^:]+):(?<line>\d+)[^ ]* (?<type>[^ ]+):(?<message>.*)/
+
+    def run
+      result = execute(command, args: applicable_files)
+      return :pass if result.success?
+
+      extract_messages(
+        result.stdout.split("\n").grep(MESSAGE_REGEX),
+        MESSAGE_REGEX
+      )
+    end
+  end
+end

data/lib/overcommit/hook/pre_commit/terraform_format.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+module Overcommit::Hook::PreCommit
+  # Runs 'terraform fmt' against any modified *.tf files.
+  #
+  # @see https://www.terraform.io/docs/commands/fmt.html
+  class TerraformFormat < Base
+    def run
+      messages = []
+      applicable_files.each do |f|
+        result = execute(command, args: [f])
+        unless result.success?
+          messages << Overcommit::Hook::Message.new(:error, f, nil, "violation found in #{f}")
+        end
+      end
+      messages
+    end
+  end
+end

data/lib/overcommit/hook/pre_commit/trailing_whitespace.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Checks for trailing whitespace in files.
   class TrailingWhitespace < Base

data/lib/overcommit/hook/pre_commit/travis_lint.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `travis-lint` against any modified Travis CI files.
   #

data/lib/overcommit/hook/pre_commit/ts_lint.rb

@@ -1,17 +1,27 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `tslint` against modified TypeScript files.
   # @see http://palantir.github.io/tslint/
   class TsLint < Base
+    # example message:
+    # "src/file/anotherfile.ts[298, 1]: exceeds maximum line length of 140"
+    # or
+    # "ERROR: src/AccountController.ts[4, 28]: expected call-signature to have a typedef"
+    MESSAGE_REGEX = /^(?<type>.+: )?(?<file>.+?(?=\[))[^\d]+(?<line>\d+).*?/
+
     def run
       result = execute(command, args: applicable_files)
       output = result.stdout.chomp
       return :pass if result.success? && output.empty?
 
-      # example message:
-      # src/file/anotherfile.ts[298, 1]: exceeds maximum line length of 140
+      output_lines = output.split("\n").map(&:strip).reject(&:empty?)
+      type_categorizer = ->(type) { type.nil? || type.include?('ERROR') ? :error : :warning }
+
       extract_messages(
-          output.split("\n"),
-          /^(?<file>.+?(?=\[))[^\d]+(?<line>\d+).*?/
+          output_lines,
+          MESSAGE_REGEX,
+          type_categorizer
       )
     end
   end