overcommit 0.46.0 → 0.47.0

data/lib/overcommit/hook/post_checkout/index_tags.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/index_tags'
 
 module Overcommit::Hook::PostCheckout

data/lib/overcommit/hook/post_checkout/npm_install.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/npm_install'
 
 module Overcommit::Hook::PostCheckout

data/lib/overcommit/hook/post_checkout/submodule_status.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/submodule_status'
 
 module Overcommit::Hook::PostCheckout

data/lib/overcommit/hook/post_checkout/yarn_install.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/yarn_install'
 
 module Overcommit::Hook::PostCheckout

data/lib/overcommit/hook/post_commit/base.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'forwardable'
 
 module Overcommit::Hook::PostCommit

data/lib/overcommit/hook/post_commit/bower_install.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/bower_install'
 
 module Overcommit::Hook::PostCommit

data/lib/overcommit/hook/post_commit/bundle_install.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/bundle_install'
 
 module Overcommit::Hook::PostCommit

data/lib/overcommit/hook/post_commit/commitplease.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PostCommit
   # Check that a commit message conforms to a certain style
   #

data/lib/overcommit/hook/post_commit/composer_install.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/composer_install'
 
 module Overcommit::Hook::PostCommit

data/lib/overcommit/hook/post_commit/git_guilt.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PostCommit
   # Calculates the change in blame since the last revision.
   #

data/lib/overcommit/hook/post_commit/index_tags.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/index_tags'
 
 module Overcommit::Hook::PostCommit

data/lib/overcommit/hook/post_commit/npm_install.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/npm_install'
 
 module Overcommit::Hook::PostCommit

data/lib/overcommit/hook/post_commit/submodule_status.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/submodule_status'
 
 module Overcommit::Hook::PostCommit

data/lib/overcommit/hook/post_commit/yarn_install.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/yarn_install'
 
 module Overcommit::Hook::PostCommit

data/lib/overcommit/hook/post_merge/base.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'forwardable'
 
 module Overcommit::Hook::PostMerge

data/lib/overcommit/hook/post_merge/bower_install.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/bower_install'
 
 module Overcommit::Hook::PostMerge

data/lib/overcommit/hook/post_merge/bundle_install.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/bundle_install'
 
 module Overcommit::Hook::PostMerge

data/lib/overcommit/hook/post_merge/composer_install.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/composer_install'
 
 module Overcommit::Hook::PostMerge

data/lib/overcommit/hook/post_merge/index_tags.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/index_tags'
 
 module Overcommit::Hook::PostMerge

data/lib/overcommit/hook/post_merge/npm_install.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/npm_install'
 
 module Overcommit::Hook::PostMerge

data/lib/overcommit/hook/post_merge/submodule_status.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/submodule_status'
 
 module Overcommit::Hook::PostMerge

data/lib/overcommit/hook/post_merge/yarn_install.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/yarn_install'
 
 module Overcommit::Hook::PostMerge

data/lib/overcommit/hook/post_rewrite/base.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'forwardable'
 
 module Overcommit::Hook::PostRewrite

data/lib/overcommit/hook/post_rewrite/bower_install.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/bower_install'
 
 module Overcommit::Hook::PostRewrite

data/lib/overcommit/hook/post_rewrite/bundle_install.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/bundle_install'
 
 module Overcommit::Hook::PostRewrite

data/lib/overcommit/hook/post_rewrite/composer_install.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/composer_install'
 
 module Overcommit::Hook::PostRewrite

data/lib/overcommit/hook/post_rewrite/index_tags.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/index_tags'
 
 module Overcommit::Hook::PostRewrite

data/lib/overcommit/hook/post_rewrite/npm_install.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/npm_install'
 
 module Overcommit::Hook::PostRewrite

data/lib/overcommit/hook/post_rewrite/submodule_status.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/submodule_status'
 
 module Overcommit::Hook::PostRewrite

data/lib/overcommit/hook/post_rewrite/yarn_install.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'overcommit/hook/shared/yarn_install'
 
 module Overcommit::Hook::PostRewrite

data/lib/overcommit/hook/pre_commit/author_email.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Checks the format of an author's email address.
   class AuthorEmail < Base

data/lib/overcommit/hook/pre_commit/author_name.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Ensures that a commit author has a name with at least first and last names.
   class AuthorName < Base

data/lib/overcommit/hook/pre_commit/base.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'forwardable'
 require 'overcommit/utils/messages_utils'
 

data/lib/overcommit/hook/pre_commit/broken_symlinks.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Checks for broken symlinks.
   class BrokenSymlinks < Base

data/lib/overcommit/hook/pre_commit/bundle_audit.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Checks for vulnerable versions of gems in Gemfile.lock.
   #

data/lib/overcommit/hook/pre_commit/bundle_check.rb

@@ -22,7 +22,8 @@ module Overcommit::Hook::PreCommit
 
       new_lockfile = File.read(LOCK_FILE) if File.exist?(LOCK_FILE)
       if previous_lockfile != new_lockfile
-        return :fail, "#{LOCK_FILE} is not up-to-date -- run `#{command.join(' ')}`"
+        return :fail, "#{LOCK_FILE} is not up-to-date -- run \
+        `#{command.join(' ')}` or add the Gemfile and/or Gemfile.lock".squeeze
       end
 
       :pass

data/lib/overcommit/hook/pre_commit/bundle_outdated.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Check if any gems in Gemfile.lock have newer versions, unless the
   # Gemfile.lock is ignored by Git.

data/lib/overcommit/hook/pre_commit/case_conflicts.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Checks for files that would conflict in case-insensitive filesystems
   # Adapted from https://github.com/pre-commit/pre-commit-hooks

data/lib/overcommit/hook/pre_commit/chamber_compare.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `chamber compare` against a configurable set of namespaces.
   #

data/lib/overcommit/hook/pre_commit/chamber_security.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `chamber secure` against any modified Chamber settings files.
   #

data/lib/overcommit/hook/pre_commit/chamber_verification.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `chamber sign --verify`.
   #
@@ -5,7 +7,7 @@ module Overcommit::Hook::PreCommit
   # rubocop:disable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
   class ChamberVerification < Base
     def run
-      approver_name  = config.fetch('approver_name', 'your approver')
+      approver_name  = config.fetch('approver_name') { 'your approver' }
       approver_email = config['approver_email'] ? " (#{config['approver_email']})" : nil
 
       result = execute(command)

data/lib/overcommit/hook/pre_commit/coffee_lint.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `coffeelint` against any modified CoffeeScript files.
   #

data/lib/overcommit/hook/pre_commit/cook_style.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+module Overcommit::Hook::PreCommit
+  # Runs `cookstyle` against any modified Chef Ruby files.
+  #
+  # @see https://docs.chef.io/cookstyle.html
+  class CookStyle < Base
+    GENERIC_MESSAGE_TYPE_CATEGORIZER = lambda do |type|
+      type =~ /^warn/ ? :warning : :error
+    end
+
+    COP_MESSAGE_TYPE_CATEGORIZER = lambda do |type|
+      type.include?('W') ? :warning : :error
+    end
+
+    def run
+      result = execute(command, args: applicable_files)
+      return :pass if result.success?
+
+      generic_messages = extract_messages(
+        result.stderr.split("\n"),
+        /^(?<type>[a-z]+)/i,
+        GENERIC_MESSAGE_TYPE_CATEGORIZER,
+      )
+
+      cop_messages = extract_messages(
+        result.stdout.split("\n"),
+        /^(?<file>(?:\w:)?[^:]+):(?<line>\d+):[^ ]+ (?<type>[^ ]+)/,
+        COP_MESSAGE_TYPE_CATEGORIZER,
+      )
+
+      generic_messages + cop_messages
+    end
+  end
+end

data/lib/overcommit/hook/pre_commit/credo.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `credo` against any modified ex files.
   #

data/lib/overcommit/hook/pre_commit/css_lint.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `csslint` against any modified CSS files.
   #

data/lib/overcommit/hook/pre_commit/dogma.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `dogma` against any modified ex files.
   #

data/lib/overcommit/hook/pre_commit/es_lint.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `eslint` against any modified JavaScript files.
   #

data/lib/overcommit/hook/pre_commit/execute_permissions.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Checks for files with execute permissions, which are usually not necessary
   # in source code files (and are typically caused by a misconfigured editor

data/lib/overcommit/hook/pre_commit/fasterer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `fasterer` against any modified Ruby files.
   #

data/lib/overcommit/hook/pre_commit/fix_me.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Check for "token" strings
   class FixMe < Base

data/lib/overcommit/hook/pre_commit/flay.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `flay` against any modified files.
   #

data/lib/overcommit/hook/pre_commit/foodcritic.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `foodcritic` against any modified Ruby files from Chef directory structure.
   #

data/lib/overcommit/hook/pre_commit/forbidden_branches.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Prevents commits to branches matching one of the configured patterns.
   class ForbiddenBranches < Base

data/lib/overcommit/hook/pre_commit/go_lint.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `golint` against any modified Golang files.
   #

data/lib/overcommit/hook/pre_commit/go_vet.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `go vet` against any modified Golang files.
   #

data/lib/overcommit/hook/pre_commit/hadolint.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Overcommit::Hook::PreCommit
   # Runs `hadolint` against any modified Dockefile files.
   #