RubyGems - osc_machete_rails - Versions diffs - 1.2.0 - Mend

osc_machete_rails 1.2.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (113) hide show

data/test/dummy/public/404.html ADDED Viewed

@@ -0,0 +1,58 @@
+<!DOCTYPE html>
+<html>
+<head>
+  <title>The page you were looking for doesn't exist (404)</title>
+  <style>
+  body {
+    background-color: #EFEFEF;
+    color: #2E2F30;
+    text-align: center;
+    font-family: arial, sans-serif;
+  }
+  div.dialog {
+    width: 25em;
+    margin: 4em auto 0 auto;
+    border: 1px solid #CCC;
+    border-right-color: #999;
+    border-left-color: #999;
+    border-bottom-color: #BBB;
+    border-top: #B00100 solid 4px;
+    border-top-left-radius: 9px;
+    border-top-right-radius: 9px;
+    background-color: white;
+    padding: 7px 4em 0 4em;
+  }
+  h1 {
+    font-size: 100%;
+    color: #730E15;
+    line-height: 1.5em;
+  }
+  body > p {
+    width: 33em;
+    margin: 0 auto 1em;
+    padding: 1em 0;
+    background-color: #F7F7F7;
+    border: 1px solid #CCC;
+    border-right-color: #999;
+    border-bottom-color: #999;
+    border-bottom-left-radius: 4px;
+    border-bottom-right-radius: 4px;
+    border-top-color: #DADADA;
+    color: #666;
+    box-shadow:0 3px 8px rgba(50, 50, 50, 0.17);
+  }
+  </style>
+</head>
+<body>
+  <!-- This file lives in public/404.html -->
+  <div class="dialog">
+    <h1>The page you were looking for doesn't exist.</h1>
+    <p>You may have mistyped the address or the page may have moved.</p>
+  </div>
+  <p>If you are the application owner check the logs for more information.</p>
+</body>
+</html>

data/test/dummy/public/422.html ADDED Viewed

@@ -0,0 +1,58 @@
+<!DOCTYPE html>
+<html>
+<head>
+  <title>The change you wanted was rejected (422)</title>
+  <style>
+  body {
+    background-color: #EFEFEF;
+    color: #2E2F30;
+    text-align: center;
+    font-family: arial, sans-serif;
+  }
+  div.dialog {
+    width: 25em;
+    margin: 4em auto 0 auto;
+    border: 1px solid #CCC;
+    border-right-color: #999;
+    border-left-color: #999;
+    border-bottom-color: #BBB;
+    border-top: #B00100 solid 4px;
+    border-top-left-radius: 9px;
+    border-top-right-radius: 9px;
+    background-color: white;
+    padding: 7px 4em 0 4em;
+  }
+  h1 {
+    font-size: 100%;
+    color: #730E15;
+    line-height: 1.5em;
+  }
+  body > p {
+    width: 33em;
+    margin: 0 auto 1em;
+    padding: 1em 0;
+    background-color: #F7F7F7;
+    border: 1px solid #CCC;
+    border-right-color: #999;
+    border-bottom-color: #999;
+    border-bottom-left-radius: 4px;
+    border-bottom-right-radius: 4px;
+    border-top-color: #DADADA;
+    color: #666;
+    box-shadow:0 3px 8px rgba(50, 50, 50, 0.17);
+  }
+  </style>
+</head>
+<body>
+  <!-- This file lives in public/422.html -->
+  <div class="dialog">
+    <h1>The change you wanted was rejected.</h1>
+    <p>Maybe you tried to change something you didn't have access to.</p>
+  </div>
+  <p>If you are the application owner check the logs for more information.</p>
+</body>
+</html>

data/test/dummy/public/500.html ADDED Viewed

@@ -0,0 +1,57 @@
+<!DOCTYPE html>
+<html>
+<head>
+  <title>We're sorry, but something went wrong (500)</title>
+  <style>
+  body {
+    background-color: #EFEFEF;
+    color: #2E2F30;
+    text-align: center;
+    font-family: arial, sans-serif;
+  }
+  div.dialog {
+    width: 25em;
+    margin: 4em auto 0 auto;
+    border: 1px solid #CCC;
+    border-right-color: #999;
+    border-left-color: #999;
+    border-bottom-color: #BBB;
+    border-top: #B00100 solid 4px;
+    border-top-left-radius: 9px;
+    border-top-right-radius: 9px;
+    background-color: white;
+    padding: 7px 4em 0 4em;
+  }
+  h1 {
+    font-size: 100%;
+    color: #730E15;
+    line-height: 1.5em;
+  }
+  body > p {
+    width: 33em;
+    margin: 0 auto 1em;
+    padding: 1em 0;
+    background-color: #F7F7F7;
+    border: 1px solid #CCC;
+    border-right-color: #999;
+    border-bottom-color: #999;
+    border-bottom-left-radius: 4px;
+    border-bottom-right-radius: 4px;
+    border-top-color: #DADADA;
+    color: #666;
+    box-shadow:0 3px 8px rgba(50, 50, 50, 0.17);
+  }
+  </style>
+</head>
+<body>
+  <!-- This file lives in public/500.html -->
+  <div class="dialog">
+    <h1>We're sorry, but something went wrong.</h1>
+  </div>
+  <p>If you are the application owner check the logs for more information.</p>
+</body>
+</html>

data/test/dummy/public/favicon.ico ADDED Viewed

File without changes

data/test/dummy/tmp/cache/assets/test/sprockets/0ff4cb4a6c217771a1336b307c51cf4e ADDED Viewed

Binary file

data/test/dummy/tmp/cache/assets/test/sprockets/13fe41fee1fe35b49d145bcc06610705 ADDED Viewed

Binary file

data/test/dummy/tmp/cache/assets/test/sprockets/2f5173deea6c795b8fdde723bb4b63af ADDED Viewed

Binary file

data/test/dummy/tmp/cache/assets/test/sprockets/357970feca3ac29060c1e3861e2c0953 ADDED Viewed

Binary file

data/test/dummy/tmp/cache/assets/test/sprockets/57261b7c75c19be33229517e39e47528 ADDED Viewed

Binary file

data/test/dummy/tmp/cache/assets/test/sprockets/9e1e594361ba2561e5f6011db99503bb ADDED Viewed

Binary file

data/test/dummy/tmp/cache/assets/test/sprockets/cffd775d018f68ce5dba1ee0d951a994 ADDED Viewed

Binary file

data/test/dummy/tmp/cache/assets/test/sprockets/d771ace226fc8215a3572e0aa35bb0d6 ADDED Viewed

Binary file

data/test/dummy/tmp/cache/assets/test/sprockets/dc292ec300d07016ebcc2de4806208c3 ADDED Viewed

Binary file

data/test/dummy/tmp/cache/assets/test/sprockets/f7cbd26ba1d28d48de824f0e94586655 ADDED Viewed

Binary file

data/test/integration/error_handling_test.rb ADDED Viewed

@@ -0,0 +1,166 @@
+require 'test_helper'
+class ErrorHandlingTest < ActionDispatch::IntegrationTest
+  # these tests are for
+  def setup
+    setup_torquehelper
+    # FIXME: better to create simulations from doing a request to post a new sim
+    @sim = Simulation.create
+    @tmpdir = Dir.mktmpdir
+    @empty_template = Pathname.new(@tmpdir + "/template")
+    FileUtils.mkdir(@empty_template.to_s)
+    @empty_template = @empty_template.realpath
+    # so Workflow#ood_dataroot is set
+    ENV['OOD_DATAROOT'] = @tmpdir
+  end
+  def setup_torquehelper
+    # defaults
+    OSC::Machete::TorqueHelper.any_instance.unstub(:qstat)
+    OSC::Machete::TorqueHelper.any_instance.unstub(:qdel)
+    OSC::Machete::TorqueHelper.any_instance.unstub(:qsub)
+    # use subclasses of PBS::Error
+    OSC::Machete::TorqueHelper.any_instance.stubs(:qstat).raises(PBS::SystemError, "The system is down!")
+    OSC::Machete::TorqueHelper.any_instance.stubs(:qdel).raises(PBS::BadhostError, "The system is down!")
+    OSC::Machete::TorqueHelper.any_instance.stubs(:qsub).raises(PBS::BadatvalError, "The system is down!")
+  end
+  def teardown
+    @sim.delete
+    FileUtils.rm_rf @tmpdir
+  end
+  def simulations_dir_empty?
+    Dir[@tmpdir+'/*'].empty? || Dir[@tmpdir+'/simulations/*'].empty?
+  end
+  def test_handle_missing_script_error_on_submit
+    # stub to an empty template to trigger ScriptMissingError
+    Simulation.any_instance.stubs(:staging_template_dir).returns(@empty_template)
+    # sanity check
+    assert_equal 1, Simulation.count, "Sanity check failed"
+    assert simulations_dir_empty?, "Sanity check failed"
+    assert @empty_template.directory?, "Sanity check failed"
+    # now we should be able to try to submit the simulation, that needs main.sh but doesn't have it
+    put "/simulations/#{@sim.id}/submit"
+    assert_response 500
+    # verify an error message was attached to the simulation object
+    assert assigns(:simulation).errors.to_a.any?
+    assert assigns(:simulation).errors.to_a.first =~ /ScriptMissingError/, "Should have thrown ScriptMissingError"
+    assert simulations_dir_empty?, 'If submitting a simulation fails, the staged directory should be deleted.'
+    Simulation.any_instance.unstub(:staging_template_dir)
+  end
+  def test_handle_pbs_error_on_submit
+    # sanity check
+    assert_equal 1, Simulation.count, "Sanity check failed"
+    assert simulations_dir_empty?, "Sanity check failed"
+    # now we should be able to try to submit a simulation
+    put "/simulations/#{@sim.id}/submit"
+    assert_response 500
+    # verify an error message was attached to the simulation object
+    assert assigns(:simulation).errors.to_a.any?
+    assert assigns(:simulation).errors.to_a.first =~ /PBS::Error/, "Should have thrown PBS::Error"
+    assert simulations_dir_empty?, 'If submitting a simulation fails, the staged directory should be deleted.'
+  end
+  def test_handle_qstat_error_on_submit
+    OSC::Machete::TorqueHelper.any_instance.stubs(:qsub).returns("123456.oakley.osc.edu")
+    put "/simulations/#{@sim.id}/submit"
+    assert_response :found
+    # submission succeeded, but qdel failed!
+    assert Simulation.find(@sim.id).status.queued?
+    assert Simulation.find(@sim.id).simulation_jobs.count == 1
+    # reset
+    setup_torquehelper
+  end
+  def test_update_status_handles_qstat_error
+    @s1 = SimulationJob.create status: OSC::Machete::Status.queued, pbsid: "1"
+    @s2 = SimulationJob.create status: OSC::Machete::Status.queued, pbsid: "2"
+    @s3 = SimulationJob.create status: OSC::Machete::Status.queued, pbsid: "3"
+    # new
+    OSC::Machete::TorqueHelper.any_instance.stubs(:qstat).with("1", any_parameters).returns(OSC::Machete::Status.running)
+    OSC::Machete::TorqueHelper.any_instance.stubs(:qstat).with("2", any_parameters).raises(PBS::Error, "The system is down!")
+    OSC::Machete::TorqueHelper.any_instance.stubs(:qstat).with("3", any_parameters).returns(OSC::Machete::Status.passed)
+    get "/simulations"
+    # @s2 is queued and qstat will throw an error so it should just stay queued
+    # the others should be updated
+    assert_equal OSC::Machete::Status.running, SimulationJob.find(@s1.id).status
+    assert_equal OSC::Machete::Status.queued, SimulationJob.find(@s2.id).status
+    assert_equal OSC::Machete::Status.passed, SimulationJob.find(@s3.id).status
+    @s1.delete
+    @s2.delete
+    @s3.delete
+    # reset
+    setup_torquehelper
+  end
+  def test_delete_running_simulation_fails
+    OSC::Machete::TorqueHelper.any_instance.stubs(:qsub).returns("123456.oakley.osc.edu")
+    OSC::Machete::TorqueHelper.any_instance.stubs(:qstat).returns(OSC::Machete::Status.running)
+    put "/simulations/#{@sim.id}/submit"
+    assert_response :found
+    # verify we its running now
+    assert Simulation.find(@sim.id).status.running?
+    assert Simulation.find(@sim.id).simulation_jobs.count == 1
+    @job = @sim.simulation_jobs.first
+    # delete a running simulation
+    delete "/simulations/#{@sim.id}"
+    # delete threw error, so nothing should have happened
+    assert SimulationJob.find(@job.id).status.running?
+    assert Simulation.find(@sim.id).status.running?
+    assert Simulation.find(@sim.id).simulation_jobs.count == 1
+    assert_response 500
+    # verify an error message was attached to the simulation object
+    assert assigns(:simulation).errors.to_a.any?
+    assert assigns(:simulation).errors.to_a.first =~ /PBS::Error/, "Should have thrown PBS::Error"
+    OSC::Machete::TorqueHelper.any_instance.stubs(:qdel).returns(nil)
+    # delete simulation now that "the system is fixed"
+    delete "/simulations/#{@sim.id}"
+    # delete threw error, so nothing should have happened
+    assert ! SimulationJob.where(id: @job.id).any?
+    assert ! Simulation.where(id: @sim.id).any?
+    assert_response :found
+    # reset
+    setup_torquehelper
+  end
+end

data/test/integration/statusable_update_status_test.rb ADDED Viewed

@@ -0,0 +1,47 @@
+require 'test_helper'
+class StatusableUpdateStatusTest < ActionDispatch::IntegrationTest
+  fixtures :all
+  def setup
+    # FIXME: better to create simulations from doing a request to post a new sim
+    @sims = []
+    @sims << SimulationJob.create(status: OSC::Machete::Status.passed, pbsid: "123")
+    @sims << SimulationJob.create(status: OSC::Machete::Status.not_submitted, pbsid: "124")
+    @sims << SimulationJob.create(status: OSC::Machete::Status.queued, pbsid: "125")
+    @sims << SimulationJob.create(status: OSC::Machete::Status.running, pbsid: "126")
+    @sims << SimulationJob.create(status: OSC::Machete::Status.queued, pbsid: "127")
+  end
+  def teardown
+    # delete will avoid calling the destroy callbacks like "stop" i.e. qdel
+    @sims.each(&:delete)
+  end
+  def test_update_models_on_index_request
+    # 1. setup database and torque helper with jobs so that two jobs that are
+    # cached as queued and running are actually running and passed
+    OSC::Machete::TorqueHelper.any_instance.stubs(:qstat).returns(OSC::Machete::Status.passed)
+    # if a test below suddenly returns "Passed" instead of running it might be
+    # because the signature of qstat or the arguments Job#status is passing to
+    # these by default are different.
+    OSC::Machete::TorqueHelper.any_instance.stubs(:qstat).with("125", any_parameters).returns(OSC::Machete::Status.running)
+    OSC::Machete::TorqueHelper.any_instance.stubs(:qstat).with("127", any_parameters).returns(OSC::Machete::Status.queued)
+    # FIXME: move to a controller test?
+    assert_equal @sims.length, SimulationJob.count, "Test database is not cleaned up after each test is run"
+    # 2. when doing a get request, the active jobs should be updated
+    get "/simulations"
+    assert_response :success
+    # 3. we verify the modifications to the active jobs took place
+    assert_equal OSC::Machete::Status.passed, SimulationJob.where(pbsid: "123").first.status
+    assert_equal OSC::Machete::Status.not_submitted, SimulationJob.where(pbsid: "124").first.status
+    assert_equal OSC::Machete::Status.running, SimulationJob.where(pbsid: "125").first.status
+    assert_equal OSC::Machete::Status.passed, SimulationJob.where(pbsid: "126").first.status
+    assert_equal OSC::Machete::Status.queued, SimulationJob.where(pbsid: "127").first.status
+  end
+end

data/test/models/simulation_test.rb ADDED Viewed

@@ -0,0 +1,4 @@
+require 'test_helper'
+class SimulationTest < ActiveSupport::TestCase
+end

data/test/osc_machete_rails_test.rb ADDED Viewed

@@ -0,0 +1,7 @@
+require 'test_helper'
+class OscMacheteRailsTest < ActiveSupport::TestCase
+  test "truth" do
+    assert_kind_of Module, OscMacheteRails
+  end
+end

data/test/test_helper.rb ADDED Viewed

@@ -0,0 +1,19 @@
+# Configure Rails Environment
+ENV["RAILS_ENV"] = "test"
+ENV["RAILS_DATAROOT"] = "/dev/null"
+require File.expand_path("../dummy/config/environment.rb",  __FILE__)
+require "rails/test_help"
+# dependencies that dummy app depends on
+require "bootstrap_form"
+Rails.backtrace_cleaner.remove_silencers!
+# Load support files
+Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
+# Load fixtures from the engine
+if ActiveSupport::TestCase.method_defined?(:fixture_path=)
+  ActiveSupport::TestCase.fixture_path = File.expand_path("../fixtures", __FILE__)
+end

data/test/unit/statusable_test.rb ADDED Viewed

@@ -0,0 +1,124 @@
+require 'minitest/autorun'
+require 'osc/machete'
+class StatusableTest < Minitest::Unit::TestCase
+  # FIXME: the problem here: we are extending, not including, so
+  # Statusable#included never called
+  #
+  # Change the tests to do this appropriately!
+  # Or just use a dummy object SimulationJob
+  def setup
+    @job = SimulationJob.create(pbsid: "123456.oak-batch.osc.edu", job_path: "/path/to/tmp", script_name: "test.sh")
+    @job_without_script_name = SimulationJob.create(pbsid: "123456.oak-batch.osc.edu", job_path: "/path/to/tmp")
+  end
+  def teardown
+    @job.delete
+    @job_without_script_name.delete
+  end
+  # verify both of these calls work without crashing
+  def test_job_getter_works
+    assert_equal "test.sh", @job.job.script_name
+    assert_nil @job_without_script_name.job.script_name
+  end
+  # if calling status returns :Q for Queued, make sure this
+  def test_status_sym
+    @job.status = nil
+    assert ! @job.submitted?
+    assert @job.not_submitted?
+    @job.status = :Q
+    assert @job.submitted?
+    assert ! @job.completed?
+    assert @job.active?
+    assert_equal "Queued", @job.status.to_s
+    @job.status = :R
+    assert @job.active?
+    assert_equal "Running", @job.status.to_s
+    @job.status = :C
+    assert @job.completed?, "completed? should return true when status is C"
+    assert ! @job.failed?, "failed? should return false when status is not F"
+    @job.status = :F
+    assert @job.completed?, "completed? should return true when status is F"
+    assert ! @job.passed?, "passed? should return false when status is F"
+    assert @job.failed?, "failed? should return true when status is F"
+  end
+  def test_status_str
+    @job.status = "Q"
+    assert @job.submitted?
+    assert ! @job.completed?
+    assert @job.active?
+    assert_equal "Queued", @job.status.to_s
+    @job.status = "R"
+    assert @job.active?
+    assert_equal "Running", @job.status.to_s
+    @job.status = "C"
+    assert @job.completed?, "completed? should return true when status is C"
+    assert ! @job.failed?, "failed? should return false when status is not F"
+    @job.status = "F"
+    assert @job.completed?, "completed? should return true when status is F"
+    assert ! @job.passed?, "passed? should return false when status is F"
+    assert @job.failed?, "failed? should return true when status is F"
+  end
+  def test_results_valid_hook_called
+    OSC::Machete::Job.any_instance.stubs(:status).returns(OSC::Machete::Status.passed)
+    @job.status = "R"
+    @job.expects(:"results_valid?").at_least_once
+    @job.update_status!
+    # sometimes, qstat returns "C": still call the hook!
+    assert_equal OSC::Machete::Status.passed, @job.job.status
+    @job.status = "R"
+    @job.expects(:"results_valid?").at_least_once
+    @job.update_status!
+    # but if the status is completed we don't want the hook to run again
+    @job.expects(:"results_valid?").never
+    @job.status = "C"
+    @job.update_status!
+  end
+  # if status is R but also saved record is also R we shouldn't save
+  def test_save_after_update_when_status_returns_symbol
+    OSC::Machete::Job.any_instance.stubs(:status).returns(OSC::Machete::Status.running)
+    assert OSC::Machete::Status.running, @job.job.status
+    @job.expects(:"save").never
+    @job.status = "R"
+    @job.update_status!
+    @job.expects(:"save").at_least_once
+    @job.status = "Q"
+    @job.update_status!
+  end
+  def test_update_status_with_not_submitted_with_pbsid
+    OSC::Machete::Job.any_instance.stubs(:status).returns(OSC::Machete::Status.running)
+    @job.expects(:"save").at_least_once
+    @job.status = nil
+    @job.update_status!
+  end
+  def test_update_status_with_not_submitted_without_pbsid
+    OSC::Machete::Job.any_instance.stubs(:status).returns(OSC::Machete::Status.running)
+    @job.expects(:"save").never
+    @job.pbsid = nil
+    @job.status = nil
+    @job.update_status!
+  end
+end