openvox-lint 1.0.7 → 1.3.0

data/lib/openvox-lint/plugins/checks/resource_reference_without_title_capital.rb

@@ -3,6 +3,21 @@
 # Resource reference titles must start with a capital letter.
 # e.g. File['/tmp/foo'] not file['/tmp/foo']
 OpenvoxLint.new_check(:resource_reference_without_title_capital) do
+  # Puppet built-in functions and common stdlib functions that accept
+  # bracket/index syntax (name[...]).  These are NOT resource
+  # references and must not be flagged.
+  FUNCTION_ALLOWLIST = %w[
+    split join include contain require
+    each map filter reduce select reject
+    slice flatten any all empty
+    assert_type create_resources defined dig
+    ensure_packages ensure_resource epp fail
+    fqdn_rand generate hiera hiera_array hiera_hash hiera_include
+    inline_epp inline_template lookup match md5 notice
+    realize regsubst sha1 sprintf tag template unique versioncmp
+    with
+  ].freeze
+
   def check
     sem = semantic_tokens
     sem.each_with_index do |tok, i|
@@ -11,8 +26,8 @@ OpenvoxLint.new_check(:resource_reference_without_title_capital) do
       next unless sem[i + 1].type == :LBRACK
       # This is name[...] which should be Name[...] for a resource reference
       next if tok.value =~ /\A[A-Z]/
-      # Skip function calls and normal array access
-      next if %w[split join include contain require].include?(tok.value)
+      # Skip function calls, method calls, and normal array access
+      next if FUNCTION_ALLOWLIST.include?(tok.value)
       notify :warning,
         message: "resource reference '#{tok.value}' must start with a capital letter",
         line: tok.line, column: tok.column

data/lib/openvox-lint/plugins/checks/single_quote_string_with_variables.rb

@@ -13,4 +13,20 @@ OpenvoxLint.new_check(:single_quote_string_with_variables) do
         line: tok.line, column: tok.column
     end
   end
+
+  # --fix support: swap outer single quotes to double (may require manual
+  # review for literal $ or inner quotes per style exceptions).
+  def fix(problem)
+    idx = problem[:line] - 1
+    line = @manifest_lines[idx].dup
+    col = (problem[:column] || 1) - 1
+    if line[col] == "'"
+      end_col = line.index("'", col + 1)
+      if end_col
+        inner = line[(col + 1)...end_col]
+        line[col..end_col] = '"' + inner + '"'
+        @manifest_lines[idx] = line
+      end
+    end
+  end
 end

data/lib/openvox-lint/plugins/checks/top_scope_facts.rb

@@ -6,7 +6,9 @@ OpenvoxLint.new_check(:top_scope_facts) do
   def check
     tokens.each do |tok|
       next unless tok.type == :VARIABLE
-      name = tok.value.sub(/^\$/, '')
+      # Strip leading $ and any trailing : left by the lexer when a
+      # variable is used as a resource title ($::fact:).
+      name = tok.value.sub(/^\$/, '').chomp(':')
       next unless name.start_with?('::')
       fact_name = name.sub(/\A::/, '')
       # Skip module-qualified variables (e.g. ::mymodule::param)

data/lib/openvox-lint/plugins/checks/trailing_comma.rb

@@ -1,24 +1,30 @@
 # frozen_string_literal: true
 
 # Resource bodies and parameter lists should end with a trailing comma.
+#
+# Only fires inside resource bodies (NAME { ... }) — not inside
+# conditionals (if/unless/case), class bodies, or other brace contexts
+# where a trailing comma is not expected.
 OpenvoxLint.new_check(:trailing_comma) do
   def check
-    tokens.each_with_index do |tok, i|
-      next unless tok.type == :RBRACE || tok.type == :RPAREN
-      # Find the previous non-whitespace token
-      j = i - 1
-      j -= 1 while j >= 0 && tokens[j].formatting?
-      next if j < 0
-      prev = tokens[j]
-      # Skip if previous is opening brace/paren (empty block) or already a comma
-      next if %i[LBRACE LPAREN COMMA RBRACE].include?(prev.type)
-      # Only flag inside parameter lists and resource bodies
-      next unless prev.type == :SSTRING || prev.type == :STRING || prev.type == :NAME ||
-                  prev.type == :VARIABLE || prev.type == :NUMBER || prev.type == :TRUE ||
-                  prev.type == :FALSE || prev.type == :CLASSREF || prev.type == :RBRACK
+    resource_indexes.each do |res|
+      params = res[:param_tokens]
+      next if params.empty?
+
+      # Find the last non-formatting token in the resource body
+      last = params.reverse_each.find { |t| !t.formatting? }
+      next unless last
+
+      # Already has a trailing comma — nothing to do
+      next if last.type == :COMMA
+
+      # Only flag after value-like tokens (not structural tokens)
+      next unless %i[SSTRING STRING NAME VARIABLE NUMBER TRUE FALSE
+                     CLASSREF RBRACK DQSTRING].include?(last.type)
+
       notify :warning,
         message: 'missing trailing comma after last attribute',
-        line: prev.line, column: prev.column
+        line: last.line, column: last.column
     end
   end
 end

data/lib/openvox-lint/plugins/checks/trailing_whitespace.rb

@@ -11,4 +11,10 @@ OpenvoxLint.new_check(:trailing_whitespace) do
         column: line.rstrip.length + 1
     end
   end
+
+  # --fix support: strip trailing whitespace from the offending line.
+  def fix(problem)
+    idx = problem[:line] - 1
+    @manifest_lines[idx] = @manifest_lines[idx].rstrip
+  end
 end

data/lib/openvox-lint/plugins/checks/variables_not_enclosed.rb

@@ -2,18 +2,24 @@
 
 # Variables in double-quoted strings should be enclosed in braces.
 # e.g. "$foo" should be "${foo}"
+#
+# Correctly handles strings with a mix of enclosed and unenclosed
+# variables — e.g. "$foo and ${bar}" flags the unenclosed $foo even
+# though ${bar} is properly enclosed.
 OpenvoxLint.new_check(:variables_not_enclosed) do
   def check
     tokens.each do |tok|
       next unless tok.type == :DQSTRING || tok.type == :STRING
       val = tok.value
-      # Look for $var not followed by { inside double-quoted strings
-      next unless val =~ /\$([a-zA-Z_][a-zA-Z0-9_:]*)/
-      next if val =~ /\$\{/  # already enclosed
-      notify :warning,
-        message: 'variable not enclosed in braces within string',
-        line: tok.line,
-        column: tok.column
+      # Scan for any $var that is NOT preceded by ${ (already enclosed).
+      # We use a negative lookbehind to skip ${...} patterns and only
+      # match bare $varname references.
+      val.scan(/(?<!\$)\$(?!\{)([a-zA-Z_][a-zA-Z0-9_:]*)/) do
+        notify :warning,
+          message: 'variable not enclosed in braces within string',
+          line: tok.line,
+          column: tok.column
+      end
     end
   end
 end

data/lib/openvox-lint/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module OpenvoxLint
-  VERSION = '1.0.7'
+  VERSION = '1.3.0'
 end

data/lib/openvox-lint.rb

@@ -29,11 +29,21 @@ module OpenvoxLint
       yield(configuration)
     end
 
+    # Reset the global configuration singleton.  Called at the start of
+    # every CLI run so that repeated invocations in the same Ruby
+    # process (Vim plugins, guard, Rake loops) start clean.
+    def reset_configuration!
+      @configuration = Configuration.new
+    end
+
     def checks
       @checks ||= {}
     end
 
     def new_check(name, &block)
+      if checks.key?(name)
+        $stderr.puts "openvox-lint: warning: check '#{name}' is already registered — overwriting" if ENV['OPENVOX_LINT_DEBUG']
+      end
       klass = Class.new(CheckPlugin, &block)
       klass.instance_variable_set(:@check_name, name)
       checks[name] = klass

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: openvox-lint
 version: !ruby/object:Gem::Version
-  version: 1.0.7
+  version: 1.3.0
 platform: ruby
 authors:
 - Jerald Sheets
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-02-27 00:00:00.000000000 Z
+date: 2026-05-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -53,10 +53,15 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.50'
 description: |
-  openvox-lint is a linter for OpenVox and Puppet manifests. It checks your
-  code against the Puppet style guide and catches common errors including
-  deprecated patterns, legacy facts, strict mode violations, and Puppet 8+
-  language issues. Fully compatible with OpenVox 8.x and Puppet 8.x.
+  openvox-lint is a modern style-guide linter for OpenVox and Puppet manifests.
+  It checks your .pp files against the OpenVox Language Style Guide (the
+  current canonical reference) and catches common errors, deprecated patterns
+  (legacy facts, Hiera 3, import, etc.), strict-mode issues, and Puppet 8+ /
+  OpenVox 8.x problems. Includes real --fix support for many checks.
+
+  Fully compatible with OpenVox 8.x and Puppet 8.x. Drop-in replacement for
+  the archived puppet-lint with better Ruby 2.5+ support and OpenVox-specific
+  checks.
 email:
 - jsheets@xai.com
 executables:
@@ -99,7 +104,6 @@ files:
 - lib/openvox-lint/plugins/checks/parameter_order.rb
 - lib/openvox-lint/plugins/checks/puppet_url_without_modules.rb
 - lib/openvox-lint/plugins/checks/quoted_booleans.rb
-- lib/openvox-lint/plugins/checks/relative_classname_inclusion.rb
 - lib/openvox-lint/plugins/checks/resource_reference_without_title_capital.rb
 - lib/openvox-lint/plugins/checks/selector_inside_resource.rb
 - lib/openvox-lint/plugins/checks/single_quote_string_with_variables.rb
@@ -124,9 +128,9 @@ metadata:
   homepage_uri: https://github.com/cvquesty/openvox-lint
   source_code_uri: https://github.com/cvquesty/openvox-lint
   bug_tracker_uri: https://github.com/cvquesty/openvox-lint/issues
-  changelog_uri: https://github.com/cvquesty/openvox-lint/blob/main/CHANGELOG.md
+  changelog_uri: https://github.com/cvquesty/openvox-lint/blob/development/CHANGELOG.md
   rubygems_mfa_required: 'true'
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -142,7 +146,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.0.3.1
-signing_key: 
+signing_key:
 specification_version: 4
-summary: Check OpenVox/Puppet manifests against the style guide
+summary: Check OpenVox/Puppet manifests against the OpenVox Language Style Guide
 test_files: []

data/lib/openvox-lint/plugins/checks/relative_classname_inclusion.rb

@@ -1,24 +0,0 @@
-# frozen_string_literal: true
-
-# Use absolute class names in include/require/contain statements.
-OpenvoxLint.new_check(:relative_classname_inclusion) do
-  INCLUDE_FUNCS = %w[include require contain].freeze
-
-  def check
-    sem = semantic_tokens
-    sem.each_with_index do |tok, i|
-      next unless tok.type == :NAME && INCLUDE_FUNCS.include?(tok.value)
-      j = i + 1
-      next if j >= sem.length
-      name_tok = sem[j]
-      next unless name_tok.type == :NAME || name_tok.type == :SSTRING || name_tok.type == :STRING
-      class_name = name_tok.value.gsub(/['"]/, '')
-      next if class_name.start_with?('::') || class_name.empty?
-      # Single-segment names are OK (they're unambiguous)
-      next unless class_name.include?('::')
-      notify :warning,
-        message: "class name '#{class_name}' should be fully qualified (start with ::)",
-        line: name_tok.line, column: name_tok.column
-    end
-  end
-end