openvox-lint 1.0.7 → 1.3.0

data/README.md

@@ -1,14 +1,15 @@
 # openvox-lint
 
-![Version](https://img.shields.io/badge/version-1.0.7-blue)
+[![Gem Version](https://img.shields.io/gem/v/openvox-lint)](https://rubygems.org/gems/openvox-lint)
+[![Gem Downloads](https://img.shields.io/gem/dt/openvox-lint)](https://rubygems.org/gems/openvox-lint)
 ![Ruby](https://img.shields.io/badge/ruby-%E2%89%A5%202.5-red)
 ![License](https://img.shields.io/badge/license-Apache%202.0-blue)
-![Checks](https://img.shields.io/badge/built--in%20checks-38-brightgreen)
+![Checks](https://img.shields.io/badge/built--in%20checks-37-brightgreen)
 ![Status](https://img.shields.io/badge/status-stable-brightgreen)
 
 **A style-guide linter for OpenVox and Puppet manifests.**
 
-openvox-lint checks your `.pp` manifest files against the [Puppet Style Guide](https://puppet.com/docs/puppet/latest/style_guide.html) and catches common errors, deprecated patterns, legacy facts, strict-mode violations, and Puppet 8+ / OpenVox 8.x language issues.
+openvox-lint checks your `.pp` manifest files against the [OpenVox Language Style Guide](https://docs.openvoxproject.org/openvox/latest/style_guide.html) (and Puppet equivalent) and catches common errors, deprecated patterns, legacy facts, strict-mode violations, and Puppet 8+ / OpenVox 8.x language issues.
 
 Fully compatible with:
 - **OpenVox 8.x** (the community-maintained open-source fork of Puppet)
@@ -24,7 +25,7 @@ Fully compatible with:
 - [Quick Start](#quick-start)
 - [Usage](#usage)
 - [Enabling and Disabling Checks](#enabling-and-disabling-checks)
-- [Built-in Checks (38)](#built-in-checks)
+- [Built-in Checks (37)](#built-in-checks)
 - [Configuration](#configuration)
 - [Output Formats](#output-formats)
 - [Integration](#integration)
@@ -32,6 +33,7 @@ Fully compatible with:
 - [Updating](#updating)
 - [Uninstalling](#uninstalling)
 - [Development](#development)
+- [Contributors](#contributors)
 - [License](#license)
 
 ---
@@ -158,6 +160,27 @@ openvox-lint -f github manifests/
 openvox-lint --fail-on-warnings manifests/
 ```
 
+### Fix mode (`--fix`)
+
+`--fix` automatically corrects problems for the checks that implement fix logic. Fixes are applied in-place and are safe for the supported cases.
+
+Currently supported checks:
+- `trailing_whitespace` — removes trailing spaces/tabs
+- `hard_tabs` — converts tabs to two spaces
+- `quoted_booleans` — changes `'true'` / `'false'` (strings) to unquoted booleans
+- `double_quoted_strings` — converts unnecessary double-quoted strings (no interpolation or escapes) to single quotes
+- `single_quote_string_with_variables` — converts single-quoted strings containing `$variables` to double quotes so interpolation works
+
+Example:
+
+```bash
+openvox-lint --fix manifests/
+# or
+openvox-lint --fix .
+```
+
+After running, re-lint to confirm. Complex structural fixes (e.g. arrow alignment) are not yet implemented.
+
 ---
 
 ## Enabling and Disabling Checks
@@ -181,7 +204,7 @@ openvox-lint --no-line_length-check --no-arrow_alignment-check --no-strict_inden
 Use `--only-checks` to run *only* the checks you specify (everything else is skipped):
 
 ```bash
-# Only check for legacy facts and hiera3 usage
+# Only check for legacy facts and deprecated Hiera 3 functions
 openvox-lint --only-checks legacy_facts,hiera3_function,top_scope_facts manifests/
 
 # Only check for errors (skip all warnings)
@@ -231,13 +254,13 @@ To see every check that openvox-lint can run:
 openvox-lint --list-checks
 ```
 
-This shows the check name, severity (warning or error), and description for all 38 built-in checks.
+This shows the check name, severity (warning or error), and description for all 37 built-in checks.
 
 ---
 
 ## Built-in Checks
 
-openvox-lint ships with **38 built-in checks** organized into categories:
+openvox-lint ships with **37 built-in checks** organized into categories:
 
 ### Whitespace & Formatting (5 checks)
 
@@ -301,13 +324,12 @@ openvox-lint ships with **38 built-in checks** organized into categories:
 | `case_without_default` | warning | Case statements must have a `default` case |
 | `selector_inside_resource` | warning | Don't use selectors inside resource bodies |
 
-### References & Syntax (4 checks)
+### References & Syntax (3 checks)
 
 | Check | Severity | Description |
 |-------|----------|-------------|
 | `leading_zero` | warning | No leading zeros in numbers (except file modes) |
 | `resource_reference_without_title_capital` | warning | Capitalise resource reference types |
-| `relative_classname_inclusion` | warning | Use fully qualified class names |
 | `autoloader_layout` | warning | Class/define name must match file path |
 
 ### Comments (1 check)
@@ -334,7 +356,7 @@ openvox-lint ships with **38 built-in checks** organized into categories:
 |-------|----------|-------------|
 | `legacy_facts` | warning | Legacy facts removed in Puppet 8; use `$facts['...']` |
 | `top_scope_facts` | warning | `$::fact` references; use `$facts['fact']` |
-| `hiera3_function` | **error** | `hiera()` / `hiera_hash()` removed; use `lookup()` |
+| `hiera3_function` | **error** | Deprecated Hiera 3 functions removed; use Hiera 5 `lookup()` |
 | `import_statement` | **error** | `import` removed in Puppet 4+ |
 
 ---
@@ -381,7 +403,7 @@ class foo { # lint:ignore:documentation
 
 ```
 manifests/init.pp:5:15: WARNING: unquoted_file_mode: unquoted file mode
-manifests/init.pp:9:3: ERROR: hiera3_function: 'hiera()' is removed in Puppet 8
+manifests/init.pp:9:3: ERROR: hiera3_function: deprecated Hiera 3 function 'hiera()' — use Hiera 5 lookup() instead
 ```
 
 ### JSON (`-f json`)
@@ -616,14 +638,14 @@ openvox-lint/
 
 ## Comparison with puppet-lint
 
-| Feature | puppet-lint 5.x | openvox-lint 1.0 |
+| Feature | puppet-lint 5.x | openvox-lint 1.3.0 |
 |---------|-----------------|------------------|
 | Ruby requirement | ≥ 3.1 | ≥ 2.5 (RHEL 8, macOS, all modern platforms) |
 | Runtime dependencies | None | None |
-| Built-in checks | ~25 | 38 |
+| Built-in checks | ~25 | 37 |
 | Legacy facts detection | Via plugin | Built-in |
 | Top-scope facts detection | Via plugin | Built-in |
-| Hiera 3 detection | No | Built-in (error) |
+| Deprecated Hiera 3 function detection | No | Built-in (error) |
 | Import statement detection | No | Built-in (error) |
 | Strict indent check | Via plugin | Built-in |
 | GitHub Actions output | No | Built-in (`-f github`) |
@@ -632,17 +654,33 @@ openvox-lint/
 | Custom log format | Yes | Yes (compatible) |
 | OpenVox awareness | No | Yes |
 | Plugin system | Yes | Yes (compatible) |
-| `--fix` support | Yes | Yes |
+| `--fix` support | Yes | Yes (real implementations for trailing_whitespace, hard_tabs, quoted_booleans, double_quoted_strings, single_quote_string_with_variables + line-based) |
 | vim-openvox integration | No | Native |
 
 ---
 
+## Links
+
+- **RubyGems**: [rubygems.org/gems/openvox-lint](https://rubygems.org/gems/openvox-lint)
+- **GitHub**: [github.com/cvquesty/openvox-lint](https://github.com/cvquesty/openvox-lint)
+- **Issues**: [github.com/cvquesty/openvox-lint/issues](https://github.com/cvquesty/openvox-lint/issues)
+
 ## License
 
 Apache License, Version 2.0. See [LICENSE](LICENSE) for details.
 
 ---
 
+## Contributors
+
+Thanks to the following people for their contributions to openvox-lint:
+
+| Contributor | Contribution |
+|-------------|--------------|
+| **[@hbro](https://github.com/hbro)** (Hans Broeckx) | Fixed `legacy_facts` false positives on local variables ([PR #1](https://github.com/cvquesty/openvox-lint/pull/1)) — *First community contribution!* 🎉 |
+
+Want to contribute? See [CONTRIBUTING.md](CONTRIBUTING.md) to get started!
+
 ## Author
 
 Jerald Sheets ([@cvquesty](https://github.com/cvquesty))

data/lib/openvox-lint/check_plugin.rb

@@ -83,7 +83,8 @@ module OpenvoxLint
       return false if @ignore_comments.empty?
       line = problem[:line]
       @ignore_comments.any? do |ic|
-        ic[:line] == line && (ic[:checks].empty? || ic[:checks].include?(problem[:check].to_s))
+        line >= ic[:start_line] && line <= ic[:end_line] &&
+          (ic[:checks].empty? || ic[:checks].include?(problem[:check].to_s))
       end
     end
 

data/lib/openvox-lint/checks.rb

@@ -30,17 +30,61 @@ module OpenvoxLint
 
     private
 
+    # Parse inline and block-style lint:ignore comments.
+    #
+    # Inline:  # lint:ignore:check_name   — suppresses on the same line
+    # Block:   # lint:ignore:check_name
+    #          ...code...
+    #          # lint:endignore            — suppresses from ignore to endignore
     def parse_ignore_comments
       results = []
+      open_blocks = []  # stack of { start_line:, checks: }
+
       @tokens.each do |tok|
         next unless tok.type == :COMMENT
-        if tok.value =~ /lint:ignore:(.+)/
-          results << { line: tok.line, checks: Regexp.last_match(1).strip.split(/\s*,\s*/) }
+
+        if tok.value =~ /lint:endignore/
+          # Close the most recent open block
+          block = open_blocks.pop
+          if block
+            block[:end_line] = tok.line
+            results << block
+          end
+        elsif tok.value =~ /lint:ignore:(.+)/
+          checks = Regexp.last_match(1).strip.split(/\s*,\s*/)
+          # If there's code on the same line before this comment, treat
+          # it as inline-only (same line).  Otherwise open a block.
+          if inline_ignore?(tok)
+            results << { start_line: tok.line, end_line: tok.line, checks: checks }
+          else
+            open_blocks.push({ start_line: tok.line, end_line: nil, checks: checks })
+          end
         elsif tok.value =~ /lint:ignore\b/
-          results << { line: tok.line, checks: [] }
+          if inline_ignore?(tok)
+            results << { start_line: tok.line, end_line: tok.line, checks: [] }
+          else
+            open_blocks.push({ start_line: tok.line, end_line: nil, checks: [] })
+          end
         end
       end
+
+      # Any unclosed blocks extend to end-of-file
+      open_blocks.each do |block|
+        block[:end_line] = Float::INFINITY
+        results << block
+      end
+
       results
     end
+
+    # An ignore comment is "inline" if there is a non-formatting token
+    # on the same line before it (i.e. it sits at the end of a code line).
+    def inline_ignore?(comment_token)
+      @tokens.any? do |t|
+        t.line == comment_token.line &&
+          t.column < comment_token.column &&
+          !t.formatting?
+      end
+    end
   end
 end

data/lib/openvox-lint/cli.rb

@@ -6,11 +6,12 @@ module OpenvoxLint
   # Command-line interface for openvox-lint.
   class CLI
     def initialize(args = ARGV)
-      @args   = args
-      @config = OpenvoxLint.configuration
+      @args = args
     end
 
     def run
+      OpenvoxLint.reset_configuration!
+      @config = OpenvoxLint.configuration
       parse_options
       load_rc_file
       if @list_checks
@@ -41,7 +42,7 @@ module OpenvoxLint
         opts.on('--only-checks CHECKS', 'Comma-separated checks') { |c| @config.only_checks = c.split(',').map { |s| s.strip.to_sym } }
         opts.on('--ignore-paths PATHS', 'Comma-separated globs') { |p| @config.ignore_paths = p.split(',').map(&:strip) }
         opts.on('--list-checks', 'List available checks') { @list_checks = true }
-        opts.on('-c', '--config FILE', 'Config file path') { |f| @config.config_file = f }
+        opts.on('-c', '--config FILE', 'Config file path') { |f| @explicit_config_file = f }
       end
       remaining = []
       begin
@@ -59,7 +60,15 @@ module OpenvoxLint
     end
 
     def load_rc_file
-      ['.openvox-lint.rc', @config.config_file, File.expand_path('~/.openvox-lint.rc')].each do |path|
+      # Priority: explicit --config flag > local .openvox-lint.rc > ~/.openvox-lint.rc
+      # An explicit --config flag must always win.  The default value of
+      # config_file is nil until the user passes -c / --config.
+      candidates = if @explicit_config_file
+                     [@explicit_config_file]
+                   else
+                     ['.openvox-lint.rc', File.expand_path('~/.openvox-lint.rc')]
+                   end
+      candidates.each do |path|
         next unless path && File.exist?(path)
         @config.load_from_rc(path); break
       end

data/lib/openvox-lint/configuration.rb

@@ -7,13 +7,12 @@ module OpenvoxLint
       log_format: 'text', with_filename: true, fail_on_warnings: false,
       fix: false, only_checks: [], disabled_checks: [],
       ignore_paths: %w[vendor/**/*.pp pkg/**/*.pp spec/**/*.pp],
-      config_file: '.openvox-lint.rc', relative: false, column: true,
-      custom_log_format: nil,
+      relative: false, column: true, custom_log_format: nil,
     }.freeze
 
     attr_accessor :log_format, :with_filename, :fail_on_warnings,
                   :fix, :only_checks, :disabled_checks, :ignore_paths,
-                  :config_file, :relative, :column, :custom_log_format
+                  :relative, :column, :custom_log_format
 
     def initialize
       DEFAULTS.each do |k, v|

data/lib/openvox-lint/lexer.rb

@@ -140,8 +140,9 @@ module OpenvoxLint
     end
 
     def scan_regex
-      start = @pos; start_col = @column
+      start = @pos; start_line = @line; start_col = @column
       @pos += 1; @column += 1
+      terminated = false
       while @pos < @code.length && @code[@pos] != '/'
         if @code[@pos] == '\\'
           @pos += 2; @column += 2
@@ -149,31 +150,41 @@ module OpenvoxLint
           @pos += 1; @column += 1
         end
       end
-      @pos += 1; @column += 1
-      add_token(:REGEX, @code[start...@pos], @line, start_col)
+      if @pos < @code.length
+        @pos += 1; @column += 1; terminated = true
+      end
+      if !terminated
+        raise OpenvoxLint::Error, "unterminated regex starting at line #{start_line}"
+      end
+      add_token(:REGEX, @code[start...@pos], start_line, start_col)
     end
 
     def scan_single_quoted_string
-      start = @pos; start_col = @column
+      start = @pos; start_line = @line; start_col = @column
       @pos += 1; @column += 1
+      terminated = false
       while @pos < @code.length
         if @code[@pos] == '\\'
           @pos += 2; @column += 2
         elsif @code[@pos] == "'"
-          @pos += 1; @column += 1; break
+          @pos += 1; @column += 1; terminated = true; break
         elsif @code[@pos] == "\n"
           @line += 1; @column = 1; @pos += 1
         else
           @pos += 1; @column += 1
         end
       end
-      add_token(:SSTRING, @code[start...@pos], @line, start_col)
+      if !terminated
+        raise OpenvoxLint::Error, "unterminated single-quoted string starting at line #{start_line}"
+      end
+      add_token(:SSTRING, @code[start...@pos], start_line, start_col)
     end
 
     def scan_double_quoted_string
-      start = @pos; start_col = @column
+      start = @pos; start_line = @line; start_col = @column
       @pos += 1; @column += 1
       has_interp = false
+      terminated = false
       while @pos < @code.length
         if @code[@pos] == '\\'
           @pos += 2; @column += 2
@@ -184,15 +195,18 @@ module OpenvoxLint
             @pos += 1; @column += 1
           end
         elsif @code[@pos] == '"'
-          @pos += 1; @column += 1; break
+          @pos += 1; @column += 1; terminated = true; break
         elsif @code[@pos] == "\n"
           @line += 1; @column = 1; @pos += 1
         else
           @pos += 1; @column += 1
         end
       end
+      if !terminated
+        raise OpenvoxLint::Error, "unterminated double-quoted string starting at line #{start_line}"
+      end
       type = has_interp ? :DQSTRING : :STRING
-      add_token(type, @code[start...@pos], @line, start_col)
+      add_token(type, @code[start...@pos], start_line, start_col)
     end
 
     def scan_variable

data/lib/openvox-lint/linter.rb

@@ -42,6 +42,24 @@ module OpenvoxLint
         fullpath: filepath, configuration: @config,
       )
       @problems.concat(checker.run)
+
+      # Apply --fix: checks' #fix methods (if implemented) mutate the shared
+      # manifest_lines array in place. After all checks, write the (possibly
+      # fixed) content back if it differs. This makes --fix functional for
+      # supported checks. Ensures final newline per style guide.
+      if @config.fix
+        begin
+          fixed_code = lexer.manifest_lines.join("\n") + "\n"
+          if fixed_code != code
+            File.write(filepath, fixed_code)
+          end
+        rescue StandardError => write_err
+          @problems << {
+            path: filepath, line: 0, column: 0, kind: :error,
+            check: :fix, message: "Failed to write fixes: #{write_err.message}",
+          }
+        end
+      end
     rescue StandardError => e
       @problems << {
         path: filepath, line: 0, column: 0, kind: :error,
@@ -64,8 +82,14 @@ module OpenvoxLint
     end
 
     def ignored?(filepath)
+      # Normalize away leading './' so that patterns like 'vendor/**/*.pp'
+      # match regardless of whether the file was discovered as
+      # './vendor/foo.pp' or 'vendor/foo.pp'.
+      normalized = filepath.sub(%r{\A\./}, '')
       @config.ignore_paths.any? do |pat|
-        File.fnmatch?(pat, filepath, File::FNM_PATHNAME | File::FNM_DOTMATCH)
+        File.fnmatch?(pat, normalized, File::FNM_PATHNAME | File::FNM_DOTMATCH) ||
+          File.fnmatch?(pat, filepath, File::FNM_PATHNAME | File::FNM_DOTMATCH) ||
+          File.fnmatch?("**/#{pat}", normalized, File::FNM_PATHNAME | File::FNM_DOTMATCH)
       end
     end
   end

data/lib/openvox-lint/plugins/checks/arrow_alignment.rb

@@ -1,6 +1,11 @@
 # frozen_string_literal: true
 
 # Hash rockets (=>) should be aligned within a resource body.
+#
+# Only fires on groups of 2+ arrows.  Skips groups where the
+# misalignment is caused by the longest key having extra leading
+# whitespace — that case is already reported by the
+# space_before_arrow check to avoid duplicate / contradictory advice.
 OpenvoxLint.new_check(:arrow_alignment) do
   def check
     # Group FARROW tokens by resource (consecutive lines)
@@ -11,8 +16,16 @@ OpenvoxLint.new_check(:arrow_alignment) do
     groups = group_arrows(arrows)
     groups.each do |group|
       next if group.size <= 1
+
+      # If the arrows are already at the same column, nothing to do.
       columns = group.map(&:column)
       max_col = columns.max
+      next if columns.all? { |c| c == max_col }
+
+      # Skip this group if the misalignment is caused by extra space
+      # before the longest-key arrow — space_before_arrow handles that.
+      next if longest_key_has_extra_space?(group)
+
       group.each do |arrow|
         next if arrow.column == max_col
         notify :warning,
@@ -39,4 +52,29 @@ OpenvoxLint.new_check(:arrow_alignment) do
     groups << current unless current.empty?
     groups
   end
+
+  # Returns true when the arrow belonging to the longest key in the
+  # group has more than one space before it.  In that situation the
+  # space_before_arrow check will fire, so arrow_alignment should stay
+  # silent to avoid contradictory advice.
+  def longest_key_has_extra_space?(group)
+    group.each do |arrow|
+      idx = tokens.index(arrow)
+      next unless idx && idx >= 2
+      ws = tokens[idx - 1]
+      next unless ws.type == :WHITESPACE
+      key = tokens[idx - 2]
+      next if key.formatting?
+      # Find the longest key length in the group
+      max_klen = group.map { |a|
+        ai = tokens.index(a)
+        next 0 unless ai && ai >= 2 && tokens[ai - 1].type == :WHITESPACE
+        tokens[ai - 2].value.length
+      }.max
+      if key.value.length == max_klen && ws.value.length > 1
+        return true
+      end
+    end
+    false
+  end
 end

data/lib/openvox-lint/plugins/checks/double_quoted_strings.rb

@@ -24,4 +24,20 @@ OpenvoxLint.new_check(:double_quoted_strings) do
         column: tok.column
     end
   end
+
+  # --fix support: convert the double-quoted string (no interp) to single
+  # quotes by swapping the outer delimiters at the reported column.
+  def fix(problem)
+    idx = problem[:line] - 1
+    line = @manifest_lines[idx].dup
+    col = (problem[:column] || 1) - 1
+    if line[col] == '"'
+      end_col = line.index('"', col + 1)
+      if end_col
+        inner = line[(col + 1)...end_col]
+        line[col..end_col] = "'" + inner + "'"
+        @manifest_lines[idx] = line
+      end
+    end
+  end
 end

data/lib/openvox-lint/plugins/checks/duplicate_params.rb

@@ -8,9 +8,9 @@ OpenvoxLint.new_check(:duplicate_params) do
       params = res[:param_tokens]
       params.each_with_index do |tok, i|
         next unless tok.type == :NAME
-        # Check if followed by =>
+        # param_tokens are already semantic (non-formatting), so the
+        # next token is directly adjacent.
         j = i + 1
-        j += 1 while j < params.length && params[j].formatting?
         next unless j < params.length && params[j].type == :FARROW
         if seen[tok.value]
           notify :error,

data/lib/openvox-lint/plugins/checks/hard_tabs.rb

@@ -12,4 +12,11 @@ OpenvoxLint.new_check(:hard_tabs) do
         column: col + 1
     end
   end
+
+  # --fix support: replace all hard tabs with two spaces (simple but effective
+  # for consistent soft-tab style; more sophisticated indent fixers exist).
+  def fix(problem)
+    idx = problem[:line] - 1
+    @manifest_lines[idx] = @manifest_lines[idx].gsub("\t", '  ')
+  end
 end

data/lib/openvox-lint/plugins/checks/hiera3_function.rb

@@ -1,7 +1,17 @@
 # frozen_string_literal: true
 
-# Hiera 3 functions (hiera, hiera_array, hiera_hash, hiera_include)
-# are removed in Puppet 8 / OpenVox 8. Use lookup() instead.
+# Detects deprecated Hiera 3 functions that are removed in Puppet 8 / OpenVox 8.
+#
+# Hiera 3 is fully deprecated.  Only Hiera 5 is supported in Puppet 8+.
+# The legacy hiera() functions were compatibility shims that have been removed.
+#
+# Deprecated functions:
+#   - hiera()         -> lookup()
+#   - hiera_array()   -> lookup(..., Array, 'unique')
+#   - hiera_hash()    -> lookup(..., Hash, 'hash')
+#   - hiera_include() -> lookup(...).include
+#
+# Use the Hiera 5 lookup() function instead.
 OpenvoxLint.new_check(:hiera3_function) do
   HIERA3_FUNCS = %w[hiera hiera_array hiera_hash hiera_include].freeze
 
@@ -9,7 +19,7 @@ OpenvoxLint.new_check(:hiera3_function) do
     tokens.each do |tok|
       next unless tok.type == :NAME && HIERA3_FUNCS.include?(tok.value)
       notify :error,
-        message: "'#{tok.value}()' is removed in Puppet 8 / OpenVox 8 — use lookup() instead",
+        message: "deprecated Hiera 3 function '#{tok.value}()' — use Hiera 5 lookup() instead",
         line: tok.line, column: tok.column
     end
   end

data/lib/openvox-lint/plugins/checks/legacy_facts.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require 'set'
+
 # Legacy (unstructured) top-scope facts are removed in Puppet 8 / OpenVox 8.
 # Use structured facts via $facts hash instead.
 #
@@ -35,13 +37,57 @@ OpenvoxLint.new_check(:legacy_facts) do
   ].freeze
 
   def check
+    local_vars = collect_local_vars
     tokens.each do |tok|
       next unless tok.type == :VARIABLE
-      name = tok.value.sub(/^\$/, '').sub(/\A::/, '')
+      # Strip leading $ and :: prefix, and any trailing : left by the
+      # lexer when a variable is used as a resource title ($fact:).
+      name = tok.value.sub(/^\$/, '').sub(/\A::/, '').chomp(':')
       next unless LEGACY_FACTS.include?(name)
+      next if local_vars.include?(name)
       notify :warning,
         message: "legacy fact '#{name}' — use $facts['...'] structured fact instead (Puppet 8 / OpenVox 8)",
         line: tok.line, column: tok.column
     end
   end
+
+  private
+
+  # Collect variable names that are declared locally (class/define parameters
+  # or lambda block parameters) so they are not mistaken for legacy facts.
+  def collect_local_vars
+    local = Set.new
+    toks = tokens
+    i = 0
+    while i < toks.size
+      case toks[i].type
+      when :CLASS, :DEFINE
+        # Skip to the opening LPAREN of the parameter list (stop at LBRACE)
+        j = i + 1
+        j += 1 while j < toks.size && toks[j].type != :LPAREN && toks[j].type != :LBRACE
+        if j < toks.size && toks[j].type == :LPAREN
+          depth = 1
+          j += 1
+          while j < toks.size && depth > 0
+            case toks[j].type
+            when :LPAREN then depth += 1
+            when :RPAREN then depth -= 1
+            when :VARIABLE then local << toks[j].value.sub(/^\$/, '').sub(/\A::/, '') if depth == 1
+            end
+            j += 1
+          end
+        end
+      when :PIPE
+        # Lambda parameter list: |$var1, $var2|
+        j = i + 1
+        while j < toks.size && toks[j].type != :PIPE
+          local << toks[j].value.sub(/^\$/, '').sub(/\A::/, '') if toks[j].type == :VARIABLE
+          j += 1
+        end
+        i = j # skip past closing PIPE
+      end
+      i += 1
+    end
+    local
+  end
 end

data/lib/openvox-lint/plugins/checks/parameter_order.rb

@@ -8,9 +8,9 @@ OpenvoxLint.new_check(:parameter_order) do
       found_default = false
       params.each_with_index do |tok, i|
         next unless tok.type == :VARIABLE
-        # Look ahead for = (default value)
+        # param_tokens from find_keyword_indexes are already semantic
+        # (non-formatting), so the next token is directly adjacent.
         j = i + 1
-        j += 1 while j < params.length && params[j].formatting?
         has_default = j < params.length && params[j].type == :EQUALS
         if has_default
           found_default = true

data/lib/openvox-lint/plugins/checks/quoted_booleans.rb

@@ -13,4 +13,25 @@ OpenvoxLint.new_check(:quoted_booleans) do
         line: tok.line, column: tok.column
     end
   end
+
+  # --fix support: unquote the boolean at the reported column (or fallback
+  # gsub). Assumes the problem points to the start of the quoted value.
+  def fix(problem)
+    idx = problem[:line] - 1
+    line = @manifest_lines[idx].dup
+    col = (problem[:column] || 1) - 1
+    if line[col] == "'" || line[col] == '"'
+      quote = line[col]
+      # Find matching closing quote for this simple boolean token
+      end_col = line.index(quote, col + 1)
+      if end_col && %w[true false].include?(line[(col + 1)...end_col])
+        val = line[(col + 1)...end_col]
+        line[col..end_col] = val
+        @manifest_lines[idx] = line
+        return
+      end
+    end
+    # Fallback (safe for most manifests)
+    @manifest_lines[idx] = line.gsub(/(['"])(true|false)\1/, '\2')
+  end
 end