openstudio-standards 0.8.1 → 0.8.3

data/lib/openstudio-standards/standards/Standards.CoilCoolingDXMultiSpeed.rb

@@ -7,10 +7,7 @@ class Standard
   # @param sql_db_vars_map [Hash] hash map
   # @return [Hash] hash of coil objects
   def coil_cooling_dx_multi_speed_apply_efficiency_and_curves(coil_cooling_dx_multi_speed, sql_db_vars_map)
-    successfully_set_all_properties = true
-
-    # Define the criteria to find the chiller properties
-    # in the hvac standards data set.
+    # Define the criteria to find the cooling coil properties in the hvac standards data set.
     search_criteria = {}
     search_criteria['template'] = template
     cooling_type = coil_cooling_dx_multi_speed.condenserType
@@ -68,8 +65,7 @@ class Standard
       capacity_w = coil_cooling_dx_multi_speed.autosizedSpeed4GrossRatedTotalCoolingCapacity.get
     else
       OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingDXMultiSpeed', "For #{coil_cooling_dx_multi_speed.name} capacity is not available, cannot apply efficiency standard.")
-      successfully_set_all_properties = false
-      return successfully_set_all_properties
+      return false
     end
 
     # Volume flow rate
@@ -105,9 +101,8 @@ class Standard
 
     # Check to make sure properties were found
     if ac_props.nil?
-      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingDXMultiSpeed', "For #{coil_cooling_dx_multi_speed.name}, cannot find efficiency info using #{search_criteria}, cannot apply efficiency standard.")
-      successfully_set_all_properties = false
-      return successfully_set_all_properties
+      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingDXMultiSpeed', "For #{coil_cooling_dx_multi_speed.name}, cannot find efficiency info using #{search_criteria} and capacity #{capacity_btu_per_hr} btu/hr, cannot apply efficiency standard.")
+      return false
     end
 
     # Make the COOL-CAP-FT curve
@@ -124,7 +119,6 @@ class Standard
       end
     else
       OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingDXMultiSpeed', "For #{coil_cooling_dx_multi_speed.name}, cannot find cool_cap_ft curve, will not be set.")
-      successfully_set_all_properties = false
     end
 
     # Make the COOL-CAP-FFLOW curve
@@ -132,7 +126,7 @@ class Standard
     if ac_props['cool_cap_fflow']
       cool_cap_fflow = model_add_curve(coil_coolingcoil_cooling_dx_multi_speed_dx_two_speed.model, ac_props['cool_cap_fflow'])
     else
-      cool_cap_fflow_curve_name = coil_dx_cap_fff(coil_cooling_dx_multi_speed)
+      cool_cap_fflow_curve_name = coil_dx_cap_fflow(coil_cooling_dx_multi_speed)
       cool_cap_fflow = model_add_curve(coil_cooling_dx_multi_speed.model, cool_cap_fflow_curve_name)
     end
     if cool_cap_fflow
@@ -141,7 +135,6 @@ class Standard
       end
     else
       OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingDXMultiSpeed', "For #{coil_cooling_dx_multi_speed.name}, cannot find cool_cap_fflow curve, will not be set.")
-      successfully_set_all_properties = false
     end
 
     # Make the COOL-EIR-FT curve
@@ -158,7 +151,6 @@ class Standard
       end
     else
       OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingDXMultiSpeed', "For #{coil_cooling_dx_multi_speed.name}, cannot find cool_eir_ft curve, will not be set.")
-      successfully_set_all_properties = false
     end
 
     # Make the COOL-EIR-FFLOW curve
@@ -166,7 +158,7 @@ class Standard
     if ac_props['cool_eir_fflow']
       cool_eir_fflow = model_add_curve(coil_cooling_dx_multi_speed.model, ac_props['cool_eir_fflow'])
     else
-      cool_eir_fflow_curve_name = coil_dx_eir_fff(coil_cooling_dx_multi_speed)
+      cool_eir_fflow_curve_name = coil_dx_eir_fflow(coil_cooling_dx_multi_speed)
       cool_eir_fflow = model_add_curve(coil_cooling_dx_multi_speed.model, cool_eir_fflow_curve_name)
     end
     if cool_eir_fflow
@@ -175,7 +167,6 @@ class Standard
       end
     else
       OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingDXMultiSpeed', "For #{coil_cooling_dx_multi_speed.name}, cannot find cool_eir_fflow curve, will not be set.")
-      successfully_set_all_properties = false
     end
 
     # Make the COOL-PLF-FPLR curve
@@ -192,7 +183,6 @@ class Standard
       end
     else
       OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingDXMultiSpeed', "For #{coil_cooling_dx_multi_speed.name}, cannot find cool_plf_fplr curve, will not be set.")
-      successfully_set_all_properties = false
     end
 
     # Get the minimum efficiency standards
@@ -249,8 +239,7 @@ class Standard
       capacity_w = coil_cooling_dx_multi_speed.stages[3].autosizedGrossRatedTotalCoolingCapacity.get
     else
       OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingDXMultiSpeed', "For #{coil_cooling_dx_multi_speed.name} capacity is not available, cannot apply efficiency standard.")
-      successfully_set_all_properties = false
-      return successfully_set_all_properties
+      return false
     end
 
     return capacity_w

data/lib/openstudio-standards/standards/Standards.CoilCoolingDXSingleSpeed.rb

@@ -64,8 +64,8 @@ class Standard
       (template == 'BTAP1980TO2010'))
       if search_criteria.keys.include?('equipment_type')
         equipment_type = search_criteria['equipment_type']
-        if equipment_type == 'PTAC'
-          search_criteria['application'] = coil_dx_ptac_application(coil_cooling_dx_single_speed)
+        if ['PTAC', 'PTHP'].include?(equipment_type) && template.include?('90.1')
+          search_criteria['application'] = coil_dx_packaged_terminal_application(coil_cooling_dx_single_speed)
         end
       elsif !coil_dx_heat_pump?(coil_cooling_dx_single_speed)
         search_criteria['equipment_type'] = 'Air Conditioners'
@@ -83,12 +83,10 @@ class Standard
     # Lookup efficiencies depending on whether it is a unitary AC or a heat pump
     ac_props = nil
     ac_props = model_find_object(database, search_criteria, capacity_btu_per_hr, Date.today)
-
     # Check to make sure properties were found
     if ac_props.nil?
-      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingDXSingleSpeed', "For #{coil_cooling_dx_single_speed.name}, cannot find efficiency info using #{search_criteria}, cannot apply efficiency standard.")
-      successfully_set_all_properties = false
-      return successfully_set_all_properties
+      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingDXSingleSpeed', "For #{coil_cooling_dx_single_speed.name}, cannot find efficiency info using #{search_criteria} and capacity #{capacity_btu_per_hr} btu/hr, cannot apply efficiency standard.")
+      return false
     end
 
     # Get the minimum efficiency standards
@@ -97,7 +95,7 @@ class Standard
     # If PTHP, use equations if coefficients are specified
     pthp_eer_coeff_1 = ac_props['pthp_eer_coefficient_1']
     pthp_eer_coeff_2 = ac_props['pthp_eer_coefficient_2']
-    if sub_category == 'PTHP' && !pthp_eer_coeff_1.nil? && !pthp_eer_coeff_2.nil?
+    if equipment_type == 'PTHP' && !pthp_eer_coeff_1.nil? && !pthp_eer_coeff_2.nil?
       # TABLE 6.8.1D
       # EER = pthp_eer_coeff_1 - (pthp_eer_coeff_2 * Cap / 1000)
       # Note c: Cap means the rated cooling capacity of the product in Btu/h.
@@ -223,8 +221,6 @@ class Standard
   # @param necb_ref_hp [Boolean] for compatability with NECB ruleset only.
   # @return [Hash] hash of coil objects
   def coil_cooling_dx_single_speed_apply_efficiency_and_curves(coil_cooling_dx_single_speed, sql_db_vars_map, necb_ref_hp = false)
-    successfully_set_all_properties = true
-
     # Get efficiencies data depending on whether it is a unitary AC or a heat pump
     coil_efficiency_data = if coil_dx_heat_pump?(coil_cooling_dx_single_speed)
                              standards_data['heat_pumps']
@@ -241,8 +237,8 @@ class Standard
       (template == 'BTAP1980TO2010'))
       if search_criteria.keys.include?('equipment_type')
         equipment_type = search_criteria['equipment_type']
-        if equipment_type == 'PTAC'
-          search_criteria['application'] = coil_dx_ptac_application(coil_cooling_dx_single_speed)
+        if ['PTAC', 'PTHP'].include?(equipment_type) && template.include?('90.1')
+          search_criteria['application'] = coil_dx_packaged_terminal_application(coil_cooling_dx_single_speed)
         end
       elsif !coil_dx_heat_pump?(coil_cooling_dx_single_speed)
         search_criteria['equipment_type'] = 'Air Conditioners'
@@ -262,8 +258,7 @@ class Standard
 
     # Check to make sure properties were found
     if ac_props.nil?
-      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingDXSingleSpeed', "For #{coil_cooling_dx_single_speed.name}, cannot find efficiency info using #{search_criteria}, cannot apply efficiency standard.")
-      successfully_set_all_properties = false
+      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingDXSingleSpeed', "For #{coil_cooling_dx_single_speed.name}, cannot find efficiency info using #{search_criteria} and capacity #{capacity_btu_per_hr} btu/hr, cannot apply efficiency standard.")
       return sql_db_vars_map
     end
 
@@ -280,7 +275,6 @@ class Standard
       coil_cooling_dx_single_speed.setTotalCoolingCapacityFunctionOfTemperatureCurve(cool_cap_ft)
     else
       OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingDXSingleSpeed', "For #{coil_cooling_dx_single_speed.name}, cannot find cool_cap_ft curve, will not be set.")
-      successfully_set_all_properties = false
     end
 
     # Make the COOL-CAP-FFLOW curve
@@ -288,14 +282,13 @@ class Standard
     if ac_props['cool_cap_fflow']
       cool_cap_fflow = model_add_curve(coil_cooling_dx_single_speed.model, ac_props['cool_cap_fflow'])
     else
-      cool_cap_fflow_curve_name = coil_dx_cap_fff(coil_cooling_dx_single_speed, equipment_type_field)
+      cool_cap_fflow_curve_name = coil_dx_cap_fflow(coil_cooling_dx_single_speed, equipment_type_field)
       cool_cap_fflow = model_add_curve(coil_cooling_dx_single_speed.model, cool_cap_fflow_curve_name)
     end
     if cool_cap_fflow
       coil_cooling_dx_single_speed.setTotalCoolingCapacityFunctionOfFlowFractionCurve(cool_cap_fflow)
     else
       OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingDXSingleSpeed', "For #{coil_cooling_dx_single_speed.name}, cannot find cool_cap_fflow curve, will not be set.")
-      successfully_set_all_properties = false
     end
 
     # Make the COOL-EIR-FT curve
@@ -310,7 +303,6 @@ class Standard
       coil_cooling_dx_single_speed.setEnergyInputRatioFunctionOfTemperatureCurve(cool_eir_ft)
     else
       OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingDXSingleSpeed', "For #{coil_cooling_dx_single_speed.name}, cannot find cool_eir_ft curve, will not be set.")
-      successfully_set_all_properties = false
     end
 
     # Make the COOL-EIR-FFLOW curve
@@ -318,14 +310,13 @@ class Standard
     if ac_props['cool_eir_fflow']
       cool_eir_fflow = model_add_curve(coil_cooling_dx_single_speed.model, ac_props['cool_eir_fflow'])
     else
-      cool_eir_fflow_curve_name = coil_dx_eir_fff(coil_cooling_dx_single_speed, equipment_type_field)
+      cool_eir_fflow_curve_name = coil_dx_eir_fflow(coil_cooling_dx_single_speed, equipment_type_field)
       cool_eir_fflow = model_add_curve(coil_cooling_dx_single_speed.model, cool_eir_fflow_curve_name)
     end
     if cool_eir_fflow
       coil_cooling_dx_single_speed.setEnergyInputRatioFunctionOfFlowFractionCurve(cool_eir_fflow)
     else
       OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingDXSingleSpeed', "For #{coil_cooling_dx_single_speed.name}, cannot find cool_eir_fflow curve, will not be set.")
-      successfully_set_all_properties = false
     end
 
     # Make the COOL-PLF-FPLR curve
@@ -340,7 +331,6 @@ class Standard
       coil_cooling_dx_single_speed.setPartLoadFractionCorrelationCurve(cool_plf_fplr)
     else
       OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingDXSingleSpeed', "For #{coil_cooling_dx_single_speed.name}, cannot find cool_plf_fplr curve, will not be set.")
-      successfully_set_all_properties = false
     end
 
     # Preserve the original name

data/lib/openstudio-standards/standards/Standards.CoilCoolingDXTwoSpeed.rb

@@ -57,9 +57,8 @@ class Standard
 
     # Check to make sure properties were found
     if ac_props.nil?
-      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingDXTwoSpeed', "For #{coil_cooling_dx_two_speed.name}, cannot find efficiency info using #{search_criteria}, cannot apply efficiency standard.")
-      successfully_set_all_properties = false
-      return successfully_set_all_properties
+      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingDXTwoSpeed', "For #{coil_cooling_dx_two_speed.name}, cannot find efficiency info using #{search_criteria} and capacity #{capacity_btu_per_hr} btu/hr, cannot apply efficiency standard.")
+      return false
     end
 
     # Get the minimum efficiency standards
@@ -67,7 +66,7 @@ class Standard
 
     # Check to make sure properties were found
     if ac_props.nil?
-      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingDXTwoSpeed', "For #{coil_cooling_dx_two_speed.name}, cannot find efficiency info using #{search_criteria}, cannot apply efficiency standard.")
+      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingDXTwoSpeed', "For #{coil_cooling_dx_two_speed.name}, cannot find efficiency info using #{search_criteria} and capacity #{capacity_btu_per_hr} btu/hr, cannot apply efficiency standard.")
       return cop # value of nil
     end
 
@@ -143,8 +142,6 @@ class Standard
   # @param sql_db_vars_map [Hash] hash map
   # @return [Hash] hash of coil objects
   def coil_cooling_dx_two_speed_apply_efficiency_and_curves(coil_cooling_dx_two_speed, sql_db_vars_map)
-    successfully_set_all_properties = true
-
     # Get the search criteria
     search_criteria = coil_dx_find_search_criteria(coil_cooling_dx_two_speed)
 
@@ -176,8 +173,7 @@ class Standard
 
     # Check to make sure properties were found
     if ac_props.nil?
-      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingDXTwoSpeed', "For #{coil_cooling_dx_two_speed.name}, cannot find efficiency info using #{search_criteria}, cannot apply efficiency standard.")
-      successfully_set_all_properties = false
+      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingDXTwoSpeed', "For #{coil_cooling_dx_two_speed.name}, cannot find efficiency info using #{search_criteria} and capacity #{capacity_btu_per_hr} btu/hr, cannot apply efficiency standard.")
       return sql_db_vars_map
     end
 
@@ -194,7 +190,6 @@ class Standard
       coil_cooling_dx_two_speed.setLowSpeedTotalCoolingCapacityFunctionOfTemperatureCurve(cool_cap_ft)
     else
       OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingDXTwoSpeed', "For #{coil_cooling_dx_two_speed.name}, cannot find cool_cap_ft curve, will not be set.")
-      successfully_set_all_properties = false
     end
 
     # Make the total COOL-CAP-FFLOW curve
@@ -202,14 +197,13 @@ class Standard
     if ac_props['cool_cap_fflow']
       cool_cap_fflow = model_add_curve(coil_cooling_dx_two_speed.model, ac_props['cool_cap_fflow'])
     else
-      cool_cap_fflow_curve_name = coil_dx_cap_fff(coil_cooling_dx_two_speed)
+      cool_cap_fflow_curve_name = coil_dx_cap_fflow(coil_cooling_dx_two_speed)
       cool_cap_fflow = model_add_curve(coil_cooling_dx_two_speed.model, cool_cap_fflow_curve_name)
     end
     if cool_cap_fflow
       coil_cooling_dx_two_speed.setTotalCoolingCapacityFunctionOfFlowFractionCurve(cool_cap_fflow)
     else
       OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingDXTwoSpeed', "For #{coil_cooling_dx_two_speed.name}, cannot find cool_cap_fflow curve, will not be set.")
-      successfully_set_all_properties = false
     end
 
     # Make the COOL-EIR-FT curve
@@ -225,7 +219,6 @@ class Standard
       coil_cooling_dx_two_speed.setLowSpeedEnergyInputRatioFunctionOfTemperatureCurve(cool_eir_ft)
     else
       OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingDXTwoSpeed', "For #{coil_cooling_dx_two_speed.name}, cannot find cool_eir_ft curve, will not be set.")
-      successfully_set_all_properties = false
     end
 
     # Make the COOL-EIR-FFLOW curve
@@ -233,14 +226,13 @@ class Standard
     if ac_props['cool_eir_fflow']
       cool_eir_fflow = model_add_curve(coil_cooling_dx_two_speed.model, ac_props['cool_eir_fflow'])
     else
-      cool_eir_fflow_curve_name = coil_dx_eir_fff(coil_cooling_dx_two_speed)
+      cool_eir_fflow_curve_name = coil_dx_eir_fflow(coil_cooling_dx_two_speed)
       cool_eir_fflow = model_add_curve(coil_cooling_dx_two_speed.model, cool_eir_fflow_curve_name)
     end
     if cool_eir_fflow
       coil_cooling_dx_two_speed.setEnergyInputRatioFunctionOfFlowFractionCurve(cool_eir_fflow)
     else
       OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingDXTwoSpeed', "For #{coil_cooling_dx_two_speed.name}, cannot find cool_eir_fflow curve, will not be set.")
-      successfully_set_all_properties = false
     end
 
     # Make the COOL-PLF-FPLR curve
@@ -255,7 +247,6 @@ class Standard
       coil_cooling_dx_two_speed.setPartLoadFractionCorrelationCurve(cool_plf_fplr)
     else
       OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingDXTwoSpeed', "For #{coil_cooling_dx_two_speed.name}, cannot find cool_plf_fplr curve, will not be set.")
-      successfully_set_all_properties = false
     end
 
     # Preserve the original name

data/lib/openstudio-standards/standards/Standards.CoilCoolingWaterToAirHeatPumpEquationFit.rb

@@ -29,11 +29,10 @@ class Standard
     search_criteria['template'] = template
     if computer_room_air_conditioner
       search_criteria['cooling_type'] = 'WaterCooled'
-      search_criteria['heating_type'] = 'All Other'
-      search_criteria['subcategory'] = 'CRAC'
+      search_criteria['standard_model'] = 'Downflow units'
       cooling_type = search_criteria['cooling_type']
-      heating_type = search_criteria['heating_type']
-      sub_category = search_criteria['subcategory']
+      heating_type = 'All Other'
+      sub_category = 'CRAC'
     end
     capacity_w = coil_cooling_water_to_air_heat_pump_find_capacity(coil_cooling_water_to_air_heat_pump)
     capacity_btu_per_hr = OpenStudio.convert(capacity_w, 'W', 'Btu/hr').get
@@ -61,7 +60,7 @@ class Standard
 
     # Check to make sure properties were found
     if coil_props.nil?
-      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingWaterToAirHeatPumpEquationFit', "For #{coil_cooling_water_to_air_heat_pump.name}, cannot find efficiency info using #{search_criteria}, cannot apply efficiency standard.")
+      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingWaterToAirHeatPumpEquationFit', "For #{coil_cooling_water_to_air_heat_pump.name}, cannot find efficiency info using #{search_criteria}  and capacity #{capacity_btu_per_hr} btu/hr, cannot apply efficiency standard.")
       successfully_set_all_properties = false
       return successfully_set_all_properties
     end
@@ -129,7 +128,7 @@ class Standard
       matching_objects = model_find_objects(standards_data['water_source_heat_pumps'], search_criteria, nil, Date.today)
       if matching_objects.empty?
         # This proves that the search_criteria has issue finding the correct coil prop
-        OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingWaterToAirHeatPumpEquationFit', "For #{coil_cooling_water_to_air_heat_pump.name}, cannot find efficiency info using #{search_criteria}, cannot apply efficiency standard.")
+        OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingWaterToAirHeatPumpEquationFit', "For #{coil_cooling_water_to_air_heat_pump.name}, cannot find efficiency info using #{search_criteria} and capacity #{capacity_btu_per_hr} btu/hr, cannot apply efficiency standard.")
         return sql_db_vars_map
       end
     end

data/lib/openstudio-standards/standards/Standards.CoilDX.rb

@@ -26,22 +26,12 @@ module CoilDX
       sub_category = 'CRAC'
     end
 
-    if coil_dx.airLoopHVAC.empty? && coil_dx.containingZoneHVACComponent.is_initialized
-      containing_comp = coil_dx.containingZoneHVACComponent.get
-      # PTHP
-      if containing_comp.to_ZoneHVACPackagedTerminalHeatPump.is_initialized
-        sub_category = 'PTHP'
-      end
-      # @todo Add other zone hvac systems
-    end
-
     return sub_category
   end
 
   # Determine if it is a heat pump
   #
-  # @param coil_dx [OpenStudio::Model::StraightComponent] coil cooling object, allowable types:
-  #   CoilCoolingDXSingleSpeed, CoilCoolingDXTwoSpeed, CoilCoolingDXMultiSpeed
+  # @param coil_dx [OpenStudio::Model::StraightComponent] coil cooling object
   # @return [Boolean] returns true if it is a heat pump, false if not
   def coil_dx_heat_pump?(coil_dx)
     heat_pump = false
@@ -83,7 +73,7 @@ module CoilDX
   def coil_dx_heating_type(coil_dx, necb_ref_hp = false)
     htg_type = nil
 
-    # If Unitary or Zone HVAC
+    # If Unitary or Zone HVAC (could be a unitary system on an air loop)
     if coil_dx.airLoopHVAC.empty?
       if coil_dx.containingHVACComponent.is_initialized
         containing_comp = coil_dx.containingHVACComponent.get
@@ -97,7 +87,7 @@ module CoilDX
             htg_coil = htg_coil.get
             if htg_coil.to_CoilHeatingElectric.is_initialized || htg_coil.to_CoilHeatingDXMultiSpeed.is_initialized
               htg_type = 'Electric Resistance or None'
-            elsif htg_coil.to_CoilHeatingGas.is_initialized || htg_coil.to_CoilHeatingGasMultiStage.is_initialized
+            elsif htg_coil.to_CoilHeatingGas.is_initialized || htg_coil.to_CoilHeatingGasMultiStage.is_initialized || htg_coil.to_CoilHeatingWater.is_initialized
               htg_type = 'All Other'
             end
           else
@@ -108,7 +98,7 @@ module CoilDX
           supp_htg_coil = containing_comp.to_AirLoopHVACUnitaryHeatPumpAirToAirMultiSpeed.get.supplementalHeatingCoil
           if htg_coil.to_CoilHeatingDXMultiSpeed.is_initialized || supp_htg_coil.to_CoilHeatingElectric.is_initialized
             htg_type = 'Electric Resistance or None'
-          elsif htg_coil.to_CoilHeatingGasMultiStage.is_initialized || htg_coil.to_CoilHeatingGas.is_initialized
+          elsif htg_coil.to_CoilHeatingGas.is_initialized || htg_coil.to_CoilHeatingGasMultiStage.is_initialized || htg_coil.to_CoilHeatingWater.is_initialized
             htg_type = 'All Other'
           end
         end
@@ -120,7 +110,7 @@ module CoilDX
           htg_coil = containing_comp.to_ZoneHVACPackagedTerminalAirConditioner.get.heatingCoil
           if htg_coil.to_CoilHeatingElectric.is_initialized
             htg_type = 'Electric Resistance or None'
-          elsif htg_coil.to_CoilHeatingWater.is_initialized || htg_coil.to_CoilHeatingGas.is_initialized
+          elsif htg_coil.to_CoilHeatingGas.is_initialized || htg_coil.to_CoilHeatingGasMultiStage.is_initialized || htg_coil.to_CoilHeatingWater.is_initialized
             htg_type = 'All Other'
           end
         # PTHP
@@ -171,6 +161,7 @@ module CoilDX
     search_criteria = {}
     search_criteria['template'] = template
 
+    # Cooling type
     search_criteria['cooling_type'] = case coil_dx.iddObjectType.valueName.to_s
                                       when 'OS_Coil_Cooling_DX_SingleSpeed',
                                            'OS_Coil_Cooling_DX_TwoSpeed',
@@ -182,24 +173,20 @@ module CoilDX
                                         'AirCooled'
                                       end
 
-    # Get the coil_dx_subcategory(coil_dx)
+    # Subcategory
     search_criteria['subcategory'] = coil_dx_subcategory(coil_dx)
 
     # Add the heating type to the search criteria
-    htg_type = coil_dx_heating_type(coil_dx, necb_ref_hp)
-    unless htg_type.nil?
-      search_criteria['heating_type'] = htg_type
-    end
-
-    # The heating side of unitary heat pumps don't have a heating type as part of the search
-    if coil_dx.to_CoilHeatingDXSingleSpeed.is_initialized &&
-       coil_dx_heat_pump?(coil_dx) &&
-       coil_dx.airLoopHVAC.empty? && coil_dx.containingHVACComponent.is_initialized
-      containing_comp = coil_dx.containingHVACComponent.get
-      if containing_comp.to_AirLoopHVACUnitaryHeatPumpAirToAir.is_initialized
-        search_criteria['heating_type'] = nil
+    case coil_dx.iddObjectType.valueName.to_s
+    when 'OS_Coil_Cooling_DX_SingleSpeed',
+         'OS_Coil_Cooling_DX_TwoSpeed',
+         'OS_Coil_Cooling_DX_VariableSpeed',
+         'OS_Coil_Cooling_DX_MultiSpeed',
+         'OS_AirConditioner_VariableRefrigerantFlow'
+      htg_type = coil_dx_heating_type(coil_dx, necb_ref_hp)
+      unless htg_type.nil?
+        search_criteria['heating_type'] = htg_type
       end
-      # @todo Add other unitary systems
     end
 
     # Get the equipment type
@@ -214,6 +201,13 @@ module CoilDX
           search_criteria['heating_type'] = nil
         end
       end
+      # PTHP
+      if containing_comp.to_ZoneHVACPackagedTerminalHeatPump.is_initialized && !((template == 'NECB2011') || (template == 'NECB2015') || (template == 'NECB2017') || (template == 'NECB2020') || (template == 'BTAPPRE1980') ||
+               (template == 'BTAP1980TO2010'))
+        search_criteria['subcategory'] = nil
+        search_criteria['heating_type'] = nil
+        search_criteria['equipment_type'] = 'PTHP'
+      end
     end
 
     return search_criteria
@@ -224,25 +218,47 @@ module CoilDX
   # @param coil_dx [OpenStudio::Model::StraightComponent] coil cooling object, allowable types:
   #   CoilCoolingDXSingleSpeed, CoilCoolingDXTwoSpeed, CoilCoolingDXMultiSpeed
   # @return [String] PTAC application
-  def coil_dx_ptac_application(coil_dx)
-    case template
-    when '90.1-2004', '90.1-2007'
+  def coil_dx_packaged_terminal_application(coil_dx)
+    if template.include?('90.1-2004') || template.include?('90.1-2007')
       return 'New Construction'
-    when '90.1-2010', '90.1-2013', '90.1-2016', '90.1-2019'
+    else # '90.1-2010', '90.1-2013', '90.1-2016', '90.1-2019', others
       return 'Standard Size'
     end
   end
 
+  # Determine what electric power phase value should be used for efficiency lookups for DX coils
+  #
+  # @param coil_dx [OpenStudio::Model::StraightComponent] coil cooling object, allowable types:
+  #   CoilCoolingDXSingleSpeed, CoilCoolingDXTwoSpeed, CoilCoolingDXMultiSpeed
+  # @return [String] Electric power phase
+  def coil_dx_electric_power_phase(coil_dx)
+    case template
+    when '90.1-2019', '90.1-2016'
+      return 3
+    else
+      return nil
+    end
+  end
+
   # Determine what capacity curve to use to represent the change of the coil's capacity as a function of changes in temperatures
   #
   # @param coil_dx [OpenStudio::Model::StraightComponent] coil cooling object, allowable types:
   #   CoilCoolingDXSingleSpeed, CoilCoolingDXTwoSpeed, CoilCoolingDXMultiSpeed
   # @param equipment_type [String] Type of equipment
-  # @return [String] PTAC application
-  def coil_dx_cap_ft(coil_dx, equipment_type = 'Air Conditioners')
+  # @param heating [Boolean] Specify if the curve to return is for heating operation
+  # @return [String] Curve name
+  def coil_dx_cap_ft(coil_dx, equipment_type = 'Air Conditioners', heating = false)
     case equipment_type
     when 'PTAC'
       return 'PSZ-Fine Storage DX Coil Cap-FT'
+    when 'PSZ-AC', 'Air Conditioners'
+      return 'CoilClgDXQRatio_fTwbToadbSI'
+    when 'PTHP'
+      return 'DXHEAT-NECB2011-REF-CAPFT'
+    when 'PSZ-HP', 'Heat Pumps'
+      return 'HPACHeatCapFT' if heating
+
+      return 'HPACCoolCapFT'
     else
       return 'CoilClgDXQRatio_fTwbToadbSI'
     end
@@ -253,11 +269,20 @@ module CoilDX
   # @param coil_dx [OpenStudio::Model::StraightComponent] coil cooling object, allowable types:
   #   CoilCoolingDXSingleSpeed, CoilCoolingDXTwoSpeed, CoilCoolingDXMultiSpeed
   # @param equipment_type [String] Type of equipment
-  # @return [String] PTAC application
-  def coil_dx_cap_fff(coil_dx, equipment_type = 'Air Conditioners')
+  # @param heating [Boolean] Specify if the curve to return is for heating operation
+  # @return [String] Curve name
+  def coil_dx_cap_fflow(coil_dx, equipment_type = 'Air Conditioners', heating = false)
     case equipment_type
     when 'PTAC'
       return 'DX Coil Cap-FF'
+    when 'PSZ-AC', 'Air Conditioners'
+      return 'CoilClgDXSnglQRatio_fCFMRatio'
+    when 'PTHP'
+      return 'DXHEAT-NECB2011-REF-CAPFFLOW'
+    when 'PSZ-HP', 'Heat Pumps'
+      return 'HPACHeatCapFFF' if heating
+
+      return 'HPACCoolCapFFF'
     else
       return 'CoilClgDXSnglQRatio_fCFMRatio'
     end
@@ -268,11 +293,20 @@ module CoilDX
   # @param coil_dx [OpenStudio::Model::StraightComponent] coil cooling object, allowable types:
   #   CoilCoolingDXSingleSpeed, CoilCoolingDXTwoSpeed, CoilCoolingDXMultiSpeed
   # @param equipment_type [String] Type of equipment
-  # @return [String] PTAC application
-  def coil_dx_eir_ft(coil_dx, equipment_type = 'Air Conditioners')
+  # @param heating [Boolean] Specify if the curve to return is for heating operation
+  # @return [String] Curve name
+  def coil_dx_eir_ft(coil_dx, equipment_type = 'Air Conditioners', heating = false)
     case equipment_type
     when 'PTAC'
       return 'PSZ-AC DX Coil EIR-FT'
+    when 'PSZ-AC', 'Air Conditioners'
+      return 'CoilClgDXEIRRatio_fTwbToadbSI'
+    when 'PTHP'
+      return 'DXHEAT-NECB2011-REF-EIRFT'
+    when 'PSZ-HP', 'Heat Pumps'
+      return 'HPACHeatEIRFT' if heating
+
+      return 'HPACCoolEIRFT'
     else
       return 'CoilClgDXEIRRatio_fTwbToadbSI'
     end
@@ -283,11 +317,20 @@ module CoilDX
   # @param coil_dx [OpenStudio::Model::StraightComponent] coil cooling object, allowable types:
   #   CoilCoolingDXSingleSpeed, CoilCoolingDXTwoSpeed, CoilCoolingDXMultiSpeed
   # @param equipment_type [String] Type of equipment
-  # @return [String] PTAC application
-  def coil_dx_eir_fff(coil_dx, equipment_type = 'Air Conditioners')
+  # @param heating [Boolean] Specify if the curve to return is for heating operation
+  # @return [String] Curve name
+  def coil_dx_eir_fflow(coil_dx, equipment_type = 'Air Conditioners', heating = false)
     case equipment_type
     when 'PTAC'
       return 'Split DX Coil EIR-FF'
+    when 'PSZ-AC', 'Air Conditioners'
+      return 'CoilClgDXSnglEIRRatio_fCFMRatio'
+    when 'PTHP'
+      return 'DXHEAT-NECB2011-REF-EIRFFLOW'
+    when 'PSZ-HP', 'Heat Pumps'
+      return 'HPACHeatEIRFFF' if heating
+
+      return 'HPACCoolEIRFFF'
     else
       return 'CoilClgDXSnglEIRRatio_fCFMRatio'
     end
@@ -298,11 +341,18 @@ module CoilDX
   # @param coil_dx [OpenStudio::Model::StraightComponent] coil cooling object, allowable types:
   #   CoilCoolingDXSingleSpeed, CoilCoolingDXTwoSpeed, CoilCoolingDXMultiSpeed
   # @param equipment_type [String] Type of equipment
-  # @return [String] PTAC application
-  def coil_dx_plf_fplr(coil_dx, equipment_type = 'Air Conditioners')
+  # @param heating [Boolean] Specify if the curve to return is for heating operation
+  # @return [String] Curve name
+  def coil_dx_plf_fplr(coil_dx, equipment_type = 'Air Conditioners', heating = false)
     case equipment_type
     when 'PTAC'
       return 'HPACCOOLPLFFPLR'
+    when 'PSZ-AC', 'Air Conditioners'
+      return 'CoilClgDXEIRRatio_fQFrac'
+    when 'PTHP'
+      return 'DXHEAT-NECB2011-REF-PLFFPLR'
+    when 'PSZ-HP', 'Heat Pumps'
+      return 'HPACCOOLPLFFPLR'
     else
       return 'CoilClgDXEIRRatio_fQFrac'
     end

data/lib/openstudio-standards/standards/Standards.CoilHeatingDXMultiSpeed.rb

@@ -22,10 +22,10 @@ class Standard
         heat_pump = true
         htg_coil = containing_comp.to_AirLoopHVACUnitaryHeatPumpAirToAirMultiSpeed.get.supplementalHeatingCoil
         suppl_heating_type = if htg_coil.to_CoilHeatingElectric.is_initialized
-                                'Electric Resistance or None'
-                              else
-                                'All Other'
-                              end
+                               'Electric Resistance or None'
+                             else
+                               'All Other'
+                             end
       end
       # @todo Add other unitary systems
     end
@@ -68,7 +68,7 @@ class Standard
 
     # Check to make sure properties were found
     if hp_props.nil?
-      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilHeatingDXMultipeed', "For #{coil_heating_dx_multi_speed.name}, cannot find efficiency info using #{search_criteria}, cannot apply efficiency standard.")
+      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilHeatingDXMultipeed', "For #{coil_heating_dx_multi_speed.name}, cannot find efficiency info using #{search_criteria} and capacity #{capacity_btu_per_hr} btu/hr, cannot apply efficiency standard.")
       successfully_set_all_properties = false
       return successfully_set_all_properties
     end