openstudio-standards 0.6.3 → 0.7.0.rc1

data/lib/openstudio-standards/standards/necb/NECB2011/data/geometry/LEEPTownHouse.osm

@@ -19296,7 +19296,7 @@ OS:Building,
   4,                                      !- Standards Number of Stories
   4,                                      !- Standards Number of Above Ground Stories
   ,                                       !- Standards Template
-  ,                                       !- Standards Building Type
+  LEEPTownHouse,                          !- Standards Building Type
   ,                                       !- Standards Number of Living Units
   ,                                       !- Relocatable
   ;                                       !- Nominal Floor to Ceiling Height {m}

data/lib/openstudio-standards/standards/necb/NECB2011/data/geometry/NorthernEducation.osm

@@ -44366,7 +44366,7 @@ OS:Connection,
 
 OS:Schedule:Ruleset,
   {9d5b666a-4e1e-46b3-9d97-8c5c37fc3b63}, !- Handle
-  Water Heater Ambient Temp Schedule 70F, !- Name
+  Water Heater Ambient Temp Schedule - 70F, !- Name
   {85e3f998-9b04-469c-b1ae-993d46032970}, !- Schedule Type Limits Name
   {74f82300-3fbb-4409-b504-cf26bb955cdb}, !- Default Day Schedule Name
   {756b8134-4003-4632-9ddb-72e4c2c884b6}, !- Summer Design Day Schedule Name
@@ -44374,7 +44374,7 @@ OS:Schedule:Ruleset,
 
 OS:Schedule:Day,
   {74f82300-3fbb-4409-b504-cf26bb955cdb}, !- Handle
-  Water Heater Ambient Temp Schedule 70F_Default, !- Name
+  Water Heater Ambient Temp Schedule - 70F_Default, !- Name
   {85e3f998-9b04-469c-b1ae-993d46032970}, !- Schedule Type Limits Name
   ,                                       !- Interpolate to Timestep
   24,                                     !- Hour 1
@@ -44383,7 +44383,7 @@ OS:Schedule:Day,
 
 OS:Schedule:Day,
   {756b8134-4003-4632-9ddb-72e4c2c884b6}, !- Handle
-  Water Heater Ambient Temp Schedule 70F_Summer_Design_Day, !- Name
+  Water Heater Ambient Temp Schedule - 70F_Summer_Design_Day, !- Name
   {85e3f998-9b04-469c-b1ae-993d46032970}, !- Schedule Type Limits Name
   ,                                       !- Interpolate to Timestep
   24,                                     !- Hour 1
@@ -44392,7 +44392,7 @@ OS:Schedule:Day,
 
 OS:Schedule:Day,
   {1016e14d-d134-44b4-8243-fef610fe7c9c}, !- Handle
-  Water Heater Ambient Temp Schedule 70F_Winter_Design_Day, !- Name
+  Water Heater Ambient Temp Schedule - 70F_Winter_Design_Day, !- Name
   {85e3f998-9b04-469c-b1ae-993d46032970}, !- Schedule Type Limits Name
   ,                                       !- Interpolate to Timestep
   24,                                     !- Hour 1

data/lib/openstudio-standards/standards/necb/NECB2011/data/geometry/NorthernHealthCare.osm

@@ -48651,7 +48651,7 @@ OS:Connection,
 
 OS:Schedule:Ruleset,
   {4f677daa-59d2-49b5-aa1a-6dd83e0b19bd}, !- Handle
-  Water Heater Ambient Temp Schedule 70F, !- Name
+  Water Heater Ambient Temp Schedule - 70F, !- Name
   {85e3f998-9b04-469c-b1ae-993d46032970}, !- Schedule Type Limits Name
   {d34869e3-d524-49a8-be02-404ef50ddebd}, !- Default Day Schedule Name
   {1b0aa04d-8083-4db1-b00e-25f523c27ed6}, !- Summer Design Day Schedule Name
@@ -48659,7 +48659,7 @@ OS:Schedule:Ruleset,
 
 OS:Schedule:Day,
   {d34869e3-d524-49a8-be02-404ef50ddebd}, !- Handle
-  Water Heater Ambient Temp Schedule 70F_Default, !- Name
+  Water Heater Ambient Temp Schedule - 70F_Default, !- Name
   {85e3f998-9b04-469c-b1ae-993d46032970}, !- Schedule Type Limits Name
   ,                                       !- Interpolate to Timestep
   24,                                     !- Hour 1
@@ -48668,7 +48668,7 @@ OS:Schedule:Day,
 
 OS:Schedule:Day,
   {1b0aa04d-8083-4db1-b00e-25f523c27ed6}, !- Handle
-  Water Heater Ambient Temp Schedule 70F_Summer_Design_Day, !- Name
+  Water Heater Ambient Temp Schedule - 70F_Summer_Design_Day, !- Name
   {85e3f998-9b04-469c-b1ae-993d46032970}, !- Schedule Type Limits Name
   ,                                       !- Interpolate to Timestep
   24,                                     !- Hour 1
@@ -48677,7 +48677,7 @@ OS:Schedule:Day,
 
 OS:Schedule:Day,
   {96989d3c-9a1f-45e2-aa14-e96ed361f0b5}, !- Handle
-  Water Heater Ambient Temp Schedule 70F_Winter_Design_Day, !- Name
+  Water Heater Ambient Temp Schedule - 70F_Winter_Design_Day, !- Name
   {85e3f998-9b04-469c-b1ae-993d46032970}, !- Schedule Type Limits Name
   ,                                       !- Interpolate to Timestep
   24,                                     !- Hour 1

data/lib/openstudio-standards/standards/necb/NECB2011/hvac_systems.rb

@@ -542,31 +542,38 @@ class NECB2011
     # Get the capacity
     capacity_w = boiler_hot_water_find_capacity(boiler_hot_water)
 
-    # Check if secondary and/or modulating boiler required
-    # If boiler names include 'Primary Boiler' or 'Secondary Boiler' then NECB rules are applied
     boiler_capacity = capacity_w
-    if boiler_hot_water.name.to_s.include?('Primary Boiler') || boiler_hot_water.name.to_s.include?('Secondary Boiler')
-      if capacity_w / 1000.0 >= 352.0
-        if boiler_hot_water.name.to_s.include?('Primary Boiler')
-          boiler_capacity = capacity_w
-          boiler_hot_water.setBoilerFlowMode('LeavingSetpointModulated')
-          boiler_hot_water.setMinimumPartLoadRatio(0.25)
-        elsif boiler_hot_water.name.to_s.include?('Secondary Boiler')
-          boiler_capacity = 0.001
-        end
-      elsif ((capacity_w / 1000.0) >= 176.0) && ((capacity_w / 1000.0) < 352.0)
-        boiler_capacity = capacity_w / 2
-      elsif (capacity_w / 1000.0) <= 176.0
-        if boiler_hot_water.name.to_s.include?('Primary Boiler')
-          if capacity_w <= 1.0
-            boiler_capacity = 1.0
-          else
+    # Use the NECB capacities if the SystemFuels class is not defined (i.e. this method was not called from something
+    # that created a SystemFuels object) or if either primary or secondary boiler capacity fractions are not defined.
+    if !self.fuel_type_set.is_a?(SystemFuels) || self.fuel_type_set.primary_boiler_cap_frac.nil? || self.fuel_type_set.secondary_boiler_cap_frac.nil?
+      # Check if secondary and/or modulating boiler required
+      # If boiler names include 'Primary Boiler' or 'Secondary Boiler' then NECB rules are applied
+      if boiler_hot_water.name.to_s.include?('Primary Boiler') || boiler_hot_water.name.to_s.include?('Secondary Boiler')
+        if capacity_w / 1000.0 >= 352.0
+          if boiler_hot_water.name.to_s.include?('Primary Boiler')
             boiler_capacity = capacity_w
+            boiler_hot_water.setBoilerFlowMode('LeavingSetpointModulated')
+            boiler_hot_water.setMinimumPartLoadRatio(0.25)
+          elsif boiler_hot_water.name.to_s.include?('Secondary Boiler')
+            boiler_capacity = 0.001
+          end
+        elsif ((capacity_w / 1000.0) >= 176.0) && ((capacity_w / 1000.0) < 352.0)
+          boiler_capacity = capacity_w / 2
+        elsif (capacity_w / 1000.0) <= 176.0
+          if boiler_hot_water.name.to_s.include?('Primary Boiler')
+            if capacity_w <= 1.0
+              boiler_capacity = 1.0
+            else
+              boiler_capacity = capacity_w
+            end
+          elsif boiler_hot_water.name.to_s.include?('Secondary Boiler')
+            boiler_capacity = 0.001
           end
-        elsif boiler_hot_water.name.to_s.include?('Secondary Boiler')
-          boiler_capacity = 0.001
         end
       end
+    else
+      boiler_capacity = capacity_w * self.fuel_type_set.primary_boiler_cap_frac if boiler_hot_water.name.to_s.include?('Primary Boiler')
+      boiler_capacity = capacity_w * self.fuel_type_set.secondary_boiler_cap_frac if boiler_hot_water.name.to_s.include?('Secondary Boiler')
     end
     boiler_hot_water.setNominalCapacity(boiler_capacity)
 
@@ -1117,7 +1124,7 @@ class NECB2011
     # This method will seem like an error in number of args..but this is due to swig voodoo.
     heat_pump_avail_sch_actuator = OpenStudio::Model::EnergyManagementSystemActuator.new(updated_heat_pump_avail_sch, 'Schedule:Constant', 'Schedule Value')
     heat_pump_avail_sch_prog = OpenStudio::Model::EnergyManagementSystemProgram.new(model)
-    heat_pump_avail_sch_prog.setName("#{multi_speed_heat_pump.name.to_s.gsub(/[ +-.]/, '_')} Availability Schedule Program by Line")
+    heat_pump_avail_sch_prog.setName("#{ems_friendly_name(multi_speed_heat_pump.name)} Availability Schedule Program by Line")
     heat_pump_avail_sch_prog_body = <<-EMS
         IF #{heat_pump_avail_sch_sensor.handle} > 0.0
           SET #{heat_pump_avail_sch_actuator.handle} = #{heat_pump_avail_sch_sensor.handle}
@@ -1129,7 +1136,7 @@ class NECB2011
     EMS
     heat_pump_avail_sch_prog.setBody(heat_pump_avail_sch_prog_body)
     pcm = OpenStudio::Model::EnergyManagementSystemProgramCallingManager.new(model)
-    pcm.setName("#{heat_pump_avail_sch_prog.name.to_s.gsub(/[ +-.]/, '_')} Calling Manager")
+    pcm.setName("#{heat_pump_avail_sch_prog.name} Calling Manager")
     pcm.setCallingPoint('InsideHVACSystemIterationLoop')
     pcm.addProgram(heat_pump_avail_sch_prog)
   end
@@ -1650,6 +1657,7 @@ class NECB2011
   def setup_hw_loop_with_components(model,
                                     hw_loop,
                                     boiler_fueltype,
+                                    backup_boiler_fueltype,
                                     pump_flow_sch)
     hw_loop.setName('Hot Water Loop')
     sizing_plant = hw_loop.sizingPlant
@@ -1671,7 +1679,7 @@ class NECB2011
     boiler1 = OpenStudio::Model::BoilerHotWater.new(model)
     boiler2 = OpenStudio::Model::BoilerHotWater.new(model)
     boiler1.setFuelType(boiler_fueltype)
-    boiler2.setFuelType(boiler_fueltype)
+    boiler2.setFuelType(backup_boiler_fueltype)
     boiler1.setName('Primary Boiler')
     boiler2.setName('Secondary Boiler')
 
@@ -2178,7 +2186,7 @@ class NECB2011
   end
 
   # Method to set the base system name based on the following syntax:
-  # |sys_abbr|sys_oa|sc>?|sh>?|ssf>?|zh>?|zc>?|srf>?|
+  # |sys_abbr|sys_oa|shr>?|sc>?|sh>?|ssf>?|zh>?|zc>?|srf>?|
   # "sys_abbr" designates the NECB system type ("sys_1, sys_2, ... sys_6")
   # "sys_oa": "mixed" or "doas"
   # "sys_name_pars" is a hash for the remaining system name parts for heat recovery,

data/lib/openstudio-standards/standards/necb/NECB2011/necb_2011.rb

@@ -16,7 +16,7 @@ class NECB2011 < Standard
   # This is a helper method to convert arguments that may support 'NECB_Default, and nils to convert to float'
   def convert_arg_to_f(variable:, default:)
     return variable if variable.kind_of?(Numeric)
-    return default if variable.nil? || (variable == 'NECB_Default')
+    return default if variable.nil? || (variable.to_s == 'NECB_Default')
     return unless variable.kind_of?(String)
 
     variable = variable.strip
@@ -26,13 +26,25 @@ class NECB2011 < Standard
   # This method converts arguments to bool.  Anything other than a bool false or string 'false' is converted
   # to a bool true.  Bool false and case insesitive string false are turned into bool false.
   def convert_arg_to_bool(variable:, default:)
-    return true if variable.nil?
+    return default if variable.nil?
     if variable.is_a? String
-      return true if variable.to_s.downcase == 'necb_default'
+      return default if variable.to_s.downcase == 'necb_default'
       return false if variable.to_s.downcase == 'false'
+      return true if variable.to_s.downcase == 'true'
     end
     return false if variable == false
-    return true
+    return variable
+  end
+
+  # This method checks if a variable is a string.  If it is anything but a string it returns the default.  If it is a
+  # string set to "NECB_Default" it return the default.  Otherwise it returns the strirng set to it.
+  def convert_arg_to_string(variable:, default:)
+    return default if variable.nil?
+    if variable.is_a? String
+      return default if variable.to_s.downcase == 'necb_default'
+      return variable
+    end
+    return default
   end
 
   def get_standards_table(table_name:)
@@ -257,7 +269,9 @@ class NECB2011 < Standard
                                    baseline_system_zones_map_option: nil,
                                    tbd_option: nil,
                                    tbd_interpolate: false,
-                                   necb_hdd: true)
+                                   necb_hdd: true,
+                                   boiler_fuel: nil,
+                                   boiler_cap_ratio: nil)
     model = load_building_type_from_library(building_type: building_type)
     return model_apply_standard(model: model,
                                 tbd_option: tbd_option,
@@ -317,9 +331,10 @@ class NECB2011 < Standard
                                 output_meters: output_meters,
                                 airloop_economizer_type: airloop_economizer_type, # (1) 'NECB_Default'/nil/' (2) 'DifferentialEnthalpy' (3) 'DifferentialTemperature'
                                 baseline_system_zones_map_option: baseline_system_zones_map_option,  # Three options: (1) 'NECB_Default'/'none'/nil (i.e. 'one_sys_per_bldg'), (2) 'one_sys_per_dwelling_unit', (3) 'one_sys_per_bldg'
-                                necb_hdd: necb_hdd
+                                necb_hdd: necb_hdd,
+                                boiler_fuel: boiler_fuel,
+                                boiler_cap_ratio: boiler_cap_ratio
                                 )
-
   end
 
   def load_building_type_from_library(building_type:)
@@ -394,14 +409,24 @@ class NECB2011 < Standard
                            output_meters: nil,
                            airloop_economizer_type: nil,
                            baseline_system_zones_map_option: nil,
-                           necb_hdd: true)
+                           necb_hdd: true,
+                           boiler_fuel: nil,
+                           boiler_cap_ratio: nil)
+
+    primary_heating_fuel = validate_primary_heating_fuel(primary_heating_fuel: primary_heating_fuel)
     self.fuel_type_set = SystemFuels.new()
     swh_fuel = swh_fuel.nil? ? 'NECB_Default' : swh_fuel.to_s
     self.fuel_type_set.set_defaults(standards_data: @standards_data, primary_heating_fuel: primary_heating_fuel, swh_fuel: swh_fuel)
+    swh_fuel = self.fuel_type_set.swh_fueltype if swh_fuel.to_s.downcase == 'necb_default'
     clean_and_scale_model(model: model, rotation_degrees: rotation_degrees, scale_x: scale_x, scale_y: scale_y, scale_z: scale_z)
     fdwr_set = convert_arg_to_f(variable: fdwr_set, default: -1)
     srr_set = convert_arg_to_f(variable: srr_set, default: -1)
     necb_hdd = convert_arg_to_bool(variable: necb_hdd, default: true)
+    boiler_fuel = convert_arg_to_string(variable: boiler_fuel, default: nil)
+    boiler_cap_ratio = convert_arg_to_string(variable: boiler_cap_ratio, default: nil)
+
+    boiler_cap_ratios = set_boiler_cap_ratios(boiler_cap_ratio: boiler_cap_ratio, boiler_fuel: boiler_fuel) unless boiler_cap_ratio.nil? && boiler_fuel.nil?
+    self.fuel_type_set.set_boiler_fuel(standards_data: @standards_data, boiler_fuel: boiler_fuel, boiler_cap_ratios: boiler_cap_ratios) unless boiler_fuel.nil?
 
     # Ensure the volume calculation in all spaces is done automatically
     model.getSpaces.sort.each do |space|
@@ -564,8 +589,6 @@ class NECB2011 < Standard
     ecm.apply_system_ecm(model: model,
                          ecm_system_name: ecm_system_name,
                          template_standard: self,
-                         primary_heating_fuel: self.fuel_type_set.ecm_fueltype,
-                         swh_fuel: self.fuel_type_set.ecm_fueltype,
                          ecm_system_zones_map_option: ecm_system_zones_map_option)
 
     # -------- Performace, Efficiencies, Controls and Sensors ------------
@@ -1176,11 +1199,6 @@ class NECB2011 < Standard
     end
   end
 
-  # Determine whether or not water fixtures are attached to spaces
-  def model_attach_water_fixtures_to_spaces?(model)
-    return true
-  end
-
   # Set the infiltration rate for this space to include
   # the impact of air leakage requirements in the standard.
   #
@@ -2417,4 +2435,60 @@ class NECB2011 < Standard
     return true
   end
 
+  # This method is defined and used by the vintage classes to address he issue with the heat pump fuel types.  This
+  # method does nothing when creating NECB reference buildings.
+  def validate_primary_heating_fuel(primary_heating_fuel:)
+    return primary_heating_fuel
+  end
+
+  # This method expects a string with the following pattern:  number-number
+  # The first number is the percent of the total capacity that the primary boiler's capacity will be set to.
+  # The second number is the percent of the total capacity that the secondary boiler's capacity will be set to.
+  # If no boiler_cap_ratio is provided the the primary boiler will have its capacity set to 75% of the total and the
+  # secondary boiler will have its capacity set to 25% of the total.  If a boiler_cap_ratio is set to '0_0' then the
+  # NECB default capacities are assigned.
+  def set_boiler_cap_ratios(boiler_cap_ratio:, boiler_fuel:)
+    # Rules if boiler_fuel is defined
+    unless boiler_fuel.nil?
+      # Set the NECB default boiler capacities if the boiler_cap_ratio is set to '0-0'
+      if boiler_cap_ratio == '0-0'
+        boiler_cap_ratios = {
+          primary_ratio: nil,
+          secondary_ratio: nil
+        }
+        return boiler_cap_ratios
+      elsif !boiler_fuel.to_s.downcase.include?('backup') && boiler_cap_ratio.nil?
+        # Set the NECB default boiler capacities if the boiler_cap_ratio in not defined and the boiler fuel type is set
+        # and the primary and secondary fuel types are the same.
+        boiler_cap_ratios = {
+          primary_ratio: nil,
+          secondary_ratio: nil
+        }
+        return boiler_cap_ratios
+      end
+    end
+    # Assuming the above rules do not apply, set the default boiler capacity ratio to 75% for the primary boiler and 25%
+    # for the secondary boiler
+    if boiler_cap_ratio.nil?
+      boiler_cap_ratios = {
+        primary_ratio: 0.75,
+        secondary_ratio: 0.25
+      }
+      return boiler_cap_ratios
+    end
+    # If you defined the boiler capacity ratios set them accordingly.
+    # Split the capacity ratio using the '-' symbol
+    string_ratios = boiler_cap_ratio.to_s.split('-')
+    # Turn the percentages into fractions
+    primary_ratio = string_ratios[0].to_f/100.0
+    secondary_ratio = string_ratios[1].to_f/100.0
+    # Set the hash containg the ratios and return
+    boiler_cap_ratios = {
+      primary_ratio: primary_ratio,
+      secondary_ratio: secondary_ratio
+    }
+    return boiler_cap_ratios
+  end
 end
+
+

data/lib/openstudio-standards/standards/necb/NECB2011/qaqc/necb_qaqc.rb

@@ -224,6 +224,10 @@ class NECB2011
     qaqc = {}
     qaqc[:sql_data] = get_sql_tables_to_json(model)
     error_warning = []
+    qaqc[:os_standards_revision] = OpenstudioStandards.git_revision
+    qaqc[:os_standards_version] = OpenstudioStandards::VERSION
+    qaqc[:openstudio_version] = os_version.strip
+    qaqc[:energyplus_version] = eplus_version.strip
     # Store Building data.
     qaqc[:building] = {}
     qaqc[:building][:name] = model.building.get.name.get
@@ -1919,7 +1923,7 @@ class NECB2011
     matches = nil
     # save a copy of the headers
     headers = nil
-    CSV.open(csv_fname, 'r', options) do |csv|
+    CSV.open(csv_fname, 'r', **options) do |csv|
       # Since CSV includes Enumerable we can use 'find_all'
       # which will return all the elements of the Enumerble for
       # which the block returns true

data/lib/openstudio-standards/standards/necb/NECB2011/service_water_heating.rb

@@ -21,77 +21,34 @@ class NECB2011
     # Add the main service water heating loop
     shw_pump_motor_eff = 0.9
 
-    main_swh_loop = model_add_swh_loop(model,
-                                       'Main Service Water Loop',
-                                       nil,
-                                       shw_sizing['max_temp_SI'],
-                                       shw_pump_head,
-                                       shw_pump_motor_eff,
-                                       shw_sizing['tank_capacity_SI'],
-                                       shw_sizing['tank_volume_SI'],
-                                       swh_fueltype,
-                                       shw_sizing['parasitic_loss'],
-                                       nil)
+    main_swh_loop = OpenstudioStandards::ServiceWaterHeating.create_service_water_heating_loop(model,
+                                                                                               system_name: 'Main Service Water Loop',
+                                                                                               service_water_temperature: shw_sizing['max_temp_SI'],
+                                                                                               service_water_pump_head: shw_pump_head,
+                                                                                               service_water_pump_motor_efficiency: shw_pump_motor_eff,
+                                                                                               water_heater_capacity: shw_sizing['tank_capacity_SI'],
+                                                                                               water_heater_volume: shw_sizing['tank_volume_SI'],
+                                                                                               water_heater_fuel: swh_fueltype,
+                                                                                               on_cycle_parasitic_fuel_consumption_rate: shw_sizing['parasitic_loss'],
+                                                                                               off_cycle_parasitic_fuel_consumption_rate: shw_sizing['parasitic_loss'])
 
     # Note that when water use equipment is assigned to spaces then the water used by the equipment is multiplied by
     # the space (ultimately thermal zone) multiplier.  Note that there is a separate water use equipment multiplier
     # as well which is different than the space (ultimately thermal zone) multiplier.
-    shw_sizing['spaces_w_dhw'].each { |space| model_add_swh_end_uses_by_spaceonly(model, space, main_swh_loop) }
+    shw_sizing['spaces_w_dhw'].each do |space|
+      OpenstudioStandards::ServiceWaterHeating.create_water_use(model,
+                                                                name: "#{space['shw_spaces'].name.get.capitalize}",
+                                                                flow_rate: space['shw_peakflow_ind_SI'],
+                                                                flow_rate_fraction_schedule: model_add_schedule(model, space['shw_sched']),
+                                                                water_use_temperature: space['shw_temp_SI'],
+                                                                service_water_loop: main_swh_loop,
+                                                                space: space['shw_spaces'])
+    end
     OpenStudio.logFree(OpenStudio::Info, 'openstudio.model.Model', 'Finished adding Service Water Heating')
 
     return true
   end
 
-  # This method will add an swh water fixture to the model for the space.
-  # if the it will return a water fixture object, or NIL if there is no water load at all.
-  #
-  # @param model [OpenStudio::Model::Model] OpenStudio model object
-  # @param space [Hash] hash of shw space information
-  # @param swh_loop [OpenStudio::Model::PlantLoop] plant loop to add swh
-  # @return [OpenStudio::Model::WaterUseEquipment] water use equipment
-  def model_add_swh_end_uses_by_spaceonly(model, space, swh_loop)
-    # Water use connection
-    swh_connection = OpenStudio::Model::WaterUseConnections.new(model)
-
-    # Water fixture definition
-    water_fixture_def = OpenStudio::Model::WaterUseEquipmentDefinition.new(model)
-
-    # water_use_sensible_frac_sch = OpenStudio::Model::ScheduleConstant.new(self)
-    # water_use_sensible_frac_sch.setValue(0.2)
-    # water_use_latent_frac_sch = OpenStudio::Model::ScheduleConstant.new(self)
-    # water_use_latent_frac_sch.setValue(0.05)
-    # Note that when water use equipment is assigned to spaces then the water used by the equipment is multiplied by the
-    # space (ultimately thermal zone) multiplier.  Note that there is a separate water use equipment multiplier as well
-    # which is different than the space (ultimately thermal zone) multiplier.
-    rated_flow_rate_gal_per_min = OpenStudio.convert(space['shw_peakflow_ind_SI'], 'm^3/s', 'gal/min').get
-    water_use_sensible_frac_sch = OpenStudio::Model::ScheduleRuleset.new(model)
-    water_use_sensible_frac_sch.defaultDaySchedule.addValue(OpenStudio::Time.new(0, 24, 0, 0), 0.2)
-    water_use_latent_frac_sch = OpenStudio::Model::ScheduleRuleset.new(model)
-    water_use_latent_frac_sch.defaultDaySchedule.addValue(OpenStudio::Time.new(0, 24, 0, 0), 0.05)
-    water_fixture_def.setSensibleFractionSchedule(water_use_sensible_frac_sch)
-    water_fixture_def.setLatentFractionSchedule(water_use_latent_frac_sch)
-    water_fixture_def.setPeakFlowRate(space['shw_peakflow_ind_SI'])
-    water_fixture_def.setName("#{space['shw_spaces'].name.to_s.capitalize} Service Water Use Def #{rated_flow_rate_gal_per_min.round(2)}gal/min")
-    # Target mixed water temperature
-    mixed_water_temp_c = space['shw_temp_SI']
-    mixed_water_temp_sch = OpenStudio::Model::ScheduleRuleset.new(model)
-    mixed_water_temp_sch.defaultDaySchedule.addValue(OpenStudio::Time.new(0, 24, 0, 0), mixed_water_temp_c)
-    water_fixture_def.setTargetTemperatureSchedule(mixed_water_temp_sch)
-
-    # Water use equipment
-    water_fixture = OpenStudio::Model::WaterUseEquipment.new(water_fixture_def)
-    schedule = model_add_schedule(model, space['shw_sched'])
-    water_fixture.setFlowRateFractionSchedule(schedule)
-    water_fixture.setName("#{space['shw_spaces'].name.to_s.capitalize} Service Water Use #{rated_flow_rate_gal_per_min.round(2)}gal/min")
-    swh_connection.addWaterUseEquipment(water_fixture)
-    # Assign water fixture to a space
-    water_fixture.setSpace(space['shw_spaces']) if model_attach_water_fixtures_to_spaces?(model)
-
-    # Connect the water use connection to the SWH loop
-    swh_loop.addDemandBranchForComponent(swh_connection)
-    return water_fixture
-  end
-
   # add swh
 
   # Applies the standard efficiency ratings and typical losses and paraisitic loads to this object.
@@ -476,9 +433,9 @@ class NECB2011
   # space that has a demand for shw.  It calculates the x, y, and z components of the vector between the shw space and the
   # spaces with demand for shw.  The distance of the piping run is calculated by adding the x, y, and z components of the
   # vector (rather than the magnitude of the vector).  For the purposes of calculating pressure loss along the pipe bends,
-  # and other minor losses are accounted by doubling the calculated length of the pipe.  The default kinematic viscosity 
-  # of water is assumed to be that at 60 C (in m^2/s).  The default density of water is assumed to be 983 kg/m^3 as per 
-  # https://hypertextbook.com/facts/2007/AllenMa.shtml accessed 2018-07-27.  The pipe is assumed to be made out of PVC and 
+  # and other minor losses are accounted by doubling the calculated length of the pipe.  The default kinematic viscosity
+  # of water is assumed to be that at 60 C (in m^2/s).  The default density of water is assumed to be 983 kg/m^3 as per
+  # https://hypertextbook.com/facts/2007/AllenMa.shtml accessed 2018-07-27.  The pipe is assumed to be made out of PVC and
   # have a roughness height of 1.5*10^-6 m as per:
   # www.pipeflow.com/pipe-pressure-drop-calculations/pipe-roughness accessed on 2018-07-25.
   # The default maximum velocity is from the table from 'The Engineering Toolbox' link:

data/lib/openstudio-standards/standards/necb/NECB2011/system_fuels.rb

@@ -1,6 +1,9 @@
 class SystemFuels
   attr_accessor :name
   attr_accessor :boiler_fueltype
+  attr_accessor :backup_boiler_fueltype
+  attr_accessor :primary_boiler_cap_frac
+  attr_accessor :secondary_boiler_cap_frac
   attr_accessor :baseboard_type
   attr_accessor :mau_type
   attr_accessor :mau_heating_coil_type
@@ -23,6 +26,9 @@ class SystemFuels
     # Assign fuel sources.
     @name = system_fuel_defaults['name']
     @boiler_fueltype = system_fuel_defaults['boiler_fueltype']
+    @backup_boiler_fueltype = system_fuel_defaults['boiler_fueltype']
+    @primary_boiler_cap_frac = nil
+    @secondary_boiler_cap_frac = nil
     @baseboard_type = system_fuel_defaults['baseboard_type']
     @mau_type = system_fuel_defaults['mau_type']
     @mau_cooling_type = system_fuel_defaults['mau_cooling_type']
@@ -37,4 +43,17 @@ class SystemFuels
     @swh_fueltype = system_fuel_defaults['swh_fueltype']
     @ecm_fueltype = system_fuel_defaults['ecm_fueltype']
   end
+
+  # Forces a boiler to be generated.  It searches boiler_fuel_type_sets.json for the boiler_fuel string and sets the
+  # primary and backup boiler fuels to be whatever is boiler fuel type set.
+  def set_boiler_fuel(standards_data:, boiler_fuel:, boiler_cap_ratios:)
+    boiler_fuel_defaults = standards_data['boiler_fuel_type_sets'].detect { |fuel_type_set| fuel_type_set['name'] == boiler_fuel }
+    @boiler_fueltype = boiler_fuel_defaults['boiler_fueltype']
+    @primary_boiler_cap_frac = boiler_cap_ratios[:primary_ratio]
+    @backup_boiler_fueltype = boiler_fuel_defaults['backup_boiler_fueltype']
+    @secondary_boiler_cap_frac = boiler_cap_ratios[:secondary_ratio]
+    @baseboard_type = boiler_fuel_defaults['baseboard_type']
+    @mau_heating_coil_type = boiler_fuel_defaults['mau_heating_coil_type'] unless @mau_heating_coil_type == 'DX'
+    @heating_coil_type_sys6 = boiler_fuel_defaults['heating_coil_type_sys6']
+  end
 end

data/lib/openstudio-standards/standards/necb/common/btap_data.rb

@@ -2075,8 +2075,62 @@ class BTAPData
     dehumidification_degree_days = OpenstudioStandards::Weather.epw_file_get_dehumidification_degree_days(epw_file)
 
     ### annual global horizontal irradiance (GHI)
-    ghi_timeseries = epw_file.getTimeSeries('Global Horizontal Radiation').get
-    annual_ghi_kwh_per_m_sq = ghi_timeseries.values.sum / 1000.0
+
+    # Workaround for case when the weather file contains the February from a leap year but that February only has 28
+    # days of data.
+    has_leap_day = false
+
+    # Find the first day in February
+    feb_index = epw_file.data.find_index { |entry| entry.date.monthOfYear.value == 2 }
+
+    # Find the year for February
+    feb_year = epw_file.data[feb_index].year
+    # Determine if February's year is a leap year
+    leap_year = false
+    if (feb_year % 100) > 0
+      leap_year = true if (feb_year % 4) == 0
+    else
+      leap_year = true if (feb_year % 400) == 0
+    end
+    # If the February is from a leap year determine if it contains a leap day
+    if leap_year
+
+      day = epw_file.data[feb_index].date.dayOfMonth
+      inc = 0
+
+      while epw_file.data[feb_index].date.dayOfMonth == day
+        feb_index += 1
+        inc       += 1
+      end
+
+      has_leap_day = epw_file.data[feb_index + (inc * 28)].date.dayOfMonth == 29
+    end
+
+    # If the February is from a leap year and there is no leap day then do not use the faulty OpenStudio Epw
+    # .getTimeSeries method.  Otherwise, use the method.
+    if has_leap_day || !leap_year
+      ghi_timeseries = epw_file.getTimeSeries('Global Horizontal Radiation').get.values
+    else
+      # Access the data directly instead of using the OpenStudio API to avoid the faulty OpenStudioEpw
+      # .getTimeSeries method.
+
+      # Open the weather file
+      regex_csv = /[^,]+/
+      regex_num = /[0-9]/
+      f         = File.open(epw_file.path.to_s, 'r')
+      i         = 0
+
+      # Skip the header
+      i += 1 until f.readline[0] =~ regex_num
+
+      # Get all of the hourly weather data
+      lines         = IO.readlines(f)[i..-1]
+
+      # Get hourly weather data for a specific column
+      ghi_timeseries = lines.map {|line| Float(line.scan(regex_csv)[13])}
+    end
+
+    annual_ghi_kwh_per_m_sq = ghi_timeseries.sum / 1000.0
 
     ### THD-1 Temperature at the colder of the two heating design conditions in PHIUS, 2021
     ### ('Heating design temperature' in REF: Wright (2019))

data/lib/openstudio-standards/standards/necb/common/btap_datapoint.rb

@@ -176,7 +176,9 @@ class BTAPDatapoint
                                        shw_scale: @options[:shw_scale],
                                        baseline_system_zones_map_option: @options[:baseline_system_zones_map_option],
                                        tbd_option: @options[:tbd_option],
-                                       necb_hdd: @options[:necb_hdd]
+                                       necb_hdd: @options[:necb_hdd],
+                                       boiler_fuel: @options[:boiler_fuel],
+                                       boiler_cap_ratio: @options[:boiler_cap_ratio]
                                        )
       end
 

data/lib/openstudio-standards/standards/necb/common/construction_defaults.osm

@@ -1928,13 +1928,13 @@ OS:Schedule:Day,
 
 OS:Schedule:Ruleset,
   {402721ef-5979-4bdf-8041-e590c3fe0060}, !- Handle
-  Water Heater Ambient Temp Schedule 70F, !- Name
+  Water Heater Ambient Temp Schedule - 70F, !- Name
   {7b49cd38-34d6-4fe8-8f95-f7546eac6e94}, !- Schedule Type Limits Name
   {5d1da6bc-bb9e-4fd7-930d-a079c77f9584}; !- Default Day Schedule Name
 
 OS:Schedule:Day,
   {5d1da6bc-bb9e-4fd7-930d-a079c77f9584}, !- Handle
-  Water Heater Ambient Temp Schedule 70F Default, !- Name
+  Water Heater Ambient Temp Schedule - 70F Default, !- Name
   {7b49cd38-34d6-4fe8-8f95-f7546eac6e94}, !- Schedule Type Limits Name
   ,                                       !- Interpolate to Timestep
   24,                                     !- Hour 1