openstudio-standards 0.2.17.rc1 → 0.3.0

data/lib/openstudio-standards/standards/necb/NECB2011/hvac_systems.rb

@@ -21,9 +21,9 @@ class NECB2011
   # @return [Bool] returns true if an economizer is required, false if not
   def air_loop_hvac_economizer_required?(air_loop_hvac)
     economizer_required = false
-    
+
     # need a better way to determine if an economizer is needed.
-    return economizer_required if ((air_loop_hvac.name.to_s.include? 'Outpatient F1' ) || 
+    return economizer_required if ((air_loop_hvac.name.to_s.include? 'Outpatient F1' ) ||
                                    (air_loop_hvac.sizingSystem.typeofLoadtoSizeOn.to_s == "VentilationRequirement"))
 
     # A big number of btu per hr as the minimum requirement
@@ -1997,7 +1997,11 @@ class NECB2011
     air_loop_sizing.setCentralHeatingDesignSupplyAirTemperature(system_data[:CentralHeatingDesignSupplyAirTemperature]) unless system_data[:CentralHeatingDesignSupplyAirTemperature].nil?
     air_loop_sizing.setAllOutdoorAirinCooling(system_data[:AllOutdoorAirinCooling]) unless system_data[:AllOutdoorAirinCooling].nil?
     air_loop_sizing.setAllOutdoorAirinHeating(system_data[:AllOutdoorAirinHeating]) unless system_data[:AllOutdoorAirinHeating].nil?
-    air_loop_sizing.setMinimumSystemAirFlowRatio(system_data[:MinimumSystemAirFlowRatio]) unless system_data[:MinimumSystemAirFlowRatio].nil?
+    if model.version < OpenStudio::VersionString.new('2.7.0')
+      air_loop_sizing.setMinimumSystemAirFlowRatio(system_data[:MinimumSystemAirFlowRatio]) unless system_data[:MinimumSystemAirFlowRatio].nil?
+    else
+      air_loop_sizing.setCentralHeatingMaximumSystemAirFlowRatio(system_data[:MinimumSystemAirFlowRatio]) unless system_data[:MinimumSystemAirFlowRatio].nil?
+    end
     return mau_air_loop
   end
 

data/lib/openstudio-standards/standards/necb/NECB2011/qaqc/necb_qaqc.rb

@@ -835,7 +835,7 @@ class NECB2011
           air_loop_info[:cooling_coils][:dx_single_speed] << coil
           single_speed = supply_comp.to_CoilCoolingDXSingleSpeed.get
           coil[:name] = single_speed.name.get
-          coil[:cop] = single_speed.ratedCOP.get
+          coil[:cop] = single_speed.ratedCOP.to_f
           coil[:nominal_total_capacity_w] = model.sqlFile.get.execAndReturnFirstDouble("SELECT Value FROM TabularDataWithStrings WHERE ReportName='EquipmentSummary' AND ReportForString='Entire Facility' AND TableName='Cooling Coils' AND ColumnName='Nominal Total Capacity' AND RowName='#{coil[:name].upcase}' ")
           coil[:nominal_total_capacity_w] = validate_optional(coil[:nominal_total_capacity_w], model, -1.0)
         end
@@ -844,8 +844,8 @@ class NECB2011
           air_loop_info[:cooling_coils][:dx_two_speed] << coil
           two_speed = supply_comp.to_CoilCoolingDXTwoSpeed.get
           coil[:name] = two_speed.name.get
-          coil[:cop_low] = two_speed.ratedLowSpeedCOP.get
-          coil[:cop_high] = two_speed.ratedHighSpeedCOP.get
+          coil[:cop_low] = two_speed.ratedLowSpeedCOP.to_f
+          coil[:cop_high] = two_speed.ratedHighSpeedCOP.to_f
           coil[:nominal_total_capacity_w] = model.sqlFile.get.execAndReturnFirstDouble("SELECT Value FROM TabularDataWithStrings WHERE ReportName='EquipmentSummary' AND ReportForString='Entire Facility' AND TableName='Cooling Coils' AND ColumnName='Nominal Total Capacity' AND RowName='#{coil[:name].upcase}' ")
           coil[:nominal_total_capacity_w] = validate_optional(coil[:nominal_total_capacity_w], model, -1.0)
         end
@@ -1712,7 +1712,7 @@ class NECB2011
   # This method will run the HRV compliance for a single air loop
   #
   # @param qaqc [:hash] Hash that contains the base data with qaqc keys
-  # @param model [:OS:Model] Openstudio Model
+  # @param model [:OS:Model] OpenStudio Model
   # @param  air_loop_info [:hash]  single air_loop object from the qaqc hash
   def necb_hrv_compliance_for_single_airloop(qaqc, model, air_loop_info)
     # HRV check

data/lib/openstudio-standards/standards/necb/NECB2011/service_water_heating.rb

@@ -222,7 +222,7 @@ class NECB2011
 
     # Append the name with standards information
     water_heater_mixed.setName("#{water_heater_mixed.name} #{water_heater_eff.round(3)} Therm Eff")
-    OpenStudio.logFree(OpenStudio::Info, 'openstudio.model.WaterHeaterMixed', "For #{template}: #{water_heater_mixed.name}; thermal efficiency = #{water_heater_eff.round(3)}, skin-loss UA = #{ua_btu_per_hr_per_f.round}Btu/hr")
+    OpenStudio.logFree(OpenStudio::Info, 'openstudio.model.WaterHeaterMixed', "For #{template}: #{water_heater_mixed.name}; thermal efficiency = #{water_heater_eff.round(3)}, skin-loss UA = #{ua_btu_per_hr_per_f.round}Btu/hr-R")
     return true
   end
 

data/lib/openstudio-standards/standards/necb/NECB2020/service_water_heating.rb

@@ -153,7 +153,7 @@ class NECB2020
 
     # Append the name with standards information
     water_heater_mixed.setName("#{water_heater_mixed.name} #{water_heater_eff.round(3)} Therm Eff")
-    OpenStudio.logFree(OpenStudio::Info, 'openstudio.model.WaterHeaterMixed', "For #{template}: #{water_heater_mixed.name}; thermal efficiency = #{water_heater_eff.round(3)}, skin-loss UA = #{ua_btu_per_hr_per_f.round}Btu/hr")
+    OpenStudio.logFree(OpenStudio::Info, 'openstudio.model.WaterHeaterMixed', "For #{template}: #{water_heater_mixed.name}; thermal efficiency = #{water_heater_eff.round(3)}, skin-loss UA = #{ua_btu_per_hr_per_f.round}Btu/hr-R")
     return true
   end
 end

data/lib/openstudio-standards/version.rb

@@ -13,5 +13,5 @@ module OpenstudioStandards
     end
     return 'git-not-found-on-this-system'
   end
-  VERSION = '0.2.17.rc1'.freeze
+  VERSION = '0.3.0'.freeze
 end

data/lib/openstudio-standards/weather/Weather.Model.rb

@@ -98,6 +98,11 @@ class Standard
       weather_dir = File.expand_path(File.join(Dir.pwd, 'extracted_files/weather/'))
       OpenStudio.logFree(OpenStudio::Info, 'openstudio.weather.Model', "Extracting weather files from OpenStudio CLI to #{weather_dir}")
       FileUtils.mkdir_p(weather_dir)
+
+      path_length = "#{weather_dir}/#{weather_file_name}".length
+      if path_length > 260
+        OpenStudio.logFree(OpenStudio::Warn, 'openstudio.weather.Model', "Weather file path length #{path_length} is >260 characters and may cause issues in Windows environments.")
+      end
       File.open("#{weather_dir}/#{weather_file_name}", 'wb') { |f| f << epw_string; f.flush }
       File.open("#{weather_dir}/#{weather_file_name.gsub('.epw', '.ddy')}", 'wb') { |f| f << ddy_string; f.flush }
       File.open("#{weather_dir}/#{weather_file_name.gsub('.epw', '.stat')}", 'wb') { |f| f << stat_string; f.flush }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: openstudio-standards
 version: !ruby/object:Gem::Version
-  version: 0.2.17.rc1
+  version: 0.3.0
 platform: ruby
 authors:
 - Andrew Parker
@@ -28,7 +28,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-10-07 00:00:00.000000000 Z
+date: 2022-11-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest-reporters
@@ -653,6 +653,7 @@ files:
 - data/geometry/DOERefSmallOffice.json
 - data/geometry/DOERefWarehouse.json
 - data/geometry/DOERefWarehouse.osm
+- data/standards/OpenStudio_Standards-ashrae_90_1.xlsx
 - data/standards/exclude_list.csv
 - data/standards/export_OpenStudio_libraries.rb
 - data/standards/legacy_dd_results.csv
@@ -661,6 +662,7 @@ files:
 - data/standards/metadata_units_OpenStudio_Standards-ashrae_90_1-ALL-comstockspace_types.csv
 - data/standards/metadata_units_OpenStudio_Standards-ashrae_90_1.csv
 - data/standards/metadata_units_OpenStudio_Standards-ashrae_90_1space_types.csv
+- data/standards/openstudio_standards_duplicates_log.csv
 - data/standards/templates_to_climate_zones.json
 - data/standards/test_performance_expected_dd_results.csv
 - data/weather/ALTURAS_725958_CZ2010.ddy