openstudio-standards 0.2.17.rc1 → 0.3.0

data/lib/openstudio-standards/standards/Standards.Model.rb

@@ -19,21 +19,18 @@ class Standard
   # @note Per 90.1, the Performance Rating Method "does NOT offer an alternative compliance path for minimum standard compliance."
   # This means you can't use this method for code compliance to get a permit.
   # @param user_model [OpenStudio::model::Model] User specified OpenStudio model
-  # @param building_type [String] the building type
   # @param climate_zone [String] the climate zone
   # @param hvac_building_type [String] the building type for baseline HVAC system determination (90.1-2016 and onward)
   # @param wwr_building_type [String] the building type for baseline WWR determination (90.1-2016 and onward)
   # @param swh_building_type [String] the building type for baseline SWH determination (90.1-2016 and onward)
-  # @param custom [String] the custom logic that will be applied during baseline creation.  Valid choices are 'Xcel Energy CO EDA' or '90.1-2007 with addenda dn'.
-  #   If nothing is specified, no custom logic will be applied; the process will follow the template logic explicitly.
-  # @param sizing_run_dir [String] the directory where the sizing runs will be performed
+  # @param output_dir [String] the directory where the PRM generations will be performed
   # @param run_all_orients [Boolean] indicate weather a baseline model should be created for all 4 orientations: same as user model, +90 deg, +180 deg, +270 deg
   # @param debug [Boolean] If true, will report out more detailed debugging output
   # @return [Bool] returns true if successful, false if not
 
   # Method used for 90.1-2016 and onward
-  def model_create_prm_stable_baseline_building(model, building_type, climate_zone, hvac_building_type, wwr_building_type, swh_building_type, custom = nil, sizing_run_dir = Dir.pwd, run_all_orients = true, unmet_load_hours_check = true, debug = false)
-    model_create_prm_any_baseline_building(model, building_type, climate_zone, hvac_building_type, wwr_building_type, swh_building_type, true, custom, sizing_run_dir, run_all_orients, unmet_load_hours_check, debug)
+  def model_create_prm_stable_baseline_building(model, climate_zone, hvac_building_type, wwr_building_type, swh_building_type, output_dir = Dir.pwd, unmet_load_hours_check = true, debug = false)
+    model_create_prm_any_baseline_building(model, '', climate_zone, hvac_building_type, wwr_building_type, swh_building_type, true, false, output_dir, true, unmet_load_hours_check, debug)
   end
 
   # Creates a Performance Rating Method (aka Appendix G aka LEED) baseline building model
@@ -77,6 +74,9 @@ class Standard
           OpenStudio.logFree(OpenStudio::Error, 'prm.log', "Proposed model unmet load hours exceed 300. Baseline model(s) won't be created.")
           raise "Proposed model unmet load hours exceed 300. Baseline model(s) won't be created."
         end
+      else
+        OpenStudio.logFree(OpenStudio::Error, 'prm.log', "Simulation failed. Check the model to make sure no severe errors.")
+        raise "Simulation on proposed model failed. Baseline generation is stopped."
       end
     end
 
@@ -1885,9 +1885,9 @@ class Standard
           # separate the primary zones from the secondary zones.
           # Add the baseline system type to the primary zones
           # and add the suplemental system type to the secondary zones.
-          story_zone_lists.each do |zones|
+          story_zone_lists.each do |story_group|
             # Differentiate primary and secondary zones
-            pri_sec_zone_lists = model_differentiate_primary_secondary_thermal_zones(model, story_group, zone_fan_scheds)
+            pri_sec_zone_lists = model_differentiate_primary_secondary_thermal_zones(model, story_group)
             # Record the primary zone system types
             pri_sec_zone_lists['primary'].each do |zone|
               zone_to_sys_type[zone] = pri_system_type
@@ -6926,7 +6926,7 @@ class Standard
   # include data source from:
   # 1. user data csv files
   # 2. data from measure and OpenStudio interface
-  # @param [Openstudio:model:Model] model
+  # @param [OpenStudio:model:Model] model
   # @param [String] climate_zone
   # @param [String] default_hvac_building_type
   # @param [String] default_wwr_building_type
@@ -6940,7 +6940,7 @@ class Standard
   # Template method for adding a setpoint manager for a coil control logic to a heating coil.
   # ASHRAE 90.1-2019 Appendix G.
   #
-  # @param model [OpenStudio::Model::Model] Openstudio model
+  # @param model [OpenStudio::Model::Model] OpenStudio model
   # @param thermalZones Array([OpenStudio::Model::ThermalZone]) thermal zone array
   # @param coil Heating Coils
   # @return [Boolean] true
@@ -6951,7 +6951,7 @@ class Standard
   # Template method for adding zone additional property "zone DCV implemented in user model"
   #
   # @author Xuechen (Jerry) Lei, PNNL
-  # @param model [OpenStudio::Model::Model] Openstudio model
+  # @param model [OpenStudio::Model::Model] OpenStudio model
   def model_mark_zone_dcv_existence(model)
     return true
   end
@@ -6960,7 +6960,7 @@ class Standard
   # The default shall be true
   #
   # @param [Boolean] run_all_orients: user inputs to indicate whether it is required to run all orientations
-  # @param [OpenStudio::Model::Model] Openstudio model
+  # @param [OpenStudio::Model::Model] OpenStudio model
   def run_all_orientations(run_all_orients, user_model)
     return run_all_orients
   end
@@ -6968,7 +6968,7 @@ class Standard
   # Template method for reading user data and adding to zone additional properties
   #
   # @author Xuechen (Jerry) Lei, PNNL
-  # @param model [OpenStudio::Model::Model] Openstudio model
+  # @param model [OpenStudio::Model::Model] OpenStudio model
   def model_add_dcv_user_exception_properties(model)
     return true
   end
@@ -6976,7 +6976,7 @@ class Standard
   # Template method for raising user model DCV warning and errors
   #
   # @author Xuechen (Jerry) Lei, PNNL
-  # @param model [OpenStudio::Model::Model] Openstudio model
+  # @param model [OpenStudio::Model::Model] OpenStudio model
   def model_raise_user_model_dcv_errors(model)
     return true
   end
@@ -6984,7 +6984,7 @@ class Standard
   # Template method for adding zone additional property "airloop dcv required by 901" and "zone dcv required by 901"
   #
   # @author Xuechen (Jerry) Lei, PNNL
-  # @param model [OpenStudio::Model::Model] Openstudio model
+  # @param model [OpenStudio::Model::Model] OpenStudio model
   def model_add_dcv_requirement_properties(model)
     return true
   end
@@ -6993,7 +6993,7 @@ class Standard
   # Zone additional property 'apxg no need to have DCV' added
   #
   # @author Xuechen (Jerry) Lei, PNNL
-  # @param model [OpenStudio::Model::Model] Openstudio model
+  # @param model [OpenStudio::Model::Model] OpenStudio model
   def model_add_apxg_dcv_properties(model)
     return true
   end
@@ -7001,14 +7001,14 @@ class Standard
   # Template method for setting DCV in baseline HVAC system if required
   #
   # @author Xuechen (Jerry) Lei, PNNL
-  # @param model [OpenStudio::Model::Model] Openstudio model
+  # @param model [OpenStudio::Model::Model] OpenStudio model
   def model_set_baseline_demand_control_ventilation(model, climate_zone)
     return true
   end
 
   # Identify the return air type associated with each thermal zone
   #
-  # @param model [OpenStudio::Model::Model] Openstudio model object
+  # @param model [OpenStudio::Model::Model] OpenStudio model object
   def model_identify_return_air_type(model)
     # air-loop based system
     model.getThermalZones.each do |zone|

data/lib/openstudio-standards/standards/Standards.PlanarSurface.rb

@@ -7,7 +7,7 @@ class Standard
   # create a construction that meets those properties and assign it to this surface.
   # 90.1-2007, 90.1-2010, 90.1-2013
   #
-  # @param planar_surface [Openstudio::Model:PlanarSurface] surface object
+  # @param planar_surface [OpenStudio::Model:PlanarSurface] surface object
   # @param climate_zone [String] ASHRAE climate zone, e.g. 'ASHRAE 169-2013-4A'
   # @param previous_construction_map [Hash] a hash where the keys are an array of inputs
   #   [template, climate_zone, intended_surface_type, standards_construction_type, occ_type]

data/lib/openstudio-standards/standards/Standards.ThermalZone.rb

@@ -980,7 +980,7 @@ class Standard
         end
       elsif equip.to_ZoneHVACLowTemperatureRadiantElectric.is_initialized
         equip = equip.to_ZoneHVACLowTemperatureRadiantElectric.get
-        htg_sch = equip.heatingSetpointTemperatureSchedule.get
+        htg_sch = equip.heatingSetpointTemperatureSchedule
       elsif equip.to_ZoneHVACLowTempRadiantConstFlow.is_initialized
         equip = equip.to_ZoneHVACLowTempRadiantConstFlow.get
         htg_coil = equip.heatingCoil

data/lib/openstudio-standards/standards/Standards.WaterHeaterMixed.rb

@@ -169,15 +169,15 @@ class Standard
     end
 
     # Convert to SI
-    ua_btu_per_hr_per_c = OpenStudio.convert(ua_btu_per_hr_per_f, 'Btu/hr*R', 'W/K').get
-    OpenStudio.logFree(OpenStudio::Debug, 'openstudio.standards.WaterHeaterMixed', "For #{water_heater_mixed.name}, skin-loss UA = #{ua_btu_per_hr_per_c} W/K.")
+    ua_w_per_k = OpenStudio.convert(ua_btu_per_hr_per_f, 'Btu/hr*R', 'W/K').get
+    OpenStudio.logFree(OpenStudio::Debug, 'openstudio.standards.WaterHeaterMixed', "For #{water_heater_mixed.name}, skin-loss UA = #{ua_w_per_k} W/K.")
 
     # Set the water heater properties
     # Efficiency
     water_heater_mixed.setHeaterThermalEfficiency(water_heater_eff)
     # Skin loss
-    water_heater_mixed.setOffCycleLossCoefficienttoAmbientTemperature(ua_btu_per_hr_per_c)
-    water_heater_mixed.setOnCycleLossCoefficienttoAmbientTemperature(ua_btu_per_hr_per_c)
+    water_heater_mixed.setOffCycleLossCoefficienttoAmbientTemperature(ua_w_per_k)
+    water_heater_mixed.setOnCycleLossCoefficienttoAmbientTemperature(ua_w_per_k)
     # @todo Parasitic loss (pilot light)
     # PNNL document says pilot lights were removed, but IDFs
     # still have the on/off cycle parasitic fuel consumptions filled in
@@ -190,7 +190,7 @@ class Standard
 
     # Append the name with standards information
     water_heater_mixed.setName("#{water_heater_mixed.name} #{water_heater_eff.round(3)} Therm Eff")
-    OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.WaterHeaterMixed', "For #{template}: #{water_heater_mixed.name}; thermal efficiency = #{water_heater_eff.round(3)}, skin-loss UA = #{ua_btu_per_hr_per_f.round}Btu/hr")
+    OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.WaterHeaterMixed', "For #{template}: #{water_heater_mixed.name}; thermal efficiency = #{water_heater_eff.round(3)}, skin-loss UA = #{ua_btu_per_hr_per_f.round}Btu/hr-R")
 
     return true
   end

data/lib/openstudio-standards/standards/Standards.ZoneHVACComponent.rb

@@ -144,6 +144,7 @@ class Standard
     # Zone HVAC operating schedule if providing ventilation
     # Zone HVAC components return an OptionalSchedule object for supplyAirFanOperatingModeSchedule
     # except for ZoneHVACTerminalUnitVariableRefrigerantFlow which returns a Schedule
+    # and starting at 3.5.0, PTAC / PTHP also return a Schedule, optional before that
     existing_sch = nil
     if zone_hvac_component.to_ZoneHVACFourPipeFanCoil.is_initialized
       zone_hvac_component = zone_hvac_component.to_ZoneHVACFourPipeFanCoil.get
@@ -161,7 +162,7 @@ class Standard
         ventilation = true if oa_rate > 0.0
       end
       ventilation = true if zone_hvac_component.isOutdoorAirFlowRateWhenNoCoolingorHeatingisNeededAutosized
-      fan_op_sch = zone_hvac_component.supplyAirFanOperatingModeSchedule
+      fan_op_sch = OpenStudio::Model::OptionalSchedule.new(zone_hvac_component.supplyAirFanOperatingModeSchedule)
       existing_sch = fan_op_sch.get if fan_op_sch.is_initialized
     elsif zone_hvac_component.to_ZoneHVACPackagedTerminalHeatPump.is_initialized
       zone_hvac_component = zone_hvac_component.to_ZoneHVACPackagedTerminalHeatPump.get
@@ -170,7 +171,7 @@ class Standard
         ventilation = true if oa_rate > 0.0
       end
       ventilation = true if zone_hvac_component.isOutdoorAirFlowRateWhenNoCoolingorHeatingisNeededAutosized
-      fan_op_sch = zone_hvac_component.supplyAirFanOperatingModeSchedule
+      fan_op_sch = OpenStudio::Model::OptionalSchedule.new(zone_hvac_component.supplyAirFanOperatingModeSchedule)
       existing_sch = fan_op_sch.get if fan_op_sch.is_initialized
     elsif zone_hvac_component.to_ZoneHVACTerminalUnitVariableRefrigerantFlow.is_initialized
       zone_hvac_component = zone_hvac_component.to_ZoneHVACTerminalUnitVariableRefrigerantFlow.get

data/lib/openstudio-standards/standards/ashrae_90_1/ashrae_90_1_2019/ashrae_90_1_2019.AirLoopHVAC.rb

@@ -640,46 +640,49 @@ class ASHRAE9012019 < ASHRAE901
     # Controller:MechanicalVentilation object
     # to the design v_ot using the maximum OA
     # fraction schedule
-
-    # Add EMS sensors
-    # OA mass flow calculated by the Controller:MechanicalVentilation
-    air_loop_hvac_name_ems = "EMS_#{air_loop_hvac.name.to_s.gsub(' ', '_')}"
-    oa_vrp_mass_flow = OpenStudio::Model::EnergyManagementSystemSensor.new(air_loop_hvac.model, 'Air System Outdoor Air Mechanical Ventilation Requested Mass Flow Rate')
-    oa_vrp_mass_flow.setKeyName(air_loop_hvac.name.to_s)
-    oa_vrp_mass_flow.setName("#{air_loop_hvac_name_ems}_OA_VRP")
-    # Actual sensed OA mass flow
-    oa_mass_flow = OpenStudio::Model::EnergyManagementSystemSensor.new(air_loop_hvac.model, 'Air System Outdoor Air Mass Flow Rate')
-    oa_mass_flow.setKeyName(air_loop_hvac.name.to_s)
-    oa_mass_flow.setName("#{air_loop_hvac_name_ems}_OA")
-    # Actual sensed volumetric OA flow
-    oa_vol_flow = OpenStudio::Model::EnergyManagementSystemSensor.new(air_loop_hvac.model, 'System Node Standard Density Volume Flow Rate')
-    oa_vol_flow.setKeyName("#{air_loop_hvac.name} Mixed Air Node")
-    oa_vol_flow.setName("#{air_loop_hvac_name_ems}_SUPPLY_FLOW")
-
-    # Add EMS actuator
-    max_oa_fraction = OpenStudio::Model::EnergyManagementSystemActuator.new(max_oa_frac_sch, max_oa_frac_sch_type, 'Schedule Value')
-    max_oa_fraction.setName("#{air_loop_hvac_name_ems}_MAX_OA_FRAC")
-
-    # Add EMS program
-    max_oa_ems_prog = OpenStudio::Model::EnergyManagementSystemProgram.new(air_loop_hvac.model)
-    max_oa_ems_prog.setName("#{air_loop_hvac.name}_MAX_OA_FRAC")
-    max_oa_ems_prog_body = <<-EMS
-    IF #{air_loop_hvac_name_ems}_OA > #{air_loop_hvac_name_ems}_OA_VRP,
-    SET #{air_loop_hvac_name_ems}_MAX_OA_FRAC = NULL,
-    ELSE,
-    IF #{air_loop_hvac_name_ems}_SUPPLY_FLOW > 0,
-    SET #{air_loop_hvac_name_ems}_MAX_OA_FRAC = #{v_ot} / #{air_loop_hvac_name_ems}_SUPPLY_FLOW,
-    ELSE,
-    SET #{air_loop_hvac_name_ems}_MAX_OA_FRAC = NULL,
-    ENDIF,
-    ENDIF
-    EMS
-    max_oa_ems_prog.setBody(max_oa_ems_prog_body)
-
-    max_oa_ems_prog_manager = OpenStudio::Model::EnergyManagementSystemProgramCallingManager.new(air_loop_hvac.model)
-    max_oa_ems_prog_manager.setName("SET_#{air_loop_hvac.name.to_s.gsub(' ', '_')}_MAX_OA_FRAC")
-    max_oa_ems_prog_manager.setCallingPoint('InsideHVACSystemIterationLoop')
-    max_oa_ems_prog_manager.addProgram(max_oa_ems_prog)
+    # In newer EnergyPlus versions, this is handled by Standard62.1VentilationRateProcedureWithLimit
+    # in the Controller:MechanicalVentilation object
+    if air_loop_hvac.model.version < OpenStudio::VersionString.new('3.3.0')
+      # Add EMS sensors
+      # OA mass flow calculated by the Controller:MechanicalVentilation
+      air_loop_hvac_name_ems = "EMS_#{air_loop_hvac.name.to_s.gsub(' ', '_')}"
+      oa_vrp_mass_flow = OpenStudio::Model::EnergyManagementSystemSensor.new(air_loop_hvac.model, 'Air System Outdoor Air Mechanical Ventilation Requested Mass Flow Rate')
+      oa_vrp_mass_flow.setKeyName(air_loop_hvac.name.to_s)
+      oa_vrp_mass_flow.setName("#{air_loop_hvac_name_ems}_OA_VRP")
+      # Actual sensed OA mass flow
+      oa_mass_flow = OpenStudio::Model::EnergyManagementSystemSensor.new(air_loop_hvac.model, 'Air System Outdoor Air Mass Flow Rate')
+      oa_mass_flow.setKeyName(air_loop_hvac.name.to_s)
+      oa_mass_flow.setName("#{air_loop_hvac_name_ems}_OA")
+      # Actual sensed volumetric OA flow
+      oa_vol_flow = OpenStudio::Model::EnergyManagementSystemSensor.new(air_loop_hvac.model, 'System Node Standard Density Volume Flow Rate')
+      oa_vol_flow.setKeyName("#{air_loop_hvac.name} Mixed Air Node")
+      oa_vol_flow.setName("#{air_loop_hvac_name_ems}_SUPPLY_FLOW")
+
+      # Add EMS actuator
+      max_oa_fraction = OpenStudio::Model::EnergyManagementSystemActuator.new(max_oa_frac_sch, max_oa_frac_sch_type, 'Schedule Value')
+      max_oa_fraction.setName("#{air_loop_hvac_name_ems}_MAX_OA_FRAC")
+
+      # Add EMS program
+      max_oa_ems_prog = OpenStudio::Model::EnergyManagementSystemProgram.new(air_loop_hvac.model)
+      max_oa_ems_prog.setName("#{air_loop_hvac.name}_MAX_OA_FRAC")
+      max_oa_ems_prog_body = <<-EMS
+      IF #{air_loop_hvac_name_ems}_OA > #{air_loop_hvac_name_ems}_OA_VRP,
+      SET #{air_loop_hvac_name_ems}_MAX_OA_FRAC = NULL,
+      ELSE,
+      IF #{air_loop_hvac_name_ems}_SUPPLY_FLOW > 0,
+      SET #{air_loop_hvac_name_ems}_MAX_OA_FRAC = #{v_ot} / #{air_loop_hvac_name_ems}_SUPPLY_FLOW,
+      ELSE,
+      SET #{air_loop_hvac_name_ems}_MAX_OA_FRAC = NULL,
+      ENDIF,
+      ENDIF
+      EMS
+      max_oa_ems_prog.setBody(max_oa_ems_prog_body)
+
+      max_oa_ems_prog_manager = OpenStudio::Model::EnergyManagementSystemProgramCallingManager.new(air_loop_hvac.model)
+      max_oa_ems_prog_manager.setName("SET_#{air_loop_hvac.name.to_s.gsub(' ', '_')}_MAX_OA_FRAC")
+      max_oa_ems_prog_manager.setCallingPoint('InsideHVACSystemIterationLoop')
+      max_oa_ems_prog_manager.addProgram(max_oa_ems_prog)
+    end
 
     # Hard-size the sizing:system
     # object with the calculated min OA flow rate

data/lib/openstudio-standards/standards/ashrae_90_1/ashrae_90_1_2019/ashrae_90_1_2019.ZoneHVACComponent.rb

@@ -44,7 +44,8 @@ class ASHRAE9012019 < ASHRAE901
     end
 
     # Set fan operating schedule during assumed occupant standby mode time to 0 so the fan can cycle
-    new_sch = model_set_schedule_value(zone_hvac_component.supplyAirFanOperatingModeSchedule.get, '12' => 0)
+    # ZoneHVACFourPipeFanCoil has it optional, PTAC/PTHP starting a 3.5.0 is required
+    new_sch = model_set_schedule_value(OpenStudio::Model::OptionalSchedule.new(zone_hvac_component.supplyAirFanOperatingModeSchedule).get, '12' => 0)
     zone_hvac_component.setSupplyAirFanOperatingModeSchedule(new_sch) unless new_sch == true
 
     return true

data/lib/openstudio-standards/standards/ashrae_90_1/data/ashrae_90_1.entryways.json

@@ -2,25 +2,25 @@
   "entryways": [
     {
       "building_type": "College",
-      "rollup_doors_per_10,000": null,
-      "entrance_doors_per_10,000": null,
-      "others_doors_per_10,000": null,
+      "rollup_doors_per_10,000": 0.0,
+      "entrance_doors_per_10,000": 2.0,
+      "others_doors_per_10,000": 2.45,
       "entrance_canopies": null,
       "emergency_canopies": null,
       "canopy_size": null,
       "floor_area_per_drive_through_window": null,
-      "notes": null
+      "notes": "match SecondarySchool"
     },
     {
       "building_type": "Courthouse",
-      "rollup_doors_per_10,000": null,
-      "entrance_doors_per_10,000": null,
-      "others_doors_per_10,000": null,
+      "rollup_doors_per_10,000": 0.0,
+      "entrance_doors_per_10,000": 1.0,
+      "others_doors_per_10,000": 3.0,
       "entrance_canopies": null,
       "emergency_canopies": null,
       "canopy_size": null,
       "floor_area_per_drive_through_window": null,
-      "notes": null
+      "notes": "match MediumOffice"
     },
     {
       "building_type": "FullServiceRestaurant",
@@ -55,6 +55,17 @@
       "floor_area_per_drive_through_window": null,
       "notes": "No source for canopy size, Table 5.41. Exterior Lighting Savings Summary for Addendum 90.1-07i  doesn't indicate canopy lighting. Section 5.4.2 Exterior Lights in U.S. Department of Energy Commercial Reference Building Models of the National Building Stock shows their use."
     },
+    {
+      "building_type": "Laboratory",
+      "rollup_doors_per_10,000": 0.0,
+      "entrance_doors_per_10,000": 2.0,
+      "others_doors_per_10,000": 2.45,
+      "entrance_canopies": null,
+      "emergency_canopies": null,
+      "canopy_size": null,
+      "floor_area_per_drive_through_window": null,
+      "notes": "match SecondarySchool"
+    },
     {
       "building_type": "LargeDataCenterHighITE",
       "rollup_doors_per_10,000": null,

data/lib/openstudio-standards/standards/ashrae_90_1/data/ashrae_90_1.parking.json

@@ -2,21 +2,21 @@
   "parking": [
     {
       "building_type": "College",
-      "building_area_per_spot": null,
+      "building_area_per_spot": 250.0,
       "units_per_spot": null,
       "students_per_spot": null,
       "beds_per_spot": null,
       "parking_area_per_spot": 405.0,
-      "notes": "Based on Table 4.17 Illuminated Parking Area from Achieving the 30% Goal: Energy and Cost Savings Analysis of ASHRAE Standard 90.1-2010"
+      "notes": "match MediumOffice"
     },
     {
       "building_type": "Courthouse",
-      "building_area_per_spot": null,
+      "building_area_per_spot": 250.0,
       "units_per_spot": null,
       "students_per_spot": null,
       "beds_per_spot": null,
       "parking_area_per_spot": 405.0,
-      "notes": "Based on Table 4.17 Illuminated Parking Area from Achieving the 30% Goal: Energy and Cost Savings Analysis of ASHRAE Standard 90.1-2010"
+      "notes": "match MediumOffice"
     },
     {
       "building_type": "FullServiceRestaurant",
@@ -45,6 +45,15 @@
       "parking_area_per_spot": 405.0,
       "notes": "Based on Table 4.17 Illuminated Parking Area from Achieving the 30% Goal: Energy and Cost Savings Analysis of ASHRAE Standard 90.1-2010"
     },
+    {
+      "building_type": "Laboratory",
+      "building_area_per_spot": 250.0,
+      "units_per_spot": null,
+      "students_per_spot": null,
+      "beds_per_spot": null,
+      "parking_area_per_spot": 405.0,
+      "notes": "match MediumOffice"
+    },
     {
       "building_type": "LargeDataCenterHighITE",
       "building_area_per_spot": 0.0,

data/lib/openstudio-standards/standards/ashrae_90_1/doe_ref_1980_2004/doe_ref_1980_2004.AirLoopHVAC.rb

@@ -47,4 +47,15 @@ class DOERef1980to2004 < ASHRAE901
     damper_action = 'Single Maximum'
     return damper_action
   end
+
+  # Determine minimum ventilation efficiency for zones.
+  # For DOE Ref 1980-2004, assume that VAV system designers did not
+  # care about decreasing system OA flow rates and therefore did not
+  # adjust minimum damper positions to achieve any specific
+  # ventilation efficiency.
+  def air_loop_hvac_minimum_zone_ventilation_efficiency(air_loop_hvac)
+    min_ventilation_efficiency = 0
+
+    return min_ventilation_efficiency
+  end
 end

data/lib/openstudio-standards/standards/ashrae_90_1/doe_ref_pre_1980/doe_ref_pre_1980.AirLoopHVAC.rb

@@ -47,4 +47,15 @@ class DOERefPre1980 < ASHRAE901
     damper_action = 'Single Maximum'
     return damper_action
   end
+
+  # Determine minimum ventilation efficiency for zones.
+  # For DOE Ref Pre-1980, assume that VAV system designers did not
+  # care about decreasing system OA flow rates and therefore did not
+  # adjust minimum damper positions to achieve any specific
+  # ventilation efficiency.
+  def air_loop_hvac_minimum_zone_ventilation_efficiency(air_loop_hvac)
+    min_ventilation_efficiency = 0
+
+    return min_ventilation_efficiency
+  end
 end

data/lib/openstudio-standards/standards/ashrae_90_1_prm/ashrae_90_1_prm.AirLoopHVAC.rb

@@ -272,7 +272,7 @@ class ASHRAE901PRM < Standard
         return_fan_power_fraction /= total_fan_avg_fan_w
         relief_fan_power_fraction /= total_fan_avg_fan_w
       else
-        Openstudio.logFree(OpenStudio::Error, "Total zone design airflow for #{air_loop_hvac.name} is 0.")
+        OpenStudio.logFree(OpenStudio::Error, 'openstudio.ashrae_90_1_prm.AirLoopHVAC', "Total zone design airflow for #{air_loop_hvac.name} is 0.")
       end
     elsif system_type == 'PTAC' ||
           system_type == 'PTHP' ||

data/lib/openstudio-standards/standards/ashrae_90_1_prm/ashrae_90_1_prm.Model.rb

@@ -1176,7 +1176,7 @@ class ASHRAE901PRM < Standard
   # Template method for adding a setpoint manager for a coil control logic to a heating coil.
   # ASHRAE 90.1-2019 Appendix G.
   #
-  # @param model [OpenStudio::Model::Model] Openstudio model
+  # @param model [OpenStudio::Model::Model] OpenStudio model
   # @param thermalZones Array([OpenStudio::Model::ThermalZone]) thermal zone array
   # @param coil Heating Coils
   # @return [Boolean] true
@@ -1228,7 +1228,7 @@ class ASHRAE901PRM < Standard
   #   - 'false' otherwise
   #
   # @author Xuechen (Jerry) Lei, PNNL
-  # @param model [OpenStudio::Model::Model] Openstudio model
+  # @param model [OpenStudio::Model::Model] OpenStudio model
   def model_mark_zone_dcv_existence(model)
     model.getAirLoopHVACs.each do |air_loop_hvac|
       next unless air_loop_hvac.airLoopHVACOutdoorAirSystem.is_initialized
@@ -1274,7 +1274,7 @@ class ASHRAE901PRM < Standard
   # "one user specified DCV exception"
   #
   # @author Xuechen (Jerry) Lei, PNNL
-  # @param model [OpenStudio::Model::Model] Openstudio model
+  # @param model [OpenStudio::Model::Model] OpenStudio model
   def model_add_dcv_user_exception_properties(model)
     model.getAirLoopHVACs.each do |air_loop_hvac|
       dcv_airloop_user_exception = false
@@ -1336,7 +1336,7 @@ class ASHRAE901PRM < Standard
   # - 'flase' otherwise
   #
   # @author Xuechen (Jerry) Lei, PNNL
-  # @param model [OpenStudio::Model::Model] Openstudio model
+  # @param model [OpenStudio::Model::Model] OpenStudio model
   def model_add_dcv_requirement_properties(model)
     model.getAirLoopHVACs.each do |air_loop_hvac|
       if user_model_air_loop_hvac_demand_control_ventilation_required?(air_loop_hvac)
@@ -1370,7 +1370,7 @@ class ASHRAE901PRM < Standard
   # generation
   #
   # @author Xuechen (Jerry) Lei, PNNL
-  # @param model [OpenStudio::Model::Model] Openstudio model
+  # @param model [OpenStudio::Model::Model] OpenStudio model
   def model_raise_user_model_dcv_errors(model)
     # TODO: JXL add log msgs to PRM logger
     model.getThermalZones.each do |thermal_zone|
@@ -1396,7 +1396,7 @@ class ASHRAE901PRM < Standard
   # property 'apxg no need to have DCV' added
   #
   # @author Xuechen (Jerry) Lei, PNNL
-  # @param model [OpenStudio::Model::Model] Openstudio model
+  # @param model [OpenStudio::Model::Model] OpenStudio model
   def model_add_apxg_dcv_properties(model)
     model.getAirLoopHVACs.each do |air_loop_hvac|
       if air_loop_hvac.airLoopHVACOutdoorAirSystem.is_initialized
@@ -1434,7 +1434,7 @@ class ASHRAE901PRM < Standard
   # Set DCV in baseline HVAC system if required
   #
   # @author Xuechen (Jerry) Lei, PNNL
-  # @param model [OpenStudio::Model::Model] Openstudio model
+  # @param model [OpenStudio::Model::Model] OpenStudio model
   def model_set_baseline_demand_control_ventilation(model, climate_zone)
     model.getAirLoopHVACs.each do |air_loop_hvac|
       if baseline_air_loop_hvac_demand_control_ventilation_required?(air_loop_hvac)
@@ -1452,7 +1452,7 @@ class ASHRAE901PRM < Standard
   # include data source from:
   # 1. user data csv files
   # 2. data from measure and OpenStudio interface
-  # @param [Openstudio:model:Model] model
+  # @param [OpenStudio:model:Model] model
   # @param [String] climate_zone
   # @param [String] default_hvac_building_type
   # @param [String] default_wwr_building_type
@@ -1948,7 +1948,7 @@ class ASHRAE901PRM < Standard
   # The default shall be true
   #
   # @param [Boolean] run_all_orients: user inputs to indicate whether it is required to run all orientations
-  # @param [OpenStudio::Model::Model] Openstudio model
+  # @param [OpenStudio::Model::Model] OpenStudio model
   def run_all_orientations(run_all_orients, user_model)
     # Step 0, assign the default value
     run_orients_flag = run_all_orients

data/lib/openstudio-standards/standards/ashrae_90_1_prm/ashrae_90_1_prm.PlanarSurface.rb

@@ -7,7 +7,7 @@ class ASHRAE901PRM < Standard
   # create a construction that meets those properties and assign it to this surface.
   # 90.1-PRM-2019
   #
-  # @param planar_surface [Openstudio::Model:PlanarSurface] surface object
+  # @param planar_surface [OpenStudio::Model:PlanarSurface] surface object
   # @param climate_zone [String] ASHRAE climate zone, e.g. 'ASHRAE 169-2013-4A'
   # @param previous_construction_map [Hash] a hash where the keys are an array of inputs
   #   [template, climate_zone, intended_surface_type, standards_construction_type, occ_type]

data/lib/openstudio-standards/standards/ashrae_90_1_prm/ashrae_90_1_prm.PlantLoop.rb

@@ -112,7 +112,11 @@ class ASHRAE901PRM < Standard
           sizing_run_ran = model_run_sizing_run(model, "#{sizing_run_dir}/SR_cooling_plant") if !sizing_run_ran
 
           if sizing_run_ran
-            sizing_run_capacity = model.getAutosizedValueFromEquipmentSummary(chiller, 'Central Plant', 'Nominal Capacity', 'W').get
+            if model.version <= OpenStudio::VersionString.new('3.2.1')
+              sizing_run_capacity = model.getAutosizedValueFromEquipmentSummary(chiller, 'Central Plant', 'Nominal Capacity', 'W').get
+            else
+              sizing_run_capacity = model.getAutosizedValueFromEquipmentSummary(chiller, 'Central Plant', 'Rated Capacity', 'W').get
+            end
             chiller.setReferenceCapacity(sizing_run_capacity)
             total_cooling_capacity_w += sizing_run_capacity
           else

data/lib/openstudio-standards/standards/necb/BTAPPRE1980/hvac_system_6.rb

@@ -235,7 +235,11 @@ class BTAPPRE1980
         air_loop_sizing.setCentralHeatingDesignSupplyAirTemperature(system_data[:CentralHeatingDesignSupplyAirTemperature])
         air_loop_sizing.setAllOutdoorAirinCooling(system_data[:AllOutdoorAirinCooling])
         air_loop_sizing.setAllOutdoorAirinHeating(system_data[:AllOutdoorAirinHeating])
-        air_loop_sizing.setMinimumSystemAirFlowRatio(system_data[:MinimumSystemAirFlowRatio])
+        if model.version < OpenStudio::VersionString.new('2.7.0')
+          air_loop_sizing.setMinimumSystemAirFlowRatio(system_data[:MinimumSystemAirFlowRatio])
+        else
+          air_loop_sizing.setCentralHeatingMaximumSystemAirFlowRatio(system_data[:MinimumSystemAirFlowRatio])
+        end
 
         supply_fan = OpenStudio::Model::FanVariableVolume.new(model, always_on)
         supply_fan.setName('Sys6 Supply Fan')

data/lib/openstudio-standards/standards/necb/ECMS/hvac_systems.rb

@@ -442,7 +442,7 @@ class ECMS
     end
     return storey_zones_map
   end
-  
+
   #==============================================================================================================================
   # Update the map between systems and zones
   def update_system_zones_map(model,system_zones_map,system_zones_map_option,system_key)
@@ -482,7 +482,7 @@ class ECMS
       system_zones_map = update_system_zones_map(model,system_zones_map,ecm_system_zones_map_option,'sys_1')
     else
       updated_system_zones_map = {}
-      system_zones_map.each {|sname,zones| updated_system_zones_map["sys_1#{sname[5..-1]}"] = zones}  # doas unit is an NECB sys_1 
+      system_zones_map.each {|sname,zones| updated_system_zones_map["sys_1#{sname[5..-1]}"] = zones}  # doas unit is an NECB sys_1
       system_zones_map = updated_system_zones_map
     end
     # Add outdoor VRF unit
@@ -612,7 +612,11 @@ class ECMS
     airloop.sizingSystem.setSystemOutdoorAirMethod('ZoneSum')
     airloop.sizingSystem.setCentralCoolingDesignSupplyAirHumidityRatio(0.0085)
     airloop.sizingSystem.setCentralHeatingDesignSupplyAirHumidityRatio(0.0080)
-    airloop.sizingSystem.setMinimumSystemAirFlowRatio(1.0)
+    if model.version < OpenStudio::VersionString.new('2.7.0')
+      airloop.sizingSystem.setMinimumSystemAirFlowRatio(1.0)
+    else
+      airloop.sizingSystem.setCentralHeatingMaximumSystemAirFlowRatio(1.0)
+    end
     case sys_vent_type.downcase
     when 'doas'
       airloop.sizingSystem.setAllOutdoorAirinCooling(true)
@@ -1126,7 +1130,7 @@ class ECMS
           # There is an error in EnergyPlus in the estimated capacity of the coil "CoilCoolingDXVariableSpeed".
           # Here the capacity reported by OS is adjusted to estimate an appropriate capacity for the cooling coil.
           # The autosized capacity is corrected for the actual fan flow rate and fan power.
-          if supply_fan.autosizedMaximumFlowRate.is_initialized 
+          if supply_fan.autosizedMaximumFlowRate.is_initialized
             fan_max_afr = supply_fan.autosizedMaximumFlowRate.to_f
           elsif supply_fan.maximumFlowRate.is_initialized
             fan_max_afr = supply_fan.maximumFlowRate.to_f

data/lib/openstudio-standards/standards/necb/ECMS/nv.rb

@@ -121,8 +121,11 @@ class ECMS
 
               ##### Add a "ZoneVentilation:DesignFlowRate" object for NV to set OA per person.
               zn_vent_design_flow_rate_1 = OpenStudio::Model::ZoneVentilationDesignFlowRate.new(model)
-              zn_vent_design_flow_rate_1.setDesignFlowRateCalculationMethod('Flow/Person')
               zn_vent_design_flow_rate_1.setFlowRateperPerson(oa_per_person_normalized_by_number_of_windows)
+              if model.version < OpenStudio::VersionString.new('3.5.0')
+                # Design Flow Rate Calculation Method is automatically set in 3.5.0+
+                zn_vent_design_flow_rate_1.setDesignFlowRateCalculationMethod('Flow/Person')
+              end
               zn_vent_design_flow_rate_1.setVentilationType('Natural')
               zn_vent_design_flow_rate_1.setMinimumIndoorTemperatureSchedule(min_Tin_schedule)
               zn_vent_design_flow_rate_1.setMaximumIndoorTemperatureSchedule(max_Tin_schedule)
@@ -133,8 +136,11 @@ class ECMS
 
               ##### Add another "ZoneVentilation:DesignFlowRate" object for NV to set OA per floor area.
               zn_vent_design_flow_rate_2 = OpenStudio::Model::ZoneVentilationDesignFlowRate.new(model)
-              zn_vent_design_flow_rate_2.setDesignFlowRateCalculationMethod('Flow/Area')
               zn_vent_design_flow_rate_2.setFlowRateperZoneFloorArea(oa_per_floor_area_normalized_by_number_of_windows)
+              if model.version < OpenStudio::VersionString.new('3.5.0')
+                # Design Flow Rate Calculation Method is automatically set in 3.5.0+
+                zn_vent_design_flow_rate_2.setDesignFlowRateCalculationMethod('Flow/Area')
+              end
               zn_vent_design_flow_rate_2.setVentilationType('Natural')
               zn_vent_design_flow_rate_2.setMinimumIndoorTemperatureSchedule(min_Tin_schedule)
               zn_vent_design_flow_rate_2.setMaximumIndoorTemperatureSchedule(max_Tin_schedule)