openstudio-standards 0.2.15.pre.rc2 → 0.2.16.rc2

data/lib/openstudio-standards/standards/Standards.AirLoopHVAC.rb

@@ -489,7 +489,7 @@ class Standard
         fan_pwr_limit_type = 'variable volume'
       elsif comp.to_AirLoopHVACUnitaryHeatCoolVAVChangeoverBypass.is_initialized
         fan = comp.to_AirLoopHVACUnitaryHeatCoolVAVChangeoverBypass.get.supplyAirFan
-        if fan.to_FanConstantVolume.is_initialized || comp.to_FanOnOff.is_initialized
+        if fan.to_FanConstantVolume.is_initialized || fan.to_FanOnOff.is_initialized
           fan_pwr_limit_type = 'constant volume'
         elsif fan.to_FanVariableVolume.is_initialized
           fan_pwr_limit_type = 'variable volume'
@@ -1712,7 +1712,7 @@ class Standard
     heat_exchanger_air_to_air_sensible_and_latent_apply_prototype_nominal_electric_power(erv)
 
     # add economizer lockout
-    erv.setSupplyAirOutletTemperatureControl(false)
+    erv.setSupplyAirOutletTemperatureControl(true)
     erv.setEconomizerLockout(true)
 
     # add defrost

data/lib/openstudio-standards/standards/Standards.CoilCoolingWaterToAirHeatPumpEquationFit.rb

@@ -103,7 +103,6 @@ class Standard
   # @param sql_db_vars_map [Hash] hash map
   # @return [Hash] hash of coil objects
   def coil_cooling_water_to_air_heat_pump_apply_efficiency_and_curves(coil_cooling_water_to_air_heat_pump, sql_db_vars_map)
-    successfully_set_all_properties = true
 
     # Get the search criteria
     search_criteria = {}
@@ -116,8 +115,15 @@ class Standard
 
     # Check to make sure properties were found
     if coil_props.nil?
-      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingWaterToAirHeatPumpEquationFit', "For #{coil_cooling_water_to_air_heat_pump.name}, cannot find efficiency info using #{search_criteria}, cannot apply efficiency standard.")
-      successfully_set_all_properties = false
+      # search again without capacity
+      matching_objects = model_find_objects(standards_data['water_source_heat_pumps'], search_criteria, nil, Date.today)
+      if matching_objects.size.zero?
+        # This proves that the search_criteria has issue finding the correct coil prop
+        OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingWaterToAirHeatPumpEquationFit', "For #{coil_cooling_water_to_air_heat_pump.name}, cannot find efficiency info using #{search_criteria}, cannot apply efficiency standard.")
+      else
+        # Issue warning indicate the coil size is may be too large
+        OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingWaterToAirHeatPumpEquationFit', "The capacity of the coil: #{coil_cooling_water_to_air_heat_pump.name} maybe too large to be found in the efficiency standard. The coil capacity is #{capacity_btu_per_hr} Btu/hr.")
+      end
       return sql_db_vars_map
     end
 

data/lib/openstudio-standards/standards/Standards.CoilHeatingGas.rb

@@ -22,6 +22,8 @@ class Standard
     capacity_btu_per_hr = OpenStudio.convert(capacity_w, 'W', 'Btu/hr').get
     capacity_kbtu_per_hr = OpenStudio.convert(capacity_w, 'W', 'kBtu/hr').get
 
+    return false unless capacity_btu_per_hr > 0
+
     # Get the boiler properties, if it exists for this template
     return false unless standards_data.include?('furnaces')
 

data/lib/openstudio-standards/standards/Standards.Construction.rb

@@ -83,16 +83,22 @@ class Standard
     # and the R-value of the non-insulation layers and air films.
     # This is the desired R-value of the insulation.
     ins_r_value_si = target_r_value_si - other_layer_r_value_si
-    if ins_r_value_si <= 0.0
-      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.Construction', "Requested U-value of #{target_u_value_ip} for #{construction.name} is too low given the other materials in the construction; insulation layer will not be modified.")
-      return false
-    end
-    ins_r_value_ip = OpenStudio.convert(ins_r_value_si, 'm^2*K/W', 'ft^2*h*R/Btu').get
 
     # Set the R-value of the insulation layer
-    construction.layers.each do |layer|
+    construction.layers.each_with_index do |layer, l|
       next unless layer.name.get == insulation_layer_name
 
+      # Remove insulation layer if requested R-value is lower than sum of non-insulation materials
+      if ins_r_value_si <= 0.0
+        OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.Construction', "Requested U-value of #{target_u_value_ip} for #{construction.name} is too low given the other materials in the construction; insulation layer will be removed.")
+        construction.eraseLayer(l)
+        # Set the target R-value to the sum of other layers to make name match properties
+        target_r_value_ip = OpenStudio.convert(other_layer_r_value_si, 'm^2*K/W', 'ft^2*hr*R/Btu').get
+        break # Don't modify the insulation layer since it has been removed
+      end
+
+      # Modify the insulation layer
+      ins_r_value_ip = OpenStudio.convert(ins_r_value_si, 'm^2*K/W', 'ft^2*h*R/Btu').get
       if layer.to_StandardOpaqueMaterial.is_initialized
         layer = layer.to_StandardOpaqueMaterial.get
         layer.setThickness(ins_r_value_si * layer.conductivity)

data/lib/openstudio-standards/standards/Standards.Model.rb

@@ -2524,12 +2524,28 @@ class Standard
     # which specifies properties by construction category by climate zone set.
     # AKA the info in Tables 5.5-1-5.5-8
 
-    props = model_find_object(standards_data['construction_properties'],
-                              'template' => template,
-                              'climate_zone_set' => climate_zone_set,
-                              'intended_surface_type' => intended_surface_type,
-                              'standards_construction_type' => standards_construction_type,
-                              'building_category' => building_category)
+    wwr = model_get_percent_of_surface_range(model, intended_surface_type)
+
+    search_criteria = { 'template' => template,
+                        'climate_zone_set' => climate_zone_set,
+                        'intended_surface_type' => intended_surface_type,
+                        'standards_construction_type' => standards_construction_type,
+                        'building_category' => building_category }
+
+    if !wwr['minimum_percent_of_surface'].nil? && !wwr['maximum_percent_of_surface'].nil?
+      search_criteria['minimum_percent_of_surface'] = wwr['minimum_percent_of_surface']
+      search_criteria['maximum_percent_of_surface'] = wwr['maximum_percent_of_surface']
+    end
+
+    # First search
+    props = model_find_object(standards_data['construction_properties'], search_criteria)
+
+    if !props
+      # Second search: In case need to use climate zone (e.g: 3) instead of sub-climate zone (e.g: 3A) for search
+      climate_zone = climate_zone_set[0..-2]
+      search_criteria['climate_zone_set'] = climate_zone
+      props = model_find_object(standards_data['construction_properties'], search_criteria)
+    end
 
     if !props
       OpenStudio.logFree(OpenStudio::Error, 'openstudio.standards.Model', "Could not find construction properties for: #{template}-#{climate_zone_set}-#{intended_surface_type}-#{standards_construction_type}-#{building_category}.")
@@ -3602,6 +3618,12 @@ class Standard
     # switch to use this but update test in standards and measures to load this outside of the method
     construction_properties = model_find_object(standards_data['construction_properties'], search_criteria)
 
+    if !construction_properties
+      # Search again use climate zone (e.g. 3) instead of sub-climate zone (3A)
+      search_criteria['climate_zone_set'] = climate_zone_set[0..-2]
+      construction_properties = model_find_object(standards_data['construction_properties'], search_criteria)
+    end
+
     return construction_properties
   end
 
@@ -3962,6 +3984,9 @@ class Standard
 
     # Air loops
     model.getAirLoopHVACs.each(&:remove)
+    if model.version > OpenStudio::VersionString.new('3.1.0')
+      model.getAirLoopHVACDedicatedOutdoorAirSystems.each(&:remove)
+    end
 
     # Zone equipment
     model.getThermalZones.sort.each do |zone|
@@ -4290,7 +4315,7 @@ class Standard
   # @param possible_climate_zone_sets [Array] climate zone sets
   # @return [String] climate zone ses
   def model_get_climate_zone_set_from_list(model, possible_climate_zone_sets)
-    climate_zone_set = possible_climate_zone_sets.min
+    climate_zone_set = possible_climate_zone_sets.max
     return climate_zone_set
   end
 
@@ -5185,6 +5210,7 @@ class Standard
       electric = true
 
       if htg_fuels.include?('NaturalGas') ||
+         htg_fuels.include?('Propane') ||
          htg_fuels.include?('PropaneGas') ||
          htg_fuels.include?('FuelOilNo1') ||
          htg_fuels.include?('FuelOilNo2') ||
@@ -5779,6 +5805,15 @@ class Standard
     return parametric_inputs
   end
 
+  # Determine the surface range of a baseline model.
+  # The method calculates the window to wall ratio (assuming all spaces are conditioned)
+  # and select the range based on the calculated window to wall ratio
+  # @param model [OpenStudio::Model::Model] OpenStudio model object
+  # @param intended_surface_type [String] surface type
+  def model_get_percent_of_surface_range(model, intended_surface_type)
+    return { 'minimum_percent_of_surface' => nil, 'maximum_percent_of_surface' => nil }
+  end
+
   # Default SAT reset type
   #
   # @param air_loop_hvac [OpenStudio::Model::AirLoopHVAC] air loop

data/lib/openstudio-standards/standards/Standards.PlanarSurface.rb

@@ -92,6 +92,21 @@ class Standard
         OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.PlanarSurface', "Could not determine the standards fenestration type for #{planar_surface.name} from #{construction.name}.  This surface will not have the standard applied.")
         return previous_construction_map
       end
+    # Exterior Doors
+    elsif surf_type == 'ExteriorDoor'
+      stds_type = standards_info.standardsConstructionType
+      if stds_type.is_initialized
+        stds_type = stds_type.get
+        case stds_type
+        when 'RollUp', 'Rollup', 'NonSwinging', 'Nonswinging'
+          stds_type = 'NonSwinging'
+        else
+          stds_type = 'Swinging'
+        end
+      else
+        OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.PlanarSurface', "Could not determine the standards construction type for exterior door #{planar_surface.name}.  This door will not have the standard applied.")
+        return previous_construction_map
+      end
     # All other surface types
     else
       stds_type = standards_info.standardsConstructionType

data/lib/openstudio-standards/standards/Standards.Space.rb

@@ -321,7 +321,7 @@ class Standard
               min_y_val = vertex.y
             end
             # Max y value
-            if vertex.y > max_x_val
+            if vertex.y > max_y_val
               max_y_val = vertex.y
             end
           end

data/lib/openstudio-standards/standards/Standards.SpaceType.rb

@@ -599,6 +599,13 @@ class Standard
     # switch to use this but update test in standards and measures to load this outside of the method
     construction_properties = model_find_object(standards_data['construction_properties'], search_criteria)
 
+    if !construction_properties
+      # Search again use climate zone (e.g. 3) instead of sub-climate zone (3A)
+      search_criteria['climate_zone_set'] = climate_zone_set[0..-2]
+      construction_properties = model_find_object(standards_data['construction_properties'], search_criteria)
+    end
+
+
     return construction_properties
   end
 end

data/lib/openstudio-standards/standards/Standards.ThermalZone.rb

@@ -602,12 +602,13 @@ class Standard
 
     # Get an array of the heating fuels
     # used by the zone.  Possible values are
-    # Electricity, NaturalGas, PropaneGas, FuelOilNo1, FuelOilNo2,
+    # Electricity, NaturalGas, Propane, PropaneGas, FuelOilNo1, FuelOilNo2,
     # Coal, Diesel, Gasoline, DistrictHeating,
     # and SolarEnergy.
     htg_fuels = thermal_zone.heating_fuels
 
     if htg_fuels.include?('NaturalGas') ||
+       htg_fuels.include?('Propane') ||
        htg_fuels.include?('PropaneGas') ||
        htg_fuels.include?('FuelOilNo1') ||
        htg_fuels.include?('FuelOilNo2') ||
@@ -641,6 +642,7 @@ class Standard
     # Fossil heating
     htg_fuels = thermal_zone.heating_fuels
     if htg_fuels.include?('NaturalGas') ||
+       htg_fuels.include?('Propane') ||
        htg_fuels.include?('PropaneGas') ||
        htg_fuels.include?('FuelOilNo1') ||
        htg_fuels.include?('FuelOilNo2') ||
@@ -703,7 +705,7 @@ class Standard
 
     # Get an array of the heating fuels
     # used by the zone.  Possible values are
-    # Electricity, NaturalGas, PropaneGas, FuelOilNo1, FuelOilNo2,
+    # Electricity, NaturalGas, Propane, PropaneGas, FuelOilNo1, FuelOilNo2,
     # Coal, Diesel, Gasoline, DistrictHeating,
     # and SolarEnergy.
     htg_fuels = thermal_zone.heating_fuels
@@ -711,6 +713,7 @@ class Standard
     # Includes fossil
     fossil = false
     if htg_fuels.include?('NaturalGas') ||
+       htg_fuels.include?('Propane') ||
        htg_fuels.include?('PropaneGas') ||
        htg_fuels.include?('FuelOilNo1') ||
        htg_fuels.include?('FuelOilNo2') ||

data/lib/openstudio-standards/standards/ashrae_90_1/ashrae_90_1_2004/ashrae_90_1_2004.Model.rb

@@ -1,16 +1,37 @@
 class ASHRAE9012004 < ASHRAE901
   # @!group Model
+  #
+  # Determine the surface range of a baseline model.
+  # The method calculates the window to wall ratio (assuming all spaces are conditioned)
+  # and select the range based on the calculated window to wall ratio
+  # @param model [OpenStudio::Model::Model] OpenStudio model object
+  # @param intended_surface_type [String] intended surface type
+  def model_get_percent_of_surface_range(model, intended_surface_type)
+    wwr_range = {}
 
-  # Determine which climate zone to use.
-  # Uses the most specific climate zone set for most
-  # climate zones, except for ClimateZone 3, which
-  # uses the least specific climate zone.
-  def model_get_climate_zone_set_from_list(model, possible_climate_zone_sets)
-    climate_zone_set = if possible_climate_zone_sets.include? 'ClimateZone 3'
-                         possible_climate_zone_sets.max
-                       else
-                         possible_climate_zone_sets.min
-                       end
-    return climate_zone_set
+    # Do not process surfaces other than exterior windows and glass door for 2004 standard
+    if intended_surface_type != 'ExteriorWindow' && intended_surface_type != 'GlassDoor'
+      wwr_range['minimum_percent_of_surface'] = nil
+      wwr_range['maximum_percent_of_surface'] = nil
+    else
+      wwr = model_get_window_area_info(model, true)
+      if wwr <= 10
+        wwr_range['minimum_percent_of_surface'] = 1.0
+        wwr_range['maximum_percent_of_surface'] = 10.0
+      elsif wwr <= 20
+        wwr_range['minimum_percent_of_surface'] = 10.001
+        wwr_range['maximum_percent_of_surface'] = 20
+      elsif wwr <= 30
+        wwr_range['minimum_percent_of_surface'] = 20.001
+        wwr_range['maximum_percent_of_surface'] = 30
+      elsif wwr <= 40
+        wwr_range['minimum_percent_of_surface'] = 30.001
+        wwr_range['maximum_percent_of_surface'] = 40
+      else
+        wwr_range['minimum_percent_of_surface'] = 40.001
+        wwr_range['maximum_percent_of_surface'] = 100.0
+      end
+    end
+    return wwr_range
   end
 end