openstudio-model-articulation 0.3.1 → 0.6.0

data/lib/measures/SetInteriorWallsToSelectedConstruction/measure.xml

@@ -1,9 +1,10 @@
+<?xml version="1.0"?>
 <measure>
   <schema_version>3.0</schema_version>
   <name>set_interior_walls_to_selected_construction</name>
   <uid>e3d59d0d-1ce8-4cb2-ae59-001f0fa2ac46</uid>
-  <version_id>01d5fe6b-b17f-4cf5-8fb7-c510611e4257</version_id>
-  <version_modified>20200229T024052Z</version_modified>
+  <version_id>bb0dd052-2f62-49ef-8e20-2e9c39786802</version_id>
+  <version_modified>20220505T182927Z</version_modified>
   <xml_checksum>1E963D9C</xml_checksum>
   <class_name>SetInteriorWallsToSelectedConstruction</class_name>
   <display_name>SetInteriorWallsToSelectedConstruction</display_name>
@@ -18,8 +19,8 @@
       <model_dependent>false</model_dependent>
     </argument>
   </arguments>
-  <outputs/>
-  <provenances/>
+  <outputs />
+  <provenances />
   <tags>
     <tag>Envelope.Opaque</tag>
   </tags>
@@ -54,6 +55,12 @@
       <usage_type>readme</usage_type>
       <checksum>C8974F9D</checksum>
     </file>
+    <file>
+      <filename>LICENSE.md</filename>
+      <filetype>md</filetype>
+      <usage_type>license</usage_type>
+      <checksum>A21A3ED2</checksum>
+    </file>
     <file>
       <version>
         <software_program>OpenStudio</software_program>
@@ -63,19 +70,13 @@
       <filename>measure.rb</filename>
       <filetype>rb</filetype>
       <usage_type>script</usage_type>
-      <checksum>934DE430</checksum>
+      <checksum>DC3C3C85</checksum>
     </file>
     <file>
       <filename>SetInteriorWallstoSelectedConstruction_Test.rb</filename>
       <filetype>rb</filetype>
       <usage_type>test</usage_type>
-      <checksum>AAF34E3E</checksum>
-    </file>
-    <file>
-      <filename>LICENSE.md</filename>
-      <filetype>md</filetype>
-      <usage_type>license</usage_type>
-      <checksum>E0468DD6</checksum>
+      <checksum>17B7EFF1</checksum>
     </file>
   </files>
 </measure>

data/lib/measures/SetWindowToWallRatioByFacade/LICENSE.md

@@ -1,4 +1,4 @@
-OpenStudio(R), Copyright (c) 2008-2020, Alliance for Sustainable Energy, LLC. All rights reserved.
+OpenStudio(R), Copyright (c) 2008-2021, Alliance for Sustainable Energy, LLC. All rights reserved.
 
 Redistribution and use in source and binary forms, with or without modification, are permitted 
 provided that the following conditions are met:

data/lib/measures/SetWindowToWallRatioByFacade/README.md

@@ -100,6 +100,17 @@ This will only impact exterior surfaces with specified orientation
 
 
 
+### Triangulation Minimum Area (m^2)
+Triangulated surfaces less than this will not be created.
+**Name:** triangulation_min_area,
+**Type:** Double,
+**Units:** ,
+**Required:** true,
+**Model Dependent:** false
+
+
+
+
 
 
 

data/lib/measures/SetWindowToWallRatioByFacade/measure.rb

@@ -1,5 +1,5 @@
 # *******************************************************************************
-# OpenStudio(R), Copyright (c) 2008-2020, Alliance for Sustainable Energy, LLC.
+# OpenStudio(R), Copyright (c) 2008-2021, Alliance for Sustainable Energy, LLC.
 # All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are met:
@@ -33,6 +33,8 @@
 # OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 # *******************************************************************************
 
+require_relative 'resources/functions'
+
 class SetWindowToWallRatioByFacade < OpenStudio::Measure::ModelMeasure
   # override name to return the name of your script
   def name
@@ -97,6 +99,13 @@ class SetWindowToWallRatioByFacade < OpenStudio::Measure::ModelMeasure
     triangulate.setDefaultValue(true)
     args << triangulate
 
+    # triangulation minimum area
+    triangulation_min_area = OpenStudio::Measure::OSArgument.makeDoubleArgument('triangulation_min_area', true)
+    triangulation_min_area.setDisplayName('Triangulation Minimum Area (m^2)')
+    triangulation_min_area.setDescription('Triangulated surfaces less than this will not be created.')
+    triangulation_min_area.setDefaultValue(0.001) # Two vertices < 0.01 meters apart are coincident in EnergyPlus (SurfaceGeometry.cc).
+    args << triangulation_min_area
+
     return args
   end
 
@@ -117,6 +126,7 @@ class SetWindowToWallRatioByFacade < OpenStudio::Measure::ModelMeasure
     split_at_doors = runner.getStringArgumentValue('split_at_doors', user_arguments)
     inset_tri_sub = runner.getBoolArgumentValue('inset_tri_sub', user_arguments)
     triangulate = runner.getBoolArgumentValue('triangulate', user_arguments)
+    triangulation_min_area = runner.getDoubleArgumentValue('triangulation_min_area', user_arguments)
 
     # check reasonableness of fraction
     if wwr == 0
@@ -192,6 +202,7 @@ class SetWindowToWallRatioByFacade < OpenStudio::Measure::ModelMeasure
       surfaces = []
       model.getSpaces.sort.each do |space|
         next if !space.partofTotalFloorArea
+
         space.surfaces.sort.each do |surface|
           surfaces << surface
         end
@@ -201,79 +212,14 @@ class SetWindowToWallRatioByFacade < OpenStudio::Measure::ModelMeasure
     end
 
     # used for new sub surfaces to find target construction
-    orig_sub_surf_const_for_target_facade = {}
-    orig_sub_surf_const_for_target_all_ext = {}
-
-    # pre-loop through sub-surfaces to store constructions
-    model.getSubSurfaces.sort.each do |sub_surf|
-      # store constructions for entire building
-      next if sub_surf.subSurfaceType == 'Door' || sub_surf.subSurfaceType == 'OverheadDoor'
-      if sub_surf.construction.is_initialized
-        if orig_sub_surf_const_for_target_all_ext.key?(sub_surf.construction.get)
-          orig_sub_surf_const_for_target_all_ext[sub_surf.construction.get] += 1
-        else
-          orig_sub_surf_const_for_target_all_ext[sub_surf.construction.get] = 1
-        end
-      end
-
-      # get the absoluteAzimuth for the surface so we can categorize it
-      absoluteAzimuth = OpenStudio.convert(sub_surf.azimuth, 'rad', 'deg').get + sub_surf.surface.get.space.get.directionofRelativeNorth + model.getBuilding.northAxis
-      absoluteAzimuth -= 360.0 until absoluteAzimuth < 360.0
-
-      if facade == 'North'
-        next if !((absoluteAzimuth >= 315.0) || (absoluteAzimuth < 45.0))
-      elsif facade == 'East'
-        next if !((absoluteAzimuth >= 45.0) && (absoluteAzimuth < 135.0))
-      elsif facade == 'South'
-        next if !((absoluteAzimuth >= 135.0) && (absoluteAzimuth < 225.0))
-      elsif facade == 'West'
-        next if !((absoluteAzimuth >= 225.0) && (absoluteAzimuth < 315.0))
-      elsif facade == 'All'
-        # no next needed
-      else
-        runner.registerError('Unexpected value of facade: ' + facade + '.')
-        return false
-      end
-
-      # store constructions for this facade
-      if sub_surf.construction.is_initialized
-        if orig_sub_surf_const_for_target_facade.key?(sub_surf.construction.get)
-          orig_sub_surf_const_for_target_facade[sub_surf.construction.get] += 1
-        else
-          orig_sub_surf_const_for_target_facade[sub_surf.construction.get] = 1
-        end
-      end
-    end
+    subsurfaces_by_facade = Functions.get_surfaces_or_subsurfaces_by_facade(model.getSubSurfaces, facade)
+    orig_sub_surf_const_for_target_facade = Functions.get_orig_sub_surf_const_for_target(subsurfaces_by_facade)
+    orig_sub_surf_const_for_target_all_ext = Functions.get_orig_sub_surf_const_for_target(model.getSubSurfaces)
 
     # hash for sub surfaces removed from non rectangular surfaces
     non_rect_parent = {}
 
-    surfaces.sort.each do |s|
-      next if s.surfaceType != 'Wall'
-      next if s.outsideBoundaryCondition != 'Outdoors'
-      if s.space.empty?
-        runner.registerWarning("#{s.name} doesn't have a parent space and won't be included in the measure reporting or modifications.")
-        next
-      end
-
-      # get the absoluteAzimuth for the surface so we can categorize it
-      absoluteAzimuth = OpenStudio.convert(s.azimuth, 'rad', 'deg').get + s.space.get.directionofRelativeNorth + model.getBuilding.northAxis
-      absoluteAzimuth -= 360.0 until absoluteAzimuth < 360.0
-
-      if facade == 'North'
-        next if !((absoluteAzimuth >= 315.0) || (absoluteAzimuth < 45.0))
-      elsif facade == 'East'
-        next if !((absoluteAzimuth >= 45.0) && (absoluteAzimuth < 135.0))
-      elsif facade == 'South'
-        next if !((absoluteAzimuth >= 135.0) && (absoluteAzimuth < 225.0))
-      elsif facade == 'West'
-        next if !((absoluteAzimuth >= 225.0) && (absoluteAzimuth < 315.0))
-      elsif facade == 'All'
-        # no next needed
-      else
-        runner.registerError('Unexpected value of facade: ' + facade + '.')
-        return false
-      end
+    Functions.get_surfaces_or_subsurfaces_by_facade(model.getSurfaces, facade).sort.each do |s|
       exterior_walls = true
 
       # get surface area adjusting for zone multiplier
@@ -317,6 +263,14 @@ class SetWindowToWallRatioByFacade < OpenStudio::Measure::ModelMeasure
 
       all_surfaces = [s]
       if split_at_doors == 'Split Walls at Doors' && has_doors
+
+        # remove windows before split at doors
+        s.subSurfaces.each do |sub_surface|
+          next if ['Door', 'OverheadDoor'].include? sub_surface.subSurfaceType
+
+          sub_surface.remove
+        end
+
         # split base surfaces at doors to create  multiple base surfaces
         split_surfaces = s.splitSurfaceForSubSurfaces.to_a # frozen array
 
@@ -332,22 +286,7 @@ class SetWindowToWallRatioByFacade < OpenStudio::Measure::ModelMeasure
         all_surfaces.sort.each do |ss|
           # see if surface is rectangular (only checking non rotated on vertical wall)
           # todo - add in more robust rectangle check that can look for rotate and tilted rectangles
-          rect_tri = false
-          x_vals = []
-          y_vals = []
-          z_vals = []
-          vertices = ss.vertices
-          flag = false
-          vertices.each do |vertex|
-            # initialize new vertex to old vertex
-            # rounding values to address tolerance issue 10 digits digits in
-            x_vals << vertex.x.round(8)
-            y_vals << vertex.y.round(8)
-            z_vals << vertex.z.round(8)
-          end
-          if x_vals.uniq.size <= 2 && y_vals.uniq.size <= 2 && z_vals.uniq.size <= 2
-            rect_tri = true
-          end
+          rect_tri = Functions.rectangle?(ss)
 
           has_doors = false
           ss.subSurfaces.sort.each do |subSurface|
@@ -377,8 +316,14 @@ class SetWindowToWallRatioByFacade < OpenStudio::Measure::ModelMeasure
             subSurface.remove
           end
 
+          # triangulate surface
           ss.triangulation.each do |tri|
             new_surface = OpenStudio::Model::Surface.new(tri, model)
+            if new_surface.grossArea < triangulation_min_area
+              runner.registerWarning("triangulation produced a surface with area less than minimum for surface = #{ss.name}")
+              new_surface.remove
+              next
+            end
             new_surface.setSpace(ss.space.get)
             if ss.construction.is_initialized && !ss.isConstructionDefaulted
               new_surface.setConstruction(ss.construction.get)
@@ -402,6 +347,7 @@ class SetWindowToWallRatioByFacade < OpenStudio::Measure::ModelMeasure
         orig_sub_surf_constructions = {}
         ss.subSurfaces.sort.each do |sub_surf|
           next if sub_surf.subSurfaceType == 'Door' || sub_surf.subSurfaceType == 'OverheadDoor'
+
           if sub_surf.construction.is_initialized
             if orig_sub_surf_constructions.key?(sub_surf.construction.get)
               orig_sub_surf_constructions[sub_surf.construction.get] += 1
@@ -425,38 +371,35 @@ class SetWindowToWallRatioByFacade < OpenStudio::Measure::ModelMeasure
         if wwr > 0 && new_window.empty?
 
           # if new window is empty then inset base surface to add window (check may need to skip on base surfaces with doors)
-          if inset_tri_sub
-
-            # skip of surface already has sub-surfaces or if not triangle
-            if ss.subSurfaces.empty? && ss.vertices.size <= 3
-              # get centroid
-              vertices = ss.vertices
-              centroid = OpenStudio.getCentroid(vertices).get
-              x_cent = centroid.x
-              y_cent = centroid.y
-              z_cent = centroid.z
-
-              # reduce vertices towards centroid
-              scale = Math.sqrt(wwr)
-              new_vertices = OpenStudio::Point3dVector.new
-              vertices.each do |vertex|
-                x = (vertex.x * scale + x_cent * (1.0 - scale))
-                y = (vertex.y * scale + y_cent * (1.0 - scale))
-                z = (vertex.z * scale + z_cent * (1.0 - scale))
-                new_vertices << OpenStudio::Point3d.new(x, y, z)
-              end
-
-              # create inset window
-              new_window = OpenStudio::Model::SubSurface.new(new_vertices, model)
-              new_window.setSurface(ss)
-              new_window.setSubSurfaceType('FixedWindow')
-              if non_rect_parent.key?(ss)
-                new_window.setConstruction(non_rect_parent[ss])
-              end
-              window_confirmed = true
+          # skip of surface already has sub-surfaces or if not triangle
+          if inset_tri_sub && (ss.subSurfaces.empty? && ss.vertices.size <= 3)
+            # get centroid
+            vertices = ss.vertices
+            centroid = OpenStudio.getCentroid(vertices).get
+            x_cent = centroid.x
+            y_cent = centroid.y
+            z_cent = centroid.z
+
+            # reduce vertices towards centroid
+            scale = Math.sqrt(wwr)
+            new_vertices = OpenStudio::Point3dVector.new
+            vertices.each do |vertex|
+              x = (vertex.x * scale + x_cent * (1.0 - scale))
+              y = (vertex.y * scale + y_cent * (1.0 - scale))
+              z = (vertex.z * scale + z_cent * (1.0 - scale))
+              new_vertices << OpenStudio::Point3d.new(x, y, z)
             end
 
+            # create inset window
+            new_window = OpenStudio::Model::SubSurface.new(new_vertices, model)
+            new_window.setSurface(ss)
+            new_window.setSubSurfaceType('FixedWindow')
+            if non_rect_parent.key?(ss)
+              new_window.setConstruction(non_rect_parent[ss])
+            end
+            window_confirmed = true
           end
+
         else
           if wwr > 0
             new_window = new_window.get
@@ -465,7 +408,38 @@ class SetWindowToWallRatioByFacade < OpenStudio::Measure::ModelMeasure
         end
 
         if !window_confirmed
-          runner.registerWarning("Fenestration could not be added for #{ss.name}. Surface may not be rectangular or triangular, may have a door, or the requested WWR may be too large.")
+          case ss.vertices.size
+          when 3
+            if !inset_tri_sub
+              runner.registerWarning("window could not be added because the surface has 3 sides, but the inset_tri_sub argument is false = #{ss.name}")
+            end
+          when 4
+            case Functions.rectangle?(ss)
+            when true
+              # if Functions.requested_window_area_greater_than_max?(ss, wwr)
+              #   runner.registerWarning("window could not be added because the surface has 4 sides and is rectangular, but the WWR exceeds the maximum = #{ss.name}")
+              # end
+              # HACK until requested_window_area_greater_than_max? works. reduce by 0.01 to find the "maximum".
+              (1..(wwr / 0.1).floor).each do |i|
+                wwr_adj = wwr - (i / 100.0)
+                new_window = ss.setWindowToWallRatio(wwr_adj, sillHeight_si.value, true)
+                unless new_window.empty?
+                  new_window = new_window.get
+                  window_confirmed = true
+                  runner.registerWarning("window-to-wall ratio exceeds maximum and was reduced to #{wwr_adj.round(3)} for surface = #{ss.name}")
+                  break
+                end
+              end
+            when false
+              if !triangulate
+                runner.registerWarning("window could not be added because the surface has 4 sides, but is not rectangular and the triangulate argument is false = #{ss.name}")
+              end
+            end
+          else
+            if !triangulate
+              runner.registerWarning("window could not be added because the surface has more than 4 sides and the triangulate argument is false = #{ss.name}")
+            end
+          end
         end
 
         # warn user if resulting window doesn't have a construction, as it will result in failed simulation. In the future may use logic from starting windows to apply construction to new window.
@@ -522,33 +496,7 @@ class SetWindowToWallRatioByFacade < OpenStudio::Measure::ModelMeasure
     end
 
     # data for final condition wwr
-    surfaces.sort.each do |s|
-      next if s.surfaceType != 'Wall'
-      next if s.outsideBoundaryCondition != 'Outdoors'
-      if s.space.empty?
-        runner.registerWarning("#{s.name} doesn't have a parent space and won't be included in the measure reporting or modifications.")
-        next
-      end
-
-      # get the absoluteAzimuth for the surface so we can categorize it
-      absoluteAzimuth = OpenStudio.convert(s.azimuth, 'rad', 'deg').get + s.space.get.directionofRelativeNorth + model.getBuilding.northAxis
-      absoluteAzimuth -= 360.0 until absoluteAzimuth < 360.0
-
-      if facade == 'North'
-        next if !((absoluteAzimuth >= 315.0) || (absoluteAzimuth < 45.0))
-      elsif facade == 'East'
-        next if !((absoluteAzimuth >= 45.0) && (absoluteAzimuth < 135.0))
-      elsif facade == 'South'
-        next if !((absoluteAzimuth >= 135.0) && (absoluteAzimuth < 225.0))
-      elsif facade == 'West'
-        next if !((absoluteAzimuth >= 225.0) && (absoluteAzimuth < 315.0))
-      elsif facade == 'All'
-        # no next needed
-      else
-        runner.registerError('Unexpected value of facade: ' + facade + '.')
-        return false
-      end
-
+    Functions.get_surfaces_or_subsurfaces_by_facade(model.getSurfaces, facade).sort.each do |s|
       # get surface area adjusting for zone multiplier
       space = s.space
       if !space.empty?

data/lib/measures/SetWindowToWallRatioByFacade/measure.xml

@@ -3,8 +3,8 @@
   <schema_version>3.0</schema_version>
   <name>set_window_to_wall_ratio_by_facade</name>
   <uid>c567a0bf-a7d9-4a06-afe9-bf7df79e6bf8</uid>
-  <version_id>ba8a1d2e-0d49-4e86-9aba-f4d55097f358</version_id>
-  <version_modified>20200928T200703Z</version_modified>
+  <version_id>d0d69032-509b-4257-a4c5-74e0e4615cc4</version_id>
+  <version_modified>20220505T182928Z</version_modified>
   <xml_checksum>6DE831F7</xml_checksum>
   <class_name>SetWindowToWallRatioByFacade</class_name>
   <display_name>Set Window to Wall Ratio by Facade</display_name>
@@ -153,6 +153,15 @@ The measure doesn?t have any cost or lifecycle arguments, however If lifecycle o
         </choice>
       </choices>
     </argument>
+    <argument>
+      <name>triangulation_min_area</name>
+      <display_name>Triangulation Minimum Area (m^2)</display_name>
+      <description>Triangulated surfaces less than this will not be created.</description>
+      <type>Double</type>
+      <required>true</required>
+      <model_dependent>false</model_dependent>
+      <default_value>0.001</default_value>
+    </argument>
   </arguments>
   <outputs />
   <provenances />
@@ -212,17 +221,29 @@ The measure doesn?t have any cost or lifecycle arguments, however If lifecycle o
       <usage_type>readmeerb</usage_type>
       <checksum>232D0477</checksum>
     </file>
+    <file>
+      <filename>LICENSE.md</filename>
+      <filetype>md</filetype>
+      <usage_type>license</usage_type>
+      <checksum>A21A3ED2</checksum>
+    </file>
+    <file>
+      <filename>prototype_sec_sch.osm</filename>
+      <filetype>osm</filetype>
+      <usage_type>test</usage_type>
+      <checksum>581DA01B</checksum>
+    </file>
     <file>
       <filename>README.md</filename>
       <filetype>md</filetype>
       <usage_type>readme</usage_type>
-      <checksum>C85B9D94</checksum>
+      <checksum>7FCCDC8E</checksum>
     </file>
     <file>
-      <filename>LICENSE.md</filename>
-      <filetype>md</filetype>
-      <usage_type>license</usage_type>
-      <checksum>E0468DD6</checksum>
+      <filename>SetWindowToWallRatioByFacade_Test.rb</filename>
+      <filetype>rb</filetype>
+      <usage_type>test</usage_type>
+      <checksum>2FAF08A3</checksum>
     </file>
     <file>
       <version>
@@ -233,13 +254,13 @@ The measure doesn?t have any cost or lifecycle arguments, however If lifecycle o
       <filename>measure.rb</filename>
       <filetype>rb</filetype>
       <usage_type>script</usage_type>
-      <checksum>CB9895D2</checksum>
+      <checksum>E1F85411</checksum>
     </file>
     <file>
-      <filename>SetWindowToWallRatioByFacade_Test.rb</filename>
+      <filename>functions.rb</filename>
       <filetype>rb</filetype>
-      <usage_type>test</usage_type>
-      <checksum>268FC2B7</checksum>
+      <usage_type>resource</usage_type>
+      <checksum>8AFBC32D</checksum>
     </file>
   </files>
 </measure>

data/lib/measures/SetWindowToWallRatioByFacade/resources/functions.rb

@@ -0,0 +1,176 @@
+# *******************************************************************************
+# OpenStudio(R), Copyright (c) 2008-2021, Alliance for Sustainable Energy, LLC.
+# All rights reserved.
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are met:
+#
+# (1) Redistributions of source code must retain the above copyright notice,
+# this list of conditions and the following disclaimer.
+#
+# (2) Redistributions in binary form must reproduce the above copyright notice,
+# this list of conditions and the following disclaimer in the documentation
+# and/or other materials provided with the distribution.
+#
+# (3) Neither the name of the copyright holder nor the names of any contributors
+# may be used to endorse or promote products derived from this software without
+# specific prior written permission from the respective party.
+#
+# (4) Other than as required in clauses (1) and (2), distributions in any form
+# of modifications or other derivative works may not use the "OpenStudio"
+# trademark, "OS", "os", or any other confusingly similar designation without
+# specific prior written permission from Alliance for Sustainable Energy, LLC.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDER(S) AND ANY CONTRIBUTORS
+# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+# THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+# ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER(S), ANY CONTRIBUTORS, THE
+# UNITED STATES GOVERNMENT, OR THE UNITED STATES DEPARTMENT OF ENERGY, NOR ANY OF
+# THEIR EMPLOYEES, BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+# EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT
+# OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
+# STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
+# OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+# *******************************************************************************
+
+require 'openstudio'
+
+module Functions
+  # return an array of surfaces or subsurfaces from a specific facade.
+  def self.get_surfaces_or_subsurfaces_by_facade(surfaces_or_subsurfaces, facade)
+    surfaces_or_subsurfaces_by_facade = []
+
+    surfaces_or_subsurfaces.each do |surface_or_subsurface|
+      case surface_or_subsurface.class.to_s.gsub('OpenStudio::Model::', '')
+      when 'Surface'
+        next if surface_or_subsurface.surfaceType != 'Wall'
+        next if surface_or_subsurface.outsideBoundaryCondition != 'Outdoors'
+
+        if surface_or_subsurface.space.empty?
+          runner.registerWarning("#{surface_or_subsurface.name} doesn't have a parent space and won't be included in the measure reporting or modifications.")
+          next
+        end
+        direction_of_relative_north = surface_or_subsurface.space.get.directionofRelativeNorth
+      when 'SubSurface'
+        next if surface_or_subsurface.subSurfaceType == 'Door' || surface_or_subsurface.subSurfaceType == 'OverheadDoor'
+
+        direction_of_relative_north = surface_or_subsurface.surface.get.space.get.directionofRelativeNorth
+      end
+
+      # get the absoluteAzimuth for the surface so we can categorize it
+      absoluteAzimuth = OpenStudio.convert(surface_or_subsurface.azimuth, 'rad', 'deg').get + direction_of_relative_north + surface_or_subsurface.model.getBuilding.northAxis
+      absoluteAzimuth -= 360.0 until absoluteAzimuth < 360.0
+
+      case facade
+      when 'North'
+        next if !((absoluteAzimuth >= 315.0) || (absoluteAzimuth < 45.0))
+      when 'East'
+        next if !((absoluteAzimuth >= 45.0) && (absoluteAzimuth < 135.0))
+      when 'South'
+        next if !((absoluteAzimuth >= 135.0) && (absoluteAzimuth < 225.0))
+      when 'West'
+        next if !((absoluteAzimuth >= 225.0) && (absoluteAzimuth < 315.0))
+      when 'All'
+        # no next needed
+      else
+        runner.registerError("Unexpected value of facade: #{facade}.")
+        return false
+      end
+
+      surfaces_or_subsurfaces_by_facade << surface_or_subsurface
+    end
+
+    return surfaces_or_subsurfaces_by_facade
+  end
+
+  # return a hash of subsurface constructions.
+  def self.get_orig_sub_surf_const_for_target(subsurfaces)
+    orig_sub_surf_const_for_target = {}
+
+    subsurfaces.each do |subsurface|
+      next if subsurface.subSurfaceType == 'Door' || subsurface.subSurfaceType == 'OverheadDoor'
+
+      if subsurface.construction.is_initialized
+        if orig_sub_surf_const_for_target.key?(subsurface.construction.get)
+          orig_sub_surf_const_for_target[subsurface.construction.get] += 1
+        else
+          orig_sub_surf_const_for_target[subsurface.construction.get] = 1
+        end
+      end
+    end
+
+    return orig_sub_surf_const_for_target
+  end
+
+  # see if surface is rectangular (only checking non rotated on vertical wall)
+  # todo - add in more robust rectangle check that can look for rotate and tilted rectangles
+  def self.rectangle?(surface)
+    x_vals = []
+    y_vals = []
+    z_vals = []
+    vertices = surface.vertices
+    vertices.each do |vertex|
+      # initialize new vertex to old vertex
+      # rounding values to address tolerance issue 10 digits digits in
+      x_vals << vertex.x.round(4)
+      y_vals << vertex.y.round(4)
+      z_vals << vertex.z.round(4)
+    end
+    if x_vals.uniq.size <= 2 && y_vals.uniq.size <= 2 && z_vals.uniq.size <= 2
+      return true
+    else
+      return false
+    end
+  end
+
+  # return true if the requested window-to-wall area exceeds the maximum allowed area, false if not.
+  # implements the following part of the applyViewAndDaylightingGlassRatios method, which is what setWindowToWallRatio uses.
+  # https://github.com/NREL/OpenStudio/blob/760613c7ac9c2093f7dbd65f947a6853356c558d/src/utilities/geometry/Geometry.cpp#L605-L695
+  def self.requested_window_area_greater_than_max?(surface, viewGlassToWallRatio)
+    daylightingGlassToWallRatio = 0
+    totalWWR = viewGlassToWallRatio + daylightingGlassToWallRatio
+
+    vertices = surface.vertices
+    transformation = OpenStudio::Transformation.alignFace(vertices)
+    faceVertices = transformation.inverse * vertices
+
+    # // new coordinate system has z' in direction of outward normal, y' is up
+    xmin = 0
+    xmax = 0
+    ymin = 0
+    ymax = 0
+    faceVertices.each do |faceVertex|
+      xmin = [xmin, faceVertex.x].min
+      xmax = [xmax, faceVertex.x].max
+      ymin = [ymin, faceVertex.y].min
+      ymax = [ymax, faceVertex.y].max
+    end
+
+    oneInch = 0.0254 # meters
+
+    # // DLM: preserve a 1" gap between window and edge to keep SketchUp happy
+    minGlassToEdgeDistance = oneInch
+    minViewToDaylightDistance = 0
+
+    # // wall parameters
+    wallWidth = xmax - xmin
+    wallHeight = ymax - ymin
+    wallArea = wallWidth * wallHeight
+
+    # return false if wallWidth < 2 * minGlassToEdgeDistance
+
+    # return false if wallHeight < 2 * minGlassToEdgeDistance + minViewToDaylightDistance
+
+    maxWindowArea = wallArea - 2 * wallHeight * minGlassToEdgeDistance
+    - (wallWidth - 2 * minGlassToEdgeDistance) * (2 * minGlassToEdgeDistance + minViewToDaylightDistance)
+    requestedViewArea = viewGlassToWallRatio * wallArea
+    requestedDaylightingArea = daylightingGlassToWallRatio * wallArea
+    requestedTotalWindowArea = totalWWR * wallArea
+
+    if requestedTotalWindowArea > maxWindowArea
+      return true
+    else
+      return false
+    end
+  end
+end

data/lib/measures/SimplifyGeometryToSlicedBar/LICENSE.md

@@ -1,4 +1,4 @@
-OpenStudio(R), Copyright (c) 2008-2020, Alliance for Sustainable Energy, LLC. All rights reserved.
+OpenStudio(R), Copyright (c) 2008-2021, Alliance for Sustainable Energy, LLC. All rights reserved.
 
 Redistribution and use in source and binary forms, with or without modification, are permitted 
 provided that the following conditions are met: