openstudio-model-articulation 0.3.1 → 0.6.0

data/lib/measures/create_baseline_building/LICENSE.md

@@ -1,4 +1,4 @@
-OpenStudio(R), Copyright (c) 2008-2020, Alliance for Sustainable Energy, LLC. All rights reserved.
+OpenStudio(R), Copyright (c) 2008-2021, Alliance for Sustainable Energy, LLC. All rights reserved.
 
 Redistribution and use in source and binary forms, with or without modification, are permitted 
 provided that the following conditions are met:

data/lib/measures/create_baseline_building/measure.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 # *******************************************************************************
-# OpenStudio(R), Copyright (c) 2008-2020, Alliance for Sustainable Energy, LLC.
+# OpenStudio(R), Copyright (c) 2008-2021, Alliance for Sustainable Energy, LLC.
 # All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are met:
@@ -233,7 +233,7 @@ class CreateBaselineBuilding < OpenStudio::Measure::ModelMeasure
 
     log_msgs(debug)
     return success
-  end # end the run method
+  end
 
   # Get all the log messages and put into output
   # for users to see.
@@ -253,6 +253,7 @@ class CreateBaselineBuilding < OpenStudio::Measure::ModelMeasure
                 msg.logChannel.include?('Translator') || # Forward translator and geometry translator
                 msg.logMessage.include?('UseWeatherFile') || # 'UseWeatherFile' is not yet a supported option for YearDescription
                 msg.logMessage.include?('has multiple parents') # Object of type 'OS:Curve:Cubic' and named 'VSD-TWR-FAN-FPLR' has multiple parents. Returning the first.
+
         # Report the message in the correct way
         if msg.logLevel == OpenStudio::Info
           @runner.registerInfo(msg.logMessage)
@@ -267,7 +268,7 @@ class CreateBaselineBuilding < OpenStudio::Measure::ModelMeasure
     end
     @runner.registerInfo("Total Time = #{(Time.new - @start_time).round}sec.")
   end
-end # end the measure
+end
 
 # this allows the measure to be use by the application
 CreateBaselineBuilding.new.registerWithApplication

data/lib/measures/create_baseline_building/measure.xml

@@ -3,8 +3,8 @@
   <schema_version>3.0</schema_version>
   <name>create_baseline_building</name>
   <uid>4de56e21-b6cd-45d9-8466-862507d228b2</uid>
-  <version_id>aa1e11a0-3fb8-4aff-a93b-38a94736f3c6</version_id>
-  <version_modified>20200624T003805Z</version_modified>
+  <version_id>0b726224-752c-4961-9422-505c2e506f99</version_id>
+  <version_modified>20220505T182926Z</version_modified>
   <xml_checksum>A514F332</xml_checksum>
   <class_name>CreateBaselineBuilding</class_name>
   <display_name>Create Baseline Building</display_name>
@@ -263,13 +263,13 @@
       <filename>LICENSE.md</filename>
       <filetype>md</filetype>
       <usage_type>license</usage_type>
-      <checksum>E0468DD6</checksum>
+      <checksum>A21A3ED2</checksum>
     </file>
     <file>
       <filename>create_baseline_building_test.rb</filename>
       <filetype>rb</filetype>
       <usage_type>test</usage_type>
-      <checksum>1758475B</checksum>
+      <checksum>56AD4C78</checksum>
     </file>
     <file>
       <version>
@@ -280,7 +280,7 @@
       <filename>measure.rb</filename>
       <filetype>rb</filetype>
       <usage_type>script</usage_type>
-      <checksum>4E3D13AE</checksum>
+      <checksum>70026B27</checksum>
     </file>
   </files>
 </measure>

data/lib/measures/create_deer_prototype_building/LICENSE.md

@@ -1,4 +1,4 @@
-OpenStudio(R), Copyright (c) 2008-2020, Alliance for Sustainable Energy, LLC. All rights reserved.
+OpenStudio(R), Copyright (c) 2008-2021, Alliance for Sustainable Energy, LLC. All rights reserved.
 
 Redistribution and use in source and binary forms, with or without modification, are permitted 
 provided that the following conditions are met:

data/lib/measures/create_deer_prototype_building/measure.rb

@@ -1,5 +1,5 @@
 # *******************************************************************************
-# OpenStudio(R), Copyright (c) 2008-2020, Alliance for Sustainable Energy, LLC.
+# OpenStudio(R), Copyright (c) 2008-2021, Alliance for Sustainable Energy, LLC.
 # All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are met:

data/lib/measures/create_deer_prototype_building/measure.xml

@@ -3,8 +3,8 @@
   <schema_version>3.0</schema_version>
   <name>create_deer_prototype_building</name>
   <uid>752055bd-10d9-4ede-8a35-18487fedf579</uid>
-  <version_id>3aef0d72-786e-47a0-b144-dfd6cb6c90ff</version_id>
-  <version_modified>20200624T003806Z</version_modified>
+  <version_id>8b85f282-639e-4a80-af9d-cdfefeb38c47</version_id>
+  <version_modified>20220505T182926Z</version_modified>
   <xml_checksum>A514F332</xml_checksum>
   <class_name>CreateDEERPrototypeBuilding</class_name>
   <display_name>Create DEER Prototype Building ALPHA Version</display_name>
@@ -816,13 +816,13 @@
       <filename>LICENSE.md</filename>
       <filetype>md</filetype>
       <usage_type>license</usage_type>
-      <checksum>E0468DD6</checksum>
+      <checksum>A21A3ED2</checksum>
     </file>
     <file>
       <filename>deer_building_types.rb</filename>
       <filetype>rb</filetype>
       <usage_type>resource</usage_type>
-      <checksum>046B6023</checksum>
+      <checksum>1811336C</checksum>
     </file>
     <file>
       <version>
@@ -833,13 +833,13 @@
       <filename>measure.rb</filename>
       <filetype>rb</filetype>
       <usage_type>script</usage_type>
-      <checksum>C614EF0D</checksum>
+      <checksum>9D69B5B2</checksum>
     </file>
     <file>
       <filename>create_DEER_prototype_building_test.rb</filename>
       <filetype>rb</filetype>
       <usage_type>test</usage_type>
-      <checksum>57A1B14A</checksum>
+      <checksum>94E3EAF7</checksum>
     </file>
   </files>
 </measure>

data/lib/measures/create_deer_prototype_building/resources/deer_building_types.rb

@@ -1,5 +1,5 @@
 # *******************************************************************************
-# OpenStudio(R), Copyright (c) 2008-2020, Alliance for Sustainable Energy, LLC.
+# OpenStudio(R), Copyright (c) 2008-2021, Alliance for Sustainable Energy, LLC.
 # All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are met:

data/lib/measures/create_parametric_schedules/LICENSE.md

@@ -1,4 +1,4 @@
-OpenStudio(R), Copyright (c) 2008-2020, Alliance for Sustainable Energy, LLC. All rights reserved.
+OpenStudio(R), Copyright (c) 2008-2021, Alliance for Sustainable Energy, LLC. All rights reserved.
 
 Redistribution and use in source and binary forms, with or without modification, are permitted 
 provided that the following conditions are met:

data/lib/measures/create_parametric_schedules/measure.rb

@@ -1,5 +1,5 @@
 # *******************************************************************************
-# OpenStudio(R), Copyright (c) 2008-2020, Alliance for Sustainable Energy, LLC.
+# OpenStudio(R), Copyright (c) 2008-2021, Alliance for Sustainable Energy, LLC.
 # All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are met:
@@ -41,7 +41,7 @@ require 'json'
 # load OpenStudio measure libraries from openstudio-extension gem
 require 'openstudio-extension'
 require 'openstudio/extension/core/os_lib_helper_methods'
-require 'openstudio/extension/core/os_lib_schedules.rb'
+require 'openstudio/extension/core/os_lib_schedules'
 
 # start the measure
 class CreateParametricSchedules < OpenStudio::Measure::ModelMeasure
@@ -206,7 +206,7 @@ class CreateParametricSchedules < OpenStudio::Measure::ModelMeasure
     occupancy_profiles.setDefaultValue(string.join(', '))
     args << occupancy_profiles
 
-    # note: infiltration, setpoints, and hvac availability follow the same time parameters but use different values
+    # NOTE: infiltration, setpoints, and hvac availability follow the same time parameters but use different values
 
     # Make argument for infiltration_profiles
     string = []
@@ -336,13 +336,14 @@ class CreateParametricSchedules < OpenStudio::Measure::ModelMeasure
       # day_type specific gsub
       temp_array.each_with_index do |string, i|
         day_type = string.split('=>').first.delete(':')
-        if day_type == 'default'
+        case day_type
+        when 'default'
           hoo_start = args['hoo_start_wkdy']
           hoo_end = args['hoo_end_wkdy']
-        elsif day_type == 'saturday'
+        when 'saturday'
           hoo_start = args['hoo_start_sat']
           hoo_end = args['hoo_end_sat']
-        elsif day_type == 'sunday'
+        when 'sunday'
           hoo_start = args['hoo_start_sun']
           hoo_end = args['hoo_end_sun']
         end
@@ -364,7 +365,7 @@ class CreateParametricSchedules < OpenStudio::Measure::ModelMeasure
       final_string = temp_array.join(']], :')
 
       hash = eval("{#{final_string}}").to_hash
-    rescue SyntaxError => se
+    rescue SyntaxError => e
       runner.registerError("{#{final_string}} could not be converted to a hash.")
       return false
     end
@@ -478,7 +479,7 @@ class CreateParametricSchedules < OpenStudio::Measure::ModelMeasure
           time_values_used << time_value_pair[0]
         end
       end
-      items_to_remove.reverse.each do |i|
+      items_to_remove.reverse_each do |i|
         time_value_pairs.delete_at(i)
       end
 
@@ -500,11 +501,12 @@ class CreateParametricSchedules < OpenStudio::Measure::ModelMeasure
       end
 
       # add on text needed for createComplexSchedule
-      if day_type == :saturday
+      case day_type
+      when :saturday
         time_value_pairs.insert(0, 'Sat')
         time_value_pairs.insert(0, '1/1-12/31')
         time_value_pairs.insert(0, 'Saturday')
-      elsif day_type == :sunday
+      when :sunday
         time_value_pairs.insert(0, 'Sun')
         time_value_pairs.insert(0, '1/1-12/31')
         time_value_pairs.insert(0, 'Sunday')
@@ -623,6 +625,7 @@ class CreateParametricSchedules < OpenStudio::Measure::ModelMeasure
         next if space_type.standardsSpaceType.get != args['standards_space_type']
       end
       next if space_type.spaces.empty?
+
       space_types_to_alter << space_type
     end
 
@@ -646,6 +649,7 @@ class CreateParametricSchedules < OpenStudio::Measure::ModelMeasure
       # remove schedule sets.
       model.getDefaultScheduleSets.each do |sch_set|
         next if sch_set == default_schedule_set
+
         sch_set.remove
       end
 
@@ -703,6 +707,7 @@ class CreateParametricSchedules < OpenStudio::Measure::ModelMeasure
       if args['alter_swh_wo_space']
         model.getWaterUseEquipments.each do |water_use_equipment|
           next if water_use_equipment.space.is_initialized
+
           water_use_equipment_to_alter << water_use_equipment
         end
       end
@@ -860,7 +865,7 @@ class CreateParametricSchedules < OpenStudio::Measure::ModelMeasure
     hash = process_hash(runner, args['hvac_availability_profiles'], args, profile_override, ruleset_name)
     if !hash then runner.registerError("Failed to generate #{ruleset_name}"); return false end
     winter_design_day = [[24, 1]] # TODO: - confirm proper value
-    summer_design_day = [[24, 1]] # todo - confirm proper value
+    summer_design_day = [[24, 1]] # TODO: - confirm proper value
     default_day = hash[:default]
     rules = []
     rules << hash[:saturday]

data/lib/measures/create_parametric_schedules/measure.xml

@@ -3,8 +3,8 @@
   <schema_version>3.0</schema_version>
   <name>create_parametric_schedules</name>
   <uid>befa8099-c6a7-4045-8792-53fc7124b862</uid>
-  <version_id>feffd422-7afb-49cf-b8ad-3da237d78c65</version_id>
-  <version_modified>20200509T155940Z</version_modified>
+  <version_id>41022be2-227f-4c93-8ff0-8970d23eef8e</version_id>
+  <version_modified>20220505T182933Z</version_modified>
   <xml_checksum>03F02484</xml_checksum>
   <class_name>CreateParametricSchedules</class_name>
   <display_name>Create Parametric Schedules</display_name>
@@ -321,7 +321,7 @@
       <filename>LICENSE.md</filename>
       <filetype>md</filetype>
       <usage_type>license</usage_type>
-      <checksum>E0468DD6</checksum>
+      <checksum>A21A3ED2</checksum>
     </file>
     <file>
       <version>
@@ -332,13 +332,13 @@
       <filename>measure.rb</filename>
       <filetype>rb</filetype>
       <usage_type>script</usage_type>
-      <checksum>D7799451</checksum>
+      <checksum>374552A6</checksum>
     </file>
     <file>
       <filename>create_parametric_schedules_test.rb</filename>
       <filetype>rb</filetype>
       <usage_type>test</usage_type>
-      <checksum>35C96C2F</checksum>
+      <checksum>691911FE</checksum>
     </file>
   </files>
 </measure>

data/lib/measures/create_typical_building_from_model/LICENSE.md

@@ -1,4 +1,4 @@
-OpenStudio(R), Copyright (c) 2008-2020, Alliance for Sustainable Energy, LLC. All rights reserved.
+OpenStudio(R), Copyright (c) 2008-2021, Alliance for Sustainable Energy, LLC. All rights reserved.
 
 Redistribution and use in source and binary forms, with or without modification, are permitted 
 provided that the following conditions are met: