openstudio-common-measures 0.4.0 → 0.6.1

data/lib/measures/generic_qaqc/resources/check_eui_by_end_use.rb

@@ -38,33 +38,46 @@ module OsLib_QAQC
 
   # checks the number of unmet hours in the model
   def check_eui_by_end_use(category, target_standard, min_pass, max_pass, name_only = false)
+
     # summary of the check
     check_elems = OpenStudio::AttributeVector.new
     check_elems << OpenStudio::Attribute.new('name', 'End Use by Category')
     check_elems << OpenStudio::Attribute.new('category', category)
-    check_elems << OpenStudio::Attribute.new('description', "Check end use by category against #{target_standard} DOE prototype buildings.")
+
+    # update display sttandard
+    if target_standard.include?('90.1')
+      display_standard = "ASHRAE #{target_standard}"
+    else
+      display_standard = target_standard
+    end
 
     # stop here if only name is requested this is used to populate display name for arguments
     if name_only == true
       results = []
+      check_elems << OpenStudio::Attribute.new('description', "Check model consumption by end use against #{target_standard} DOE prototype building.")
       check_elems.each do |elem|
         results << elem.valueAsString
       end
       return results
     end
 
-    # Versions of OpenStudio greater than 2.4.0 use a modified version of
-    # openstudio-standards with different method calls.  These methods
-    # require a "Standard" object instead of the standard being passed into method calls.
-    # This Standard object is used throughout the QAQC check.
-    if OpenStudio::VersionString.new(OpenStudio.openStudioVersion) < OpenStudio::VersionString.new('2.4.3')
-      use_old_gem_code = true
-    else
-      use_old_gem_code = false
+    begin
+
+      # setup standard
       std = Standard.build(target_standard)
-    end
+      target_eui = std.model_find_target_eui(@model)
+
+      # gather building type for summary
+      bt_cz = std.model_get_building_climate_zone_and_building_type(@model)
+      building_type = bt_cz['building_type']
+      # mapping to obuilding type to match space types
+      if building_type.include?("Office") then building_type = "Office" end
+      climate_zone = bt_cz['climate_zone']
+      prototype_prefix = "#{display_standard} #{building_type} #{climate_zone}"
+      check_elems << OpenStudio::Attribute.new('description', "Check model consumption by end use against #{prototype_prefix} DOE prototype building.")
+      check_elems << OpenStudio::Attribute.new('min_pass', min_pass * 100)
+      check_elems << OpenStudio::Attribute.new('max_pass', max_pass * 100)
 
-    begin
       # total building area
       query = 'SELECT Value FROM tabulardatawithstrings WHERE '
       query << "ReportName='AnnualBuildingUtilityPerformanceSummary' and "
@@ -107,14 +120,36 @@ module OsLib_QAQC
         actual_eui_by_end_use[end_use] = total_end_use / energy_plus_area
       end
 
-      # gather target end uses for given standard as hash
-      if use_old_gem_code
-        target_eui_by_end_use = @model.find_target_eui_by_end_use(target_standard)
-      else
-        std = Standard.build(target_standard)
-        target_eui_by_end_use = std.model_find_target_eui_by_end_use(@model)
+      # check if all spaces types used the building type defined in the model (percentage calculation doesn't check if all area is inclued in building floor area)
+      if building_type != ''
+        primary_type_floor_area = 0.0
+        non_pri_area = 0.0
+        non_pri_types = []
+        @model.getSpaceTypes.each do |space_type|
+          st_bt = space_type.standardsBuildingType
+          if st_bt.is_initialized
+              st_bt = st_bt.get.to_s
+              if st_bt.include?("Office") then st_bt = "Office" end
+              if st_bt.to_s == building_type.to_s
+                primary_type_floor_area += space_type.floorArea
+              else
+                non_pri_area += space_type.floorArea
+                if !non_pri_types.include?(st_bt) then non_pri_types << st_bt end
+              end
+          else
+            non_pri_area += space_type.floorArea
+            if !non_pri_types.include?(st_bt) then non_pri_types << st_bt end
+          end
+        end
+        if non_pri_area > 0.0
+          check_elems << OpenStudio::Attribute.new('flag', "The primary building type, #{building_type}, only represents #{(100 * primary_type_floor_area / (primary_type_floor_area + non_pri_area)).round}% of the total building area. Other standads building types included are #{non_pri_types.sort.join(",")}. While a comparison to the #{building_type} prototype consumption by end use is provided, it would not be unexpected for the building consumption by end use to be significantly different than the prototype.")
+        end
       end
 
+      # gather target end uses for given standard as hash
+      std = Standard.build(target_standard)
+      target_eui_by_end_use = std.model_find_target_eui_by_end_use(@model)
+
       # units for flag display text and unit conversion
       source_units = 'GJ/m^2'
       target_units = 'kBtu/ft^2'
@@ -136,13 +171,17 @@ module OsLib_QAQC
           if (end_use == 'Pumps') && (value < 0.05) && (target_value < 0.05) then skip = true end
 
           if (value < target_value * (1.0 - min_pass)) && !skip
-            check_elems << OpenStudio::Attribute.new('flag', "#{end_use} EUI of #{eui_ip_neat} (#{target_units}) is less than #{min_pass * 100} % below the expected #{end_use} EUI of #{target_eui_ip_neat} (#{target_units}) for #{target_standard}.")
+            check_elems << OpenStudio::Attribute.new('flag', "#{end_use} EUI of #{eui_ip_neat} (#{target_units}) is more than #{min_pass * 100} % below the #{prototype_prefix} prototype #{end_use} EUI of #{target_eui_ip_neat} (#{target_units}) for #{target_standard}.")
           elsif (value > target_value * (1.0 + max_pass)) && !skip
-            check_elems << OpenStudio::Attribute.new('flag', "#{end_use} EUI of #{eui_ip_neat} (#{target_units}) is more than #{max_pass * 100} % above the expected #{end_use} EUI of #{target_eui_ip_neat} (#{target_units}) for #{target_standard}.")
+            check_elems << OpenStudio::Attribute.new('flag', "#{end_use} EUI of #{eui_ip_neat} (#{target_units}) is more than #{max_pass * 100} % above the #{prototype_prefix} prototype #{end_use} EUI of #{target_eui_ip_neat} (#{target_units}) for #{target_standard}.")
           end
         end
       else
-        check_elems << OpenStudio::Attribute.new('flag', "Can't calculate target end use EUIs. Make sure model has expected climate zone and building type.")
+        if ['90.1-2016','90.1-2019'].include?(target_standard) || target_standard.include?("ComStock")
+          check_elems << OpenStudio::Attribute.new('flag', "target EUI end use comparison is not supported yet for #{target_standard}.")
+        else
+          check_elems << OpenStudio::Attribute.new('flag', "Can't calculate target end use EUIs. Make sure model has expected climate zone and building type.")
+        end
       end
     rescue StandardError => e
       # brief description of ruby error

data/lib/measures/generic_qaqc/resources/check_eui_reasonableness.rb

@@ -38,14 +38,22 @@ module OsLib_QAQC
 
   # checks the number of unmet hours in the model
   def check_eui_reasonableness(category, target_standard, min_pass, max_pass, name_only = false)
+
     # summary of the check
     check_elems = OpenStudio::AttributeVector.new
     check_elems << OpenStudio::Attribute.new('name', 'EUI Reasonableness')
     check_elems << OpenStudio::Attribute.new('category', category)
-    check_elems << OpenStudio::Attribute.new('description', "Check EUI for model against #{target_standard} DOE prototype buildings.")
+
+    # update display sttandard
+    if target_standard.include?('90.1')
+      display_standard = "ASHRAE #{target_standard}"
+    else
+      display_standard = target_standard
+    end
 
     # stop here if only name is requested this is used to populate display name for arguments
     if name_only == true
+      check_elems << OpenStudio::Attribute.new('description', "Check model EUI against #{display_standard} DOE prototype building.")
       results = []
       check_elems.each do |elem|
         results << elem.valueAsString
@@ -53,18 +61,26 @@ module OsLib_QAQC
       return results
     end
 
-    # Versions of OpenStudio greater than 2.4.0 use a modified version of
-    # openstudio-standards with different method calls.  These methods
-    # require a "Standard" object instead of the standard being passed into method calls.
-    # This Standard object is used throughout the QAQC check.
-    if OpenStudio::VersionString.new(OpenStudio.openStudioVersion) < OpenStudio::VersionString.new('2.4.3')
-      use_old_gem_code = true
-    else
-      use_old_gem_code = false
+    begin
+
+      # setup standard
       std = Standard.build(target_standard)
-    end
+      target_eui = std.model_find_target_eui(@model)
+
+      # gather building type for summary
+      bt_cz = std.model_get_building_climate_zone_and_building_type(@model)
+      building_type = bt_cz['building_type']
+      climate_zone = bt_cz['climate_zone']
+      prototype_prefix = "#{display_standard} #{building_type} #{climate_zone}"
+
+      # mapping to obuilding type to match space types
+      if building_type.include?("Office") then building_type = "Office" end
+
+      # last part of summary table
+      check_elems << OpenStudio::Attribute.new('description', "Check model EUI against #{prototype_prefix} DOE prototype building.")
+      check_elems << OpenStudio::Attribute.new('min_pass', min_pass * 100)
+      check_elems << OpenStudio::Attribute.new('max_pass', max_pass * 100)
 
-    begin
       # total building area
       query = 'SELECT Value FROM tabulardatawithstrings WHERE '
       query << "ReportName='AnnualBuildingUtilityPerformanceSummary' and "
@@ -98,12 +114,30 @@ module OsLib_QAQC
         return OpenStudio::Attribute.new('check', check_elems)
       end
 
-      # test using new method
-      if use_old_gem_code
-        target_eui = @model.find_target_eui(target_standard)
-      else
-        std = Standard.build(target_standard)
-        target_eui = std.model_find_target_eui(@model)
+      # check if all spaces types used the building type defined in the model (percentage calculation doesn't check if all area is inclued in building floor area)
+      if building_type != ''
+        primary_type_floor_area = 0.0
+        non_pri_area = 0.0
+        non_pri_types = []
+        @model.getSpaceTypes.each do |space_type|
+          st_bt = space_type.standardsBuildingType
+          if st_bt.is_initialized
+              st_bt = st_bt.get.to_s
+              if st_bt.include?("Office") then st_bt = "Office" end
+              if st_bt.to_s == building_type.to_s
+                primary_type_floor_area += space_type.floorArea
+              else
+                non_pri_area += space_type.floorArea
+                if !non_pri_types.include?(st_bt) then non_pri_types << st_bt end
+              end
+          else
+            non_pri_area += space_type.floorArea
+            if !non_pri_types.include?(st_bt) then non_pri_types << st_bt end
+          end
+        end
+        if non_pri_area > 0.0
+          check_elems << OpenStudio::Attribute.new('flag', "The primary building type, #{building_type}, only represents #{(100 * primary_type_floor_area / (primary_type_floor_area + non_pri_area)).round}% of the total building area. Other standads building types included are #{non_pri_types.sort.join(",")}. While a comparison to the #{building_type} prototype EUI is provided, it would not be unexpected for the building EUI to be significantly different than the prototype.")
+        end
       end
 
       # check model vs. target for user specified tolerance.
@@ -111,12 +145,16 @@ module OsLib_QAQC
         eui_ip_neat = OpenStudio.toNeatString(OpenStudio.convert(eui, source_units, target_units).get, 1, true)
         target_eui_ip_neat = OpenStudio.toNeatString(OpenStudio.convert(target_eui, source_units, target_units).get, 1, true)
         if eui < target_eui * (1.0 - min_pass)
-          check_elems << OpenStudio::Attribute.new('flag', "Model EUI of #{eui_ip_neat} (#{target_units}) is less than #{min_pass * 100} % below the expected EUI of #{target_eui_ip_neat} (#{target_units}) for #{target_standard}.")
+          check_elems << OpenStudio::Attribute.new('flag', "Model EUI of #{eui_ip_neat} (#{target_units}) is more than #{min_pass * 100} % below the #{prototype_prefix} prototype EUI of #{target_eui_ip_neat} (#{target_units}).")
         elsif eui > target_eui * (1.0 + max_pass)
-          check_elems << OpenStudio::Attribute.new('flag', "Model EUI of #{eui_ip_neat} (#{target_units}) is more than #{max_pass * 100} % above the expected EUI of #{target_eui_ip_neat} (#{target_units}) for #{target_standard}.")
+          check_elems << OpenStudio::Attribute.new('flag', "Model EUI of #{eui_ip_neat} (#{target_units}) is more than #{max_pass * 100} % above the #{prototype_prefix} prototype EUI of #{target_eui_ip_neat} (#{target_units}).")
         end
       else
-        check_elems << OpenStudio::Attribute.new('flag', "Can't calculate target EUI. Make sure model has expected climate zone and building type.")
+        if ['90.1-2016','90.1-2019'].include?(target_standard) || target_standard.include?("ComStock")
+          check_elems << OpenStudio::Attribute.new('flag', "target EUI comparison is not supported yet for #{target_standard}.")
+        else
+          check_elems << OpenStudio::Attribute.new('flag', "Can't calculate target EUI. Make sure model has expected climate zone and building type.")
+        end
       end
     rescue StandardError => e
       # brief description of ruby error

data/lib/measures/generic_qaqc/resources/check_internal_loads.rb

@@ -42,38 +42,48 @@ module OsLib_QAQC
     check_elems = OpenStudio::AttributeVector.new
     check_elems << OpenStudio::Attribute.new('name', 'Internal Loads')
     check_elems << OpenStudio::Attribute.new('category', category)
-    if target_standard == 'ICC IECC 2015'
-      check_elems << OpenStudio::Attribute.new('description', 'Check internal loads against Table R405.5.2(1) in ICC IECC 2015 Residential Provisions.')
+
+    # update display sttandard
+    if target_standard.include?('90.1')
+      display_standard = "ASHRAE #{target_standard}"
     else
-      if target_standard.include?('90.1')
-        display_standard = "ASHRAE #{target_standard}"
-      else
-        display_standard = target_standard
-      end
-      check_elems << OpenStudio::Attribute.new('description', "Check LPD, ventilation rates, occupant density, plug loads, and equipment loads against #{display_standard} and DOE Prototype buildings.")
+      display_standard = target_standard
     end
 
     # stop here if only name is requested this is used to populate display name for arguments
     if name_only == true
       results = []
+      if target_standard == 'ICC IECC 2015'
+        check_elems << OpenStudio::Attribute.new('description', 'Check internal loads against Table R405.5.2(1) in ICC IECC 2015 Residential Provisions.')
+      else
+        check_elems << OpenStudio::Attribute.new('description', "Check LPD, ventilation rates, occupant density, plug loads, and equipment loads against #{display_standard} DOE Prototype buildings.")
+      end      
       check_elems.each do |elem|
         results << elem.valueAsString
       end
       return results
     end
 
-    # Versions of OpenStudio greater than 2.4.0 use a modified version of
-    # openstudio-standards with different method calls.  These methods
-    # require a "Standard" object instead of the standard being passed into method calls.
-    # This Standard object is used throughout the QAQC check.
-    if OpenStudio::VersionString.new(OpenStudio.openStudioVersion) < OpenStudio::VersionString.new('2.4.3')
-      use_old_gem_code = true
-    else
-      use_old_gem_code = false
+    begin
+
+      # setup standard
       std = Standard.build(target_standard)
-    end
 
-    begin
+      # gather building type for summary
+      bt_cz = std.model_get_building_climate_zone_and_building_type(@model)
+      building_type = bt_cz['building_type']
+      # mapping to obuilding type to match space types
+      if building_type.include?("Office") then building_type = "Office" end      
+      climate_zone = bt_cz['climate_zone']
+      prototype_prefix = "#{display_standard} #{building_type} #{climate_zone}"
+      if target_standard == 'ICC IECC 2015'
+        check_elems << OpenStudio::Attribute.new('description', 'Check internal loads against Table R405.5.2(1) in ICC IECC 2015 Residential Provisions.')
+      else
+        check_elems << OpenStudio::Attribute.new('description', "Check LPD, ventilation rates, occupant density, plug loads, and equipment loads against #{prototype_prefix} DOE Prototype building.")
+      end
+      check_elems << OpenStudio::Attribute.new('min_pass', min_pass * 100)
+      check_elems << OpenStudio::Attribute.new('max_pass', max_pass * 100)
+      
       if target_standard == 'ICC IECC 2015'
 
         num_people = 0.0
@@ -88,11 +98,7 @@ module OsLib_QAQC
         # lookup iecc internal loads for the building
         bedrooms_per_unit = 2.0 # assumption
         num_units = num_people / 2.5 # Avg 2.5 units per person.
-        if use_old_gem_code
-          target_loads_hash = @model.find_icc_iecc_2015_internal_loads(num_units, bedrooms_per_unit)
-        else
-          target_loads_hash = std.model_find_icc_iecc_2015_internal_loads(@model, num_units, bedrooms_per_unit)
-        end
+        target_loads_hash = std.model_find_icc_iecc_2015_internal_loads(@model, num_units, bedrooms_per_unit)
 
         # get model internal gains for lights, elec equipment, and gas equipment
         model_internal_gains_si = 0.0
@@ -172,6 +178,9 @@ module OsLib_QAQC
 
       else
 
+        # gather all non statandard space types so can be listed in single flag
+        non_tagged_space_types = []
+
         # loop through all space types used in the model
         @model.getSpaceTypes.each do |space_type|
           next if space_type.floorArea <= 0
@@ -181,32 +190,21 @@ module OsLib_QAQC
           num_people = space_type.getNumberOfPeople(floor_area)
 
           # load in standard info for this space type
-          if use_old_gem_code
-            data = space_type.get_standards_data(target_standard)
-          else
-            data = std.space_type_get_standards_data(space_type)
-          end
+          data = std.space_type_get_standards_data(space_type)
 
           if data.nil? || data.empty?
 
             # skip if all spaces using this space type are plenums
             all_spaces_plenums = true
             space_type.spaces.each do |space|
-              if use_old_gem_code
-                if !space.plenum?
-                  all_spaces_plenums = false
-                  next
-                end
-              else
-                if !std.space_plenum?(space)
-                  all_spaces_plenums = false
-                  next
-                end
+               if !std.space_plenum?(space)
+                all_spaces_plenums = false
+                next
               end
             end
 
             if !all_spaces_plenums
-              check_elems << OpenStudio::Attribute.new('flag', "Unexpected standards type for #{space_type.name}, can't validate internal loads.")
+              non_tagged_space_types << space_type.floorArea
             end
 
             next
@@ -223,9 +221,9 @@ module OsLib_QAQC
           model_ip_neat = OpenStudio.toNeatString(model_ip, 2, true)
           target_ip_neat = OpenStudio.toNeatString(target_ip, 2, true)
           if model_ip < target_ip * (1.0 - min_pass)
-            check_elems << OpenStudio::Attribute.new('flag', "#{load_type} of #{model_ip_neat} (#{target_units}) for #{space_type.name} is more than #{min_pass * 100} % below the expected value of #{target_ip_neat} (#{target_units}) for #{display_standard}.")
+            check_elems << OpenStudio::Attribute.new('flag', "#{load_type} of #{model_ip_neat} (#{target_units}) for #{space_type.name} is more than #{min_pass * 100} % below the value of #{target_ip_neat} (#{target_units}) for #{prototype_prefix} Prototype model.")
           elsif model_ip > target_ip * (1.0 + max_pass)
-            check_elems << OpenStudio::Attribute.new('flag', "#{load_type} of #{model_ip_neat} (#{target_units}) for #{space_type.name} is more than #{max_pass * 100} % above the expected value of #{target_ip_neat} (#{target_units}) for #{display_standard}.")
+            check_elems << OpenStudio::Attribute.new('flag', "#{load_type} of #{model_ip_neat} (#{target_units}) for #{space_type.name} is more than #{max_pass * 100} % above the value of #{target_ip_neat} (#{target_units}) for #{prototype_prefix} Prototype model.")
           end
 
           # check electric equipment
@@ -239,9 +237,9 @@ module OsLib_QAQC
           model_ip_neat = OpenStudio.toNeatString(model_ip, 2, true)
           target_ip_neat = OpenStudio.toNeatString(target_ip, 2, true)
           if model_ip < target_ip * (1.0 - min_pass)
-            check_elems << OpenStudio::Attribute.new('flag', "#{load_type} of #{model_ip_neat} (#{target_units}) for #{space_type.name} is more than #{min_pass * 100} % below the expected value of #{target_ip_neat} (#{target_units}) for #{display_standard}.")
+            check_elems << OpenStudio::Attribute.new('flag', "#{load_type} of #{model_ip_neat} (#{target_units}) for #{space_type.name} is more than #{min_pass * 100} % below the value of #{target_ip_neat} (#{target_units}) for #{prototype_prefix} Prototype model.")
           elsif model_ip > target_ip * (1.0 + max_pass)
-            check_elems << OpenStudio::Attribute.new('flag', "#{load_type} of #{model_ip_neat} (#{target_units}) for #{space_type.name} is more than #{max_pass * 100} % above the expected value of #{target_ip_neat} (#{target_units}) for #{display_standard}.")
+            check_elems << OpenStudio::Attribute.new('flag', "#{load_type} of #{model_ip_neat} (#{target_units}) for #{space_type.name} is more than #{max_pass * 100} % above the value of #{target_ip_neat} (#{target_units}) for #{prototype_prefix} Prototype model.")
           end
 
           # check gas equipment
@@ -255,9 +253,9 @@ module OsLib_QAQC
           model_ip_neat = OpenStudio.toNeatString(model_ip, 2, true)
           target_ip_neat = OpenStudio.toNeatString(target_ip, 2, true)
           if model_ip < target_ip * (1.0 - min_pass)
-            check_elems << OpenStudio::Attribute.new('flag', "#{load_type} of #{model_ip_neat} (#{target_units}) for #{space_type.name} is more than #{min_pass * 100} % below the expected value of #{target_ip_neat} (#{target_units}) for #{display_standard}.")
+            check_elems << OpenStudio::Attribute.new('flag', "#{load_type} of #{model_ip_neat} (#{target_units}) for #{space_type.name} is more than #{min_pass * 100} % below the value of #{target_ip_neat} (#{target_units}) for #{prototype_prefix} Prototype model.")
           elsif model_ip > target_ip * (1.0 + max_pass)
-            check_elems << OpenStudio::Attribute.new('flag', "#{load_type} of #{model_ip_neat} (#{target_units}) for #{space_type.name} is more than #{max_pass * 100} % above the expected value of #{target_ip_neat} (#{target_units}) for #{display_standard}.")
+            check_elems << OpenStudio::Attribute.new('flag', "#{load_type} of #{model_ip_neat} (#{target_units}) for #{space_type.name} is more than #{max_pass * 100} % above the value of #{target_ip_neat} (#{target_units}) for #{prototype_prefix} Prototype model.")
           end
 
           # check people
@@ -273,9 +271,9 @@ module OsLib_QAQC
           # for people need to update target units just for display. Can't be used for converstion.
           target_units = 'People/1000 ft^2'
           if model_ip < target_ip * (1.0 - min_pass)
-            check_elems << OpenStudio::Attribute.new('flag', "#{load_type} of #{model_ip_neat} (#{target_units}) for #{space_type.name} is more than #{min_pass * 100} % below the expected value of #{target_ip_neat} (#{target_units}) for #{display_standard}.")
+            check_elems << OpenStudio::Attribute.new('flag', "#{load_type} of #{model_ip_neat} (#{target_units}) for #{space_type.name} is more than #{min_pass * 100} % below the value of #{target_ip_neat} (#{target_units}) for #{prototype_prefix} Prototype model.")
           elsif model_ip > target_ip * (1.0 + max_pass)
-            check_elems << OpenStudio::Attribute.new('flag', "#{load_type} of #{model_ip_neat} (#{target_units}) for #{space_type.name} is more than #{max_pass * 100} % above the expected value of #{target_ip_neat} (#{target_units}) for #{display_standard}.")
+            check_elems << OpenStudio::Attribute.new('flag', "#{load_type} of #{model_ip_neat} (#{target_units}) for #{space_type.name} is more than #{max_pass * 100} % above the value of #{target_ip_neat} (#{target_units}) for #{prototype_prefix} Prototype model.")
           end
 
           # get volume for space type for use with ventilation and infiltration
@@ -340,9 +338,9 @@ module OsLib_QAQC
           model_ip_neat = OpenStudio.toNeatString(OpenStudio.convert(oa_per_person, source_units, target_units).get, 2, true)
           target_ip_neat = OpenStudio.toNeatString(target_oa_per_person_ip, 2, true)
           if oa_per_person < target_oa_per_person_si * (1.0 - min_pass)
-            check_elems << OpenStudio::Attribute.new('flag', "#{load_type} of #{model_ip_neat} (#{target_units}) for #{space_type.name} is more than #{min_pass * 100} % below the expected value of #{target_ip_neat} (#{target_units}) for #{display_standard}.")
+            check_elems << OpenStudio::Attribute.new('flag', "#{load_type} of #{model_ip_neat} (#{target_units}) for #{space_type.name} is more than #{min_pass * 100} % below the value of #{target_ip_neat} (#{target_units}) for #{prototype_prefix} Prototype model.")
           elsif oa_per_person > target_oa_per_person_si * (1.0 + max_pass)
-            check_elems << OpenStudio::Attribute.new('flag', "#{load_type} of #{model_ip_neat} (#{target_units}) for #{space_type.name} is more than #{max_pass * 100} % above the expected value of #{target_ip_neat} (#{target_units}) for #{display_standard}.")
+            check_elems << OpenStudio::Attribute.new('flag', "#{load_type} of #{model_ip_neat} (#{target_units}) for #{space_type.name} is more than #{max_pass * 100} % above the value of #{target_ip_neat} (#{target_units}) for #{prototype_prefix} Prototype model.")
           end
 
           # check other oa
@@ -352,19 +350,22 @@ module OsLib_QAQC
           model_ip_neat = OpenStudio.toNeatString(OpenStudio.convert(oa_total, source_units, target_units).get, 2, true)
           target_ip_neat = OpenStudio.toNeatString(OpenStudio.convert(target_oa_total, source_units, target_units).get, 2, true)
           if oa_total < target_oa_total * (1.0 - min_pass)
-            check_elems << OpenStudio::Attribute.new('flag', "#{load_type} of #{model_ip_neat} (#{target_units}) for #{space_type.name} is more than #{min_pass * 100} % below the expected value of #{target_ip_neat} (#{target_units}) for #{display_standard}.")
+            check_elems << OpenStudio::Attribute.new('flag', "#{load_type} of #{model_ip_neat} (#{target_units}) for #{space_type.name} is more than #{min_pass * 100} % below the value of #{target_ip_neat} (#{target_units}) for #{prototype_prefix} Prototype model.")
           elsif oa_total > target_oa_total * (1.0 + max_pass)
-            check_elems << OpenStudio::Attribute.new('flag', "#{load_type} of #{model_ip_neat} (#{target_units}) for #{space_type.name} is more than #{max_pass * 100} % above the expected value of #{target_ip_neat} (#{target_units}) for #{display_standard}.")
+            check_elems << OpenStudio::Attribute.new('flag', "#{load_type} of #{model_ip_neat} (#{target_units}) for #{space_type.name} is more than #{max_pass * 100} % above the value of #{target_ip_neat} (#{target_units}) for #{prototype_prefix} Prototype model.")
           end
         end
 
+        # report about non standard space types
+        if non_tagged_space_types.size > 0
+          impacted_floor_area = non_tagged_space_types.sum
+          building_area = @model.getBuilding.floorArea
+          check_elems << OpenStudio::Attribute.new('flag', "Unexpected standard building/space types found for #{non_tagged_space_types.size} space types covering #{(100.0 * impacted_floor_area/building_area).round}% of floor area, can't provide comparisons for internal loads for those space types.")
+        end        
+
         # warn if there are spaces in model that don't use space type unless they appear to be plenums
         @model.getSpaces.each do |space|
-          if use_old_gem_code
-            next if space.plenum?
-          else
-            next if std.space_plenum?(space)
-          end
+          next if std.space_plenum?(space)
 
           if !space.spaceType.is_initialized
             check_elems << OpenStudio::Attribute.new('flag', "#{space.name} doesn't have a space type assigned, can't validate internal loads.")

data/lib/measures/generic_qaqc/resources/check_mech_sys_capacity.rb

@@ -43,11 +43,14 @@ module OsLib_QAQC
     check_elems << OpenStudio::Attribute.new('name', 'Mechanical System Capacity')
     check_elems << OpenStudio::Attribute.new('category', category)
     check_elems << OpenStudio::Attribute.new('description', 'Check HVAC capacity against ASHRAE rules of thumb for chiller max flow rate, air loop max flow rate, air loop cooling capciaty, and zone heating capcaity. Zone heating check will skip thermal zones without any exterior exposure, and thermal zones that are not conditioned.')
-
+    check_elems << OpenStudio::Attribute.new('min_pass', "Var")
+    check_elems << OpenStudio::Attribute.new('max_pass', "Var")
+    
     # stop here if only name is requested this is used to populate display name for arguments
     if name_only == true
       results = []
       check_elems.each do |elem|
+        next if ['Double','Integer'].include? (elem.valueType.valueDescription)
         results << elem.valueAsString
       end
       return results

data/lib/measures/generic_qaqc/resources/check_mech_sys_efficiency.rb

@@ -44,7 +44,9 @@ module OsLib_QAQC
     check_elems = OpenStudio::AttributeVector.new
     check_elems << OpenStudio::Attribute.new('name', 'Mechanical System Efficiency')
     check_elems << OpenStudio::Attribute.new('category', category)
-
+    check_elems << OpenStudio::Attribute.new('min_pass', min_pass * 100)
+    check_elems << OpenStudio::Attribute.new('max_pass', max_pass * 100)
+    
     if target_standard.include?('90.1-2013')
       display_standard = "ASHRAE #{target_standard}"
       check_elems << OpenStudio::Attribute.new('description', "Check against #{display_standard} Tables 6.8.1 A-K for the following component types: #{component_type_array.join(', ')}.")
@@ -62,6 +64,7 @@ module OsLib_QAQC
     if name_only == true
       results = []
       check_elems.each do |elem|
+        next if ['Double','Integer'].include? (elem.valueType.valueDescription)
         results << elem.valueAsString
       end
       return results
@@ -96,9 +99,9 @@ module OsLib_QAQC
         if standard_minimum_full_load_efficiency.nil?
           check_elems <<  OpenStudio::Attribute.new('flag', "Can't find target full load efficiency for #{component.name}.")
         elsif reference_COP < standard_minimum_full_load_efficiency * (1.0 - min_pass)
-          check_elems <<  OpenStudio::Attribute.new('flag', "COP of #{reference_COP.round(2)} for #{component.name} is more than #{min_pass * 100} % below the expected value of #{standard_minimum_full_load_efficiency.round(2)}.")
+          check_elems <<  OpenStudio::Attribute.new('flag', "COP of #{reference_COP.round(2)} for #{component.name} is more than #{min_pass * 100} % below the value of #{standard_minimum_full_load_efficiency.round(2)}.")
         elsif reference_COP > standard_minimum_full_load_efficiency * (1.0 + max_pass)
-          check_elems <<  OpenStudio::Attribute.new('flag', "COP  of #{reference_COP.round(2)} for #{component.name} is more than #{max_pass * 100} % above the expected value of #{standard_minimum_full_load_efficiency.round(2)}.")
+          check_elems <<  OpenStudio::Attribute.new('flag', "COP  of #{reference_COP.round(2)} for #{component.name} is more than #{max_pass * 100} % above the value of #{standard_minimum_full_load_efficiency.round(2)}.")
         end
       end
 
@@ -118,9 +121,9 @@ module OsLib_QAQC
         if standard_minimum_cop.nil?
           check_elems <<  OpenStudio::Attribute.new('flag', "Can't find target COP for #{component.name}.")
         elsif rated_COP < standard_minimum_cop * (1.0 - min_pass)
-          check_elems <<  OpenStudio::Attribute.new('flag', "The COP of #{rated_COP.round(2)} for #{component.name} is more than #{min_pass * 100} % below the expected value of #{standard_minimum_cop.round(2)} for #{display_standard}.")
+          check_elems <<  OpenStudio::Attribute.new('flag', "The COP of #{rated_COP.round(2)} for #{component.name} is more than #{min_pass * 100} % below the value of #{standard_minimum_cop.round(2)} for #{display_standard}.")
         elsif rated_COP > standard_minimum_cop * (1.0 + max_pass)
-          check_elems <<  OpenStudio::Attribute.new('flag', "The COP of  #{rated_COP.round(2)} for #{component.name} is more than #{max_pass * 100} % above the expected value of #{standard_minimum_cop.round(2)} for #{display_standard}.")
+          check_elems <<  OpenStudio::Attribute.new('flag', "The COP of  #{rated_COP.round(2)} for #{component.name} is more than #{max_pass * 100} % above the value of #{standard_minimum_cop.round(2)} for #{display_standard}.")
         end
       end
 
@@ -141,16 +144,16 @@ module OsLib_QAQC
         if standard_minimum_cop.nil?
           check_elems <<  OpenStudio::Attribute.new('flag', "Can't find target COP for #{component.name}.")
         elsif rated_high_speed_COP < standard_minimum_cop * (1.0 - min_pass)
-          check_elems <<  OpenStudio::Attribute.new('flag', "The high speed COP of #{rated_high_speed_COP.round(2)} for #{component.name} is more than #{min_pass * 100} % below the expected value of #{standard_minimum_cop.round(2)} for #{display_standard}.")
+          check_elems <<  OpenStudio::Attribute.new('flag', "The high speed COP of #{rated_high_speed_COP.round(2)} for #{component.name} is more than #{min_pass * 100} % below the value of #{standard_minimum_cop.round(2)} for #{display_standard}.")
         elsif rated_high_speed_COP > standard_minimum_cop * (1.0 + max_pass)
-          check_elems <<  OpenStudio::Attribute.new('flag', "The high speed COP of  #{rated_high_speed_COP.round(2)} for #{component.name} is more than #{max_pass * 100} % above the expected value of #{standard_minimum_cop.round(2)} for #{display_standard}.")
+          check_elems <<  OpenStudio::Attribute.new('flag', "The high speed COP of  #{rated_high_speed_COP.round(2)} for #{component.name} is more than #{max_pass * 100} % above the value of #{standard_minimum_cop.round(2)} for #{display_standard}.")
         end
         if standard_minimum_cop.nil?
           check_elems <<  OpenStudio::Attribute.new('flag', "Can't find target COP for #{component.name}.")
         elsif rated_low_speed_COP < standard_minimum_cop * (1.0 - min_pass)
-          check_elems <<  OpenStudio::Attribute.new('flag', "The low speed COP of #{rated_low_speed_COP.round(2)} for #{component.name} is more than #{min_pass * 100} % below the expected value of #{standard_minimum_cop.round(2)} for #{display_standard}.")
+          check_elems <<  OpenStudio::Attribute.new('flag', "The low speed COP of #{rated_low_speed_COP.round(2)} for #{component.name} is more than #{min_pass * 100} % below the value of #{standard_minimum_cop.round(2)} for #{display_standard}.")
         elsif rated_low_speed_COP > standard_minimum_cop * (1.0 + max_pass)
-          check_elems <<  OpenStudio::Attribute.new('flag', "The low speed COP of  #{rated_low_speed_COP.round(2)} for #{component.name} is more than #{max_pass * 100} % above the expected value of #{standard_minimum_cop.round(2)} for #{display_standard}.")
+          check_elems <<  OpenStudio::Attribute.new('flag', "The low speed COP of  #{rated_low_speed_COP.round(2)} for #{component.name} is more than #{max_pass * 100} % above the value of #{standard_minimum_cop.round(2)} for #{display_standard}.")
         end
       end
 
@@ -171,9 +174,9 @@ module OsLib_QAQC
         if standard_minimum_cop.nil?
           check_elems <<  OpenStudio::Attribute.new('flag', "Can't find target COP for #{component.name}.")
         elsif rated_COP < standard_minimum_cop * (1.0 - min_pass)
-          check_elems <<  OpenStudio::Attribute.new('flag', "The COP of #{rated_COP.round(2)} for #{component.name} is more than #{min_pass * 100} % below the expected value of #{standard_minimum_cop.round(2)} for #{display_standard}.")
+          check_elems <<  OpenStudio::Attribute.new('flag', "The COP of #{rated_COP.round(2)} for #{component.name} is more than #{min_pass * 100} % below the value of #{standard_minimum_cop.round(2)} for #{display_standard}.")
         elsif rated_COP > standard_minimum_cop * (1.0 + max_pass)
-          check_elems <<  OpenStudio::Attribute.new('flag', "The COP of  #{rated_COP.round(2)} for #{component.name} is more than #{max_pass * 100} % above the expected value of #{standard_minimum_cop.round(2)}. for #{display_standard}")
+          check_elems <<  OpenStudio::Attribute.new('flag', "The COP of  #{rated_COP.round(2)} for #{component.name} is more than #{max_pass * 100} % above the value of #{standard_minimum_cop.round(2)}. for #{display_standard}")
         end
       end
 
@@ -190,12 +193,14 @@ module OsLib_QAQC
         end
 
         # check actual against target
-        if standard_minimum_thermal_efficiency.nil?
+        if component.autosizedNominalCapacity.get == 0
+          check_elems <<  OpenStudio::Attribute.new('flag', "Boiler named #{component.name} has a capacity of 0.")
+        elsif standard_minimum_thermal_efficiency.nil?
           check_elems <<  OpenStudio::Attribute.new('flag', "Can't find target thermal efficiency for #{component.name}.")
         elsif nominal_thermal_efficiency < standard_minimum_thermal_efficiency * (1.0 - min_pass)
-          check_elems <<  OpenStudio::Attribute.new('flag', "Nominal thermal efficiency of #{nominal_thermal_efficiency.round(2)} for #{component.name} is more than #{min_pass * 100} % below the expected value of #{standard_minimum_thermal_efficiency.round(2)} for #{display_standard}.")
+          check_elems <<  OpenStudio::Attribute.new('flag', "Nominal thermal efficiency of #{nominal_thermal_efficiency.round(2)} for #{component.name} is more than #{min_pass * 100} % below the value of #{standard_minimum_thermal_efficiency.round(2)} for #{display_standard}.")
         elsif nominal_thermal_efficiency > standard_minimum_thermal_efficiency * (1.0 + max_pass)
-          check_elems <<  OpenStudio::Attribute.new('flag', "Nominal thermal efficiency of  #{nominal_thermal_efficiency.round(2)} for #{component.name} is more than #{max_pass * 100} % above the expected value of #{standard_minimum_thermal_efficiency.round(2)} for #{display_standard}.")
+          check_elems <<  OpenStudio::Attribute.new('flag', "Nominal thermal efficiency of  #{nominal_thermal_efficiency.round(2)} for #{component.name} is more than #{max_pass * 100} % above the value of #{standard_minimum_thermal_efficiency.round(2)} for #{display_standard}.")
         end
       end
 
@@ -219,9 +224,9 @@ module OsLib_QAQC
 
         # check actual against target
         if motor_eff < standard_minimum_motor_efficiency_and_size * (1.0 - min_pass)
-          check_elems <<  OpenStudio::Attribute.new('flag', "Motor efficiency of #{motor_eff.round(2)} for #{component.name} is more than #{min_pass * 100} % below the expected value of #{standard_minimum_motor_efficiency_and_size.round(2)} for #{display_standard}.")
+          check_elems <<  OpenStudio::Attribute.new('flag', "Motor efficiency of #{motor_eff.round(2)} for #{component.name} is more than #{min_pass * 100} % below the value of #{standard_minimum_motor_efficiency_and_size.round(2)} for #{display_standard}.")
         elsif motor_eff > standard_minimum_motor_efficiency_and_size * (1.0 + max_pass)
-          check_elems <<  OpenStudio::Attribute.new('flag', "Motor efficiency of #{motor_eff.round(2)} for #{component.name} is more than #{max_pass * 100} % above the expected value of #{standard_minimum_motor_efficiency_and_size.round(2)} for #{display_standard}.")
+          check_elems <<  OpenStudio::Attribute.new('flag', "Motor efficiency of #{motor_eff.round(2)} for #{component.name} is more than #{max_pass * 100} % above the value of #{standard_minimum_motor_efficiency_and_size.round(2)} for #{display_standard}.")
         end
       end
 
@@ -244,9 +249,9 @@ module OsLib_QAQC
 
         # check actual against target
         if motor_eff < standard_minimum_motor_efficiency_and_size * (1.0 - min_pass)
-          check_elems <<  OpenStudio::Attribute.new('flag', "Motor efficiency of #{motor_eff.round(2)} for #{component.name} is more than #{min_pass * 100} % below the expected value of #{standard_minimum_motor_efficiency_and_size.round(2)} for #{display_standard}.")
+          check_elems <<  OpenStudio::Attribute.new('flag', "Motor efficiency of #{motor_eff.round(2)} for #{component.name} is more than #{min_pass * 100} % below the value of #{standard_minimum_motor_efficiency_and_size.round(2)} for #{display_standard}.")
         elsif motor_eff > standard_minimum_motor_efficiency_and_size * (1.0 + max_pass)
-          check_elems <<  OpenStudio::Attribute.new('flag', "Motor efficiency of #{motor_eff.round(2)} for #{component.name} is more than #{max_pass * 100} % above the expected value of #{standard_minimum_motor_efficiency_and_size.round(2)} for #{display_standard}.")
+          check_elems <<  OpenStudio::Attribute.new('flag', "Motor efficiency of #{motor_eff.round(2)} for #{component.name} is more than #{max_pass * 100} % above the value of #{standard_minimum_motor_efficiency_and_size.round(2)} for #{display_standard}.")
         end
       end
 
@@ -270,9 +275,9 @@ module OsLib_QAQC
 
         # check actual against target
         if motor_eff < standard_minimum_motor_efficiency_and_size * (1.0 - min_pass)
-          check_elems <<  OpenStudio::Attribute.new('flag', "Motor efficiency of #{motor_eff.round(2)} for #{component.name} is more than #{min_pass * 100} % below the expected value of #{standard_minimum_motor_efficiency_and_size.round(2)} for #{display_standard}.")
+          check_elems <<  OpenStudio::Attribute.new('flag', "Motor efficiency of #{motor_eff.round(2)} for #{component.name} is more than #{min_pass * 100} % below the value of #{standard_minimum_motor_efficiency_and_size.round(2)} for #{display_standard}.")
         elsif motor_eff > standard_minimum_motor_efficiency_and_size * (1.0 + max_pass)
-          check_elems <<  OpenStudio::Attribute.new('flag', "Motor efficiency of #{motor_eff.round(2)} for #{component.name} is more than #{max_pass * 100} % above the expected value of #{standard_minimum_motor_efficiency_and_size.round(2)} for #{display_standard}.")
+          check_elems <<  OpenStudio::Attribute.new('flag', "Motor efficiency of #{motor_eff.round(2)} for #{component.name} is more than #{max_pass * 100} % above the value of #{standard_minimum_motor_efficiency_and_size.round(2)} for #{display_standard}.")
         end
       end
 
@@ -296,9 +301,9 @@ module OsLib_QAQC
 
         # check actual against target
         if motor_eff < standard_minimum_motor_efficiency_and_size * (1.0 - min_pass)
-          check_elems <<  OpenStudio::Attribute.new('flag', "Motor efficiency of #{motor_eff.round(2)} for #{component.name} is more than #{min_pass * 100} % below the expected value of #{standard_minimum_motor_efficiency_and_size.round(2)} for #{display_standard}.")
+          check_elems <<  OpenStudio::Attribute.new('flag', "Motor efficiency of #{motor_eff.round(2)} for #{component.name} is more than #{min_pass * 100} % below the value of #{standard_minimum_motor_efficiency_and_size.round(2)} for #{display_standard}.")
         elsif motor_eff > standard_minimum_motor_efficiency_and_size * (1.0 + max_pass)
-          check_elems <<  OpenStudio::Attribute.new('flag', "Motor efficiency of #{motor_eff.round(2)} for #{component.name} is more than #{max_pass * 100} % above the expected value of #{standard_minimum_motor_efficiency_and_size.round(2)} for #{display_standard}.")
+          check_elems <<  OpenStudio::Attribute.new('flag', "Motor efficiency of #{motor_eff.round(2)} for #{component.name} is more than #{max_pass * 100} % above the value of #{standard_minimum_motor_efficiency_and_size.round(2)} for #{display_standard}.")
         end
       end