openproject-global_roles 1.0.0

data/lib/open_project/global_roles/principal_allowance_evaluator/global.rb

@@ -0,0 +1,24 @@
+#-- copyright
+# OpenProject is a project management system.
+#
+# Copyright (C) 2010-2013 the OpenProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# See doc/COPYRIGHT.rdoc for more details.
+#++
+
+class OpenProject::GlobalRoles::PrincipalAllowanceEvaluator::Global < ChiliProject::PrincipalAllowanceEvaluator::Base
+
+  def granted_for_global? membership, action, options
+    return false unless membership.is_a?(PrincipalRole)
+    granted = super
+
+    granted ||= membership.role.allowed_to?(action).present?
+  end
+
+  def global_granting_candidates
+    @user.principal_roles
+  end
+end

data/lib/open_project/global_roles/version.rb

@@ -0,0 +1,16 @@
+#-- copyright
+# OpenProject is a project management system.
+#
+# Copyright (C) 2010-2013 the OpenProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# See doc/COPYRIGHT.rdoc for more details.
+#++
+
+module OpenProject
+  module GlobalRoles
+    VERSION = "1.0.0"
+  end
+end

data/lib/openproject-global_roles.rb

@@ -0,0 +1,12 @@
+#-- copyright
+# OpenProject is a project management system.
+#
+# Copyright (C) 2010-2013 the OpenProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# See doc/COPYRIGHT.rdoc for more details.
+#++
+
+require 'open_project/global_roles'

data/spec/controllers/principal_roles_controller_spec.rb

@@ -0,0 +1,163 @@
+#-- copyright
+# OpenProject is a project management system.
+#
+# Copyright (C) 2010-2013 the OpenProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# See doc/COPYRIGHT.rdoc for more details.
+#++
+
+require File.dirname(__FILE__) + '/../spec_helper'
+
+describe PrincipalRolesController do
+  before(:each) do
+    @controller.stub!(:require_admin).and_return(true)
+    @controller.stub!(:check_if_login_required).and_return(true)
+    @controller.stub!(:set_localization).and_return(true)
+
+    @principal_role = mock_model PrincipalRole
+
+    if privacy_plugin_loaded?
+      @principal_role.stub!(:privacy_unnecessary=)
+      @principal_role.stub!(:valid?).and_return(true)
+      @principal_role.stub!(:privacy_statement_necessary?).and_return(false)
+    end
+
+    @principal_role.stub!(:id).and_return(23)
+    PrincipalRole.stub!(:find).and_return @principal_role
+    disable_flash_sweep
+    disable_log_requesting_user
+  end
+
+  describe :post do
+    before :each do
+      @params = {"principal_role"=>{"principal_id"=>"3", "role_ids"=>["7"]}}
+    end
+
+    unless privacy_plugin_loaded? #tests than are defined in privacy_plugin
+
+      describe :create do
+        before :each do
+
+        end
+
+        describe "SUCCESS" do
+          before :each do
+            @global_role = mock_model(GlobalRole)
+            @global_role.stub!(:id).and_return(42)
+            Role.stub!(:find).and_return([@global_role])
+            PrincipalRole.stub!(:new).and_return(@principal_role)
+            @user = mock_model User
+            @user.stub!(:valid?).and_return(true)
+            @user.stub!(:logged?).and_return(true)
+            Principal.stub!(:find).and_return(@user)
+            @principal_role.stub!(:role=)
+            @principal_role.stub!(:role).and_return(@global_role)
+            @principal_role.stub!(:principal_id=)
+            @principal_role.stub!(:save)
+            @principal_role.stub!(:role_id).and_return(@global_role.id)
+            @principal_role.stub!(:valid?).and_return(true)
+          end
+
+          describe "js" do
+            before :each do
+              response_should_render :replace,
+                                     "available_principal_roles",
+                                     :partial => "users/available_global_roles",
+                                     :locals => {:global_roles => anything(),
+                                                 :user => anything()}
+              response_should_render :insert_html,
+                                     :top, 'table_principal_roles_body',
+                                     :partial => "principal_roles/show_table_row",
+                                     :locals => {:principal_role => anything()}
+
+              #post :create, { "format" => "js", "principal_role"=>{"principal_id"=>"3", "role_ids"=>["7"]}}
+              xhr :post, :create, @params
+            end
+
+            it { response.should be_success }
+          end
+        end
+      end
+    end
+  end
+
+  describe :put do
+    before :each do
+      @params = {"principal_role"=>{"id"=>"6", "role_id" => "5"}}
+    end
+
+    describe :update do
+      before(:each) do
+        @principal_role.stub!(:update_attributes)
+      end
+
+      describe "SUCCESS" do
+        describe "js" do
+          before :each do
+            @principal_role.stub!(:valid?).and_return(true)
+
+            response_should_render :replace,
+                                  "principal_role-#{@principal_role.id}",
+                                  :partial => "principal_roles/show_table_row",
+                                  :locals => {:principal_role => anything()}
+
+            xhr :put, :update, @params
+          end
+
+          it {response.should be_success}
+        end
+      end
+
+      describe "FAILURE" do
+        describe "js" do
+          before :each do
+            @principal_role.stub!(:valid?).and_return(false)
+            response_should_render :insert_html,
+                                   :top,
+                                   "tab-content-global_roles",
+                                   :partial => 'errors'
+
+            xhr :put, :update, @params
+          end
+
+          it {response.should be_success}
+        end
+      end
+    end
+  end
+
+  describe :delete do
+    before :each do
+      @principal_role.stub!(:principal_id).and_return(1)
+      @user = mock_model User
+      @user.stub!(:logged?).and_return(true)
+      Principal.stub(:find).and_return(@user)
+      @principal_role.stub!(:destroy)
+      @params = {"id" => "1"}
+    end
+
+    describe :destroy do
+      describe "SUCCESS" do
+        before :each do
+          response_should_render :remove, "principal_role-#{@principal_role.id}"
+          response_should_render :replace,
+                                 "available_principal_roles",
+                                 :partial => "users/available_global_roles",
+                                 :locals => {:global_roles => anything(),
+                                             :user => anything()}
+        end
+
+        describe "js" do
+          before :each do
+            xhr :delete, :destroy, @params
+          end
+
+          it { response.should be_success }
+        end
+      end
+    end
+  end
+end

data/spec/controllers/roles_controller_spec.rb

@@ -0,0 +1,315 @@
+#-- copyright
+# OpenProject is a project management system.
+#
+# Copyright (C) 2010-2013 the OpenProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# See doc/COPYRIGHT.rdoc for more details.
+#++
+
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
+
+describe RolesController do
+  before (:each) do
+    @controller.stub!(:check_if_login_required)
+    @controller.should_receive(:require_admin)
+    disable_flash_sweep
+  end
+
+  after (:each) do
+    User.current = nil
+  end
+
+  shared_examples_for "index" do
+    it {response.should be_success}
+    it {assigns(:roles).should eql(@roles)}
+    it {response.should render_template "roles/index"}
+  end
+
+  shared_examples_for "global assigns" do
+    it {assigns(:global_permissions).should eql @global_role.setable_permissions}
+    it {assigns(:global_roles).should eql @global_roles}
+    it {assigns(:global_role).should eql @global_role}
+  end
+
+  shared_examples_for "permission assigns" do
+    it {assigns(:member_permissions).should eql @member_role.setable_permissions}
+    it {assigns(:global_permissions).should eql GlobalRole.setable_permissions}
+  end
+
+  shared_examples_for "successful create" do
+    it {response.should be_redirect}
+    it {response.should redirect_to "/admin/roles"}
+    it {flash[:notice].should eql I18n.t(:notice_successful_create)}
+  end
+
+  shared_examples_for "failed create" do
+    it {response.should be_success}
+    it {response.should render_template "new"}
+  end
+
+
+
+  describe "WITH get" do
+    describe "VERB", :index do
+      before (:each) do
+        mock_role_find
+      end
+
+      describe "html" do
+        before {get "index"}
+
+        it_should_behave_like "index"
+
+      end
+
+      describe "xhr" do
+        before {xhr :get, "index"}
+
+        it_should_behave_like "index"
+      end
+    end
+
+    describe "VERB", :new do
+      before (:each) do
+        @member_role = mocks_for_creating Role
+        GlobalRole.stub!(:setable_permissions).and_return([:perm1, :perm2, :perm3])
+        @non_member_role = mock_model Role
+        mock_permissions_on @non_member_role
+        Role.stub!(:non_member).and_return(@non_member_role)
+
+        mock_role_find
+        get "new"
+      end
+
+      it {response.should be_success}
+      it {response.should render_template "roles/new"}
+      it {assigns(:member_permissions).should eql @member_role.setable_permissions}
+      it {assigns(:roles).should eql @roles}
+      it {assigns(:role).should eql @member_role}
+      it {assigns(:global_permissions).should eql GlobalRole.setable_permissions}
+    end
+
+    describe "VERB", :edit do
+      before(:each) do
+        @member_role = mocks_for_creating Role
+        @global_role = mocks_for_creating GlobalRole
+        mock_role_find
+      end
+
+      describe "WITH member_role id" do
+        before (:each) do
+          @params = {"id" => "1"}
+          Role.stub!(:find).and_return(@member_role)
+        end
+
+        describe "RESULT" do
+          describe "success" do
+            describe "html" do
+              before {get :edit, @params}
+
+              it {response.should be_success}
+              it {response.should render_template "roles/edit"}
+              it {assigns(:role).should eql @member_role}
+              it {assigns(:permissions).should eql @member_role.setable_permissions}
+            end
+          end
+        end
+      end
+    end
+  end
+
+  describe "WITH post" do
+    before(:each) do
+      @member_role = mocks_for_creating Role
+      @global_role = mocks_for_creating GlobalRole
+      mock_role_find
+      Role.stub!(:find).with("1").and_return(@member_role)
+      Role.stub!(:find).with("2").and_return(@global_role)
+    end
+
+    describe "VERB", :create do
+
+      describe "WITH member_role params" do
+        before (:each) do
+          @params = {"role"=>{"name"=>"role",
+                            "permissions"=>["perm1", "perm2", "perm3"],
+                            "assignable"=>"1"}}
+        end
+
+        describe "RESULT" do
+          describe "success" do
+            before(:each) do
+              Role.should_receive(:new).with(@params["role"]).and_return(@member_role)
+              @member_role.stub!(:save).and_return(true)
+              @member_role.stub!(:errors).and_return([])
+            end
+
+            describe "html" do
+              before (:each) do
+                post "create", @params
+              end
+
+              it_should_behave_like "successful create"
+              it {assigns(:role).should eql @member_role}
+            end
+          end
+
+          describe "failure" do
+            before(:each) do
+              Role.should_receive(:new).with(@params["role"]).and_return(@member_role)
+              @member_role.stub!(:save).and_return(false)
+              @member_role.stub!(:errors).and_return(["something is wrong"])
+            end
+
+            describe "html" do
+              before {post "create", @params}
+
+              it_should_behave_like "failed create"
+              it {assigns(:role).should eql @member_role}
+              it {assigns(:roles).should eql Role.all}
+              it_should_behave_like "permission assigns"
+            end
+          end
+        end
+      end
+
+      describe "WITH global_role params" do
+        before (:each) do
+          @params = {"role"=>{"name"=>"role",
+                              "permissions"=>["perm1", "perm2", "perm3"]
+                              },
+                      "global_role" => "1"}
+        end
+
+        describe "RESULTS" do
+          describe "success" do
+            before(:each) do
+              GlobalRole.should_receive(:new).with(@params["role"]).and_return(@global_role)
+              @global_role.stub!(:save).and_return(true)
+            end
+
+            describe "html" do
+              before {post "create", @params}
+
+              it_should_behave_like "successful create"
+            end
+          end
+
+          describe "failure" do
+            before(:each) do
+              GlobalRole.should_receive(:new).with(@params["role"]).and_return(@global_role)
+              @global_role.stub!(:save).and_return(false)
+            end
+
+            describe "html" do
+              before {post "create", @params}
+
+              it_should_behave_like "failed create"
+              it {assigns(:role).should eql @global_role}
+              it {assigns(:roles).should eql Role.all}
+              it_should_behave_like "permission assigns"
+            end
+          end
+        end
+      end
+    end
+
+
+
+    describe "VERB", :destroy do
+      shared_examples_for "destroy results" do
+        describe "success" do
+          before (:each) do
+            @role.should_receive(:destroy)
+            post "destroy", @params
+          end
+
+          it {response.should be_redirect}
+          it {response.should redirect_to "/admin/roles"}
+        end
+      end
+
+      describe "WITH member_role params" do
+        before (:each) do
+          @params = {"class" => "Role", "id" => "1"}
+          @role = @member_role
+        end
+
+        describe "RESULTS" do
+          it_should_behave_like "destroy results"
+        end
+      end
+
+      describe "WITH global_role params" do
+        before (:each) do
+          @params = {"class" => "Role", "id" => "2"}
+          @role = @global_role
+        end
+
+        describe "RESULTS" do
+          it_should_behave_like "destroy results"
+        end
+      end
+    end
+
+
+    describe "VERB", :update do
+      shared_examples_for "update results" do
+        describe "success" do
+          describe "html" do
+            before (:each) do
+              @role.should_receive(:update_attributes).with(@params["role"]).and_return(true)
+              @role.stub!(:errors).and_return([])
+              post :update, @params
+            end
+
+            it {response.should be_redirect}
+            it {response.should redirect_to "/admin/roles"}
+            it {flash[:notice].should eql I18n.t(:notice_successful_update)}
+          end
+        end
+
+        describe "failure" do
+          describe "html" do
+            before(:each) do
+              @role.should_receive(:update_attributes).with(@params["role"]).and_return(false)
+              @role.stub!(:errors).and_return(["something is wrong"])
+              post :update, @params
+            end
+
+            it { response.should render_template "roles/edit" }
+          end
+        end
+      end
+
+      describe "WITH member_role params" do
+        before (:each) do
+          @params = {"role" => {"permissions" => ["permA", "permB"],
+                                "name" => "schmu"},
+                     "id" => "1"}
+          @role = @member_role
+        end
+
+        describe "RESULT" do
+          it_should_behave_like "update results"
+        end
+      end
+
+      describe "WITH global_role params" do
+        before (:each) do
+          @params = {"role" => {"permissions" => ["permA", "permB"],
+                                "name" => "schmu"},
+                     "id" => "2"}
+          @role = @global_role
+        end
+
+        describe "RESULT" do
+          it_should_behave_like "update results"
+        end
+      end
+    end
+  end
+end