opal 0.9.0.beta1 → 0.9.0.beta2

data/spec/filters/bugs/module.rb

@@ -5,8 +5,8 @@ opal_filter "Module" do
   fails "Module#<= raises a TypeError if the argument is not a class/module"
   fails "Module#<= returns nil if self is not related to the given module"
   fails "Module#<= returns true if self is a subclass of, the same as or includes the given module"
-  fails "Module#<=> returns +1 if self is a superclas of or included by the given module"
   fails "Module#<=> returns -1 if self is a subclass of or includes the given module"
+  fails "Module#<=> returns +1 if self is a superclas of or included by the given module"
   fails "Module#=== returns true when the given Object's class includes self or when the given Object is extended by self"
   fails "Module#> raises a TypeError if the argument is not a class/module"
   fails "Module#> returns false if self is a subclass of or includes the given module"
@@ -58,12 +58,6 @@ opal_filter "Module" do
   fails "Module#class_eval resolves constants in the receiver's scope"
   fails "Module#class_eval uses the optional filename and lineno parameters for error messages"
   fails "Module#class_exec defines method in the receiver's scope"
-  fails "Module#class_exec passes arguments to the block"
-  fails "Module#class_exec raises a LocalJumpError when no block is given"
-  fails "Module#class_variables does not return class variables defined in extended modules"
-  fails "Module#class_variables returns an Array of Symbols of class variable names defined in a metaclass"
-  fails "Module#class_variables returns an Array with names of class variables defined in metaclasses"
-  fails "Module#class_variables returns an Array with the names of class variables of self"
   fails "Module#class_variable_defined? converts a non string/symbol/fixnum name to string using to_str"
   fails "Module#class_variable_defined? raises a TypeError when the given names can't be converted to strings using to_str"
   fails "Module#class_variable_defined? returns false if a class variables with the given name is defined in an extended module"
@@ -74,13 +68,10 @@ opal_filter "Module" do
   fails "Module#class_variable_defined? returns true if the class variable is defined in a metaclass"
   fails "Module#class_variable_get returns the value of a class variable with the given name defined in an included module"
   fails "Module#class_variable_set sets the value of a class variable with the given name defined in an included module"
-  fails "Module#constants doesn't returns inherited constants when passed false"
-  fails "Module#constants doesn't returns inherited constants when passed nil"
-  fails "Module#constants includes names of constants defined after a module is included"
-  fails "Module#constants returns all constants including inherited when passed some object"
-  fails "Module#constants returns all constants including inherited when passed true"
-  fails "Module#constants returns an array of Symbol names of all constants defined in the module and all included modules"
-  fails "Module#constants returns only public constants"
+  fails "Module#class_variables does not return class variables defined in extended modules"
+  fails "Module#class_variables returns an Array of Symbols of class variable names defined in a metaclass"
+  fails "Module#class_variables returns an Array with names of class variables defined in metaclasses"
+  fails "Module#class_variables returns an Array with the names of class variables of self"
   fails "Module#const_get accepts a toplevel scope qualifier"
   fails "Module#const_get calls #to_str to convert the given name to a String"
   fails "Module#const_get does not search the singleton class of a Class or Module"
@@ -92,9 +83,18 @@ opal_filter "Module" do
   fails "Module#const_get with dynamically assigned constants searches a module included in the superclass"
   fails "Module#const_get with dynamically assigned constants searches the superclass chain"
   fails "Module#const_missing raises NameError and does not include toplevel Object"
+  fails "Module#constants doesn't returns inherited constants when passed false"
+  fails "Module#constants doesn't returns inherited constants when passed nil"
+  fails "Module#constants includes names of constants defined after a module is included"
+  fails "Module#constants returns all constants including inherited when passed some object"
+  fails "Module#constants returns all constants including inherited when passed true"
+  fails "Module#constants returns an array of Symbol names of all constants defined in the module and all included modules"
+  fails "Module#constants returns only public constants"
   fails "Module#define_method does not change the arity check style of the original proc"
   fails "Module#define_method passed {  } creates a method that raises an ArgumentError when passed one argument"
   fails "Module#define_method passed {  } creates a method that raises an ArgumentError when passed two arguments"
+  fails "Module#define_method passed { ||  } creates a method that raises an ArgumentError when passed one argument"
+  fails "Module#define_method passed { ||  } creates a method that raises an ArgumentError when passed two arguments"
   fails "Module#define_method passed { |a, *b|  } creates a method that raises an ArgumentError when passed zero arguments"
   fails "Module#define_method passed { |a, b, *c|  } creates a method that raises an ArgumentError when passed one argument and a block"
   fails "Module#define_method passed { |a, b, *c|  } creates a method that raises an ArgumentError when passed one argument"
@@ -106,8 +106,6 @@ opal_filter "Module" do
   fails "Module#define_method passed { |a|  } creates a method that raises an ArgumentError when passed two arguments"
   fails "Module#define_method passed { |a|  } creates a method that raises an ArgumentError when passed zero arguments and a block"
   fails "Module#define_method passed { |a|  } creates a method that raises an ArgumentError when passed zero arguments"
-  fails "Module#define_method passed { ||  } creates a method that raises an ArgumentError when passed one argument"
-  fails "Module#define_method passed { ||  } creates a method that raises an ArgumentError when passed two arguments"
   fails "Module#define_method raises a TypeError when a Method from a singleton class is defined on another class"
   fails "Module#define_method raises a TypeError when a Method from one class is defined on an unrelated class"
   fails "Module#define_method raises a TypeError when an UnboundMethod from a child class is defined on a parent class"
@@ -149,8 +147,6 @@ opal_filter "Module" do
   fails "Module#module_eval resolves constants in the receiver's scope"
   fails "Module#module_eval uses the optional filename and lineno parameters for error messages"
   fails "Module#module_exec defines method in the receiver's scope"
-  fails "Module#module_exec passes arguments to the block"
-  fails "Module#module_exec raises a LocalJumpError when no block is given"
   fails "Module#module_function as a toggle (no arguments) in a Module body affects evaled method definitions also even when outside the eval itself"
   fails "Module#module_function as a toggle (no arguments) in a Module body does not affect module_evaled method definitions also if outside the eval itself"
   fails "Module#module_function as a toggle (no arguments) in a Module body doesn't affect definitions when inside an eval even if the definitions are outside of it"
@@ -183,15 +179,18 @@ opal_filter "Module" do
   fails "Module#prepend reports the prepended module as the unbound method owner"
   fails "Module#prepend returns the class it's included into"
   fails "Module#prepend sees an instance of a prepended class as kind of the prepended module"
+  fails "Module#prepend supports super when the module is prepended into a singleton class with a class super"
   fails "Module#prepend supports super when the module is prepended into a singleton class"
   fails "Module#prepend throws a NoMethodError when there is no more superclass"
   fails "Module#prepend works with subclasses"
-  fails "Module#prepended is invoked when self is prepended to another module or class"
   fails "Module#prepend_features copies own tainted status to the given module"
   fails "Module#prepend_features copies own untrusted status to the given module"
   fails "Module#prepend_features gets called when self is included in another module/class"
   fails "Module#prepend_features on Class raises a TypeError if calling after rebinded to Class"
   fails "Module#prepend_features raises an ArgumentError on a cyclic prepend"
+  fails "Module#prepended is invoked when self is prepended to another module or class"
+  fails "Module#private without arguments within a closure sets the visibility outside the closure"
+  fails "Module#protected without arguments within a closure sets the visibility outside the closure"
   fails "Module#remove_class_variable raises a NameError when an uninitialized class variable is given"
   fails "Module#remove_class_variable raises a NameError when passed a symbol with no leading @"
   fails "Module#remove_class_variable raises a NameError when passed a symbol with one leading @"

data/spec/filters/bugs/regexp.rb

@@ -1,5 +1,4 @@
 opal_filter "regular_expressions" do
-  fails "Regexp#=== returns false if the other value cannot be coerced to a string"
   fails "Regexp#hash is based on the text and options of Regexp"
   fails "Regexp#hash returns the same value for two Regexps differing only in the /n option"
   fails "Regexp#initialize is a private method"
@@ -12,8 +11,6 @@ opal_filter "regular_expressions" do
   fails "Regexp#inspect escapes 2 slashes in a row properly"
   fails "Regexp#inspect returns a formatted string that would eval to the same regexp"
   fails "Regexp#inspect returns options in the order 'mixn'"
-  fails "Regexp#match raises a TypeError on an uninitialized Regexp"
-  fails "Regexp#options returns 0 for a Regexp literal without options"
   fails "Regexp#source returns the original string of the pattern"
   fails "Regexp#to_s deals properly with the two types of lookahead groups"
   fails "Regexp#to_s returns a string in (?xxx:yyy) notation"

data/spec/filters/bugs/set.rb

@@ -27,10 +27,6 @@ opal_filter "Set" do
   fails "Set#merge raises an ArgumentError when passed a non-Enumerable"
   fails "Set#pretty_print passes the 'pretty print' representation of self to the pretty print writer"
   fails "Set#pretty_print_cycle passes the 'pretty print' representation of a self-referencing Set to the pretty print writer"
-  fails "Set#proper_subset? raises an ArgumentError when passed a non-Set"
-  fails "Set#proper_subset? returns true if passed a Set that self is a proper subset of"
-  fails "Set#proper_superset? raises an ArgumentError when passed a non-Set"
-  fails "Set#proper_superset? returns true if passed a Set that self is a proper superset of"
   fails "Set#reject! deletes every element from self for which the passed block returns true"
   fails "Set#reject! returns an Enumerator when passed no block"
   fails "Set#reject! returns nil when self was not modified"
@@ -41,10 +37,6 @@ opal_filter "Set" do
   fails "Set#select! returns nil when self was not modified"
   fails "Set#select! returns self when self was modified"
   fails "Set#select! yields every element of self"
-  fails "Set#subset? raises an ArgumentError when passed a non-Set"
-  fails "Set#subset? returns true if passed a Set that is equal to self or self is a subset of"
-  fails "Set#superset? raises an ArgumentError when passed a non-Set"
-  fails "Set#superset? returns true if passed a Set that equals self or self is a proper superset of"
   fails "Set#^ raises an ArgumentError when passed a non-Enumerable"
   fails "Set#^ returns a new Set containing elements that are not in both self and the passed Enumberable"
 end

data/spec/filters/bugs/struct.rb

@@ -11,9 +11,9 @@ opal_filter "Struct" do
   fails "Struct.new does not create a constant with symbol as first argument"
   fails "Struct.new fails with invalid constant name as first argument"
   fails "Struct.new fails with too many arguments"
+  fails "Struct.new on subclasses creates a constant in subclass' namespace"
+  fails "Struct.new on subclasses fails with too many arguments"
   fails "Struct.new raises a TypeError if object doesn't respond to to_sym"
   fails "Struct.new raises a TypeError if object is not a Symbol"
-  fails "Struct.new on subclasses fails with too many arguments"
-  fails "Struct.new on subclasses creates a constant in subclass' namespace"
   fails "Struct.new with a block passes same struct class to the block"
 end

data/spec/filters/unsupported/bignum.rb

@@ -8,6 +8,7 @@ opal_filter "Bignum" do
   fails "Complex#rect returns an Array"
   fails "Complex#rect returns the imaginary part of self as the last element"
   fails "Complex#rect returns the real part of self as the first element"
+  fails "Enumerable#first raises a RangeError when passed a Bignum"
   fails "Fixnum#& returns self bitwise AND a Bignum"
   fails "Fixnum#& returns self bitwise AND other"
   fails "Fixnum#* overflows to Bignum when the result does not fit in Fixnum"

data/spec/filters/unsupported/language.rb

@@ -6,6 +6,13 @@ opal_filter "language" do
   fails "Magic comment is case-insensitive"
   fails "Magic comment must be at the first line"
   fails "Magic comment must be the first token of the line"
+  fails "Regexps with modifers supports /x (extended syntax)"
+  fails "Regexps with modifers supports /o (once)"
+  fails "Regexps with modifers invokes substitutions for /o only once"
+  fails "Regexps with modifers supports modifier combinations"
+  fails "Regexps with modifers supports (?imx-imx) (inline modifiers)"
+  fails "Regexps with modifers supports (?imx-imx:expr) (scoped inline modifiers)"
+  fails "Regexps with modifers supports ASII/Unicode modifiers"
   fails "The defined? keyword for pseudo-variables returns 'expression' for __ENCODING__"
   fails "The defined? keyword when called with a method name having a module as receiver returns nil if the method is private"
   fails "The defined? keyword when called with a method name having a module as receiver returns nil if the method is protected"

data/spec/lib/compiler_spec.rb

@@ -51,6 +51,11 @@ describe Opal::Compiler do
     expect_compiled("Object").to include("Object")
     expect_compiled("Array").to include("Array")
   end
+  
+  it "should compile undef calls" do
+    expect_compiled("undef a").to include("Opal.udef(self, '$a')")
+    expect_compiled("undef a,b").to match(/Opal.udef\(self, '\$a'\);.*return Opal.udef\(self, '\$b'\);/m)
+  end
 
   describe "class names" do
     it "generates a named function for class using $ prefix" do

data/spec/lib/parser/undef_spec.rb

@@ -12,4 +12,8 @@ describe "The undef keyword" do
   it "can take symbols or fitems" do
     parsed("undef :foo").should == [:undef, [:sym, :foo]]
   end
+  
+  it "can take multiple symbols" do
+    parsed("undef :a, :b").should == [:undef, [:sym, :a], [:sym, :b]]
+  end
 end

data/spec/lib/paths_spec.rb

@@ -0,0 +1,11 @@
+require 'lib/spec_helper'
+
+describe 'Opal.use_gem' do
+  it 'adds require_paths of a gem to Opal paths' do
+    Opal.use_gem 'sprockets'
+    # Will fail if GEM_HOME has "sprockets" in the path, that's ok.
+    added_sprockets_paths = Opal.paths.grep /sprockets/
+    expect(added_sprockets_paths.size).to eq(1)
+    expect(added_sprockets_paths.first).to match(%r{/sprockets-[\d\.]+/lib$})
+  end
+end

data/spec/lib/spec_helper.rb

@@ -5,7 +5,7 @@ RSpec.configure do |config|
   config.run_all_when_everything_filtered = true
   config.filter_run :focus
   config.order = 'random'
-  config.before { Opal.instance_variable_set('@paths', nil) }
+  config.before { Opal.reset_paths! }
   config.before { Opal::Config.reset! if defined? Opal::Config }
   config.before { Opal::Processor.reset_cache_key! if defined? Opal::Processor }
 end

data/spec/opal/core/arity_spec.rb

@@ -0,0 +1,142 @@
+# This spec has been copied over from rubyspec and modified to avoid the use
+# of instance_eval with a String argument and also because some syntaxes are
+# not suppoted yet by Opal (e.g. def a(b, *c, d)).
+
+require 'spec_helper'
+
+describe "UnboundMethod#arity" do
+  context "returns zero" do
+
+    def self.evaluate_in_module message, &block
+      it message do
+        Module.new do
+          def self.arity_of(method_name)
+            instance_method(method_name).arity
+          end
+        end.class_eval(&block)
+      end
+    end
+
+    evaluate_in_module "for m()" do
+      arity_of(def m() end).should == 0
+    end
+
+    evaluate_in_module "for n(&b)" do
+      arity_of(def n(&b) end).should == 0
+    end
+  end
+
+  context "returns positive values," do
+    evaluate_in_module "the number of args for simple args" do
+      arity_of(def m(a) end).should == 1
+      arity_of(def n(a, b) end).should == 2
+      arity_of(def o(a, b, c) end).should == 3
+      arity_of(def p(a, b, c, d) end).should == 4
+    end
+
+    ruby_version_is "2.1" do
+      evaluate_in_module "1 for kwargs" do
+        arity_of(def m(a:) end).should == 1
+        arity_of(def n(a:, b:) end).should == 1
+        arity_of(def o(a: 1, b:, c:, d: 2) end).should == 1
+      end
+
+      evaluate_in_module __LINE__ do
+        arity_of(def m(a, b:) end).should == 2
+        arity_of(def n(a, b:, &l) end).should == 2
+      end
+
+      evaluate_in_module __LINE__ do
+        arity_of(def m(a, b, c:, d: 1) end).should == 3
+        arity_of(def n(a, b, c:, d: 1, **k, &l) end).should == 3
+      end
+    end
+  end
+
+  context "returns negative values" do
+    # evaluate_in_module __LINE__ do
+    #   arity_of(def m(a=1) end).should == -1
+    #   arity_of(def n(a=1, b=2) end).should == -1
+    # end
+    #
+    # evaluate_in_module __LINE__ do
+    #   arity_of(def m(a, b=1) end).should == -2
+    #   arity_of(def n(a, b, c=1, d=2) end).should == -3
+    # end
+    #
+    # evaluate_in_module __LINE__ do
+    #   arity_of(def m(a=1, *b) end).should == -1
+    #   arity_of(def n(a=1, b=2, *c) end).should == -1
+    # end
+    #
+    # evaluate_in_module __LINE__ do
+    #   arity_of(def m(*) end).should == -1
+    #   arity_of(def n(*a) end).should == -1
+    # end
+    #
+    # evaluate_in_module __LINE__ do
+    #   arity_of(def m(a, *) end).should == -2
+    #   arity_of(def n(a, *b) end).should == -2
+    #   arity_of(def o(a, b, *c) end).should == -3
+    #   arity_of(def p(a, b, c, *d) end).should == -4
+    # end
+    #
+    # evaluate_in_module __LINE__ do
+    #   arity_of(def m(*a, b) end).should == -2
+    #   arity_of(def n(*a, b, c) end).should == -3
+    #   arity_of(def o(*a, b, c, d) end).should == -4
+    # end
+    #
+    # evaluate_in_module __LINE__ do
+    #   arity_of(def m(a, *b, c) end).should == -3
+    #   arity_of(def n(a, b, *c, d, e) end).should == -5
+    # end
+    #
+    # evaluate_in_module __LINE__ do
+    #   arity_of(def m(a, b=1, c=2, *d, e, f) end).should == -4
+    #   arity_of(def n(a, b, c=1, *d, e, f, g) end).should == -6
+    # end
+
+    # ruby_version_is "2.1" do
+    #   evaluate_in_module __LINE__ do
+    #     arity_of(def m(a: 1) end).should == -1
+    #     arity_of(def n(a: 1, b: 2) end).should == -1
+    #   end
+    # end
+    #
+    # evaluate_in_module __LINE__ do
+    #   arity_of(def m(a=1, b: 2) end).should == -1
+    #   # arity_of(def n(*a, b: 1) end).should == -1
+    #   arity_of(def o(a=1, b: 2) end).should == -1
+    #   # arity_of(def p(a=1, *b, c: 2, &l) end).should == -1
+    # end
+
+    ruby_version_is "2.1" do
+      # evaluate_in_module __LINE__ do
+      #   arity_of(def m(**k, &l) end).should == -1
+      #   arity_of(def n(*a, **k) end).should == -1
+      #   arity_of(def o(a: 1, b: 2, **k) end).should == -1
+      # end
+      #
+      # evaluate_in_module __LINE__ do
+      #   arity_of(def m(a=1, *b, c:, d: 2, **k, &l) end).should == -2
+      # end
+      #
+      # evaluate_in_module __LINE__ do
+      #   arity_of(def m(a, b=1, *c, d, e:, f: 2, **k, &l) end).should == -4
+      #   arity_of(def n(a, b=1, *c, d:, e:, f: 2, **k, &l) end).should == -3
+      #   arity_of(def o(a=0, b=1, *c, d, e:, f: 2, **k, &l) end).should == -3
+      #   arity_of(def p(a=0, b=1, *c, d:, e:, f: 2, **k, &l) end).should == -2
+      # end
+    end
+  end
+
+  # context "for a Method generated by respond_to_missing?" do
+  #   it "returns -1" do
+  #     obj = mock("method arity respond_to_missing")
+  #     obj.should_receive(:respond_to_missing?).and_return(true)
+  #
+  #     obj.method(:m).unbind.arity.should == -1
+  #   end
+  # end
+end

data/spec/rubyspecs

@@ -125,6 +125,7 @@ rubyspec/language
 !rubyspec/language/predefined_spec
 !rubyspec/language/proc_spec
 !rubyspec/language/regexp_spec
+rubyspec/language/regexp/modifiers_spec
 !rubyspec/language/return_spec
 !rubyspec/language/send_spec
 !rubyspec/language/string_spec

data/stdlib/json.rb

@@ -4,6 +4,8 @@ module JSON
         $hasOwn = Opal.hasOwnProperty;
 
     function to_opal(value, options) {
+      var klass, arr, hash, i, ii, k;
+
       switch (typeof value) {
         case 'string':
           return value;
@@ -21,25 +23,24 @@ module JSON
           if (!value) return nil;
 
           if (value.$$is_array) {
-            var arr = #{`options.array_class`.new};
+            arr = #{`options.array_class`.new};
 
-            for (var i = 0, ii = value.length; i < ii; i++) {
+            for (i = 0, ii = value.length; i < ii; i++) {
               #{`arr`.push(`to_opal(value[i], options)`)};
             }
 
             return arr;
           }
           else {
-            var hash = #{`options.object_class`.new};
+            hash = #{`options.object_class`.new};
 
-            for (var k in value) {
+            for (k in value) {
               if ($hasOwn.call(value, k)) {
                 #{`hash`[`k`] = `to_opal(value[k], options)`};
               }
             }
 
-            var klass;
-            if ((klass = #{`hash`[JSON.create_id]}) != nil) {
+            if (!options.parse && (klass = #{`hash`[JSON.create_id]}) != nil) {
               klass = Opal.get(klass);
               return #{`klass`.json_create(`hash`)};
             }
@@ -47,7 +48,7 @@ module JSON
               return hash;
             }
           }
-      }
+        }
     };
   }
 
@@ -66,13 +67,17 @@ module JSON
   end
 
   def self.parse(source, options = {})
-    from_object(`$parse(source)`, options)
+    from_object(`$parse(source)`, options.merge(parse: true))
   end
 
   def self.parse!(source, options = {})
     parse(source, options)
   end
 
+  def self.load(source, options = {})
+    from_object(`$parse(source)`, options)
+  end
+
   # Raw js object => opal object
   def self.from_object(js_object, options = {})
     options[:object_class] ||= Hash

data/stdlib/native.rb

@@ -601,7 +601,7 @@ class Class
     %x{
       var aliased = #{self}.$$proto['$' + #{existing_mid}];
       if (!aliased) {
-        #{raise NameError, "undefined method `#{existing_mid}' for class `#{inspect}'"};
+        #{raise NameError.new("undefined method `#{existing_mid}' for class `#{inspect}'", exiting_mid)};
       }
       #{self}.$$proto[#{new_jsid}] = aliased;
     }

data/stdlib/observer.rb

@@ -126,7 +126,7 @@ module Observable
   def add_observer(observer, func=:update)
     @observer_peers = {} unless defined? @observer_peers
     unless observer.respond_to? func
-      raise NoMethodError, "observer does not respond to `#{func.to_s}'"
+      raise NoMethodError.new("observer does not respond to `#{func.to_s}'", func.to_s)
     end
     @observer_peers[observer] = func
   end