opal 0.9.0.beta1 → 0.9.0.beta2

data/opal/corelib/error.rb

@@ -112,3 +112,21 @@ class UncaughtThrowError < ArgumentError
     super("uncaught throw #{@sym.inspect}")
   end
 end
+
+class NameError
+  attr_reader :name
+  
+  def initialize(message, name=nil)
+    super message
+    @name = name  
+  end
+end
+
+class NoMethodError
+  attr_reader :args
+  
+  def initialize(message, name, args=[])
+    super message, name
+    @args = args
+  end
+end

data/opal/corelib/helpers.rb

@@ -108,15 +108,9 @@ module Opal
     name = Opal.coerce_to!(name, String, :to_str)
 
     unless `/^@[a-zA-Z_][a-zA-Z0-9_]*?$/.test(name)`
-      raise NameError, "'#{name}' is not allowed as an instance variable name"
+      raise NameError.new("'#{name}' is not allowed as an instance variable name", name)
     end
 
     name
-  end
-
-  def self.valid_method_name?(method_name)
-    method_name = Opal.coerce_to!(method_name, String, :to_str)
-
-    `/^[a-zA-Z_][a-zA-Z0-9_]*?$/.test(method_name)`
-  end
+  end  
 end

data/opal/corelib/kernel.rb

@@ -1,6 +1,6 @@
 module Kernel
   def method_missing(symbol, *args, &block)
-    raise NoMethodError, "undefined method `#{symbol}' for #{inspect}"
+    raise NoMethodError.new("undefined method `#{symbol}' for #{inspect}", symbol, args)
   end
 
   def =~(obj)
@@ -35,7 +35,7 @@ module Kernel
       var meth = self['$' + name];
 
       if (!meth || meth.$$stub) {
-        #{raise NameError, "undefined method `#{name}' for class `#{self.class}'"};
+        #{raise NameError.new("undefined method `#{name}' for class `#{self.class}'", name)};
       }
 
       return #{Method.new(self, `meth`, name)};
@@ -993,7 +993,7 @@ module Kernel
     $stderr.puts(*strs) unless $VERBOSE.nil? || strs.empty?
   end
 
-  def raise(exception = undefined, string = nil)
+  def raise(exception = undefined, string = nil, _backtrace = nil)
     %x{
       if (exception == null && #$! !== nil) {
         throw #$!;
@@ -1010,16 +1010,16 @@ module Kernel
       }
       else if (#{exception.kind_of?(Exception)}) {
         // exception is fine
-      }      
+      }
       else {
         exception = #{TypeError.new 'exception class/object expected'};
       }
-      
+
       if (#$! !== nil) {
         Opal.exceptions.push(#$!);
       }
-            
-      #$! = exception;      
+
+      #$! = exception;
 
       throw exception;
     }

data/opal/corelib/module.rb

@@ -180,10 +180,10 @@ class Module
 
   def class_variable_get(name)
     name = Opal.coerce_to!(name, String, :to_str)
-    raise NameError, 'class vars should start with @@' if `name.length < 3 || name.slice(0,2) !== '@@'`
+    raise NameError.new('class vars should start with @@', name) if `name.length < 3 || name.slice(0,2) !== '@@'`
     %x{
       var value = Opal.cvars[name.slice(2)];
-      #{raise NameError, 'uninitialized class variable @@a in' if `value == null`}
+      #{raise NameError.new('uninitialized class variable @@a in', name) if `value == null`}
       return value;
     }
   end
@@ -204,7 +204,7 @@ class Module
   # check for constant within current scope
   # if inherit is true or self is Object, will also check ancestors
   def const_defined?(name, inherit = true)
-    raise NameError, "wrong constant name #{name}" unless name =~ /^[A-Z]\w*$/
+    raise NameError.new("wrong constant name #{name}", name) unless name =~ /^[A-Z]\w*$/
 
     %x{
       var scopes = [self.$$scope];
@@ -234,7 +234,7 @@ class Module
       return name.split('::').inject(self) { |o, c| o.const_get(c) }
     end
 
-    raise NameError, "wrong constant name #{name}" unless `/^[A-Z]\w*$/.test(name)`
+    raise NameError.new("wrong constant name #{name}", name) unless `/^[A-Z]\w*$/.test(name)`
 
     %x{
       var scopes = [self.$$scope];
@@ -272,11 +272,11 @@ class Module
       }
     }
 
-    raise NameError, "uninitialized constant #{self}::#{name}"
+    raise NameError.new("uninitialized constant #{self}::#{name}", name)
   end
 
   def const_set(name, value)
-    raise NameError, "wrong constant name #{name}" unless name =~ /^[A-Z]\w*$/
+    raise NameError.new("wrong constant name #{name}", name) unless name =~ /^[A-Z]\w*$/
 
     begin
       name = name.to_str
@@ -374,7 +374,7 @@ class Module
       var meth = self.$$proto['$' + name];
 
       if (!meth || meth.$$stub) {
-        #{raise NameError, "undefined method `#{name}' for class `#{self.name}'"};
+        #{raise NameError.new("undefined method `#{name}' for class `#{self.name}'", name)};
       }
 
       return #{UnboundMethod.new(self, `meth`, name)};
@@ -452,16 +452,16 @@ class Module
 
   alias class_eval module_eval
 
-  def module_exec(&block)
+  def module_exec(*args, &block)
     %x{
       if (block === nil) {
-        throw new Error("no block given");
+        #{raise LocalJumpError, 'no block given'}
       }
 
       var block_self = block.$$s, result;
 
       block.$$s = null;
-      result = block.apply(self, $slice.call(arguments));
+      result = block.apply(self, args);
       block.$$s = block_self;
 
       return result;

data/opal/corelib/number.rb

@@ -298,7 +298,7 @@ class Number < Numeric
 
   def bit_length
     unless Integer === self
-      raise NoMethodError, "undefined method `bit_length` for #{self}:Float"
+      raise NoMethodError.new("undefined method `bit_length` for #{self}:Float", 'bit_length')
     end
 
     %x{

data/opal/corelib/regexp.rb

@@ -7,6 +7,12 @@ class Regexp < `RegExp`
   `def.$$is_regexp = true`  
 
   class << self
+    def allocate
+      allocated = super
+      `#{allocated}.uninitialized = true`
+      allocated      
+    end
+    
     def escape(string)
       %x{
         return string.replace(/([-[\]\/{}()*+?.^$\\| ])/g, '\\$1')
@@ -102,7 +108,7 @@ class Regexp < `RegExp`
   end
 
   def ===(string)
-    `#{match(string)} !== nil`
+    `#{match(Opal.coerce_to?(string, String, :to_str))} !== nil`
   end
 
   def =~(string)
@@ -117,6 +123,10 @@ class Regexp < `RegExp`
 
   def match(string, pos = undefined, &block)
     %x{
+      if (self.uninitialized) {
+        #{raise TypeError, 'uninitialized Regexp'}
+      }
+      
       if (pos === undefined) {
         pos = 0;
       } else {
@@ -136,8 +146,16 @@ class Regexp < `RegExp`
         }
       }
 
-      // global RegExp maintains state, so not using self/this
-      var md, re = new RegExp(self.source, 'gm' + (self.ignoreCase ? 'i' : ''));
+      var source = self.source;
+      var flags = 'g';
+      // m flag + a . in Ruby will match white space, but in JS, it only matches beginning/ending of lines, so we get the equivalent here
+      if (self.multiline) {
+        source = source.replace('.', "[\\s\\S]");
+        flags += 'm';
+      }
+
+      // global RegExp maintains state, so not using self/this            
+      var md, re = new RegExp(source, flags + (self.ignoreCase ? 'i' : ''));
 
       while (true) {
         md = re.exec(string);
@@ -162,36 +180,19 @@ class Regexp < `RegExp`
   end
   
   def options
-    # https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/flags is still experimental
-    # we need the flags and source does not give us that
+    # Flags would be nice to use with this, but still experimental - https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/flags
     %x{
-      var as_string, text_flags, result, text_flag;
-      as_string = self.toString();
-      if (as_string == "/(?:)/") {
+      if (self.uninitialized) {
         #{raise TypeError, 'uninitialized Regexp'}
+      }      
+      var result = 0;
+      // should be supported in IE6 according to https://msdn.microsoft.com/en-us/library/7f5z26w4(v=vs.94).aspx
+      if (self.multiline) {
+        result |= #{MULTILINE};
       }
-      text_flags = as_string.replace(self.source, '').match(/\w+/);
-      result = 0;
-      // may have no flags
-      if (text_flags == null) {
-        return result;
-      }
-      // first match contains all of our flags
-      text_flags = text_flags[0];
-      for (var i=0; i < text_flags.length; i++) {
-        text_flag = text_flags[i];
-        switch(text_flag) {
-          case 'i':
-            result |= #{IGNORECASE};
-            break;
-          case 'm':
-            result |= #{MULTILINE};
-            break;
-          default:
-            #{raise "RegExp flag #{`text_flag`} does not have a match in Ruby"}
-        }
-      }
-      
+      if (self.ignoreCase) {
+        result |= #{IGNORECASE};
+      }      
       return result;
     }  
   end

data/opal/corelib/string.rb

@@ -455,7 +455,7 @@ class String < `String`
   def gsub(pattern, replacement = undefined, &block)
     %x{
       if (replacement === undefined && block === nil) {
-        #{return enum_for :gsub, pattern}
+        return #{enum_for :gsub, pattern};
       }
 
       var result = '', match_data = nil, index = 0, match, _replacement;

data/opal/corelib/struct.rb

@@ -37,15 +37,13 @@ class Struct
 
     members << name
 
-    if Opal.valid_method_name?(name)
-      define_method name do
-        self[name]
-      end
-
-      define_method "#{name}=" do |value|
-        self[name] = value
-      end
+    define_method name do
+      self[name]
     end
+
+    define_method "#{name}=" do |value|
+      self[name] = value
+    end    
   end
 
   def self.members
@@ -85,7 +83,7 @@ class Struct
 
       name = members[name]
     elsif String === name
-      raise NameError, "no member '#{name}' in struct" unless members.include?(name.to_sym)
+      raise NameError.new("no member '#{name}' in struct", name) unless members.include?(name.to_sym)
     else
       raise TypeError, "no implicit conversion of #{name.class} into Integer"
     end
@@ -101,7 +99,7 @@ class Struct
 
       name = members[name]
     elsif String === name
-      raise NameError, "no member '#{name}' in struct" unless members.include?(name.to_sym)
+      raise NameError.new("no member '#{name}' in struct", name) unless members.include?(name.to_sym)
     else
       raise TypeError, "no implicit conversion of #{name.class} into Integer"
     end

data/opal/corelib/time.rb

@@ -159,7 +159,8 @@ class Time < `Date`
     }
   end
 
-  def self.local(year, month = nil, day = nil, hour = nil, min = nil, sec = nil, millisecond = nil)
+  def self.local(year, month = nil, day = nil, hour = nil, min = nil, sec = nil, millisecond = nil, _dummy1 = nil, _dummy2 = nil, _dummy3 = nil)
+    # The _dummy args are there only because the MRI version accepts up to 10 arguments
     %x{
       var args, result;
 
@@ -189,7 +190,8 @@ class Time < `Date`
     }
   end
 
-  def self.gm(year, month = nil, day = nil, hour = nil, min = nil, sec = nil, millisecond = nil)
+  def self.gm(year, month = nil, day = nil, hour = nil, min = nil, sec = nil, millisecond = nil, _dummy1 = nil, _dummy2 = nil, _dummy3 = nil)
+    # The _dummy args are there only because the MRI version accepts up to 10 arguments
     %x{
       var args, result;
 

data/opal/corelib/unsupported.rb

@@ -180,8 +180,8 @@ class Module
 
   alias nesting public
 
-  def private_class_method(name)
-    `self['$' + name] || nil`
+  def private_class_method(*)
+    self
   end
 
   alias public_class_method private_class_method

data/spec/filters/bugs/enumerable.rb

@@ -1,29 +1,10 @@
 opal_filter "Enumerable" do
-  fails "Enumerable#cycle passed a number n as an argument raises an ArgumentError if more arguments are passed"
-  fails "Enumerable#each_cons gathers whole arrays as elements when each yields multiple"
-  fails "Enumerable#each_cons passes element groups to the block"
-  fails "Enumerable#each_cons raises an ArgumentError if there is not a single parameter > 0"
-  fails "Enumerable#each_cons tries to convert n to an Integer using #to_int"
-  fails "Enumerable#each_cons when no block is given Enumerable with no size when no block is given returned Enumerator size returns nil"
-  fails "Enumerable#each_cons when no block is given Enumerable with size returned Enumerator size returns 0 when the argument is larger than self"
-  fails "Enumerable#each_cons when no block is given Enumerable with size returned Enumerator size returns 0 when the enum is empty"
-  fails "Enumerable#each_cons when no block is given Enumerable with size returned Enumerator size returns enum size - each_cons argument + 1"
-  fails "Enumerable#each_cons when no block is given returns an enumerator"
-  fails "Enumerable#each_cons works when n is >= full length"
-  fails "Enumerable#each_cons yields only as much as needed"
   fails "Enumerable#each_entry Enumerable with no size when no block is given returned Enumerator size returns nil"
   fails "Enumerable#each_entry Enumerable with size when no block is given returned Enumerator size returns the enumerable size"
   fails "Enumerable#each_entry passes extra arguments to #each"
   fails "Enumerable#each_entry passes through the values yielded by #each_with_index"
   fails "Enumerable#each_entry returns an enumerator if no block"
   fails "Enumerable#each_entry yields multiple arguments as an array"
-  fails "Enumerable#first raises a RangeError when passed a Bignum"
-  fails "Enumerable#minmax gathers whole arrays as elements when each yields multiple"
-  fails "Enumerable#minmax min should return the minimum element"
-  fails "Enumerable#minmax raises a NoMethodError for elements without #<=>"
-  fails "Enumerable#minmax raises an ArgumentError when elements are incomparable"
-  fails "Enumerable#minmax returns the minimum when using a block rule"
-  fails "Enumerable#minmax returns [nil, nil] for an empty Enumerable"
   fails "Enumerable#minmax_by Enumerable with no size when no block is given returned Enumerator size returns nil"
   fails "Enumerable#minmax_by Enumerable with size when no block is given returned Enumerator size returns the enumerable size"
   fails "Enumerable#minmax_by gathers whole arrays as elements when each yields multiple"

data/spec/filters/bugs/exception.rb

@@ -36,12 +36,8 @@ opal_filter "Exception" do
   fails "Exception#set_backtrace raises a TypeError when the Array contains a Symbol"
   fails "Exception#set_backtrace raises a TypeError when the array contains nil"
   fails "IOError is a superclass of EOFError"
-  fails "NameError.new NameError.new should take optional name argument"
-  fails "NoMethodError#args returns an array with the same elements as passed to the method"
-  fails "NoMethodError#args returns an empty array if the caller method had no arguments"
   fails "NoMethodError#message for an protected method match /protected method/"
   fails "NoMethodError#message for private method match /private method/"
-  fails "NoMethodError.new allows passing method args"
   fails "rescueing SignalException raises a SignalException when sent a signal"
   fails "SignalException.new raises an exception for an optional argument with a signal name"
   fails "SignalException.new raises an exception with an invalid signal name"

data/spec/filters/bugs/language.rb

@@ -54,6 +54,8 @@ opal_filter "language" do
   fails "A singleton class raises a TypeError for symbols"
   fails "An ensure block inside a begin block is executed even when a symbol is thrown in it's corresponding begin block"
   fails "An ensure block inside a method is executed even when a symbol is thrown in the method"
+  fails "Assigning an anonymous module to a constant sets the name of contained modules when assigning a toplevel anonymous module"
+  fails "Assigning an anonymous module to a constant sets the name of the module"
   fails "calling methods on the metaclass calls a method defined on the metaclass of the metaclass"
   fails "Class methods of a singleton class for a class include class methods of Class"
   fails "Class methods of a singleton class for a class include instance methods of the singleton class of Class"
@@ -67,7 +69,10 @@ opal_filter "language" do
   fails "Operators * / % are left-associative"
   fails "self in a metaclass body (class << obj) raises a TypeError for numbers"
   fails "self in a metaclass body (class << obj) raises a TypeError for symbols"
+  fails "The __FILE__ pseudo-variable equals the absolute path of a file loaded by a relative path" # we can't clear $LOADED_FEATURES, should be treated as readonly
+  fails "The __FILE__ pseudo-variable equals the absolute path of a file loaded by an absolute path" # we can't clear $LOADED_FEATURES, should be treated as readonly
   fails "The alias keyword is not allowed against Fixnum or String instances"
+  fails "The alias keyword on top level defines the alias on Object"
   fails "The alias keyword operates on methods defined via attr, attr_reader, and attr_accessor"
   fails "The alias keyword operates on methods with splat arguments defined in a superclass using text block for class eval"
   fails "The alias keyword operates on the object's metaclass when used in instance_eval"
@@ -77,6 +82,7 @@ opal_filter "language" do
   fails "The BEGIN keyword runs in a shared scope"
   fails "The BEGIN keyword runs multiple begins in FIFO order"
   fails "The defined? keyword for a scoped constant does not call .const_missing if the constant is not defined"
+  fails "The defined? keyword for a scoped constant returns nil when a constant is defined on top-level but not on the module"
   fails "The defined? keyword for a scoped constant returns nil when an undefined constant is scoped to a defined constant"
   fails "The defined? keyword for a simple constant does not call Object.const_missing if the constant is not defined"
   fails "The defined? keyword for a simple constant returns 'constant' for a constant defined in an included module"
@@ -84,8 +90,8 @@ opal_filter "language" do
   fails "The defined? keyword for a simple constant returns 'constant' when the constant is defined"
   fails "The defined? keyword for a simple constant returns nil when the constant is not defined"
   fails "The defined? keyword for a top-level scoped constant returns nil when an undefined constant is scoped to a defined constant"
-  fails "The defined? keyword for an expression returns nil for an expression with != and an undefined method"
   fails "The defined? keyword for an expression returns nil for an expression with !~ and an undefined method"
+  fails "The defined? keyword for an expression returns nil for an expression with != and an undefined method"
   fails "The defined? keyword for an expression returns nil for an expression with == and an undefined method"
   fails "The defined? keyword for an expression with logical connectives does not propagate an exception raised by a method in a 'not' expression"
   fails "The defined? keyword for an expression with logical connectives returns nil for an expression with '!' and an undefined method"
@@ -150,8 +156,6 @@ opal_filter "language" do
   fails "The super keyword without explicit arguments passes optional arguments that have a default value"
   fails "The super keyword without explicit arguments passes optional arguments that have a non-default value but were modified"
   fails "The super keyword without explicit arguments passes rest arguments including any modifications"
-  # can be removed when https://github.com/opal/opal/pull/1153 is merged
-  fails "The undef keyword allows undefining multiple methods at a time"
   fails "The unpacking splat operator (*) unpacks arguments as if they were listed statically"
   fails "The until expression restarts the current iteration without reevaluating condition with redo"
   fails "The until modifier restarts the current iteration without reevaluating condition with redo"
@@ -159,6 +163,4 @@ opal_filter "language" do
   fails "The until modifier with begin .. end block restart the current iteration without reevaluting condition with redo"
   fails "The until modifier with begin .. end block runs block at least once (even if the expression is true)"
   fails "The until modifier with begin .. end block skips to end of body with next"
-  fails "The __FILE__ pseudo-variable equals the absolute path of a file loaded by a relative path" # we can't clear $LOADED_FEATURES, should be treated as readonly
-  fails "The __FILE__ pseudo-variable equals the absolute path of a file loaded by an absolute path" # we can't clear $LOADED_FEATURES, should be treated as readonly
 end