opal 0.11.4 → 1.0.0.beta1

data/stdlib/template.rb

@@ -20,7 +20,7 @@ class Template
   end
 
   def inspect
-    "#<Template: '#@name'>"
+    "#<Template: '#{@name}'>"
   end
 
   def render(ctx = self)
@@ -43,4 +43,3 @@ class Template
     end
   end
 end
-

data/stdlib/thread.rb

@@ -21,7 +21,7 @@ class Thread
 
   # Do not allow creation of new instances.
   def initialize(*args)
-    fail NotImplementedError, "Thread creation not available"
+    raise NotImplementedError, 'Thread creation not available'
   end
 
   # fiber-local attribute access.
@@ -59,6 +59,7 @@ class Thread
   end
 
   private
+
   def core_initialize!
     @thread_locals = {}
     @fiber_locals  = {}
@@ -68,7 +69,6 @@ class Thread
     Opal.coerce_to!(key, String, :to_s)
   end
 
-  public
   class Queue
     def initialize
       clear
@@ -90,8 +90,8 @@ class Thread
 
     def pop(non_block = false)
       if empty?
-        fail ThreadError, "Queue empty" if non_block
-        fail ThreadError, "Deadlock"
+        raise ThreadError, 'Queue empty' if non_block
+        raise ThreadError, 'Deadlock'
       end
 
       @storage.shift
@@ -111,7 +111,6 @@ class Thread
       @storage.each(&block)
     end
   end
-
 end
 
 Queue = Thread::Queue
@@ -124,7 +123,7 @@ class Mutex
   end
 
   def lock
-    fail ThreadError, "Deadlock" if @locked
+    raise ThreadError, 'Deadlock' if @locked
     @locked = true
     self
   end
@@ -148,7 +147,7 @@ class Mutex
   end
 
   def unlock
-    fail ThreadError, "Mutex not locked" unless @locked
+    raise ThreadError, 'Mutex not locked' unless @locked
     @locked = false
     self
   end

data/tasks/benchmarking.rake

@@ -107,7 +107,7 @@ namespace :bench do
     raise ArgumentError, "no files provided" if files.empty?
     puts "=== Files: #{files.join ', '}"
     files.each do |bm_path|
-      sh "bundle exec opal -ropal/platform -gbenchmark-ips -rbenchmark/ips -A #{bm_path}"
+      sh "bundle exec opal --dynamic-require ignore --missing-require ignore -ropal/platform -gbenchmark-ips -rbenchmark/ips -A #{bm_path}"
     end
   end
 end

data/tasks/building.rake

@@ -17,9 +17,7 @@ task :dist do
   Opal::Config.arity_check_enabled = false
   Opal::Config.const_missing_enabled = false
   Opal::Config.dynamic_require_severity = :warning
-
-  # Hike gem is required to build opal-builder
-  Opal.use_gem 'hike'
+  Opal::Config.missing_require_severity = :error
 
   build_dir = ENV['DIR'] || 'build'
   files     = ENV['FILES'] ? ENV['FILES'].split(',') :
@@ -34,9 +32,9 @@ task :dist do
       log << "* building #{lib}...".ljust(width+'* building ... '.size)
       $stdout.flush
 
-      # Set requirable to true to be consistent with previous builds, generated
-      # with sprockets.
-      src = Opal::Builder.build(lib, requirable: true).to_s
+      # Set requirable to true, unless building opal. This allows opal to be auto-loaded.
+      requirable = (lib != 'opal')
+      src = Opal::Builder.build(lib, requirable: requirable).to_s
       min = Opal::Util.uglify src
       gzp = Opal::Util.gzip min
 
@@ -54,12 +52,6 @@ task :dist do
   end.map(&:value).map(&method(:puts))
 end
 
-desc 'Rebuild grammar.rb for opal parser'
-task :racc do
-  debug_option = '--debug' if ENV['RACC_DEBUG']
-  sh "racc #{debug_option} -l -o lib/opal/parser/grammar.rb lib/opal/parser/grammar.y"
-end
-
 desc 'Remove any generated file.'
 task :clobber do
   rm_r './build'

data/tasks/linting.rake

@@ -1,3 +1,4 @@
+import 'tasks/building.rake'
 desc "Build *corelib* and *stdlib* and lint the result"
 task :jshint do
   dir = 'tmp/lint'
@@ -5,7 +6,8 @@ task :jshint do
   puts "= Checking distributed files..."
   unless ENV['SKIP_BUILD']
     rm_rf dir if File.exist? dir
-    sh "bundle exec rake dist DIR=#{dir}"
+    ENV['DIR'] = dir
+    Rake::Task[:dist].invoke
   end
 
   Dir["#{dir}/*.js"].each {|path|
@@ -19,7 +21,8 @@ task :jshint do
   js_paths = []
   Dir['opal/{opal,corelib}/*.rb'].each do |path|
     js_path = "#{dir}/#{path.tr('/', '-')}.js"
-    sh "bundle exec opal -Dignore -cEO #{path} > #{js_path}"
+    Bundler::SharedHelpers.set_bundle_environment
+    File.write js_path, Opal.compile(File.read(path), file: path, dynamic_require_severity: :ignore)
     js_paths << js_path
   end
   js_paths.each do |js_path|
@@ -27,3 +30,15 @@ task :jshint do
   end
   sh "jshint --verbose opal/corelib/runtime.js"
 end
+
+require 'rubocop/rake_task'
+desc 'Run RuboCop on lib/, opal/ and stdlib/ directories'
+RuboCop::RakeTask.new(:rubocop) do |task|
+  # TODO: enable it back after releasing https://github.com/bbatsov/rubocop/pull/5633
+  # task.options << '--fail-fast'
+  task.options << '--extra-details'
+  task.options << '--display-style-guide'
+  task.options << '--parallel'
+end
+
+task :lint => [:jshint, :rubocop]

data/tasks/releasing.rake

@@ -0,0 +1,84 @@
+# frozen_string_literal: true
+
+require 'bundler'
+Bundler.require
+Bundler::GemHelper.install_tasks
+
+# Let the release process update the changelog from github
+task :release => :changelog
+
+github_releases = -> do
+  require 'date'
+  require 'octokit'
+  Octokit.auto_paginate = true
+
+  Octokit.releases('opal/opal').sort_by do |r|
+    Gem::Version.new(r[:tag_name][1..-1])
+  end.select do |release|
+    release[:tag_name] =~ /^v(\d+)(\.\d+)*$/
+  end
+end
+
+expand_pull_request_links = -> string {
+  string.gsub(/\(#(\d+)\)/, '([#\1](https://github.com/opal/opal/pull/\1))')
+}
+
+changelog_entry = -> (
+  tag_name:,
+  release_date:,
+  previous_tag_name:,
+  body:
+) do
+  compare_url = "https://github.com/opal/opal/compare/#{previous_tag_name}...#{tag_name}"
+  version_name = tag_name == 'HEAD' ? 'Unreleased' : tag_name.sub(/^v/, '')
+  [
+    "## [#{version_name}](#{compare_url}) - #{release_date}\n\n\n",
+    expand_pull_request_links[body.gsub("\r\n", "\n").strip],
+  ].join('')
+end
+
+CHANGELOG_HEADING = <<~MARKDOWN
+  # Change Log
+
+  All notable changes to this project will be documented in this file.
+  This project *tries* to adhere to [Semantic Versioning](http://semver.org/), even before v1.0.
+
+  Changes are grouped as follows:
+  - **Added** for new features.
+  - **Changed** for changes in existing functionality.
+  - **Deprecated** for once-stable features removed in upcoming releases.
+  - **Removed** for deprecated features removed in this release.
+  - **Fixed** for any bug fixes.
+  - **Security** to invite users to upgrade in case of vulnerabilities.
+MARKDOWN
+
+desc "Update CHANGELOG.md usign info from published GitHub releases (the first unreleased section is preserved)"
+task :changelog do
+  changelog_path    = "#{__dir__}/../CHANGELOG.md"
+  unreleased_path   = "#{__dir__}/../UNRELEASED.md"
+  changelog_entries = []
+  previous_tag_name = '000000'
+
+  github_releases.call.each do |release|
+    changelog_entries.unshift changelog_entry.call(
+      tag_name: release[:tag_name],
+      release_date: release[:created_at].to_date.iso8601, # YYYY-MM-DD
+      previous_tag_name: previous_tag_name,
+      body: release[:body],
+    )
+    previous_tag_name = release[:tag_name]
+  end
+
+  changelog_entries.unshift changelog_entry.call(
+    tag_name: 'HEAD',
+    release_date: 'unreleased',
+    previous_tag_name: previous_tag_name,
+    body: File.read(unreleased_path),
+  )
+
+  changelog_entries.unshift CHANGELOG_HEADING
+
+  changelog_entries << nil # for the final newlines
+
+  File.write changelog_path, changelog_entries.join("\n\n\n\n\n")
+end

data/tasks/testing.rake

@@ -3,6 +3,11 @@ RSpec::Core::RakeTask.new(:rspec) do |t|
   t.pattern = 'spec/lib/**/*_spec.rb'
 end
 
+if ENV.key?('RUBYSPEC')
+  warn "Did you mean RUBYSPECS=...? (RUBYSPEC was found among ENV variables)"
+  exit 1
+end
+
 module Testing
   extend self
 
@@ -20,7 +25,6 @@ module Testing
         mspec/helpers/tmp
         mspec/helpers/environment
         mspec/guards/block_device
-        mspec/guards/endian
         a_file
         lib/spec_helper
         mspec/commands/mspec-run
@@ -32,6 +36,7 @@ module Testing
       suite = env['SUITE']
       pattern = env['PATTERN']
       whitelist_pattern = !!env['RUBYSPECS']
+      env['OPAL_PLATFORM_NAME'] = RbConfig::CONFIG['host_os'] unless env['OPAL_PLATFORM_NAME']
 
       excepting = []
       rubyspecs = File.read('spec/ruby_specs').lines.reject do |l|
@@ -139,6 +144,7 @@ module Testing
 
   module Minitest
     extend self
+    extend FileUtils
 
     def write_file(filename, files = [], env = {})
       env_data = env.map{ |k,v| "ENV[#{k.inspect}] = #{v.to_s.inspect}" unless v.nil? }.join("\n")
@@ -227,6 +233,38 @@ module Testing
     end
   end
 
+  class HTTPServer
+    def with_server
+      begin
+        server = Process.spawn 'ruby test/opal/http_server.rb'
+        puts 'Waiting for server…'
+        sleep 0.1 until sinatra_server_running?
+        puts 'Server ready.'
+        yield self
+      ensure
+        if windows?
+          # https://blog.simplificator.com/2016/01/18/how-to-kill-processes-on-windows-using-ruby/
+          # system("taskkill /f /pid #{pid}")
+          Process.kill("KILL", server)
+        else
+          Process.kill(:TERM, server)
+        end
+        Process.wait(server)
+      end
+    end
+
+    def windows?
+      (/cygwin|mswin|mingw|bccwin|wince|emx/ =~ RUBY_PLATFORM) != nil
+    end
+
+    def sinatra_server_running?
+      puts "Connecting to localhost:4567..."
+      TCPSocket.new('localhost', '4567').close
+      true
+    rescue Errno::ECONNREFUSED, Errno::EADDRNOTAVAIL
+      false
+    end
+  end
 end
 
 
@@ -235,8 +273,8 @@ Use PATTERN environment variable to manually set the glob for specs:
 
   # Will run all specs matching the specified pattern.
   # (Note: the ruby_specs filters will still apply)
-  bundle exec rake mspec_node PATTERN=spec/ruby/core/module/class_variable*_spec.rb
-  bundle exec rake mspec_node PATTERN=spec/ruby/core/numeric/**_spec.rb
+  bundle exec rake mspec_nodejs PATTERN=spec/ruby/core/module/class_variable*_spec.rb
+  bundle exec rake mspec_nodejs PATTERN=spec/ruby/core/numeric/**_spec.rb
 DESC
 
 platforms = %w[nodejs server chrome]
@@ -261,7 +299,7 @@ platforms.each do |platform|
       stubs = Testing::MSpec.stubs.map{|s| "-s#{s}"}.join(' ')
 
       sh "ruby -w -rbundler/setup -r#{__dir__}/testing/mspec_special_calls "\
-         "exe/opal -gmspec -Ispec -Ilib #{stubs} -R#{platform} -Dwarning -A --enable-source-location #{filename}"
+         "exe/opal -Ispec/mspec/lib -Ispec -Ilib #{stubs} -R#{platform} -Dwarning -A --enable-source-location #{filename}"
 
       if bm_filepath
         puts "Benchmark results have been written to #{bm_filepath}"
@@ -283,18 +321,22 @@ platforms.each do |platform|
           ruby/test_call.rb
           opal/test_keyword.rb
           opal/test_base64.rb
+          opal/test_openuri.rb
           opal/unsupported_and_bugs.rb
+          opal/test_matrix.rb
         ]
       end
+      Testing::HTTPServer.new.with_server do |session|
+        filename = "tmp/minitest_#{suite}_#{platform}.rb"
+        files.push('nodejs') if platform == 'nodejs'
+        Testing::Minitest.write_file(filename, files, ENV)
 
-      filename = "tmp/minitest_#{suite}_#{platform}.rb"
-      Testing::Minitest.write_file(filename, files, ENV)
-
-      stubs = "-soptparse -sio/console -stimeout -smutex_m -srubygems -stempfile -smonitor"
-      includes = "-Itest -Ilib -Ivendored-minitest #{includes}"
+        stubs = "-soptparse -sio/console -stimeout -smutex_m -srubygems -stempfile -smonitor"
+        includes = "-Itest -Ilib -Ivendored-minitest #{includes}"
 
-      sh "ruby -rbundler/setup "\
-         "exe/opal -ghike #{includes} #{stubs} -R#{platform} -Dwarning -A --enable-source-location #{filename}"
+        sh "ruby -rbundler/setup "\
+         "exe/opal #{includes} #{stubs} -R#{platform} -Dwarning -A --enable-source-location #{filename}"
+      end
     end
   end
 end
@@ -302,15 +344,15 @@ end
 # The name ends with the platform, which is of course mandated in this case
 desc "Run the Node.js Minitest suite on Node.js"
 task :minitest_node_nodejs do
-  Opal.use_gem 'hike'
-
   platform = 'nodejs'
   files = %w[
     nodejs
     opal-parser
     nodejs/test_file.rb
     nodejs/test_dir.rb
+    nodejs/test_env.rb
     nodejs/test_io.rb
+    nodejs/test_file_encoding.rb
     nodejs/test_opal_builder.rb
   ]
 
@@ -321,7 +363,7 @@ task :minitest_node_nodejs do
   includes = "-Itest -Ilib -Ivendored-minitest"
 
   sh "ruby -rbundler/setup "\
-     "exe/opal -ghike #{includes} #{stubs} -R#{platform} -Dwarning -A --enable-source-location #{filename}"
+     "exe/opal #{includes} #{stubs} -R#{platform} -Dwarning -A --enable-source-location #{filename}"
 end
 
 desc 'Run smoke tests with opal-rspec to see if something is broken'
@@ -340,7 +382,7 @@ task :smoke_test do
 
   cd opal_rspec_dir do
     Bundler.with_clean_env do
-      sh 'bundle install'
+      sh 'bundle check && bundle update opal-rspec || bundle install'
       sh %{bundle exec opal-rspec --color --default-path=../../spec ../../spec/lib/deprecations_spec.rb > #{actual_output_path}}
 
       actual_output = File.read(actual_output_path)

data/tasks/testing/mspec_special_calls.rb

@@ -1,4 +1,5 @@
 require 'opal/nodes/call'
+require 'opal/ast/builder'
 
 class Opal::Nodes::CallNode
   # Rubyspec uses this call to load in language specific features at runtime.
@@ -28,14 +29,20 @@ class Opal::Nodes::CallNode
     end
   end
 
+  has_xstring = -> node {
+    next if node.nil? || !node.respond_to?(:type)
+    node.type == :xstr || (node.children && node.children.any?(&has_xstring))
+  }
+
   add_special :platform_is_not do |compile_default|
-    unless arglist.children.include?(s(:sym, :opal))
-      compile_default.call
-    end
+    next if arglist.children.include?(s(:sym, :opal))
+    next if children.any?(&has_xstring)
+
+    compile_default.call
   end
 
   add_special :platform_is do |compile_default|
-    if arglist.children.include?(s(:sym, :opal))
+    if arglist.children.include?(s(:sym, :opal)) || !children.any?(&has_xstring)
       compile_default.call
     end
   end
@@ -69,5 +76,17 @@ def opal_unsupported_filter(filter_name, &block)
   Opal::Rubyspec::FiltersRewriter.instance_eval(&block)
 end
 
+# In the test environment we have to parse invalid characters
+# Otherwise the parser throws an error and the whole suites aborts
+class Opal::AST::Builder
+  def string_value(token)
+    unless token[0].valid_encoding?
+      diagnostic(:warning, :invalid_encoding, nil, token[1])
+    end
+
+    token[0]
+  end
+end
+
 Dir[File.expand_path('../../../spec/filters/unsupported/**/*.rb', __FILE__)].each { |f| require f }
 Dir[File.expand_path('../../../spec/filters/bugs/**/*.rb', __FILE__)].each { |f| require f }