opal 0.11.4 → 1.0.0.beta1

data/lib/opal/version.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
+
 module Opal
   # WHEN RELEASING:
   # Remember to update RUBY_ENGINE_VERSION in opal/corelib/constants.rb too!
-  VERSION = '0.11.4'
+  VERSION = '1.0.0.beta1'
 end

data/lib/tilt/opal.rb

@@ -1,11 +1,10 @@
 # frozen_string_literal: true
+
 require 'tilt'
 require 'opal/builder'
 require 'opal/config'
 require 'opal/version'
 
-$OPAL_SOURCE_MAPS = {}
-
 module Opal
   class TiltTemplate < Tilt::Template
     self.default_mime_type = 'application/javascript'
@@ -31,9 +30,10 @@ module Opal
     end
 
     def prepare
+      # stub
     end
 
-    def evaluate(_, _, &block)
+    def evaluate(_scope, _locals)
       if builder = @options[:builder]
         builder.dup.build(file).to_s
       elsif @options[:build]

data/opal.gemspec

@@ -13,6 +13,17 @@ Gem::Specification.new do |spec|
   spec.homepage     = 'https://opalrb.com'
   spec.license      = 'MIT'
 
+  spec.metadata = {
+    "bug_tracker_uri"       => "https://github.com/opal/opal/issues",
+    "changelog_uri"         => "https://github.com/opal/opal/blob/v#{spec.version}/CHANGELOG.md",
+    "readme_uri"            => "https://github.com/opal/opal/blob/v#{spec.version}/README.md",
+    "api_documentation_uri" => "http://opalrb.com/docs/api/v#{spec.version}/index.html",
+    "guides_uri"            => "http://opalrb.com/docs/guides/v#{spec.version}/index.html",
+    "homepage_uri"          => "https://opalrb.com/",
+    "chat_uri"              => "https://gitter.im/opal/opal",
+    "source_code_uri"       => "https://github.com/opal/opal",
+  }
+
   spec.files         = Dir.chdir(File.expand_path('..', __FILE__)) do
     `git ls-files -z`.split("\x0")
       .reject { |f| f.match(%r{^(test|spec|features)/}) }
@@ -24,20 +35,18 @@ Gem::Specification.new do |spec|
 
   spec.required_ruby_version = '>= 2.0.0'
 
-  spec.add_dependency 'sourcemap', '~> 0.1.0'
-  spec.add_dependency 'hike', '~> 1.2'
   spec.add_dependency 'ast', '>= 2.3.0'
-  spec.add_dependency 'parser', '= 2.3.3.1'
+  spec.add_dependency 'parser', '= 2.5.3.0'
 
-  spec.add_development_dependency 'mspec', '1.5.20'
+  spec.add_development_dependency 'sourcemap', '~> 0.1.0'
   spec.add_development_dependency 'rake', '~> 10.0'
-  spec.add_development_dependency 'racc'
-  spec.add_development_dependency 'rspec', '~> 3.6.0'
-  spec.add_development_dependency 'octokit', '~> 2.4.0'
-  spec.add_development_dependency 'bundler', '~> 1.5'
-  spec.add_development_dependency 'yard', '~> 0.8.7'
+  spec.add_development_dependency 'rspec', '~> 3.7'
+  spec.add_development_dependency 'octokit', '~> 4.9'
+  spec.add_development_dependency 'bundler'
   spec.add_development_dependency 'rack-test'
   spec.add_development_dependency 'opal-minitest'
   spec.add_development_dependency 'selenium-webdriver'
   spec.add_development_dependency 'benchmark-ips'
+  spec.add_development_dependency 'sinatra'
+  spec.add_development_dependency 'rubocop', '= 0.53.0'
 end

data/opal/corelib/array.rb

@@ -5,7 +5,7 @@ class Array < `Array`
   include Enumerable
 
   # Mark all javascript arrays as being valid ruby arrays
-  `def.$$is_array = true`
+  `Opal.defineProperty(self.$$prototype, '$$is_array', true)`
 
   %x{
     function toArraySubclass(obj, klass) {
@@ -28,7 +28,7 @@ class Array < `Array`
       }
 
       if (size > #{Integer::MAX}) {
-        #{raise ArgumentError, "array size too big"}
+        #{raise ArgumentError, 'array size too big'}
       }
 
       if (arguments.length > 2) {
@@ -53,7 +53,7 @@ class Array < `Array`
       size = #{Opal.coerce_to size, Integer, :to_int}
 
       if (size < 0) {
-        #{raise ArgumentError, "negative array size"}
+        #{raise ArgumentError, 'negative array size'}
       }
 
       self.splice(0, self.length);
@@ -80,11 +80,11 @@ class Array < `Array`
   end
 
   def &(other)
-    if Array === other
-      other = other.to_a
-    else
-      other = Opal.coerce_to(other, Array, :to_ary).to_a
-    end
+    other = if Array === other
+              other.to_a
+            else
+              Opal.coerce_to(other, Array, :to_ary).to_a
+            end
 
     %x{
       var result = [], hash = #{{}}, i, length, item;
@@ -105,11 +105,11 @@ class Array < `Array`
   end
 
   def |(other)
-    if Array === other
-      other = other.to_a
-    else
-      other = Opal.coerce_to(other, Array, :to_ary).to_a
-    end
+    other = if Array === other
+              other.to_a
+            else
+              Opal.coerce_to(other, Array, :to_ary).to_a
+            end
 
     %x{
       var hash = #{{}}, i, length, item;
@@ -132,12 +132,12 @@ class Array < `Array`
     other = Opal.coerce_to other, Integer, :to_int
 
     if `other < 0`
-      raise ArgumentError, "negative argument"
+      raise ArgumentError, 'negative argument'
     end
 
     %x{
       var result = [],
-          converted = #{self.to_a};
+          converted = #{to_a};
 
       for (var i = 0; i < other; i++) {
         result = result.concat(converted);
@@ -148,21 +148,21 @@ class Array < `Array`
   end
 
   def +(other)
-    if Array === other
-      other = other.to_a
-    else
-      other = Opal.coerce_to(other, Array, :to_ary).to_a
-    end
+    other = if Array === other
+              other.to_a
+            else
+              Opal.coerce_to(other, Array, :to_ary).to_a
+            end
 
     `self.concat(other)`
   end
 
   def -(other)
-    if Array === other
-      other = other.to_a
-    else
-      other = Opal.coerce_to(other, Array, :to_ary).to_a
-    end
+    other = if Array === other
+              other.to_a
+            else
+              Opal.coerce_to(other, Array, :to_ary).to_a
+            end
 
     return [] if `self.length === 0`
     return `self.slice()` if `other.length === 0`
@@ -186,7 +186,7 @@ class Array < `Array`
   end
 
   def <<(object)
-    `self.push(object);`
+    `self.push(object)`
 
     self
   end
@@ -237,9 +237,9 @@ class Array < `Array`
           }
         }
 
-        if (array.constructor !== Array)
+        if (array.$$constructor !== Array)
           array = #{`array`.to_a};
-        if (other.constructor !== Array)
+        if (other.$$constructor !== Array)
           other = #{`other`.to_a};
 
         if (array.length !== other.length) {
@@ -362,13 +362,13 @@ class Array < `Array`
     }
 
     if Range === index
-      if Array === value
-        data = value.to_a
-      elsif value.respond_to? :to_ary
-        data = value.to_ary.to_a
-      else
-        data = [value]
-      end
+      data = if Array === value
+               value.to_a
+             elsif value.respond_to? :to_ary
+               value.to_ary.to_a
+             else
+               [value]
+             end
 
       %x{
         var exclude = index.excl,
@@ -413,13 +413,13 @@ class Array < `Array`
         length = value
         value  = extra
 
-        if Array === value
-          data = value.to_a
-        elsif value.respond_to? :to_ary
-          data = value.to_ary.to_a
-        else
-          data = [value]
-        end
+        data = if Array === value
+                 value.to_a
+               elsif value.respond_to? :to_ary
+                 value.to_ary.to_a
+               else
+                 [value]
+               end
       end
 
       %x{
@@ -459,8 +459,8 @@ class Array < `Array`
     end
   end
 
-  def any?
-    `if (self.length === 0) return false;`
+  def any?(pattern = undefined, &block)
+    `if (self.length === 0) return false`
     super
   end
 
@@ -546,14 +546,16 @@ class Array < `Array`
   end
 
   def cycle(n = nil, &block)
-    return enum_for(:cycle, n) {
-      if n == nil
-        Float::INFINITY
-      else
-        n = Opal.coerce_to!(n, Integer, :to_int)
-        n > 0 ? self.enumerator_size * n : 0
+    unless block_given?
+      return enum_for(:cycle, n) do
+        if n.nil?
+          Float::INFINITY
+        else
+          n = Opal.coerce_to!(n, Integer, :to_int)
+          n > 0 ? enumerator_size * n : 0
+        end
       end
-    } unless block_given?
+    end
 
     return if empty? || n == 0
 
@@ -605,7 +607,7 @@ class Array < `Array`
   end
 
   def collect(&block)
-    return enum_for(:collect){self.size} unless block_given?
+    return enum_for(:collect) { size } unless block_given?
 
     %x{
       var result = [];
@@ -620,7 +622,7 @@ class Array < `Array`
   end
 
   def collect!(&block)
-    return enum_for(:collect!){self.size} unless block_given?
+    return enum_for(:collect!) { size } unless block_given?
 
     %x{
       for (var i = 0, length = self.length; i < length; i++) {
@@ -648,7 +650,7 @@ class Array < `Array`
 
   def combination(n)
     num = Opal.coerce_to! n, Integer, :to_int
-    return enum_for(:combination, num){ `binomial_coefficient(#{self}.length, num)` } unless block_given?
+    return enum_for(:combination, num) { `binomial_coefficient(#{self}.length, num)` } unless block_given?
 
     %x{
       var i, length, stack, chosen, lev, done, next;
@@ -698,7 +700,7 @@ class Array < `Array`
     num = Opal.coerce_to! n, Integer, :to_int
 
     unless block_given?
-      return enum_for(:repeated_combination, num){ `binomial_coefficient(self.length + num - 1, num)` }
+      return enum_for(:repeated_combination, num) { `binomial_coefficient(self.length + num - 1, num)` }
     end
 
     %x{
@@ -755,11 +757,11 @@ class Array < `Array`
 
   def concat(*others)
     others = others.map do |other|
-      if Array === other
-        other = other.to_a
-      else
-        other = Opal.coerce_to(other, Array, :to_ary).to_a
-      end
+      other = if Array === other
+                other.to_a
+              else
+                Opal.coerce_to(other, Array, :to_ary).to_a
+              end
 
       if other.equal?(self)
         other = other.dup
@@ -823,7 +825,7 @@ class Array < `Array`
   end
 
   def delete_if(&block)
-    return enum_for(:delete_if){self.size} unless block_given?
+    return enum_for(:delete_if) { size } unless block_given?
 
     %x{
       for (var i = 0, length = self.length, value; i < length; i++) {
@@ -869,19 +871,19 @@ class Array < `Array`
 
   def dup
     %x{
-      if (
-        self.$$class === Opal.Array &&
-        self.$$class.$allocate.$$pristine &&
-        self.$copy_instance_variables.$$pristine &&
-        self.$initialize_dup.$$pristine
-      ) return self.slice(0);
+      if (self.$$class === Opal.Array &&
+          self.$$class.$allocate.$$pristine &&
+          self.$copy_instance_variables.$$pristine &&
+          self.$initialize_dup.$$pristine) {
+        return self.slice(0);
+      }
     }
 
     super
   end
 
   def each(&block)
-    return enum_for(:each){self.size} unless block_given?
+    return enum_for(:each) { size } unless block_given?
 
     %x{
       for (var i = 0, length = self.length; i < length; i++) {
@@ -893,7 +895,7 @@ class Array < `Array`
   end
 
   def each_index(&block)
-    return enum_for(:each_index){self.size} unless block_given?
+    return enum_for(:each_index) { size } unless block_given?
 
     %x{
       for (var i = 0, length = self.length; i < length; i++) {
@@ -1001,7 +1003,7 @@ class Array < `Array`
       one, two = args
     else
       if `args.length == 0`
-        raise ArgumentError, "wrong number of arguments (0 for 1..3)"
+        raise ArgumentError, 'wrong number of arguments (0 for 1..3)'
       elsif `args.length > 3`
         raise ArgumentError, "wrong number of arguments (#{args.length} for 1..3)"
       end
@@ -1010,13 +1012,13 @@ class Array < `Array`
     end
 
     if Range === one
-      raise TypeError, "length invalid with range" if two
+      raise TypeError, 'length invalid with range' if two
 
       left   = Opal.coerce_to one.begin, Integer, :to_int
       `left += this.length` if `left < 0`
       raise RangeError, "#{one.inspect} out of range" if `left < 0`
 
-      right  = Opal.coerce_to one.end, Integer, :to_int
+      right = Opal.coerce_to one.end, Integer, :to_int
       `right += this.length` if `right < 0`
       `right += 1` unless one.exclude_end?
 
@@ -1098,7 +1100,7 @@ class Array < `Array`
         for (i = 0, length = array.length; i < length; i++) {
           item = array[i];
 
-          if (!#{Opal.respond_to? `item`, :to_ary}) {
+          if (!#{Opal.respond_to? `item`, :to_ary, true}) {
             result.push(item);
             continue;
           }
@@ -1214,7 +1216,7 @@ class Array < `Array`
     }
   end
 
-  def index(object=undefined, &block)
+  def index(object = undefined, &block)
     %x{
       var i, length, value;
 
@@ -1292,7 +1294,7 @@ class Array < `Array`
   end
 
   def join(sep = nil)
-    return "" if `self.length === 0`
+    return '' if `self.length === 0`
 
     if `sep === nil`
       sep = $,
@@ -1352,7 +1354,7 @@ class Array < `Array`
   end
 
   def keep_if(&block)
-    return enum_for(:keep_if){self.size} unless block_given?
+    return enum_for(:keep_if) { size } unless block_given?
 
     %x{
       for (var i = 0, length = self.length, value; i < length; i++) {
@@ -1398,6 +1400,14 @@ class Array < `Array`
 
   alias map! collect!
 
+  def max(n = undefined, &block)
+    each.max(n, &block)
+  end
+
+  def min(&block)
+    each.min(&block)
+  end
+
   %x{
     // Returns the product of from, from-1, ..., from - how_many + 1.
     function descending_factorial(from, how_many) {
@@ -1413,9 +1423,9 @@ class Array < `Array`
 
   def permutation(num = undefined, &block)
     unless block_given?
-      return enum_for(:permutation, num) {
+      return enum_for(:permutation, num) do
         `descending_factorial(self.length, num === undefined ? self.length : num)`
-      }
+      end
     end
 
     %x{
@@ -1483,7 +1493,7 @@ class Array < `Array`
 
   def repeated_permutation(n)
     num = Opal.coerce_to! n, Integer, :to_int
-    return enum_for(:repeated_permutation, num){ num >= 0 ? self.size ** num : 0 } unless block_given?
+    return enum_for(:repeated_permutation, num) { num >= 0 ? size**num : 0 } unless block_given?
 
     %x{
       function iterate(max, buffer, self) {
@@ -1547,7 +1557,7 @@ class Array < `Array`
         }
         resultlen *= len;
         if (resultlen > 2147483647) {
-          #{raise RangeError, "too big to product"}
+          #{raise RangeError, 'too big to product'}
         }
         lengths[i] = len;
         counters[i] = 0;
@@ -1586,6 +1596,8 @@ class Array < `Array`
     self
   end
 
+  alias append push
+
   def rassoc(object)
     %x{
       for (var i = 0, length = self.length, item; i < length; i++) {
@@ -1603,7 +1615,7 @@ class Array < `Array`
   end
 
   def reject(&block)
-    return enum_for(:reject){self.size} unless block_given?
+    return enum_for(:reject) { size } unless block_given?
 
     %x{
       var result = [];
@@ -1620,7 +1632,7 @@ class Array < `Array`
   end
 
   def reject!(&block)
-    return enum_for(:reject!){self.size} unless block_given?
+    return enum_for(:reject!) { size } unless block_given?
 
     original = length
     delete_if(&block)
@@ -1631,11 +1643,11 @@ class Array < `Array`
   end
 
   def replace(other)
-    if Array === other
-      other = other.to_a
-    else
-      other = Opal.coerce_to(other, Array, :to_ary).to_a
-    end
+    other = if Array === other
+              other.to_a
+            else
+              Opal.coerce_to(other, Array, :to_ary).to_a
+            end
 
     %x{
       self.splice(0, self.length);
@@ -1654,7 +1666,7 @@ class Array < `Array`
   end
 
   def reverse_each(&block)
-    return enum_for(:reverse_each){self.size} unless block_given?
+    return enum_for(:reverse_each) { size } unless block_given?
 
     reverse.each(&block)
     self
@@ -1699,7 +1711,7 @@ class Array < `Array`
     }
   end
 
-  def rotate(n=1)
+  def rotate(n = 1)
     n = Opal.coerce_to n, Integer, :to_int
     %x{
       var ary, idx, firstPart, lastPart;
@@ -1720,7 +1732,7 @@ class Array < `Array`
     }
   end
 
-  def rotate!(cnt=1)
+  def rotate!(cnt = 1)
     %x{
       if (self.length === 0 || self.length === 1) {
         return self;
@@ -1738,8 +1750,8 @@ class Array < `Array`
 
     def rand(size)
       random = Opal.coerce_to @rng.rand(size), Integer, :to_int
-      raise RangeError, "random value must be >= 0" if `random < 0`
-      raise RangeError, "random value must be less than Array size" unless `random < size`
+      raise RangeError, 'random value must be >= 0' if `random < 0`
+      raise RangeError, 'random value must be less than Array size' unless `random < size`
 
       random
     end
@@ -1761,16 +1773,16 @@ class Array < `Array`
       options = Opal.coerce_to options, Hash, :to_hash
     end
 
-    if count and `count < 0`
-      raise ArgumentError, "count must be greater than 0"
+    if count && `count < 0`
+      raise ArgumentError, 'count must be greater than 0'
     end
 
     rng = options[:random] if options
-    if rng and rng.respond_to? :rand
-      rng = SampleRandom.new rng
-    else
-      rng = Kernel
-    end
+    rng = if rng && rng.respond_to?(:rand)
+            SampleRandom.new rng
+          else
+            Kernel
+          end
 
     return `self[#{rng.rand(`self.length`)}]` unless count
 
@@ -1857,7 +1869,7 @@ class Array < `Array`
   end
 
   def select(&block)
-    return enum_for(:select){self.size} unless block_given?
+    return enum_for(:select) { size } unless block_given?
 
     %x{
       var result = [];
@@ -1867,7 +1879,7 @@ class Array < `Array`
 
         value = Opal.yield1(block, item);
 
-        if (value !== false && value !== nil) {
+        if (Opal.truthy(value)) {
           result.push(item);
         }
       }
@@ -1877,7 +1889,7 @@ class Array < `Array`
   end
 
   def select!(&block)
-    return enum_for(:select!){self.size} unless block_given?
+    return enum_for(:select!) { size } unless block_given?
 
     %x{
       var original = self.length;
@@ -2080,7 +2092,7 @@ class Array < `Array`
   end
 
   def sort_by!(&block)
-    return enum_for(:sort_by!){self.size} unless block_given?
+    return enum_for(:sort_by!) { size } unless block_given?
 
     replace sort_by(&block)
   end
@@ -2150,12 +2162,12 @@ class Array < `Array`
     result = []
     max    = nil
 
-    each {|row|
-      if Array === row
-        row = row.to_a
-      else
-        row = Opal.coerce_to(row, Array, :to_ary).to_a
-      end
+    each do |row|
+      row = if Array === row
+              row.to_a
+            else
+              Opal.coerce_to(row, Array, :to_ary).to_a
+            end
 
       max ||= `row.length`
 
@@ -2163,11 +2175,11 @@ class Array < `Array`
         raise IndexError, "element size differs (#{`row.length`} should be #{max})"
       end
 
-      `row.length`.times {|i|
+      `row.length`.times do |i|
         entry = (result[i] ||= [])
         entry << row.at(i)
-      }
-    }
+      end
+    end
 
     result
   end
@@ -2230,11 +2242,13 @@ class Array < `Array`
     self
   end
 
+  alias prepend unshift
+
   def values_at(*args)
-    out = [];
+    out = []
 
     args.each do |elem|
-      if elem.kind_of? Range
+      if elem.is_a? Range
         finish = Opal.coerce_to elem.last, Integer, :to_int
         start = Opal.coerce_to elem.first, Integer, :to_int
 
@@ -2320,7 +2334,7 @@ class Array < `Array`
 
   def self.inherited(klass)
     %x{
-      klass.$$proto.$to_a = function() {
+      klass.$$prototype.$to_a = function() {
         return this.slice(0, this.length);
       }
     }
@@ -2330,6 +2344,10 @@ class Array < `Array`
     super.reject { |ivar| `/^@\d+$/.test(#{ivar})` || ivar == '@length' }
   end
 
-  Opal.pristine self, :allocate, :copy_instance_variables, :initialize_dup
-end
+  Opal.pristine singleton_class, :allocate
+  Opal.pristine self, :copy_instance_variables, :initialize_dup
 
+  def pack(*args)
+    raise "To use Array#pack, you must first require 'corelib/array/pack'."
+  end
+end