omnibus 3.0.0 → 3.1.0

data/spec/unit/project_spec.rb

@@ -1,138 +1,136 @@
-#
-# Copyright:: Copyright (c) 2014 Noah Kantrowitz
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the 'License');
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an 'AS IS' BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
 require 'spec_helper'
+require 'ohai'
 
-require 'omnibus/project'
+module Omnibus
+  describe Project do
+    let(:project) do
+      Omnibus::Project.load(project_path('sample'))
+    end
 
-describe Omnibus::Project do
-  let(:project) do
-    Omnibus::Project.load(project_path('sample'))
-  end
+    subject { project }
 
-  subject { project }
+    describe 'basics' do
+      it 'should return a name' do
+        expect(project.name).to eq('sample')
+      end
 
-  describe 'basics' do
-    it 'should return a name' do
-      expect(project.name).to eq('sample')
-    end
+      it 'should return an install path' do
+        expect(project.install_path).to eq('/sample')
+      end
 
-    it 'should return an install path' do
-      expect(project.install_path).to eq('/sample')
-    end
+      it 'should return a maintainer' do
+        expect(project.maintainer).to eq('Sample Devs')
+      end
 
-    it 'should return a maintainer' do
-      expect(project.maintainer).to eq('Sample Devs')
-    end
+      it 'should return a homepage' do
+        expect(project.homepage).to eq('http://example.com/')
+      end
 
-    it 'should return a homepage' do
-      expect(project.homepage).to eq('http://example.com/')
-    end
+      it 'should return a build version' do
+        expect(project.build_version).to eq('1.0')
+      end
 
-    it 'should return a build version' do
-      expect(project.build_version).to eq('1.0')
-    end
+      it 'should return a build iteration' do
+        expect(project.build_iteration).to eq('1')
+      end
 
-    it 'should return a build iteration' do
-      expect(project.build_iteration).to eq('1')
-    end
+      it 'should return an array of files and dirs' do
+        expect(project.extra_package_files).to eq(['/path/to/sample_dir', '/path/to/file.conf'])
+      end
 
-    it 'should return an array of files and dirs' do
-      expect(project.extra_package_files).to eq(['/path/to/sample_dir', '/path/to/file.conf'])
-    end
-  end
+      it 'should return friendly_name' do
+        expect(project.friendly_name).to eq('Sample Project')
+      end
 
-  describe '#iteration' do
-    let(:fauxhai_options) { Hash.new }
-    around(:each) do |example|
-      data = OHAI.data
-      begin
-        OHAI.data = Mash.new(Fauxhai.mock(fauxhai_options).data)
-        example.run
-      ensure
-        OHAI.data = data
+      it 'should return friendly_name' do
+        expect(project.resources_path).to eq('sample/project/resources')
       end
     end
 
-    context 'when on RHEL' do
-      let(:fauxhai_options) { { platform: 'redhat', version: '6.4' } }
-      it 'should return a RHEL iteration' do
-        expect(project.iteration).to eq('1.el6')
+    describe '#<=>' do
+      it 'compares projects by name' do
+        list = [
+          project,
+          Omnibus::Project.load(project_path('chefdk')),
+        ]
+        expect(list.sort.map(&:name)).to eq(%w(chefdk sample))
       end
     end
 
-    context 'when on Debian' do
-      let(:fauxhai_options) { { platform: 'debian', version: '7.2' } }
-      it 'should return a Debian iteration' do
-        expect(project.iteration).to eq('1')
+    describe '#iteration' do
+      let(:fauxhai_options) { Hash.new }
+
+      before do
+        stub_ohai(Fauxhai.mock(fauxhai_options).data)
       end
-    end
 
-    context 'when on FreeBSD' do
-      let(:fauxhai_options) { { platform: 'freebsd', version: '9.1' } }
-      it 'should return a FreeBSD iteration' do
-        expect(project.iteration).to eq('1.freebsd.9.amd64')
+      context 'when on RHEL' do
+        let(:fauxhai_options) { { platform: 'redhat', version: '6.4' } }
+        it 'should return a RHEL iteration' do
+          expect(project.iteration).to eq('1.el6')
+        end
       end
-    end
 
-    context 'when on Windows' do
-      let(:fauxhai_options) { { platform: 'windows', version: '2008R2' } }
-      it 'should return a Windows iteration' do
-        expect(project.iteration).to eq('1.windows')
+      context 'when on Debian' do
+        let(:fauxhai_options) { { platform: 'debian', version: '7.2' } }
+        it 'should return a Debian iteration' do
+          expect(project.iteration).to eq('1')
+        end
       end
-    end
 
-    context 'when on OS X' do
-      let(:fauxhai_options) { { platform: 'mac_os_x', version: '10.8.2' } }
-      it 'should return a generic iteration' do
-        expect(project.iteration).to eq('1.mac_os_x.10.8.2')
+      context 'when on FreeBSD' do
+        let(:fauxhai_options) { { platform: 'freebsd', version: '9.1' } }
+        it 'should return a FreeBSD iteration' do
+          expect(project.iteration).to eq('1.freebsd.9.amd64')
+        end
       end
-    end
-  end
 
-  describe '#overrides' do
-    let(:project) { Omnibus::Project.load(project_path('chefdk')) }
+      context 'when on Windows' do
+        let(:fauxhai_options) { { platform: 'windows', version: '2008R2' } }
+        before { stub_const('File::ALT_SEPARATOR', '\\') }
+        it 'should return a Windows iteration' do
+          expect(project.iteration).to eq('1.windows')
+        end
+      end
 
-    it 'should set an override for the zlib version' do
-      expect(project.overrides[:zlib][:version]).to eq('1.2.8')
+      context 'when on OS X' do
+        let(:fauxhai_options) { { platform: 'mac_os_x', version: '10.8.2' } }
+        it 'should return a generic iteration' do
+          expect(project.iteration).to eq('1')
+        end
+      end
     end
 
-    it 'should access the zlib version through the #override method as well' do
-      expect(project.override(:zlib)[:version]).to eq('1.2.8')
-    end
+    describe '#overrides' do
+      let(:project) { Omnibus::Project.load(project_path('chefdk')) }
 
-    it 'should set all the things through #overrides' do
-      project.overrides(thing: { version: '6.6.6' })
-      expect(project.override(:zlib)).to be_nil
-    end
+      it 'should set an override for the zlib version' do
+        expect(project.overrides[:zlib][:version]).to eq('1.2.8')
+      end
 
-    it 'should retrieve the things set through #overrides' do
-      project.overrides(thing: { version: '6.6.6' })
-      expect(project.override(:thing)[:version]).to eq('6.6.6')
-    end
+      it 'should access the zlib version through the #override method as well' do
+        expect(project.override(:zlib)[:version]).to eq('1.2.8')
+      end
 
-    it 'should not set other things through setting a single #override' do
-      project.override(:thing, version: '6.6.6')
-      expect(project.override(:zlib)[:version]).to eq('1.2.8')
-    end
+      it 'should set all the things through #overrides' do
+        project.overrides(thing: { version: '6.6.6' })
+        expect(project.override(:zlib)).to be_nil
+      end
 
-    it 'should retrieve the things set through #overrides' do
-      project.override(:thing, version: '6.6.6')
-      expect(project.override(:thing)[:version]).to eq('6.6.6')
+      it 'should retrieve the things set through #overrides' do
+        project.overrides(thing: { version: '6.6.6' })
+        expect(project.override(:thing)[:version]).to eq('6.6.6')
+      end
+
+      it 'should not set other things through setting a single #override' do
+        project.override(:thing, version: '6.6.6')
+        expect(project.override(:zlib)[:version]).to eq('1.2.8')
+      end
+
+      it 'should retrieve the things set through #overrides' do
+        project.override(:thing, version: '6.6.6')
+        expect(project.override(:thing)[:version]).to eq('6.6.6')
+      end
     end
   end
 end

data/spec/unit/s3_cacher_spec.rb

@@ -1,22 +1,4 @@
-#
-# Copyright:: Copyright (c) 2013-2014 Chef Software, Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
 require 'spec_helper'
-require 'omnibus/s3_cacher'
 
 describe Omnibus::S3Cache do
 

data/spec/unit/software_spec.rb

@@ -1,11 +1,8 @@
-require 'omnibus/software'
-
 require 'spec_helper'
 
 describe Omnibus::Software do
-
   let(:project) do
-    double(Omnibus::Project, install_path: 'monkeys', overrides: {})
+    double(Omnibus::Project, install_path: '/monkeys', overrides: {})
   end
 
   let(:software_name) { 'erchef' }
@@ -17,6 +14,65 @@ describe Omnibus::Software do
 
   before do
     allow_any_instance_of(Omnibus::Software).to receive(:render_tasks)
+    stub_ohai(platform: 'linux')
+  end
+
+  describe "path helpers" do
+    before do
+      stub_const("File::PATH_SEPARATOR", separator)
+      ENV.stub(:[]).and_call_original
+      ENV.stub(:[]).with("PATH").and_return(path)
+    end
+
+    context "on *NIX" do
+      let(:separator) { ":" }
+      let(:path) { "/usr/local/bin:/usr/local/sbin:/usr/bin:/bin:/usr/sbin:/sbin" }
+
+      it "prepends a path to PATH" do
+        expect(software.prepend_path("/foo/bar")).to eq("/foo/bar:/usr/local/bin:/usr/local/sbin:/usr/bin:/bin:/usr/sbin:/sbin")
+      end
+
+      it "prepends the embedded bin to PATH" do
+        expect(software.path_with_embedded).to eq("/monkeys/bin:/monkeys/embedded/bin:/usr/local/bin:/usr/local/sbin:/usr/bin:/bin:/usr/sbin:/sbin")
+      end
+
+      it "prepends multiple paths to PATH" do
+        expect(software.prepend_path("/foo/bar", "/foo/baz"))
+          .to eq("/foo/bar:/foo/baz:/usr/local/bin:/usr/local/sbin:/usr/bin:/bin:/usr/sbin:/sbin")
+      end
+    end
+
+    context "on Windows" do
+      before do
+        project.stub(:install_path).and_return("c:/monkeys")
+      end
+
+      let(:separator) { ";" }
+      let(:path) { "c:/Ruby193/bin;c:/Windows/system32;c:/Windows;c:/Windows/System32/Wbem" }
+
+      it "prepends a path to PATH" do
+        expect(software.prepend_path("c:/foo/bar")).to eq("c:/foo/bar;c:/Ruby193/bin;c:/Windows/system32;c:/Windows;c:/Windows/System32/Wbem")
+      end
+
+      it "prepends the embedded bin to PATH" do
+        expect(software.path_with_embedded).to eq("c:/monkeys/bin;c:/monkeys/embedded/bin;c:/Ruby193/bin;c:/Windows/system32;c:/Windows;c:/Windows/System32/Wbem")
+      end
+
+      it "prepends multiple paths to PATH" do
+        expect(software.prepend_path("c:/foo/bar", "c:/foo/baz"))
+          .to eq("c:/foo/bar;c:/foo/baz;c:/Ruby193/bin;c:/Windows/system32;c:/Windows;c:/Windows/System32/Wbem")
+      end
+    end
+  end
+
+  describe '#<=>' do
+    it 'compares projects by name' do
+      list = [
+        Omnibus::Software.load(software_path('zlib'), project),
+        Omnibus::Software.load(software_path('erchef'), project),
+      ]
+      expect(list.sort.map(&:name)).to eq(%w(erchef zlib))
+    end
   end
 
   describe '#whitelist_file' do
@@ -33,6 +89,42 @@ describe Omnibus::Software do
     end
   end
 
+  describe '#override_version' do
+    it 'returns the override version' do
+      software.stub(:overrides).and_return(version: '1.2.3')
+      expect(software.override_version).to eq('1.2.3')
+    end
+
+    it 'outputs a deprecation message' do
+      output = capture_logging { software.override_version }
+      expect(output).to include('DEPRECATED')
+    end
+  end
+
+  describe '#given_version' do
+    it 'returns the version' do
+      software.stub(:default_version).and_return('4.5.6')
+      expect(software.given_version).to eq('4.5.6')
+    end
+
+    it 'outputs a deprecation message' do
+      output = capture_logging { software.given_version }
+      expect(output).to include('DEPRECATED')
+    end
+  end
+
+  describe '#version' do
+    it 'sets the given version' do
+      software.version('1.2.3')
+      expect(software.given_version).to eq('1.2.3')
+    end
+
+    it 'outputs a deprecation message' do
+      output = capture_logging { software.version('1.2.3') }
+      expect(output).to include('DEPRECATED')
+    end
+  end
+
   context 'testing repo-level version overrides' do
     let(:software_name) { 'zlib' }
     let(:default_version) { '1.2.6' }
@@ -58,13 +150,21 @@ describe Omnibus::Software do
         expect(software.override_version).to eq(expected_override_version)
       end
 
-      it 'should have the md5 of the default version' do
+      it 'should have the right source md5' do
         expect(software.source[:md5]).to eq(expected_md5)
       end
 
-      it 'should have the url of the default version' do
+      it 'should have the right source url' do
         expect(software.source[:url]).to eq(expected_url)
       end
+
+      it 'should have the right checksum' do
+        expect(software.checksum).to eq(expected_md5)
+      end
+
+      it 'should have the right source_uri' do
+        expect(software.source_uri).to eq(URI.parse(expected_url))
+      end
     end
 
     context 'without overrides' do
@@ -99,7 +199,53 @@ describe Omnibus::Software do
       let(:expected_url) { 'http://downloads.sourceforge.net/project/libpng/zlib/1.2.8/zlib-1.2.8.tar.gz' }
 
       it_behaves_like 'a software definition'
+
+      context 'with the source overridden' do
+        let(:expected_md5) { '1234567890' }
+        let(:expected_url) { 'http://foo.bar/zlib-1.2.8.tar.gz' }
+        let(:project) do
+          double(Omnibus::Project, install_path: 'monkeys', overrides: { zlib: { version: '1.2.8', source: { url: expected_url, md5: expected_md5 } } })
+        end
+
+        it_behaves_like 'a software definition'
+      end
+    end
+  end
+
+  context 'while getting version_for_cache' do
+    let(:fetcher) { nil }
+    let(:software_name) { 'zlib' }
+    let(:default_version) { '1.2.6' }
+
+    def get_version_for_cache(expected_version)
+      software.stub(:fetcher).and_return(fetcher)
+      expect(software.version_for_cache).to eq(expected_version)
+    end
+
+    context 'without a fetcher' do
+      it 'should return the default version' do
+        get_version_for_cache('1.2.6')
+      end
     end
 
+    context 'with a NetFetcher' do
+      let(:fetcher) { Omnibus::NetFetcher.new(software) }
+
+      it 'should return the default version' do
+        get_version_for_cache('1.2.6')
+      end
+    end
+
+    context 'with a GitFetcher' do
+      let(:fetcher) do
+        a = Omnibus::GitFetcher.new(software)
+        a.stub(:target_revision).and_return('4b19a96d57bff9bbf4764d7323b92a0944009b9e')
+        a
+      end
+
+      it 'should return the git sha' do
+        get_version_for_cache('4b19a96d57bff9bbf4764d7323b92a0944009b9e')
+      end
+    end
   end
 end