ohloh_scm 2.5.1 → 3.0.1

data/spec/ohloh_scm/svn/activity_spec.rb

@@ -0,0 +1,55 @@
+require 'spec_helper'
+require 'mocha'
+
+describe 'Svn::Activity' do
+  describe 'cat' do
+    let(:commit_1) { OhlohScm::Commit.new(token: 1) }
+    let(:hello_diff) { OhlohScm::Diff.new(path: 'helloworld.c') }
+
+    it 'must export data correctly' do
+      with_svn_repository('svn') do |svn|
+        tmpdir do |dir|
+          svn.activity.export(dir)
+          Dir.entries(dir).sort.must_equal %w[. .. branches tags trunk]
+        end
+      end
+    end
+
+    it 'must export tags correctly' do
+      with_svn_repository('svn', 'trunk') do |svn|
+        tmpdir do |svn_working_folder|
+          tmpdir('oh_scm_out_dir_') do |dir|
+            root_path = svn.activity.root
+            folder_name = root_path.slice(/[^\/]+\/?\Z/)
+            cmd = "cd #{svn_working_folder} && svn co #{root_path} && cd #{folder_name}"\
+                  " && mkdir -p #{root_path.gsub(/^file:../, '')}/db/transactions"\
+                  " && svn copy trunk tags/2.0 && svn commit -m 'v2.0' && svn update"
+            svn.activity.send :run, cmd
+
+            svn.activity.export_tag(dir, '2.0')
+
+            Dir.entries(dir).sort.must_equal %w[. .. COPYING README helloworld.c makefile]
+          end
+        end
+      end
+    end
+
+    it 'must get tags correctly' do
+      with_svn_repository('svn', 'trunk') do |svn|
+        tmpdir do |svn_working_folder|
+          root_path = svn.activity.root
+          folder_name = root_path.slice(/[^\/]+\/?\Z/)
+          cmd = "cd #{svn_working_folder} && svn co #{root_path} && cd #{folder_name}"\
+                " && mkdir -p #{root_path.gsub(/^file:../, '')}/db/transactions"\
+                " && svn copy trunk tags/2.0 && svn commit -m 'v2.0' && svn update"
+          svn.activity.send :run, cmd
+
+          svn.activity.tags.first[0..1].must_equal ['2.0', '6']
+          # Avoid millisecond comparision.
+          svn.activity.tags.first[-1].strftime('%F %R')
+             .must_equal Time.now.utc.strftime('%F %R')
+        end
+      end
+    end
+  end
+end

data/spec/ohloh_scm/svn/scm_spec.rb

@@ -0,0 +1,75 @@
+require 'spec_helper'
+
+describe 'Svn::Scm' do
+  it 'must prefix file: to local path' do
+    get_core(:svn, url: '').scm.send(:prefix_file_for_local_path, '').must_be_nil
+    get_core(:svn, url: '/home/test').scm.send(:prefix_file_for_local_path, '/home/test')
+                                     .must_equal 'file:///home/test'
+  end
+
+  it 'must require https for sourceforge' do
+    OhlohScm::Svn::Scm.any_instance.stubs(:recalc_branch_name)
+
+    url = '://svn.code.sf.net/p/gallery/code/trunk/gallery2'
+    get_core(:svn, url: "http#{url}").scm.normalize.url.must_equal "https#{url}"
+    get_core(:svn, url: "https#{url}").scm.normalize.url.must_equal "https#{url}"
+
+    url = 'https://github.com/blackducksw/ohloh_scm/trunk'
+    get_core(:svn, url: url).scm.normalize.url.must_equal url
+  end
+
+  it 'must recalc branch name' do
+    with_svn_repository('svn') do |svn_core|
+      svn_scm = get_core(:svn, url: svn_core.scm.url, branch_name: '').scm
+      svn_scm.branch_name.must_be_nil
+      svn_scm.send(:recalc_branch_name).must_be_empty
+      svn_scm.branch_name.must_be_empty
+
+      svn_scm = get_core(:svn, url: svn_core.scm.url, branch_name: '/').scm
+      svn_scm.send(:recalc_branch_name).must_be_empty
+      svn_scm.branch_name.must_be_empty
+
+      svn_scm = get_core(:svn, url: svn_core.scm.url + '/trunk').scm
+      OhlohScm::Svn::Activity.any_instance.stubs(:root).returns(svn_core.scm.url)
+      svn_scm.send(:recalc_branch_name)
+      svn_scm.branch_name.must_equal '/trunk'
+
+      svn_scm = get_core(:svn, url: svn_core.scm.url + '/trunk', branch_name: nil).scm
+      OhlohScm::Svn::Activity.any_instance.stubs(:root).returns(svn_core.scm.url)
+      svn_scm.normalize.branch_name.must_equal '/trunk'
+    end
+  end
+
+  describe 'restrict_url_to_trunk' do
+    it 'must return url when url ends with trunk' do
+      svn_scm = get_core(:svn, url: 'svn:foobar/trunk').scm
+      svn_scm.restrict_url_to_trunk.must_equal svn_scm.url
+    end
+
+    it 'must append trunk to url and set branch_name when trunk folder is present' do
+      with_svn_repository('svn') do |svn_core|
+        scm = svn_core.scm
+        scm.url.must_equal svn_core.activity.root
+        scm.branch_name.must_be_nil
+
+        scm.restrict_url_to_trunk
+
+        scm.url.must_equal svn_core.activity.root + '/trunk'
+        scm.branch_name.must_equal '/trunk'
+      end
+    end
+
+    it 'must update url and branch_name when repo has a single subfolder' do
+      with_svn_repository('svn_subdir') do |svn_core|
+        scm = svn_core.scm
+        scm.url.must_equal svn_core.activity.root
+        scm.branch_name.must_be_nil
+
+        scm.restrict_url_to_trunk
+
+        scm.url.must_equal svn_core.activity.root + '/subdir/trunk'
+        scm.branch_name.must_equal '/subdir/trunk'
+      end
+    end
+  end
+end

data/spec/ohloh_scm/svn/validation_spec.rb

@@ -0,0 +1,89 @@
+require 'spec_helper'
+
+describe 'Svn::Status' do
+  it 'should validate usernames' do
+    [nil, '', 'joe_36', 'a' * 32, 'robin@ohloh.net'].each do |username|
+      assert !get_core(:svn, username: username).validation.send(:username_errors)
+    end
+  end
+
+  it 'should validate rejected urls' do
+    [nil, '', 'foo', 'http:/', 'http:://', 'http://',
+     'sourceforge.net/svn/project/trunk', # missing a protocol prefix
+     'http://robin@svn.sourceforge.net/', # must not include a username with the url
+     '/home/robin/cvs', # local file paths not allowed
+     'git://kernel.org/whatever/linux.git', # git protocol is not allowed
+     ':pserver:anonymous:@juicereceiver.cvs.sourceforge.net:/cvsroot/juicereceiver', # pserver is just wrong
+     'svn://svn.gajim.org:/gajim/trunk', # invalid port number
+     'svn://svn.gajim.org:abc/gajim/trunk', # invalid port number
+     'svn log https://svn.sourceforge.net/svnroot/myserver/trunk'].each do |url|
+      # Rejected for both internal and public use
+      assert get_core(:svn, url: url).validation.send(:url_errors)
+    end
+  end
+
+  it 'should validate urls' do
+    [
+      'https://svn.sourceforge.net/svnroot/opende/trunk', # https protocol OK
+      'svn://svn.gajim.org/gajim/trunk', # svn protocol OK
+      'http://svn.mythtv.org/svn/trunk/mythtv', # http protocol OK
+      'https://svn.sourceforge.net/svnroot/vienna-rss/trunk/2.0.0', # periods, numbers and dashes OK
+      'svn://svn.gajim.org:3690/gajim/trunk', # port number OK
+      'http://svn.mythtv.org:80/svn/trunk/mythtv', # port number OK
+      'http://svn.gnome.org/svn/gtk+/trunk', # + character OK
+      'http://svn.gnome.org', # no path, no trailing /, just a domain name is OK
+      'http://brlcad.svn.sourceforge.net/svnroot/brlcad/rt^3/trunk', # a caret ^ is allowed
+      'http://www.thus.ch/~patrick/svn/pvalsecc', # ~ is allowed
+      'http://franklinmath.googlecode.com/svn/trunk/Franklin Math' # space is allowed in path
+    ].each do |url|
+      # Accepted for both internal and public use
+      assert !get_core(:svn, url: url).validation.send(:url_errors)
+    end
+  end
+
+  # These urls are not available to the public
+  it 'should reject public urls' do
+    ['file:///home/robin/svn'].each do |url|
+      assert get_core(:svn, url: url).validation.send(:url_errors)
+    end
+  end
+
+  it 'should validate_server_connection' do
+    with_svn_repository('svn') do |svn|
+      svn.validation.send(:validate_server_connection)
+      svn.validation.errors.must_be :empty?
+    end
+  end
+
+  it 'should strip trailing whitespace in branch_name' do
+    get_core(:svn, branch_name: '/trunk/').scm.normalize.branch_name.must_equal '/trunk'
+  end
+
+  it 'should catch exception when validating server connection' do
+    git_svn = get_core(:svn)
+    git_svn.validation.instance_variable_set('@errors', nil)
+    git_svn.validation.send :validate_server_connection
+    msg = 'An error occured connecting to the server. Check the URL, username, and password.'
+    git_svn.validation.errors.must_equal [[:failed, msg]]
+  end
+
+  it 'should validate head token when validating server connection' do
+    git_svn = get_core(:svn)
+    git_svn.validation.instance_variable_set('@errors', nil)
+    OhlohScm::Svn::Activity.any_instance.stubs(:head_token).returns(nil)
+    git_svn.validation.expects(:url_error)
+    git_svn.validation.send :validate_server_connection
+    msg = "The server did not respond to a 'svn info' command. Is the URL correct?"
+    git_svn.validation.errors.must_equal [[:failed, msg]]
+  end
+
+  it 'should validate url when validating server connection' do
+    git_svn = get_core(:svn)
+    git_svn.validation.instance_variable_set('@errors', nil)
+    OhlohScm::Svn::Activity.any_instance.stubs(:head_token).returns('')
+    OhlohScm::Svn::Activity.any_instance.stubs(:root).returns('tt')
+    git_svn.validation.send :validate_server_connection
+    git_svn.validation.errors
+           .must_equal [[:failed, 'The URL did not match the Subversion root tt. Is the URL correct?']]
+  end
+end

data/spec/ohloh_scm/svn_parser_spec.rb

@@ -0,0 +1,146 @@
+require 'spec_helper'
+
+DATA_DIR = File.expand_path(File.join(File.dirname(__FILE__), '../raw_fixtures'))
+
+describe 'SvnParser' do
+  it 'test_empty_array' do
+    OhlohScm::SvnParser.parse('').must_be :empty?
+  end
+
+  it 'test_yield_instead_of_writer' do
+    commits = []
+    result = OhlohScm::SvnParser.parse(File.read(DATA_DIR + '/simple.svn_log')) do |commit|
+      commits << commit.token
+    end
+    result.must_be_nil
+    commits.must_equal [5, 4, 3, 2, 1]
+  end
+
+  it 'test_log_parser' do
+    sample_log = <<~SAMPLE
+      ------------------------------------------------------------------------
+      r1 | robin | 2006-06-11 11:28:00 -0700 (Sun, 11 Jun 2006) | 2 lines
+
+      Initial Checkin
+
+      ------------------------------------------------------------------------
+      r2 | jason | 2006-06-11 11:32:13 -0700 (Sun, 11 Jun 2006) | 1 line
+
+      added makefile
+      ------------------------------------------------------------------------
+      r3 | robin | 2006-06-11 11:34:17 -0700 (Sun, 11 Jun 2006) | 1 line
+
+      added some documentation and licensing info
+      ------------------------------------------------------------------------
+    SAMPLE
+
+    revs = OhlohScm::SvnParser.parse(sample_log)
+
+    assert revs
+    revs.size.must_equal 3
+
+    revs[0].token.must_equal 1
+    revs[0].committer_name.must_equal 'robin'
+    revs[0].message.must_equal "Initial Checkin\n" # Note \n at end of comment
+    revs[0].committer_date.must_equal Time.utc(2006, 6, 11, 18, 28, 0o0)
+
+    revs[1].token.must_equal 2
+    revs[1].committer_name.must_equal 'jason'
+    revs[1].message.must_equal 'added makefile' # Note no \n at end of comment
+    revs[1].committer_date.must_equal Time.utc(2006, 6, 11, 18, 32, 13)
+
+    revs[2].token.must_equal 3
+    revs[2].committer_name.must_equal 'robin'
+    revs[2].message.must_equal 'added some documentation and licensing info'
+    revs[2].committer_date.must_equal Time.utc(2006, 6, 11, 18, 34, 17)
+  end
+
+  # This is an excerpt from the log for Wireshark. It includes Subversion log excerpts in
+  # its comments, which really screwed us up. This test confirms that I've fixed the
+  # parser to ignore log excerpts in the comments.
+  it 'test_log_embedded_in_comments' do
+    log = <<~LOG
+      ------------------------------------------------------------------------
+      r21932 | jmayer | 2007-05-25 01:34:15 -0700 (Fri, 25 May 2007) | 22 lines
+
+      Update from samba tree revision 23054 to 23135
+      ============================ Samba log start ============
+      ------------------------------------------------------------------------
+      r23069 | metze | 2007-05-22 13:23:36 +0200 (Tue, 22 May 2007) | 3 lines
+      Changed paths:
+         M /branches/SAMBA_4_0/source/pidl/tests/Util.pm
+
+       print out the command, to find out the problem on host 'tridge'
+
+       metze
+      ------------------------------------------------------------------------
+      r23071 | metze | 2007-05-22 14:45:58 +0200 (Tue, 22 May 2007) | 3 lines
+      Changed paths:
+         M /branches/SAMBA_4_0/source/pidl/tests/Util.pm
+
+       print the command on failure only
+
+       metze
+      ------------------------------------------------------------------------
+      ------------------------------------------------------------------------
+      ============================ Samba log end ==============
+
+       ------------------------------------------------------------------------
+      r21931 | kukosa | 2007-05-24 23:54:39 -0700 (Thu, 24 May 2007) | 2 lines
+
+       UMTS RRC updated to 3GPP TS 25.331 V7.4.0 (2007-03) and moved to one directory
+
+       ------------------------------------------------------------------------
+    LOG
+    revs = OhlohScm::SvnParser.parse(log)
+
+    assert revs
+    revs.size.must_equal 2
+
+    revs[0].token.must_equal 21_932
+    revs[1].token.must_equal 21_931
+
+    comment = <<~COMMENT
+      Update from samba tree revision 23054 to 23135
+      ============================ Samba log start ============
+      ------------------------------------------------------------------------
+      r23069 | metze | 2007-05-22 13:23:36 +0200 (Tue, 22 May 2007) | 3 lines
+      Changed paths:
+         M /branches/SAMBA_4_0/source/pidl/tests/Util.pm
+
+       print out the command, to find out the problem on host 'tridge'
+
+       metze
+      ------------------------------------------------------------------------
+      r23071 | metze | 2007-05-22 14:45:58 +0200 (Tue, 22 May 2007) | 3 lines
+      Changed paths:
+         M /branches/SAMBA_4_0/source/pidl/tests/Util.pm
+
+       print the command on failure only
+
+       metze
+      ------------------------------------------------------------------------
+      ------------------------------------------------------------------------
+      ============================ Samba log end ==============
+    COMMENT
+    revs[0].message.must_equal comment
+  end
+
+  it 'test_svn_copy' do
+    log = <<~LOG
+      ------------------------------------------------------------------------
+      r8 | robin | 2009-02-05 05:40:46 -0800 (Thu, 05 Feb 2009) | 1 line
+      Changed paths:
+         A /trunk (from /branches/development:7)
+
+      the branch becomes the new trunk
+    LOG
+
+    commits = OhlohScm::SvnParser.parse(log)
+    commits.size.must_equal 1
+    commits.first.diffs.size.must_equal 1
+    commits.first.diffs.first.path.must_equal '/trunk'
+    commits.first.diffs.first.from_path.must_equal '/branches/development'
+    commits.first.diffs.first.from_revision.must_equal 7
+  end
+end

data/spec/ohloh_scm/system_spec.rb

@@ -0,0 +1,32 @@
+require 'spec_helper'
+
+describe 'System' do
+  describe 'run' do
+    it 'must run a command succesfully' do
+      run_p('ls /tmp')
+    end
+
+    it 'must raise an exception when command fails' do
+      -> { run_p('ls /tmp/foobartest') }.must_raise(Exception)
+    end
+  end
+
+  describe 'run_with_error' do
+    it 'must provide error and exitstatus' do
+      cmd = %q(ruby -e"  t = 'Hello World'; STDOUT.puts t; STDERR.puts t  ")
+      stdout, stderr, status = run_with_error_p(cmd)
+      status.exitstatus.must_equal 0
+      stdout.must_equal "Hello World\n"
+      stderr.must_equal "Hello World\n"
+    end
+  end
+
+  describe 'logger' do
+    it 'must allow setting logger level' do
+      level = (1..5).to_a.sample
+      OhlohScm::System.logger.level = level
+      core = OhlohScm::Factory.get_core(scm_type: :git, url: 'foo')
+      core.scm.send(:logger).level.must_equal level
+    end
+  end
+end

data/spec/ohloh_scm/version_spec.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe 'Version' do
+  it 'must return the version string' do
+    OhlohScm::Version::STRING.must_be_instance_of String
+  end
+end

data/{test/data → spec/raw_fixtures}/simple.ohlog

@@ -1,5 +1,5 @@
 <?xml version="1.0"?>
-<ohloh_log scm="svn">
+<ohloh_log>
     <commit token="5">
         <committer name="jason" date="2006-07-14T23:07:15Z" />
         <message>moving COPYING</message>