ohai 8.10.0 → 8.11.1

data/spec/unit/plugins/windows/memory_spec.rb

@@ -14,19 +14,19 @@
 # limitations under the License.
 #
 
-require File.expand_path(File.dirname(__FILE__) + '/../../../spec_helper.rb')
+require File.expand_path(File.dirname(__FILE__) + "/../../../spec_helper.rb")
 
 describe Ohai::System, "Windows memory plugin", :windows_only do
   before do
     require "wmi-lite/wmi"
     @plugin = get_plugin("windows/memory")
-    mock_os = { 
+    mock_os = {
                 "TotalVisibleMemorySize" => "10485760",
                 "FreePhysicalMemory" => "5242880",
                 "SizeStoredInPagingFiles" => "20971520",
-                "FreeSpaceInPagingFiles" =>  "15728640"
+                "FreeSpaceInPagingFiles" =>  "15728640",
               }
-    expect_any_instance_of(WmiLite::Wmi).to receive(:first_of).with('Win32_OperatingSystem').and_return(mock_os)
+    expect_any_instance_of(WmiLite::Wmi).to receive(:first_of).with("Win32_OperatingSystem").and_return(mock_os)
   end
 
   it "should get total memory" do
@@ -49,4 +49,4 @@ describe Ohai::System, "Windows memory plugin", :windows_only do
     expect(@plugin["memory"]["swap"]["free"]).to eql("15728640kB")
   end
 
-end
+end

data/spec/unit/plugins/windows/virtualization_spec.rb

@@ -18,197 +18,197 @@
 # limitations under the License.
 #
 
-require File.expand_path(File.dirname(__FILE__) + '/../../../spec_helper.rb')
+require File.expand_path(File.dirname(__FILE__) + "/../../../spec_helper.rb")
 
-describe Ohai::System, 'Windows virtualization platform' do
-  let(:plugin) { get_plugin('windows/virtualization') }
+describe Ohai::System, "Windows virtualization platform" do
+  let(:plugin) { get_plugin("windows/virtualization") }
 
   before(:each) do
     allow(plugin).to receive(:collect_os).and_return(:windows)
   end
 
-  context 'when running on vmware' do
-    it 'system is vmware' do
-      allow_any_instance_of(WmiLite::Wmi).to receive(:instances_of).with('Win32_BIOS').and_return([{ 'bioscharacteristics' => [4, 7, 8, 9, 10, 11, 12, 14, 15, 16, 19, 26, 27, 28, 29, 30, 32, 39, 40, 41, 42, 50, 57, 58],
-                                                                                                     'biosversion' => ['INTEL  - 6040000', 'PhoenixBIOS 4.0 Release 6.0     '],
-                                                                                                     'buildnumber' => nil,
-                                                                                                     'caption' => 'PhoenixBIOS 4.0 Release 6.0     ',
-                                                                                                     'codeset' => nil, 'currentlanguage' => nil,
-                                                                                                     'description' => 'PhoenixBIOS 4.0 Release 6.0     ',
-                                                                                                     'identificationcode' => nil,
-                                                                                                     'installablelanguages' => nil,
-                                                                                                     'installdate' => nil,
-                                                                                                     'languageedition' => nil,
-                                                                                                     'listoflanguages' => nil,
-                                                                                                     'manufacturer' => 'Phoenix Technologies LTD',
-                                                                                                     'name' => 'PhoenixBIOS 4.0 Release 6.0     ',
-                                                                                                     'othertargetos' => nil,
-                                                                                                     'primarybios' => true,
-                                                                                                     'releasedate' => '20130731000000.000000+000',
-                                                                                                     'serialnumber' => 'VMware-56 4d 65 24 ac cf ec 72-fa 29 b2 7d 8f df b2 7a',
-                                                                                                     'smbiosbiosversion' => '6.00',
-                                                                                                     'smbiosmajorversion' => 2,
-                                                                                                     'smbiosminorversion' => 4,
-                                                                                                     'smbiospresent' => true,
-                                                                                                     'softwareelementid' => 'PhoenixBIOS 4.0 Release 6.0     ',
-                                                                                                     'softwareelementstate' => 3,
-                                                                                                     'status' => 'OK',
-                                                                                                     'targetoperatingsystem' => 0,
-                                                                                                     'version' => 'INTEL  - 6040000'
+  context "when running on vmware" do
+    it "system is vmware" do
+      allow_any_instance_of(WmiLite::Wmi).to receive(:instances_of).with("Win32_BIOS").and_return([{ "bioscharacteristics" => [4, 7, 8, 9, 10, 11, 12, 14, 15, 16, 19, 26, 27, 28, 29, 30, 32, 39, 40, 41, 42, 50, 57, 58],
+                                                                                                     "biosversion" => ["INTEL  - 6040000", "PhoenixBIOS 4.0 Release 6.0     "],
+                                                                                                     "buildnumber" => nil,
+                                                                                                     "caption" => "PhoenixBIOS 4.0 Release 6.0     ",
+                                                                                                     "codeset" => nil, "currentlanguage" => nil,
+                                                                                                     "description" => "PhoenixBIOS 4.0 Release 6.0     ",
+                                                                                                     "identificationcode" => nil,
+                                                                                                     "installablelanguages" => nil,
+                                                                                                     "installdate" => nil,
+                                                                                                     "languageedition" => nil,
+                                                                                                     "listoflanguages" => nil,
+                                                                                                     "manufacturer" => "Phoenix Technologies LTD",
+                                                                                                     "name" => "PhoenixBIOS 4.0 Release 6.0     ",
+                                                                                                     "othertargetos" => nil,
+                                                                                                     "primarybios" => true,
+                                                                                                     "releasedate" => "20130731000000.000000+000",
+                                                                                                     "serialnumber" => "VMware-56 4d 65 24 ac cf ec 72-fa 29 b2 7d 8f df b2 7a",
+                                                                                                     "smbiosbiosversion" => "6.00",
+                                                                                                     "smbiosmajorversion" => 2,
+                                                                                                     "smbiosminorversion" => 4,
+                                                                                                     "smbiospresent" => true,
+                                                                                                     "softwareelementid" => "PhoenixBIOS 4.0 Release 6.0     ",
+                                                                                                     "softwareelementstate" => 3,
+                                                                                                     "status" => "OK",
+                                                                                                     "targetoperatingsystem" => 0,
+                                                                                                     "version" => "INTEL  - 6040000"
          }])
       plugin.run
-      expect(plugin[:virtualization][:system]).to eq('vmware')
-      expect(plugin[:virtualization][:role]).to eq('guest')
-      expect(plugin[:virtualization][:systems][:vmware]).to eq('guest')
+      expect(plugin[:virtualization][:system]).to eq("vmware")
+      expect(plugin[:virtualization][:role]).to eq("guest")
+      expect(plugin[:virtualization][:systems][:vmware]).to eq("guest")
     end
   end
 
-  context 'when running on parallels desktop' do
-    it 'system is parallels' do
-      allow_any_instance_of(WmiLite::Wmi).to receive(:instances_of).with('Win32_BIOS').and_return([{ 'bioscharacteristics' => [4, 7, 9, 10, 15, 24, 25, 27, 28, 29, 30, 32, 42, 44, 48, 49, 51, 64, 65, 67],
-                                                                                                     'biosversion' => ['PRLS   - 1'],
-                                                                                                     'buildnumber' => nil,
-                                                                                                     'caption' => 'Default System BIOS',
-                                                                                                     'codeset' => nil,
-                                                                                                     'currentlanguage' => nil,
-                                                                                                     'description' => 'Default System BIOS',
-                                                                                                     'identificationcode' => nil,
-                                                                                                     'installablelanguages' => nil,
-                                                                                                     'installdate' => nil,
-                                                                                                     'languageedition' => nil,
-                                                                                                     'listoflanguages' => nil,
-                                                                                                     'manufacturer' => 'Parallels Software International Inc.',
-                                                                                                     'name' => 'Default System BIOS',
-                                                                                                     'othertargetos' => nil,
-                                                                                                     'primarybios' => true,
-                                                                                                     'releasedate' => '20151005000000.000000+000',
-                                                                                                     'serialnumber' =>      'Parallels-82 75 A0 A0 9B B4 47 7C 87 A9 D9 E1 2B 90 4B 1F',
-                                                                                                     'smbiosbiosversion' => '11.0.2 (31348)',
-                                                                                                     'smbiosmajorversion' => 2,
-                                                                                                     'smbiosminorversion' => 7,
-                                                                                                     'smbiospresent' => true,
-                                                                                                     'softwareelementid' => 'Default System BIOS',
-                                                                                                     'softwareelementstate' => 3,
-                                                                                                     'status' => 'OK',
-                                                                                                     'targetoperatingsystem' => 0,
-                                                                                                     'version' => 'PRLS   - 1'
+  context "when running on parallels desktop" do
+    it "system is parallels" do
+      allow_any_instance_of(WmiLite::Wmi).to receive(:instances_of).with("Win32_BIOS").and_return([{ "bioscharacteristics" => [4, 7, 9, 10, 15, 24, 25, 27, 28, 29, 30, 32, 42, 44, 48, 49, 51, 64, 65, 67],
+                                                                                                     "biosversion" => ["PRLS   - 1"],
+                                                                                                     "buildnumber" => nil,
+                                                                                                     "caption" => "Default System BIOS",
+                                                                                                     "codeset" => nil,
+                                                                                                     "currentlanguage" => nil,
+                                                                                                     "description" => "Default System BIOS",
+                                                                                                     "identificationcode" => nil,
+                                                                                                     "installablelanguages" => nil,
+                                                                                                     "installdate" => nil,
+                                                                                                     "languageedition" => nil,
+                                                                                                     "listoflanguages" => nil,
+                                                                                                     "manufacturer" => "Parallels Software International Inc.",
+                                                                                                     "name" => "Default System BIOS",
+                                                                                                     "othertargetos" => nil,
+                                                                                                     "primarybios" => true,
+                                                                                                     "releasedate" => "20151005000000.000000+000",
+                                                                                                     "serialnumber" =>      "Parallels-82 75 A0 A0 9B B4 47 7C 87 A9 D9 E1 2B 90 4B 1F",
+                                                                                                     "smbiosbiosversion" => "11.0.2 (31348)",
+                                                                                                     "smbiosmajorversion" => 2,
+                                                                                                     "smbiosminorversion" => 7,
+                                                                                                     "smbiospresent" => true,
+                                                                                                     "softwareelementid" => "Default System BIOS",
+                                                                                                     "softwareelementstate" => 3,
+                                                                                                     "status" => "OK",
+                                                                                                     "targetoperatingsystem" => 0,
+                                                                                                     "version" => "PRLS   - 1",
          }])
       plugin.run
-      expect(plugin[:virtualization][:system]).to eq('parallels')
-      expect(plugin[:virtualization][:role]).to eq('guest')
-      expect(plugin[:virtualization][:systems][:parallels]).to eq('guest')
+      expect(plugin[:virtualization][:system]).to eq("parallels")
+      expect(plugin[:virtualization][:role]).to eq("guest")
+      expect(plugin[:virtualization][:systems][:parallels]).to eq("guest")
     end
   end
 
-  context 'when running on kvm' do
-    it 'system is kvm' do
-      allow_any_instance_of(WmiLite::Wmi).to receive(:instances_of).with('Win32_BIOS').and_return([{ 'bioscharacteristics' => [3, 42, 48, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79],
-                                                                                                     'biosversion' => ['BOCHS  - 1'],
-                                                                                                     'buildnumber' => nil,
-                                                                                                     'caption' => 'Default System BIOS',
-                                                                                                     'codeset' => nil,
-                                                                                                     'currentlanguage' => nil,
-                                                                                                     'description' => 'Default System BIOS',
-                                                                                                     'identificationcode' => nil,
-                                                                                                     'installablelanguages' => nil,
-                                                                                                     'installdate' => nil,
-                                                                                                     'languageedition' => nil,
-                                                                                                     'listoflanguages' => nil,
-                                                                                                     'manufacturer' => 'Bochs',
-                                                                                                     'name' => 'Default System BIOS',
-                                                                                                     'othertargetos' => nil,
-                                                                                                     'primarybios' => true,
-                                                                                                     'releasedate' => '20110101******.******+***',
-                                                                                                     'serialnumber' => nil,
-                                                                                                     'smbiosbiosversion' => 'Bochs',
-                                                                                                     'smbiosmajorversion' => 2,
-                                                                                                     'smbiosminorversion' => 4,
-                                                                                                     'smbiospresent' => true,
-                                                                                                     'softwareelementid' => 'Default System BIOS',
-                                                                                                     'softwareelementstate' => 3,
-                                                                                                     'status' => 'OK',
-                                                                                                     'targetoperatingsystem' => 0, 'version' => 'BOCHS  -1'
+  context "when running on kvm" do
+    it "system is kvm" do
+      allow_any_instance_of(WmiLite::Wmi).to receive(:instances_of).with("Win32_BIOS").and_return([{ "bioscharacteristics" => [3, 42, 48, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79],
+                                                                                                     "biosversion" => ["BOCHS  - 1"],
+                                                                                                     "buildnumber" => nil,
+                                                                                                     "caption" => "Default System BIOS",
+                                                                                                     "codeset" => nil,
+                                                                                                     "currentlanguage" => nil,
+                                                                                                     "description" => "Default System BIOS",
+                                                                                                     "identificationcode" => nil,
+                                                                                                     "installablelanguages" => nil,
+                                                                                                     "installdate" => nil,
+                                                                                                     "languageedition" => nil,
+                                                                                                     "listoflanguages" => nil,
+                                                                                                     "manufacturer" => "Bochs",
+                                                                                                     "name" => "Default System BIOS",
+                                                                                                     "othertargetos" => nil,
+                                                                                                     "primarybios" => true,
+                                                                                                     "releasedate" => "20110101******.******+***",
+                                                                                                     "serialnumber" => nil,
+                                                                                                     "smbiosbiosversion" => "Bochs",
+                                                                                                     "smbiosmajorversion" => 2,
+                                                                                                     "smbiosminorversion" => 4,
+                                                                                                     "smbiospresent" => true,
+                                                                                                     "softwareelementid" => "Default System BIOS",
+                                                                                                     "softwareelementstate" => 3,
+                                                                                                     "status" => "OK",
+                                                                                                     "targetoperatingsystem" => 0, "version" => "BOCHS  -1"
           }])
       plugin.run
-      expect(plugin[:virtualization][:system]).to eq('kvm')
-      expect(plugin[:virtualization][:role]).to eq('guest')
-      expect(plugin[:virtualization][:systems][:kvm]).to eq('guest')
+      expect(plugin[:virtualization][:system]).to eq("kvm")
+      expect(plugin[:virtualization][:role]).to eq("guest")
+      expect(plugin[:virtualization][:systems][:kvm]).to eq("guest")
     end
   end
 
-  context 'when running on virtualbox' do
-    it 'system is vbox' do
-      allow_any_instance_of(WmiLite::Wmi).to receive(:instances_of).with('Win32_BIOS').and_return([{ 'bioscharacteristics' => [4, 7, 15, 16, 27, 30, 32],
-                                                                                                     'biosversion' => ['VBOX   - 1'],
-                                                                                                     'buildnumber' => nil,
-                                                                                                     'caption' => 'Default System BIOS',
-                                                                                                     'codeset' => nil,
-                                                                                                     'currentlanguage' => nil,
-                                                                                                     'description' => 'Default System BIOS',
-                                                                                                     'identificationcode' => nil,
-                                                                                                     'installablelanguages' => nil,
-                                                                                                     'installdate' => nil,
-                                                                                                     'languageedition' => nil,
-                                                                                                     'listoflanguages' => nil,
-                                                                                                     'manufacturer' => 'innotek GmbH',
-                                                                                                     'name' => 'Default System BIOS',
-                                                                                                     'othertargetos' => nil,
-                                                                                                     'primarybios' => true,
-                                                                                                     'releasedate' => '20061201000000.000000+000',
-                                                                                                     'serialnumber' => '0',
-                                                                                                     'smbiosbiosversion' => 'VirtualBox',
-                                                                                                     'smbiosmajorversion' => 2,
-                                                                                                     'smbiosminorversion' => 5,
-                                                                                                     'smbiospresent' => true,
-                                                                                                     'softwareelementid' => 'Default System BIOS',
-                                                                                                     'softwareelementstate' => 3,
-                                                                                                     'status' => 'OK',
-                                                                                                     'targetoperatingsystem' => 0,
-                                                                                                     'version' => 'VBOX   - 1'
+  context "when running on virtualbox" do
+    it "system is vbox" do
+      allow_any_instance_of(WmiLite::Wmi).to receive(:instances_of).with("Win32_BIOS").and_return([{ "bioscharacteristics" => [4, 7, 15, 16, 27, 30, 32],
+                                                                                                     "biosversion" => ["VBOX   - 1"],
+                                                                                                     "buildnumber" => nil,
+                                                                                                     "caption" => "Default System BIOS",
+                                                                                                     "codeset" => nil,
+                                                                                                     "currentlanguage" => nil,
+                                                                                                     "description" => "Default System BIOS",
+                                                                                                     "identificationcode" => nil,
+                                                                                                     "installablelanguages" => nil,
+                                                                                                     "installdate" => nil,
+                                                                                                     "languageedition" => nil,
+                                                                                                     "listoflanguages" => nil,
+                                                                                                     "manufacturer" => "innotek GmbH",
+                                                                                                     "name" => "Default System BIOS",
+                                                                                                     "othertargetos" => nil,
+                                                                                                     "primarybios" => true,
+                                                                                                     "releasedate" => "20061201000000.000000+000",
+                                                                                                     "serialnumber" => "0",
+                                                                                                     "smbiosbiosversion" => "VirtualBox",
+                                                                                                     "smbiosmajorversion" => 2,
+                                                                                                     "smbiosminorversion" => 5,
+                                                                                                     "smbiospresent" => true,
+                                                                                                     "softwareelementid" => "Default System BIOS",
+                                                                                                     "softwareelementstate" => 3,
+                                                                                                     "status" => "OK",
+                                                                                                     "targetoperatingsystem" => 0,
+                                                                                                     "version" => "VBOX   - 1",
         }])
       plugin.run
-      expect(plugin[:virtualization][:system]).to eq('vbox')
-      expect(plugin[:virtualization][:role]).to eq('guest')
-      expect(plugin[:virtualization][:systems][:vbox]).to eq('guest')
+      expect(plugin[:virtualization][:system]).to eq("vbox")
+      expect(plugin[:virtualization][:role]).to eq("guest")
+      expect(plugin[:virtualization][:systems][:vbox]).to eq("guest")
     end
   end
 
-  context 'when running on a hardware system' do
-    it 'does not set virtualization attributes' do
-      allow_any_instance_of(WmiLite::Wmi).to receive(:instances_of).with('Win32_BIOS').and_return([{ 'bioscharacteristics' => [7, 11, 12, 15, 16, 17, 19, 23, 24, 25, 26, 27, 28, 29, 32, 33, 40, 42, 43],
-                                                                                                     'biosversion' => ['DELL   - 1072009', 'A10', 'American Megatrends - 4028D'],
-                                                                                                     'buildnumber' => nil,
-                                                                                                     'caption' => 'A10',
-                                                                                                     'codeset' => nil,
-                                                                                                     'currentlanguage' => nil,
-                                                                                                     'description' => 'A10',
-                                                                                                     'embeddedcontrollermajorversion' => 255,
-                                                                                                     'embeddedcontrollerminorversion' => 255,
-                                                                                                     'identificationcode' => nil,
-                                                                                                     'installablelanguages' => nil,
-                                                                                                     'installdate' => nil,
-                                                                                                     'languageedition' => nil,
-                                                                                                     'listoflanguages' => nil,
-                                                                                                     'manufacturer' => 'Dell Inc.',
-                                                                                                     'name' => 'A10',
-                                                                                                     'othertargetos' => nil,
-                                                                                                     'primarybios' => true,
-                                                                                                     'releasedate' => '20130513000000.000000+000',
-                                                                                                     'serialnumber' => '87GBNY1',
-                                                                                                     'smbiosbiosversion' => 'A10',
-                                                                                                     'smbiosmajorversion' => 2,
-                                                                                                     'smbiosminorversion' => 7,
-                                                                                                     'smbiospresent' => true,
-                                                                                                     'softwareelementid' => 'A10',
-                                                                                                     'softwareelementstate' => 3,
-                                                                                                     'status' => 'OK',
-                                                                                                     'systembiosmajorversion' => 4,
-                                                                                                     'systembiosminorversion' => 6,
-                                                                                                     'targetoperatingsystem' => 0,
-                                                                                                     'version' => 'DELL   - 1072009'
+  context "when running on a hardware system" do
+    it "does not set virtualization attributes" do
+      allow_any_instance_of(WmiLite::Wmi).to receive(:instances_of).with("Win32_BIOS").and_return([{ "bioscharacteristics" => [7, 11, 12, 15, 16, 17, 19, 23, 24, 25, 26, 27, 28, 29, 32, 33, 40, 42, 43],
+                                                                                                     "biosversion" => ["DELL   - 1072009", "A10", "American Megatrends - 4028D"],
+                                                                                                     "buildnumber" => nil,
+                                                                                                     "caption" => "A10",
+                                                                                                     "codeset" => nil,
+                                                                                                     "currentlanguage" => nil,
+                                                                                                     "description" => "A10",
+                                                                                                     "embeddedcontrollermajorversion" => 255,
+                                                                                                     "embeddedcontrollerminorversion" => 255,
+                                                                                                     "identificationcode" => nil,
+                                                                                                     "installablelanguages" => nil,
+                                                                                                     "installdate" => nil,
+                                                                                                     "languageedition" => nil,
+                                                                                                     "listoflanguages" => nil,
+                                                                                                     "manufacturer" => "Dell Inc.",
+                                                                                                     "name" => "A10",
+                                                                                                     "othertargetos" => nil,
+                                                                                                     "primarybios" => true,
+                                                                                                     "releasedate" => "20130513000000.000000+000",
+                                                                                                     "serialnumber" => "87GBNY1",
+                                                                                                     "smbiosbiosversion" => "A10",
+                                                                                                     "smbiosmajorversion" => 2,
+                                                                                                     "smbiosminorversion" => 7,
+                                                                                                     "smbiospresent" => true,
+                                                                                                     "softwareelementid" => "A10",
+                                                                                                     "softwareelementstate" => 3,
+                                                                                                     "status" => "OK",
+                                                                                                     "systembiosmajorversion" => 4,
+                                                                                                     "systembiosminorversion" => 6,
+                                                                                                     "targetoperatingsystem" => 0,
+                                                                                                     "version" => "DELL   - 1072009",
         }])
       plugin.run
-      expect(plugin[:virtualization]).to eq('systems' => {})
+      expect(plugin[:virtualization]).to eq("systems" => {})
     end
   end
 end

data/spec/unit/provides_map_spec.rb

@@ -17,7 +17,7 @@
 # limitations under the License
 #
 
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper.rb')
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper.rb")
 
 describe Ohai::ProvidesMap do
 
@@ -31,14 +31,14 @@ describe Ohai::ProvidesMap do
   describe "when looking up providing plugins for a single attribute" do
     describe "when the attribute does not exist" do
       it "should raise Ohai::Exceptions::AttributeNotFound error" do
-        expect{ provides_map.find_providers_for(["single"]) }.to raise_error(Ohai::Exceptions::AttributeNotFound, "No such attribute: 'single'")
+        expect { provides_map.find_providers_for(["single"]) }.to raise_error(Ohai::Exceptions::AttributeNotFound, "No such attribute: 'single'")
       end
     end
 
     describe "when the attribute does not have a provider" do
       it "should raise Ohai::Exceptions::ProviderNotFound error" do
         provides_map.set_providers_for(plugin_1, ["first/second"])
-        expect{ provides_map.find_providers_for(["first"]) }.to raise_error(Ohai::Exceptions::ProviderNotFound, "Cannot find plugin providing attribute: 'first'")
+        expect { provides_map.find_providers_for(["first"]) }.to raise_error(Ohai::Exceptions::ProviderNotFound, "Cannot find plugin providing attribute: 'first'")
       end
     end
 
@@ -73,7 +73,7 @@ describe Ohai::ProvidesMap do
       end
 
       it "should return each provider" do
-        expect(provides_map.find_providers_for(["one", "two"])).to eq([plugin_1, plugin_2])
+        expect(provides_map.find_providers_for(%w{one two})).to eq([plugin_1, plugin_2])
       end
     end
 
@@ -85,7 +85,7 @@ describe Ohai::ProvidesMap do
       end
 
       it "should return unique providers" do
-        expect(provides_map.find_providers_for(["one", "one_again"])).to eq([plugin_1])
+        expect(provides_map.find_providers_for(%w{one one_again})).to eq([plugin_1])
       end
     end
   end
@@ -105,13 +105,13 @@ describe Ohai::ProvidesMap do
   describe "when setting multi-level attributes" do
     describe "when the attribute contains //" do
       it "should raise an Ohai::Exceptions::AttributeSyntaxError" do
-        expect{ provides_map.set_providers_for(plugin_1, ["this/plugin//is/bad"]) }.to raise_error(Ohai::Exceptions::AttributeSyntaxError, "Attribute contains duplicate '/' characters: this/plugin//is/bad")
+        expect { provides_map.set_providers_for(plugin_1, ["this/plugin//is/bad"]) }.to raise_error(Ohai::Exceptions::AttributeSyntaxError, "Attribute contains duplicate '/' characters: this/plugin//is/bad")
       end
     end
 
     describe "when the attribute has a trailing slash" do
       it "should raise an Ohai::Exceptions::AttributeSyntaxError" do
-        expect{ provides_map.set_providers_for(plugin_1, ["this/plugin/is/bad/"]) }.to raise_error(Ohai::Exceptions::AttributeSyntaxError, "Attribute contains a trailing '/': this/plugin/is/bad/")
+        expect { provides_map.set_providers_for(plugin_1, ["this/plugin/is/bad/"]) }.to raise_error(Ohai::Exceptions::AttributeSyntaxError, "Attribute contains a trailing '/': this/plugin/is/bad/")
       end
     end
   end
@@ -154,7 +154,7 @@ describe Ohai::ProvidesMap do
       end
 
       it "should not raise error if a parent attribute is provided" do
-        expect{ provides_map.find_closest_providers_for(["do/not/eat/plastic"]) }.not_to raise_error
+        expect { provides_map.find_closest_providers_for(["do/not/eat/plastic"]) }.not_to raise_error
       end
 
       it "should return the providers of the closest parent attribute" do
@@ -163,11 +163,11 @@ describe Ohai::ProvidesMap do
       end
 
       it "should raise error if the least-specific parent is not an attribute" do
-        expect{ provides_map.find_closest_providers_for(["please/eat/your/vegetables"]) }.to raise_error(Ohai::Exceptions::AttributeNotFound, "No such attribute: 'please/eat/your/vegetables'")
+        expect { provides_map.find_closest_providers_for(["please/eat/your/vegetables"]) }.to raise_error(Ohai::Exceptions::AttributeNotFound, "No such attribute: 'please/eat/your/vegetables'")
       end
 
       it "should raise error if no parent attribute has a provider" do
-        expect{ provides_map.find_closest_providers_for(["do/not"]) }.to raise_error(Ohai::Exceptions::ProviderNotFound, "Cannot find plugin providing attribute: 'do/not'")
+        expect { provides_map.find_closest_providers_for(["do/not"]) }.to raise_error(Ohai::Exceptions::ProviderNotFound, "Cannot find plugin providing attribute: 'do/not'")
       end
     end
   end