ohai 8.10.0 → 8.11.1

data/spec/unit/plugins/elixir_spec.rb

@@ -14,7 +14,7 @@
 # limitations under the License.
 #
 
-require File.expand_path(File.join(File.dirname(__FILE__), '..', '..', '/spec_helper.rb'))
+require File.expand_path(File.join(File.dirname(__FILE__), "..", "..", "/spec_helper.rb"))
 
 describe Ohai::System, "plugin elixir" do
 
@@ -43,4 +43,3 @@ describe Ohai::System, "plugin elixir" do
   end
 
 end
-

data/spec/unit/plugins/erlang_spec.rb

@@ -17,7 +17,7 @@
 # limitations under the License.
 #
 
-require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper.rb')
+require File.expand_path(File.dirname(__FILE__) + "/../../spec_helper.rb")
 
 describe Ohai::System, "plugin erlang" do
 
@@ -40,7 +40,7 @@ describe Ohai::System, "plugin erlang" do
 
   it "should set languages[:erlang][:options]" do
     @plugin.run
-    expect(@plugin.languages[:erlang][:options]).to eql(["ASYNC_THREADS", "SMP", "HIPE"])
+    expect(@plugin.languages[:erlang][:options]).to eql(%w{ASYNC_THREADS SMP HIPE})
   end
 
   it "should set languages[:erlang][:emulator]" do

data/spec/unit/plugins/eucalyptus_spec.rb

@@ -17,8 +17,8 @@
 # limitations under the License.
 #
 
-require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper.rb')
-require 'open-uri'
+require File.expand_path(File.dirname(__FILE__) + "/../../spec_helper.rb")
+require "open-uri"
 
 describe Ohai::System, "plugin eucalyptus" do
   before(:each) do
@@ -58,15 +58,15 @@ describe Ohai::System, "plugin eucalyptus" do
     end
 
     it "should recursively fetch all the eucalyptus metadata" do
-      allow(IO).to receive(:select).and_return([[],[1],[]])
+      allow(IO).to receive(:select).and_return([[], [1], []])
       t = double("connection")
       allow(t).to receive(:connect_nonblock).and_raise(Errno::EINPROGRESS)
       allow(Socket).to receive(:new).and_return(t)
       @plugin.run
       expect(@plugin[:eucalyptus]).not_to be_nil
-      expect(@plugin[:eucalyptus]['instance_type']).to eq("c1.medium")
-      expect(@plugin[:eucalyptus]['ami_id']).to eq("ami-5d2dc934")
-      expect(@plugin[:eucalyptus]['security_groups']).to eql ['group1', 'group2']
+      expect(@plugin[:eucalyptus]["instance_type"]).to eq("c1.medium")
+      expect(@plugin[:eucalyptus]["ami_id"]).to eq("ami-5d2dc934")
+      expect(@plugin[:eucalyptus]["security_groups"]).to eql %w{group1 group2}
     end
   end
 
@@ -74,8 +74,8 @@ describe Ohai::System, "plugin eucalyptus" do
     it_should_behave_like "eucalyptus"
 
     before(:each) do
-      allow(IO).to receive(:select).and_return([[],[1],[]])
-      @plugin[:network] = { "interfaces" => { "eth0" => { "addresses" => { "d0:0d:95:47:6E:ED"=> { "family" => "lladdr" } } } } }
+      allow(IO).to receive(:select).and_return([[], [1], []])
+      @plugin[:network] = { "interfaces" => { "eth0" => { "addresses" => { "d0:0d:95:47:6E:ED" => { "family" => "lladdr" } } } } }
     end
   end
 
@@ -83,7 +83,7 @@ describe Ohai::System, "plugin eucalyptus" do
     it_should_behave_like "!eucalyptus"
 
     before(:each) do
-      @plugin[:network] = { "interfaces" => { "eth0" => { "addresses" => { "ff:ff:95:47:6E:ED"=> { "family" => "lladdr" } } } } }
+      @plugin[:network] = { "interfaces" => { "eth0" => { "addresses" => { "ff:ff:95:47:6E:ED" => { "family" => "lladdr" } } } } }
     end
   end
 
@@ -91,10 +91,10 @@ describe Ohai::System, "plugin eucalyptus" do
     it_should_behave_like "eucalyptus"
 
     before(:each) do
-      allow(File).to receive(:exist?).with('/etc/chef/ohai/hints/eucalyptus.json').and_return(true)
-      allow(File).to receive(:read).with('/etc/chef/ohai/hints/eucalyptus.json').and_return('')
+      allow(File).to receive(:exist?).with("/etc/chef/ohai/hints/eucalyptus.json").and_return(true)
+      allow(File).to receive(:read).with("/etc/chef/ohai/hints/eucalyptus.json").and_return("")
       allow(File).to receive(:exist?).with('C:\chef\ohai\hints/eucalyptus.json').and_return(true)
-      allow(File).to receive(:read).with('C:\chef\ohai\hints/eucalyptus.json').and_return('')
+      allow(File).to receive(:read).with('C:\chef\ohai\hints/eucalyptus.json').and_return("")
     end
   end
 
@@ -102,8 +102,8 @@ describe Ohai::System, "plugin eucalyptus" do
     it_should_behave_like "!eucalyptus"
 
     before(:each) do
-      @plugin[:network] = {:interfaces => {}}
-      allow(File).to receive(:exist?).with('/etc/chef/ohai/hints/eucalyptus.json').and_return(false)
+      @plugin[:network] = { :interfaces => {} }
+      allow(File).to receive(:exist?).with("/etc/chef/ohai/hints/eucalyptus.json").and_return(false)
       allow(File).to receive(:exist?).with('C:\chef\ohai\hints/eucalyptus.json').and_return(false)
     end
   end
@@ -112,14 +112,14 @@ describe Ohai::System, "plugin eucalyptus" do
     it_should_behave_like "!eucalyptus"
 
     before(:each) do
-      @plugin[:network] = {:interfaces => {}}
+      @plugin[:network] = { :interfaces => {} }
 
-      allow(File).to receive(:exist?).with('/etc/chef/ohai/hints/eucalyptus.json').and_return(false)
+      allow(File).to receive(:exist?).with("/etc/chef/ohai/hints/eucalyptus.json").and_return(false)
       allow(File).to receive(:exist?).with('C:\chef\ohai\hints/eucalyptus.json').and_return(false)
       allow(File).to receive(:exist?).with('C:\chef\ohai\hints/ec2.json').and_return(true)
-      allow(File).to receive(:exist?).with('/etc/chef/ohai/hints/ec2.json').and_return(true)
-      allow(File).to receive(:read).with('/etc/chef/ohai/hints/ec2.json').and_return('')
-      allow(File).to receive(:read).with('C:\chef\ohai\hints/ec2.json').and_return('')
+      allow(File).to receive(:exist?).with("/etc/chef/ohai/hints/ec2.json").and_return(true)
+      allow(File).to receive(:read).with("/etc/chef/ohai/hints/ec2.json").and_return("")
+      allow(File).to receive(:read).with('C:\chef\ohai\hints/ec2.json').and_return("")
     end
   end
 

data/spec/unit/plugins/fail_spec.rb

@@ -17,9 +17,9 @@
 # limitations under the License.
 #
 
-require File.expand_path(File.join(File.dirname(__FILE__), '..', '..', '/spec_helper.rb'))
+require File.expand_path(File.join(File.dirname(__FILE__), "..", "..", "/spec_helper.rb"))
 
-tmp = ENV['TMPDIR'] || ENV['TMP'] || ENV['TEMP'] || '/tmp'
+tmp = ENV["TMPDIR"] || ENV["TMP"] || ENV["TEMP"] || "/tmp"
 
 shared_examples "a v7 loading failure" do
   before(:all) do

data/spec/unit/plugins/freebsd/cpu_spec.rb

@@ -16,7 +16,7 @@
 # limitations under the License.
 #
 
-require File.expand_path(File.dirname(__FILE__) + '/../../../spec_helper.rb')
+require File.expand_path(File.dirname(__FILE__) + "/../../../spec_helper.rb")
 
 describe Ohai::System, "FreeBSD cpu plugin on FreeBSD >=10.2" do
   before(:each) do
@@ -24,20 +24,20 @@ describe Ohai::System, "FreeBSD cpu plugin on FreeBSD >=10.2" do
     allow(@plugin).to receive(:collect_os).and_return(:freebsd)
     @double_file = double("/var/run/dmesg.boot")
     allow(@double_file).to receive(:each).
-      and_yield('CPU: Intel(R) Core(TM) i7-4980HQ CPU @ 2.80GHz (2793.59-MHz K8-class CPU)').
+      and_yield("CPU: Intel(R) Core(TM) i7-4980HQ CPU @ 2.80GHz (2793.59-MHz K8-class CPU)").
       and_yield('  Origin="GenuineIntel"  Id=0x40661  Family=0x6  Model=0x46  Stepping=1').
-      and_yield('  Features=0x783fbff<FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,MMX,FXSR,SSE,SSE2>').
-      and_yield('  Features2=0x5ed8220b<SSE3,PCLMULQDQ,MON,SSSE3,CX16,SSE4.1,SSE4.2,MOVBE,POPCNT,AESNI,XSAVE,OSXSAVE,AVX,RDRAND>').
-      and_yield('  AMD Features=0x28100800<SYSCALL,NX,RDTSCP,LM>').
-      and_yield('  AMD Features2=0x21<LAHF,ABM>').
-      and_yield('  Structured Extended Features=0x2000<NFPUSG>').
-      and_yield('  TSC: P-state invariant').
-      and_yield('real memory  = 1073676288 (1023 MB)').
-      and_yield('avail memory = 1010253824 (963 MB)').
+      and_yield("  Features=0x783fbff<FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,MMX,FXSR,SSE,SSE2>").
+      and_yield("  Features2=0x5ed8220b<SSE3,PCLMULQDQ,MON,SSSE3,CX16,SSE4.1,SSE4.2,MOVBE,POPCNT,AESNI,XSAVE,OSXSAVE,AVX,RDRAND>").
+      and_yield("  AMD Features=0x28100800<SYSCALL,NX,RDTSCP,LM>").
+      and_yield("  AMD Features2=0x21<LAHF,ABM>").
+      and_yield("  Structured Extended Features=0x2000<NFPUSG>").
+      and_yield("  TSC: P-state invariant").
+      and_yield("real memory  = 1073676288 (1023 MB)").
+      and_yield("avail memory = 1010253824 (963 MB)").
       and_yield('Event timer "LAPIC" quality 400').
-      and_yield('ACPI APIC Table: <VBOX   VBOXAPIC>').
-      and_yield('FreeBSD/SMP: Multiprocessor System Detected: 16 CPUs').
-      and_yield('FreeBSD/SMP: 2 package(s) x 4 core(s) x 2 SMT threads')
+      and_yield("ACPI APIC Table: <VBOX   VBOXAPIC>").
+      and_yield("FreeBSD/SMP: Multiprocessor System Detected: 16 CPUs").
+      and_yield("FreeBSD/SMP: 2 package(s) x 4 core(s) x 2 SMT threads")
     allow(File).to receive(:open).with("/var/run/dmesg.boot").and_return(@double_file)
   end
 
@@ -100,7 +100,7 @@ describe Ohai::System, "FreeBSD cpu plugin on FreeBSD <=10.1" do
     allow(@plugin).to receive(:shell_out).with("sysctl -n hw.ncpu").and_return(mock_shell_out(0, "2", ""))
     @double_file = double("/var/run/dmesg.boot")
     allow(@double_file).to receive(:each).
-      and_yield('CPU: Intel(R) Atom(TM) CPU N270   @ 1.60GHz (1596.03-MHz 686-class CPU)').
+      and_yield("CPU: Intel(R) Atom(TM) CPU N270   @ 1.60GHz (1596.03-MHz 686-class CPU)").
       and_yield('  Origin = "GenuineIntel"  Id = 0x106c2  Family = 0x6  Model = 0x1c  Stepping = 2')
     allow(File).to receive(:open).with("/var/run/dmesg.boot").and_return(@double_file)
   end

data/spec/unit/plugins/freebsd/hostname_spec.rb

@@ -16,8 +16,7 @@
 # limitations under the License.
 #
 
-
-require File.expand_path(File.dirname(__FILE__) + '/../../../spec_helper.rb')
+require File.expand_path(File.dirname(__FILE__) + "/../../../spec_helper.rb")
 
 describe Ohai::System, "FreeBSD hostname plugin" do
   before(:each) do

data/spec/unit/plugins/freebsd/kernel_spec.rb

@@ -16,14 +16,13 @@
 # limitations under the License.
 #
 
-
-require File.expand_path(File.dirname(__FILE__) + '/../../../spec_helper.rb')
+require File.expand_path(File.dirname(__FILE__) + "/../../../spec_helper.rb")
 
 describe Ohai::System, "FreeBSD kernel plugin" do
   before(:each) do
     @plugin = get_plugin("kernel")
     allow(@plugin).to receive(:collect_os).and_return(:freebsd)
-    allow(@plugin).to receive(:init_kernel).and_return({:name => "freebsd"})
+    allow(@plugin).to receive(:init_kernel).and_return({ :name => "freebsd" })
     allow(@plugin).to receive(:shell_out).with("uname -i").and_return(mock_shell_out(0, "foo\n", ""))
     allow(@plugin).to receive(:shell_out).with("sysctl kern.securelevel").and_return(mock_shell_out(0, "kern.securelevel: 1", ""))
     allow(@plugin).to receive(:shell_out).with( Ohai.abs_path( "/sbin/kldstat" )).and_return(mock_shell_out(0, "  1    7 0xc0400000 97f830   kernel", ""))

data/spec/unit/plugins/freebsd/os_spec.rb

@@ -6,9 +6,9 @@
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
 # You may obtain a copy of the License at
-# 
+#
 #     http://www.apache.org/licenses/LICENSE-2.0
-# 
+#
 # Unless required by applicable law or agreed to in writing, software
 # distributed under the License is distributed on an "AS IS" BASIS,
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -16,8 +16,7 @@
 # limitations under the License.
 #
 
-
-require File.expand_path(File.dirname(__FILE__) + '/../../../spec_helper.rb')
+require File.expand_path(File.dirname(__FILE__) + "/../../../spec_helper.rb")
 
 describe Ohai::System, "FreeBSD plugin os" do
   before(:each) do
@@ -30,4 +29,4 @@ describe Ohai::System, "FreeBSD plugin os" do
     @plugin.run
     expect(@plugin[:os_version]).to eq("902001")
   end
-end  
+end

data/spec/unit/plugins/freebsd/platform_spec.rb

@@ -16,8 +16,7 @@
 # limitations under the License.
 #
 
-
-require File.expand_path(File.dirname(__FILE__) + '/../../../spec_helper.rb')
+require File.expand_path(File.dirname(__FILE__) + "/../../../spec_helper.rb")
 
 describe Ohai::System, "FreeBSD plugin platform" do
   before(:each) do

data/spec/unit/plugins/gce_spec.rb

@@ -15,8 +15,8 @@
 # limitations under the License.
 #
 
-require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper.rb')
-require 'open-uri'
+require File.expand_path(File.dirname(__FILE__) + "/../../spec_helper.rb")
+require "open-uri"
 
 describe Ohai::System, "plugin gce" do
   before(:each) do
@@ -34,7 +34,7 @@ describe Ohai::System, "plugin gce" do
     before(:each) do
       @http_client = double("Net::HTTP client")
       allow(@plugin).to receive(:http_client).and_return(@http_client)
-      allow(IO).to receive(:select).and_return([[],[1],[]])
+      allow(IO).to receive(:select).and_return([[], [1], []])
       t = double("connection")
       allow(t).to receive(:connect_nonblock).and_raise(Errno::EINPROGRESS)
       allow(Socket).to receive(:new).and_return(t)
@@ -44,12 +44,12 @@ describe Ohai::System, "plugin gce" do
     it "should recursively fetch and properly parse json metadata" do
       expect(@http_client).to receive(:get).
         with("/computeMetadata/v1beta1/?recursive=true/").
-        and_return(double("Net::HTTP Response", :body => '{"instance":{"hostname":"test-host"}}', :code=>"200"))
+        and_return(double("Net::HTTP Response", :body => '{"instance":{"hostname":"test-host"}}', :code => "200"))
 
       @plugin.run
 
       expect(@plugin[:gce]).not_to be_nil
-      expect(@plugin[:gce]['instance']).to eq("hostname"=>"test-host")
+      expect(@plugin[:gce]["instance"]).to eq("hostname" => "test-host")
     end
 
   end
@@ -58,10 +58,10 @@ describe Ohai::System, "plugin gce" do
     it_should_behave_like "gce"
 
     before(:each) do
-      allow(File).to receive(:exist?).with('/etc/chef/ohai/hints/gce.json').and_return(true)
-      allow(File).to receive(:read).with('/etc/chef/ohai/hints/gce.json').and_return('')
+      allow(File).to receive(:exist?).with("/etc/chef/ohai/hints/gce.json").and_return(true)
+      allow(File).to receive(:read).with("/etc/chef/ohai/hints/gce.json").and_return("")
       allow(File).to receive(:exist?).with('C:\chef\ohai\hints/gce.json').and_return(true)
-      allow(File).to receive(:read).with('C:\chef\ohai\hints/gce.json').and_return('')
+      allow(File).to receive(:read).with('C:\chef\ohai\hints/gce.json').and_return("")
     end
   end
 
@@ -69,7 +69,7 @@ describe Ohai::System, "plugin gce" do
     it_should_behave_like "!gce"
 
     before(:each) do
-      allow(File).to receive(:exist?).with('/etc/chef/ohai/hints/gce.json').and_return(false)
+      allow(File).to receive(:exist?).with("/etc/chef/ohai/hints/gce.json").and_return(false)
       allow(File).to receive(:exist?).with('C:\chef\ohai\hints/gce.json').and_return(false)
 
       # Raise Errno::ENOENT to simulate the scenario in which metadata server

data/spec/unit/plugins/go_spec.rb

@@ -13,7 +13,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-require File.expand_path(File.join(File.dirname(__FILE__), '..', '..', '/spec_helper.rb'))
+require File.expand_path(File.join(File.dirname(__FILE__), "..", "..", "/spec_helper.rb"))
 
 describe Ohai::System, "plugin go" do
 

data/spec/unit/plugins/groovy_spec.rb

@@ -16,8 +16,7 @@
 # limitations under the License.
 #
 
-
-require File.expand_path(File.join(File.dirname(__FILE__), '..', '..', '/spec_helper.rb'))
+require File.expand_path(File.join(File.dirname(__FILE__), "..", "..", "/spec_helper.rb"))
 
 describe Ohai::System, "plugin groovy" do
 

data/spec/unit/plugins/hostname_spec.rb

@@ -16,8 +16,7 @@
 # limitations under the License.
 #
 
-
-require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper.rb')
+require File.expand_path(File.dirname(__FILE__) + "/../../spec_helper.rb")
 
 describe Ohai::System, "hostname plugin" do
   before(:each) do

data/spec/unit/plugins/init_package_spec.rb

@@ -16,7 +16,7 @@
 # limitations under the License.
 #
 
-require File.expand_path(File.join(File.dirname(__FILE__), '..', '..', '/spec_helper.rb'))
+require File.expand_path(File.join(File.dirname(__FILE__), "..", "..", "/spec_helper.rb"))
 
 describe Ohai::System, "Init package" do
   let(:plugin) {

data/spec/unit/plugins/ip_scopes_spec.rb

@@ -1,12 +1,12 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper.rb')
+require File.expand_path(File.dirname(__FILE__) + "/../../spec_helper.rb")
 
 begin
-  require 'ipaddr_extensions'
+  require "ipaddr_extensions"
 rescue LoadError
 end
 
 describe Ohai::System, "plugin ip_scopes" do
-  let(:plugin) { get_plugin('ip_scopes') }
+  let(:plugin) { get_plugin("ip_scopes") }
   let(:network) { Mash.new(:interfaces => interfaces) }
   let(:interfaces) { Hash[
       interface1, { :addresses => addresses1, :type => interface1_type },
@@ -15,59 +15,59 @@ describe Ohai::System, "plugin ip_scopes" do
   let(:interface2) { :eth1 }
   let(:addresses1) { {} }
   let(:addresses2) { {} }
-  let(:interface1_type) { 'eth' }
-  let(:interface2_type) { 'eth' }
+  let(:interface1_type) { "eth" }
+  let(:interface2_type) { "eth" }
 
   before { plugin[:network] = network }
 
   if defined?(IPAddrExtensions)
-    context 'with ipaddr_extensions gem' do
-      let(:ip1) { '10.0.0.1' }
-      let(:ip2) { '1.2.3.4' }
-      let(:ip3) { 'fe80::8638:35ff:fe4e:dc74' }
+    context "with ipaddr_extensions gem" do
+      let(:ip1) { "10.0.0.1" }
+      let(:ip2) { "1.2.3.4" }
+      let(:ip3) { "fe80::8638:35ff:fe4e:dc74" }
 
       let(:addresses1) { Hash[ip1, {}] }
       let(:addresses2) { Hash[ip2, {}, ip3, {}] }
 
       it "adds ip_scope to each address's information hash" do
         plugin.run
-        expect(plugin[:network][:interfaces][:eth0][:addresses]['10.0.0.1'][:ip_scope]).to eq('RFC1918 PRIVATE')
-        expect(plugin[:network][:interfaces][:eth1][:addresses]['1.2.3.4'][:ip_scope]).to eq('GLOBAL UNICAST')
-        expect(plugin[:network][:interfaces][:eth1][:addresses]['fe80::8638:35ff:fe4e:dc74'][:ip_scope]).to eq('LINK LOCAL UNICAST')
+        expect(plugin[:network][:interfaces][:eth0][:addresses]["10.0.0.1"][:ip_scope]).to eq("RFC1918 PRIVATE")
+        expect(plugin[:network][:interfaces][:eth1][:addresses]["1.2.3.4"][:ip_scope]).to eq("GLOBAL UNICAST")
+        expect(plugin[:network][:interfaces][:eth1][:addresses]["fe80::8638:35ff:fe4e:dc74"][:ip_scope]).to eq("LINK LOCAL UNICAST")
       end
 
-      describe 'privateaddress attribute' do
+      describe "privateaddress attribute" do
         before { plugin.run }
 
-        context 'when host has multiple RFC1918 ethernet addresses' do
-          let(:ip1) { '10.0.0.1' }
-          let(:ip2) { '192.168.1.1' }
-          let(:interface1_type) { 'eth' }
-          let(:interface2_type) { 'eth' }
+        context "when host has multiple RFC1918 ethernet addresses" do
+          let(:ip1) { "10.0.0.1" }
+          let(:ip2) { "192.168.1.1" }
+          let(:interface1_type) { "eth" }
+          let(:interface2_type) { "eth" }
 
-          it 'picks the last RFC1918 address' do
-            expect(plugin[:privateaddress]).to eq('192.168.1.1')
+          it "picks the last RFC1918 address" do
+            expect(plugin[:privateaddress]).to eq("192.168.1.1")
           end
         end
 
-        context 'when host has virtual and ethernet RFC1918 addresses' do
-          let(:ip1) { '10.0.0.1' }
-          let(:ip2) { '192.168.1.1' }
-          let(:interface1_type) { 'eth' }
-          let(:interface2_type) { 'ppp' }
+        context "when host has virtual and ethernet RFC1918 addresses" do
+          let(:ip1) { "10.0.0.1" }
+          let(:ip2) { "192.168.1.1" }
+          let(:interface1_type) { "eth" }
+          let(:interface2_type) { "ppp" }
 
-          it 'picks the non-virtual address' do
-            expect(plugin[:privateaddress]).to eq('10.0.0.1')
+          it "picks the non-virtual address" do
+            expect(plugin[:privateaddress]).to eq("10.0.0.1")
           end
         end
 
-        context 'when host only has virtual RFC1918 addresses' do
-          let(:ip1) { '10.0.0.1' }
-          let(:ip2) { '192.168.1.1' }
-          let(:interface1_type) { 'ppp' }
-          let(:interface2_type) { 'ppp' }
+        context "when host only has virtual RFC1918 addresses" do
+          let(:ip1) { "10.0.0.1" }
+          let(:ip2) { "192.168.1.1" }
+          let(:interface1_type) { "ppp" }
+          let(:interface2_type) { "ppp" }
 
-          it 'ignores them' do
+          it "ignores them" do
             expect(plugin[:privateaddress]).to be nil
           end
         end
@@ -76,8 +76,8 @@ describe Ohai::System, "plugin ip_scopes" do
   end
 
   unless defined?(IPAddrExtensions)
-    context 'without the ipaddr_extensions gem' do
-      let(:addresses1) { Hash['10.0.0.1', {}] }
+    context "without the ipaddr_extensions gem" do
+      let(:addresses1) { Hash["10.0.0.1", {}] }
 
       before do
         # standin for raising on `require 'ipaddr_extensions'`
@@ -85,11 +85,11 @@ describe Ohai::System, "plugin ip_scopes" do
         plugin.run
       end
 
-      it 'does not add ip_scope to addresses' do
-        expect(plugin[:network][:interfaces][:eth0][:addresses]['10.0.0.1'][:ip_scope]).to be nil
+      it "does not add ip_scope to addresses" do
+        expect(plugin[:network][:interfaces][:eth0][:addresses]["10.0.0.1"][:ip_scope]).to be nil
       end
 
-      it 'does not add a privateaddress attribute' do
+      it "does not add a privateaddress attribute" do
         expect(plugin[:privateaddress]).to be nil
       end
     end