ohai 7.6.0.rc.1 → 8.0.1

data/spec/unit/plugins/darwin/platform_spec.rb

@@ -22,51 +22,51 @@ require File.expand_path(File.dirname(__FILE__) + '/../../../spec_helper.rb')
 describe Ohai::System, "Darwin plugin platform" do
   before(:each) do
     @plugin = get_plugin("darwin/platform")
-    @plugin.stub(:collect_os).and_return(:darwin)
+    allow(@plugin).to receive(:collect_os).and_return(:darwin)
     @stdout = "ProductName:	Mac OS X\nProductVersion:	10.5.5\nBuildVersion:	9F33"
-    @plugin.stub(:shell_out).with("/usr/bin/sw_vers").and_return(mock_shell_out(0, @stdout, ""))
+    allow(@plugin).to receive(:shell_out).with("/usr/bin/sw_vers").and_return(mock_shell_out(0, @stdout, ""))
   end
 
   it "should run sw_vers" do
-    @plugin.should_receive(:shell_out).with("/usr/bin/sw_vers").and_return(mock_shell_out(0, @stdout, ""))
+    expect(@plugin).to receive(:shell_out).with("/usr/bin/sw_vers").and_return(mock_shell_out(0, @stdout, ""))
     @plugin.run
   end
 
   it "should set platform to ProductName, downcased with _ for \\s" do
     @plugin.run
-    @plugin[:platform].should == "mac_os_x"
+    expect(@plugin[:platform]).to eq("mac_os_x")
   end
   
   it "should set platform_version to ProductVersion" do
     @plugin.run
-    @plugin[:platform_version].should == "10.5.5"
+    expect(@plugin[:platform_version]).to eq("10.5.5")
   end
   
   it "should set platform_build to BuildVersion" do
     @plugin.run
-    @plugin[:platform_build].should == "9F33"
+    expect(@plugin[:platform_build]).to eq("9F33")
   end
 
   it "should set platform_family to mac_os_x" do
     @plugin.run
-    @plugin[:platform_family].should == "mac_os_x"
+    expect(@plugin[:platform_family]).to eq("mac_os_x")
   end
 
   describe "on os x server" do
     before(:each) do
       @plugin[:os] = "darwin"
       @stdout = "ProductName:	Mac OS X Server\nProductVersion:	10.6.8\nBuildVersion:	10K549"
-      @plugin.stub(:shell_out).with("/usr/bin/sw_vers").and_return(mock_shell_out(0, @stdout, ""))
+      allow(@plugin).to receive(:shell_out).with("/usr/bin/sw_vers").and_return(mock_shell_out(0, @stdout, ""))
     end
 
     it "should set platform to mac_os_x_server" do
       @plugin.run
-      @plugin[:platform].should == "mac_os_x_server"
+      expect(@plugin[:platform]).to eq("mac_os_x_server")
     end
 
     it "should set platform_family to mac_os_x" do
       @plugin.run
-      @plugin[:platform_family].should == "mac_os_x"
+      expect(@plugin[:platform_family]).to eq("mac_os_x")
     end
   end
 end

data/spec/unit/plugins/darwin/system_profiler_spec.rb

@@ -29,7 +29,7 @@ end
 describe Ohai::System, "Darwin system_profiler plugin", :unix_only do
   before(:each) do
     @plugin = get_plugin("darwin/system_profiler")
-    @plugin.stub(:collect_os).and_return(:darwin)
+    allow(@plugin).to receive(:collect_os).and_return(:darwin)
   end
 
   it "should return the right serial number" do
@@ -39,9 +39,9 @@ describe Ohai::System, "Darwin system_profiler plugin", :unix_only do
     mini_cmd += " SPPCIData SPParallelSCSIData SPPrintersSoftwareData SPPrintersData SPSASData SPSerialATAData"
     mini_cmd += " SPSoftwareData SPThunderboltData SPUSBData SPWWANData SPAirPortData"
     full_cmd = "system_profiler -xml -detailLevel full SPHardwareDataType"
-    @plugin.stub(:shell_out).with(full_cmd).and_return(mock_shell_out(0, SystemProfilerOutput::Full, ""))
-    @plugin.stub(:shell_out).with(mini_cmd).and_return(mock_shell_out(0, SystemProfilerOutput::Mini, ""))
+    allow(@plugin).to receive(:shell_out).with(full_cmd).and_return(mock_shell_out(0, SystemProfilerOutput::Full, ""))
+    allow(@plugin).to receive(:shell_out).with(mini_cmd).and_return(mock_shell_out(0, SystemProfilerOutput::Mini, ""))
     @plugin.run
-    @plugin['system_profile'][18]["_items"][0]["serial_number"].should == 'ABCDEFG12345'
+    expect(@plugin['system_profile'][18]["_items"][0]["serial_number"]).to eq('ABCDEFG12345')
   end
 end

data/spec/unit/plugins/dmi_spec.rb

@@ -95,11 +95,11 @@ describe Ohai::System, "plugin dmi" do
   before(:each) do
     @plugin = get_plugin("dmi")
     @stdout = DMI_OUT
-    @plugin.stub(:shell_out).with("dmidecode").and_return(mock_shell_out(0, @stdout, ""))
+    allow(@plugin).to receive(:shell_out).with("dmidecode").and_return(mock_shell_out(0, @stdout, ""))
   end
 
   it "should run dmidecode" do
-    @plugin.should_receive(:shell_out).with("dmidecode").and_return(mock_shell_out(0, @stdout, ""))
+    expect(@plugin).to receive(:shell_out).with("dmidecode").and_return(mock_shell_out(0, @stdout, ""))
     @plugin.run
   end
 
@@ -121,7 +121,7 @@ describe Ohai::System, "plugin dmi" do
     data.each do |attribute, value|
       it "should have [:dmi][:#{id}][:#{attribute}] set" do
         @plugin.run
-        @plugin[:dmi][id][attribute].should eql(value)
+        expect(@plugin[:dmi][id][attribute]).to eql(value)
       end
     end
   end

data/spec/unit/plugins/ec2_spec.rb

@@ -24,13 +24,13 @@ describe Ohai::System, "plugin ec2" do
   before(:each) do
     @plugin = get_plugin("ec2")
     @plugin[:network] = {:interfaces => {:eth0 => {} } }
-    File.stub(:exist?).with('/etc/chef/ohai/hints/ec2.json').and_return(false)
-    File.stub(:exist?).with('C:\chef\ohai\hints/ec2.json').and_return(false)
+    allow(File).to receive(:exist?).with('/etc/chef/ohai/hints/ec2.json').and_return(false)
+    allow(File).to receive(:exist?).with('C:\chef\ohai\hints/ec2.json').and_return(false)
   end
 
   shared_examples_for "!ec2" do
     it "should NOT attempt to fetch the ec2 metadata" do
-      @plugin.should_not_receive(:http_client)
+      expect(@plugin).not_to receive(:http_client)
       @plugin.run
     end
   end
@@ -38,196 +38,196 @@ describe Ohai::System, "plugin ec2" do
   shared_examples_for "ec2" do
     before(:each) do
       @http_client = double("Net::HTTP client")
-      @plugin.stub(:http_client).and_return(@http_client)
-      IO.stub(:select).and_return([[],[1],[]])
+      allow(@plugin).to receive(:http_client).and_return(@http_client)
+      allow(IO).to receive(:select).and_return([[],[1],[]])
       t = double("connection")
-      t.stub(:connect_nonblock).and_raise(Errno::EINPROGRESS)
-      Socket.stub(:new).and_return(t)
-      @http_client.should_receive(:get).
+      allow(t).to receive(:connect_nonblock).and_raise(Errno::EINPROGRESS)
+      allow(Socket).to receive(:new).and_return(t)
+      expect(@http_client).to receive(:get).
         with("/").twice.
         and_return(double("Net::HTTP Response", :body => "2012-01-12", :code => "200"))
-      File.stub(:exist?).and_return(false)
+      allow(File).to receive(:exist?).and_return(false)
     end
 
     it "should recursively fetch all the ec2 metadata" do
-      @http_client.should_receive(:get).
+      expect(@http_client).to receive(:get).
         with("/2012-01-12/meta-data/").
         and_return(double("Net::HTTP Response", :body => "instance_type\nami_id\nsecurity-groups", :code => "200"))
-      @http_client.should_receive(:get).
+      expect(@http_client).to receive(:get).
         with("/2012-01-12/meta-data/instance_type").
         and_return(double("Net::HTTP Response", :body => "c1.medium", :code => "200"))
-      @http_client.should_receive(:get).
+      expect(@http_client).to receive(:get).
         with("/2012-01-12/meta-data/ami_id").
         and_return(double("Net::HTTP Response", :body => "ami-5d2dc934", :code => "200"))
-      @http_client.should_receive(:get).
+      expect(@http_client).to receive(:get).
         with("/2012-01-12/meta-data/security-groups").
         and_return(double("Net::HTTP Response", :body => "group1\ngroup2", :code => "200"))
-      @http_client.should_receive(:get).
+      expect(@http_client).to receive(:get).
         with("/2012-01-12/user-data/").
         and_return(double("Net::HTTP Response", :body => "By the pricking of my thumb...", :code => "200"))
 
       @plugin.run
 
-      @plugin[:ec2].should_not be_nil
-      @plugin[:ec2]['instance_type'].should == "c1.medium"
-      @plugin[:ec2]['ami_id'].should == "ami-5d2dc934"
-      @plugin[:ec2]['security_groups'].should eql ['group1', 'group2']
+      expect(@plugin[:ec2]).not_to be_nil
+      expect(@plugin[:ec2]['instance_type']).to eq("c1.medium")
+      expect(@plugin[:ec2]['ami_id']).to eq("ami-5d2dc934")
+      expect(@plugin[:ec2]['security_groups']).to eql ['group1', 'group2']
     end
 
     it "should parse ec2 network/ directory as a multi-level hash" do
-      @http_client.should_receive(:get).
+      expect(@http_client).to receive(:get).
         with("/2012-01-12/meta-data/").
         and_return(double("Net::HTTP Response", :body => "network/", :code => "200"))
-      @http_client.should_receive(:get).
+      expect(@http_client).to receive(:get).
         with("/2012-01-12/meta-data/network/").
         and_return(double("Net::HTTP Response", :body => "interfaces/", :code => "200"))
-      @http_client.should_receive(:get).
+      expect(@http_client).to receive(:get).
         with("/2012-01-12/meta-data/network/interfaces/").
         and_return(double("Net::HTTP Response", :body => "macs/", :code => "200"))
-      @http_client.should_receive(:get).
+      expect(@http_client).to receive(:get).
         with("/2012-01-12/meta-data/network/interfaces/macs/").
         and_return(double("Net::HTTP Response", :body => "12:34:56:78:9a:bc/", :code => "200"))
-      @http_client.should_receive(:get).
+      expect(@http_client).to receive(:get).
         with("/2012-01-12/meta-data/network/interfaces/macs/12:34:56:78:9a:bc/").
         and_return(double("Net::HTTP Response", :body => "public_hostname", :code => "200"))
-      @http_client.should_receive(:get).
+      expect(@http_client).to receive(:get).
         with("/2012-01-12/meta-data/network/interfaces/macs/12:34:56:78:9a:bc/public_hostname").
         and_return(double("Net::HTTP Response", :body => "server17.opscode.com", :code => "200"))
-      @http_client.should_receive(:get).
+      expect(@http_client).to receive(:get).
         with("/2012-01-12/user-data/").
         and_return(double("Net::HTTP Response", :body => "By the pricking of my thumb...", :code => "200"))
 
       @plugin.run
 
-      @plugin[:ec2].should_not be_nil
-      @plugin[:ec2]['network_interfaces_macs']['12:34:56:78:9a:bc']['public_hostname'].should eql('server17.opscode.com')
+      expect(@plugin[:ec2]).not_to be_nil
+      expect(@plugin[:ec2]['network_interfaces_macs']['12:34:56:78:9a:bc']['public_hostname']).to eql('server17.opscode.com')
     end
 
     context "with ec2_iam cloud file" do
       before do
         if windows?
-          File.stub(:exist?).with('C:\chef\ohai\hints/iam.json').and_return(true)
-          File.stub(:read).with('C:\chef\ohai\hints/iam.json').and_return('')
+          allow(File).to receive(:exist?).with('C:\chef\ohai\hints/iam.json').and_return(true)
+          allow(File).to receive(:read).with('C:\chef\ohai\hints/iam.json').and_return('')
         else
-          File.stub(:exist?).with('/etc/chef/ohai/hints/iam.json').and_return(true)
-          File.stub(:read).with('/etc/chef/ohai/hints/iam.json').and_return('')
+          allow(File).to receive(:exist?).with('/etc/chef/ohai/hints/iam.json').and_return(true)
+          allow(File).to receive(:read).with('/etc/chef/ohai/hints/iam.json').and_return('')
         end
       end
 
       it "should parse ec2 iam/ directory and collect iam/security-credentials/" do
-        @http_client.should_receive(:get).
+        expect(@http_client).to receive(:get).
           with("/2012-01-12/meta-data/").
           and_return(double("Net::HTTP Response", :body => "iam/", :code => "200"))
-        @http_client.should_receive(:get).
+        expect(@http_client).to receive(:get).
           with("/2012-01-12/meta-data/iam/").
           and_return(double("Net::HTTP Response", :body => "security-credentials/", :code => "200"))
-        @http_client.should_receive(:get).
+        expect(@http_client).to receive(:get).
           with("/2012-01-12/meta-data/iam/security-credentials/").
           and_return(double("Net::HTTP Response", :body => "MyRole", :code => "200"))
-        @http_client.should_receive(:get).
+        expect(@http_client).to receive(:get).
           with("/2012-01-12/meta-data/iam/security-credentials/MyRole").
           and_return(double("Net::HTTP Response", :body => "{\n  \"Code\" : \"Success\",\n  \"LastUpdated\" : \"2012-08-22T07:47:22Z\",\n  \"Type\" : \"AWS-HMAC\",\n  \"AccessKeyId\" : \"AAAAAAAA\",\n  \"SecretAccessKey\" : \"SSSSSSSS\",\n  \"Token\" : \"12345678\",\n  \"Expiration\" : \"2012-08-22T11:25:52Z\"\n}", :code => "200"))
-        @http_client.should_receive(:get).
+        expect(@http_client).to receive(:get).
           with("/2012-01-12/user-data/").
           and_return(double("Net::HTTP Response", :body => "By the pricking of my thumb...", :code => "200"))
 
         @plugin.run
 
-        @plugin[:ec2].should_not be_nil
-        @plugin[:ec2]['iam']['security-credentials']['MyRole']['Code'].should eql 'Success'
-        @plugin[:ec2]['iam']['security-credentials']['MyRole']['Token'].should eql '12345678'
+        expect(@plugin[:ec2]).not_to be_nil
+        expect(@plugin[:ec2]['iam']['security-credentials']['MyRole']['Code']).to eql 'Success'
+        expect(@plugin[:ec2]['iam']['security-credentials']['MyRole']['Token']).to eql '12345678'
       end
     end
 
     context "without ec2_iam cloud file" do
       before do
         if windows?
-          File.stub(:exist?).with('C:\chef\ohai\hints/iam.json').and_return(false)
+          allow(File).to receive(:exist?).with('C:\chef\ohai\hints/iam.json').and_return(false)
         else
-          File.stub(:exist?).with('/etc/chef/ohai/hints/iam.json').and_return(false)
+          allow(File).to receive(:exist?).with('/etc/chef/ohai/hints/iam.json').and_return(false)
         end
       end
 
       it "should parse ec2 iam/ directory and NOT collect iam/security-credentials/" do
-        @http_client.should_receive(:get).
+        expect(@http_client).to receive(:get).
           with("/2012-01-12/meta-data/").
           and_return(double("Net::HTTP Response", :body => "iam/", :code => "200"))
-        @http_client.should_receive(:get).
+        expect(@http_client).to receive(:get).
           with("/2012-01-12/meta-data/iam/").
           and_return(double("Net::HTTP Response", :body => "security-credentials/", :code => "200"))
-        @http_client.should_receive(:get).
+        expect(@http_client).to receive(:get).
           with("/2012-01-12/meta-data/iam/security-credentials/").
           and_return(double("Net::HTTP Response", :body => "MyRole", :code => "200"))
-        @http_client.should_receive(:get).
+        expect(@http_client).to receive(:get).
           with("/2012-01-12/meta-data/iam/security-credentials/MyRole").
           and_return(double("Net::HTTP Response", :body => "{\n  \"Code\" : \"Success\",\n  \"LastUpdated\" : \"2012-08-22T07:47:22Z\",\n  \"Type\" : \"AWS-HMAC\",\n  \"AccessKeyId\" : \"AAAAAAAA\",\n  \"SecretAccessKey\" : \"SSSSSSSS\",\n  \"Token\" : \"12345678\",\n  \"Expiration\" : \"2012-08-22T11:25:52Z\"\n}", :code => "200"))
-        @http_client.should_receive(:get).
+        expect(@http_client).to receive(:get).
           with("/2012-01-12/user-data/").
           and_return(double("Net::HTTP Response", :body => "By the pricking of my thumb...", :code => "200"))
 
         @plugin.run
 
-        @plugin[:ec2].should_not be_nil
-        @plugin[:ec2]['iam'].should be_nil
+        expect(@plugin[:ec2]).not_to be_nil
+        expect(@plugin[:ec2]['iam']).to be_nil
       end
     end
 
     it "should ignore \"./\" and \"../\" on ec2 metadata paths to avoid infinity loops" do
-      @http_client.should_receive(:get).
+      expect(@http_client).to receive(:get).
         with("/2012-01-12/meta-data/").
         and_return(double("Net::HTTP Response", :body => ".\n./\n..\n../\npath1/.\npath2/./\npath3/..\npath4/../", :code => "200"))
 
-      @http_client.should_not_receive(:get).
+      expect(@http_client).not_to receive(:get).
         with("/2012-01-12/meta-data/.")
-      @http_client.should_not_receive(:get).
+      expect(@http_client).not_to receive(:get).
         with("/2012-01-12/meta-data/./")
-      @http_client.should_not_receive(:get).
+      expect(@http_client).not_to receive(:get).
         with("/2012-01-12/meta-data/..")
-      @http_client.should_not_receive(:get).
+      expect(@http_client).not_to receive(:get).
         with("/2012-01-12/meta-data/../")
-      @http_client.should_not_receive(:get).
+      expect(@http_client).not_to receive(:get).
         with("/2012-01-12/meta-data/path1/..")
 
-      @http_client.should_receive(:get).
+      expect(@http_client).to receive(:get).
         with("/2012-01-12/meta-data/path1/").
         and_return(double("Net::HTTP Response", :body => "", :code => "200"))
-      @http_client.should_receive(:get).
+      expect(@http_client).to receive(:get).
         with("/2012-01-12/meta-data/path2/").
         and_return(double("Net::HTTP Response", :body => "", :code => "200"))
-      @http_client.should_receive(:get).
+      expect(@http_client).to receive(:get).
         with("/2012-01-12/meta-data/path3/").
         and_return(double("Net::HTTP Response", :body => "", :code => "200"))
-      @http_client.should_receive(:get).
+      expect(@http_client).to receive(:get).
         with("/2012-01-12/meta-data/path4/").
         and_return(double("Net::HTTP Response", :body => "", :code => "200"))
-      @http_client.should_receive(:get).
+      expect(@http_client).to receive(:get).
         with("/2012-01-12/user-data/").
         and_return(double("Net::HTTP Response", :body => "By the pricking of my thumb...", :code => "200"))
 
       @plugin.run
 
-      @plugin[:ec2].should_not be_nil
+      expect(@plugin[:ec2]).not_to be_nil
     end
 
     it "should complete the run despite unavailable metadata" do
-      @http_client.should_receive(:get).
+      expect(@http_client).to receive(:get).
         with("/2012-01-12/meta-data/").
         and_return(double("Net::HTTP Response", :body => "metrics/", :code => "200"))
-      @http_client.should_receive(:get).
+      expect(@http_client).to receive(:get).
         with("/2012-01-12/meta-data/metrics/").
         and_return(double("Net::HTTP Response", :body => "vhostmd", :code => "200"))
-      @http_client.should_receive(:get).
+      expect(@http_client).to receive(:get).
         with("/2012-01-12/meta-data/metrics/vhostmd").
         and_return(double("Net::HTTP Response", :body => "", :code => "404"))
-      @http_client.should_receive(:get).
+      expect(@http_client).to receive(:get).
         with("/2012-01-12/user-data/").
         and_return(double("Net::HTTP Response", :body => "By the pricking of my thumb...", :code => "200"))
 
       @plugin.run
 
-      @plugin[:ec2].should_not be_nil
-      @plugin[:ec2]['metrics'].should be_nil
-      @plugin[:ec2]['metrics_vhostmd'].should be_nil
+      expect(@plugin[:ec2]).not_to be_nil
+      expect(@plugin[:ec2]['metrics']).to be_nil
+      expect(@plugin[:ec2]['metrics_vhostmd']).to be_nil
     end
   end
 
@@ -235,7 +235,7 @@ describe Ohai::System, "plugin ec2" do
     it_should_behave_like "ec2"
 
     before(:each) do
-      IO.stub(:select).and_return([[],[1],[]])
+      allow(IO).to receive(:select).and_return([[],[1],[]])
       @plugin[:network][:interfaces][:eth0][:arp] = {"169.254.1.0"=>"fe:ff:ff:ff:ff:ff"}
     end
   end
@@ -253,11 +253,11 @@ describe Ohai::System, "plugin ec2" do
 
     before(:each) do
       if windows?
-        File.should_receive(:exist?).with('C:\chef\ohai\hints/ec2.json').and_return(true)
-        File.stub(:read).with('C:\chef\ohai\hints/ec2.json').and_return('')
+        expect(File).to receive(:exist?).with('C:\chef\ohai\hints/ec2.json').and_return(true)
+        allow(File).to receive(:read).with('C:\chef\ohai\hints/ec2.json').and_return('')
       else
-        File.should_receive(:exist?).with('/etc/chef/ohai/hints/ec2.json').and_return(true)
-        File.stub(:read).with('/etc/chef/ohai/hints/ec2.json').and_return('')
+        expect(File).to receive(:exist?).with('/etc/chef/ohai/hints/ec2.json').and_return(true)
+        allow(File).to receive(:read).with('/etc/chef/ohai/hints/ec2.json').and_return('')
       end
     end
   end
@@ -266,8 +266,8 @@ describe Ohai::System, "plugin ec2" do
     it_should_behave_like "!ec2"
 
     before(:each) do
-      File.stub(:exist?).with('/etc/chef/ohai/hints/ec2.json').and_return(false)
-      File.stub(:exist?).with('C:\chef\ohai\hints/ec2.json').and_return(false)
+      allow(File).to receive(:exist?).with('/etc/chef/ohai/hints/ec2.json').and_return(false)
+      allow(File).to receive(:exist?).with('C:\chef\ohai\hints/ec2.json').and_return(false)
     end
   end
 
@@ -275,13 +275,13 @@ describe Ohai::System, "plugin ec2" do
     it_should_behave_like "!ec2"
 
     before(:each) do
-      File.stub(:exist?).with('/etc/chef/ohai/hints/ec2.json').and_return(false)
-      File.stub(:exist?).with('C:\chef\ohai\hints/ec2.json').and_return(false)
+      allow(File).to receive(:exist?).with('/etc/chef/ohai/hints/ec2.json').and_return(false)
+      allow(File).to receive(:exist?).with('C:\chef\ohai\hints/ec2.json').and_return(false)
 
-      File.stub(:exist?).with('/etc/chef/ohai/hints/rackspace.json').and_return(true)
-      File.stub(:read).with('/etc/chef/ohai/hints/rackspace.json').and_return('')
-      File.stub(:exist?).with('C:\chef\ohai\hints/rackspace.json').and_return(true)
-      File.stub(:read).with('C:\chef\ohai\hints/rackspace.json').and_return('')
+      allow(File).to receive(:exist?).with('/etc/chef/ohai/hints/rackspace.json').and_return(true)
+      allow(File).to receive(:read).with('/etc/chef/ohai/hints/rackspace.json').and_return('')
+      allow(File).to receive(:exist?).with('C:\chef\ohai\hints/rackspace.json').and_return(true)
+      allow(File).to receive(:read).with('C:\chef\ohai\hints/rackspace.json').and_return('')
     end
   end
 

data/spec/unit/plugins/erlang_spec.rb

@@ -25,36 +25,36 @@ describe Ohai::System, "plugin erlang" do
     @plugin = get_plugin("erlang")
     @plugin[:languages] = Mash.new
     @stderr = "Erlang (ASYNC_THREADS,SMP,HIPE) (BEAM) emulator version 5.6.2\n"
-    @plugin.stub(:shell_out).with("erl +V").and_return(mock_shell_out(0, "", @stderr))
+    allow(@plugin).to receive(:shell_out).with("erl +V").and_return(mock_shell_out(0, "", @stderr))
   end
 
   it "should get the erlang version from erl +V" do
-    @plugin.should_receive(:shell_out).with("erl +V").and_return(mock_shell_out(0, "", @stderr))
+    expect(@plugin).to receive(:shell_out).with("erl +V").and_return(mock_shell_out(0, "", @stderr))
     @plugin.run
   end
 
   it "should set languages[:erlang][:version]" do
     @plugin.run
-    @plugin.languages[:erlang][:version].should eql("5.6.2")
+    expect(@plugin.languages[:erlang][:version]).to eql("5.6.2")
   end
 
   it "should set languages[:erlang][:options]" do
     @plugin.run
-    @plugin.languages[:erlang][:options].should eql(["ASYNC_THREADS", "SMP", "HIPE"])
+    expect(@plugin.languages[:erlang][:options]).to eql(["ASYNC_THREADS", "SMP", "HIPE"])
   end
 
   it "should set languages[:erlang][:emulator]" do
     @plugin.run
-    @plugin.languages[:erlang][:emulator].should eql("BEAM")
+    expect(@plugin.languages[:erlang][:emulator]).to eql("BEAM")
   end
 
   it "should not set the languages[:erlang] tree up if erlang command fails" do
     @status = 1
     @stdin = ""
     @stderr = "Erlang (ASYNC_THREADS,SMP,HIPE) (BEAM) emulator version 5.6.2\n"
-    @plugin.stub(:shell_out).with("erl +V").and_return(mock_shell_out(1, "", @stderr))
+    allow(@plugin).to receive(:shell_out).with("erl +V").and_return(mock_shell_out(1, "", @stderr))
     @plugin.run
-    @plugin.languages.should_not have_key(:erlang)
+    expect(@plugin.languages).not_to have_key(:erlang)
   end
 
 end