ohai 7.6.0.rc.1 → 8.0.1

data/spec/unit/plugins/linux/uptime_spec.rb

@@ -22,28 +22,28 @@ require File.expand_path(File.dirname(__FILE__) + '/../../../spec_helper.rb')
 describe Ohai::System, "Linux plugin uptime" do
   before(:each) do
     @plugin = get_plugin("uptime")
-    @plugin.stub(:collect_os).and_return(:linux)
+    allow(@plugin).to receive(:collect_os).and_return(:linux)
     @double_file = double("/proc/uptime", { :gets => "18423 989" })
-    File.stub(:open).with("/proc/uptime").and_return(@double_file)
+    allow(File).to receive(:open).with("/proc/uptime").and_return(@double_file)
   end
  
   it "should set uptime_seconds to uptime" do
     @plugin.run
-    @plugin[:uptime_seconds].should == 18423
+    expect(@plugin[:uptime_seconds]).to eq(18423)
   end
   
   it "should set uptime to a human readable date" do
     @plugin.run
-    @plugin[:uptime].should == "5 hours 07 minutes 03 seconds"
+    expect(@plugin[:uptime]).to eq("5 hours 07 minutes 03 seconds")
   end
   
   it "should set idletime_seconds to uptime" do
     @plugin.run
-    @plugin[:idletime_seconds].should == 989
+    expect(@plugin[:idletime_seconds]).to eq(989)
   end
   
   it "should set idletime to a human readable date" do
     @plugin.run
-    @plugin[:idletime].should == "16 minutes 29 seconds"
+    expect(@plugin[:idletime]).to eq("16 minutes 29 seconds")
   end
 end

data/spec/unit/plugins/linux/virtualization_spec.rb

@@ -21,130 +21,130 @@ require File.expand_path(File.dirname(__FILE__) + '/../../../spec_helper.rb')
 describe Ohai::System, "Linux virtualization platform" do
   before(:each) do
     @plugin = get_plugin("linux/virtualization")
-    @plugin.stub(:collect_os).and_return(:linux)
+    allow(@plugin).to receive(:collect_os).and_return(:linux)
 
     # default to all requested Files not existing
-    File.stub(:exists?).with("/proc/xen").and_return(false)
-    File.stub(:exists?).with("/proc/xen/capabilities").and_return(false)
-    File.stub(:exists?).with("/proc/modules").and_return(false)
-    File.stub(:exists?).with("/proc/cpuinfo").and_return(false)
-    File.stub(:exists?).with("/usr/sbin/dmidecode").and_return(false)
-    File.stub(:exists?).with("/proc/self/status").and_return(false)
-    File.stub(:exists?).with("/proc/bc/0").and_return(false)
-    File.stub(:exists?).with("/proc/vz").and_return(false)
-    File.stub(:exists?).with("/proc/self/cgroup").and_return(false)
+    allow(File).to receive(:exists?).with("/proc/xen").and_return(false)
+    allow(File).to receive(:exists?).with("/proc/xen/capabilities").and_return(false)
+    allow(File).to receive(:exists?).with("/proc/modules").and_return(false)
+    allow(File).to receive(:exists?).with("/proc/cpuinfo").and_return(false)
+    allow(File).to receive(:exists?).with("/usr/sbin/dmidecode").and_return(false)
+    allow(File).to receive(:exists?).with("/proc/self/status").and_return(false)
+    allow(File).to receive(:exists?).with("/proc/bc/0").and_return(false)
+    allow(File).to receive(:exists?).with("/proc/vz").and_return(false)
+    allow(File).to receive(:exists?).with("/proc/self/cgroup").and_return(false)
   end
 
   describe "when we are checking for xen" do
     it "should set xen guest if /proc/xen exists but /proc/xen/capabilities does not" do
-      File.should_receive(:exists?).with("/proc/xen").and_return(true)
-      File.should_receive(:exists?).with("/proc/xen/capabilities").and_return(false)
+      expect(File).to receive(:exists?).with("/proc/xen").and_return(true)
+      expect(File).to receive(:exists?).with("/proc/xen/capabilities").and_return(false)
       @plugin.run
-      @plugin[:virtualization][:system].should == "xen"
-      @plugin[:virtualization][:role].should == "guest"
-      @plugin[:virtualization][:systems][:xen].should == "guest"
+      expect(@plugin[:virtualization][:system]).to eq("xen")
+      expect(@plugin[:virtualization][:role]).to eq("guest")
+      expect(@plugin[:virtualization][:systems][:xen]).to eq("guest")
     end
 
     it "should set xen host if /proc/xen/capabilities contains control_d " do
-      File.should_receive(:exists?).with("/proc/xen").and_return(true)
-      File.should_receive(:exists?).with("/proc/xen/capabilities").and_return(true)
-      File.stub(:read).with("/proc/xen/capabilities").and_return("control_d")
+      expect(File).to receive(:exists?).with("/proc/xen").and_return(true)
+      expect(File).to receive(:exists?).with("/proc/xen/capabilities").and_return(true)
+      allow(File).to receive(:read).with("/proc/xen/capabilities").and_return("control_d")
       @plugin.run
-      @plugin[:virtualization][:system].should == "xen"
-      @plugin[:virtualization][:role].should == "host"
-      @plugin[:virtualization][:systems][:xen].should == "host"
+      expect(@plugin[:virtualization][:system]).to eq("xen")
+      expect(@plugin[:virtualization][:role]).to eq("host")
+      expect(@plugin[:virtualization][:systems][:xen]).to eq("host")
     end
 
     it "should set xen guest if /proc/xen/capabilities exists but is empty" do
-      File.should_receive(:exists?).with("/proc/xen").and_return(true)
-      File.should_receive(:exists?).with("/proc/xen/capabilities").and_return(true)
-      File.stub(:read).with("/proc/xen/capabilities").and_return("")
+      expect(File).to receive(:exists?).with("/proc/xen").and_return(true)
+      expect(File).to receive(:exists?).with("/proc/xen/capabilities").and_return(true)
+      allow(File).to receive(:read).with("/proc/xen/capabilities").and_return("")
       @plugin.run
-      @plugin[:virtualization][:system].should == "xen"
-      @plugin[:virtualization][:role].should == "guest"
-      @plugin[:virtualization][:systems][:xen].should == "guest"
+      expect(@plugin[:virtualization][:system]).to eq("xen")
+      expect(@plugin[:virtualization][:role]).to eq("guest")
+      expect(@plugin[:virtualization][:systems][:xen]).to eq("guest")
     end
 
     it "should not set virtualization if xen isn't there" do
-      File.should_receive(:exists?).at_least(:once).and_return(false)
+      expect(File).to receive(:exists?).at_least(:once).and_return(false)
       @plugin.run
-      @plugin[:virtualization].should == {'systems' => {}}
+      expect(@plugin[:virtualization]).to eq({'systems' => {}})
     end
   end
 
   describe "when we are checking for kvm" do
     it "should set kvm host if /proc/modules contains kvm" do
-      File.should_receive(:exists?).with("/proc/modules").and_return(true)
-      File.stub(:read).with("/proc/modules").and_return("kvm 165872  1 kvm_intel")
+      expect(File).to receive(:exists?).with("/proc/modules").and_return(true)
+      allow(File).to receive(:read).with("/proc/modules").and_return("kvm 165872  1 kvm_intel")
       @plugin.run
-      @plugin[:virtualization][:system].should == "kvm"
-      @plugin[:virtualization][:role].should == "host"
-      @plugin[:virtualization][:systems][:kvm].should == "host"
+      expect(@plugin[:virtualization][:system]).to eq("kvm")
+      expect(@plugin[:virtualization][:role]).to eq("host")
+      expect(@plugin[:virtualization][:systems][:kvm]).to eq("host")
     end
 
     it "should set kvm guest if /proc/cpuinfo contains QEMU Virtual CPU" do
-      File.should_receive(:exists?).with("/proc/cpuinfo").and_return(true)
-      File.stub(:read).with("/proc/cpuinfo").and_return("QEMU Virtual CPU")
+      expect(File).to receive(:exists?).with("/proc/cpuinfo").and_return(true)
+      allow(File).to receive(:read).with("/proc/cpuinfo").and_return("QEMU Virtual CPU")
       @plugin.run
-      @plugin[:virtualization][:system].should == "kvm"
-      @plugin[:virtualization][:role].should == "guest"
-      @plugin[:virtualization][:systems][:kvm].should == "guest"
+      expect(@plugin[:virtualization][:system]).to eq("kvm")
+      expect(@plugin[:virtualization][:role]).to eq("guest")
+      expect(@plugin[:virtualization][:systems][:kvm]).to eq("guest")
     end
 
     it "should set kvm guest if /proc/cpuinfo contains Common KVM processor" do
-      File.should_receive(:exists?).with("/proc/cpuinfo").and_return(true)
-      File.stub(:read).with("/proc/cpuinfo").and_return("Common KVM processor")
+      expect(File).to receive(:exists?).with("/proc/cpuinfo").and_return(true)
+      allow(File).to receive(:read).with("/proc/cpuinfo").and_return("Common KVM processor")
       @plugin.run
-      @plugin[:virtualization][:system].should == "kvm"
-      @plugin[:virtualization][:role].should == "guest"
-      @plugin[:virtualization][:systems][:kvm].should == "guest"
+      expect(@plugin[:virtualization][:system]).to eq("kvm")
+      expect(@plugin[:virtualization][:role]).to eq("guest")
+      expect(@plugin[:virtualization][:systems][:kvm]).to eq("guest")
     end
 
     it "should set kvm guest if /proc/cpuinfo contains Common 32-bit KVM processor" do
-      File.should_receive(:exists?).with("/proc/cpuinfo").and_return(true)
-      File.stub(:read).with("/proc/cpuinfo").and_return("Common 32-bit KVM processor")
+      expect(File).to receive(:exists?).with("/proc/cpuinfo").and_return(true)
+      allow(File).to receive(:read).with("/proc/cpuinfo").and_return("Common 32-bit KVM processor")
       @plugin.run
-      @plugin[:virtualization][:system].should == "kvm"
-      @plugin[:virtualization][:role].should == "guest"
-      @plugin[:virtualization][:systems][:kvm].should == "guest"
+      expect(@plugin[:virtualization][:system]).to eq("kvm")
+      expect(@plugin[:virtualization][:role]).to eq("guest")
+      expect(@plugin[:virtualization][:systems][:kvm]).to eq("guest")
     end
 
     it "should not set virtualization if kvm isn't there" do
-      File.should_receive(:exists?).at_least(:once).and_return(false)
+      expect(File).to receive(:exists?).at_least(:once).and_return(false)
       @plugin.run
-      @plugin[:virtualization].should == {'systems' => {}}
+      expect(@plugin[:virtualization]).to eq({'systems' => {}})
     end
   end
 
   describe "when we are checking for VirtualBox" do
     it "should set vbox host if /proc/modules contains vboxdrv" do
-      File.should_receive(:exists?).with("/proc/modules").and_return(true)
-      File.stub(:read).with("/proc/modules").and_return("vboxdrv 268268 3 vboxnetadp,vboxnetflt")
+      expect(File).to receive(:exists?).with("/proc/modules").and_return(true)
+      allow(File).to receive(:read).with("/proc/modules").and_return("vboxdrv 268268 3 vboxnetadp,vboxnetflt")
       @plugin.run
-      @plugin[:virtualization][:system].should == "vbox"
-      @plugin[:virtualization][:role].should == "host"
-      @plugin[:virtualization][:systems][:vbox].should == "host"
+      expect(@plugin[:virtualization][:system]).to eq("vbox")
+      expect(@plugin[:virtualization][:role]).to eq("host")
+      expect(@plugin[:virtualization][:systems][:vbox]).to eq("host")
     end
 
     it "should set vbox gues if /proc/modules contains vboxguest" do
-      File.should_receive(:exists?).with("/proc/modules").and_return(true)
-      File.stub(:read).with("/proc/modules").and_return("vboxguest 214901 2 vboxsf, Live 0xffffffffa00db000 (OF)")
+      expect(File).to receive(:exists?).with("/proc/modules").and_return(true)
+      allow(File).to receive(:read).with("/proc/modules").and_return("vboxguest 214901 2 vboxsf, Live 0xffffffffa00db000 (OF)")
       @plugin.run
-      @plugin[:virtualization][:system].should == "vbox"
-      @plugin[:virtualization][:role].should == "guest"
-      @plugin[:virtualization][:systems][:vbox].should == "guest"
+      expect(@plugin[:virtualization][:system]).to eq("vbox")
+      expect(@plugin[:virtualization][:role]).to eq("guest")
+      expect(@plugin[:virtualization][:systems][:vbox]).to eq("guest")
     end
 
     it "should not set virtualization if vbox isn't there" do
-      File.should_receive(:exists?).at_least(:once).and_return(false)
+      expect(File).to receive(:exists?).at_least(:once).and_return(false)
       @plugin.run
-      @plugin[:virtualization].should == {'systems' => {}}
+      expect(@plugin[:virtualization]).to eq({'systems' => {}})
     end
   end
 
   describe "when we are parsing dmidecode" do
     before(:each) do
-      File.should_receive(:exists?).with("/usr/sbin/dmidecode").and_return(true)
+      expect(File).to receive(:exists?).with("/usr/sbin/dmidecode").and_return(true)
     end
 
     it "should set virtualpc guest if dmidecode detects Microsoft Virtual Machine" do
@@ -157,11 +157,11 @@ System Information
   UUID: D29974A4-BE51-044C-BDC6-EFBC4B87A8E9
   Wake-up Type: Power Switch
 MSVPC
-      @plugin.stub(:shell_out).with("dmidecode").and_return(mock_shell_out(0, ms_vpc_dmidecode, ""))
+      allow(@plugin).to receive(:shell_out).with("dmidecode").and_return(mock_shell_out(0, ms_vpc_dmidecode, ""))
       @plugin.run
-      @plugin[:virtualization][:system].should == "virtualpc"
-      @plugin[:virtualization][:role].should == "guest"
-      @plugin[:virtualization][:systems][:virtualpc].should == "guest"
+      expect(@plugin[:virtualization][:system]).to eq("virtualpc")
+      expect(@plugin[:virtualization][:role]).to eq("guest")
+      expect(@plugin[:virtualization][:systems][:virtualpc]).to eq("guest")
     end
 
     it "should set vmware guest if dmidecode detects VMware Virtual Platform" do
@@ -176,11 +176,11 @@ System Information
   SKU Number: Not Specified
   Family: Not Specified
 VMWARE
-      @plugin.stub(:shell_out).with("dmidecode").and_return(mock_shell_out(0, vmware_dmidecode, ""))
+      allow(@plugin).to receive(:shell_out).with("dmidecode").and_return(mock_shell_out(0, vmware_dmidecode, ""))
       @plugin.run
-      @plugin[:virtualization][:system].should == "vmware"
-      @plugin[:virtualization][:role].should == "guest"
-      @plugin[:virtualization][:systems][:vmware].should == "guest"
+      expect(@plugin[:virtualization][:system]).to eq("vmware")
+      expect(@plugin[:virtualization][:role]).to eq("guest")
+      expect(@plugin[:virtualization][:systems][:vmware]).to eq("guest")
     end
 
     it "should set vbox guest if dmidecode detects Oracle Corporation" do
@@ -197,105 +197,105 @@ Base Board Information
   Type: Motherboard
   Contained Object Handles: 0
 VBOX
-      @plugin.stub(:shell_out).with("dmidecode").and_return(mock_shell_out(0, vbox_dmidecode, ""))
+      allow(@plugin).to receive(:shell_out).with("dmidecode").and_return(mock_shell_out(0, vbox_dmidecode, ""))
       @plugin.run
-      @plugin[:virtualization][:system].should == "vbox"
-      @plugin[:virtualization][:role].should == "guest"
-      @plugin[:virtualization][:systems][:vbox].should == "guest"
+      expect(@plugin[:virtualization][:system]).to eq("vbox")
+      expect(@plugin[:virtualization][:role]).to eq("guest")
+      expect(@plugin[:virtualization][:systems][:vbox]).to eq("guest")
     end
 
     it "should run dmidecode and not set virtualization if nothing is detected" do
-      @plugin.stub(:shell_out).with("dmidecode").and_return(mock_shell_out(0, "", ""))
+      allow(@plugin).to receive(:shell_out).with("dmidecode").and_return(mock_shell_out(0, "", ""))
       @plugin.run
-      @plugin[:virtualization].should == {'systems' => {}}
+      expect(@plugin[:virtualization]).to eq({'systems' => {}})
     end
   end
 
   describe "when we are checking for Linux-VServer" do
     it "should set Linux-VServer host if /proc/self/status contains s_context: 0" do
-      File.should_receive(:exists?).with("/proc/self/status").and_return(true)
-      File.stub(:read).with("/proc/self/status").and_return("s_context: 0")
+      expect(File).to receive(:exists?).with("/proc/self/status").and_return(true)
+      allow(File).to receive(:read).with("/proc/self/status").and_return("s_context: 0")
       @plugin.run
-      @plugin[:virtualization][:system].should == "linux-vserver"
-      @plugin[:virtualization][:role].should == "host"
-      @plugin[:virtualization][:systems]['linux-vserver'].should == "host"
+      expect(@plugin[:virtualization][:system]).to eq("linux-vserver")
+      expect(@plugin[:virtualization][:role]).to eq("host")
+      expect(@plugin[:virtualization][:systems]['linux-vserver']).to eq("host")
     end
 
     it "should set Linux-VServer host if /proc/self/status contains VxID: 0" do
-      File.should_receive(:exists?).with("/proc/self/status").and_return(true)
-      File.stub(:read).with("/proc/self/status").and_return("VxID: 0")
+      expect(File).to receive(:exists?).with("/proc/self/status").and_return(true)
+      allow(File).to receive(:read).with("/proc/self/status").and_return("VxID: 0")
       @plugin.run
-      @plugin[:virtualization][:system].should == "linux-vserver"
-      @plugin[:virtualization][:role].should == "host"
-      @plugin[:virtualization][:systems]['linux-vserver'].should == "host"
+      expect(@plugin[:virtualization][:system]).to eq("linux-vserver")
+      expect(@plugin[:virtualization][:role]).to eq("host")
+      expect(@plugin[:virtualization][:systems]['linux-vserver']).to eq("host")
     end
 
     it "should set Linux-VServer host if /proc/self/status contains multiple space VxID:   0" do
-      File.should_receive(:exists?).with("/proc/self/status").and_return(true)
-      File.stub(:read).with("/proc/self/status").and_return("VxID:   0")
+      expect(File).to receive(:exists?).with("/proc/self/status").and_return(true)
+      allow(File).to receive(:read).with("/proc/self/status").and_return("VxID:   0")
       @plugin.run
-      @plugin[:virtualization][:system].should == "linux-vserver"
-      @plugin[:virtualization][:role].should == "host"
-      @plugin[:virtualization][:systems]['linux-vserver'].should == "host"
+      expect(@plugin[:virtualization][:system]).to eq("linux-vserver")
+      expect(@plugin[:virtualization][:role]).to eq("host")
+      expect(@plugin[:virtualization][:systems]['linux-vserver']).to eq("host")
     end
 
     it "should set Linux-VServer host if /proc/self/status contains tabbed VxID:\t0" do
-      File.should_receive(:exists?).with("/proc/self/status").and_return(true)
-      File.stub(:read).with("/proc/self/status").and_return("VxID:\t0")
+      expect(File).to receive(:exists?).with("/proc/self/status").and_return(true)
+      allow(File).to receive(:read).with("/proc/self/status").and_return("VxID:\t0")
       @plugin.run
-      @plugin[:virtualization][:system].should == "linux-vserver"
-      @plugin[:virtualization][:role].should == "host"
-      @plugin[:virtualization][:systems]['linux-vserver'].should == "host"
+      expect(@plugin[:virtualization][:system]).to eq("linux-vserver")
+      expect(@plugin[:virtualization][:role]).to eq("host")
+      expect(@plugin[:virtualization][:systems]['linux-vserver']).to eq("host")
     end
 
     it "should set Linux-VServer guest if /proc/self/status contains s_context > 0" do
-      File.should_receive(:exists?).with("/proc/self/status").and_return(true)
-      File.stub(:read).with("/proc/self/status").and_return("s_context: 2")
+      expect(File).to receive(:exists?).with("/proc/self/status").and_return(true)
+      allow(File).to receive(:read).with("/proc/self/status").and_return("s_context: 2")
       @plugin.run
-      @plugin[:virtualization][:system].should == "linux-vserver"
-      @plugin[:virtualization][:role].should == "guest"
-      @plugin[:virtualization][:systems]['linux-vserver'].should == "guest"
+      expect(@plugin[:virtualization][:system]).to eq("linux-vserver")
+      expect(@plugin[:virtualization][:role]).to eq("guest")
+      expect(@plugin[:virtualization][:systems]['linux-vserver']).to eq("guest")
     end
 
     it "should set Linux-VServer guest if /proc/self/status contains VxID > 0" do
-      File.should_receive(:exists?).with("/proc/self/status").and_return(true)
-      File.stub(:read).with("/proc/self/status").and_return("VxID: 2")
+      expect(File).to receive(:exists?).with("/proc/self/status").and_return(true)
+      allow(File).to receive(:read).with("/proc/self/status").and_return("VxID: 2")
       @plugin.run
-      @plugin[:virtualization][:system].should == "linux-vserver"
-      @plugin[:virtualization][:role].should == "guest"
-      @plugin[:virtualization][:systems]['linux-vserver'].should == "guest"
+      expect(@plugin[:virtualization][:system]).to eq("linux-vserver")
+      expect(@plugin[:virtualization][:role]).to eq("guest")
+      expect(@plugin[:virtualization][:systems]['linux-vserver']).to eq("guest")
     end
 
     it "should not set virtualization if Linux-VServer isn't there" do
-      File.should_receive(:exists?).at_least(:once).and_return(false)
+      expect(File).to receive(:exists?).at_least(:once).and_return(false)
       @plugin.run
-      @plugin[:virtualization].should == {'systems' => {}}
+      expect(@plugin[:virtualization]).to eq({'systems' => {}})
     end
   end
 
   describe "when we are checking for openvz" do
     it "should set openvz host if /proc/bc/0 exists" do
-      File.should_receive(:exists?).with("/proc/bc/0").and_return(true)
+      expect(File).to receive(:exists?).with("/proc/bc/0").and_return(true)
       @plugin.run
-      @plugin[:virtualization][:system].should == "openvz"
-      @plugin[:virtualization][:role].should == "host"
-      @plugin[:virtualization][:systems][:openvz].should == "host"
+      expect(@plugin[:virtualization][:system]).to eq("openvz")
+      expect(@plugin[:virtualization][:role]).to eq("host")
+      expect(@plugin[:virtualization][:systems][:openvz]).to eq("host")
     end
 
     it "should set openvz guest if /proc/bc/0 doesn't exist and /proc/vz exists" do
-      File.should_receive(:exists?).with("/proc/bc/0").and_return(false)
-      File.should_receive(:exists?).with("/proc/vz").and_return(true)
+      expect(File).to receive(:exists?).with("/proc/bc/0").and_return(false)
+      expect(File).to receive(:exists?).with("/proc/vz").and_return(true)
       @plugin.run
-      @plugin[:virtualization][:system].should == "openvz"
-      @plugin[:virtualization][:role].should == "guest"
-      @plugin[:virtualization][:systems][:openvz].should == "guest"
+      expect(@plugin[:virtualization][:system]).to eq("openvz")
+      expect(@plugin[:virtualization][:role]).to eq("guest")
+      expect(@plugin[:virtualization][:systems][:openvz]).to eq("guest")
     end
 
     it "should not set virtualization if openvz isn't there" do
-      File.should_receive(:exists?).with("/proc/bc/0").and_return(false)
-      File.should_receive(:exists?).with("/proc/vz").and_return(false)
+      expect(File).to receive(:exists?).with("/proc/bc/0").and_return(false)
+      expect(File).to receive(:exists?).with("/proc/vz").and_return(false)
       @plugin.run
-      @plugin[:virtualization].should == {'systems' => {}}
+      expect(@plugin[:virtualization]).to eq({'systems' => {}})
     end
   end
 
@@ -311,12 +311,12 @@ VBOX
 2:cpu:/lxc/baa660ed81bc81d262ac6e19486142aeec5fce2043e2a173eb2505c6fbed89bc
 1:cpuset:/
 CGROUP
-      File.should_receive(:exists?).with("/proc/self/cgroup").and_return(true)
-      File.stub(:read).with("/proc/self/cgroup").and_return(self_cgroup)
+      expect(File).to receive(:exists?).with("/proc/self/cgroup").and_return(true)
+      allow(File).to receive(:read).with("/proc/self/cgroup").and_return(self_cgroup)
       @plugin.run
-      @plugin[:virtualization][:system].should == "lxc"
-      @plugin[:virtualization][:role].should == "guest"
-      @plugin[:virtualization][:systems][:lxc].should == "guest"
+      expect(@plugin[:virtualization][:system]).to eq("lxc")
+      expect(@plugin[:virtualization][:role]).to eq("guest")
+      expect(@plugin[:virtualization][:systems][:lxc]).to eq("guest")
     end
 
     it "should set lxc guest if /proc/self/cgroup exist and there are /lxc/<name> mounts" do
@@ -330,12 +330,12 @@ CGROUP
 2:cpu:/lxc/vanilla
 1:cpuset:/lxc/vanilla
 CGROUP
-      File.should_receive(:exists?).with("/proc/self/cgroup").and_return(true)
-      File.stub(:read).with("/proc/self/cgroup").and_return(self_cgroup)
+      expect(File).to receive(:exists?).with("/proc/self/cgroup").and_return(true)
+      allow(File).to receive(:read).with("/proc/self/cgroup").and_return(self_cgroup)
       @plugin.run
-      @plugin[:virtualization][:system].should == "lxc"
-      @plugin[:virtualization][:role].should == "guest"
-      @plugin[:virtualization][:systems][:lxc].should == "guest"
+      expect(@plugin[:virtualization][:system]).to eq("lxc")
+      expect(@plugin[:virtualization][:role]).to eq("guest")
+      expect(@plugin[:virtualization][:systems][:lxc]).to eq("guest")
     end
 
     it "should set lxc guest if /proc/self/cgroup exist and there are /docker/<name> mounts" do
@@ -351,12 +351,12 @@ CGROUP
 3:cpuset:/
 2:name=systemd:/system.slice/docker.service
 CGROUP
-      File.should_receive(:exists?).with("/proc/self/cgroup").and_return(true)
-      File.stub(:read).with("/proc/self/cgroup").and_return(self_cgroup)
+      expect(File).to receive(:exists?).with("/proc/self/cgroup").and_return(true)
+      allow(File).to receive(:read).with("/proc/self/cgroup").and_return(self_cgroup)
       @plugin.run
-      @plugin[:virtualization][:system].should == "lxc"
-      @plugin[:virtualization][:role].should == "guest"
-      @plugin[:virtualization][:systems][:lxc].should == "guest"
+      expect(@plugin[:virtualization][:system]).to eq("lxc")
+      expect(@plugin[:virtualization][:role]).to eq("guest")
+      expect(@plugin[:virtualization][:systems][:lxc]).to eq("guest")
     end
 
     it "should set not set anything if /proc/self/cgroup exist and the cgroup is named arbitrarily, it isn't necessarily lxc." do
@@ -370,10 +370,10 @@ CGROUP
 2:cpu:/Charlie
 1:cpuset:/Charlie
 CGROUP
-      File.should_receive(:exists?).with("/proc/self/cgroup").and_return(true)
-      File.stub(:read).with("/proc/self/cgroup").and_return(self_cgroup)
+      expect(File).to receive(:exists?).with("/proc/self/cgroup").and_return(true)
+      allow(File).to receive(:read).with("/proc/self/cgroup").and_return(self_cgroup)
       @plugin.run
-      @plugin[:virtualization].should == {'systems' => {}}
+      expect(@plugin[:virtualization]).to eq({'systems' => {}})
     end
 
     context "/proc/self/cgroup only has / mounts" do
@@ -388,47 +388,47 @@ CGROUP
 2:cpu:/
 1:cpuset:/
 CGROUP
-        File.should_receive(:exists?).with("/proc/self/cgroup").and_return(true)
-        File.stub(:read).with("/proc/self/cgroup").and_return(self_cgroup)
+        expect(File).to receive(:exists?).with("/proc/self/cgroup").and_return(true)
+        allow(File).to receive(:read).with("/proc/self/cgroup").and_return(self_cgroup)
       end
 
       it "sets lxc host if lxc-version exists" do
-        @plugin.stub(:lxc_version_exists?).and_return("/usr/bin/lxc-version")
+        allow(@plugin).to receive(:lxc_version_exists?).and_return("/usr/bin/lxc-version")
         @plugin.run
-        @plugin[:virtualization][:system].should == "lxc"
-        @plugin[:virtualization][:role].should == "host"
-        @plugin[:virtualization][:systems][:lxc].should == "host"
+        expect(@plugin[:virtualization][:system]).to eq("lxc")
+        expect(@plugin[:virtualization][:role]).to eq("host")
+        expect(@plugin[:virtualization][:systems][:lxc]).to eq("host")
       end
 
       it "does not set the old virtualization attributes if they are already set" do
-        @plugin.stub(:lxc_version_exists?).and_return("/usr/bin/lxc-version")
+        allow(@plugin).to receive(:lxc_version_exists?).and_return("/usr/bin/lxc-version")
         @plugin[:virtualization] = Mash.new
         @plugin[:virtualization][:system] = "the cloud"
         @plugin[:virtualization][:role] = "cumulonimbus"
         @plugin.run
-        @plugin[:virtualization][:system].should_not == "lxc"
-        @plugin[:virtualization][:role].should_not == "host"
+        expect(@plugin[:virtualization][:system]).not_to eq("lxc")
+        expect(@plugin[:virtualization][:role]).not_to eq("host")
       end
 
       it "does not set lxc host if lxc-version does not exist" do
-        @plugin.stub(:lxc_version_exists?).and_return(false)
+        allow(@plugin).to receive(:lxc_version_exists?).and_return(false)
         @plugin.run
-        @plugin[:virtualization][:system].should be_nil
-        @plugin[:virtualization][:role].should be_nil
-        @plugin[:virtualization].should == {'systems' => {}}
+        expect(@plugin[:virtualization][:system]).to be_nil
+        expect(@plugin[:virtualization][:role]).to be_nil
+        expect(@plugin[:virtualization]).to eq({'systems' => {}})
       end
 
     end
 
     it "should not set virtualization if /proc/self/cgroup isn't there" do
-      File.should_receive(:exists?).with("/proc/self/cgroup").and_return(false)
+      expect(File).to receive(:exists?).with("/proc/self/cgroup").and_return(false)
       @plugin.run
-      @plugin[:virtualization].should == {'systems' => {}}
+      expect(@plugin[:virtualization]).to eq({'systems' => {}})
     end
   end
 
   it "should not set virtualization if no tests match" do
     @plugin.run
-    @plugin[:virtualization].should == {'systems' => {}}
+    expect(@plugin[:virtualization]).to eq({'systems' => {}})
   end
 end