odeon_uk 3.0.6 → 4.0.0

data/test/lib/odeon_uk/{api/response_test.rb → internal/api_response_test.rb}

@@ -1,9 +1,12 @@
 require_relative '../../../test_helper'
 
-describe OdeonUk::Api::Response do
+describe OdeonUk::Internal::ApiResponse do
   include ApiFixturesHelper
 
-  let(:described_class) { OdeonUk::Api::Response }
+  let(:described_class) { OdeonUk::Internal::ApiResponse }
+
+  before { WebMock.disable_net_connect! }
+  after { WebMock.allow_net_connect! }
 
   describe '#app_init' do
     subject { described_class.new.app_init }
@@ -28,12 +31,12 @@ describe OdeonUk::Api::Response do
   end
 
   describe '#showtimes(id)' do
-    subject { described_class.new.film_times(71, 15130) }
+    subject { described_class.new.film_times(71, 15_130) }
 
     before do
       stub_post('film-times',
                 { s: '71', m: '15130' },
-                film_times_plist(71, 15130))
+                film_times_plist_random)
     end
 
     it 'returns an array' do

data/test/lib/odeon_uk/performance_test.rb

@@ -0,0 +1,149 @@
+require_relative '../../test_helper'
+
+describe OdeonUk::Performance do
+  let(:described_class) { OdeonUk::Performance }
+  let(:api_response) { FakeApiResponse.new }
+
+  before { WebMock.disable_net_connect! }
+  after { WebMock.allow_net_connect! }
+
+  describe '.at(cinema_id)' do
+    subject { described_class.at(71) }
+
+    it 'returns an array of performances' do
+      OdeonUk::Internal::ApiResponse.stub :new, api_response do
+        subject.must_be_instance_of(Array)
+        subject.each do |element|
+          element.must_be_instance_of(described_class)
+        end
+      end
+    end
+
+    it 'returns at least a sensible number' do
+      OdeonUk::Internal::ApiResponse.stub :new, api_response do
+        subject.count.must_be :>, 110
+      end
+    end
+  end
+
+  describe '.new' do
+    subject { described_class.new(options) }
+
+    describe 'simple' do
+      let(:options) do
+        {
+          film_name:   'The Big Short',
+          cinema_id:   71,
+          cinema_name: 'Brighton',
+          starting_at: Time.utc(2013, 9, 12, 11, 0)
+        }
+      end
+
+      it 'sets cinema name and film name' do
+        subject.film_name.must_equal 'The Big Short'
+        subject.cinema_name.must_equal 'Brighton'
+      end
+
+      it 'booking url, dimension & varient are set to defaults' do
+        subject.booking_url.must_equal nil
+        subject.dimension.must_equal '2d'
+        subject.variant.must_equal []
+      end
+    end
+  end
+
+  describe '#dimension' do
+    let(:options) do
+      {
+        film_name:   'Ant Man',
+        dimension:   '3d',
+        cinema_id:   71,
+        cinema_name: 'Brighton',
+        starting_at: Time.utc(2013, 9, 12, 11, 0)
+      }
+    end
+
+    subject { described_class.new(options).dimension }
+
+    it 'returns 2d or 3d' do
+      subject.must_be_instance_of(String)
+      subject.must_equal '3d'
+    end
+  end
+
+  describe '#starting_at' do
+    subject { described_class.new(options).starting_at }
+
+    describe 'with utc time' do
+      let(:options) do
+        {
+          film_name:   'Steve Jobs',
+          cinema_id:   71,
+          cinema_name: 'Brighton',
+          starting_at: Time.utc(2013, 9, 12, 11, 0)
+        }
+      end
+
+      it 'returns UTC time' do
+        subject.must_be_instance_of Time
+        subject.must_equal Time.utc(2013, 9, 12, 11, 0)
+      end
+    end
+
+    describe 'with non-utc time' do
+      let(:options) do
+        {
+          film_name:   'Steve Jobs',
+          cinema_id:   71,
+          cinema_name: 'Brighton',
+          starting_at: Time.new(2013, 9, 12, 11, 0)
+        }
+      end
+
+      it 'returns UTC time' do
+        subject.must_be_instance_of Time
+        subject.must_equal Time.utc(2013, 9, 12, 10, 0)
+        subject.utc?.must_equal(true)
+      end
+    end
+  end
+
+  describe '#showing_on' do
+    let(:options) do
+      {
+        film_name:   'The Hunger Games',
+        cinema_id:   71,
+        cinema_name: 'Brighton',
+        starting_at: Time.utc(2013, 9, 12, 11, 0)
+      }
+    end
+
+    subject { described_class.new(options).showing_on }
+
+    it 'returns date of showing' do
+      subject.must_be_instance_of(Date)
+      subject.must_equal Date.new(2013, 9, 12)
+    end
+  end
+
+  describe '#variant' do
+    subject { described_class.new(options).variant }
+
+    let(:options) do
+      {
+        film_name:   'Carol',
+        cinema_id:   71,
+        cinema_name: 'Brighton',
+        starting_at: Time.utc(2013, 9, 12, 11, 0),
+        variant:     %w(Subtitles Senior)
+      }
+    end
+
+    it 'is an alphabetically ordered array of lower-cased strings' do
+      subject.must_be_instance_of Array
+      subject.each { |element| element.must_be_instance_of String }
+      subject.must_equal %w(senior subtitles)
+    end
+  end
+
+end

data/test/lib/odeon_uk/version_test.rb

@@ -1,9 +1,7 @@
 require_relative '../../test_helper'
- 
+
 describe OdeonUk do
- 
-  it "must be defined" do
+  it 'must be defined' do
     OdeonUk::VERSION.wont_be_nil
   end
- 
-end
+end

data/test/support/api_fixtures_helper.rb

@@ -1,3 +1,4 @@
+# Read fixtures from disk
 module ApiFixturesHelper
   private
 
@@ -13,9 +14,14 @@ module ApiFixturesHelper
     read_fixture("api/film_times/#{cinema_id}-#{film_id}")
   end
 
-  def film_times_plists(cinema_id)
-    listing = Dir.entries(File.expand_path('../../fixtures/api/film_times', __FILE__))
-    listing.reject { |filename| !filename.match(/\A#{cinema_id}-/) }
+  def film_times_plist_random
+    read_fixture("api/film_times/#{film_times_plist_names(71).sample}")
+  end
+
+  def film_times_plist_names(cinema_id)
+    Dir.entries(File.expand_path('../../fixtures/api/film_times', __FILE__))
+       .reject { |filename| !filename.match(/\A#{cinema_id}-/) }
+       .map { |filename| filename.gsub('.plist', '') }
   end
 
   def parse(content)

data/test/support/fake_api_response.rb

@@ -0,0 +1,17 @@
+require_relative 'api_fixtures_helper'
+
+class FakeApiResponse
+  include ApiFixturesHelper
+
+  def app_init
+    parse(app_init_plist)
+  end
+
+  def all_cinemas
+    parse(all_cinemas_plist)
+  end
+
+  def film_times(cinema_id, film_id)
+    parse(film_times_plist(cinema_id, film_id))
+  end
+end

data/test/test_helper.rb

@@ -1,11 +1,17 @@
+require 'codeclimate-test-reporter'
+CodeClimate::TestReporter.start
+
 require 'minitest/autorun'
 require 'minitest/reporters'
-reporter_options = { color: true, slow_count: 5 }
-Minitest::Reporters.use! [Minitest::Reporters::DefaultReporter.new(reporter_options)]
+
+Minitest::Reporters.use! [
+  Minitest::Reporters::DefaultReporter.new(color: true, slow_count: 5)
+]
 
 require 'webmock/minitest'
+WebMock.allow_net_connect!
 
 require File.expand_path('../../lib/odeon_uk.rb', __FILE__)
 
 require_relative 'support/api_fixtures_helper'
-require_relative 'support/website_fixtures_helper'
+require_relative 'support/fake_api_response'

metadata

@@ -1,17 +1,17 @@
 --- !ruby/object:Gem::Specification
 name: odeon_uk
 version: !ruby/object:Gem::Version
-  version: 3.0.6
+  version: 4.0.0
 platform: ruby
 authors:
 - Andy Croll
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-05 00:00:00.000000000 Z
+date: 2016-02-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: codeclimate-test-reporter
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -39,7 +39,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: webmock
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -53,27 +53,13 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: CFPropertyList
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: nokogiri
+  name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  type: :runtime
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
@@ -81,7 +67,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: tzinfo
+  name: CFPropertyList
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -95,20 +81,20 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: tzinfo-data
+  name: cinebase
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
-description: An API to pull movie information from the ODEON.co.uk website
+        version: '3.0'
+description: Pull movie & cinema information from the Odeon iOS API
 email:
 - andy@goodscary.com
 executables: []
@@ -116,90 +102,67 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
-- ".rdoc_options"
 - ".travis.yml"
 - CHANGELOG.md
+- COMM-LICENSE
 - Gemfile
-- LICENSE.txt
+- LICENSE
 - README.md
 - Rakefile
 - lib/odeon_uk.rb
-- lib/odeon_uk/api/cinema.rb
-- lib/odeon_uk/api/response.rb
-- lib/odeon_uk/api/screenings.rb
 - lib/odeon_uk/cinema.rb
-- lib/odeon_uk/configuration.rb
-- lib/odeon_uk/html/cinema.rb
-- lib/odeon_uk/html/parser/film_with_screenings.rb
-- lib/odeon_uk/html/screenings.rb
-- lib/odeon_uk/html/website.rb
+- lib/odeon_uk/internal/api_response.rb
+- lib/odeon_uk/internal/parser/api/film_lookup.rb
+- lib/odeon_uk/internal/parser/api/performance_day.rb
 - lib/odeon_uk/internal/title_sanitizer.rb
-- lib/odeon_uk/screening.rb
+- lib/odeon_uk/performance.rb
 - lib/odeon_uk/version.rb
 - odeon_uk.gemspec
 - rake/fixture_creator.rb
 - test/fixtures/api/all_cinemas.plist
 - test/fixtures/api/app_init.plist
-- test/fixtures/api/film_times/71-100747.plist
-- test/fixtures/api/film_times/71-100750.plist
-- test/fixtures/api/film_times/71-100790.plist
-- test/fixtures/api/film_times/71-14646.plist
-- test/fixtures/api/film_times/71-14725.plist
-- test/fixtures/api/film_times/71-15086.plist
-- test/fixtures/api/film_times/71-15096.plist
-- test/fixtures/api/film_times/71-15122.plist
-- test/fixtures/api/film_times/71-15130.plist
-- test/fixtures/api/film_times/71-15141.plist
-- test/fixtures/api/film_times/71-15142.plist
-- test/fixtures/api/film_times/71-15143.plist
-- test/fixtures/api/film_times/71-15144.plist
-- test/fixtures/api/film_times/71-15145.plist
-- test/fixtures/api/film_times/71-15170.plist
-- test/fixtures/api/film_times/71-15172.plist
-- test/fixtures/api/film_times/71-15177.plist
-- test/fixtures/api/film_times/71-15179.plist
-- test/fixtures/api/film_times/71-15182.plist
-- test/fixtures/api/film_times/71-15286.plist
-- test/fixtures/api/film_times/71-15360.plist
-- test/fixtures/api/film_times/71-15586.plist
-- test/fixtures/api/film_times/71-15700.plist
-- test/fixtures/api/film_times/71-15718.plist
-- test/fixtures/api/film_times/71-15768.plist
-- test/fixtures/api/film_times/71-15788.plist
-- test/fixtures/api/film_times/71-15793.plist
-- test/fixtures/api/film_times/71-15794.plist
-- test/fixtures/api/film_times/71-15795.plist
-- test/fixtures/api/film_times/71-15796.plist
-- test/fixtures/api/film_times/71-15799.plist
-- test/fixtures/api/film_times/71-15802.plist
-- test/fixtures/api/film_times/71-15814.plist
-- test/fixtures/api/film_times/71-15817.plist
-- test/fixtures/api/film_times/71-15840.plist
-- test/fixtures/html/cinema/105.html
-- test/fixtures/html/cinema/211.html
-- test/fixtures/html/cinema/71.html
-- test/fixtures/html/showtimes/11-imax.html
-- test/fixtures/html/showtimes/171-d-box.html
-- test/fixtures/html/showtimes/71-0.html
-- test/fixtures/html/showtimes/71.html
-- test/fixtures/html/sitemap.html
-- test/lib/odeon_uk/api/cinema_test.rb
-- test/lib/odeon_uk/api/response_test.rb
-- test/lib/odeon_uk/api/screenings_test.rb
+- test/fixtures/api/film_times/71-14876.plist
+- test/fixtures/api/film_times/71-15408.plist
+- test/fixtures/api/film_times/71-15684.plist
+- test/fixtures/api/film_times/71-15866.plist
+- test/fixtures/api/film_times/71-15868.plist
+- test/fixtures/api/film_times/71-15961.plist
+- test/fixtures/api/film_times/71-15963.plist
+- test/fixtures/api/film_times/71-15965.plist
+- test/fixtures/api/film_times/71-15967.plist
+- test/fixtures/api/film_times/71-15969.plist
+- test/fixtures/api/film_times/71-15977.plist
+- test/fixtures/api/film_times/71-15980.plist
+- test/fixtures/api/film_times/71-16037.plist
+- test/fixtures/api/film_times/71-16136.plist
+- test/fixtures/api/film_times/71-16142.plist
+- test/fixtures/api/film_times/71-16143.plist
+- test/fixtures/api/film_times/71-16187.plist
+- test/fixtures/api/film_times/71-16369.plist
+- test/fixtures/api/film_times/71-16370.plist
+- test/fixtures/api/film_times/71-16374.plist
+- test/fixtures/api/film_times/71-16386.plist
+- test/fixtures/api/film_times/71-16387.plist
+- test/fixtures/api/film_times/71-16388.plist
+- test/fixtures/api/film_times/71-16438.plist
+- test/fixtures/api/film_times/71-16454.plist
+- test/fixtures/api/film_times/71-16457.plist
+- test/fixtures/api/film_times/71-16477.plist
+- test/fixtures/api/film_times/71-16478.plist
+- test/fixtures/api/film_times/71-16480.plist
+- test/fixtures/api/film_times/71-16482.plist
+- test/fixtures/api/film_times/71-16489.plist
 - test/lib/odeon_uk/cinema_test.rb
-- test/lib/odeon_uk/configuration_test.rb
-- test/lib/odeon_uk/html/cinema_test.rb
-- test/lib/odeon_uk/html/parser/film_with_screenings_test.rb
-- test/lib/odeon_uk/html/screenings_test.rb
-- test/lib/odeon_uk/html/website_test.rb
+- test/lib/odeon_uk/internal/api_response_test.rb
 - test/lib/odeon_uk/internal/title_sanitizer_test.rb
-- test/lib/odeon_uk/screening_test.rb
+- test/lib/odeon_uk/performance_test.rb
 - test/lib/odeon_uk/version_test.rb
 - test/support/api_fixtures_helper.rb
-- test/support/website_fixtures_helper.rb
+- test/support/fake_api_response.rb
 - test/test_helper.rb
 homepage: http://github.com/andycroll/odeon_uk
 licenses:
+- AGPL
 - MIT
 metadata: {}
 post_install_message: 
@@ -218,69 +181,50 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: It's a scraper, but a nice one
 test_files:
 - test/fixtures/api/all_cinemas.plist
 - test/fixtures/api/app_init.plist
-- test/fixtures/api/film_times/71-100747.plist
-- test/fixtures/api/film_times/71-100750.plist
-- test/fixtures/api/film_times/71-100790.plist
-- test/fixtures/api/film_times/71-14646.plist
-- test/fixtures/api/film_times/71-14725.plist
-- test/fixtures/api/film_times/71-15086.plist
-- test/fixtures/api/film_times/71-15096.plist
-- test/fixtures/api/film_times/71-15122.plist
-- test/fixtures/api/film_times/71-15130.plist
-- test/fixtures/api/film_times/71-15141.plist
-- test/fixtures/api/film_times/71-15142.plist
-- test/fixtures/api/film_times/71-15143.plist
-- test/fixtures/api/film_times/71-15144.plist
-- test/fixtures/api/film_times/71-15145.plist
-- test/fixtures/api/film_times/71-15170.plist
-- test/fixtures/api/film_times/71-15172.plist
-- test/fixtures/api/film_times/71-15177.plist
-- test/fixtures/api/film_times/71-15179.plist
-- test/fixtures/api/film_times/71-15182.plist
-- test/fixtures/api/film_times/71-15286.plist
-- test/fixtures/api/film_times/71-15360.plist
-- test/fixtures/api/film_times/71-15586.plist
-- test/fixtures/api/film_times/71-15700.plist
-- test/fixtures/api/film_times/71-15718.plist
-- test/fixtures/api/film_times/71-15768.plist
-- test/fixtures/api/film_times/71-15788.plist
-- test/fixtures/api/film_times/71-15793.plist
-- test/fixtures/api/film_times/71-15794.plist
-- test/fixtures/api/film_times/71-15795.plist
-- test/fixtures/api/film_times/71-15796.plist
-- test/fixtures/api/film_times/71-15799.plist
-- test/fixtures/api/film_times/71-15802.plist
-- test/fixtures/api/film_times/71-15814.plist
-- test/fixtures/api/film_times/71-15817.plist
-- test/fixtures/api/film_times/71-15840.plist
-- test/fixtures/html/cinema/105.html
-- test/fixtures/html/cinema/211.html
-- test/fixtures/html/cinema/71.html
-- test/fixtures/html/showtimes/11-imax.html
-- test/fixtures/html/showtimes/171-d-box.html
-- test/fixtures/html/showtimes/71-0.html
-- test/fixtures/html/showtimes/71.html
-- test/fixtures/html/sitemap.html
-- test/lib/odeon_uk/api/cinema_test.rb
-- test/lib/odeon_uk/api/response_test.rb
-- test/lib/odeon_uk/api/screenings_test.rb
+- test/fixtures/api/film_times/71-14876.plist
+- test/fixtures/api/film_times/71-15408.plist
+- test/fixtures/api/film_times/71-15684.plist
+- test/fixtures/api/film_times/71-15866.plist
+- test/fixtures/api/film_times/71-15868.plist
+- test/fixtures/api/film_times/71-15961.plist
+- test/fixtures/api/film_times/71-15963.plist
+- test/fixtures/api/film_times/71-15965.plist
+- test/fixtures/api/film_times/71-15967.plist
+- test/fixtures/api/film_times/71-15969.plist
+- test/fixtures/api/film_times/71-15977.plist
+- test/fixtures/api/film_times/71-15980.plist
+- test/fixtures/api/film_times/71-16037.plist
+- test/fixtures/api/film_times/71-16136.plist
+- test/fixtures/api/film_times/71-16142.plist
+- test/fixtures/api/film_times/71-16143.plist
+- test/fixtures/api/film_times/71-16187.plist
+- test/fixtures/api/film_times/71-16369.plist
+- test/fixtures/api/film_times/71-16370.plist
+- test/fixtures/api/film_times/71-16374.plist
+- test/fixtures/api/film_times/71-16386.plist
+- test/fixtures/api/film_times/71-16387.plist
+- test/fixtures/api/film_times/71-16388.plist
+- test/fixtures/api/film_times/71-16438.plist
+- test/fixtures/api/film_times/71-16454.plist
+- test/fixtures/api/film_times/71-16457.plist
+- test/fixtures/api/film_times/71-16477.plist
+- test/fixtures/api/film_times/71-16478.plist
+- test/fixtures/api/film_times/71-16480.plist
+- test/fixtures/api/film_times/71-16482.plist
+- test/fixtures/api/film_times/71-16489.plist
 - test/lib/odeon_uk/cinema_test.rb
-- test/lib/odeon_uk/configuration_test.rb
-- test/lib/odeon_uk/html/cinema_test.rb
-- test/lib/odeon_uk/html/parser/film_with_screenings_test.rb
-- test/lib/odeon_uk/html/screenings_test.rb
-- test/lib/odeon_uk/html/website_test.rb
+- test/lib/odeon_uk/internal/api_response_test.rb
 - test/lib/odeon_uk/internal/title_sanitizer_test.rb
-- test/lib/odeon_uk/screening_test.rb
+- test/lib/odeon_uk/performance_test.rb
 - test/lib/odeon_uk/version_test.rb
 - test/support/api_fixtures_helper.rb
-- test/support/website_fixtures_helper.rb
+- test/support/fake_api_response.rb
 - test/test_helper.rb
 has_rdoc: