odeon_uk 3.0.6 → 4.0.0

data/test/lib/odeon_uk/cinema_test.rb

@@ -1,479 +1,260 @@
 require_relative '../../test_helper'
 
 describe OdeonUk::Cinema do
-  let(:described_class) { OdeonUk::Cinema }
-
-  before do
-    WebMock.disable_net_connect!
-  end
-
-  describe 'with HTML parsing' do
-    include WebsiteFixturesHelper
-
-    let(:website) { Minitest::Mock.new }
-
-    describe '.all' do
-      subject { described_class.all }
-
-      before do
-        website.expect(:sitemap, sitemap_html)
-      end
-
-      it 'returns an Array of OdeonUk::Cinemas' do
-        OdeonUk::Html::Website.stub :new, website do
-          subject.must_be_instance_of(Array)
-          subject.each do |value|
-            value.must_be_instance_of(described_class)
-          end
-        end
-      end
-
-      it 'returns the correctly sized array' do
-        OdeonUk::Html::Website.stub :new, website do
-          subject.size.must_equal 115
-        end
-      end
-    end
-
-    describe '.new(id)' do
-      subject { described_class.new(id) }
+  include ApiFixturesHelper
 
-      describe 'Brighton' do
-        let(:id) { 71 }
+  let(:described_class) { OdeonUk::Cinema }
+  let(:api_response) { FakeApiResponse.new }
 
-        before do
-          website.expect(:sitemap, sitemap_html)
-        end
+  before { WebMock.disable_net_connect! }
+  after { WebMock.allow_net_connect! }
 
-        it 'returns a cinema' do
-          OdeonUk::Html::Website.stub :new, website do
-            subject.must_be_instance_of(described_class)
+  describe '.new(id)' do
+    subject { described_class.new(id) }
 
-            subject.id.must_equal 71
-            subject.brand.must_equal 'Odeon'
-            subject.name.must_equal 'Brighton'
-            subject.slug.must_equal 'odeon-brighton'
-            subject.url.must_equal 'http://www.odeon.co.uk/cinemas/brighton/71/'
-          end
-        end
-      end
-    end
+    describe 'Brighton' do
+      let(:id) { 71 }
 
-    describe '#adr' do
-      subject { described_class.new(71).adr }
-
-      describe '(brighton)' do
-        before { website.expect(:cinema, cinema_html(71), [71]) }
-
-        it 'returns the address hash' do
-          OdeonUk::Html::Website.stub :new, website do
-            subject.must_equal(
-              street_address: 'Kingswest',
-              locality:       'Brighton',
-              postal_code:    'BN1 2RE',
-              country_name:   'United Kingdom'
-            )
-          end
-        end
+      it 'returns a cinema with a string id' do
+        subject.must_be_instance_of(described_class)
+        subject.id.must_equal(id.to_s)
       end
     end
+  end
 
-    describe '#brand' do
-      subject { described_class.new(id).brand }
-
-      describe 'cinema name with London' do
-        let(:id) { 105 }
-
-        it 'removes "London" name prefix' do
-          subject.must_equal 'Odeon'
-        end
-      end
-    end
-
-    describe '#full_name' do
-      subject { described_class.new(71).full_name }
-
-      describe 'simple name (brighton)' do
-        before { website.expect(:sitemap, sitemap_html) }
+  describe '.all' do
+    subject { described_class.all }
 
-        it 'returns the brand in the name' do
-          OdeonUk::Html::Website.stub :new, website do
-            subject.must_equal 'Odeon Brighton'
-          end
+    it 'returns an array of cinemas' do
+      OdeonUk::Internal::ApiResponse.stub :new, api_response do
+        subject.must_be_instance_of(Array)
+        subject.each do |element|
+          element.must_be_instance_of(described_class)
         end
+        subject.count.must_be :>, 100
       end
     end
+  end
 
-    describe '#locality' do
-      subject { described_class.new(71).locality }
+  describe '#adr' do
+    subject { described_class.new(id).adr }
 
-      before { website.expect(:cinema, cinema_html(71), [71]) }
+    describe 'short address' do
+      let(:id) { 71 }
 
-      it 'returns town name' do
-        OdeonUk::Html::Website.stub :new, website do
-          subject.must_equal 'Brighton'
+      it 'returns the postcode' do
+        OdeonUk::Internal::ApiResponse.stub :new, api_response do
+          subject.must_equal(street_address:   'Kingswest',
+                             extended_address: nil,
+                             locality:         'Brighton',
+                             region:           nil,
+                             postal_code:      'BN1 2RE',
+                             country_name:     'United Kingdom')
         end
       end
     end
+  end
 
-    describe '#name' do
-      subject { described_class.new(id).name }
-
-      before { website.expect(:sitemap, sitemap_html) }
+  describe '#address' do
+    subject { described_class.new(id).address }
 
-      describe 'cinema name with London' do
-        let(:id) { 105 }
+    describe 'London address' do
+      let(:id) { 105 }
 
-        it 'removes "London" name prefix' do
-          OdeonUk::Html::Website.stub :new, website do
-            subject.must_equal 'Leicester Square'
-          end
-        end
-      end
-
-      describe 'cinema name with dashes' do
-        let(:id) { 208 }
-
-        it 'removes " - " and replaces it with a colon ": "' do
-          OdeonUk::Html::Website.stub :new, website do
-            subject.must_equal 'Whiteleys: The Lounge'
-          end
+      it 'returns the postcode' do
+        OdeonUk::Internal::ApiResponse.stub :new, api_response do
+          subject.must_equal(street_address:   '24-26 Leicester Square',
+                             extended_address: nil,
+                             locality:         'London',
+                             region:           nil,
+                             postal_code:      'WC2H 7JY',
+                             country_name:     'United Kingdom')
         end
       end
     end
+  end
 
-    describe '#postal_code' do
-      subject { described_class.new(id).postal_code }
-
-      describe 'short address' do
-        let(:id) { 71 }
-
-        before { website.expect(:cinema, cinema_html(71), [71]) }
-
-        it 'returns the postcode' do
-          OdeonUk::Html::Website.stub :new, website do
-            subject.must_equal 'BN1 2RE'
-          end
-        end
-      end
-
-      describe 'short address (London)' do
-        let(:id) { 211 }
-
-        before { website.expect(:cinema, cinema_html(211), [211]) }
-
-        it 'returns the postcode' do
-          OdeonUk::Html::Website.stub :new, website do
-            subject.must_equal 'SE1 8XR'
-          end
-        end
-      end
-
-      describe 'short address (extra London Postcode)' do
-        let(:id) { 105 }
-
-        before { website.expect(:cinema, cinema_html(105), [105]) }
+  describe '#brand' do
+    subject { described_class.new(id).brand }
+    describe 'short address' do
+      let(:id) { 71 }
 
-        it 'returns the postcode' do
-          OdeonUk::Html::Website.stub :new, website do
-            subject.must_equal 'WC2H 7LQ'
-          end
+      it 'returns the postcode' do
+        OdeonUk::Internal::ApiResponse.stub :new, api_response do
+          subject.must_equal 'Odeon'
         end
       end
     end
+  end
 
-    describe '#screenings' do
-      subject { described_class.new(71).screenings }
+  describe '#country_name' do
+    subject { described_class.new(id).country_name }
+    describe 'short address' do
+      let(:id) { 71 }
 
-      it 'calls out to Screening object' do
-        OdeonUk::Screening.stub :at, [:screening] do
-          subject.must_equal([:screening])
+      it 'returns the postcode' do
+        OdeonUk::Internal::ApiResponse.stub :new, api_response do
+          subject.must_equal 'United Kingdom'
         end
       end
     end
+  end
 
-    describe '#slug' do
-      subject { described_class.new(71).slug }
-
-      describe 'simple name (brighton)' do
-        before { website.expect(:sitemap, sitemap_html) }
+  describe '#extended_address' do
+    subject { described_class.new(id).extended_address }
+    describe 'short address' do
+      let(:id) { 71 }
 
-        it 'returns the brand in the name' do
-          OdeonUk::Html::Website.stub :new, website do
-            subject.must_equal 'odeon-brighton'
-          end
+      it 'returns the postcode' do
+        OdeonUk::Internal::ApiResponse.stub :new, api_response do
+          subject.must_equal ''
         end
       end
     end
+  end
 
-    describe '#street_address' do
-      subject { described_class.new(id).street_address }
-
-      describe 'short address' do
-        let(:id) { 71 }
-
-        before { website.expect(:cinema, cinema_html(71), [71]) }
+  describe '#full_name' do
+    subject { described_class.new(id).full_name }
+    describe 'Brighton' do
+      let(:id) { 71 }
 
-        it 'returns first line of address' do
-          OdeonUk::Html::Website.stub :new, website do
-            subject.must_equal 'Kingswest'
-          end
+      it 'returns cinema name' do
+        OdeonUk::Internal::ApiResponse.stub :new, api_response do
+          subject.must_equal 'Odeon Brighton'
         end
       end
     end
 
-    describe '#url' do
-      subject { described_class.new(71).url }
-
-      describe 'brighton' do
-        before { website.expect(:sitemap, sitemap_html) }
+    describe 'Leicester Square' do
+      let(:id) { 105 }
 
-        it 'returns the brand in the name' do
-          OdeonUk::Html::Website.stub :new, website do
-            subject.must_equal 'http://www.odeon.co.uk/cinemas/brighton/71/'
-          end
+      it 'returns cinema name' do
+        OdeonUk::Internal::ApiResponse.stub :new, api_response do
+          subject.must_equal 'Odeon Leicester Square'
         end
       end
     end
   end
 
-  describe 'with API parsing' do
-    include ApiFixturesHelper
+  describe '#locality' do
+    subject { described_class.new(id).locality }
+    describe 'Short Address (Brighton)' do
+      let(:id) { 71 }
 
-    before do
-      OdeonUk.configure do |config|
-        config.method = :api
-      end
-    end
-
-    after do
-      OdeonUk.configure do |config|
-        config.method = :html
-      end
-    end
-
-    let(:response) { Minitest::Mock.new }
-
-    describe '.all' do
-      subject { described_class.all }
-
-      before do
-        response.expect(:all_cinemas, parse(all_cinemas_plist))
-      end
-
-      it 'returns an Array of OdeonUk::Cinemas' do
-        OdeonUk::Api::Response.stub :new, response do
-          subject.must_be_instance_of(Array)
-          subject.each do |value|
-            value.must_be_instance_of(described_class)
-          end
-        end
-      end
-
-      it 'returns the correctly sized array' do
-        OdeonUk::Api::Response.stub :new, response do
-          subject.size.must_equal 115
-        end
-      end
-    end
-
-    describe '.new(id)' do
-      subject { described_class.new(id) }
-
-      describe 'Brighton' do
-        let(:id) { 71 }
-
-        before do
-          response.expect(:all_cinemas, parse(all_cinemas_plist))
-        end
-
-        it 'returns a cinema' do
-          OdeonUk::Api::Response.stub :new, response do
-            subject.must_be_instance_of(described_class)
-
-            subject.id.must_equal 71
-            subject.brand.must_equal 'Odeon'
-            subject.name.must_equal 'Brighton'
-            subject.slug.must_equal 'odeon-brighton'
-            subject.url.must_equal 'http://www.odeon.co.uk/cinemas/brighton/71/'
-          end
-        end
-      end
-    end
-
-    describe '#adr' do
-      subject { described_class.new(71).adr }
-
-      describe '(brighton)' do
-        before { response.expect(:all_cinemas, parse(all_cinemas_plist)) }
-
-        it 'returns the address hash' do
-          OdeonUk::Api::Response.stub :new, response do
-            subject.must_equal(
-              street_address: 'Kingswest',
-              locality:       'Brighton',
-              postal_code:    'BN1 2RE',
-              country_name:   'United Kingdom'
-            )
-          end
+      it 'returns town name' do
+        OdeonUk::Internal::ApiResponse.stub :new, api_response do
+          subject.must_equal 'Brighton'
         end
       end
     end
+  end
 
-    describe '#brand' do
-      subject { described_class.new(id).brand }
-
-      describe 'cinema name with London' do
-        let(:id) { 105 }
+  describe '#name' do
+    subject { described_class.new(id).name }
+    describe 'Brighton' do
+      let(:id) { 71 }
 
-        it 'removes "London" name prefix' do
-          subject.must_equal 'Odeon'
+      it 'returns cinema name' do
+        OdeonUk::Internal::ApiResponse.stub :new, api_response do
+          subject.must_equal 'Brighton'
         end
       end
     end
 
-    describe '#full_name' do
-      subject { described_class.new(71).full_name }
+    describe 'Leicester Square' do
+      let(:id) { 105 }
 
-      describe 'simple name (brighton)' do
-        before { response.expect(:all_cinemas, parse(all_cinemas_plist)) }
-
-        it 'returns the brand in the name' do
-          OdeonUk::Api::Response.stub :new, response do
-            subject.must_equal 'Odeon Brighton'
-          end
+      it 'returns cinema name' do
+        OdeonUk::Internal::ApiResponse.stub :new, api_response do
+          subject.must_equal 'Leicester Square'
         end
       end
     end
+  end
 
-    describe '#locality' do
-      subject { described_class.new(71).locality }
-
-      before { response.expect(:all_cinemas, parse(all_cinemas_plist)) }
+  describe '#postal_code' do
+    subject { described_class.new(id).postal_code }
+    describe 'short address' do
+      let(:id) { 71 }
 
-      it 'returns town name' do
-        OdeonUk::Api::Response.stub :new, response do
-          subject.must_equal 'Brighton'
+      it 'returns the postcode' do
+        OdeonUk::Internal::ApiResponse.stub :new, api_response do
+          subject.must_equal 'BN1 2RE'
         end
       end
     end
 
-    describe '#name' do
-      subject { described_class.new(id).name }
-
-      before { response.expect(:all_cinemas, parse(all_cinemas_plist)) }
+    describe 'short address (London)' do
+      let(:id) { 211 }
 
-      describe 'cinema name with London' do
-        let(:id) { 105 }
-
-        it 'removes "London" name prefix' do
-          OdeonUk::Api::Response.stub :new, response do
-            subject.must_equal 'Leicester Square'
-          end
-        end
-      end
-
-      describe 'cinema name with dashes' do
-        let(:id) { 208 }
-
-        it 'removes " - " and replaces it with a colon ": "' do
-          OdeonUk::Api::Response.stub :new, response do
-            subject.must_equal 'Whiteleys: The Lounge'
-          end
+      it 'returns the postcode' do
+        OdeonUk::Internal::ApiResponse.stub :new, api_response do
+          subject.must_equal 'SE1 8XR'
         end
       end
     end
 
-    describe '#postal_code' do
-      subject { described_class.new(id).postal_code }
-
-      describe 'short address' do
-        let(:id) { 71 }
-
-        before { response.expect(:all_cinemas, parse(all_cinemas_plist)) }
+    describe 'short address (extra London Postcode)' do
+      let(:id) { 105 }
 
-        it 'returns the postcode' do
-          OdeonUk::Api::Response.stub :new, response do
-            subject.must_equal 'BN1 2RE'
-          end
-        end
-      end
-
-      describe 'short address (London)' do
-        let(:id) { 211 }
-
-        before { response.expect(:all_cinemas, parse(all_cinemas_plist)) }
-
-        it 'returns the postcode' do
-          OdeonUk::Api::Response.stub :new, response do
-            subject.must_equal 'SE1 8XR'
-          end
-        end
-      end
-
-      describe 'short address (extra London Postcode)' do
-        let(:id) { 105 }
-
-        before { response.expect(:all_cinemas, parse(all_cinemas_plist)) }
-
-        it 'returns the postcode' do
-          OdeonUk::Api::Response.stub :new, response do
-            subject.must_equal 'WC2H 7LQ'
-          end
+      it 'returns the postcode' do
+        OdeonUk::Internal::ApiResponse.stub :new, api_response do
+          subject.must_equal 'WC2H 7JY'
         end
       end
     end
+  end
 
-    describe '#screenings' do
-      subject { described_class.new(71).screenings }
+  describe '#region' do
+    subject { described_class.new(id).region }
+    describe 'short address' do
+      let(:id) { 71 }
 
-      it 'calls out to Screening object' do
-        OdeonUk::Screening.stub :at, [:screening] do
-          subject.must_equal([:screening])
+      it 'returns the postcode' do
+        OdeonUk::Internal::ApiResponse.stub :new, api_response do
+          subject.must_equal ''
         end
       end
     end
+  end
 
-    describe '#slug' do
-      subject { described_class.new(71).slug }
+  describe '#slug' do
+    subject { described_class.new(id).slug }
 
-      describe 'simple name (brighton)' do
-        before { response.expect(:all_cinemas, parse(all_cinemas_plist)) }
+    describe 'short address' do
+      let(:id) { 71 }
 
-        it 'returns the brand in the name' do
-          OdeonUk::Api::Response.stub :new, response do
-            subject.must_equal 'odeon-brighton'
-          end
+      it 'returns first line of address' do
+        OdeonUk::Internal::ApiResponse.stub :new, api_response do
+          subject.must_equal 'odeon-brighton'
         end
       end
     end
+  end
 
-    describe '#street_address' do
-      subject { described_class.new(id).street_address }
-
-      describe 'short address' do
-        let(:id) { 71 }
+  describe '#street_address' do
+    subject { described_class.new(id).street_address }
 
-        before { response.expect(:all_cinemas, parse(all_cinemas_plist)) }
+    describe 'short address' do
+      let(:id) { 71 }
 
-        it 'returns first line of address' do
-          OdeonUk::Api::Response.stub :new, response do
-            subject.must_equal 'Kingswest'
-          end
+      it 'returns first line of address' do
+        OdeonUk::Internal::ApiResponse.stub :new, api_response do
+          subject.must_equal 'Kingswest'
         end
       end
     end
+  end
 
-    describe '#url' do
-      subject { described_class.new(71).url }
+  describe '#url' do
+    subject { described_class.new(id).url }
 
-      describe 'brighton' do
-        before { response.expect(:all_cinemas, parse(all_cinemas_plist)) }
+    describe 'short address' do
+      let(:id) { 71 }
 
-        it 'returns the brand in the name' do
-          OdeonUk::Api::Response.stub :new, response do
-            subject.must_equal 'http://www.odeon.co.uk/cinemas/brighton/71/'
-          end
+      it 'returns first line of address' do
+        OdeonUk::Internal::ApiResponse.stub :new, api_response do
+          subject.must_equal 'http://www.odeon.co.uk/cinemas/brighton/71/'
         end
       end
     end