odeon_uk 2.0.4 → 3.0.0

data/test/lib/odeon_uk/html/cinema_test.rb

@@ -0,0 +1,149 @@
+require_relative '../../../test_helper'
+
+describe OdeonUk::Html::Cinema do
+  include WebsiteFixturesHelper
+
+  let(:described_class) { OdeonUk::Html::Cinema }
+
+  let(:website) { Minitest::Mock.new }
+
+  before do
+    WebMock.disable_net_connect!
+  end
+
+  describe '.ids' do
+    subject { described_class.ids }
+
+    before do
+      website.expect(:sitemap, sitemap_html)
+    end
+
+    it 'returns an Array of OdeonUk::Html::Cinemas' do
+      OdeonUk::Html::Website.stub :new, website do
+        subject.must_be_instance_of(Array)
+        subject.each do |value|
+          value.must_be_instance_of(Fixnum)
+        end
+      end
+    end
+
+    it 'returns the correctly sized array' do
+      OdeonUk::Html::Website.stub :new, website do
+        subject.size.must_equal 115
+      end
+    end
+  end
+
+  describe '.new(id)' do
+    subject { described_class.new(id) }
+
+    describe 'Brighton' do
+      let(:id) { 71 }
+
+      it 'returns a cinema' do
+        subject.must_be_instance_of(described_class)
+        subject.id.must_equal(id)
+      end
+    end
+  end
+
+  describe '#name' do
+    subject { described_class.new(id).name }
+
+    before { website.expect(:sitemap, sitemap_html) }
+
+    describe 'Brighton' do
+      let(:id) { 71 }
+
+      it 'returns cinema name' do
+        OdeonUk::Html::Website.stub :new, website do
+          subject.must_equal 'Brighton'
+        end
+      end
+    end
+
+    describe 'Leicester Square' do
+      let(:id) { 105 }
+
+      it 'returns cinema name' do
+        OdeonUk::Html::Website.stub :new, website do
+          subject.must_equal 'London - Leicester Square'
+        end
+      end
+    end
+  end
+
+  describe '#locality' do
+    subject { described_class.new(id).locality }
+
+    before { website.expect(:sitemap, sitemap_html) }
+
+    describe 'Short Address (Brighton)' do
+      let(:id) { 71 }
+
+      before { website.expect(:cinema, cinema_html(71), [71]) }
+
+      it 'returns town name' do
+        OdeonUk::Html::Website.stub :new, website do
+          subject.must_equal 'Brighton'
+        end
+      end
+    end
+  end
+
+  describe '#postal_code' do
+    subject { described_class.new(id).postal_code }
+
+    describe 'short address' do
+      let(:id) { 71 }
+
+      before { website.expect(:cinema, cinema_html(71), [71]) }
+
+      it 'returns the postcode' do
+        OdeonUk::Html::Website.stub :new, website do
+          subject.must_equal 'BN1 2RE'
+        end
+      end
+    end
+
+    describe 'short address (London)' do
+      let(:id) { 211 }
+
+      before { website.expect(:cinema, cinema_html(211), [211]) }
+
+      it 'returns the postcode' do
+        OdeonUk::Html::Website.stub :new, website do
+          subject.must_equal 'SE1 8XR'
+        end
+      end
+    end
+
+    describe 'short address (extra London Postcode)' do
+      let(:id) { 105 }
+
+      before { website.expect(:cinema, cinema_html(105), [105]) }
+
+      it 'returns the postcode' do
+        OdeonUk::Html::Website.stub :new, website do
+          subject.must_equal 'WC2H 7LQ'
+        end
+      end
+    end
+  end
+
+  describe '#street_address' do
+    subject { described_class.new(id).street_address }
+
+    describe 'short address' do
+      let(:id) { 71 }
+
+      before { website.expect(:cinema, cinema_html(71), [71]) }
+
+      it 'returns first line of address' do
+        OdeonUk::Html::Website.stub :new, website do
+          subject.must_equal 'Kingswest'
+        end
+      end
+    end
+  end
+end

data/test/lib/odeon_uk/{internal/film_with_screenings_parser_test.rb → html/parser/film_with_screenings_test.rb}

@@ -1,24 +1,18 @@
-require_relative '../../../test_helper'
+require_relative '../../../../test_helper'
 
-describe OdeonUk::Internal::FilmWithScreeningsParser do
-  let(:described_class) { OdeonUk::Internal::FilmWithScreeningsParser }
+describe OdeonUk::Html::Parser::FilmWithScreenings do
+  include WebsiteFixturesHelper
+
+  let(:described_class) { OdeonUk::Html::Parser::FilmWithScreenings }
 
   describe '#film_name' do
     subject { described_class.new(film_html).film_name }
 
-    describe 'passed first film html' do
-      let(:film_html) { read_film_html('brighton/film_first') }
-
-      it 'returns film name' do
-        subject.must_equal 'A Most Wanted Man'
-      end
-    end
-
-    describe 'passed last film html' do
-      let(:film_html) { read_film_html('brighton/film_last') }
+    describe 'passed film html' do
+      let(:film_html) { showtimes_html('71-0') }
 
       it 'returns film name' do
-        subject.must_equal 'The Riot Club'
+        subject.must_equal 'Home'
       end
     end
   end
@@ -26,8 +20,8 @@ describe OdeonUk::Internal::FilmWithScreeningsParser do
   describe '#to_a' do
     subject { described_class.new(film_html).to_a }
 
-    describe 'passed first film html' do
-      let(:film_html) { read_film_html('brighton/film_first') }
+    describe 'passed film html' do
+      let(:film_html) { showtimes_html('71-0') }
 
       it 'returns an array of hashes of screening attributes' do
         subject.must_be_instance_of Array
@@ -47,32 +41,13 @@ describe OdeonUk::Internal::FilmWithScreeningsParser do
         end
       end
 
-      it 'returns the correct number of screenings' do
-        subject.count.must_equal 10
-      end
-    end
-
-    describe 'passed last film html' do
-      let(:film_html) { read_film_html('brighton/film_last') }
-
-      it 'returns an array of hashes of screening attributes' do
-        subject.must_be_instance_of Array
-        subject.each do |hash|
-          hash[:booking_url].must_match 'https://www.odeon.co.uk/'
-          hash[:dimension].must_match(/[23]d/)
-          hash[:film_name].must_be_instance_of String
-          hash[:time].must_be_instance_of Time
-          hash[:time].zone.must_equal 'UTC'
-        end
-      end
-
       it 'returns at least 1' do
         subject.count.must_be :>=, 1
       end
     end
 
     describe 'passed imax film html' do
-      let(:film_html) { read_film_html('manchester/film_first_imax') }
+      let(:film_html) { showtimes_html('11-imax') }
 
       it 'returns an array of hashes of screening attributes' do
         subject.must_be_instance_of Array
@@ -96,7 +71,7 @@ describe OdeonUk::Internal::FilmWithScreeningsParser do
     end
 
     describe 'passed d-box film html' do
-      let(:film_html) { read_film_html('liverpool_one/film_first_dbox') }
+      let(:film_html) { showtimes_html('171-d-box') }
 
       it 'returns an array of hashes of screening attributes' do
         subject.must_be_instance_of Array
@@ -119,9 +94,4 @@ describe OdeonUk::Internal::FilmWithScreeningsParser do
       end
     end
   end
-
-  def read_film_html(filename)
-    path = '../../../../fixtures/showtimes'
-    File.read(File.expand_path("#{path}/#{filename}.html", __FILE__))
-  end
 end

data/test/lib/odeon_uk/html/screenings_test.rb

@@ -0,0 +1,43 @@
+require_relative '../../../test_helper'
+
+describe OdeonUk::Html::Screenings do
+  include WebsiteFixturesHelper
+
+  let(:described_class) { OdeonUk::Html::Screenings }
+
+  let(:website) { Minitest::Mock.new }
+
+  before { WebMock.disable_net_connect! }
+
+  describe '.at(cinema_id)' do
+    subject { described_class.at(71) }
+
+    before do
+      website.expect(:showtimes, showtimes_html(71), [71])
+    end
+
+    it 'returns an array of screening attributes as hashes' do
+      OdeonUk::Html::Website.stub :new, website do
+        subject.must_be_instance_of(Array)
+        subject.each do |screening|
+          screening.must_be_instance_of(Hash)
+          screening.keys.must_include(:film_name)
+
+          screening.keys.must_include(:time)
+          screening[:time].must_be_instance_of(Time)
+
+          screening.keys.must_include(:variant)
+
+          screening.keys.must_include(:dimension)
+          screening[:dimension].must_match(/[23]d/)
+        end
+      end
+    end
+
+    it 'returns correct number of screenings' do
+      OdeonUk::Html::Website.stub :new, website do
+        subject.count.must_equal 212
+      end
+    end
+  end
+end

data/test/lib/odeon_uk/html/website_test.rb

@@ -0,0 +1,37 @@
+require_relative '../../../test_helper'
+
+describe OdeonUk::Html::Website do
+  include WebsiteFixturesHelper
+
+  let(:described_class) { OdeonUk::Html::Website }
+
+  describe '#cinema(id)' do
+    subject { described_class.new.cinema(71) }
+
+    before { stub_get('cinemas/odeon/71/', cinema_html(71)) }
+
+    it 'returns a string' do
+      subject.class.must_equal String
+    end
+  end
+
+  describe '#sitemap' do
+    subject { described_class.new.sitemap }
+
+    before { stub_get('sitemap/', sitemap_html) }
+
+    it 'returns a string' do
+      subject.class.must_equal String
+    end
+  end
+
+  describe '#showtimes(id)' do
+    subject { described_class.new.showtimes(71) }
+
+    before { stub_get('showtimes/week/71/?siteId=71', showtimes_html(71)) }
+
+    it 'returns a string' do
+      subject.class.must_equal String
+    end
+  end
+end

data/test/lib/odeon_uk/screening_test.rb

@@ -1,109 +1,43 @@
 require_relative '../../test_helper'
 
 describe OdeonUk::Screening do
+  include WebsiteFixturesHelper
+
   let(:described_class) { OdeonUk::Screening }
 
   let(:website) { Minitest::Mock.new }
 
-  before { WebMock.disable_net_connect! }
+  before do
+    WebMock.disable_net_connect!
+  end
 
   describe '.at(cinema_id)' do
     subject { described_class.at(71) }
 
     before do
-      website.expect(:showtimes, brighton_showtimes_html, [71])
-      website.expect(:sitemap, sitemap_html)
+      website.expect(:cinema, cinema_html(71), [71])
+      website.expect(:showtimes, showtimes_html(71), [71])
     end
 
-    it 'returns an array of screenings' do
-      OdeonUk::Internal::Website.stub :new, website do
+    it 'returns an array of screening attributes as hashes' do
+      OdeonUk::Html::Website.stub :new, website do
         subject.must_be_instance_of(Array)
         subject.each do |screening|
           screening.must_be_instance_of(described_class)
+          screening.cinema_name.must_equal('Brighton')
+          screening.cinema_id.must_equal(71)
+          screening.film_name.wont_be_nil
+          screening.showing_at.must_be_instance_of(Time)
+          screening.showing_on.must_be_instance_of(Date)
+          screening.dimension.must_match(/[23]d/)
         end
       end
     end
 
     it 'returns correct number of screenings' do
-      OdeonUk::Internal::Website.stub :new, website do
-        subject.count.must_equal 214
+      OdeonUk::Html::Website.stub :new, website do
+        subject.count.must_equal 212
       end
     end
   end
-
-  describe '#showing_on' do
-    subject { described_class.new(options).showing_on }
-
-    let(:options) do
-      {
-        film_name:   'Guardians of the Galaxy',
-        cinema_id:   71,
-        cinema_name: 'Odeon Brighton',
-        time:        Time.utc(2014, 9, 12, 11, 0),
-      }
-    end
-
-    it 'should return date of screening' do
-      subject.must_be_instance_of(Date)
-      subject.must_equal Date.new(2014, 9, 12)
-    end
-  end
-
-  describe '#variant' do
-    subject { described_class.new(options).variant }
-
-    describe 'passed array' do
-      let(:options) do
-        {
-          film_name:   'Guardians of the Galaxy',
-          cinema_id:   71,
-          cinema_name: 'Odeon Brighton',
-          time:        Time.utc(2014, 9, 12, 11, 0),
-          variant:     %w(Kids BABY)
-        }
-      end
-
-      it 'is an alphabetically ordered array of lower-cased strings' do
-        subject.must_be_instance_of Array
-        subject.each do |tag|
-          tag.must_be_instance_of String
-        end
-        subject.must_equal %w(baby kids)
-      end
-    end
-
-    describe 'passed string' do
-      let(:options) do
-        {
-          film_name:   'Guardians of the Galaxy',
-          cinema_id:   71,
-          cinema_name: 'Odeon Brighton',
-          time:        Time.utc(2014, 9, 12, 11, 0),
-          variant:     'Kids BABY'
-        }
-      end
-
-      it 'is an alphabetically ordered array of lower-cased strings' do
-        subject.must_be_instance_of Array
-        subject.each do |tag|
-          tag.must_be_instance_of String
-        end
-        subject.must_equal %w(baby kids)
-      end
-    end
-  end
-
-  private
-
-  def brighton_showtimes_html
-    read_file('../../../fixtures/showtimes/brighton.html')
-  end
-
-  def read_file(filepath)
-    File.read(File.expand_path(filepath, __FILE__))
-  end
-
-  def sitemap_html
-    read_file('../../../fixtures/sitemap.html')
-  end
 end

data/test/support/api_fixtures_helper.rb

@@ -0,0 +1,34 @@
+module ApiFixturesHelper
+  private
+
+  def all_cinemas_plist
+    read_fixture('api/all_cinemas')
+  end
+
+  def app_init_plist
+    read_fixture('api/app_init')
+  end
+
+  def film_times_plist(cinema_id, film_id)
+    read_fixture("api/film_times/#{cinema_id}-#{film_id}")
+  end
+
+  def film_times_plists(cinema_id)
+    listing = Dir.entries(File.expand_path('../../fixtures/api/film_times', __FILE__))
+    listing.reject { |filename| !filename.match(/\A#{cinema_id}-/) }
+  end
+
+  def parse(content)
+    CFPropertyList.native_types(CFPropertyList::List.new(data: content).value)
+  end
+
+  def read_fixture(filepath)
+    File.read(File.expand_path("../../fixtures/#{filepath}.plist", __FILE__))
+  end
+
+  def stub_post(site_path, request_body, response_body)
+    url      = "https://api.odeon.co.uk/2.1/api/#{site_path}"
+    response = { status: 200, body: response_body, headers: {} }
+    stub_request(:post, url).with(body: request_body).to_return(response)
+  end
+end

data/test/support/website_fixtures_helper.rb

@@ -0,0 +1,25 @@
+module WebsiteFixturesHelper
+  private
+
+  def cinema_html(id)
+    read_fixture("html/cinema/#{id}")
+  end
+
+  def showtimes_html(id, i = nil)
+    read_fixture("html/showtimes/#{id}#{ "-#{i}" if i }")
+  end
+
+  def sitemap_html
+    read_fixture('html/sitemap')
+  end
+
+  def read_fixture(filepath)
+    File.read(File.expand_path("../../fixtures/#{filepath}.html", __FILE__))
+  end
+
+  def stub_get(site_path, response_body)
+    url      = "http://www.odeon.co.uk/#{site_path}"
+    response = { status: 200, body: response_body, headers: {} }
+    stub_request(:get, url).to_return(response)
+  end
+end

data/test/test_helper.rb

@@ -1,6 +1,11 @@
 require 'minitest/autorun'
-require 'minitest/pride'
+require 'minitest/reporters'
+reporter_options = { color: true, slow_count: 5 }
+Minitest::Reporters.use! [Minitest::Reporters::DefaultReporter.new(reporter_options)]
 
 require 'webmock/minitest'
 
-require File.expand_path('../../lib/odeon_uk.rb', __FILE__)
+require File.expand_path('../../lib/odeon_uk.rb', __FILE__)
+
+require_relative 'support/api_fixtures_helper'
+require_relative 'support/website_fixtures_helper'