odeon_uk 2.0.4 → 3.0.0

data/test/lib/odeon_uk/cinema_test.rb

@@ -3,254 +3,479 @@ require_relative '../../test_helper'
 describe OdeonUk::Cinema do
   let(:described_class) { OdeonUk::Cinema }
 
-  let(:website) { Minitest::Mock.new }
-
   before do
     WebMock.disable_net_connect!
   end
 
-  describe '.all' do
-    subject { described_class.all }
+  describe 'with HTML parsing' do
+    include WebsiteFixturesHelper
 
-    before do
-      website.expect(:sitemap, sitemap_html)
+    let(:website) { Minitest::Mock.new }
+
+    describe '.all' do
+      subject { described_class.all }
+
+      before do
+        website.expect(:sitemap, sitemap_html)
+      end
+
+      it 'returns an Array of OdeonUk::Cinemas' do
+        OdeonUk::Html::Website.stub :new, website do
+          subject.must_be_instance_of(Array)
+          subject.each do |value|
+            value.must_be_instance_of(described_class)
+          end
+        end
+      end
+
+      it 'returns the correctly sized array' do
+        OdeonUk::Html::Website.stub :new, website do
+          subject.size.must_equal 115
+        end
+      end
     end
 
-    it 'returns an Array of OdeonUk::Cinemas' do
-      OdeonUk::Internal::Website.stub :new, website do
-        subject.must_be_instance_of(Array)
-        subject.each do |value|
-          value.must_be_instance_of(described_class)
+    describe '.new(id)' do
+      subject { described_class.new(id) }
+
+      describe 'Brighton' do
+        let(:id) { 71 }
+
+        before do
+          website.expect(:sitemap, sitemap_html)
+        end
+
+        it 'returns a cinema' do
+          OdeonUk::Html::Website.stub :new, website do
+            subject.must_be_instance_of(described_class)
+
+            subject.id.must_equal 71
+            subject.brand.must_equal 'Odeon'
+            subject.name.must_equal 'Brighton'
+            subject.slug.must_equal 'odeon-brighton'
+            subject.url.must_equal 'http://www.odeon.co.uk/cinemas/brighton/71/'
+          end
         end
       end
     end
 
-    it 'returns the correctly sized array' do
-      OdeonUk::Internal::Website.stub :new, website do
-        subject.size.must_equal 115
+    describe '#adr' do
+      subject { described_class.new(71).adr }
+
+      describe '(brighton)' do
+        before { website.expect(:cinema, cinema_html(71), [71]) }
+
+        it 'returns the address hash' do
+          OdeonUk::Html::Website.stub :new, website do
+            subject.must_equal(
+              street_address: 'Kingswest',
+              locality:       'Brighton',
+              postal_code:    'BN1 2RE',
+              country_name:   'United Kingdom'
+            )
+          end
+        end
       end
     end
-  end
 
-  describe '.find(id)' do
-    subject { described_class.find(id) }
+    describe '#brand' do
+      subject { described_class.new(id).brand }
 
-    describe 'Brighton' do
-      let(:id) { 71 }
+      describe 'cinema name with London' do
+        let(:id) { 105 }
 
-      before do
-        website.expect(:sitemap, sitemap_html)
-        # website.expect(:cinemas, cinema_html('brighton'), [71])
+        it 'removes "London" name prefix' do
+          subject.must_equal 'Odeon'
+        end
       end
+    end
 
-      it 'returns a cinema' do
-        OdeonUk::Internal::Website.stub :new, website do
-          subject.must_be_instance_of(described_class)
+    describe '#full_name' do
+      subject { described_class.new(71).full_name }
 
-          subject.id.must_equal 71
-          subject.brand.must_equal 'Odeon'
-          subject.name.must_equal 'Brighton'
-          subject.slug.must_equal 'brighton'
-          subject.url.must_equal 'http://www.odeon.co.uk/cinemas/brighton/71/'
+      describe 'simple name (brighton)' do
+        before { website.expect(:sitemap, sitemap_html) }
+
+        it 'returns the brand in the name' do
+          OdeonUk::Html::Website.stub :new, website do
+            subject.must_equal 'Odeon Brighton'
+          end
         end
       end
     end
-  end
 
-  describe '.new' do
-    it 'removes "London" name prefix' do
-      cinema = OdeonUk::Cinema.new 79, 'London - Leicester Square', '/cinemas/london_leicester_square/105/'
-      cinema.id.must_equal 79
-      cinema.name.must_equal 'Leicester Square'
-      cinema.slug.must_equal 'leicester-square'
+    describe '#locality' do
+      subject { described_class.new(71).locality }
+
+      before { website.expect(:cinema, cinema_html(71), [71]) }
+
+      it 'returns town name' do
+        OdeonUk::Html::Website.stub :new, website do
+          subject.must_equal 'Brighton'
+        end
+      end
     end
 
-    it 'removes " - " and replaces it with a colon ": "' do
-      cinema = OdeonUk::Cinema.new 208, 'Whiteleys - The Lounge', '/cinemas/whiteleys_the_lounge/208/'
-      cinema.id.must_equal 208
-      cinema.name.must_equal 'Whiteleys: The Lounge'
-      cinema.slug.must_equal 'whiteleys-the-lounge'
+    describe '#name' do
+      subject { described_class.new(id).name }
+
+      before { website.expect(:sitemap, sitemap_html) }
+
+      describe 'cinema name with London' do
+        let(:id) { 105 }
+
+        it 'removes "London" name prefix' do
+          OdeonUk::Html::Website.stub :new, website do
+            subject.must_equal 'Leicester Square'
+          end
+        end
+      end
+
+      describe 'cinema name with dashes' do
+        let(:id) { 208 }
+
+        it 'removes " - " and replaces it with a colon ": "' do
+          OdeonUk::Html::Website.stub :new, website do
+            subject.must_equal 'Whiteleys: The Lounge'
+          end
+        end
+      end
     end
-  end
 
-  describe '#adr' do
-    subject { cinema.adr }
+    describe '#postal_code' do
+      subject { described_class.new(id).postal_code }
+
+      describe 'short address' do
+        let(:id) { 71 }
 
-    describe '(brighton)' do
-      let(:cinema) do
-        described_class.new(71, 'Brighton', '/cinemas/brighton/71/')
+        before { website.expect(:cinema, cinema_html(71), [71]) }
+
+        it 'returns the postcode' do
+          OdeonUk::Html::Website.stub :new, website do
+            subject.must_equal 'BN1 2RE'
+          end
+        end
       end
 
-      before do
-        website.expect(:cinema, cinema_html('brighton'), [71])
+      describe 'short address (London)' do
+        let(:id) { 211 }
+
+        before { website.expect(:cinema, cinema_html(211), [211]) }
+
+        it 'returns the postcode' do
+          OdeonUk::Html::Website.stub :new, website do
+            subject.must_equal 'SE1 8XR'
+          end
+        end
       end
 
-      it 'returns the address hash' do
-        OdeonUk::Internal::Website.stub :new, website do
-          subject.must_equal(
-            street_address: 'Kingswest',
-            locality: 'Brighton',
-            postal_code: 'BN1 2RE',
-            country: 'United Kingdom'
-          )
+      describe 'short address (extra London Postcode)' do
+        let(:id) { 105 }
+
+        before { website.expect(:cinema, cinema_html(105), [105]) }
+
+        it 'returns the postcode' do
+          OdeonUk::Html::Website.stub :new, website do
+            subject.must_equal 'WC2H 7LQ'
+          end
         end
       end
     end
-  end
 
-  describe '#films' do
-    subject { cinema.films }
+    describe '#screenings' do
+      subject { described_class.new(71).screenings }
 
-    let(:cinema) do
-      described_class.new(71, 'Brighton', '/cinemas/brighton/71/')
+      it 'calls out to Screening object' do
+        OdeonUk::Screening.stub :at, [:screening] do
+          subject.must_equal([:screening])
+        end
+      end
     end
 
-    it 'calls out to Screening object' do
-      OdeonUk::Film.stub :at, [:film] do
-        subject.must_equal([:film])
+    describe '#slug' do
+      subject { described_class.new(71).slug }
+
+      describe 'simple name (brighton)' do
+        before { website.expect(:sitemap, sitemap_html) }
+
+        it 'returns the brand in the name' do
+          OdeonUk::Html::Website.stub :new, website do
+            subject.must_equal 'odeon-brighton'
+          end
+        end
       end
     end
-  end
 
-  describe '#full_name' do
-    subject { cinema.full_name }
+    describe '#street_address' do
+      subject { described_class.new(id).street_address }
 
-    describe 'simple name (brighton)' do
-      let(:cinema) do
-        OdeonUk::Cinema.new('71', 'Brighton', '/cinemas/brighton/71/')
-      end
+      describe 'short address' do
+        let(:id) { 71 }
 
-      before do
-        website.expect(:cinema, cinema_html('brighton'), [71])
+        before { website.expect(:cinema, cinema_html(71), [71]) }
+
+        it 'returns first line of address' do
+          OdeonUk::Html::Website.stub :new, website do
+            subject.must_equal 'Kingswest'
+          end
+        end
       end
+    end
 
-      it 'returns the brand in the name' do
-        OdeonUk::Internal::Website.stub :new, website do
-          subject.must_equal 'Odeon Brighton'
+    describe '#url' do
+      subject { described_class.new(71).url }
+
+      describe 'brighton' do
+        before { website.expect(:sitemap, sitemap_html) }
+
+        it 'returns the brand in the name' do
+          OdeonUk::Html::Website.stub :new, website do
+            subject.must_equal 'http://www.odeon.co.uk/cinemas/brighton/71/'
+          end
         end
       end
     end
   end
 
-  describe '#locality' do
-    subject { cinema.locality }
+  describe 'with API parsing' do
+    include ApiFixturesHelper
+
+    before do
+      OdeonUk.configure do |config|
+        config.method = :api
+      end
+    end
 
-    describe 'short address' do
-      let(:cinema) do
-        OdeonUk::Cinema.new('71', 'Brighton', '/cinemas/brighton/71/')
+    after do
+      OdeonUk.configure do |config|
+        config.method = :html
       end
+    end
+
+    let(:response) { Minitest::Mock.new }
+
+    describe '.all' do
+      subject { described_class.all }
 
       before do
-        website.expect(:cinema, cinema_html('brighton'), [71])
+        response.expect(:all_cinemas, parse(all_cinemas_plist))
       end
 
-      it 'returns town name' do
-        OdeonUk::Internal::Website.stub :new, website do
-          subject.must_equal 'Brighton'
+      it 'returns an Array of OdeonUk::Cinemas' do
+        OdeonUk::Api::Response.stub :new, response do
+          subject.must_be_instance_of(Array)
+          subject.each do |value|
+            value.must_be_instance_of(described_class)
+          end
+        end
+      end
+
+      it 'returns the correctly sized array' do
+        OdeonUk::Api::Response.stub :new, response do
+          subject.size.must_equal 115
         end
       end
     end
-  end
 
-  describe '#postal_code' do
-    subject { cinema.postal_code }
+    describe '.new(id)' do
+      subject { described_class.new(id) }
+
+      describe 'Brighton' do
+        let(:id) { 71 }
+
+        before do
+          response.expect(:all_cinemas, parse(all_cinemas_plist))
+        end
+
+        it 'returns a cinema' do
+          OdeonUk::Api::Response.stub :new, response do
+            subject.must_be_instance_of(described_class)
 
-    describe 'short address' do
-      let(:cinema) do
-        OdeonUk::Cinema.new('71', 'Brighton', '/cinemas/brighton/71/')
+            subject.id.must_equal 71
+            subject.brand.must_equal 'Odeon'
+            subject.name.must_equal 'Brighton'
+            subject.slug.must_equal 'odeon-brighton'
+            subject.url.must_be_nil
+          end
+        end
       end
+    end
 
-      before do
-        website.expect(:cinema, cinema_html('brighton'), [71])
+    describe '#adr' do
+      subject { described_class.new(71).adr }
+
+      describe '(brighton)' do
+        before { response.expect(:all_cinemas, parse(all_cinemas_plist)) }
+
+        it 'returns the address hash' do
+          OdeonUk::Api::Response.stub :new, response do
+            subject.must_equal(
+              street_address: 'Kingswest',
+              locality:       'Brighton',
+              postal_code:    'BN1 2RE',
+              country_name:   'United Kingdom'
+            )
+          end
+        end
       end
+    end
+
+    describe '#brand' do
+      subject { described_class.new(id).brand }
+
+      describe 'cinema name with London' do
+        let(:id) { 105 }
 
-      it 'returns the postcode' do
-        OdeonUk::Internal::Website.stub :new, website do
-          subject.must_equal 'BN1 2RE'
+        it 'removes "London" name prefix' do
+          subject.must_equal 'Odeon'
         end
       end
     end
 
-    describe 'short address (London)' do
-      let(:cinema) do
-        OdeonUk::Cinema.new('211', 'BFI Imax', '/cinemas/bfi_imax/211/')
+    describe '#full_name' do
+      subject { described_class.new(71).full_name }
+
+      describe 'simple name (brighton)' do
+        before { response.expect(:all_cinemas, parse(all_cinemas_plist)) }
+
+        it 'returns the brand in the name' do
+          OdeonUk::Api::Response.stub :new, response do
+            subject.must_equal 'Odeon Brighton'
+          end
+        end
       end
+    end
 
-      before do
-        website.expect(:cinema, cinema_html('bfi_imax'), [211])
+    describe '#locality' do
+      subject { described_class.new(71).locality }
+
+      before { response.expect(:all_cinemas, parse(all_cinemas_plist)) }
+
+      it 'returns town name' do
+        OdeonUk::Api::Response.stub :new, response do
+          subject.must_equal 'Brighton'
+        end
       end
+    end
+
+    describe '#name' do
+      subject { described_class.new(id).name }
 
-      it 'returns the postcode' do
-        OdeonUk::Internal::Website.stub :new, website do
-          subject.must_equal 'SE1 8XR'
+      before { response.expect(:all_cinemas, parse(all_cinemas_plist)) }
+
+      describe 'cinema name with London' do
+        let(:id) { 105 }
+
+        it 'removes "London" name prefix' do
+          OdeonUk::Api::Response.stub :new, response do
+            subject.must_equal 'Leicester Square'
+          end
+        end
+      end
+
+      describe 'cinema name with dashes' do
+        let(:id) { 208 }
+
+        it 'removes " - " and replaces it with a colon ": "' do
+          OdeonUk::Api::Response.stub :new, response do
+            subject.must_equal 'Whiteleys: The Lounge'
+          end
         end
       end
     end
 
-    describe 'short address (extra London Postcode)' do
-      let(:cinema) do
-        OdeonUk::Cinema.new('105',
-                            'Leicester Square',
-                            '/cinemas/london_leicester_square/105/')
+    describe '#postal_code' do
+      subject { described_class.new(id).postal_code }
+
+      describe 'short address' do
+        let(:id) { 71 }
+
+        before { response.expect(:all_cinemas, parse(all_cinemas_plist)) }
+
+        it 'returns the postcode' do
+          OdeonUk::Api::Response.stub :new, response do
+            subject.must_equal 'BN1 2RE'
+          end
+        end
       end
 
-      before do
-        website.expect(:cinema, cinema_html('leicester_square'), [105])
+      describe 'short address (London)' do
+        let(:id) { 211 }
+
+        before { response.expect(:all_cinemas, parse(all_cinemas_plist)) }
+
+        it 'returns the postcode' do
+          OdeonUk::Api::Response.stub :new, response do
+            subject.must_equal 'SE1 8XR'
+          end
+        end
       end
 
-      it 'returns the postcode' do
-        OdeonUk::Internal::Website.stub :new, website do
-          subject.must_equal 'WC2H 7LQ'
+      describe 'short address (extra London Postcode)' do
+        let(:id) { 105 }
+
+        before { response.expect(:all_cinemas, parse(all_cinemas_plist)) }
+
+        it 'returns the postcode' do
+          OdeonUk::Api::Response.stub :new, response do
+            subject.must_equal 'WC2H 7LQ'
+          end
         end
       end
     end
-  end
 
-  describe '#screenings' do
-    subject { cinema.screenings }
+    describe '#screenings' do
+      subject { described_class.new(71).screenings }
 
-    let(:cinema) do
-      described_class.new(71, 'Brighton', '/cinemas/brighton/71/')
+      it 'calls out to Screening object' do
+        OdeonUk::Screening.stub :at, [:screening] do
+          subject.must_equal([:screening])
+        end
+      end
     end
 
-    it 'calls out to Screening object' do
-      OdeonUk::Screening.stub :at, [:screening] do
-        subject.must_equal([:screening])
+    describe '#slug' do
+      subject { described_class.new(71).slug }
+
+      describe 'simple name (brighton)' do
+        before { response.expect(:all_cinemas, parse(all_cinemas_plist)) }
+
+        it 'returns the brand in the name' do
+          OdeonUk::Api::Response.stub :new, response do
+            subject.must_equal 'odeon-brighton'
+          end
+        end
       end
     end
-  end
 
-  describe '#street_address' do
-    subject { cinema.street_address }
+    describe '#street_address' do
+      subject { described_class.new(id).street_address }
 
-    describe 'short address' do
-      let(:cinema) do
-        OdeonUk::Cinema.new('71', 'Brighton', '/cinemas/brighton/71/')
-      end
+      describe 'short address' do
+        let(:id) { 71 }
 
-      before do
-        website.expect(:cinema, cinema_html('brighton'), [71])
-      end
+        before { response.expect(:all_cinemas, parse(all_cinemas_plist)) }
 
-      it 'returns first line of address' do
-        OdeonUk::Internal::Website.stub :new, website do
-          subject.must_equal 'Kingswest'
+        it 'returns first line of address' do
+          OdeonUk::Api::Response.stub :new, response do
+            subject.must_equal 'Kingswest'
+          end
         end
       end
     end
-  end
 
-  private
-
-  def read_file(filepath)
-    File.read(File.expand_path(filepath, __FILE__))
-  end
+    describe '#url' do
+      subject { described_class.new(71).url }
 
-  def sitemap_html
-    read_file('../../../fixtures/sitemap.html')
-  end
+      describe 'brighton' do
+        before { response.expect(:all_cinemas, parse(all_cinemas_plist)) }
 
-  def cinema_html(filename)
-    read_file("../../../fixtures/cinema/#{filename}.html")
+        it 'returns the brand in the name' do
+          OdeonUk::Api::Response.stub :new, response do
+            subject.must_be_nil
+          end
+        end
+      end
+    end
   end
 end

data/test/lib/odeon_uk/configuration_test.rb

@@ -0,0 +1,29 @@
+require_relative '../../test_helper'
+
+describe OdeonUk do
+  describe '.configuration' do
+    describe '.method' do
+      it 'sets default value' do
+        OdeonUk.configuration.method.must_equal(:html)
+      end
+    end
+  end
+
+  describe '.configure' do
+    before do
+      OdeonUk.configure do |config|
+        config.method = :api
+      end
+    end
+
+    after do
+      OdeonUk.configure do |config|
+        config.method = :html
+      end
+    end
+
+    it 'sets the small words for the gem to downcase' do
+      OdeonUk.configuration.method.must_equal(:api)
+    end
+  end
+end