oddb2xml 2.7.1 → 2.7.5

data/spec/spec_helper.rb

@@ -5,125 +5,125 @@
 #
 # See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
 #
-$:.unshift File.join(File.dirname(__FILE__), '..', 'lib')
+$:.unshift File.join(File.dirname(__FILE__), "..", "lib")
 $:.unshift File.dirname(__FILE__)
 
-require 'rspec'
-require 'webmock/rspec'
-require 'flexmock/rspec'
-require 'pp'
+require "rspec"
+require "webmock/rspec"
+require "flexmock/rspec"
+require "pp"
 
-begin # load pry if is available
-require 'pry'
-Pry.config.output = STDOUT
+# load pry if is available
+begin
+  require "pry"
+  Pry.config.output = $stdout
 rescue LoadError
 end
 
-require 'vcr'
-require 'timecop'
+require "vcr"
+require "timecop"
 
 module Oddb2xml
   # we override here a few directories to make input/output when running specs to
   # be in different places compared when running
-  SpecData       = File.join(File.dirname(__FILE__), 'data')
-  WorkDir        = File.join(File.dirname(__FILE__), 'run')
-  Downloads      = File.join(WorkDir, 'downloads')
-  SpecCompressor = File.join(Oddb2xml::SpecData, 'compressor')
-  DATE_REGEXP    = /\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}[-+]\d{4}/
+  SpecData = File.join(File.dirname(__FILE__), "data")
+  WORK_DIR = File.join(File.dirname(__FILE__), "run")
+  DOWNLOADS = File.join(WORK_DIR, "downloads")
+  SpecCompressor = File.join(Oddb2xml::SpecData, "compressor")
+  DATE_REGEXP = /\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}[-+]\d{4}/
 
   GTINS_CALC = [
-                  '7680458820202', # for calc_spec.rb
-                  '7680555940018', # for calc_spec.rb
-                  '7680434541015', # for calc_spec.rb
-                  '7680300150105', # for calc_spec.rb
-                  '7680446250592', # for calc_spec.rb
-                  '7680611860045', # for calc_spec.rb
-                  '7680165980114', # for calc_spec.rb
-                  '7680589430011', # for calc_spec.rb
-                  '7680556740075', # for calc_spec.rb
-                  '7680540151009', # for calc_spec.rb
-                  '7680560890018', # for calc_spec.rb
-                  '7680532900196', # Insulin, gentechnik
-                  '7680555610041', # Diaphin 10 g i.v. drug
-    ]
-  FRIDGE_GTIN = '7680002770014'   # fridge drug 7680002770014 Coeur-Vaisseaux Sérocytol, suppositoire
-  ORPHAN_GTIN = '7680587340015'   # orphan drug IKSNR 62132: Adcetris, Pulver zur Herstellung einer Infusionslösung
-  GTINS_DRUGS = [ '733905577161', # 1-DAY ACUVUE Moist Tag -2.00dpt BC 8.5
-                  FRIDGE_GTIN,
-                  ORPHAN_GTIN,
-                  '4042809018288',
-                  '4042809018400',
-                  '4042809018493',
-                  '5000223074777',
-                  '5000223439507',
-                  '7611600441013',
-                  '7611600441020',
-                  '7611600441037',
-                  '7680161050583', # Hirudoid Creme 3 mg/g
-                  '7680172330414', # SELSUN
-                  '7680284860144',
-                  '7680316440115', # FERRO-GRADUMET Depottabl 30 Stk
-                  '7680316950157', # SOFRADEX Gtt Auric 8 ml
-                  '7680324750190', # LANSOYL Gel
-                  '7680353660163',
-                  '7680403330459',
-                  '7680536620137', # 3TC Filmtabl 150 mg
-                  '7680555580054', # ZYVOXID
-                  '7680620690084', # LEVETIRACETAM DESITIN Mini Filmtab 250 mg needed for extractor_spec.rb
-                  ] + GTINS_CALC
-    FERRO_GRADUMET_GTIN           = '7680316440115'
-    HIRUDOID_GTIN                 = '7680161050583'
-    LANSOYL_GTIN                  = '7680324750190'
-    LANSOYL_PRICE_RESELLER_PUB    = 18.95
-    LANSOYL_PRICE_ZURROSE         = 10.54
-    LANSOYL_PRICE_ZURROSEPUB      = 16.25
-    LEVETIRACETAM_GTIN            = '7680620690084'
-    LEVETIRACETAM_PRICE_PPUB      = 27.8
-    LEVETIRACETAM_PRICE_ZURROSE   = 13.49
-    LEVETIRACETAM_PRICE_RESELLER_PUB = 24.3
-    SOFRADEX_GTIN                 = '7680316950157'
-    SOFRADEX_PRICE_RESELLER_PUB   = 12.9
-    SOFRADEX_PRICE_ZURROSE        = 7.18
-    SOFRADEX_PRICE_ZURROSEPUB     = 15.45
-    THREE_TC_GTIN                 = '7680536620137'
-    ZYVOXID_GTIN                  = '7680555580054'
+    "7680458820202", # for calc_spec.rb
+    "7680555940018", # for calc_spec.rb
+    "7680434541015", # for calc_spec.rb
+    "7680300150105", # for calc_spec.rb
+    "7680446250592", # for calc_spec.rb
+    "7680611860045", # for calc_spec.rb
+    "7680165980114", # for calc_spec.rb
+    "7680589430011", # for calc_spec.rb
+    "7680556740075", # for calc_spec.rb
+    "7680540151009", # for calc_spec.rb
+    "7680560890018", # for calc_spec.rb
+    "7680532900196", # Insulin, gentechnik
+    "7680555610041" # Diaphin 10 g i.v. drug
+  ]
+  FRIDGE_GTIN = "7680002770014" # fridge drug 7680002770014 Coeur-Vaisseaux Sérocytol, suppositoire
+  ORPHAN_GTIN = "7680587340015" # orphan drug IKSNR 62132: Adcetris, Pulver zur Herstellung einer Infusionslösung
+  GTINS_DRUGS = ["733905577161", # 1-DAY ACUVUE Moist Tag -2.00dpt BC 8.5
+    FRIDGE_GTIN,
+    ORPHAN_GTIN,
+    "4042809018288",
+    "4042809018400",
+    "4042809018493",
+    "5000223074777",
+    "5000223439507",
+    "7611600441013",
+    "7611600441020",
+    "7611600441037",
+    "7680161050583", # Hirudoid Creme 3 mg/g
+    "7680172330414", # SELSUN
+    "7680284860144",
+    "7680316440115", # FERRO-GRADUMET Depottabl 30 Stk
+    "7680316950157", # SOFRADEX Gtt Auric 8 ml
+    "7680324750190", # LANSOYL Gel
+    "7680353660163",
+    "7680403330459",
+    "7680536620137", # 3TC Filmtabl 150 mg
+    "7680555580054", # ZYVOXID
+    # 7680620690084 is LEVETIRACETAM DESITIN Mini Filmtab 250 mg needed for extractor_spec.rb
+    "7680620690084"] +
+    GTINS_CALC
+  FERRO_GRADUMET_GTIN = "7680316440115"
+  HIRUDOID_GTIN = "7680161050583"
+  LANSOYL_GTIN = "7680324750190"
+  LANSOYL_PRICE_RESELLER_PUB = 18.95
+  LANSOYL_PRICE_ZURROSE = 10.54
+  LANSOYL_PRICE_ZURROSEPUB = 16.25
+  LEVETIRACETAM_GTIN = "7680620690084"
+  LEVETIRACETAM_PRICE_PPUB = 27.8
+  LEVETIRACETAM_PRICE_ZURROSE = 13.49
+  LEVETIRACETAM_PRICE_RESELLER_PUB = 24.3
+  SOFRADEX_GTIN = "7680316950157"
+  SOFRADEX_PRICE_RESELLER_PUB = 12.9
+  SOFRADEX_PRICE_ZURROSE = 7.18
+  SOFRADEX_PRICE_ZURROSEPUB = 15.45
+  THREE_TC_GTIN = "7680536620137"
+  ZYVOXID_GTIN = "7680555580054"
 
   GTINS_MEDREG = [
-    '7601001380028', # Glarus
-    '7601002017145', # Kantonsspital Glarus AG
-    '7601001395145', # Kantonstierärztlicher Dienst
-    '7601001396043', # St. Fridolin Pharma AG
-    '7601000159199', #  Davatz  Ursula
-    '7601000159199', #  Davatz  Ursula
-    '7601000254344', #  Pfister Daniel  8753  Mollis
-    '7601000254207', #  Züst  Peter 8753  Mollis
-    '7601000752314', #  Züst  Yvonne  8753  Mollis
-    ]
-
+    "7601001380028", # Glarus
+    "7601002017145", # Kantonsspital Glarus AG
+    "7601001395145", # Kantonstierärztlicher Dienst
+    "7601001396043", # St. Fridolin Pharma AG
+    "7601000159199", #  Davatz  Ursula
+    "7601000159199", #  Davatz  Ursula
+    "7601000254344", #  Pfister Daniel  8753  Mollis
+    "7601000254207", #  Züst  Peter 8753  Mollis
+    "7601000752314" #  Züst  Yvonne  8753  Mollis
+  ]
 end
 
 RSpec.configure do |config|
-    config.mock_with :flexmock
-  end        
+  config.mock_with :flexmock
+end
 
 VCR.configure do |config|
   config.cassette_library_dir = "spec/fixtures/vcr_cassettes"
   config.hook_into :webmock
-  config.debug_logger = File.open(File.join(File.dirname(File.dirname(__FILE__)), 'vcr.log'), 'w+')
+  config.debug_logger = File.open(File.join(File.dirname(File.dirname(__FILE__)), "vcr.log"), "w+")
   config.debug_logger.sync = true
-  config.default_cassette_options = { :record =>:once, # ARGV.join(' ').index('downloader_spec') ? :new_episodes : :once ,
-                                      :preserve_exact_body_bytes => true,
-                                      :allow_playback_repeats => true,
-                                      :serialize_with => :json,
-                                      :decode_compressed_response => true,
-                                      :match_requests_on => [:method, :uri, :body],
-                                    }
-#	 :match_requests_on (Array<Symbol, #call>) —
-#
-# List of request matchers to use to determine what recorded HTTP interaction to replay. Defaults to [:method, :uri]. The built-in matchers are :method, :uri, :host, :path, :headers and :body. You can also pass the name of a registered custom request matcher or any object that responds to #call.
+  config.default_cassette_options = {record: :once, # ARGV.join(' ').index('downloader_spec') ? :new_episodes : :once ,
+                                     preserve_exact_body_bytes: true,
+                                     allow_playback_repeats: true,
+                                     serialize_with: :json,
+                                     decode_compressed_response: true,
+                                     match_requests_on: [:method, :uri, :body]}
+  #	 :match_requests_on (Array<Symbol, #call>) —
+  #
+  # List of request matchers to use to determine what recorded HTTP interaction to replay. Defaults to [:method, :uri]. The built-in matchers are :method, :uri, :host, :path, :headers and :body. You can also pass the name of a registered custom request matcher or any object that responds to #call.
 
   config.before_http_request(:real?) do |request|
-    $stderr.puts("before real request: #{request.method} #{request.uri} #{caller[0..5].join("\n")}")
+    warn("before real request: #{request.method} #{request.uri} #{caller[0..5].join("\n")}")
     $stderr.flush
   end
 end
@@ -131,17 +131,20 @@ end
 AllCompositionLines = File.expand_path("#{__FILE__}/../data/compositions.txt")
 AllColumn_C_Lines = File.expand_path("#{__FILE__}/../data/column_c.txt")
 
-require 'oddb2xml'
+require "oddb2xml"
 
 module Kernel
   def buildr_capture(stream)
     begin
+      # We know that standardrb complains here. But there is no time to fix it
       stream = stream.to_s
       eval "$#{stream} = StringIO.new"
       yield
       result = eval("$#{stream}").string
     ensure
-      eval "$#{stream} = #{stream.upcase}"
+      eval <<-RUBY, binding, __FILE__, __LINE__ + 1
+        "$#{stream} = #{stream.upcase}"
+      RUBY
     end
     result
   end
@@ -149,19 +152,18 @@ end
 
 module ServerMockHelper
   def cleanup_compressor
-    [ File.join(Oddb2xml::SpecCompressor, '*.zip'),
-      File.join(Oddb2xml::SpecCompressor, '*.tar.gz'),
-      File.join(Oddb2xml::SpecCompressor, 'epha_interactions.txt*'),
-      File.join(Oddb2xml::SpecCompressor, 'medregbm_company.txt*'),
-      File.join(Oddb2xml::SpecCompressor, 'medregbm_person.txt*'),
-      File.join(Oddb2xml::SpecCompressor, 'transfer.dat.*'),
-      File.join(Oddb2xml::SpecCompressor, 'oddb2xml_files_nonpharma.xls.*'),
-      ].each { |file| FileUtils.rm_f(Dir.glob(file), :verbose => false) if Dir.glob(file).size > 0 }
+    [File.join(Oddb2xml::SpecCompressor, "*.zip"),
+      File.join(Oddb2xml::SpecCompressor, "*.tar.gz"),
+      File.join(Oddb2xml::SpecCompressor, "epha_interactions.txt*"),
+      File.join(Oddb2xml::SpecCompressor, "medregbm_company.txt*"),
+      File.join(Oddb2xml::SpecCompressor, "medregbm_person.txt*"),
+      File.join(Oddb2xml::SpecCompressor, "transfer.dat.*"),
+      File.join(Oddb2xml::SpecCompressor, "oddb2xml_files_nonpharma.xls.*")].each { |file| FileUtils.rm_f(Dir.glob(file), verbose: false) if Dir.glob(file).size > 0 }
   end
+
   def cleanup_directories_before_run
-    dirs = [ Oddb2xml::Downloads, Oddb2xml::WorkDir]
-    dirs.each{ |dir| FileUtils.rm_rf(Dir.glob(File.join(dir, '*')), :verbose => false) }
-    dirs.each{ |dir| FileUtils.makedirs(dir, :verbose => false) }
+    dirs = [Oddb2xml::DOWNLOADS, Oddb2xml::WORK_DIR]
+    dirs.each { |dir| FileUtils.rm_rf(Dir.glob(File.join(dir, "*")), verbose: false) }
     cleanup_compressor
     mock_downloads
   end
@@ -177,9 +179,9 @@ def check_elements(xml_name, tests)
     value = test[1]
     it "should have correct entries #{value} for path #{path}" do
       found = false
-        Nokogiri::XML(File.read(xml_name)).search(path, nil, nil).each do |x|
+      Nokogiri::XML(File.read(xml_name)).search(path, nil, nil).each do |x|
         if value.match(x.text)
-          found= true
+          found = true
           break
         end
       end
@@ -196,8 +198,8 @@ def check_attributes(xml_name, tests)
     it "should have correct value #{value} for attribute #{attribute} in #{path}" do
       found = false
       Nokogiri::XML(File.read(xml_name)).search(path, nil, nil).each do |x|
-        if value.match(x["#{attribute}"])
-          found= true
+        if value.match(x[attribute.to_s])
+          found = true
           break
         end
       end
@@ -210,62 +212,60 @@ RSpec.configure do |config|
   config.run_all_when_everything_filtered = true
   config.filter_run :focus
   config.filter_run_excluding :slow
-  #config.exclusion_filter = {:slow => true}
+  # config.exclusion_filter = {:slow => true}
 
   # Run specs in random order to surface order dependencies. If you find an
   # order dependency and want to debug it, you can fix the order by providing
   # the seed, which is printed after each run.
   #     --seed 1234
-  config.order = 'random'
+  config.order = "random"
 
   # Helper
   config.include(ServerMockHelper)
 end
 
 def validate_via_xsd(xsd_file, xml_file)
-  xsd =open(xsd_file).read
+  xsd = File.open(xsd_file).read
   xsd_rtikelstamm_xml = Nokogiri::XML::Schema(xsd)
   doc = Nokogiri::XML(File.read(xml_file))
-  xsd_rtikelstamm_xml.validate(doc).each do
-    |error|
-      if error.message
-        puts "Failed validating #{xml_file} with #{File.size(xml_file)} bytes using XSD from #{xsd_file}"
-        puts "CMD: xmllint --noout --schema #{xsd_file} #{xml_file}"
-      end
-      msg = "expected #{error.message} to be nil\nfor #{xml_file}"
-      puts msg
-      expect(error.message).to be_nil, msg
+  xsd_rtikelstamm_xml.validate(doc).each do |error|
+    if error.message
+      puts "Failed validating #{xml_file} with #{File.size(xml_file)} bytes using XSD from #{xsd_file}"
+      puts "CMD: xmllint --noout --schema #{xsd_file} #{xml_file}"
+    end
+    msg = "expected #{error.message} to be nil\nfor #{xml_file}"
+    puts msg
+    expect(error.message).to be_nil, msg
   end
 end
 
 def mock_downloads
-    WebMock.enable!
-    { 'transfer.zip' => ['transfer.dat'],
-      'XMLPublications.zip' => ['Preparations.xml', 'ItCodes.xml', 'GL_Diff_SB.xml']
-      }.each do |zip, entries|
-        zip_file = File.join(Oddb2xml::SpecData,zip)
-        files = entries.collect{|entry| File.join(Oddb2xml::SpecData, entry)}
-        FileUtils.rm(zip_file, :verbose => false) if File.exist?(zip_file)
-        cmd = "zip --quiet --junk-paths #{zip_file} #{files.join(' ')}"
-        system(cmd)
-    end
-    { 'https://raw.githubusercontent.com/zdavatz/oddb2xml_files/master/interactions_de_utf8.csv' =>  'epha_interactions.csv',
-      'https://www.swissmedic.ch/swissmedic/de/home/services/listen_neu.html' => 'listen_neu.html',
-      'https://www.swissmedic.ch/dam/swissmedic/de/dokumente/internetlisten/status_ophan%20Drug.xlsx.download.xlsx/Liste_OrphanDrug_Internet_2019_01_31.xlsx' =>  'swissmedic_orphan.xlsx',
-      'https://www.swissmedic.ch/dam/swissmedic/de/dokumente/internetlisten/zugelassene_packungen_ham.xlsx.download.xlsx/Zugelassene_Packungen%20HAM_31012019.xlsx' => 'swissmedic_package.xlsx',
-      'http://pillbox.oddb.org/TRANSFER.ZIP' =>  'transfer.zip',
-      'https://github.com/zdavatz/cpp2sqlite/blob/master/input/atc_codes_multi_lingual.txt' => 'atc.csv',
-      'https://raw.githubusercontent.com/zdavatz/oddb2xml_files/master/LPPV.txt' => 'oddb2xml_files_lppv.txt',
-      'http://www.xn--spezialittenliste-yqb.ch/File.axd?file=XMLPublications.zip' => 'XMLPublications.zip',
-      'http://www.spezialitaetenliste.ch/varia_De.htm' => 'varia_De.htm',
-#      'http://refdatabase.refdata.ch/Service/Article.asmx?WSDL' => 'refdata_Pharma.xml',
-      }.each do |url, file|
-      inhalt = File.read(File.join(Oddb2xml::SpecData, file))
-      m = flexmock('open-uri')
-      m.should_receive(:open).with(url).and_return(inhalt)
-      stub_request(:any,url).to_return(body: inhalt)
-      stub_request(:get,url).to_return(body: inhalt)
-      stub_request(:open,url).to_return(body: inhalt)
-    end
-    VCR.eject_cassette; VCR.insert_cassette('oddb2xml')
+  WebMock.enable!
+  {"transfer.zip" => ["transfer.dat"],
+   "XMLPublications.zip" => ["Preparations.xml", "ItCodes.xml", "GL_Diff_SB.xml"]}.each do |zip, entries|
+    zip_file = File.join(Oddb2xml::SpecData, zip)
+    files = entries.collect { |entry| File.join(Oddb2xml::SpecData, entry) }
+    FileUtils.rm(zip_file, verbose: false) if File.exist?(zip_file)
+    cmd = "zip --quiet --junk-paths #{zip_file} #{files.join(" ")}"
+    system(cmd)
+  end
+  {"https://raw.githubusercontent.com/zdavatz/oddb2xml_files/master/interactions_de_utf8.csv" => "epha_interactions.csv",
+   "https://www.swissmedic.ch/swissmedic/de/home/services/listen_neu.html" => "listen_neu.html",
+   "https://www.swissmedic.ch/dam/swissmedic/de/dokumente/internetlisten/status_ophan%20Drug.xlsx.download.xlsx/Liste_OrphanDrug_Internet_2019_01_31.xlsx" => "swissmedic_orphan.xlsx",
+   "https://www.swissmedic.ch/dam/swissmedic/de/dokumente/internetlisten/zugelassene_packungen_ham.xlsx.download.xlsx/Zugelassene_Packungen%20HAM_31012019.xlsx" => "swissmedic_package.xlsx",
+   "http://pillbox.oddb.org/TRANSFER.ZIP" => "transfer.zip",
+   "https://github.com/zdavatz/cpp2sqlite/blob/master/input/atc_codes_multi_lingual.txt" => "atc.csv",
+   "https://raw.githubusercontent.com/zdavatz/oddb2xml_files/master/LPPV.txt" => "oddb2xml_files_lppv.txt",
+   "http://www.xn--spezialittenliste-yqb.ch/File.axd?file=XMLPublications.zip" => "XMLPublications.zip",
+   #      'http://refdatabase.refdata.ch/Service/Article.asmx?WSDL' => 'refdata_Pharma.xml
+   "http://www.spezialitaetenliste.ch/varia_De.htm" => "varia_De.htm"}.each do |url, file|
+    inhalt = File.read(File.join(Oddb2xml::SpecData, file))
+    m = flexmock("open-uri")
+    m.should_receive(:open).with(url).and_return(inhalt)
+    stub_request(:any, url).to_return(body: inhalt)
+    stub_request(:get, url).to_return(body: inhalt)
+    stub_request(:open, url).to_return(body: inhalt)
+  end
+  VCR.eject_cassette
+  VCR.insert_cassette("oddb2xml")
 end

data/test_options.rb

@@ -5,66 +5,63 @@
 # - runs all commands (and add ---skip-download)
 # - saveds output and downloads to ausgabe/time_stamp
 
-
-require 'fileutils'
-require 'socket'
-require 'oddb2xml/version'
+require "fileutils"
+require "socket"
+require "oddb2xml/version"
 
 def test_one_call(cmd)
-  dest = File.join(Ausgabe, cmd.gsub(/[ -]/, '_'))
-  all_downloads = File.join(dest, 'downloads')
-  FileUtils.makedirs(all_downloads) unless File.exists?(all_downloads)
-  cmd.sub!('oddb2xml',  'oddb2xml --skip-download --log')
-  files = (Dir.glob('%.xls*') + Dir.glob('*.dat*') + Dir.glob('*.xml'))
-  FileUtils.rm(files, :verbose => true)
+  dest = File.join(Ausgabe, cmd.gsub(/[ -]/, "_"))
+  all_downloads = File.join(dest, "downloads")
+  FileUtils.makedirs(all_downloads) unless File.exist?(all_downloads)
+  cmd.sub!("oddb2xml", "oddb2xml --skip-download --log")
+  files = (Dir.glob("%.xls*") + Dir.glob("*.dat*") + Dir.glob("*.xml"))
+  FileUtils.rm(files, verbose: true)
   puts "#{Time.now}: Running cmd #{cmd}"
-  startTime = Time.now
+  start_time = Time.now
   res = system(cmd)
-  endTime = Time.now
-  diffSeconds = (endTime - startTime).to_i
-  duration = "#{Time.now}: Took #{sprintf('%3d', diffSeconds)} seconds for"
+  end_time = Time.now
+  diff_seconds = (end_time - start_time).to_i
+  duration = "#{Time.now}: Took #{sprintf("%3d", diff_seconds)} seconds for"
   puts "#{duration} success #{res} for #{cmd}"
   exit 2 unless res
   FileUtils.makedirs(dest)
-  return unless File.directory?('downloads')
-  FileUtils.cp_r('downloads', dest, :preserve => true, :verbose => true) if Dir.glob(Ausgabe).size > 0
-  FileUtils.cp(Dir.glob('*.dat'), dest, :preserve => true, :verbose => true) if Dir.glob('*.dat').size > 0
-  FileUtils.cp(Dir.glob('*.xml'), dest, :preserve => true, :verbose => true) if Dir.glob('*.xml').size > 0
-  FileUtils.cp(Dir.glob('*.gz'),  dest, :preserve => true, :verbose => true) if Dir.glob('*.gz').size > 0
+  return unless File.directory?("downloads")
+  FileUtils.cp_r("downloads", dest, preserve: true, verbose: true) if Dir.glob(Ausgabe).size > 0
+  FileUtils.cp(Dir.glob("*.dat"), dest, preserve: true, verbose: true) if Dir.glob("*.dat").size > 0
+  FileUtils.cp(Dir.glob("*.xml"), dest, preserve: true, verbose: true) if Dir.glob("*.xml").size > 0
+  FileUtils.cp(Dir.glob("*.gz"), dest, preserve: true, verbose: true) if Dir.glob("*.gz").size > 0
   downloaded_files = Dir.glob("#{dest}/*/downloads/*")
-  FileUtils.mv(downloaded_files,  all_downloads, :verbose => true) if downloaded_files.size > 0
-  FileUtils.rm(Dir.glob("#{dest}/*#{Time.now.year}*.xml"), :verbose => true)
+  FileUtils.mv(downloaded_files, all_downloads, verbose: true) if downloaded_files.size > 0
+  FileUtils.rm(Dir.glob("#{dest}/*#{Time.now.year}*.xml"), verbose: true)
 end
 
 def prepare_for_gem_test
-  [ "rake clean gem install"      , # build  and install our gem first
-#    "gem uninstall --all --ignore-dependencies --executables",
-    "gem install --no-ri --no-rdoc pkg/*.gem"
-  ].each {
-    |cmd|
-      puts "Running #{cmd}"
-      exit 1 unless system(cmd)
+  ["rake clean gem install", # build  and install our gem first
+    #    "gem uninstall --all --ignore-dependencies --executables",
+    "gem install --no-ri --no-rdoc pkg/*.gem"].each { |cmd|
+    puts "Running #{cmd}"
+    exit 1 unless system(cmd)
   }
 end
 
-Ausgabe = File.join(Dir.pwd, 'ausgabe', "#{Oddb2xml::VERSION}-#{Time.now.strftime('%Y.%m.%d')}") 
+Ausgabe = File.join(Dir.pwd, "ausgabe", "#{Oddb2xml::VERSION}-#{Time.now.strftime("%Y.%m.%d")}")
 puts "FQDN hostname #{Socket.gethostbyname(Socket.gethostname).inspect}"
 FileUtils.makedirs(Ausgabe)
 prepare_for_gem_test
 # we will skip some long running tests as travis jobs must finish in less than 50 minutes
 # unfortunately it returns a very common name
-unless 'localhost.localdomain'.eql?(Socket.gethostbyname(Socket.gethostname).first)
-  test_one_call('oddb2xml -e')
-  test_one_call('oddb2xml --artikelstamm')
-  test_one_call('oddb2xml -e -I80')
-  test_one_call('oddb2xml -f dat --append -I 80')
-  test_one_call('oddb2xml -f dat --append')
-  test_one_call('oddb2xml --append')
+unless "localhost.localdomain".eql?(Socket.gethostbyname(Socket.gethostname).first)
+  test_one_call("oddb2xml -e")
+  test_one_call("oddb2xml --artikelstamm")
+  test_one_call("oddb2xml -e -I80")
+  test_one_call("oddb2xml -f dat --append -I 80")
+  test_one_call("oddb2xml -f dat --append")
+  test_one_call("oddb2xml --append")
 end
-test_one_call('oddb2xml --calc')
-test_one_call('oddb2xml -t md -c tar.gz')
-test_one_call('oddb2xml -o')
-test_one_call('oddb2xml -f xml')
-test_one_call('oddb2xml -f dat')
-test_one_call('oddb2xml -t md')
+test_one_call("oddb2xml --calc")
+test_one_call("oddb2xml -t md -c tar.gz")
+test_one_call("oddb2xml -o")
+test_one_call("oddb2xml -f xml")
+test_one_call("oddb2xml -f dat")
+test_one_call("oddb2xml -t md")
 # test_one_call('oddb2xml -x address')

data/tools/win_fetch_cacerts.rb

@@ -1,13 +1,12 @@
-require 'net/http'
+require "net/http"
 
 # create a path to the file "C:\%HOME%\cacert.pem"
 cacert_file = File.join(Dir.home, "cacert.pem")
 
 Net::HTTP.start("curl.haxx.se") do |http|
-
   resp = http.get("/ca/cacert.pem")
   if resp.code == "200"
-    open(cacert_file, "wb") { |file| file.write(resp.body) }
+    File.open(cacert_file, "wb") { |file| file.write(resp.body) }
     puts "\n\nA bundle of certificate authorities has been installed to"
     puts "C:\\%HOME%\\cacert.pem\n"
     puts "* Please set SSL_CERT_FILE in your current command prompt session with:"