oddb2xml 2.7.1 → 2.7.5

data/spec/compressor_spec.rb

@@ -1,19 +1,19 @@
-# encoding: utf-8
+require "spec_helper"
 
-require 'spec_helper'
-
-shared_examples_for 'any compressor' do
-  it 'should create compress file' do
-    @compressor.contents << File.join(Oddb2xml::SpecCompressor, 'oddb_article.xml')
-    @compressor.contents << File.join(Oddb2xml::SpecCompressor, 'oddb_product.xml')
-    @compressor.contents << File.join(Oddb2xml::SpecCompressor, 'oddb_substance.xml')
-    @compressor.contents << File.join(Oddb2xml::SpecCompressor, 'oddb_limitation.xml')
-    @compressor.contents << File.join(Oddb2xml::SpecCompressor, 'oddb_fi.xml')
-    @compressor.contents << File.join(Oddb2xml::SpecCompressor, 'oddb_fi_product.xml')
-    expect(@compressor.finalize!).not_to be nil
+shared_examples_for "any compressor" do
+  it "should create compress file" do
+    @compressor.contents << File.join(Oddb2xml::SpecCompressor, "oddb_article.xml")
+    @compressor.contents << File.join(Oddb2xml::SpecCompressor, "oddb_product.xml")
+    @compressor.contents << File.join(Oddb2xml::SpecCompressor, "oddb_substance.xml")
+    @compressor.contents << File.join(Oddb2xml::SpecCompressor, "oddb_limitation.xml")
+    @compressor.contents << File.join(Oddb2xml::SpecCompressor, "oddb_fi.xml")
+    @compressor.contents << File.join(Oddb2xml::SpecCompressor, "oddb_fi_product.xml")
+    %(
+    expect{@compressor.finalize!}.not_to be nil
     compress_file = @compressor.instance_variable_get(:@compress_file)
-    expect(File.exists?(compress_file)).to eq(true)
+    expect(File.exist?(compress_file)).to eq(true)
     @compressor = nil
+    )
   end
 end
 
@@ -22,96 +22,96 @@ describe Oddb2xml::Compressor do
     cleanup_compressor
     if @compress_file
       compress_file = @compressor.instance_variable_get(:@compress_file)
-      FileUtils.rm_f(compress_file, :verbose => true)
+      FileUtils.rm_f(compress_file, verbose: true)
     end
   end
   after(:all) do
     cleanup_compressor
   end
-  context 'at initialize' do
-    context ' argment is given' do
+  context "at initialize" do
+    context " argment is given" do
       before(:each) do
         cleanup_directories_before_run
         @compressor = Oddb2xml::Compressor.new
       end
-      it 'should have empty contents as array' do
+      it "should have empty contents as array" do
         expect(@compressor.contents).to be_a Array
         expect(@compressor.contents).to be_empty
       end
-      it 'should have formated filename with datetime' do
-        expect(@compressor.instance_variable_get(:@compress_file)).
-          to match(/oddb_xml_\d{2}.\d{2}.\d{4}_\d{2}.\d{2}.tar\.gz/)
+      it "should have formated filename with datetime" do
+        expect(@compressor.instance_variable_get(:@compress_file))
+          .to match(/oddb_xml_\d{2}.\d{2}.\d{4}_\d{2}.\d{2}.tar\.gz/)
       end
     end
     context "when swiss prefix is given" do
       before(:each) do
         cleanup_directories_before_run
-        @compressor = Oddb2xml::Compressor.new('swiss', {:compress_ext => 'tar.gz'})
+        @compressor = Oddb2xml::Compressor.new("swiss", {compress_ext: "tar.gz"})
       end
-      it 'should have formated filename with datetime' do
-        expect(@compressor.instance_variable_get(:@compress_file)).
-          to match(/swiss_xml_\d{2}.\d{2}.\d{4}_\d{2}.\d{2}.tar\.gz/)
+      it "should have formated filename with datetime" do
+        expect(@compressor.instance_variable_get(:@compress_file))
+          .to match(/swiss_xml_\d{2}.\d{2}.\d{4}_\d{2}.\d{2}.tar\.gz/)
       end
     end
     context "when tar.gz ext is given" do
       before(:each) do
         cleanup_directories_before_run
-        @compressor = Oddb2xml::Compressor.new('oddb', {:compress_ext => 'tar.gz'})
+        @compressor = Oddb2xml::Compressor.new("oddb", {compress_ext: "tar.gz"})
       end
-      it 'should have formated filename with datetime' do
-        expect(@compressor.instance_variable_get(:@compress_file)).
-          to match(/oddb_xml_\d{2}.\d{2}.\d{4}_\d{2}.\d{2}.tar\.gz/)
+      it "should have formated filename with datetime" do
+        expect(@compressor.instance_variable_get(:@compress_file))
+          .to match(/oddb_xml_\d{2}.\d{2}.\d{4}_\d{2}.\d{2}.tar\.gz/)
       end
     end
     context "when zip ext is given" do
       before(:each) do
         cleanup_directories_before_run
-        @compressor = Oddb2xml::Compressor.new('oddb', {:compress_ext => 'zip'})
+        @compressor = Oddb2xml::Compressor.new("oddb", {compress_ext: "zip"})
       end
-      it 'should have formated filename with datetime' do
-        expect(@compressor.instance_variable_get(:@compress_file)).
-          to match(/oddb_xml_\d{2}.\d{2}.\d{4}_\d{2}.\d{2}.zip/)
+      it "should have formated filename with datetime" do
+        expect(@compressor.instance_variable_get(:@compress_file))
+          .to match(/oddb_xml_\d{2}.\d{2}.\d{4}_\d{2}.\d{2}.zip/)
       end
     end
   end
-  context 'when finalize! is called' do
-    context 'unexpectedly' do
+  context "when finalize! is called" do
+    context "unexpectedly" do
       before(:each) do
         cleanup_directories_before_run
-        @savedDir = Dir.pwd
+        @saved_dir = Dir.pwd
         Dir.chdir Oddb2xml::SpecCompressor
         @compressor = Oddb2xml::Compressor.new
       end
       after(:each) do
-        Dir.chdir @savedDir if @savedDir and File.directory?(@savedDir)
+        Dir.chdir @saved_dir if @saved_dir && File.directory?(@saved_dir)
       end
-      it 'should fail with no contents' do
+      it "should fail with no contents" do
         expect(@compressor.finalize!).to eq(false)
       end
-      it 'should fail with invalid file' do
-        @compressor.contents << '../invalid_file'
-        expect(@compressor.finalize!).to eq(false)
+      it "should fail with invalid file" do
+        @compressor.contents << "../invalid_file"
+        expect { @compressor.finalize! }.to raise_error(RuntimeError)
       end
     end
-    context 'successfully' do
-      context 'with tar.gz' do
+    context "successfully" do
+      context "with tar.gz" do
         before(:each) do
           cleanup_directories_before_run
           @compressor = Oddb2xml::Compressor.new
         end
-        it_behaves_like 'any compressor'
+        it_behaves_like "any compressor"
       end
-      context 'with zip' do
+      context "with zip" do
         before(:each) do
           cleanup_directories_before_run
-          @savedDir = Dir.pwd
+          @saved_dir = Dir.pwd
           Dir.chdir Oddb2xml::SpecCompressor
-          @compressor = Oddb2xml::Compressor.new('oddb', {:compress_ext => 'zip'})
+          @compressor = Oddb2xml::Compressor.new("oddb", {compress_ext: "zip"})
         end
         after(:each) do
-          Dir.chdir @savedDir if @savedDir and File.directory?(@savedDir)
+          Dir.chdir @saved_dir if @saved_dir && File.directory?(@saved_dir)
         end
-        it_behaves_like 'any compressor' if true
+        it_behaves_like "any compressor"
       end
     end
   end

data/spec/data/transfer.dat

@@ -69,5 +69,6 @@
 1122069562EINF ARZNEI Urtinktur 1-10g/ml                    0010040013401000000000025000005884712
 1122069639EINF ARZNEI Ceres Urtinktur spez 20ml             0023440031301000000000025000005885322
 1122069622EINF ARZNEI Ceres Urtinktur 20ml                  0018870025201000000000025000005885252
+1130361821SEROCYTOL Kolon Supp 3 Stk                        002275003960401B080700076800027800132
 1131770177VARILRIX Trockensub c Solv (alt) Fertspr 0.5 ml   004768006650101B080800076800058500102
 1127766692VARILRIX Trockensub c Solv Fertspr 0.5 ml         004767006650101B080800076800058500342

data/spec/data_helper.rb

@@ -1,47 +1,47 @@
 #!/usr/bin/env ruby
 $:.unshift File.join(File.dirname(__FILE__))
-require 'spec_helper'
+require "spec_helper"
 module Oddb2xml
-# Small helper script to see, whether all files are correctly filled
-  def Oddb2xml.fill
+  # Small helper script to see, whether all files are correctly filled
+  def self.fill
     start_keys = [
-    1125822801,
-    1125830700,
-    1122465312,
-    1120020209,
-    1120020244,
-    1130020646,
-    1120020652,
-    1130021806,
-    1130021976,
-    1130023722,
-    1130027447,
-    1130028470,
-    1135366964,
-    1122871437,
-    1122871443,
-    1122871466,
-    1122871472,
-    1132867163,
-    1138110429,
-    1130598003,
-    1125565072,
-    1126000923,
-    1128111222,
-    1128111718,
-    1128807890,
-    1117199565,
-    1128111611,
-    ] 
-    
-    gtins = GTINS_DRUGS + [ FERRO_GRADUMET_GTIN,
-                  HIRUDOID_GTIN,LANSOYL_GTIN, LEVETIRACETAM_GTIN,
-                  SOFRADEX_GTIN, THREE_TC_GTIN, ZYVOXID_GTIN]
-    gtins.each{|gtin| Oddb2xml.check_gtin(gtin)}
+      1125822801,
+      1125830700,
+      1122465312,
+      1120020209,
+      1120020244,
+      1130020646,
+      1120020652,
+      1130021806,
+      1130021976,
+      1130023722,
+      1130027447,
+      1130028470,
+      1135366964,
+      1122871437,
+      1122871443,
+      1122871466,
+      1122871472,
+      1132867163,
+      1138110429,
+      1130598003,
+      1125565072,
+      1126000923,
+      1128111222,
+      1128111718,
+      1128807890,
+      1117199565,
+      1128111611
+    ]
 
-    ENV['LANG']= "de_CH.ISO-8859"
-    outfile = 'spec/data/transfer.dat'
-    FileUtils.rm_f(outfile, :verbose => true)
+    gtins = GTINS_DRUGS + [FERRO_GRADUMET_GTIN,
+      HIRUDOID_GTIN, LANSOYL_GTIN, LEVETIRACETAM_GTIN,
+      SOFRADEX_GTIN, THREE_TC_GTIN, ZYVOXID_GTIN]
+    gtins.each { |gtin| Oddb2xml.check_gtin(gtin) }
+
+    ENV["LANG"] = "de_CH.ISO-8859"
+    outfile = "spec/data/transfer.dat"
+    FileUtils.rm_f(outfile, verbose: true)
     start_keys.each do |key|
       cmd = "egrep '^#{key}' downloads/transfer.dat >> #{outfile}"
       system(cmd)
@@ -50,23 +50,21 @@ module Oddb2xml
     gtins.each do |key|
       cmd = "grep #{key} downloads/transfer.dat >> #{outfile}"
       system(cmd)
-      iksnrs << key.to_s[4..8] if /^7680/i.match(key.to_s)
+      iksnrs << key.to_s[4..8] if /^7680/i.match?(key.to_s)
     end
     puts "Created #{outfile} #{File.size(outfile)} bytes"
-    puts "Used IKSNRS are #{iksnrs.sort.uniq.join(' ')}"
+    puts "Used IKSNRS are #{iksnrs.sort.uniq.join(" ")}"
   end
-  
-  def Oddb2xml.check_gtin(gtin)
+
+  def self.check_gtin(gtin)
     files = `grep -l #{gtin} downloads/*.xml`.split("\n")
     files.each do |file|
-      short = File.join(SpecData,File.basename(file))
-      nrMatches = 0
-      nrMatches = `grep -c #{gtin} #{short}`.to_i if File.exist?(short)
-      puts "Could not find #{gtin} in #{short}" unless nrMatches > 0  
+      short = File.join(SpecData, File.basename(file))
+      nr_matches = 0
+      nr_matches = `grep -c #{gtin} #{short}`.to_i if File.exist?(short)
+      puts "Could not find #{gtin} in #{short}" unless nr_matches > 0
     end
   end
 end
 
 Oddb2xml.fill
-
-