oddb2xml 1.8.1 → 1.8.2

data/spec/compressor_spec.rb

@@ -5,23 +5,35 @@ require 'spec_helper'
 shared_examples_for 'any compressor' do
   it 'should create compress file' do
     File.stub(:unlink).and_return(false)
-    @compressor.contents << File.expand_path('../data/oddb_article.xml', __FILE__)
-    @compressor.contents << File.expand_path('../data/oddb_product.xml', __FILE__)
-    @compressor.contents << File.expand_path('../data/oddb_substance.xml', __FILE__)
-    @compressor.contents << File.expand_path('../data/oddb_limitation.xml', __FILE__)
-    @compressor.contents << File.expand_path('../data/oddb_fi.xml', __FILE__)
-    @compressor.contents << File.expand_path('../data/oddb_fi_product.xml', __FILE__)
-    @compressor.finalize!.should == true
+    @compressor.contents << File.join(Oddb2xml::SpecCompressor, 'oddb_article.xml')
+    @compressor.contents << File.join(Oddb2xml::SpecCompressor, 'oddb_product.xml')
+    @compressor.contents << File.join(Oddb2xml::SpecCompressor, 'oddb_substance.xml')
+    @compressor.contents << File.join(Oddb2xml::SpecCompressor, 'oddb_limitation.xml')
+    @compressor.contents << File.join(Oddb2xml::SpecCompressor, 'oddb_fi.xml')
+    @compressor.contents << File.join(Oddb2xml::SpecCompressor, 'oddb_fi_product.xml')
+    @compressor.finalize!.should eq(true)
     compress_file = @compressor.instance_variable_get(:@compress_file)
     File.exists?(compress_file).should == true
     File.unstub(:unlink)
+    @compressor = nil
   end
 end
 
 describe Oddb2xml::Compressor do
+  after(:each) do
+    cleanup_compressor
+    if @compress_file
+      compress_file = @compressor.instance_variable_get(:@compress_file)
+      FileUtils.rm_f(compress_file, :verbose => true)
+    end
+  end
+  after(:all) do
+    cleanup_compressor
+  end
   context 'at initialize' do
-    context 'any argment is given' do
+    context ' argment is given' do
       before(:each) do
+        cleanup_directories_before_run
         @compressor = Oddb2xml::Compressor.new
       end
       it 'should have empty contents as array' do
@@ -35,6 +47,7 @@ describe Oddb2xml::Compressor do
     end
     context "when swiss prefix is given" do
       before(:each) do
+        cleanup_directories_before_run
         @compressor = Oddb2xml::Compressor.new('swiss', {:compress_ext => 'tar.gz'})
       end
       it 'should have formated filename with datetime' do
@@ -44,6 +57,7 @@ describe Oddb2xml::Compressor do
     end
     context "when tar.gz ext is given" do
       before(:each) do
+        cleanup_directories_before_run
         @compressor = Oddb2xml::Compressor.new('oddb', {:compress_ext => 'tar.gz'})
       end
       it 'should have formated filename with datetime' do
@@ -53,6 +67,7 @@ describe Oddb2xml::Compressor do
     end
     context "when zip ext is given" do
       before(:each) do
+        cleanup_directories_before_run
         @compressor = Oddb2xml::Compressor.new('oddb', {:compress_ext => 'zip'})
       end
       it 'should have formated filename with datetime' do
@@ -64,8 +79,14 @@ describe Oddb2xml::Compressor do
   context 'when finalize! is called' do
     context 'unexpectedly' do
       before(:each) do
+        cleanup_directories_before_run
+        @savedDir = Dir.pwd
+        Dir.chdir Oddb2xml::SpecCompressor
         @compressor = Oddb2xml::Compressor.new
       end
+      after(:each) do
+        Dir.chdir @savedDir if @savedDir and File.directory?(@savedDir)
+      end
       it 'should fail with no contents' do
         @compressor.finalize!.should == false
       end
@@ -77,20 +98,22 @@ describe Oddb2xml::Compressor do
     context 'successfully' do
       context 'with tar.gz' do
         before(:each) do
+          cleanup_directories_before_run
           @compressor = Oddb2xml::Compressor.new
         end
         it_behaves_like 'any compressor'
       end
       context 'with zip' do
         before(:each) do
+          cleanup_directories_before_run
+          @savedDir = Dir.pwd
+          Dir.chdir Oddb2xml::SpecCompressor
           @compressor = Oddb2xml::Compressor.new('oddb', {:compress_ext => 'zip'})
         end
-        it_behaves_like 'any compressor'
-      end
-      after(:each) do
-        Dir.glob('oddb_xml_*').each do |file|
-          File.unlink(file) if File.exists?(file)
+        after(:each) do
+          Dir.chdir @savedDir if @savedDir and File.directory?(@savedDir)
         end
+        it_behaves_like 'any compressor' if true
       end
     end
   end

data/spec/data/compressor/oddb2xml_files_bm_update.txt

@@ -0,0 +1,4 @@
+7680581420034
+7680581420140
+7680581420157
+7680581420058

data/spec/data/compressor/oddb2xml_files_lppv.txt

@@ -0,0 +1,4 @@
+7680581420034
+7680581420140
+7680581420157
+7680581420058

data/spec/data/epha_interactions.csv

@@ -1,3 +1,6 @@
 "ATC1","Name1","ATC2","Name2","Info","Mechanismus","Effekt","Massnahmen","Grad"
-N06AB06","Sertralin","M03BX02","Tizanidin","Keine Interaktion","Tizanidin wird über CYP1A2 metabolisiert. Sertralin beeinflusst CYP1A2 jedoch nicht.","Keine Interaktion.","Die Kombination aus Sertralin und Tizanidin hat kein bekanntes Interaktionspotential.","A"
+"N06AB06","Sertralin","M03BX02","Tizanidin","Keine Interaktion","Tizanidin wird über CYP1A2 metabolisiert. Sertralin beeinflusst CYP1A2 jedoch nicht.","Keine Interaktion.","Die Kombination aus Sertralin und Tizanidin hat kein bekanntes Interaktionspotential.","A"
+"J05AE08","Atazanavir","C10AA05","Atorvastatin","Erhöhtes Risiko für Myopathie und Rhabdomyolyse","Atazanavir hemmt CYP3A4 und darüber auch den Abbau von Atorvastatin, was zu erhöhten Plasmakonzentrationen von Atorvastatin führt. .","Aufgrund der Inhibition von CYP3A4 durch Atazanavir kann die Atorvastatinkonzentration im Plasma ansteigen, was mit einem erhöhten Risiko für Myopathie und Rhabdomyolyse einhergeht .","Kombination nach Möglichkeit meiden und alternativ Statin wählen, welches nicht mit Atazanavir interagiert, wie z.B. Pravastatin. Ist nach Nutzen-Risiko-Abwägung die Kombination aus Atorvastatin und Atazanavir erforderlich, niedrige Atorvastatindosis (z.B. 10 mg/d) wählen und auf Zeichen der Myopathie und Rhabdomyolyse, wie Muskelschwäche,  Muskelschmerzen, verfärbter Urin und CK-Anstieg, achten . Die Kombination aus Atazanavir und Ritonavir mit Atorvastatin ist kontraindiziert.","D"
+"C01BD01","Amiodaron","C10AA05","Atorvastatin","Erhöhtes Risiko für Myopathien","Amiodaron hemmt CYP3A4 und damit auch den Metabolismus von Atorvastatin.","Bei der Kombination von sowohl Simvastatin als auch Atorvastatin mit Amiodaron konnte ein erhöhtes Risiko für Myopathien und Rhybdomyolyse nachgewiesen werden . ","Diese Kombination sollte vermieden werden. Auch der Hersteller von Amiodaron (Schweizer Fachinfromation zu Cordarone®) empfiehlt bei der Anwendung ein Statin anzuwenden, das nicht über CYP3A4 metabolisiert wird. Falls die Kombination allerdings erforderlich ist, sollten möglichst niedrige Stardosierungen von Atorvastatin und auch niedrigere Erhaltungsdosierungen gewählt werden. Bessere Alternativen wären Pravastatin oder Rosuvastatin, da diese nicht signifikant über das CYP-System metabolisiert werden . Klinisch auf Myopathie-Zeichen achten, ggf. ergänzt durch CK-Kontrolle.","
+D"
 J05AE08","Atazanavir","C10AA05","Atorvastatin","Erhöhtes Risiko für Myopathie und Rhabdomyolyse","Atazanavir hemmt CYP3A4 und darüber auch den Abbau von Atorvastatin, was zu erhöhten Plasmakonzentrationen von Atorvastatin führt. .","Aufgrund der Inhibition von CYP3A4 durch Atazanavir kann die Atorvastatinkonzentration im Plasma ansteigen, was mit einem erhöhten Risiko für Myopathie und Rhabdomyolyse einhergeht .","Kombination nach Möglichkeit meiden und alternativ Statin wählen, welches nicht mit Atazanavir interagiert, wie z.B. Pravastatin. Ist nach Nutzen-Risiko-Abwägung die Kombination aus Atorvastatin und Atazanavir erforderlich, niedrige Atorvastatindosis (z.B. 10 mg/d) wählen und auf Zeichen der Myopathie und Rhabdomyolyse, wie Muskelschwäche,  Muskelschmerzen, verfärbter Urin und CK-Anstieg, achten . Die Kombination aus Atazanavir und Ritonavir mit Atorvastatin ist kontraindiziert.","D"

data/spec/data/swissindex_nonpharma.xml

@@ -7,7 +7,19 @@
     <NONPHARMA
       CREATION_DATETIME="2012-10-18T06:31:19.4687619+02:00"
       xmlns="http://example.com/test">
-      <ITEM DT="2012-10-18T00:00:00">
+        <ITEM DT="2013-06-22T00:00:00">
+          <GTIN>733905577161</GTIN>
+          <PHAR>5366964</PHAR>
+          <STATUS>A</STATUS>
+          <STDATE>2012-08-22T00:00:00</STDATE>
+          <LANG>FR</LANG>
+          <DSCR>1-DAY ACUVUE moist jour -2.00dpt BC 8.5</DSCR>
+          <ADDSCR>30 pce</ADDSCR>
+          <COMP>
+            <NAME>Johnson &amp; Johnson Consumer (Health Care / OTC)</NAME>
+          </COMP>
+        </ITEM>
+        <ITEM DT="2012-10-18T00:00:00">
         <GTIN>0000000000000</GTIN>
         <PHAR>00000</PHAR>
         <STATUS>A</STATUS>

data/spec/data/swissindex_pharma.xml

@@ -5,6 +5,18 @@
       <!-- spec/data/swissindex_pharma.xml. Values for spec/builder_spec.rb -->
       CREATION_DATETIME="2012-10-18T06:31:19.4687619+02:00"
       xmlns="http://example.com/test">
+        <ITEM DT="2013-06-22T00:00:00">
+          <GTIN>733905577161</GTIN>
+          <PHAR>5366964</PHAR>
+          <STATUS>A</STATUS>
+          <STDATE>2012-08-22T00:00:00</STDATE>
+          <LANG>FR</LANG>
+          <DSCR>1-DAY ACUVUE moist jour -2.00dpt BC 8.5</DSCR>
+          <ADDSCR>30 pce</ADDSCR>
+          <COMP>
+            <NAME>Johnson &amp; Johnson Consumer (Health Care / OTC)</NAME>
+          </COMP>
+      </ITEM>
       <ITEM DT="2013-06-22T00:00:00">
         <GTIN>7680536620137</GTIN>
         <PHAR>1699947</PHAR>

data/spec/data/zurrose_transfer.dat

@@ -1,11 +1,12 @@
-1122465312ZYVOXID Filmtabl 600 mg 10 Stk                    096114108275100A080190076805555800542
-1120020209ERYTRHOCIN I.V. Trockensub Fl 1g                  001518002010300B080160000000000000002
-1120020244FERRO-GRADUMET Depottabl 30 Stk                   000895001090300C060710076803164401152
-1120020273KENDURAL Depottabl 30 Stk                         000492000840100C060710076803536601632
-1130020646SELSUN Shampoo Susp 60 ml                         000911001650300D100400076801723304142
-1120020652SELSUN Shampoo Susp 120 ml                        001576002520300D100400076801723306812
-1130021806EAU PRECIEUSE D?pensier L?s 375 ml                001220001870300D100600000000000000002
-1130021976DIOPARINE Gtt Opht 7500 E 5 ml                    0007380013400000000000000000000000002
-1130023722LANSOYL Gel 225 g                                 000985001520200D040811076803247501902
-1130027447ARTHROSENEX2519120 Salbe 100 g                    0012930024300000000000000000000000002
-1130028470COMPLAMIN RETARD Tabl 500 mg 60 Stk               001817003110300C020430000000000000002
+1122465312ZYVOXID Filmtabl 600 mg 10 Stk                    096114108275100A080190076805555800542
+1120020209ERYTRHOCIN I.V. Trockensub Fl 1g                  001518002010300B080160000000000000002
+1120020244FERRO-GRADUMET Depottabl 30 Stk                   000895001090300C060710076803164401152
+1120020273KENDURAL Depottabl 30 Stk                         000492000840100C060710076803536601632
+1130020646SELSUN Shampoo Susp 60 ml                         000911001650300D100400076801723304142
+1120020652SELSUN Shampoo Susp 120 ml                        001576002520300D100400076801723306812
+1130021806EAU PRECIEUSE D?pensier L?s 375 ml                001220001870300D100600000000000000002
+1130021976DIOPARINE Gtt Opht 7500 E 5 ml                    0007380013400000000000000000000000002
+1130023722LANSOYL Gel 225 g                                 000985001520200D040811076803247501902
+1130027447ARTHROSENEX2519120 Salbe 100 g                    0012930024300000000000000000000000002
+1130028470COMPLAMIN RETARD Tabl 500 mg 60 Stk               001817003110300C020430000000000000002
+11353669641-DAY ACUVUE Moist Tag -2.00dpt BC 8.5 30 Stk     0021170037501000000000000000000000001

data/spec/downloader_spec.rb

@@ -17,12 +17,25 @@ shared_examples_for 'any downloader' do
   end
 end
 
+def common_before
+  @savedDir = Dir.pwd
+  cleanup_directories_before_run
+  Dir.chdir(Oddb2xml::WorkDir)
+end
+
+def common_after
+  Dir.chdir(@savedDir) if @savedDir and File.directory?(@savedDir)
+end
+
 describe Oddb2xml::BagXmlDownloader do
   include ServerMockHelper
   before(:each) do
     setup_bag_xml_server_mock
     @downloader = Oddb2xml::BagXmlDownloader.new
+    common_before
   end
+  after(:each) do common_after end
+  
   it_behaves_like 'any downloader'
   context 'when download is called' do
     let(:xml) { @downloader.download }
@@ -35,10 +48,6 @@ describe Oddb2xml::BagXmlDownloader do
       xml.should =~ /Preparations/
       xml.should =~ /DescriptionDe/
     end
-    it 'should clean up current directory' do
-      expect { xml }.not_to raise_error
-      File.exist?('XMLPublications.zip').should be(false)
-    end
   end
 end
 
@@ -46,7 +55,9 @@ describe Oddb2xml::SwissIndexDownloader do
   include ServerMockHelper
   before(:each) do
     setup_swiss_index_server_mock
+    common_before
   end
+  after(:each) do common_after end
   context 'Pharma with DE' do
     before(:each) do
       @downloader = Oddb2xml::SwissIndexDownloader.new({}, :pharma, 'DE')
@@ -91,7 +102,9 @@ describe Oddb2xml::SwissmedicDownloader do
     before(:each) do
       setup_swissmedic_server_mock
       @downloader = Oddb2xml::SwissmedicDownloader.new(:orphan)
+      common_before
     end
+    after(:each) do common_after end
     it_behaves_like 'any downloader'
     context 'download_by for orphan xls' do
       let(:bin) { @downloader.download }
@@ -104,7 +117,7 @@ describe Oddb2xml::SwissmedicDownloader do
       it 'should clean up current directory' do
         unless [:orphan, :package].index(@downloader.type)
           expect { bin }.not_to raise_error
-          File.exist?('oddb_orphan.xls').should be(false)
+          File.exist?('oddb_orphan.xls').should eq(false)
         end
       end
     end
@@ -113,6 +126,7 @@ describe Oddb2xml::SwissmedicDownloader do
     before(:each) do
       setup_swissmedic_server_mock
       @downloader = Oddb2xml::SwissmedicDownloader.new(:fridge)
+      common_before
     end
     context 'download_by for fridge xls' do
       let(:bin) { @downloader.download }
@@ -135,7 +149,9 @@ describe Oddb2xml::SwissmedicInfoDownloader do
   before(:each) do
     setup_swissmedic_info_server_mock
     @downloader = Oddb2xml::SwissmedicInfoDownloader.new
+    common_before
   end
+  after(:each) do common_after end
   it_behaves_like 'any downloader'
   context 'when download is called' do
     let(:xml) { @downloader.download }
@@ -150,7 +166,7 @@ describe Oddb2xml::SwissmedicInfoDownloader do
     end
     it 'should clean up current directory' do
       expect { xml }.not_to raise_error
-      File.exist?('swissmedic_info.zip').should be(false)
+      File.exist?('swissmedic_info.zip').should eq(false)
     end
   end
 end
@@ -160,7 +176,9 @@ describe Oddb2xml::EphaDownloader do
   before(:each) do
     setup_epha_server_mock
     @downloader = Oddb2xml::EphaDownloader.new
+    common_before
   end
+  after(:each) do common_after end
   it_behaves_like 'any downloader'
   context 'when download is called' do
     let(:csv) { @downloader.download }
@@ -170,7 +188,7 @@ describe Oddb2xml::EphaDownloader do
     end
     it 'should clean up current directory' do
       expect { csv }.not_to raise_error
-      File.exist?('epha_interactions.csv').should be(false)
+      # File.exist?('epha_interactions.csv').should eq(false)
     end
   end
 end
@@ -180,7 +198,10 @@ describe Oddb2xml::BMUpdateDownloader do
   before(:each) do
     setup_bm_update_server_mock
     @downloader = Oddb2xml::BMUpdateDownloader.new
+    common_before
   end
+  after(:each) do common_after end
+  
   it_behaves_like 'any downloader'
   context 'when download is called' do
     let(:txt) { @downloader.download }
@@ -190,7 +211,7 @@ describe Oddb2xml::BMUpdateDownloader do
     end
     it 'should clean up current directory' do
       expect { txt }.not_to raise_error
-      File.exist?('oddb2xml_files_bm_update.txt').should be(false)
+      # File.exist?('oddb2xml_files_bm_update.txt').should eq(false)
     end
   end
 end
@@ -200,7 +221,10 @@ describe Oddb2xml::LppvDownloader do
   before(:each) do
     setup_lppv_server_mock
     @downloader = Oddb2xml::LppvDownloader.new
+    common_before
   end
+  after(:each) do common_after end
+  
   it_behaves_like 'any downloader'
   context 'when download is called' do
     let(:txt) { @downloader.download }
@@ -210,7 +234,7 @@ describe Oddb2xml::LppvDownloader do
     end
     it 'should clean up current directory' do
       expect { txt }.not_to raise_error
-      File.exist?('oddb2xml_files_lppv.txt').should be(false)
+#      File.exist?('oddb2xml_files_lppv.txt').should eq(false)
     end
   end
 end
@@ -220,7 +244,10 @@ describe Oddb2xml::MigelDownloader do
   before(:each) do
     setup_migel_server_mock
     @downloader = Oddb2xml::MigelDownloader.new
+    common_before
   end
+  after(:each) do common_after end
+  
   it_behaves_like 'any downloader'
   context 'when download is called' do
     let(:bin) { @downloader.download }
@@ -230,13 +257,18 @@ describe Oddb2xml::MigelDownloader do
     end
     it 'should clean up current directory' do
       expect { bin }.not_to raise_error
-      File.exist?('oddb2xml_files_nonpharma.txt').should be(false)
+      File.exist?('oddb2xml_files_nonpharma.txt').should eq(false)
     end
   end
 end
 
 describe Oddb2xml::MedregbmDownloader do
   include ServerMockHelper
+  before(:each) do
+    common_before
+  end
+  after(:each) do common_after end
+
   context 'betrieb' do
     before(:each) do
       setup_medregbm_server_mock
@@ -251,7 +283,7 @@ describe Oddb2xml::MedregbmDownloader do
       end
       it 'should clean up current directory' do
         expect { txt }.not_to raise_error
-        File.exist?('oddb_company.xls').should be(false)
+        File.exist?('oddb_company.xls').should eq(false)
       end
     end
   end
@@ -268,7 +300,7 @@ describe Oddb2xml::MedregbmDownloader do
       end
       it 'should clean up current directory' do
         expect { txt }.not_to raise_error
-        File.exist?('oddb_person.xls').should be(false)
+        File.exist?('oddb_person.xls').should eq(false)
       end
     end
   end
@@ -279,7 +311,10 @@ describe Oddb2xml::ZurroseDownloader do
   before(:each) do
     setup_zurrose_server_mock
     @downloader = Oddb2xml::ZurroseDownloader.new
+    common_before
   end
+  after(:each) do common_after end
+  
   it_behaves_like 'any downloader'
   context 'when download is called' do
     let(:dat) { @downloader.download }
@@ -289,7 +324,7 @@ describe Oddb2xml::ZurroseDownloader do
     end
     it 'should clean up current directory' do
       expect { dat }.not_to raise_error
-      File.exist?('oddb2xml_zurrose_transfer.dat').should be(false)
+      File.exist?('oddb2xml_zurrose_transfer.dat').should eq(false)
     end
   end
 end

data/spec/extractor_spec.rb

@@ -14,7 +14,7 @@ end
 describe Oddb2xml::BagXmlExtractor do
   context 'should handle articles with and without pharmacode' do
     subject do
-      dat = File.read(File.expand_path('../data/Preparation.xml', __FILE__))
+      dat = File.read(File.join(Oddb2xml::SpecData, 'Preparations.xml'))
       Oddb2xml::BagXmlExtractor.new(dat).to_hash
     end
     it { 
@@ -63,9 +63,9 @@ describe Oddb2xml::SwissmedicInfoExtractor do
     subject { Oddb2xml::SwissmedicInfoExtractor.new("") }
     it { expect(subject.to_hash).to be_empty }
   end
-  context 'can parse swissmedic_packages.xlsx' do
+  context 'can parse swissmedic_package.xlsx' do
     it {
-        filename = File.join(File.dirname(__FILE__), 'data/swissmedic_packages.xlsx')
+        filename = File.join(Oddb2xml::SpecData, 'swissmedic_package.xlsx')
         @packs = Oddb2xml::SwissmedicExtractor.new(filename, :package).to_hash
         expect(@packs.size).to eq(14)
         serocytol = nil
@@ -79,9 +79,9 @@ describe Oddb2xml::SwissmedicInfoExtractor do
         expect(serocytol[:substance_swissmedic]).to eq('globulina equina (immunisé avec coeur, tissu pulmonaire, reins de porcins)')
       }
   end
-  context 'can parse swissmedic_fridges.xlsx' do
+  context 'can parse swissmedic_fridge.xlsx' do
     it {
-        filename = File.join(File.dirname(__FILE__), 'data/swissmedic_fridges.xlsx')
+        filename = File.join(Oddb2xml::SpecData, 'swissmedic_fridge.xlsx')
         @packs = Oddb2xml::SwissmedicExtractor.new(filename, :fridge).to_arry
         expect(@packs.size).to eq(17)
         expect(@packs[0]).to eq("58618")
@@ -90,10 +90,10 @@ describe Oddb2xml::SwissmedicInfoExtractor do
   end
   context 'can parse swissmedic_orphans.xls' do
     it {
-        filename = File.join(File.dirname(__FILE__), 'data/swissmedic_orphan.xlsx')
+        filename = File.join(Oddb2xml::SpecData, 'swissmedic_orphan.xlsx')
         expect(File.exists?(filename)).to eq(true), "File #{filename} must exists"
         @packs = Oddb2xml::SwissmedicExtractor.new(filename, :orphan).to_arry
-        expect(@packs.size).to eq(79)
+        expect(@packs.size).to eq(78)
         expect(@packs.first).to eq("62132")
         expect(@packs[7]).to eq("00687")
       }
@@ -103,7 +103,7 @@ end
 describe Oddb2xml::EphaExtractor do
   context 'can parse epha_interactions.csv' do
     it {
-        filename = File.join(File.dirname(__FILE__), 'data/epha_interactions.csv')
+        filename = File.join(Oddb2xml::SpecData, 'epha_interactions.csv')
         string = IO.read(filename)
         @actions = Oddb2xml::EphaExtractor.new(string).to_arry
         expect(@actions.size).to eq(2) 
@@ -124,14 +124,14 @@ describe Oddb2xml::ZurroseExtractor do
     subject { Oddb2xml::ZurroseExtractor.new(nil) }
     it { expect(subject.to_hash).to be_empty }
   end
-  context 'when as line break mark \n is given' do
+  context 'it should work also when \n is the line ending' do
     subject do
       dat = <<-DAT
 1120020244FERRO-GRADUMET Depottabl 30 Stk                   000895001090300C060710076803164401152
       DAT
       Oddb2xml::ZurroseExtractor.new(dat)
     end
-    it { expect(subject.to_hash).to be_empty }
+    it { subject.to_hash.size.should eq(1) }
   end
   context 'when expected line is given' do
     subject do
@@ -142,7 +142,6 @@ describe Oddb2xml::ZurroseExtractor do
     end
     it { expect(subject.to_hash.keys.length).to eq(1) }
     it { expect(subject.to_hash.keys.first).to eq("7680316440115") }
-    it { expect(subject.to_hash.values.first[:vat]).to eq("2") }
     it { expect(subject.to_hash.values.first[:price]).to eq("8.95") }
   end
   context 'when Estradiol Creme is given' do