octokit 1.25.0 → 2.0.0.pre

data/spec/octokit/client/labels_spec.rb

@@ -1,148 +1,115 @@
-# -*- encoding: utf-8 -*-
 require 'helper'
 
 describe Octokit::Client::Labels do
 
   before do
-    @client = Octokit::Client.new(:login => 'sferik')
+    Octokit.reset!
+    @client = oauth_client
   end
 
-  describe ".labels" do
-
+  describe ".labels", :vcr do
     it "returns labels" do
-      stub_get("/repos/pengwynn/octokit/labels").
-        to_return(json_response("labels.json"))
-      labels = @client.labels("pengwynn/octokit")
-      expect(labels.first.name).to eq("V3 Transition")
+      labels = @client.labels("octokit/octokit.rb")
+      expect(labels).to be_kind_of Array
+      assert_requested :get, github_url("/repos/octokit/octokit.rb/labels")
     end
+  end # .labels
 
-  end
-
-  describe ".label" do
-
-    it "returns a single labels" do
-      stub_get("/repos/pengwynn/octokit/labels/V3+Addition").
-        to_return(json_response('label.json'))
-      label = @client.label("pengwynn/octokit", "V3 Addition")
-      expect(label.name).to eq("V3 Addition")
+  describe ".label", :vcr do
+    it "returns a single label" do
+      label = @client.label("octokit/octokit.rb", "V3 Addition")
+      expect(label.name).to eq "V3 Addition"
+      assert_requested :get, github_url("/repos/octokit/octokit.rb/labels/V3+Addition")
     end
+  end # .label
 
-  end
-
-  describe ".add_label" do
-
+  describe ".add_label", :vcr do
     it "adds a label with a color" do
-      stub_post("/repos/pengwynn/octokit/labels").
-        with(:body => {"name" => "a significant bug", "color" => "ededed"}).
-        to_return(json_response('label.json'))
-      labels = @client.add_label("pengwynn/octokit", "a significant bug", 'ededed')
-      expect(labels.color).to eq("ededed")
-      expect(labels.name).to  eq("V3 Addition")
+      @client.delete_label!("api-playground/api-sandbox", 'test-label', {:color => 'ededed'})
+      label = @client.add_label("api-playground/api-sandbox", "test-label", 'ededed')
+      expect(label.color).to eq "ededed"
+      assert_requested :post, github_url("/repos/api-playground/api-sandbox/labels")
     end
-
     it "adds a label with default color" do
-      stub_post("/repos/pengwynn/octokit/labels").
-        with(:body => {"name" => "another significant bug", "color" => "ffffff"}).
-        to_return(json_response('label.json'))
-      labels = @client.add_label("pengwynn/octokit", "another significant bug")
-      expect(labels.color).to eq("ededed")
-      expect(labels.name).to  eq("V3 Addition")
+      @client.delete_label!("api-playground/api-sandbox", 'test-label', {:color => 'ededed'})
+      label = @client.add_label("api-playground/api-sandbox", "test-label")
+      assert_requested :post, github_url("/repos/api-playground/api-sandbox/labels")
     end
+  end # .add_label
 
-  end
-
-  describe ".update_label" do
+  context "methods requiring a new label", :vcr do
 
-    it "updates a label with a new color" do
-      stub_patch("/repos/pengwynn/octokit/labels/V3+Addition").
-        with(:body => {"color" => "ededed"},
-            :headers => {'Content-Type'=>'application/json'}).
-        to_return(json_response('label.json'))
-
-      label = @client.update_label("pengwynn/octokit", "V3 Addition", {:color => 'ededed'})
-      expect(label.color).to eq('ededed')
+    before do
+      @client.delete_label!("api-playground/api-sandbox", 'test-label', {:color => 'ededed'})
+      @label = @client.add_label("api-playground/api-sandbox", "test-label", 'ededed')
     end
 
+    describe ".update_label", :vcr do
+      it "updates a label with a new color" do
+        @client.update_label("api-playground/api-sandbox", @label.name, {:color => 'ffdd33'})
+        assert_requested :patch, github_url("/repos/api-playground/api-sandbox/labels/#{@label.name}")
+      end
+    end # .update_label
   end
 
-  describe ".delete_label!" do
-
-    it "deletes a label from the repository" do
-      stub_delete("/repos/pengwynn/octokit/labels/V3+Transition").
-       to_return(:status => 204)
-
-      result = @client.delete_label!("pengwynn/octokit", "V3 Transition")
-      expect(result).to eq(true)
+  context "methods requiring a new issue", :vcr do
+    before do
+      @issue = @client.create_issue("api-playground/api-sandbox", "Issue for label test", "The body")
     end
 
+    describe ".add_labels_to_an_issue", :vcr do
+      it "adds labels to a given issue" do
+        labels = @client.add_labels_to_an_issue('api-playground/api-sandbox', @issue.number, ['bug'])
+        assert_requested :post, github_url("/repos/api-playground/api-sandbox/issues/#{@issue.number}" + "/labels")
+      end
+    end # .add_labels_to_an_issue
+
+    describe ".labels_for_issue", :vcr do
+      it "returns all labels for a given issue" do
+        labels = @client.labels_for_issue('api-playground/api-sandbox', @issue.number)
+        expect(labels).to be_kind_of Array
+        assert_requested :get, github_url("/repos/api-playground/api-sandbox/issues/#{@issue.number}/labels")
+      end
+    end # .labels_for_issue
+
+    describe ".remove_label", :vcr do
+      it "removes a label from the specified issue" do
+        labels = @client.remove_label('api-playground/api-sandbox', @issue.number, 'bug')
+        assert_requested :delete, github_url("/repos/api-playground/api-sandbox/issues/#{@issue.number}" + "/labels/bug")
+      end
+    end # .remove_label
+
+    describe ".remove_all_labels", :vcr do
+      it "removes all labels from the specified issue" do
+        labels = @client.remove_all_labels('api-playground/api-sandbox', @issue.number)
+        assert_requested :delete, github_url("/repos/api-playground/api-sandbox/issues/#{@issue.number}" + "/labels")
+      end
+    end # .remove_all_labels
+
+    describe ".replace_all_labels", :vcr do
+      it "replaces all labels for an issue" do
+        labels = @client.replace_all_labels('api-playground/api-sandbox', @issue.number, ['bug', 'pdi'])
+        assert_requested :put, github_url("/repos/api-playground/api-sandbox/issues/#{@issue.number}" + "/labels")
+      end
+    end # .replace_all_labels
   end
 
-  describe ".remove_label" do
-
-    it "removes a label from the specified issue" do
-      stub_delete("/repos/pengwynn/octokit/issues/23/labels/V3+Transition").
-        to_return(json_response('labels.json'), :headers => {})
-
-      response = @client.remove_label("pengwynn/octokit", 23, "V3 Transition")
-      expect(response.last.name).to eq('Bug')
-    end
-
-  end
 
-  describe ".remove_all_labels" do
-
-    it "removes all labels from the specified issue" do
-     stub_delete("/repos/pengwynn/octokit/issues/23/labels").
-       to_return(:status => 204)
-
-     result = @client.remove_all_labels('pengwynn/octokit', 23)
-     expect(result).to eq(true)
-    end
-
-  end
-
-  describe ".add_labels_to_an_issue" do
-    it "adds labels to a given issue" do
-      stub_post("/repos/pengwynn/octokit/issues/42/labels").
-        with(:body => '["V3 Transition","Bug"]').
-        to_return(json_response('labels.json'), :headers => {})
-
-      labels = @client.add_labels_to_an_issue('pengwynn/octokit', 42, ['V3 Transition', 'Bug'])
-      expect(labels.first.name).to eq('V3 Transition')
-      expect(labels.last.name).to  eq('Bug')
-    end
-  end
-
-  describe ".replace_all_labels" do
-    it "replaces all labels for an issue" do
-       stub_put("/repos/pengwynn/octokit/issues/42/labels").
-         with(:body => '["V3 Transition","V3 Adding"]').
-         to_return(json_response('labels.json'), :headers => {})
-
-      labels = @client.replace_all_labels('pengwynn/octokit', 42, ['V3 Transition', 'V3 Adding'])
-      expect(labels.first.name).to eq('V3 Transition')
-    end
-  end
-
-  describe ".lables_for_milestone" do
+  describe ".lables_for_milestone", :vcr do
     it "returns all labels for a repository" do
-      stub_get('/repos/pengwynn/octokit/milestones/2/labels').
-        to_return(json_response('labels.json'), :headers => {})
-
-      labels = @client.labels_for_milestone('pengwynn/octokit', 2)
-      expect(labels.size).to eq(3)
+      labels = @client.labels_for_milestone('octokit/octokit.rb', 2)
+      expect(labels).to be_kind_of Array
+      assert_requested :get, github_url("/repos/octokit/octokit.rb/milestones/2/labels")
     end
-  end
+  end # .labels_for_milestone
 
-  describe ".labels_for_issue" do
-    it "returns all labels for a given issue" do
-      stub_get("/repos/pengwynn/octokit/issues/37/labels").
-        to_return(json_response('labels.json'), :headers => {})
 
-      labels = @client.labels_for_issue('pengwynn/octokit', 37)
-      expect(labels.first.name).to eq('V3 Transition')
-      expect(labels.last.name).to  eq('Bug')
+  describe ".delete_label!", :vcr do
+    it "deletes a label from the repository" do
+      label = @client.add_label("api-playground/api-sandbox", "delete-me-label")
+      @client.delete_label!("api-playground/api-sandbox", label.name, {:color => 'ededed'})
+      assert_requested :delete, github_url("/repos/api-playground/api-sandbox/labels/#{label.name}")
     end
-  end
+  end # .delete_label!
 
 end

data/spec/octokit/client/legacy_search_spec.rb

@@ -0,0 +1,42 @@
+require 'helper'
+
+describe Octokit::Client::LegacySearch do
+
+  before do
+    Octokit.reset!
+    @client = oauth_client
+  end
+
+  describe ".legacy_search_issues", :vcr do
+    it "returns matching issues" do
+      issues = @client.search_issues("sferik/rails_admin", "activerecord")
+      expect(issues).to_not be_empty
+      assert_requested :get, github_url("/legacy/issues/search/sferik/rails_admin/open/activerecord")
+    end
+  end # .search_issues
+
+  describe ".legacy_search_repos", :vcr do
+    it "returns matching repositories" do
+      repositories = @client.search_repositories("One40Proof")
+      expect(repositories).to_not be_empty
+      assert_requested :get, github_url("/legacy/repos/search/One40Proof")
+    end
+  end # .legacy_search_repos
+
+  describe ".legacy_search_users", :vcr do
+    it "returns matching username" do
+      users = @client.search_users("sferik")
+      expect(users.first.username).to eq("sferik")
+      assert_requested :get, github_url("/legacy/user/search/sferik")
+    end
+    it "should not raise URI::InvalidURIError and returns success" do
+      VCR.eject_cassette
+      VCR.turn_off!
+      stub_get("https://api.github.com/legacy/user/search/follower:>0")
+      expect { @client.search_users("follower:>0") }.to_not raise_error
+      assert_requested :get, github_url("/legacy/user/search/follower:%3E0")
+      VCR.turn_on!
+    end
+  end # .legacy_searcy_users
+
+end

data/spec/octokit/client/markdown_spec.rb

@@ -1,23 +1,20 @@
-# -*- encoding: utf-8 -*-
 require 'helper'
 
 describe Octokit::Client::Markdown do
 
-  describe ".markdown" do
-
-    before do
-      @client = Octokit::Client.new
-    end
+  before do
+    Octokit.reset!
+    @client = oauth_client
+  end
 
+  describe ".markdown", :vcr do
     it "renders markdown" do
-      stub_post("/markdown").
-        to_return(:body => fixture("markdown_gfm"))
       text = "This is for #111"
-      markdown = @client.markdown(text, :context => 'pengwynn/octokit', :mode => 'gfm')
+      markdown = @client.markdown(text, :context => 'octokit/octokit.rb', :mode => 'gfm')
 
-      expect(markdown).to include('https://github.com/pengwynn/octokit/issues/111')
+      expect(markdown).to include 'https://github.com/octokit/octokit.rb/issues/111'
+      assert_requested :post, github_url('/markdown')
     end
-
-  end
+  end # .markdown
 
 end

data/spec/octokit/client/meta_spec.rb

@@ -0,0 +1,14 @@
+require 'helper'
+
+describe Octokit::Client::Meta do
+
+  describe ".github_meta", :vcr do
+    it "returns meta information about github" do
+      client = oauth_client
+      github_meta = client.github_meta
+      expect(github_meta.git).to include "207.97.227.239/32"
+      assert_requested :get, github_url("/meta")
+    end
+  end # .github_meta
+
+end

data/spec/octokit/client/milestones_spec.rb

@@ -1,66 +1,58 @@
-# -*- encoding: utf-8 -*-
 require 'helper'
 
 describe Octokit::Client::Milestones do
 
   before do
-    @client = Octokit::Client.new(:login => 'sferik')
+    Octokit.reset!
+    @client = oauth_client
   end
 
-  describe ".list_milestones" do
-
+  describe ".list_milestones", :vcr do
     it "lists milestones belonging to repository" do
-      stub_get("/repos/pengwynn/octokit/milestones").
-        to_return(json_response('milestones.json'))
-      milestones = @client.list_milestones("pengwynn/octokit")
-      expect(milestones.first.description).to eq("Add support for API v3")
+      milestones = @client.list_milestones("api-playground/api-sandbox")
+      expect(milestones).to be_kind_of Array
+      assert_requested :get, github_url("/repos/api-playground/api-sandbox/milestones")
     end
+  end # .list_milestones
 
-  end
-
-  describe ".milestone" do
+  context "methods that need a milestone" do
 
-    it "gets a single milestone belonging to repository" do
-      stub_get("/repos/pengwynn/octokit/milestones/1").
-        to_return(json_response('milestone.json'))
-      milestones = @client.milestone("pengwynn/octokit", 1)
-      expect(milestones.description).to eq("Add support for API v3")
+    before(:each) do
+      name = "Test Milestone #{Time.now.to_i}"
+      @milestone = @client.create_milestone("api-playground/api-sandbox", name)
     end
 
-  end
-
-  describe ".create_milestone" do
-
-    it "creates a single milestone" do
-      stub_post("/repos/pengwynn/octokit/milestones").
-        with(:body => '{"title":"0.7.0"}').
-        to_return(json_response('milestone.json'))
-      milestone = @client.create_milestone("pengwynn/octokit", "0.7.0")
-      expect(milestone.title).to eq("0.7.0")
+    after(:each) do
+      @client.delete_milestone("api-playground/api-sandbox", @milestone.number)
     end
 
-  end
-
-  describe ".update_milestone" do
-
-    it "updates a milestone" do
-      stub_patch("/repos/pengwynn/octokit/milestones/1").
-        with(:body => {"description" => "Add support for API v3"}).
-        to_return(json_response('milestone.json'))
-      milestone = @client.update_milestone("pengwynn/octokit", 1, {:description => "Add support for API v3"})
-      expect(milestone.description).to eq("Add support for API v3")
-    end
-
-  end
-
-  describe ".delete_milestone" do
-
-    it "deletes a milestone from a repository" do
-      stub_delete("/repos/pengwynn/octokit/milestones/2").
-        to_return(:status => 204, :body => "", :headers => {})
-      result = @client.delete_milestone("pengwynn/octokit", 2)
-      expect(result).to eq(true)
-    end
+    describe ".milestone", :vcr do
+      it "gets a single milestone belonging to repository" do
+        milestone = @client.milestone("api-playground/api-sandbox", @milestone.number)
+        assert_requested :get, github_url("/repos/api-playground/api-sandbox/milestones/#{@milestone.number}")
+      end
+    end # .milestone
+
+    describe ".create_milestone", :vcr do
+      it "creates a milestone" do
+        expect(@milestone.title).to_not be_nil
+        assert_requested :post, github_url("/repos/api-playground/api-sandbox/milestones")
+      end
+    end # .create_milestone
+
+    describe ".update_milestone", :vcr do
+      it "updates a milestone" do
+        @client.update_milestone("api-playground/api-sandbox", @milestone.number, {:description => "Add support for API v3"})
+        assert_requested :patch, github_url("/repos/api-playground/api-sandbox/milestones/#{@milestone.number}")
+      end
+    end # .update_milestone
+
+    describe ".delete_milestone", :vcr do
+      it "deletes a milestone from a repository" do
+        @client.delete_milestone("api-playground/api-sandbox", @milestone.number)
+        assert_requested :delete, github_url("/repos/api-playground/api-sandbox/milestones/#{@milestone.number}")
+      end
+    end # .delete_milestone
 
   end
 

data/spec/octokit/client/notifications_spec.rb

@@ -1,140 +1,84 @@
-# -*- encoding: utf-8 -*-
 require 'helper'
 
 describe Octokit::Client::Notifications do
 
   before do
-    @client = Octokit::Client.new(:login => "joeyw")
+    Octokit.reset!
+    @client = oauth_client
   end
 
-  describe ".notifications" do
-
+  describe ".notifications", :vcr do
     it "lists the notifications for the current user" do
-      stub_get("https://api.github.com/notifications").
-        to_return(json_response("notifications.json"))
       notifications = @client.notifications
-      expect(notifications.first.id).to eq(1)
-      expect(notifications.first.unread).to eq(true)
+      expect(notifications).to be_kind_of Array
+      assert_requested :get, github_url("/notifications")
     end
+  end # .notifications
 
-  end
-
-  describe ".repository_notifications" do
-
+  describe ".repository_notifications", :vcr do
     it "lists all notifications for a repository" do
-      stub_get("https://api.github.com/repos/pengwynn/octokit/notifications").
-        to_return(json_response("repository_notifications.json"))
-      notifications = @client.repository_notifications("pengwynn/octokit")
-      expect(notifications.first.id).to eq(1)
-      expect(notifications.first.unread).to eq(true)
+      notifications = @client.repository_notifications("api-playground/api-sandbox")
+      expect(notifications).to be_kind_of Array
+      assert_requested :get, github_url("/repos/api-playground/api-sandbox/notifications")
     end
+  end # .repository_notifications
 
-  end
-
-  describe ".mark_notifications_as_read" do
-
+  describe ".mark_notifications_as_read", :vcr do
     it "returns true when notifications are marked as read" do
-      stub_put("https://api.github.com/notifications").
-        to_return(:status => 205)
       result = @client.mark_notifications_as_read
-      expect(result).to eq(true)
+      expect(result).to be_true
+      assert_requested :put, github_url("/notifications")
     end
+  end # .mark_notifications_as_read
 
-    it "returns false when unsuccessful" do
-      stub_put("https://api.github.com/notifications").
-        to_return(:status => 500)
-      result = @client.mark_notifications_as_read
-      expect(result).to be_false
-    end
-
-  end
-
-  describe ".mark_repository_notifications_as_read" do
-
+  describe ".mark_repository_notifications_as_read", :vcr do
     it "returns true when notifications for a repo are marked as read" do
-      stub_put("https://api.github.com/repos/pengwynn/octokit/notifications").
-        to_return(:status => 205)
-      result = @client.mark_repository_notifications_as_read("pengwynn/octokit")
-      expect(result).to eq(true)
-    end
-
-    it "returns false when unsuccessful" do
-      stub_put("https://api.github.com/repos/pengwynn/octokit/notifications").
-        to_return(:status => 500)
-      result = @client.mark_repository_notifications_as_read("pengwynn/octokit")
-      expect(result).to be_false
-    end
-
-  end
-
-  describe ".thread_notifications" do
-
-    it "returns notifications for a specific thread" do
-      stub_get("https://api.github.com/notifications/threads/1").
-        to_return(json_response('notification_thread.json'))
-      notifications = @client.thread_notifications(1)
-      expect(notifications.first.id).to eq(1)
-      expect(notifications.first.unread).to eq(true)
+      result = @client.mark_repository_notifications_as_read("api-playground/api-sandbox")
+      expect(result).to be_true
+      assert_requested :put, github_url("/repos/api-playground/api-sandbox/notifications")
     end
+  end # .mark_repository_notifications_as_read
 
-  end
-
-  describe ".mark_thread_as_read" do
-
-    it "marks a thread as read" do
-      stub_patch("https://api.github.com/notifications/threads/1").
-        to_return(:status => 205)
-      result = @client.mark_thread_as_read(1)
-      expect(result).to eq(true)
-    end
-
-    it "returns false when unsuccessful" do
-      stub_patch("https://api.github.com/notifications/threads/1").
-        to_return(:status => 500)
-      result = @client.mark_thread_as_read(1)
-      expect(result).to be_false
-    end
-
-  end
-
-  describe ".thread_subscription" do
-
-    it "returns a thread subscription" do
-      stub_get("https://api.github.com/notifications/threads/1/subscription").
-        to_return(json_response("thread_subscription.json"))
-      subscription = @client.thread_subscription(1)
-      expect(subscription.subscribed).to eq(true)
-    end
-
-  end
-
-  describe ".update_thread_subscription" do
-
-    it "updates a thread subscription" do
-      stub_put("https://api.github.com/notifications/threads/1/subscription").
-        to_return(json_response("thread_subscription_update.json"))
-      subscription = @client.update_thread_subscription(1, :subscribed => true)
-      expect(subscription.subscribed).to eq(true)
-    end
-
-  end
-
-  describe ".delete_thread_subscription" do
-
-    it "returns true with successful thread deletion" do
-      stub_delete("https://api.github.com/notifications/threads/1").
-        to_return(:status => 204)
-      result = @client.delete_thread_subscription(1)
-      expect(result).to eq(true)
-    end
+  context "methods that need a thread context" do
 
-    it "returns false when subscription deletion fails" do
-      stub_delete("https://api.github.com/notifications/threads/1").
-        to_return(:status => 404)
-      result = @client.delete_thread_subscription(1)
-      expect(result).to be_false
+    before(:each) do
+      @thread_id = @client.repository_notifications("api-playground/api-sandbox", :all => true).last.id
     end
 
+    describe ".thread_notifications", :vcr do
+      it "returns notifications for a specific thread" do
+        notifications = @client.thread_notifications(@thread_id)
+        assert_requested :get, github_url("/notifications/threads/#{@thread_id}")
+      end
+    end # .thread_notifications
+
+    describe ".mark_thread_as_read", :vcr do
+      it "marks a thread as read" do
+        result = @client.mark_thread_as_read(@thread_id)
+        assert_requested :patch, github_url("/notifications/threads/#{@thread_id}")
+      end
+    end # .mark_thread_as_read
+
+    describe ".thread_subscription", :vcr do
+      it "returns a thread subscription" do
+        subscription = @client.thread_subscription(@thread_id)
+        assert_requested :get, github_url("/notifications/threads/#{@thread_id}/subscription")
+      end
+    end # .thread_subscription
+
+    describe ".update_thread_subscription", :vcr do
+      it "updates a thread subscription" do
+        subscription = @client.update_thread_subscription(@thread_id, :subscribed => true)
+        assert_requested :put, github_url("/notifications/threads/#{@thread_id}/subscription")
+      end
+    end # .update_thread_subscription
+
+    describe ".delete_thread_subscription", :vcr do
+      it "returns true with successful thread deletion" do
+        result = @client.delete_thread_subscription(@thread_id)
+        assert_requested :delete, github_url("/notifications/threads/#{@thread_id}/subscription")
+      end
+    end # .delete_thread_subscription
 
   end