octokit 1.25.0 → 2.0.0.pre

data/spec/octokit/client/contents_spec.rb

@@ -1,156 +1,101 @@
-# -*- encoding: utf-8 -*-
 require 'helper'
 
 describe Octokit::Client::Contents do
 
   before do
-    @client = Octokit::Client.new(:login => 'sferik')
+    Octokit.reset!
+    @client = oauth_client
   end
 
-  describe ".readme" do
-
+  describe ".readme", :vcr do
     it "returns the default readme" do
-      stub_get("/repos/pengwynn/octokit/readme").
-        to_return(json_response("readme.json"))
-      readme = @client.readme('pengwynn/octokit')
-      expect(readme.encoding).to eq("base64")
-      expect(readme.type).to eq("file")
+      readme = @client.readme('octokit/octokit.rb')
+      expect(readme.encoding).to eq "base64"
+      expect(readme.type).to eq "file"
+      assert_requested :get, github_url("/repos/octokit/octokit.rb/readme")
     end
+  end # .readme
 
-  end
-
-  describe ".contents" do
-
+  describe ".contents", :vcr do
     it "returns the contents of a file" do
-      stub_get("/repos/pengwynn/octokit/contents/lib/octokit.rb").
-        to_return(json_response("contents.json"))
-      contents = @client.contents('pengwynn/octokit', :path => "lib/octokit.rb")
-      expect(contents.path).to eq("lib/octokit.rb")
-      expect(contents.name).to eq("lib/octokit.rb")
-      expect(contents.encoding).to eq("base64")
-      expect(contents.type).to eq("file")
+      contents = @client.contents('octokit/octokit.rb', :path => "lib/octokit.rb")
+      expect(contents.encoding).to eq "base64"
+      expect(contents.type).to eq "file"
+      assert_requested :get, github_url("/repos/octokit/octokit.rb/contents/lib/octokit.rb")
     end
+  end # .contents
 
-  end
-
-  describe ".archive_link" do
-
+  describe ".archive_link", :vcr do
     it "returns the headers of the request" do
-      stub_head("/repos/pengwynn/octokit/tarball/master").
-        to_return(:status => 302, :body => '', :headers =>
-          { 'location' => "https://nodeload.github.com/repos/pengwynn/octokit/tarball/"})
-      stub_head("https://nodeload.github.com/repos/pengwynn/octokit/tarball/").
-        to_return(:status => 200)
-
-      archive_link = @client.archive_link('pengwynn/octokit', :ref => "master")
-      expect(archive_link).to eq("https://nodeload.github.com/repos/pengwynn/octokit/tarball/")
+      archive_link = @client.archive_link('octokit/octokit.rb', :ref => "master")
+      expect(archive_link).to eq 'https://codeload.github.com/octokit/octokit.rb/legacy.tar.gz/master'
+      assert_requested :head, github_url("/repos/octokit/octokit.rb/tarball/master")
     end
+  end # .archive_link
 
-  end
-
-  describe ".create_contents" do
-    it "creates repository contents at a path" do
-      stub_put("/repos/pengwynn/api-sandbox/contents/foo/bar/baz.txt").
-        with({:body => {:message => "I am commit-ing", :content => "SGVyZSBiZSB0aGUgY29udGVudA=="}}).
-        to_return(json_response("create_content.json"))
+  # TODO: Make the following specs idempotent
 
-      response = @client.create_contents("pengwynn/api-sandbox",
-                                         "foo/bar/baz.txt",
+  describe ".create_contents", :vcr do
+    it "creates repository contents at a path", :vcr do
+      response = @client.create_contents("api-playground/api-sandbox",
+                                         "test_create.txt",
                                          "I am commit-ing",
-                                         "Here be the content")
-      expect(response.commit.sha).to eq '4810b8a0d076f20169bd2acca6501112f4d93e7d'
+                                         "Here be the content\n")
+      expect(response.commit.sha).to match /[a-z0-9]{40}/
+      assert_requested(:put, github_url("/repos/api-playground/api-sandbox/contents/test_create.txt"))
     end
-    it "creates contents from file path" do
-      stub_put("/repos/pengwynn/api-sandbox/contents/foo/bar/baz.txt").
-        with({:body => {:message => "I am commit-ing", :content => "SGVyZSBiZSB0aGUgY29udGVudAo="}}).
-        to_return(json_response("create_content.json"))
-
-      response = @client.create_contents("pengwynn/api-sandbox",
-                                         "foo/bar/baz.txt",
+    it "creates contents from file path", :vcr do
+      response = @client.create_contents("api-playground/api-sandbox",
+                                         "test_create_path.txt",
                                          "I am commit-ing",
                                          :file => "spec/fixtures/new_file.txt")
-      expect(response.commit.sha).to eq '4810b8a0d076f20169bd2acca6501112f4d93e7d'
+      expect(response.commit.sha).to match /[a-z0-9]{40}/
+      assert_requested(:put, github_url("/repos/api-playground/api-sandbox/contents/test_create_path.txt"))
     end
-    it "creates contents from File object" do
-      stub_put("/repos/pengwynn/api-sandbox/contents/foo/bar/baz.txt").
-        with({:body => {:message => "I am commit-ing", :content => "SGVyZSBiZSB0aGUgY29udGVudAo="}}).
-        to_return(json_response("create_content.json"))
-
+    it "creates contents from File object", :vcr do
       file = File.new "spec/fixtures/new_file.txt", "r"
-      response = @client.create_contents("pengwynn/api-sandbox",
-                                         "foo/bar/baz.txt",
+      response = @client.create_contents("api-playground/api-sandbox",
+                                         "test_create_file.txt",
                                          "I am commit-ing",
                                          :file => file)
-      expect(response.commit.sha).to eq '4810b8a0d076f20169bd2acca6501112f4d93e7d'
+      expect(response.commit.sha).to match /[a-z0-9]{40}/
+      assert_requested(:put, github_url("/repos/api-playground/api-sandbox/contents/test_create_file.txt"))
     end
-  end
+  end # .create_contents
 
-  describe ".update_contents" do
+  describe ".update_contents", :vcr do
     it "updates repository contents at a path" do
-      stub_put("/repos/pengwynn/api-sandbox/contents/foo/bar/baz.txt").
-        with({:body => {
-                :sha => "4d149b826e7305659006eb64cfecd3be68d0f2f0",
-                :message => "I am commit-ing",
-                :content => "SGVyZSBiZSBtb2FyIGNvbnRlbnQ="
-        }}).
-        to_return(json_response("update_content.json"))
-
-      response = @client.update_contents("pengwynn/api-sandbox",
-                                         "foo/bar/baz.txt",
+      content = @client.create_contents("api-playground/api-sandbox",
+                                         "test_update.txt",
                                          "I am commit-ing",
-                                         "4d149b826e7305659006eb64cfecd3be68d0f2f0",
+                                         :file => "spec/fixtures/new_file.txt")
+      response = @client.update_contents("api-playground/api-sandbox",
+                                         "test_update.txt",
+                                         "I am commit-ing",
+                                         content.content.sha,
                                          "Here be moar content")
-      expect(response.commit.sha).to eq '15ab9bfe8985e69d64e3d06b2eaf252cfbf43a6e'
-    end
-    it "updates repository contents with a file path" do
-      stub_put("/repos/pengwynn/api-sandbox/contents/foo/bar/baz.txt").
-        with({:body => {
-                :sha => "4d149b826e7305659006eb64cfecd3be68d0f2f0",
-                :message => "I am commit-ing",
-                :content => "SGVyZSBiZSBtb2FyIGNvbnRlbnQK"
-        }}).
-        to_return(json_response("update_content.json"))
+      expect(response.commit.sha).to match /[a-z0-9]{40}/
+      assert_requested :put,
+        github_url("/repos/api-playground/api-sandbox/contents/test_update.txt"),
+        :times => 2
 
-      response = @client.update_contents("pengwynn/api-sandbox",
-                                         "foo/bar/baz.txt",
-                                         "I am commit-ing",
-                                         "4d149b826e7305659006eb64cfecd3be68d0f2f0",
-                                         :file => "spec/fixtures/updated_file.txt")
-      expect(response.commit.sha).to eq '15ab9bfe8985e69d64e3d06b2eaf252cfbf43a6e'
     end
-    it "updates repository contents with a File object" do
-      stub_put("/repos/pengwynn/api-sandbox/contents/foo/bar/baz.txt").
-        with({:body => {
-                :sha => "4d149b826e7305659006eb64cfecd3be68d0f2f0",
-                :message => "I am commit-ing",
-                :content => "SGVyZSBiZSBtb2FyIGNvbnRlbnQK"
-        }}).
-        to_return(json_response("update_content.json"))
+  end # .update_contents
 
-      file = File.new "spec/fixtures/updated_file.txt", "r"
-      response = @client.update_contents("pengwynn/api-sandbox",
-                                         "foo/bar/baz.txt",
-                                         "I am commit-ing",
-                                         "4d149b826e7305659006eb64cfecd3be68d0f2f0",
-                                         :file => file)
-      expect(response.commit.sha).to eq '15ab9bfe8985e69d64e3d06b2eaf252cfbf43a6e'
-    end
-  end
-
-  describe ".delete_contents" do
+  describe ".delete_contents", :vcr do
     it "deletes repository contents at a path" do
-      stub_delete("/repos/pengwynn/api-sandbox/contents/foo/bar/baz.txt").
-        with({:query => {
-                :sha => "4d149b826e7305659006eb64cfecd3be68d0f2f0",
-                :message => "I am rm-ing"
-        }}).
-        to_return(json_response("delete_content.json"))
-
-      response = @client.delete_contents("pengwynn/api-sandbox",
-                                         "foo/bar/baz.txt",
+      content = @client.create_contents("api-playground/api-sandbox",
+                                         "test_delete.txt",
+                                         "I am commit-ing",
+                                         "You DELETE me")
+      response = @client.delete_contents("api-playground/api-sandbox",
+                                         "test_delete.txt",
                                          "I am rm-ing",
-                                         "4d149b826e7305659006eb64cfecd3be68d0f2f0")
-      expect(response.commit.sha).to eq '960a747b2f5c3837184b84e1f8cae7ef1a765e2f'
+                                         content.content.sha)
+      expect(response.commit.sha).to match /[a-z0-9]{40}/
+      assert_requested :delete,
+        github_url("/repos/api-playground/api-sandbox/contents/test_delete.txt")
     end
-  end
+  end # .delete_contents
+
 end

data/spec/octokit/client/downloads_spec.rb

@@ -1,63 +1,59 @@
-# -*- encoding: utf-8 -*-
 require 'helper'
 
 describe Octokit::Client::Downloads do
 
   before do
-    @client = Octokit::Client.new(:login => 'sferik')
+    Octokit.reset!
+    @client = oauth_client
   end
 
-  describe ".downloads" do
-
+  describe ".downloads", :vcr do
     it "lists available downloads" do
-      stub_get("/repos/github/hubot/downloads").
-        to_return(json_response("downloads.json"))
       downloads = @client.downloads("github/hubot")
-      expect(downloads.first.description).to eq("Robawt")
+      expect(downloads.last.description).to match "Campfire"
+      assert_requested :get, github_url("/repos/github/hubot/downloads")
     end
+  end # .downloads
 
-  end
-
-  describe ".download" do
-
+  describe ".download", :vcr do
     it "gets a single download" do
-      stub_get("/repos/github/hubot/downloads/165347").
-        to_return(json_response("download.json"))
       download = @client.download("github/hubot", 165347)
-      expect(download.id).to eq(165347)
-      expect(download.name).to eq('hubot-2.1.0.tar.gz')
+      expect(download.name).to eq "hubot-2.1.0.tar.gz"
+      assert_requested :get, github_url("/repos/github/hubot/downloads/165347")
     end
+  end # .download
 
-  end
+  context "methods that require a download" do
 
-  describe ".create_download" do
     before(:each) do
-      stub_post("/repos/octocat/Hello-World/downloads").
-        with(:body => {:name => "download_create.json", :size => 690,
-                       :description => "Description of your download",
-                       :content_type => "text/plain" }).
-        to_return(json_response("download_create.json"))
-    end
-    it "creates a download resource" do
-      resource = @client.send(:create_download_resource, "octocat/Hello-World", "download_create.json", 690, {:description => "Description of your download", :content_type => "text/plain"})
-      expect(resource.s3_url).to eq("https://github.s3.amazonaws.com/")
+      local_path = File.expand_path("spec/fixtures/web_flow_token.json")
+      options = { :description => Time.now.to_i.to_s, :content_type => "text/plain" }
+      @client.create_download "api-playground/api-sandbox", local_path, options
+
+      @download = @client.downloads("api-playground/api-sandbox").last
     end
 
-    it "posts to an S3 url" do
-      stub_post("https://github.s3.amazonaws.com/").
-        to_return(:status => 201)
-      file_path = File.expand_path 'spec/fixtures/download_create.json'
-      expect(@client.create_download("octocat/Hello-World", file_path, {:description => "Description of your download", :content_type => "text/plain"})).to eq(true)
+    after(:each) do
+      @client.delete_download 'api-playground/api-sandbox', @download.id
     end
-  end
 
-  describe ".delete_download" do
+    describe ".create_download", :vcr do
+      it "creates a download resource" do
+        assert_requested :post, github_url("/repos/api-playground/api-sandbox/downloads")
+      end
+      it "posts to an S3 url", :vcr do
+        assert_requested :post, "https://github.s3.amazonaws.com/"
+      end
+    end # .create_download
+
+
+    describe ".delete_download", :vcr do
+      it "deletes a download" do
+        @client.delete_download 'api-playground/api-sandbox', @download.id
+        assert_requested :delete, github_url("/repos/api-playground/api-sandbox/downloads/#{@download.id}")
+      end
+    end # .delete_download
 
-    it "deletes a download" do
-      stub_request(:delete, "https://api.github.com/repos/octocat/Hellow-World/downloads/165347").
-        to_return(:status => 204, :body => "", :headers => {})
-      expect(@client.delete_download('octocat/Hellow-World', 165347)).to eq(true)
-    end
   end
 
 end

data/spec/octokit/client/emojis_spec.rb

@@ -1,18 +1,12 @@
-# -*- encoding: utf-8 -*-
 require 'helper'
 
 describe Octokit::Client::Emojis do
-  before do
-    @client = Octokit::Client.new
-  end
 
-  describe ".emojis" do
+  describe ".emojis", :vcr do
     it "returns all github emojis" do
-      stub_get("/emojis").
-        to_return(json_response("emojis.json"))
-      emojis = @client.emojis
-      expect(emojis[:metal]).to eq('https://a248.e.akamai.net/assets.github.com/images/icons/emoji/metal.png?v5')
+      client = oauth_client
+      emojis = client.emojis
+      expect(emojis[:metal]).to match /metal/
     end
-  end
-
+  end # .emojis
 end

data/spec/octokit/client/events_spec.rb

@@ -1,90 +1,106 @@
-# -*- encoding: utf-8 -*-
 require 'helper'
 
 describe Octokit::Client::Events do
+
   before do
-    @client = Octokit::Client.new(:login => 'sferik')
+    Octokit.reset!
+    @client = oauth_client
   end
 
-  describe ".public_events" do
+  describe ".public_events", :vcr do
     it "returns all public events" do
-      stub_get("/events").
-        to_return json_response("public_events.json")
       public_events = @client.public_events
-      expect(public_events.first.id).to eq('1513284759')
+      expect(public_events).to be_kind_of Array
+      assert_requested :get, github_url("/events")
     end
-  end
+  end # .public_events
 
-  describe ".user_events" do
+  describe ".user_events", :vcr do
     it "returns all user events" do
-      stub_get("/users/sferik/events").
-        to_return json_response("user_events.json")
       user_events = @client.user_events('sferik')
-      expect(user_events.first.id).to eq('1525888969')
+      expect(user_events).to be_kind_of Array
+      assert_requested :get, github_url("/users/sferik/events")
     end
-  end
+  end # .user_events
 
-  describe ".user_public_events" do
-    it "returns public events performed by a GitHubber" do
-      stub_get("/users/sferik/events/public").
-        to_return json_response("user_performed_public_events.json")
+  describe ".user_public_events", :vcr do
+    it "returns public events performed by a user" do
       user_public_events = @client.user_public_events("sferik")
-      expect(user_public_events.first.id).to eq("1652715007")
+      expect(user_public_events).to be_kind_of Array
+      assert_requested :get, github_url("/users/sferik/events/public")
     end
-  end
+  end # .user_public_events
 
-  describe ".received_events" do
+  describe ".received_events", :vcr do
     it "returns all user received events" do
-      stub_get("/users/sferik/received_events").
-        to_return json_response("user_events.json")
-      received_events = @client.received_events('sferik')
-      expect(received_events.first.type).to eq('PushEvent')
+      received_events = @client.received_events("api-padawan")
+      expect(received_events).to be_kind_of Array
+      assert_requested :get, github_url("/users/api-padawan/received_events")
     end
-  end
+  end # .received_events
 
-  describe ".received_public_events" do
+  describe ".received_public_events", :vcr do
     it "returns public user received events" do
-      stub_get("/users/sferik/received_events/public").
-        to_return json_response("user_public_events.json")
-      received_public_events = @client.received_public_events("sferik")
-      expect(received_public_events.first.id).to eq("1652756065")
+      received_public_events = @client.received_public_events("api-padawan")
+      expect(received_public_events).to be_kind_of Array
+      assert_requested :get, github_url("/users/api-padawan/received_events/public")
     end
-  end
+  end # .received_public_events
 
-  describe ".repository_events" do
+  describe ".repository_events", :vcr do
     it "returns events for a repository" do
-      stub_get("/repos/sferik/rails_admin/events").
-        to_return json_response("repo_events.json")
       repo_events = @client.repository_events("sferik/rails_admin")
-      expect(repo_events.first.type).to eq("IssuesEvent")
+      expect(repo_events).to be_kind_of Array
+      assert_requested :get, github_url('/repos/sferik/rails_admin/events')
     end
-  end
+  end # .repository_events
 
-  describe ".repository_network_events" do
+  describe ".repository_network_events", :vcr do
     it "returns events for a repository's network" do
-      stub_get("/networks/sferik/rails_admin/events").
-        to_return json_response("repository_network_events.json")
       repo_network_events = @client.repository_network_events("sferik/rails_admin")
-      expect(repo_network_events.first.id).to eq("1651989733")
+      expect(repo_network_events).to be_kind_of Array
+      assert_requested :get, github_url('/networks/sferik/rails_admin/events')
     end
-  end
+  end # .repository_network_events
 
-  describe ".organization_events" do
+  describe ".organization_events", :vcr do
     it "returns all events for an organization" do
-      stub_get("/users/sferik/events/orgs/lostisland").
-        to_return json_response("organization_events.json")
-      org_events = @client.organization_events("lostisland")
-      expect(org_events.first.id).to eq("1652750175")
+      client = oauth_client
+      org_events = client.organization_events("github")
+      expect(org_events).to be_kind_of Array
+      assert_requested :get, github_url("/users/api-padawan/events/orgs/github")
     end
-  end
+  end # .organization_events
 
-  describe ".organization_public_events" do
+  describe ".organization_public_events", :vcr do
     it "returns an organization's public events" do
-      stub_get("/orgs/github/events").
-        to_return json_response("organization_public_events.json")
       org_public_events = @client.organization_public_events("github")
-      expect(org_public_events.first.id).to eq("1652750175")
+      expect(org_public_events).to be_kind_of Array
+      assert_requested :get, github_url("/orgs/github/events")
     end
-  end
+  end # .organization_public_events
+
+  describe ".repo_issue_events", :vcr do
+    it "lists issue events for a repository" do
+      issue_events = @client.repo_issue_events("octokit/octokit.rb")
+      expect(issue_events).to be_kind_of Array
+      assert_requested :get, github_url("/repos/octokit/octokit.rb/issues/events")
+    end
+  end # .repo_issue_events
 
+  describe ".issue_events", :vcr do
+    it "lists issue events for a repository" do
+      issue_events = @client.issue_events("octokit/octokit.rb", 4)
+      expect(issue_events).to be_kind_of Array
+      assert_requested :get, github_url("/repos/octokit/octokit.rb/issues/4/events")
+    end
+  end # .issue_events
+
+  describe ".issue_event", :vcr do
+    it "lists issue events for a repository" do
+      # TODO: Remove and use hypermedia
+      issue_events = @client.issue_event("octokit/octokit.rb", 37786228)
+      assert_requested :get, github_url("/repos/octokit/octokit.rb/issues/events/37786228")
+    end
+  end # .issue_events
 end