object_attorney 1.2.1 → 2.1.1

data/spec/support/form_objects/post_form.rb

@@ -0,0 +1,54 @@
+module PostForm
+  
+  class Base
+
+    include ObjectAttorney
+
+    represents :post
+
+    delegate_properties :title, :body, to: :post
+
+    has_many :comments
+
+    validates_presence_of :title
+
+  end
+
+
+  class Explicit
+
+    include ObjectAttorney
+
+    represents :post
+
+    has_many :comments
+
+    validates_presence_of :title
+
+    def body=(value)
+      post.body = value
+    end
+
+    def body
+      post.body
+    end
+
+    def title=(value)
+      post.title = value
+    end
+
+    def title
+      post.title
+    end
+
+    def build_comment(attributes = {})
+      post.comments.build(attributes)
+    end
+
+    def existing_comments
+      post.comments
+    end
+
+  end
+  
+end

data/spec/support/form_objects/post_with_comment_form.rb

@@ -0,0 +1,21 @@
+module PostWithCommentForm
+
+  class Base < PostForm::Base
+
+    has_many :comments, class_name: CommentForm
+
+  end
+  
+  class Explicit < PostForm::Base
+
+    def build_comment(attributes = {})
+      CommentForm.new(attributes)
+    end
+
+    def existing_comments
+      post.comments.map { |comment| CommentForm.new({}, comment) }
+    end
+
+  end
+  
+end

data/spec/support/form_objects/post_with_comments_and_address_form.rb

@@ -0,0 +1,13 @@
+class PostWithCommentsAndAddressForm
+  
+  include ObjectAttorney
+
+  represents :post, properties: [:title, :body]
+
+  has_many :comments
+  
+  has_one :address
+
+  validates_presence_of :title
+  
+end

data/spec/support/form_objects/user_form.rb

@@ -0,0 +1,11 @@
+class UserForm
+
+  include ObjectAttorney
+
+  represents :user, properties: [:email]
+
+  attr_accessor :terms_of_service
+
+  validates_acceptance_of :terms_of_service, accept: true, allow_nil: false
+
+end

data/spec/support/models/address.rb

@@ -0,0 +1,5 @@
+class Address < ActiveRecord::Base
+
+  belongs_to :post
+
+end

data/spec/support/models/comment.rb

@@ -0,0 +1,5 @@
+class Comment < ActiveRecord::Base
+
+  belongs_to :post
+
+end

data/spec/support/models/post.rb

@@ -1,3 +1,9 @@
 class Post < ActiveRecord::Base
-  validates_presence_of :title
+  
+  has_many :comments
+  
+  has_one :address
+
+  belongs_to :user
+  
 end

data/spec/support/models/user.rb

@@ -0,0 +1,7 @@
+class User < ActiveRecord::Base
+
+  has_many :posts
+
+  validates_presence_of :email
+
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: object_attorney
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 2.1.1
 platform: ruby
 authors:
 - João Gonçalves
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-18 00:00:00.000000000 Z
+date: 2014-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -67,7 +67,10 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
+- db/migrate/20131205114000_create_users.rb
 - db/migrate/20131205114900_create_posts.rb
+- db/migrate/20131205114901_create_comments.rb
+- db/migrate/20131205114902_create_addresses.rb
 - db/schema.rb
 - lib/object_attorney.rb
 - lib/object_attorney/association_reflection.rb
@@ -76,21 +79,33 @@ files:
 - lib/object_attorney/nested_uniqueness_validator.rb
 - lib/object_attorney/orm.rb
 - lib/object_attorney/orm_handlers/smooth_operator.rb
+- lib/object_attorney/reflection.rb
 - lib/object_attorney/version.rb
 - object_attorney.gemspec
-- spec/object_attorney/bulk_posts_form_child_spec.rb
-- spec/object_attorney/bulk_posts_form_spec.rb
-- spec/object_attorney/post_form_child_spec.rb
+- spec/object_attorney/bulk_post_form_spec.rb
+- spec/object_attorney/bulk_posts_allow_only_existing_form_spec.rb
+- spec/object_attorney/bulk_posts_allow_only_new_form_spec.rb
+- spec/object_attorney/bulk_posts_with_form_objects_form_spec.rb
 - spec/object_attorney/post_form_spec.rb
+- spec/object_attorney/post_with_comment_form_spec.rb
+- spec/object_attorney/post_with_comments_and_address_form_spec.rb
+- spec/object_attorney/user_form_spec.rb
 - spec/spec_helper.rb
 - spec/support/active_model/validations.rb
 - spec/support/database_setup.rb
-- spec/support/models/bulk_posts_form.rb
-- spec/support/models/bulk_posts_form_child.rb
-- spec/support/models/item.rb
+- spec/support/form_objects/bulk_posts_allow_only_existing_form.rb
+- spec/support/form_objects/bulk_posts_allow_only_new_form.rb
+- spec/support/form_objects/bulk_posts_form.rb
+- spec/support/form_objects/bulk_posts_with_form_objects_form.rb
+- spec/support/form_objects/comment_form.rb
+- spec/support/form_objects/post_form.rb
+- spec/support/form_objects/post_with_comment_form.rb
+- spec/support/form_objects/post_with_comments_and_address_form.rb
+- spec/support/form_objects/user_form.rb
+- spec/support/models/address.rb
+- spec/support/models/comment.rb
 - spec/support/models/post.rb
-- spec/support/models/post_form.rb
-- spec/support/models/post_form_child.rb
+- spec/support/models/user.rb
 homepage: https://github.com/goncalvesjoao/object_attorney
 licenses:
 - MIT
@@ -118,17 +133,27 @@ summary: This gem allows you to extract the code responsible for 'validations',
   objects' and 'strong parameters' from your model onto a specific class for a specific
   use case.
 test_files:
-- spec/object_attorney/bulk_posts_form_child_spec.rb
-- spec/object_attorney/bulk_posts_form_spec.rb
-- spec/object_attorney/post_form_child_spec.rb
+- spec/object_attorney/bulk_post_form_spec.rb
+- spec/object_attorney/bulk_posts_allow_only_existing_form_spec.rb
+- spec/object_attorney/bulk_posts_allow_only_new_form_spec.rb
+- spec/object_attorney/bulk_posts_with_form_objects_form_spec.rb
 - spec/object_attorney/post_form_spec.rb
+- spec/object_attorney/post_with_comment_form_spec.rb
+- spec/object_attorney/post_with_comments_and_address_form_spec.rb
+- spec/object_attorney/user_form_spec.rb
 - spec/spec_helper.rb
 - spec/support/active_model/validations.rb
 - spec/support/database_setup.rb
-- spec/support/models/bulk_posts_form.rb
-- spec/support/models/bulk_posts_form_child.rb
-- spec/support/models/item.rb
+- spec/support/form_objects/bulk_posts_allow_only_existing_form.rb
+- spec/support/form_objects/bulk_posts_allow_only_new_form.rb
+- spec/support/form_objects/bulk_posts_form.rb
+- spec/support/form_objects/bulk_posts_with_form_objects_form.rb
+- spec/support/form_objects/comment_form.rb
+- spec/support/form_objects/post_form.rb
+- spec/support/form_objects/post_with_comment_form.rb
+- spec/support/form_objects/post_with_comments_and_address_form.rb
+- spec/support/form_objects/user_form.rb
+- spec/support/models/address.rb
+- spec/support/models/comment.rb
 - spec/support/models/post.rb
-- spec/support/models/post_form.rb
-- spec/support/models/post_form_child.rb
-has_rdoc: 
+- spec/support/models/user.rb

data/spec/object_attorney/bulk_posts_form_child_spec.rb

@@ -1,191 +0,0 @@
-require "spec_helper"
-
-describe BulkPostsFormChild do
-
-  it "Creating multiple Posts, with a tabless model 'BulkPostsFormChild' has if it had 'accepts_nested_attributes_for :posts'", current: true do
-    params = {
-      bulk_post: {
-        admin: true,
-        posts_attributes: {
-          "0" => { state: "draft", title: "My title1" },
-          "1" => { state: "public", title: "My title2" }
-        }
-      }
-    }
-
-    bulk_posts_form_child = BulkPostsFormChild.new(params[:bulk_post])
-    bulk_posts_form_child.save
-    
-    expect(Post.all.count).to(eq(2))
-  end
-
-  it "Trying to create multiple Posts, with the same title (testing the 'validates_nested_uniqueness')" do
-    params = {
-      bulk_post: {
-        admin: true,
-        posts_attributes: {
-          "0" => { state: "draft", title: "My title1" },
-          "1" => { state: "public", title: "My title1" }
-        }
-      }
-    }
-
-    bulk_posts_form = BulkPostsFormChild.new(params[:bulk_post])
-    bulk_posts_form.save
-    
-    # TODO: Ensure that the nested objects remember their respective errors
-    # see: http://stackoverflow.com/questions/13879700/rails-model-valid-flusing-custom-errors-and-falsely-returning-true
-    
-    expect(Post.all.count).to(eq(0))
-  end
-
-  it "Creating new Post and editing an existing one" do
-    params = {
-      bulk_post: {
-        admin: true,
-        posts_attributes: {
-          "0" => { id: 1, state: "draft", title: "Changed title" },
-          "1" => { state: "public", title: "My title2" }
-        }
-      }
-    }
-    
-    existing_post = Post.create(title: "My title1")
-    BulkPostsFormChild.new(params[:bulk_post]).save
-    existing_post.reload
-    
-    expect(Post.all.count).to(eq(2)) && expect(existing_post.title).to(eq('Changed title'))
-  end
-
-  it "Creating new Post and deleting an existing one" do
-    params = {
-      bulk_post: {
-        admin: true,
-        posts_attributes: {
-          "0" => { id: 1, state: "draft", title: "Changed title", _destroy: true },
-          "1" => { state: "public", title: "My title2" }
-        }
-      }
-    }
-
-    existing_post = Post.create(title: "My title1")
-    BulkPostsFormChild.new(params[:bulk_post]).save
-    
-    expect(Post.all.count).to(eq(1)) && expect(Post.where(id: existing_post.id).present?).to(eq(false))
-  end
-
-  it "Trying to create multiple Posts, but one of them is invalid" do
-    params = {
-      bulk_post: {
-        admin: true,
-        posts_attributes: {
-          "0" => { title: "My title1" },
-          "1" => { state: "public", title: "My title2" }
-        }
-      }
-    }
-
-    BulkPostsFormChild.new(params[:bulk_post]).save
-
-    params = {
-      bulk_post: {
-        admin: true,
-        posts_attributes: {
-          "0" => { state: 'draft', title: "My title1" },
-          "1" => { state: "public" }
-        }
-      }
-    }
-
-    BulkPostsFormChild.new(params[:bulk_post]).save
-    
-    expect(Post.all.count).to(eq(0))
-  end
-
-  it "Trying to create new Post and editing an existing one, but one of them is invalid" do
-    params = {
-      bulk_post: {
-        admin: true,
-        posts_attributes: {
-          "0" => { id: 1, title: "Changed title" },
-          "1" => { state: "public", title: "My title2" }
-        }
-      }
-    }
-
-    existing_post = Post.create(title: "My title1")
-    BulkPostsFormChild.new(params[:bulk_post]).save
-    existing_post.reload
-    
-    expect(Post.all.count).to(eq(1)) && expect(existing_post.title).to(eq('My title1'))
-
-    params = {
-      bulk_post: {
-        admin: true,
-        posts_attributes: {
-          "0" => { id: 1, state: 'draft', title: "Changed title" },
-          "1" => { state: "public" }
-        }
-      }
-    }
-
-    BulkPostsFormChild.new(params[:bulk_post]).save
-    existing_post.reload
-    
-    expect(Post.all.count).to(eq(1)) && expect(existing_post.title).to(eq('My title1'))
-  end
-
-  it "Trying to create new Post and deleting an existing one, but the new one is invalid" do
-    params = {
-      bulk_post: {
-        admin: true,
-        posts_attributes: {
-          "0" => { id: 1, state: "draft", title: "Changed title", _destroy: true },
-          "1" => { state: "public" }
-        }
-      }
-    }
-
-    existing_post = Post.create(title: "My title1")
-    BulkPostsFormChild.new(params[:bulk_post]).save
-    existing_post.reload
-    
-    expect(Post.all.count).to(eq(1)) && expect(existing_post.title).to(eq('My title1'))
-  end
-
-  it "Trying to create new Post and deleting an existing one, the existing one is invalid but since it is marked for destruction, it should be deleted" do
-    params = {
-      bulk_post: {
-        admin: true,
-        posts_attributes: {
-          "0" => { id: 1, title: "Changed title", _destroy: true },
-          "1" => { state: "public", title: "My title2" }
-        }
-      }
-    }
-
-    existing_post = Post.create(title: "My title1")
-    bulk_posts_form_child = BulkPostsFormChild.new(params[:bulk_post])
-    bulk_posts_form_child.save
-    
-    expect(Post.all.count).to(eq(1)) && expect(Post.where(id: existing_post.id).present?).to(eq(false))
-  end
-
-  it "Trying to create new Post and deleting an existing one, both of them are invalid, no changes should occur." do
-    params = {
-      bulk_post: {
-        admin: true,
-        posts_attributes: {
-          "0" => { id: 1, title: "Changed title", _destroy: true },
-          "1" => { state: "public" }
-        }
-      }
-    }
-
-    existing_post = Post.create(title: "My title1")
-    BulkPostsFormChild.new(params[:bulk_post]).save
-    
-    expect(Post.all.count).to(eq(1)) && expect(existing_post.title).to(eq('My title1'))
-  end
-
-end

data/spec/object_attorney/bulk_posts_form_spec.rb

@@ -1,178 +0,0 @@
-require "spec_helper"
-
-describe BulkPostsForm do
-
-  it "Creating multiple Posts, with a tabless model 'BulkPostsForm' has if it had 'accepts_nested_attributes_for :posts'" do
-    params = {
-      bulk_post: {
-        posts_attributes: {
-          "0" => { state: "draft", title: "My title1" },
-          "1" => { state: "public", title: "My title2" }
-        }
-      }
-    }
-
-    BulkPostsForm.new(params[:bulk_post]).save
-    
-    expect(Post.all.count).to(eq(2))
-  end
-
-  it "Creating multiple Posts, with the same title (testing the 'validates_nested_uniqueness')" do
-    params = {
-      bulk_post: {
-        posts_attributes: {
-          "0" => { state: "draft", title: "My title1" },
-          "1" => { state: "public", title: "My title1" }
-        }
-      }
-    }
-
-    bulk_posts_form = BulkPostsForm.new(params[:bulk_post])
-    bulk_posts_form.save
-    
-    # TODO: Ensure that the nested objects remember their respective errors
-    # see: http://stackoverflow.com/questions/13879700/rails-model-valid-flusing-custom-errors-and-falsely-returning-true
-    
-    expect(Post.all.count).to(eq(0))
-  end
-
-  it "Creating new Post and editing an existing one" do
-    params = {
-      bulk_post: {
-        posts_attributes: {
-          "0" => { id: 1, state: "draft", title: "Changed title" },
-          "1" => { state: "public", title: "My title2" }
-        }
-      }
-    }
-
-    existing_post = Post.create(title: "My title1")
-    BulkPostsForm.new(params[:bulk_post]).save
-    existing_post.reload
-    
-    expect(Post.all.count).to(eq(2)) && expect(existing_post.title).to(eq('Changed title'))
-  end
-
-  it "Creating new Post and deleting an existing one" do
-    params = {
-      bulk_post: {
-        posts_attributes: {
-          "0" => { id: 1, state: "draft", title: "Changed title", _destroy: true },
-          "1" => { state: "public", title: "My title2" }
-        }
-      }
-    }
-
-    existing_post = Post.create(title: "My title1")
-    BulkPostsForm.new(params[:bulk_post]).save
-    
-    expect(Post.all.count).to(eq(1)) && expect(Post.where(id: existing_post.id).present?).to(eq(false))
-  end
-
-  it "Trying to create multiple Posts, but one of them is invalid" do
-    params = {
-      bulk_post: {
-        posts_attributes: {
-          "0" => { title: "My title1" },
-          "1" => { state: "public", title: "My title2" }
-        }
-      }
-    }
-
-    BulkPostsForm.new(params[:bulk_post]).save
-
-    params = {
-      bulk_post: {
-        posts_attributes: {
-          "0" => { state: 'draft', title: "My title1" },
-          "1" => { state: "public" }
-        }
-      }
-    }
-
-    BulkPostsForm.new(params[:bulk_post]).save
-    
-    expect(Post.all.count).to(eq(0))
-  end
-
-  it "Trying to create new Post and editing an existing one, but one of them is invalid" do
-    params = {
-      bulk_post: {
-        posts_attributes: {
-          "0" => { id: 1, title: "Changed title" },
-          "1" => { state: "public", title: "My title2" }
-        }
-      }
-    }
-
-    existing_post = Post.create(title: "My title1")
-    BulkPostsForm.new(params[:bulk_post]).save
-    existing_post.reload
-    
-    expect(Post.all.count).to(eq(1)) && expect(existing_post.title).to(eq('My title1'))
-
-    params = {
-      bulk_post: {
-        posts_attributes: {
-          "0" => { id: 1, state: 'draft', title: "Changed title" },
-          "1" => { state: "public" }
-        }
-      }
-    }
-
-    BulkPostsForm.new(params[:bulk_post]).save
-    existing_post.reload
-    
-    expect(Post.all.count).to(eq(1)) && expect(existing_post.title).to(eq('My title1'))
-  end
-
-  it "Trying to create new Post and deleting an existing one, but the new one is invalid" do
-    params = {
-      bulk_post: {
-        posts_attributes: {
-          "0" => { id: 1, state: "draft", title: "Changed title", _destroy: true },
-          "1" => { state: "public" }
-        }
-      }
-    }
-
-    existing_post = Post.create(title: "My title1")
-    BulkPostsForm.new(params[:bulk_post]).save
-    existing_post.reload
-    
-    expect(Post.all.count).to(eq(1)) && expect(existing_post.title).to(eq('My title1'))
-  end
-
-  it "Trying to create new Post and deleting an existing one, the existing one is invalid but since it is marked for destruction, it should be deleted" do
-    params = {
-      bulk_post: {
-        posts_attributes: {
-          "0" => { id: 1, title: "Changed title", _destroy: true },
-          "1" => { state: "public", title: "My title2" }
-        }
-      }
-    }
-
-    existing_post = Post.create(title: "My title1")
-    BulkPostsForm.new(params[:bulk_post]).save
-    
-    expect(Post.all.count).to(eq(1)) && expect(Post.where(id: existing_post.id).present?).to(eq(false))
-  end
-
-  it "Trying to create new Post and deleting an existing one, both of them are invalid, no changes should occur." do
-    params = {
-      bulk_post: {
-        posts_attributes: {
-          "0" => { id: 1, title: "Changed title", _destroy: true },
-          "1" => { state: "public" }
-        }
-      }
-    }
-
-    existing_post = Post.create(title: "My title1")
-    BulkPostsForm.new(params[:bulk_post]).save
-    
-    expect(Post.all.count).to(eq(1)) && expect(existing_post.title).to(eq('My title1'))
-  end
-
-end

data/spec/object_attorney/post_form_child_spec.rb

@@ -1,60 +0,0 @@
-require "spec_helper"
-
-describe PostFormChild do
-
-  it "PostFormChild becomes invalid when Post does and incorporates its errors" do
-    post = Post.new
-    post.should have(1).error_on(:title)
-    post.title = "My title"
-    post.should have(:no).errors_on(:title)
-
-    post_form = PostFormChild.new({ state: 'draft', date: Date.today })
-    post_form.should have(1).error_on(:title)
-    post_form.title = "My title"
-    post_form.should have(:no).errors_on(:title)
-  end
-
-  it "PostFormChild may require the validations of fields that Post doesn't have" do
-    params = { post: { title: "My title" } }
-
-    post = Post.new(params[:post])
-    post.should have(:no).errors_on(:date)
-
-    post_form = PostFormChild.new(params[:post].merge(state: 'public'))
-    post_form.should have(1).error_on(:date)
-    post_form.date = Date.today
-    post_form.should have(:no).errors_on(:date)
-  end
-
-  it "Post creation through PostFormChild" do
-    params = { post: { state: 'public', title: "My title", body: "My body", date: Date.today } }
-    post_form = PostFormChild.new(params[:post])
-
-    expect(post_form.save).to(eq(true)) && expect(post_form.post.persisted?).to(eq(true))
-  end
-
-  it "Post can't be created if PostFormChild isn't valid" do
-    params = { post: { state: 'public', title: "My title", body: "My body" } }
-    post_form = PostFormChild.new(params[:post])
-
-    expect(post_form.save).to(eq(false)) && expect(post_form.post.persisted?).to(eq(false))
-  end
-
-  it "Post can't be created if Post isn't valid" do
-    params = { post: { state: 'public', date: Date.today, body: "My body" } }
-    post_form = PostFormChild.new(params[:post])
-
-    expect(post_form.save).to(eq(false)) && expect(post_form.post.persisted?).to(eq(false))
-  end
-
-  it "PostFormChild won't allow weak params to be updated, unlike Post" do
-    params = { post: { title: 'My title', body: "My body", admin: true } }
-
-    post_form = PostFormChild.new(params[:post].merge({ state: 'public', date: Date.today }))
-    expect(post_form.save).to(eq(true)) && expect(post_form.post.admin).to(eq(false))
-    
-    post = Post.new(params[:post])
-    expect(post.save).to(eq(true)) && expect(post.admin).to(eq(true))
-  end
-
-end

data/spec/support/models/bulk_posts_form.rb

@@ -1,21 +0,0 @@
-require 'object_attorney/nested_uniqueness_validator'
-
-class BulkPostsForm
-
-  include ObjectAttorney
-
-  accepts_nested_objects :posts
-
-  validates_nested_uniqueness :posts, uniq_value: :title
-
-  ##################### BODY BELLOW THIS LINE ####################
-
-  def build_post(attributes = {}, post = nil)
-    PostForm.new(attributes, post)
-  end
-
-  def existing_posts
-    Post.all.map { |post| build_post({}, post) }
-  end
-
-end