object_attorney 1.2.1 → 2.1.1

data/spec/object_attorney/bulk_posts_allow_only_new_form_spec.rb

@@ -0,0 +1,39 @@
+require "spec_helper"
+
+shared_examples "a BulkPostsAllowOnlyNewForm" do
+
+  it "1. Tabless model 'BulkPostsAllowOnlyNewForm' only accepts new 'Post' requests and ignores editing requests." do
+    params = {
+      bulk_post: {
+        posts_attributes: {
+          "0" => { title: "new post" },
+          "1" => { id: 1, title: 'altered post' },
+          "2" => { id: 2, title: '', _destroy: true }
+        }
+      }
+    }
+
+    Post.create(title: "My title1")
+    Post.create(title: "My title2")
+    Post.all.count.should == 2
+    Post.find_by_id(1).title.should == 'My title1'
+    Post.find_by_id(2).title.should == 'My title2'
+
+    buld_posts_form = described_class.new(params[:bulk_post])
+    buld_posts_form.save
+    
+    Post.all.count.should == 3
+    Post.find_by_id(1).title.should == 'My title1'
+    Post.find_by_id(2).title.should == 'My title2'
+    Post.find_by_id(3).title.should == 'new post'
+  end
+
+end
+
+describe BulkPostsAllowOnlyNewForm::Base do
+  it_behaves_like 'a BulkPostsAllowOnlyNewForm'
+end
+
+describe BulkPostsAllowOnlyNewForm::Explicit do
+  it_behaves_like 'a BulkPostsAllowOnlyNewForm'
+end

data/spec/object_attorney/bulk_posts_with_form_objects_form_spec.rb

@@ -0,0 +1,91 @@
+require "spec_helper"
+
+shared_examples "a BulkPostsWithFormObjectsForm" do
+
+  it "1. If any of the 'Post's is invalid, no changes should take effect." do
+    params = {
+      bulk_post: {
+        posts_attributes: {
+          "0" => { title: "new post" },
+          "1" => { id: 1, title: '' },
+          "2" => { id: 2, title: 'to be destroyed', _destroy: true }
+        }
+      }
+    }
+
+    Post.create(title: "My title1")
+    Post.create(title: "My title2")
+    Post.all.count.should == 2
+    Post.find_by_id(1).title.should == 'My title1'
+    Post.find_by_id(2).title.should == 'My title2'
+
+    bulk_posts_form = described_class.new(params[:bulk_post])
+    bulk_posts_form.save
+    
+    bulk_posts_form.posts.first.should have(1).errors_on(:title)
+    Post.all.count.should == 2
+    Post.find_by_id(1).title.should == 'My title1'
+    Post.find_by_id(2).title.should == 'My title2'
+  end
+
+  it "2. A soon to be deleted 'Post' that is invalid, should not stop all other changes." do
+    params = {
+      bulk_post: {
+        posts_attributes: {
+          "0" => { title: "new post" },
+          "1" => { id: 1, title: 'altered post' },
+          "2" => { id: 2, title: '', _destroy: true }
+        }
+      }
+    }
+
+    Post.create(title: "My title1")
+    Post.create(title: "My title2")
+    Post.all.count.should == 2
+    Post.find_by_id(1).title.should == 'My title1'
+    Post.find_by_id(2).title.should == 'My title2'
+
+    bulk_posts_form = described_class.new(params[:bulk_post])
+    bulk_posts_form.save
+    
+    bulk_posts_form.posts.second.id.should == 2
+    bulk_posts_form.posts.second.persisted?.should == false
+    bulk_posts_form.posts.second.should have(:no).errors_on(:title)
+    Post.all.count.should == 2
+    Post.find_by_id(1).title.should == 'altered post'
+    Post.find_by_id(3).title.should == 'new post'
+  end
+
+  it "3. 'BulkPostsWithFormObjectsForm' should be importing all of the represented objects errors." do
+    params = {
+      bulk_post: {
+        posts_attributes: {
+          "0" => { title: "" },
+          "1" => { id: 1, title: '' },
+          "2" => { id: 2, title: '', _destroy: true }
+        }
+      }
+    }
+
+    Post.create(title: "My title1")
+    Post.create(title: "My title2")
+    Post.all.count.should == 2
+
+    bulk_posts_form = described_class.new(params[:bulk_post])
+    bulk_posts_form.save
+    
+    bulk_posts_form.should have(2).errors_on(:posts)
+    bulk_posts_form.posts.first.should have(1).errors_on(:title)
+    bulk_posts_form.posts.second.should have(:no).errors_on(:title)
+    bulk_posts_form.posts.third.should have(1).errors_on(:title)
+  end
+
+end
+
+describe BulkPostsWithFormObjectsForm::Base do
+  it_behaves_like 'a BulkPostsWithFormObjectsForm'
+end
+
+describe BulkPostsWithFormObjectsForm::Explicit do
+  it_behaves_like 'a BulkPostsWithFormObjectsForm'
+end

data/spec/object_attorney/post_form_spec.rb

@@ -1,60 +1,126 @@
 require "spec_helper"
 
-describe PostForm do
-
-  it "PostForm becomes invalid when Post does and incorporates its errors" do
-    post = Post.new
-    post.should have(1).error_on(:title)
-    post.title = "My title"
-    post.should have(:no).errors_on(:title)
-
-    post_form = PostForm.new({ state: 'draft' })
-    post_form.should have(1).error_on(:title)
-    post_form.title = "My title"
-    post_form.should have(:no).errors_on(:title)
-  end
+shared_examples "a PostForm" do
 
-  it "PostForm may require the validations of fields that Post doesn't have" do
-    params = { post: { title: "My title" } }
+  it "1. Creating a 'Post' with nested 'Comment's, through 'FormObjects::Post'" do
+    params = {
+      post: {
+        title: 'First post',
+        body: 'post body',
+        comments_attributes: {
+          "0" => { body: "body1" },
+          "1" => { body: "" }
+        }
+      }
+    }
 
-    post = Post.new(params[:post])
-    post.should have(:no).errors_on(:state)
+    post_form = described_class.new(params[:post])
 
-    post_form = PostForm.new(params[:post])
-    post_form.should have(1).error_on(:state)
-    post_form.state = "draft"
-    post_form.should have(:no).errors_on(:state)
+    post_form.save.should == true
+    
+    Post.all.count.should == 1
+    post = Post.first
+    post.title.should == 'First post'
+    post.body.should == 'post body'
+    
+    post.comments.count.should == 2
+    
+    comment = post.comments.first
+    comment.post_id.should == post.id
+    comment.body.should == 'body1'
   end
 
-  it "Post creation through PostForm" do
-    params = { post: { state: 'public', title: "My title", body: "My body" } }
-    post_form = PostForm.new(params[:post])
+  it "2. Editing a 'Post' and a nested 'Comment'." do
+    params = {
+      id: 1,
+      post: {
+        title: "altered post",
+        comments_attributes: {
+          "0" => { id: 1, body: "altered comment" }
+        }
+      }
+    }
 
-    expect(post_form.save).to(eq(true)) && expect(post_form.post.persisted?).to(eq(true))
-  end
+    Post.create(title: "My title1")
+    Post.first.title.should == 'My title1'
+    Comment.create(post_id: 1, body: "body1")
+    Comment.first.body.should == 'body1'
 
-  it "Post can't be created if PostForm isn't valid" do
-    params = { post: { title: "My title", body: "My body" } }
-    post_form = PostForm.new(params[:post])
-
-    expect(post_form.save).to(eq(false)) && expect(post_form.post.persisted?).to(eq(false))
+    post_form = described_class.new(params[:post], Post.find(params[:id]))
+    post_form.save
+    
+    post = Post.first
+    post.title.should == 'altered post'
+    
+    comment = post.comments.first
+    comment.post_id.should == post.id
+    comment.body.should == 'altered comment'
   end
 
-  it "Post can't be created if Post isn't valid" do
-    params = { post: { state: 'public', body: "My body" } }
-    post_form = PostForm.new(params[:post])
+  it "3. Editing a 'Post' and deleting a nested 'Comment'." do
+    params = {
+      id: 1,
+      post: {
+        title: "altered post",
+        comments_attributes: {
+          "0" => { id: 1, _destroy: true }
+        }
+      }
+    }
+
+    Post.create(title: "My title1")
+    Post.first.title.should == 'My title1'
+    Comment.create(post_id: 1, body: "body1")
+    Comment.all.count.should == 1
 
-    expect(post_form.save).to(eq(false)) && expect(post_form.post.persisted?).to(eq(false))
+    post_form = described_class.new(params[:post], Post.find(params[:id]))
+    post_form.save
+    
+    Post.first.title.should == 'altered post'
+    Comment.all.count.should == 0
   end
 
-  it "PostForm won't allow weak params to be updated, unlike Post" do
-    params = { post: { title: 'My title', body: "My body", admin: true } }
+  it "4. Editing a 'Post', creating new nested 'Comment', editing another and deleting yet another." do
+    params = {
+      id: 1,
+      post: {
+        title: "altered post",
+        comments_attributes: {
+          "0" => { body: "new comment" },
+          "1" => { id: 1, body: 'to be destroyed', _destroy: true },
+          "2" => { id: 2, body: 'altered comment' }
+        }
+      }
+    }
+
+    Post.create(title: "My title1")
+    Post.first.title.should == 'My title1'
+    Comment.create(post_id: 1, body: "body1")
+    Comment.create(post_id: 1, body: "body2")
+    Comment.all.count.should == 2
 
-    post_form = PostForm.new(params[:post].merge({ state: 'public' }))
-    expect(post_form.save).to(eq(true)) && expect(post_form.post.admin).to(eq(false))
+    post_form = described_class.new(params[:post], Post.find(params[:id]))
+    post_form.save
     
-    post = Post.new(params[:post])
-    expect(post.save).to(eq(true)) && expect(post.admin).to(eq(true))
+    post = Post.first
+    post.title.should == 'altered post'
+    post.comments.count.should == 2
+
+    comment = post.comments.where(id: 2).first
+    comment.post_id.should == post.id
+    comment.body.should == 'altered comment'
+
+    comment = post.comments.where(id: 3).first
+    comment.post_id.should == post.id
+    comment.body.should == 'new comment'
   end
 
 end
+
+describe PostForm::Base do
+  it_behaves_like 'a PostForm'
+end
+
+describe PostForm::Explicit do
+  it_behaves_like 'a PostForm'
+end

data/spec/object_attorney/post_with_comment_form_spec.rb

@@ -0,0 +1,123 @@
+require "spec_helper"
+
+shared_examples "a PostWithCommentForm" do
+
+  it "1. 'Post' can't be created if any of the nested comments on 'FormObjects::PostWithCommentForm' isn't valid" do
+    params = {
+      post: {
+        title: 'First post',
+        body: 'post body',
+        comments_attributes: {
+          "0" => { body: "body1" },
+          "1" => { body: "" }
+        }
+      }
+    }
+
+    post2_form = described_class.new(params[:post])
+    post2_form.save
+    
+    Post.all.count.should == 0
+    Comment.all.count.should == 0
+    post2_form.comments.second.should have(1).errors_on(:body)
+  end
+
+  it "2. Editing a 'Post', creating new nested 'Comment' (with errors), editing another and deleting yet another (none of the changes should take place)." do
+    params = {
+      id: 1,
+      post: {
+        title: "altered post",
+        comments_attributes: {
+          "0" => {},
+          "1" => { id: 1, body: 'to be destroyed', _destroy: true },
+          "2" => { id: 2, body: 'altered comment' }
+        }
+      }
+    }
+
+    Post.create(title: "My title1")
+    Post.first.title.should == 'My title1'
+    Comment.create(post_id: 1, body: "body1")
+    Comment.create(post_id: 1, body: "body2")
+    Comment.all.count.should == 2
+
+    post_form = described_class.new(params[:post], Post.find(params[:id]))
+    post_form.save
+    
+    Post.first.title.should == 'My title1'
+    Comment.all.count.should == 2
+    Comment.find_by_id(1).body.should == 'body1'
+    Comment.find_by_id(2).body.should == 'body2'
+  end
+
+  it "3. Editing a 'Post' (with errors), creating new nested 'Comment', editing another and deleting yet another (none of the changes should take place)." do
+    params = {
+      id: 1,
+      post: {
+        title: "",
+        comments_attributes: {
+          "0" => { body: "new comment" },
+          "1" => { id: 1, body: 'to be destroyed', _destroy: true },
+          "2" => { id: 2, body: 'altered comment' }
+        }
+      }
+    }
+
+    Post.create(title: "My title1")
+    Post.first.title.should == 'My title1'
+    Comment.create(post_id: 1, body: "body1")
+    Comment.create(post_id: 1, body: "body2")
+    Comment.all.count.should == 2
+
+    post_form = described_class.new(params[:post], Post.find(params[:id]))
+    post_form.save
+    
+    Post.first.title.should == 'My title1'
+    Comment.all.count.should == 2
+    Comment.find_by_id(1).body.should == 'body1'
+    Comment.find_by_id(2).body.should == 'body2'
+  end
+
+  it "4. Editing a 'Post', creating new nested 'Comment', editing another and deleting (with errors) yet another (all changes should take place!)." do
+    params = {
+      id: 1,
+      post: {
+        title: "altered post",
+        comments_attributes: {
+          "0" => { body: "new comment" },
+          "1" => { id: 1, _destroy: true },
+          "2" => { id: 2, body: 'altered comment' }
+        }
+      }
+    }
+
+    Post.create(title: "My title1")
+    Post.first.title.should == 'My title1'
+    Comment.create(post_id: 1, body: "body1")
+    Comment.create(post_id: 1, body: "body2")
+    Comment.all.count.should == 2
+
+    post_form = described_class.new(params[:post], Post.find(params[:id]))
+    post_form.save
+    
+    Post.first.title.should == 'altered post'
+    Comment.all.count.should == 2
+
+    comment = Comment.find_by_id(2)
+    comment.body.should == 'altered comment'
+    comment.post_id.should == 1
+
+    comment = Comment.find_by_id(3)
+    comment.body.should == 'new comment'
+    comment.post_id.should == 1
+  end
+
+end
+
+describe PostWithCommentForm::Base do
+  it_behaves_like 'a PostWithCommentForm'
+end
+
+describe PostWithCommentForm::Explicit do
+  it_behaves_like 'a PostWithCommentForm'
+end

data/spec/object_attorney/post_with_comments_and_address_form_spec.rb

@@ -0,0 +1,45 @@
+require "spec_helper"
+
+describe PostWithCommentsAndAddressForm do
+
+  it "1. Creating a 'Post' with nested 'Comment's and a single 'Address'" do
+    params = {
+      post: {
+        title: 'First post',
+        body: 'post body',
+        comments_attributes: {
+          "0" => { body: "body1" },
+          "1" => { body: "" }
+        },
+        address_attributes: {
+          '0' => { street: 'street' }
+        }
+      }
+    }
+
+    post_form = described_class.new(params[:post])
+
+    post_form.save.should == true
+    
+    Post.all.count.should == 1
+    post = Post.first
+    post.title.should == 'First post'
+    post.body.should == 'post body'
+    
+    post.comments.count.should == 2
+    
+    comment = post.comments.first
+    comment.post_id.should == post.id
+    comment.body.should == 'body1'
+
+    comment = post.comments.second
+    comment.post_id.should == post.id
+    comment.body.should == ''
+
+    post.address.present?.should == true
+    address = Address.first
+    address.post_id.should == post.id
+    address.street.should == 'street'
+  end
+
+end

data/spec/object_attorney/user_form_spec.rb

@@ -0,0 +1,61 @@
+require "spec_helper"
+
+describe UserForm do
+
+  it "1. Creating a 'User' using 'UserForm'." do
+    params = { user: { email: 'email@gmail.com', terms_of_service: true } }
+
+    user_form = UserForm.new(params[:user])
+    save_result = user_form.save
+
+    save_result.should == true
+    User.all.count.should == 1
+  end
+
+  it "2. 'UserForm' becomes invalid when 'User' does and incorporates its errors." do
+    user = User.new
+    user.should have(1).error_on(:email)
+    user.email = "email@gmail.com"
+    user.should have(:no).errors_on(:email)
+
+    user_form = UserForm.new
+    user_form.should have(1).error_on(:email)
+    user_form.email = "email@gmail.com"
+    user_form.should have(:no).errors_on(:email)
+  end
+
+  it "3. 'UserForm' may require the validations of fields that 'User' doesn't have." do
+    params = { user: { email: "email@gmail.com" } }
+
+    user = User.new(params[:user])
+    user.should have(:no).errors_on(:terms_of_service)
+
+    user_form = UserForm.new(params[:user])
+    user_form.should have(1).error_on(:terms_of_service)
+    user_form.terms_of_service = true
+    user_form.should have(:no).errors_on(:terms_of_service)
+  end
+
+  it "4. 'User' can't be created if 'UserForm' isn't valid." do
+    params = { user: { email: 'email@gmail.com' } }
+    
+    user_form = UserForm.new(params[:user])
+    save_result = user_form.save
+
+    save_result.should == false
+    User.all.count.should == 0
+  end
+
+  it "5. 'UserForm' won't allow weak params to be updated, unlike 'User'." do
+    params = { user: { email: 'email@gmail.com', admin: true } }
+
+    user = User.new(params[:user])
+    user.save.should == true
+    user.admin.should == true
+
+    user_form = UserForm.new(params[:user].merge({ terms_of_service: true }))
+    user_form.save.should == true
+    user_form.user.admin.should == false
+  end
+
+end

data/spec/spec_helper.rb

@@ -12,15 +12,24 @@ require 'pry'
 require 'object_attorney'
 require 'support/database_setup'
 require 'support/active_model/validations'
+require 'support/models/address'
+require 'support/models/comment'
 require 'support/models/post'
-require 'support/models/item'
-require 'support/models/post_form'
-require 'support/models/post_form_child'
-require 'support/models/bulk_posts_form'
-require 'support/models/bulk_posts_form_child'
+require 'support/models/user'
+
+require 'support/form_objects/post_form'
+require 'support/form_objects/comment_form'
+require 'support/form_objects/post_with_comment_form'
+require 'support/form_objects/post_with_comments_and_address_form'
+require 'support/form_objects/bulk_posts_form'
+require 'support/form_objects/bulk_posts_allow_only_existing_form'
+require 'support/form_objects/bulk_posts_allow_only_new_form'
+require 'support/form_objects/bulk_posts_with_form_objects_form'
+require 'support/form_objects/user_form'
 
 RSpec.configure do |config|
-  config.filter_run :current
+  #config.treat_symbols_as_metadata_keys_with_true_values = true
+  #config.filter_run :current
   
   I18n.enforce_available_locales = false
 

data/spec/support/form_objects/bulk_posts_allow_only_existing_form.rb

@@ -0,0 +1,19 @@
+module BulkPostsAllowOnlyExistingForm
+
+  class Base < BulkPostsForm::Base
+
+    def build_post(attributes = {})
+      nil
+    end
+
+  end
+
+  class Explicit < BulkPostsForm::Base
+
+    def build_post(attributes = {})
+      nil
+    end
+
+  end
+
+end

data/spec/support/form_objects/bulk_posts_allow_only_new_form.rb

@@ -0,0 +1,19 @@
+module BulkPostsAllowOnlyNewForm
+  
+  class Base < BulkPostsForm::Base
+
+    def existing_posts
+      []
+    end
+
+  end
+
+  class Explicit < BulkPostsForm::Base
+
+    def existing_posts
+      []
+    end
+
+  end
+
+end

data/spec/support/form_objects/bulk_posts_form.rb

@@ -0,0 +1,27 @@
+module BulkPostsForm
+
+  class Base
+
+    include ObjectAttorney
+
+    has_many :posts
+
+  end
+
+  class Explicit
+
+    include ObjectAttorney
+
+    has_many :posts
+    
+    def build_post(attributes = {})
+      ::Post.new(attributes)
+    end
+
+    def existing_posts
+      ::Post.all
+    end
+
+  end
+
+end

data/spec/support/form_objects/bulk_posts_with_form_objects_form.rb

@@ -0,0 +1,27 @@
+module BulkPostsWithFormObjectsForm
+  
+  class Base
+
+    include ObjectAttorney
+
+    has_many :posts, class_name: PostForm::Base
+
+  end
+  
+  class Explicit
+
+    include ObjectAttorney
+
+    has_many :posts
+    
+    def build_post(attributes = {})
+      PostForm::Base.new(attributes)
+    end
+
+    def existing_posts
+      PostForm::Base.all
+    end
+
+  end
+
+end

data/spec/support/form_objects/comment_form.rb

@@ -0,0 +1,11 @@
+class CommentForm
+
+  include ObjectAttorney
+
+  represents :comment
+
+  delegate_properties :body, to: :comment
+
+  validates_presence_of :body
+
+end