nrb-beerxml 0.0.2

data/spec/cases/beerxml/hop_spec.rb

@@ -0,0 +1,21 @@
+require 'shared/active_model_lint'
+
+describe NRB::BeerXML::Hop do
+
+  it_behaves_like :ActiveModel
+
+  it { should validate_presence_of :alpha }
+  it { should validate_presence_of :amount }
+  it { should validate_presence_of :time }
+  it { should validate_presence_of :use }
+
+  it { should validate_inclusion_of(:form).in_array( ["Leaf", "Pellet", "Plug"] ) }
+
+  it { should validate_numericality_of(:amount).is_greater_than_or_equal_to(0) }
+  it { should validate_inclusion_of(:type).in_array(%w(Aroma Bittering Both) ) }
+  it { should validate_inclusion_of(:use).in_array( [ "Aroma", "Boil", "Dry Hop", "First Wort", "Mash" ] ) }
+
+  it { should validate_numericality_of(:time).is_greater_than_or_equal_to(0) }
+
+
+end

data/spec/cases/beerxml/mash_spec.rb

@@ -0,0 +1,25 @@
+require 'shared/active_model_lint'
+describe NRB::BeerXML::Mash do
+
+  it_behaves_like :ActiveModel
+
+  it { should validate_presence_of :grain_temp }
+  it { should validate_presence_of :mash_steps }
+
+  it { should validate_numericality_of :grain_temp }
+  it { should validate_numericality_of(:ph).is_greater_than_or_equal_to(0).is_less_than_or_equal_to(14) }
+  it { should validate_numericality_of :sparge_temp }
+  it { should validate_numericality_of(:tun_specific_heat).is_greater_than_or_equal_to(0) }
+  it { should validate_numericality_of :tun_temp }
+  it { should validate_numericality_of(:tun_weight).is_greater_than_or_equal_to(0) }
+
+
+  it 'should start with empty mash steps' do
+    expect( subject.mash_steps ).to be_a(NRB::BeerXML::RecordSet)
+  end
+
+  it 'mash steps should be a RecordSet of mash_steps' do
+    expect( subject.mash_steps.record_type ).to eq :mash_step
+  end
+
+end

data/spec/cases/beerxml/mash_step_spec.rb

@@ -0,0 +1,39 @@
+require 'shared/active_model_lint'
+
+describe NRB::BeerXML::MashStep do
+
+  it_behaves_like :ActiveModel
+
+  let(:subject) { described_class.new type: type }
+  let(:type) { "Temperature" }
+
+  it { should validate_presence_of(:step_temp) }
+  it { should validate_presence_of(:step_time) }
+  it { should validate_presence_of(:type) }
+
+  it { should validate_inclusion_of(:type).in_array(%w(Decoction Infusion Temperature)) }
+
+  it { should validate_numericality_of(:end_temp) }
+  it { should validate_numericality_of(:infuse_amount) }
+  it { should validate_numericality_of(:ramp_time).is_greater_than_or_equal_to(0) }
+  it { should validate_numericality_of(:step_temp) }
+  it { should validate_numericality_of(:step_time).is_greater_than_or_equal_to(0) }
+
+  context "Decoction steps" do
+    let(:type) { "Decoction" }
+    it { should_not validate_presence_of :infuse_amount }
+  end
+
+
+  context "Infusion steps" do
+    let(:type) { "Infusion" }
+    it { should validate_presence_of :infuse_amount }
+  end
+
+
+  context "Temperature steps" do
+    let(:type) { "Temperature" }
+    it { should_not validate_presence_of :infuse_amount }
+  end
+
+end

data/spec/cases/beerxml/misc_spec.rb

@@ -0,0 +1,14 @@
+describe NRB::BeerXML::Misc do
+
+  it { should validate_presence_of :amount }
+  it { should validate_presence_of :time }
+  it { should validate_presence_of :type }
+  it { should validate_presence_of :use }
+
+  it { should validate_numericality_of(:amount).is_greater_than_or_equal_to(0) }
+  it { should validate_numericality_of(:time).is_greater_than_or_equal_to(0) }
+
+  it { should validate_inclusion_of(:type).in_array(["Fining", "Flavor", "Herb", "Other", "Spice", "Water Agent"]) }
+  it { should validate_inclusion_of(:use).in_array(%w(Boil Bottling Mash Primary Secondary)) }
+
+end

data/spec/cases/beerxml/parser_spec.rb

@@ -0,0 +1,30 @@
+describe NRB::BeerXML::Parser do
+
+  context 'Parsing' do
+
+    let(:base_dir) { File.expand_path File.join('..','..','..'), __FILE__ }
+    let(:fixture_dir) { File.join base_dir,'fixtures' }
+    let(:fixture_path) { File.join fixture_dir, 'recipes.xml' }
+
+    it 'does not raise error when parsing a path name' do
+      expect { subject.parse fixture_path }.to_not raise_error
+    end
+
+
+    it 'does not raise error when parsing a stream' do
+      expect { subject.parse File.open(fixture_path) }.to_not raise_error
+    end
+
+
+    it 'raises an error when parsing something else' do
+      expect { subject.parse Array.new }.to raise_error
+    end
+
+
+    it 'returns a NRB::BeerXML::Parser' do
+      expect( subject.parse fixture_path ).to be_a(NRB::BeerXML::RecordSet)
+    end
+
+  end
+
+end

data/spec/cases/beerxml/recipe_spec.rb

@@ -0,0 +1,98 @@
+require 'shared/active_model_lint'
+
+describe NRB::BeerXML::Recipe do
+
+  it_behaves_like :ActiveModel
+
+  it { should_not validate_presence_of :age }
+  it { should_not validate_presence_of :age_temp }
+  it { should_not validate_presence_of :asst_brewer }
+  it { should validate_presence_of :batch_size }
+  it { should validate_presence_of :boil_size }
+  it { should validate_presence_of :boil_time }
+  it { should validate_presence_of :brewer }
+  it { should_not validate_presence_of :carbonation }
+  it { should_not validate_presence_of :carbonation_temp }
+  it { should_not validate_presence_of :date }
+  it { should validate_presence_of :equipment }
+  it { should validate_presence_of :fermentables }
+  it { should_not validate_presence_of :fermentation_stages }
+  it { should_not validate_presence_of :fg }
+  it { should_not validate_presence_of :forced_carbonation }
+  it { should validate_presence_of :hops }
+  it { should_not validate_presence_of :keg_priming_factor }
+  it { should validate_presence_of :mash }
+  it { should validate_presence_of :miscs }
+  it { should_not validate_presence_of :notes }
+  it { should_not validate_presence_of :og }
+  it { should_not validate_presence_of :primary_age }
+  it { should_not validate_presence_of :primary_temp }
+  it { should_not validate_presence_of :priming_sugar_equiv }
+  it { should_not validate_presence_of :priming_sugar_name }
+  it { should_not validate_presence_of :secondary_age }
+  it { should_not validate_presence_of :secondary_temp }
+  it { should validate_presence_of :style }
+  it { should_not validate_presence_of :taste_notes }
+  it { should_not validate_presence_of :taste_rating }
+  it { should_not validate_presence_of :tertiary_age }
+  it { should_not validate_presence_of :tertiary_temp }
+  it { should validate_presence_of :type }
+  it { should validate_presence_of :waters }
+  it { should validate_presence_of :yeasts }
+
+  it { should validate_inclusion_of(:type).in_array([ "All Grain", "Extract", "Partial Mash" ]) }
+
+  it { should validate_numericality_of(:age).is_greater_than_or_equal_to(0) }
+  it { should validate_numericality_of(:age_temp) }
+  it { should validate_numericality_of(:batch_size).is_greater_than_or_equal_to(0) }
+  it { should validate_numericality_of(:boil_size).is_greater_than_or_equal_to(0) }
+  it { should validate_numericality_of(:boil_time).is_greater_than_or_equal_to(0) }
+  it { should validate_numericality_of(:carbonation).is_greater_than_or_equal_to(0) }
+  it { should validate_numericality_of(:carbonation_temp) }
+  it { should validate_numericality_of(:fermentation_stages).only_integer }
+  it { should validate_numericality_of(:fg) }
+  it { should validate_numericality_of(:og) }
+  it { should validate_numericality_of(:primary_age).is_greater_than_or_equal_to(0) }
+  it { should validate_numericality_of(:primary_temp) }
+  it { should validate_numericality_of(:secondary_age).is_greater_than_or_equal_to(0) }
+  it { should validate_numericality_of(:secondary_temp) }
+  it { should validate_numericality_of(:tertiary_age).is_greater_than_or_equal_to(0) }
+  it { should validate_numericality_of(:tertiary_temp) }
+
+
+  %i(fermentable hop misc water yeast).each do |record_type|
+    it "#{record_type}s should be a RecordSet" do
+      expect(subject.send("#{record_type}s")).to be_a(NRB::BeerXML::RecordSet)
+    end
+
+    it "its #{record_type}s RecordSet should be of type #{record_type}" do
+      expect(subject.send("#{record_type}s").record_type).to eq record_type
+    end
+  end
+
+
+  shared_examples_for :restricted_assignment do
+    it "allows assignment of the correct type" do
+      expect{ subject.send("#{record_type}=", good) }.to_not raise_exception
+    end
+
+    it 'disallows non-Styles' do
+      expect{ subject.send("#{record_type}=", bad) }.to raise_exception
+    end
+  end
+
+  context "assigning equipment" do
+    let(:bad) { NRB::BeerXML::Hop.new }
+    let(:good) { NRB::BeerXML::Equipment.new }
+    let(:record_type) { :equipment }
+    it_behaves_like :restricted_assignment
+  end
+
+  context "assigning style" do
+    let(:bad) { NRB::BeerXML::Hop.new }
+    let(:good) { NRB::BeerXML::Style.new }
+    let(:record_type) { :style }
+    it_behaves_like :restricted_assignment
+  end
+
+end

data/spec/cases/beerxml/record_set_spec.rb

@@ -0,0 +1,36 @@
+describe NRB::BeerXML::RecordSet do
+
+  context "initialization" do
+
+    described_class.valid_record_types.each do |record_type|
+      it "does not blow up given #{record_type}" do
+        expect { described_class.new record_type: record_type }.to_not raise_exception
+      end
+    end
+
+    it 'blows up when given a blark' do
+        expect { described_class.new record_type: :blark }.to raise_exception
+    end
+
+  end
+
+
+  context 'adding records' do
+
+    let(:invalid_record) { NRB::BeerXML::Mash.new }
+    let(:record_set) { described_class.new record_type: record_type }
+    let(:record_type) { :hop }
+    let(:valid_record) { NRB::BeerXML::Hop.new }
+
+    it 'lets you add valid records' do
+      expect { record_set << valid_record }.to_not raise_exception
+    end
+
+    it "doesen't let you add invalid records" do
+      expect { record_set << inalid_record }.to raise_exception
+    end
+
+
+  end
+
+end

data/spec/cases/beerxml/record_spec.rb

@@ -0,0 +1,15 @@
+require 'shared/active_model_lint'
+describe NRB::BeerXML::Record do
+
+  it { should validate_presence_of :name }
+  it { should validate_presence_of :version }
+
+  it { should validate_numericality_of(:version).only_integer }
+
+  it 'tells you its name' do
+    expect(subject.record_type).to be_a(Symbol)
+  end
+
+  it_behaves_like :ActiveModel
+
+end

data/spec/cases/beerxml/record_validators/boolean_validator_spec.rb

@@ -0,0 +1,50 @@
+require 'beerxml/record_validators/boolean_validator'
+module NRB
+  module Fake
+    class FakeBooleanObject
+      include ActiveModel::Model
+      attr_accessor :boolean
+      validates :boolean, boolean: true
+    end
+  end
+end
+
+describe NRB::BeerXML::RecordValidators::BooleanValidator do
+
+  shared_examples_for :a_borked_record do
+
+    it 'is invalid' do
+      expect(record).to_not be_valid
+    end
+
+    it 'tells you why the record is invalid' do
+      record.valid?
+      expect(record.errors[:boolean]).to include('must be false or true')
+    end
+
+  end
+
+
+  let(:record) { NRB::Fake::FakeBooleanObject.new boolean: boolean }
+
+
+  context 'an invalid record' do
+    let(:boolean) { :false }
+    it_behaves_like :a_borked_record
+  end
+
+
+  context 'false is valid' do
+    let(:boolean) { false }
+    it { expect(record).to be_valid }
+  end
+
+
+  context 'true is valid' do
+    let(:boolean) { true }
+    it { expect(record).to be_valid }
+  end
+
+
+
+end

data/spec/cases/beerxml/record_validators/percentage_validator_spec.rb

@@ -0,0 +1,98 @@
+require 'beerxml/record_validators/percentage_validator'
+module NRB
+  module Fake
+    class FakePercentage
+      include ActiveModel::Model
+      attr_accessor :percentage
+    end
+    class NoMaxFakePercentage < FakePercentage
+      validates :percentage, percentage: { give_110: true }
+    end
+    class NoMinFakePercentage < FakePercentage
+      validates :percentage, percentage: { allow_negative: true }
+    end
+    class VanillaFakePercentage < FakePercentage
+      validates :percentage, percentage: true
+    end
+  end
+end
+
+describe NRB::BeerXML::RecordValidators::PercentageValidator do
+
+  let(:nan) { :a }
+
+  shared_examples_for :a_borked_record do
+
+    it 'is invalid' do
+      expect(record).to_not be_valid
+    end
+
+    it 'tells you why the record is invalid' do
+      record.valid?
+      expect(record.errors[:percentage]).to include('must be a BeerXML percentage (a number between 0 & 100)')
+    end
+
+  end
+
+
+  shared_examples_for :rejects_nan do
+    let(:percentage) { nan }
+    it_behaves_like :a_borked_record
+  end
+
+
+  shared_examples_for :goldilocks do
+    let(:percentage) { okay }
+    it 'is valid' do
+      expect(record).to be_valid
+    end
+  end
+
+
+  shared_examples_for :rejects_large do
+    let(:percentage) { too_big }
+    it_behaves_like :a_borked_record
+  end
+
+
+  shared_examples_for :rejects_small do
+    let(:percentage) { too_small }
+    it_behaves_like :a_borked_record
+  end
+
+
+  context 'a vanilla percentage validator' do
+    let(:okay) { 88 }
+    let(:record) { NRB::Fake::VanillaFakePercentage.new percentage: percentage }
+    let(:too_big) { 101 }
+    let(:too_small) { -1 }
+
+    it_behaves_like :goldilocks
+    it_behaves_like :rejects_large
+    it_behaves_like :rejects_nan
+    it_behaves_like :rejects_small
+  end
+
+
+  context 'with no maximum' do
+    let(:okay) { 1000 }
+    let(:record) { NRB::Fake::NoMaxFakePercentage.new percentage: percentage }
+    let(:too_small) { -1 }
+
+    it_behaves_like :goldilocks
+    it_behaves_like :rejects_small
+    it_behaves_like :rejects_nan
+  end
+
+
+  context 'with no minimum' do
+    let(:okay) { -10 }
+    let(:record) { NRB::Fake::NoMinFakePercentage.new percentage: percentage }
+    let(:too_big) { 101 }
+
+    it_behaves_like :goldilocks
+    it_behaves_like :rejects_large
+    it_behaves_like :rejects_nan
+  end
+
+end

data/spec/cases/beerxml/style_spec.rb

@@ -0,0 +1,36 @@
+require 'shared/active_model_lint'
+
+describe NRB::BeerXML::Style do
+
+  it_behaves_like :ActiveModel
+
+  it { should validate_presence_of :category }
+  it { should validate_presence_of :category_number }
+  it { should validate_presence_of :color_max }
+  it { should validate_presence_of :color_min }
+  it { should validate_presence_of :fg_max }
+  it { should validate_presence_of :fg_min }
+  it { should validate_presence_of :ibu_max }
+  it { should validate_presence_of :ibu_min }
+  it { should validate_presence_of :og_max }
+  it { should validate_presence_of :og_min }
+  it { should validate_presence_of :style_guide }
+  it { should validate_presence_of :style_letter }
+  it { should validate_presence_of :type }
+
+  it { should validate_inclusion_of(:type).in_array(%w(Ale Cider Lager Mead Mixed Wheat) ) }
+
+  it { should validate_numericality_of(:abv_max).is_greater_than_or_equal_to(0) }
+  it { should validate_numericality_of(:abv_min).is_greater_than_or_equal_to(0) }
+  it { should validate_numericality_of(:carb_max).is_greater_than_or_equal_to(0) }
+  it { should validate_numericality_of(:carb_min).is_greater_than_or_equal_to(0) }
+  it { should validate_numericality_of(:color_max).is_greater_than_or_equal_to(0) }
+  it { should validate_numericality_of(:color_min).is_greater_than_or_equal_to(0) }
+  it { should validate_numericality_of(:fg_max).is_greater_than_or_equal_to(0) }
+  it { should validate_numericality_of(:fg_min).is_greater_than_or_equal_to(0) }
+  it { should validate_numericality_of(:ibu_max).is_greater_than_or_equal_to(0) }
+  it { should validate_numericality_of(:ibu_min).is_greater_than_or_equal_to(0) }
+  it { should validate_numericality_of(:og_max).is_greater_than_or_equal_to(0) }
+  it { should validate_numericality_of(:og_min).is_greater_than_or_equal_to(0) }
+
+end