nokogiri-happymapper 0.6.0 → 0.7.0

data/spec/has_many_empty_array_spec.rb

@@ -1,4 +1,6 @@
-require "spec_helper"
+# frozen_string_literal: true
+
+require 'spec_helper'
 
 module Sheep
   class Item
@@ -16,28 +18,27 @@ module Sheep
     has_many :items, Item, tag: 'item'
 
     has_many :items_with_a_different_name, Item, tag: 'item'
-
   end
 end
 
-describe "emptyness" do
+describe 'emptyness' do
   let(:xml) do
-    <<-EOF
+    <<-XML
     <navigator>
       <items/>
     </navigator>
-    EOF
+    XML
   end
 
   let(:navigator) do
     Sheep::Navigator.parse(xml)
   end
 
-  it "returns an empty array" do
+  it 'returns an empty array' do
     expect(navigator.items_with_a_different_name).to be_empty
   end
 
-  it "returns an empty array" do
+  it 'returns an empty array' do
     expect(navigator.items).to be_empty
   end
 end

data/spec/ignay_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 class CatalogTree
@@ -10,86 +12,80 @@ class CatalogTree
 
   attribute :code, String
 
-  has_many :nodes, 'CatalogNode', :tag => 'Node', :xpath => '.'
-
+  has_many :nodes, 'CatalogNode', tag: 'Node', xpath: '.'
 end
 
-
 class CatalogNode
   include HappyMapper
 
   tag 'Node'
 
-  attribute :back_office_id, String, :tag => 'vodBackOfficeId'
+  attribute :back_office_id, String, tag: 'vodBackOfficeId'
 
-  has_one :name, String, :tag => 'Name'
+  has_one :name, String, tag: 'Name'
   # other important fields
 
-  has_many :translations, 'CatalogNode::Translations', :tag => 'Translation', :xpath => 'child::*'
+  has_many :translations, 'CatalogNode::Translations', tag: 'Translation', xpath: 'child::*'
 
   class Translations
     include HappyMapper
     tag 'Translation'
 
-    attribute :language, String, :tag => 'Language'
-    has_one :name, String, :tag => 'Name'
-
+    attribute :language, String, tag: 'Language'
+    has_one :name, String, tag: 'Name'
   end
 
-  has_many :nodes, CatalogNode, :tag => 'Node', :xpath => 'child::*'
-
+  has_many :nodes, CatalogNode, tag: 'Node', xpath: 'child::*'
 end
 
 describe HappyMapper do
-
-  it "should not be nil" do
+  it 'should not be nil' do
     expect(catalog_tree).not_to be_nil
   end
 
-  it "should have the attribute code" do
-    expect(catalog_tree.code).to eq("NLD")
+  it 'should have the attribute code' do
+    expect(catalog_tree.code).to eq('NLD')
   end
 
-  it "should have many nodes" do
+  it 'should have many nodes' do
     expect(catalog_tree.nodes).not_to be_empty
     expect(catalog_tree.nodes.length).to eq(2)
   end
 
-  context "first node" do
-
-    it "should have a name" do
-      expect(first_node.name).to eq("Parent 1")
+  context 'first node' do
+    it 'should have a name' do
+      expect(first_node.name).to eq('Parent 1')
     end
 
-    it "should have translations" do
+    it 'should have translations' do
       expect(first_node.translations.length).to eq(2)
 
-      expect(first_node.translations.first.language).to eq("en-GB")
+      expect(first_node.translations.first.language).to eq('en-GB')
 
-      expect(first_node.translations.last.name).to eq("Parent 1 de")
+      expect(first_node.translations.last.name).to eq('Parent 1 de')
     end
 
-    it "should have subnodes" do
+    it 'should have subnodes' do
       expect(first_node.nodes).to be_kind_of(Enumerable)
       expect(first_node.nodes).not_to be_empty
       expect(first_node.nodes.length).to eq(1)
     end
 
-    it "first node - first node name" do
-      expect(first_node.nodes.first.name).to eq("First")
+    it 'first node - first node name' do
+      expect(first_node.nodes.first.name).to eq('First')
     end
 
     def first_node
       @first_node = catalog_tree.nodes.first
     end
-
   end
 
-
-  def catalog_tree ; @catalog_tree ; end
+  def catalog_tree
+    @catalog_tree
+  end
 
   before(:all) do
     xml_reference = "#{File.dirname(__FILE__)}/fixtures/inagy.xml"
-    @catalog_tree = CatalogTree.parse(File.read(xml_reference), :single => true)
+    @catalog_tree = CatalogTree.parse(File.read(xml_reference), single: true)
   end
-end
+end

data/spec/inheritance_spec.rb

@@ -1,7 +1,8 @@
-require 'spec_helper'
+# frozen_string_literal: true
 
-describe "Using inheritance to share elements and attributes" do
+require 'spec_helper'
 
+describe 'Using inheritance to share elements and attributes' do
   class Genetics
     include HappyMapper
     content :dna, String
@@ -26,9 +27,12 @@ describe "Using inheritance to share elements and attributes" do
     element :genetics, Integer
   end
 
-  describe "Overwrite" do
+  describe 'Overwrite' do
     let(:subject) do
-      xml = '<overwrite love="love" naivety="trusting"><genetics>1001</genetics><immunities>Chicken Pox</immunities></overwrite>'
+      xml =
+        '<overwrite love="love" naivety="trusting">' \
+        '<genetics>1001</genetics><immunities>Chicken Pox</immunities>' \
+        '</overwrite>'
       Overwrite.parse(xml, single: true)
     end
 
@@ -37,9 +41,9 @@ describe "Using inheritance to share elements and attributes" do
       expect(Overwrite.elements.count).to be == Parent.elements.count
     end
 
-    context "when parsing xml" do
+    context 'when parsing xml' do
       it 'parses the new overwritten attribut' do
-        expect(subject.love).to be == "love"
+        expect(subject.love).to be == 'love'
       end
 
       it 'parses the new overwritten element' do
@@ -47,11 +51,11 @@ describe "Using inheritance to share elements and attributes" do
       end
     end
 
-    context "when saving to xml" do
+    context 'when saving to xml' do
       subject do
         overwrite = Overwrite.new
         overwrite.genetics = 1
-        overwrite.love = "love"
+        overwrite.love = 'love'
         Nokogiri::XML(overwrite.to_xml).root
       end
 
@@ -60,48 +64,50 @@ describe "Using inheritance to share elements and attributes" do
       end
 
       it 'has only 1 love attribute' do
-        expect(subject.xpath('@love').text).to be == "love"
+        expect(subject.xpath('@love').text).to be == 'love'
       end
     end
   end
 
-  describe "Child", "a subclass of the Parent" do
+  describe 'Child', 'a subclass of the Parent' do
     let(:subject) do
-      xml = '<child love="99" naivety="trusting"><genetics>ABBA</genetics><immunities>Chicken Pox</immunities></child>'
+      xml =
+        '<child love="99" naivety="trusting">' \
+        '<genetics>ABBA</genetics><immunities>Chicken Pox</immunities>' \
+        '</child>'
       Child.parse(xml)
     end
 
-    context "when parsing xml" do
+    context 'when parsing xml' do
       it 'should be possible to deserialize XML into a Child class instance' do
         expect(subject.love).to eq 99
-        expect(subject.genetics.dna).to eq "ABBA"
-        expect(subject.naivety).to eq "trusting"
+        expect(subject.genetics.dna).to eq 'ABBA'
+        expect(subject.naivety).to eq 'trusting'
         expect(subject.immunities.size).to eq(1)
       end
     end
 
-    context "when saving to xml" do
+    context 'when saving to xml' do
       let(:subject) do
         child = Child.new
         child.love = 100
         child.naivety = 'Bright Eyed'
-        child.immunities = [ "Small Pox", "Chicken Pox", "Mumps" ]
+        child.immunities = ['Small Pox', 'Chicken Pox', 'Mumps']
         genetics = Genetics.new
-        genetics.dna = "GATTACA"
+        genetics.dna = 'GATTACA'
         child.genetics = genetics
         Nokogiri::XML(child.to_xml).root
       end
 
-      it "saves both the Child and Parent attributes" do
-        expect(subject.xpath("@naivety").text).to eq "Bright Eyed"
-        expect(subject.xpath("@love").text).to eq "100"
+      it 'saves both the Child and Parent attributes' do
+        expect(subject.xpath('@naivety').text).to eq 'Bright Eyed'
+        expect(subject.xpath('@love').text).to eq '100'
       end
 
-      it "saves both the Child and Parent elements" do
-        expect(subject.xpath("genetics").text).to eq "GATTACA"
-        expect(subject.xpath("immunities").size).to eq(3)
+      it 'saves both the Child and Parent elements' do
+        expect(subject.xpath('genetics').text).to eq 'GATTACA'
+        expect(subject.xpath('immunities').size).to eq(3)
       end
     end
-
   end
 end

data/spec/mixed_namespaces_spec.rb

@@ -1,7 +1,8 @@
-require 'spec_helper'
+# frozen_string_literal: true
 
-describe "A document with mixed namespaces" do
+require 'spec_helper'
 
+describe 'A document with mixed namespaces' do
   #
   # Note that the parent element of the xml has the namespacing. The elements
   # contained within the xml do not share the parent element namespace so a
@@ -9,14 +10,14 @@ describe "A document with mixed namespaces" do
   # these child elements.
   #
   let(:xml_document) do
-    %{<prefix:address location='home' xmlns:prefix="http://www.unicornland.com/prefix"
+    %(<prefix:address location='home' xmlns:prefix="http://www.unicornland.com/prefix"
         xmlns:different="http://www.trollcountry.com/different">
         <street>Milchstrasse</street>
         <street>Another Street</street>
         <housenumber>23</housenumber>
         <different:postcode>26131</different:postcode>
         <city>Oldenburg</city>
-      </prefix:address>}
+      </prefix:address>)
   end
 
   module MixedNamespaces
@@ -41,21 +42,19 @@ describe "A document with mixed namespaces" do
     MixedNamespaces::Address.parse(xml_document, single: true)
   end
 
-
-  it "has the correct streets" do
-    expect(address.streets).to eq [ "Milchstrasse", "Another Street" ]
+  it 'has the correct streets' do
+    expect(address.streets).to eq ['Milchstrasse', 'Another Street']
   end
 
-  it "house number" do
-    expect(address.house_number).to eq "23"
+  it 'house number' do
+    expect(address.house_number).to eq '23'
   end
 
-  it "postcode" do
-    expect(address.postcode).to eq "26131"
+  it 'postcode' do
+    expect(address.postcode).to eq '26131'
   end
 
-  it "city" do
-    expect(address.city).to eq "Oldenburg"
+  it 'city' do
+    expect(address.city).to eq 'Oldenburg'
   end
-
-end
+end

data/spec/parse_with_object_to_update_spec.rb

@@ -1,34 +1,35 @@
-require 'spec_helper'
+# frozen_string_literal: true
 
-describe "Updating existing objects with .parse and #parse" do
+require 'spec_helper'
 
+describe 'Updating existing objects with .parse and #parse' do
   let(:subject) { ParseInstanceSpec::Root.parse(parse_instance_initial_xml) }
 
   let(:parse_instance_initial_xml) do
-     %{<root attr1="initial">
-      <item attr1="initial">
-        <description>initial</description>
-        <subitem attr1="initial">
-          <name>initial</name>
-        </subitem>
-        <subitem attr1="initial">
-          <name>initial</name>
-        </subitem>
-      </item>
-      <item attr1="initial">
-        <description>initial</description>
-        <subitem attr1="initial">
-          <name>initial</name>
-        </subitem>
-        <subitem attr1="initial">
-          <name>initial</name>
-        </subitem>
-      </item>
-    </root>}
+    %(<root attr1="initial">
+     <item attr1="initial">
+       <description>initial</description>
+       <subitem attr1="initial">
+         <name>initial</name>
+       </subitem>
+       <subitem attr1="initial">
+         <name>initial</name>
+       </subitem>
+     </item>
+     <item attr1="initial">
+       <description>initial</description>
+       <subitem attr1="initial">
+         <name>initial</name>
+       </subitem>
+       <subitem attr1="initial">
+         <name>initial</name>
+       </subitem>
+     </item>
+   </root>)
   end
 
   let(:parse_instance_updated_xml) do
-    %{<root attr1="updated">
+    %(<root attr1="updated">
       <item attr1="updated">
         <description>updated</description>
         <subitem attr1="updated">
@@ -47,7 +48,7 @@ describe "Updating existing objects with .parse and #parse" do
           <name>updated</name>
         </subitem>
       </item>
-    </root>}
+    </root>)
   end
 
   module ParseInstanceSpec
@@ -72,7 +73,7 @@ describe "Updating existing objects with .parse and #parse" do
     end
   end
 
-  def item_is_correctly_defined(item,value='initial')
+  def item_is_correctly_defined(item, value = 'initial')
     expect(item.attr1).to eq value
     expect(item.description).to eq value
     expect(item.sub_items[0].attr1).to eq value
@@ -83,29 +84,27 @@ describe "Updating existing objects with .parse and #parse" do
 
   it 'initial values are correct' do
     expect(subject.attr1).to eq('initial')
-    item_is_correctly_defined( subject.items[0] )
-    item_is_correctly_defined( subject.items[1] )
+    item_is_correctly_defined(subject.items[0])
+    item_is_correctly_defined(subject.items[1])
   end
 
-
-  describe ".parse", "specifying an existing object to update" do
+  describe '.parse', 'specifying an existing object to update' do
     it 'all fields are correct' do
-      ParseInstanceSpec::Root.parse(parse_instance_updated_xml, :update => subject)
+      ParseInstanceSpec::Root.parse(parse_instance_updated_xml, update: subject)
       expect(subject.attr1).to eq 'updated'
 
-      item_is_correctly_defined( subject.items[0], 'updated' )
-      item_is_correctly_defined( subject.items[1], 'updated' )
+      item_is_correctly_defined(subject.items[0], 'updated')
+      item_is_correctly_defined(subject.items[1], 'updated')
     end
   end
 
-  describe "#parse" do
-    it "all fields are correct" do
+  describe '#parse' do
+    it 'all fields are correct' do
       subject.parse(parse_instance_updated_xml)
       expect(subject.attr1).to eq 'updated'
 
-      item_is_correctly_defined( subject.items[0], 'updated' )
-      item_is_correctly_defined( subject.items[1], 'updated' )
+      item_is_correctly_defined(subject.items[0], 'updated')
+      item_is_correctly_defined(subject.items[1], 'updated')
     end
   end
-
-end
+end