nokogiri-happymapper 0.6.0 → 0.7.0

data/spec/attributes_spec.rb

@@ -1,36 +1,35 @@
-require 'spec_helper'
+# frozen_string_literal: true
 
-describe "Attribute Method Conversion" do
+require 'spec_helper'
 
+describe 'Attribute Method Conversion' do
   let(:xml_document) do
-    %{<document>
+    %(<document>
         <link data-src='http://cooking.com/roastbeef' type='recipe'>Roast Beef</link>
-      </document>}
+      </document>)
   end
 
   module AttributeMethodConversion
     class Document
       include HappyMapper
 
-      has_many :link, String, :attributes => { :'data-src' => String, :type => String, :href => String }
-
+      has_many :link, String, attributes: { 'data-src': String, type: String, href: String }
     end
   end
 
   let(:document) do
-    AttributeMethodConversion::Document.parse(xml_document,single: true)
+    AttributeMethodConversion::Document.parse(xml_document, single: true)
   end
 
-  it "link" do
-    expect(document.link).to eq ["Roast Beef"]
+  it 'link' do
+    expect(document.link).to eq ['Roast Beef']
   end
 
-  it "link.data_src" do
-    expect(document.link.first.data_src).to eq "http://cooking.com/roastbeef"
+  it 'link.data_src' do
+    expect(document.link.first.data_src).to eq 'http://cooking.com/roastbeef'
   end
 
-  it "link.type" do
-    expect(document.link.first.type).to eq "recipe"
+  it 'link.type' do
+    expect(document.link.first.type).to eq 'recipe'
   end
-
-end
+end

data/spec/happymapper/attribute_spec.rb

@@ -1,12 +1,12 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe HappyMapper::Attribute do
-
-  describe "initialization" do
+  describe 'initialization' do
     it 'accepts :default option' do
-      attr = described_class.new(:foo, String, :default => 'foobar')
+      attr = described_class.new(:foo, String, default: 'foobar')
       expect(attr.default).to eq('foobar')
     end
   end
-
 end

data/spec/happymapper/element_spec.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe HappyMapper::Element do
-  describe "initialization" do
+  describe 'initialization' do
     before do
       @attr = HappyMapper::Element.new(:foo, String)
     end

data/spec/happymapper/item_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module Foo
@@ -5,13 +7,12 @@ module Foo
 end
 
 describe HappyMapper::Item do
-
-  describe "new instance" do
+  describe 'new instance' do
     before do
-      @item = HappyMapper::Item.new(:foo, String, :tag => 'foobar')
+      @item = HappyMapper::Item.new(:foo, String, tag: 'foobar')
     end
 
-    it "should accept a name" do
+    it 'should accept a name' do
       expect(@item.name).to eq('foo')
     end
 
@@ -23,112 +24,119 @@ describe HappyMapper::Item do
       expect(@item.tag).to eq('foobar')
     end
 
-    it "should have a method_name" do
+    it 'should have a method_name' do
       expect(@item.method_name).to eq('foo')
     end
   end
 
-  describe "#constant" do
-    it "should just use type if constant" do
+  describe '#constant' do
+    it 'should just use type if constant' do
       item = HappyMapper::Item.new(:foo, String)
       expect(item.constant).to eq(String)
     end
 
-    it "should convert string type to constant" do
+    it 'should convert string type to constant' do
       item = HappyMapper::Item.new(:foo, 'String')
       expect(item.constant).to eq(String)
     end
 
-    it "should convert string with :: to constant" do
+    it 'should convert string with :: to constant' do
       item = HappyMapper::Item.new(:foo, 'Foo::Bar')
       expect(item.constant).to eq(Foo::Bar)
     end
   end
 
-  describe "#method_name" do
-    it "should convert dashes to underscores" do
-      item = HappyMapper::Item.new(:'foo-bar', String, :tag => 'foobar')
+  describe '#method_name' do
+    it 'should convert dashes to underscores' do
+      item = HappyMapper::Item.new(:'foo-bar', String, tag: 'foobar')
       expect(item.method_name).to eq('foo_bar')
     end
   end
 
-  describe "#xpath" do
-    it "should default to tag" do
-      item = HappyMapper::Item.new(:foo, String, :tag => 'foobar')
+  describe '#xpath' do
+    it 'should default to tag' do
+      item = HappyMapper::Item.new(:foo, String, tag: 'foobar')
       expect(item.xpath).to eq('foobar')
     end
 
-    it "should prepend with .// if options[:deep] true" do
-      item = HappyMapper::Item.new(:foo, String, :tag => 'foobar', :deep => true)
+    it 'should prepend with .// if options[:deep] true' do
+      item = HappyMapper::Item.new(:foo, String, tag: 'foobar', deep: true)
       expect(item.xpath).to eq('.//foobar')
     end
 
-    it "should prepend namespace if namespace exists" do
-      item = HappyMapper::Item.new(:foo, String, :tag => 'foobar')
+    it 'should prepend namespace if namespace exists' do
+      item = HappyMapper::Item.new(:foo, String, tag: 'foobar')
       item.namespace = 'v2'
       expect(item.xpath).to eq('v2:foobar')
     end
   end
 
-  describe "typecasting" do
-    it "should work with Strings" do
+  describe 'typecasting' do
+    it 'should work with Strings' do
       item = HappyMapper::Item.new(:foo, String)
       [21, '21'].each do |a|
         expect(item.typecast(a)).to eq('21')
       end
     end
 
-    it "should work with Integers" do
+    it 'should work with Integers' do
       item = HappyMapper::Item.new(:foo, Integer)
       [21, 21.0, '21'].each do |a|
         expect(item.typecast(a)).to eq(21)
       end
     end
 
-    it "should work with Floats" do
+    it 'should work with Floats' do
       item = HappyMapper::Item.new(:foo, Float)
       [21, 21.0, '21'].each do |a|
         expect(item.typecast(a)).to eq(21.0)
       end
     end
 
-    it "should work with Times" do
+    it 'should work with Times' do
       item = HappyMapper::Item.new(:foo, Time)
       expect(item.typecast('2000-01-01 01:01:01.123456')).to eq(Time.local(2000, 1, 1, 1, 1, 1, 123456))
     end
 
-    it "should work with Dates" do
+    it 'should work with Dates' do
       item = HappyMapper::Item.new(:foo, Date)
       expect(item.typecast('2000-01-01')).to eq(Date.new(2000, 1, 1))
     end
 
-    it "should handle nil Dates" do
+    it 'should handle nil Dates' do
       item = HappyMapper::Item.new(:foo, Date)
       expect(item.typecast(nil)).to eq(nil)
     end
 
-    it "should handle empty string Dates" do
+    it 'should handle empty string Dates' do
       item = HappyMapper::Item.new(:foo, Date)
-      expect(item.typecast("")).to eq(nil)
+      expect(item.typecast('')).to eq(nil)
     end
 
-    it "should work with DateTimes" do
-      item = HappyMapper::Item.new(:foo, DateTime)
-      expect(item.typecast('2000-01-01 00:00:00')).to eq(DateTime.new(2000, 1, 1, 0, 0, 0))
-    end
+    context 'with DateTime' do
+      let(:item) { HappyMapper::Item.new(:foo, DateTime) }
 
-    it "should handle nil DateTimes" do
-      item = HappyMapper::Item.new(:foo, DateTime)
-      expect(item.typecast(nil)).to eq(nil)
-    end
+      it 'works with a string' do
+        result = item.typecast('2000-01-01 13:42:37')
+        expect(result.to_time).to eq Time.new(2000, 1, 1, 13, 42, 37, '+00:00')
+      end
 
-    it "should handle empty string DateTimes" do
-      item = HappyMapper::Item.new(:foo, DateTime)
-      expect(item.typecast("")).to eq(nil)
-    end
+      it 'works with a historical date in a string' do
+        result = item.typecast('1616-04-23')
+        expect(result.to_time).to eq Time.new(1616, 4, 23, 0, 0, 0, '+00:00')
+        expect(result).to be_gregorian
+      end
+
+      it 'handles nil' do
+        expect(item.typecast(nil)).to eq(nil)
+      end
 
+      it 'handles empty strings' do
+        expect(item.typecast('')).to eq(nil)
+      end
+    end
 
-    it "should work with Boolean" do
+    it 'should work with Boolean' do
       item = HappyMapper::Item.new(:foo, HappyMapper::Boolean)
       expect(item.typecast('false')).to eq(false)
     end

data/spec/happymapper/text_node_spec.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe HappyMapper::Attribute do
-  describe "initialization" do
+  describe 'initialization' do
     before do
       @attr = HappyMapper::TextNode.new(:foo, String)
     end

data/spec/happymapper_parse_spec.rb

@@ -1,88 +1,108 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe HappyMapper do
-
-  context ".parse" do
-
-    context "on a single root node" do
-
+  context '.parse' do
+    context 'on a single root node' do
       subject { described_class.parse fixture_file('address.xml') }
 
-      it "should parse child elements" do
-        expect(subject.street).to eq("Milchstrasse")
-        expect(subject.housenumber).to eq("23")
-        expect(subject.postcode).to eq("26131")
-        expect(subject.city).to eq("Oldenburg")
+      it 'should parse child elements' do
+        expect(subject.street).to eq('Milchstrasse')
+        expect(subject.housenumber).to eq('23')
+        expect(subject.postcode).to eq('26131')
+        expect(subject.city).to eq('Oldenburg')
       end
 
-      it "should not create a content entry when the xml contents no text content" do
+      it 'should not create a content entry when the xml contents no text content' do
         expect(subject).not_to respond_to :content
       end
 
-      context "child elements with attributes" do
-
-        it "should parse the attributes" do
-          expect(subject.country.code).to eq("de")
+      context 'child elements with attributes' do
+        it 'should parse the attributes' do
+          expect(subject.country.code).to eq('de')
         end
 
-        it "should parse the content" do
-          expect(subject.country.content).to eq("Germany")
+        it 'should parse the content' do
+          expect(subject.country.content).to eq('Germany')
         end
-
       end
-
     end
 
-    context "element names with special characters" do
+    context 'element names with special characters' do
       subject { described_class.parse fixture_file('ambigous_items.xml') }
 
-      it "should create accessor methods with similar names" do
+      it 'should create accessor methods with similar names' do
         expect(subject.my_items.item).to be_kind_of Array
       end
     end
 
-    context "element names with camelCased elements and Capital Letters" do
-
+    context 'element names with camelCased elements and Capital Letters' do
       subject { described_class.parse fixture_file('subclass_namespace.xml') }
 
-      it "should parse the elements and values correctly" do
-        expect(subject.title).to eq("article title")
-        expect(subject.photo.publish_options.author).to eq("Stephanie")
-        expect(subject.gallery.photo.title).to eq("photo title")
+      it 'parses camel-cased child elements correctly' do
+        expect(subject.photo.publish_options.author).to eq('Stephanie')
+        expect(subject.gallery.photo.title).to eq('photo title')
+      end
+
+      it 'parses camel-cased child properties correctly' do
+        expect(subject.publish_options.created_day).to eq('2011-01-14')
       end
     end
 
-    context "several elements nested deep" do
-      subject { described_class.parse fixture_file('ambigous_items.xml') }
+    context 'with elements with camelCased attribute names' do
+      subject { described_class.parse '<foo barBaz="quuz"/>' }
 
-      it "should parse the entire relationship" do
-        expect(subject.my_items.item.first.item.name).to eq("My first internal item")
+      it 'parses attributes correctly' do
+        expect(subject.bar_baz).to eq('quuz')
       end
     end
 
-    context "xml that contains multiple entries" do
+    context 'several elements nested deep' do
+      subject { described_class.parse fixture_file('ambigous_items.xml') }
+
+      it 'should parse the entire relationship' do
+        expect(subject.my_items.item.first.item.name).to eq('My first internal item')
+      end
+    end
 
+    context 'xml that contains multiple entries' do
       subject { described_class.parse fixture_file('multiple_primitives.xml') }
 
       it "should parse the elements as it would a 'has_many'" do
+        expect(subject.name).to eq('value')
+        expect(subject.image).to eq(%w(image1 image2))
+      end
+    end
 
-        expect(subject.name).to eq("value")
-        expect(subject.image).to eq([ "image1", "image2" ])
+    context 'xml with multiple namespaces' do
+      subject { described_class.parse fixture_file('subclass_namespace.xml') }
 
+      it 'should parse the elements an values correctly' do
+        expect(subject.title).to eq('article title')
       end
 
+      it 'parses attribute names correctly' do
+        expect(subject.name).to eq 'title'
+      end
     end
 
-    context "xml with multiple namespaces" do
-
-      subject { described_class.parse fixture_file('subclass_namespace.xml') }
+    context 'with value elements with different namespace' do
+      let(:xml) do
+        <<~XML
+          <a:foo xmlns:a="http://foo.org/a" xmlns:b="http://foo.org/b">
+            <b:bar>Hello</b:bar>
+          </a:foo>
+        XML
+      end
+      let(:result) { described_class.parse xml }
 
-      it "should parse the elements an values correctly" do
-        expect(subject.title).to eq("article title")
+      it 'parses the value elements correctly' do
+        expect(result.bar).to eq 'Hello'
       end
     end
 
-    context "after_parse callbacks" do
+    context 'after_parse callbacks' do
       module AfterParseSpec
         class Address
           include HappyMapper
@@ -94,7 +114,7 @@ describe HappyMapper do
         AfterParseSpec::Address.after_parse_callbacks.clear
       end
 
-      it "should callback with the newly created object" do
+      it 'should callback with the newly created object' do
         from_cb = nil
         called = false
         cb1 = proc { |object| from_cb = object }
@@ -107,7 +127,5 @@ describe HappyMapper do
         expect(called).to eq(true)
       end
     end
-
   end
-
-end
+end

data/spec/happymapper_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'uri'
 
@@ -39,13 +41,12 @@ module Analytics
 
     tag 'entry'
     element :title, String
-    element :tableId, String, :namespace => 'dxp'
+    element :tableId, String, namespace: 'dxp'
 
     has_many :properties, Property
     has_many :goals, Goal
   end
 
-
   class Entry
     include HappyMapper
 
@@ -53,7 +54,7 @@ module Analytics
     element :id, String
     element :updated, DateTime
     element :title, String
-    element :table_id, String, :namespace => 'dxp', :tag => 'tableId'
+    element :table_id, String, namespace: 'dxp', tag: 'tableId'
     has_many :properties, Property
   end
 
@@ -73,15 +74,15 @@ module Atom
     include HappyMapper
     tag 'feed'
 
-    attribute :xmlns, String, :single => true
-    element :id, String, :single => true
-    element :title, String, :single => true
-    element :updated, DateTime, :single => true
-    element :link, String, :single => false, :attributes => {
-        :rel => String,
-        :type => String,
-        :href => String
-      }
+    attribute :xmlns, String, single: true
+    element :id, String, single: true
+    element :title, String, single: true
+    element :updated, DateTime, single: true
+    element :link, String, single: false, attributes: {
+      rel: String,
+      type: String,
+      href: String
+    }
     # has_many :entries, Entry # nothing interesting in the entries
   end
 end
@@ -93,7 +94,6 @@ class Country
   content :name, String
 end
 
-
 class State
   include HappyMapper
 end
@@ -115,7 +115,7 @@ end
 
 class Feature
   include HappyMapper
-  element :name, String, :xpath => './/text()'
+  element :name, String, xpath: './/text()'
 end
 
 class FeatureBullet
@@ -143,7 +143,7 @@ module FamilySearch
     include HappyMapper
 
     tag 'alternateIds'
-    has_many :ids, String, :tag => 'id'
+    has_many :ids, String, tag: 'id'
   end
 
   class Information
@@ -171,8 +171,8 @@ module FamilySearch
 
     tag 'familytree'
     attribute :version, String
-    attribute :status_message, String, :tag => 'statusMessage'
-    attribute :status_code, String, :tag => 'statusCode'
+    attribute :status_message, String, tag: 'statusMessage'
+    attribute :status_code, String, tag: 'statusCode'
     has_one :persons, Persons
   end
 end
@@ -183,11 +183,11 @@ module FedEx
 
     tag 'Address'
     namespace 'v2'
-    element :city, String, :tag => 'City'
-    element :state, String, :tag => 'StateOrProvinceCode'
-    element :zip, String, :tag => 'PostalCode'
-    element :countrycode, String, :tag => 'CountryCode'
-    element :residential, Boolean, :tag => 'Residential'
+    element :city, String, tag: 'City'
+    element :state, String, tag: 'StateOrProvinceCode'
+    element :zip, String, tag: 'PostalCode'
+    element :countrycode, String, tag: 'CountryCode'
+    element :residential, Boolean, tag: 'Residential'
   end
 
   class Event
@@ -195,9 +195,9 @@ module FedEx
 
     tag 'Events'
     namespace 'v2'
-    element :timestamp, String, :tag => 'Timestamp'
-    element :eventtype, String, :tag => 'EventType'
-    element :eventdescription, String, :tag => 'EventDescription'
+    element :timestamp, String, tag: 'Timestamp'
+    element :eventtype, String, tag: 'EventType'
+    element :eventdescription, String, tag: 'EventDescription'
     has_one :address, Address
   end
 
@@ -206,8 +206,8 @@ module FedEx
 
     tag 'PackageWeight'
     namespace 'v2'
-    element :units, String, :tag => 'Units'
-    element :value, Integer, :tag => 'Value'
+    element :units, String, tag: 'Units'
+    element :value, Integer, tag: 'Value'
   end
 
   class TrackDetails
@@ -215,13 +215,13 @@ module FedEx
 
     tag 'TrackDetails'
     namespace 'v2'
-    element   :tracking_number, String, :tag => 'TrackingNumber'
-    element   :status_code, String, :tag => 'StatusCode'
-    element   :status_desc, String, :tag => 'StatusDescription'
-    element   :carrier_code, String, :tag => 'CarrierCode'
-    element   :service_info, String, :tag => 'ServiceInfo'
-    has_one   :weight, PackageWeight, :tag => 'PackageWeight'
-    element   :est_delivery,  String, :tag => 'EstimatedDeliveryTimestamp'
+    element   :tracking_number, String, tag: 'TrackingNumber'
+    element   :status_code, String, tag: 'StatusCode'
+    element   :status_desc, String, tag: 'StatusDescription'
+    element   :carrier_code, String, tag: 'CarrierCode'
+    element   :service_info, String, tag: 'ServiceInfo'
+    has_one   :weight, PackageWeight, tag: 'PackageWeight'
+    element   :est_delivery, String, tag: 'EstimatedDeliveryTimestamp'
     has_many  :events, Event
   end
 
@@ -230,11 +230,11 @@ module FedEx
 
     tag 'Notifications'
     namespace 'v2'
-    element :severity, String, :tag => 'Severity'
-    element :source, String, :tag => 'Source'
-    element :code, Integer, :tag => 'Code'
-    element :message, String, :tag => 'Message'
-    element :localized_message, String, :tag => 'LocalizedMessage'
+    element :severity, String, tag: 'Severity'
+    element :source, String, tag: 'Source'
+    element :code, Integer, tag: 'Code'
+    element :message, String, tag: 'Message'
+    element :localized_message, String, tag: 'LocalizedMessage'
   end
 
   class TransactionDetail
@@ -242,7 +242,7 @@ module FedEx
 
     tag 'TransactionDetail'
     namespace 'v2'
-    element :cust_tran_id, String, :tag => 'CustomerTransactionId'
+    element :cust_tran_id, String, tag: 'CustomerTransactionId'
   end
 
   class TrackReply
@@ -250,11 +250,11 @@ module FedEx
 
     tag 'TrackReply'
     namespace 'v2'
-    element   :highest_severity, String, :tag => 'HighestSeverity'
-    element   :more_data, Boolean, :tag => 'MoreData'
-    has_many  :notifications, Notification, :tag => 'Notifications'
-    has_many  :trackdetails, TrackDetails, :tag => 'TrackDetails'
-    has_one   :tran_detail, TransactionDetail, :tab => 'TransactionDetail'
+    element   :highest_severity, String, tag: 'HighestSeverity'
+    element   :more_data, Boolean, tag: 'MoreData'
+    has_many  :notifications, Notification, tag: 'Notifications'
+    has_many  :trackdetails, TrackDetails, tag: 'TrackDetails'
+    has_one   :tran_detail, TransactionDetail, tab: 'TransactionDetail'
   end
 end
 
@@ -265,7 +265,7 @@ end
 
 class Radar
   include HappyMapper
-  has_many :places, Place, :tag => :place
+  has_many :places, Place, tag: :place
 end
 
 class Post
@@ -297,7 +297,7 @@ end
 class Status
   include HappyMapper
 
-  register_namespace 'fake', "faka:namespace"
+  register_namespace 'fake', 'faka:namespace'
 
   element :id, Integer
   element :text, String
@@ -307,7 +307,7 @@ class Status
   element :in_reply_to_status_id, Integer
   element :in_reply_to_user_id, Integer
   element :favorited, Boolean
-  element :non_existent, String, :tag => 'dummy', :namespace => 'fake'
+  element :non_existent, String, tag: 'dummy', namespace: 'fake'
   has_one :user, User
 end
 
@@ -316,9 +316,9 @@ class CurrentWeather
 
   tag 'ob'
   namespace 'aws'
-  element :temperature, Integer, :tag => 'temp'
-  element :feels_like, Integer, :tag => 'feels-like'
-  element :current_condition, String, :tag => 'current-condition', :attributes => {:icon => String}
+  element :temperature, Integer, tag: 'temp'
+  element :feels_like, Integer, tag: 'feels-like'
+  element :current_condition, String, tag: 'current-condition', attributes: { icon: String }
 end
 
 # for type coercion
@@ -329,19 +329,19 @@ module PITA
     include HappyMapper
 
     tag 'Item' # if you put class in module you need tag
-    element :asin, String, :tag => 'ASIN'
-    element :detail_page_url, URI, :tag => 'DetailPageURL', :parser => :parse
-    element :manufacturer, String, :tag => 'Manufacturer', :deep => true
-    element :point, String, :tag => 'point', :namespace => 'georss'
-    element :product_group, ProductGroup, :tag => 'ProductGroup', :deep => true, :parser => :new, :raw => true
+    element :asin, String, tag: 'ASIN'
+    element :detail_page_url, URI, tag: 'DetailPageURL', parser: :parse
+    element :manufacturer, String, tag: 'Manufacturer', deep: true
+    element :point, String, tag: 'point', namespace: 'georss'
+    element :product_group, ProductGroup, tag: 'ProductGroup', deep: true, parser: :new, raw: true
   end
 
   class Items
     include HappyMapper
 
     tag 'Items' # if you put class in module you need tag
-    element :total_results, Integer, :tag => 'TotalResults'
-    element :total_pages, Integer, :tag => 'TotalPages'
+    element :total_results, Integer, tag: 'TotalResults'
+    element :total_pages, Integer, tag: 'TotalPages'
     has_many :items, Item
   end
 end
@@ -350,7 +350,7 @@ module GitHub
   class Commit
     include HappyMapper
 
-    tag "commit"
+    tag 'commit'
     element :url, String
     element :tree, String
     element :message, String
@@ -382,10 +382,10 @@ module QuarterTest
     # to be used for all these differently named elements is the next
     # best thing
     has_one :details, QuarterTest::Details
-    has_one :q1, QuarterTest::Quarter, :tag => 'q1'
-    has_one :q2, QuarterTest::Quarter, :tag => 'q2'
-    has_one :q3, QuarterTest::Quarter, :tag => 'q3'
-    has_one :q4, QuarterTest::Quarter, :tag => 'q4'
+    has_one :q1, QuarterTest::Quarter, tag: 'q1'
+    has_one :q2, QuarterTest::Quarter, tag: 'q2'
+    has_one :q3, QuarterTest::Quarter, tag: 'q3'
+    has_one :q4, QuarterTest::Quarter, tag: 'q4'
   end
 end
 
@@ -394,7 +394,7 @@ class Artist
   include HappyMapper
 
   tag 'artist'
-  element :images, String, :tag => "image", :single => false
+  element :images, String, tag: 'image', single: false
   element :name, String
 end
 
@@ -402,8 +402,8 @@ class Location
   include HappyMapper
 
   tag 'point'
-  namespace "geo"
-  element :latitude, String, :tag => "lat"
+  namespace 'geo'
+  element :latitude, String, tag: 'lat'
 end
 
 # Testing the XmlContent type
@@ -414,7 +414,7 @@ module Dictionary
     has_xml_content
 
     def to_html
-      xml_content.gsub('<tag>','<em>').gsub('</tag>','</em>')
+      xml_content.gsub('<tag>', '<em>').gsub('</tag>', '</em>')
     end
   end
 
@@ -422,7 +422,7 @@ module Dictionary
     include HappyMapper
 
     tag 'def'
-    element :text, XmlContent, :tag => 'dtext'
+    element :text, XmlContent, tag: 'dtext'
   end
 
   class Record
@@ -430,7 +430,7 @@ module Dictionary
 
     tag 'record'
     has_many :definitions, Definition
-    has_many :variants, Variant, :tag => 'var'
+    has_many :variants, Variant, tag: 'var'
   end
 end
 
@@ -449,16 +449,15 @@ class PublishOptions
 
   tag 'publishOptions'
 
-  element :author, String, :tag => 'author'
-
-  element :draft, Boolean, :tag => 'draft'
-  element :scheduled_day, String, :tag => 'scheduledDay'
-  element :scheduled_time, String, :tag => 'scheduledTime'
-  element :published_day, String, :tag => 'publishDisplayDay'
-  element :published_time, String, :tag => 'publishDisplayTime'
-  element :created_day, String, :tag => 'publishDisplayDay'
-  element :created_time, String, :tag => 'publishDisplayTime'
+  element :author, String, tag: 'author'
 
+  element :draft, Boolean, tag: 'draft'
+  element :scheduled_day, String, tag: 'scheduledDay'
+  element :scheduled_time, String, tag: 'scheduledTime'
+  element :published_day, String, tag: 'publishDisplayDay'
+  element :published_time, String, tag: 'publishDisplayTime'
+  element :created_day, String, tag: 'publishDisplayDay'
+  element :created_time, String, tag: 'publishDisplayTime'
 end
 
 class Article
@@ -471,11 +470,10 @@ class Article
 
   element :title, String
   element :text, String
-  has_many :photos, 'Photo', :tag => 'Photo', :namespace => 'photo', :xpath => '/article:Article'
-  has_many :galleries, 'Gallery', :tag => 'Gallery', :namespace => 'gallery'
-
-  element :publish_options, PublishOptions, :tag => 'publishOptions', :namespace => 'article'
+  has_many :photos, 'Photo', tag: 'Photo', namespace: 'photo', xpath: '/article:Article'
+  has_many :galleries, 'Gallery', tag: 'Gallery', namespace: 'gallery'
 
+  element :publish_options, PublishOptions, tag: 'publishOptions', namespace: 'article'
 end
 
 class PartiallyBadArticle
@@ -488,11 +486,10 @@ class PartiallyBadArticle
 
   element :title, String
   element :text, String
-  has_many :photos, 'Photo', :tag => 'Photo', :namespace => 'photo', :xpath => '/article:Article'
-  has_many :videos, 'Video', :tag => 'Video', :namespace => 'video'
-
-  element :publish_options, PublishOptions, :tag => 'publishOptions', :namespace => 'article'
+  has_many :photos, 'Photo', tag: 'Photo', namespace: 'photo', xpath: '/article:Article'
+  has_many :videos, 'Video', tag: 'Video', namespace: 'video'
 
+  element :publish_options, PublishOptions, tag: 'publishOptions', namespace: 'article'
 end
 
 class Photo
@@ -504,8 +501,7 @@ class Photo
   attr_writer :xml_value
 
   element :title, String
-  element :publish_options, PublishOptions, :tag => 'publishOptions', :namespace => 'photo'
-
+  element :publish_options, PublishOptions, tag: 'publishOptions', namespace: 'photo'
 end
 
 class Gallery
@@ -517,7 +513,6 @@ class Gallery
   attr_writer :xml_value
 
   element :title, String
-
 end
 
 class Video
@@ -529,8 +524,7 @@ class Video
   attr_writer :xml_value
 
   element :title, String
-  element :publish_options, PublishOptions, :tag => 'publishOptions', :namespace => 'video'
-
+  element :publish_options, PublishOptions, tag: 'publishOptions', namespace: 'video'
 end
 
 class OptionalAttribute
@@ -543,78 +537,73 @@ end
 class DefaultNamespaceCombi
   include HappyMapper
 
-
-  register_namespace 'bk', "urn:loc.gov:books"
-  register_namespace 'isbn', "urn:ISBN:0-395-36341-6"
-  register_namespace 'p', "urn:loc.gov:people"
+  register_namespace 'bk', 'urn:loc.gov:books'
+  register_namespace 'isbn', 'urn:ISBN:0-395-36341-6'
+  register_namespace 'p', 'urn:loc.gov:people'
   namespace 'bk'
 
   tag 'book'
 
-  element :title, String, :namespace => 'bk', :tag => "title"
-  element :number, String, :namespace => 'isbn', :tag => "number"
-  element :author, String, :namespace => 'p', :tag => "author"
+  element :title, String, namespace: 'bk', tag: 'title'
+  element :number, String, namespace: 'isbn', tag: 'number'
+  element :author, String, namespace: 'p', tag: 'author'
 end
 
 describe HappyMapper do
-
-  describe "being included into another class" do
+  describe 'being included into another class' do
     before do
       @klass = Class.new do
         include HappyMapper
 
-        def self.to_s
+        def self.name
           'Boo'
         end
       end
     end
 
-    class Boo; include HappyMapper end
-
-    it "should set attributes to an array" do
+    it 'should set attributes to an array' do
       expect(@klass.attributes).to eq([])
     end
 
-    it "should set @elements to a hash" do
+    it 'should set @elements to a hash' do
       expect(@klass.elements).to eq([])
     end
 
-    it "should allow adding an attribute" do
-      expect {
+    it 'should allow adding an attribute' do
+      expect do
         @klass.attribute :name, String
-      }.to change(@klass, :attributes)
+      end.to change(@klass, :attributes)
     end
 
-    it "should allow adding an attribute containing a dash" do
-      expect {
+    it 'should allow adding an attribute containing a dash' do
+      expect do
         @klass.attribute :'bar-baz', String
-      }.to change(@klass, :attributes)
+      end.to change(@klass, :attributes)
     end
 
-    it "should be able to get all attributes in array" do
+    it 'should be able to get all attributes in array' do
       @klass.attribute :name, String
       expect(@klass.attributes.size).to eq(1)
     end
 
-    it "should allow adding an element" do
-      expect {
+    it 'should allow adding an element' do
+      expect do
         @klass.element :name, String
-      }.to change(@klass, :elements)
+      end.to change(@klass, :elements)
     end
 
-    it "should allow adding an element containing a dash" do
-      expect {
+    it 'should allow adding an element containing a dash' do
+      expect do
         @klass.element :'bar-baz', String
-      }.to change(@klass, :elements)
-
+      end.to change(@klass, :elements)
     end
 
-    it "should be able to get all elements in array" do
+    it 'should be able to get all elements in array' do
       @klass.element(:name, String)
       expect(@klass.elements.size).to eq(1)
     end
 
-    it "should allow has one association" do
+    it 'should allow has one association' do
       @klass.has_one(:user, User)
       element = @klass.elements.first
       expect(element.name).to eq('user')
@@ -622,7 +611,7 @@ describe HappyMapper do
       expect(element.options[:single]).to eq(true)
     end
 
-    it "should allow has many association" do
+    it 'should allow has many association' do
       @klass.has_many(:users, User)
       element = @klass.elements.first
       expect(element.name).to eq('users')
@@ -630,62 +619,67 @@ describe HappyMapper do
       expect(element.options[:single]).to eq(false)
     end
 
-    it "should default tag name to lowercase class" do
+    it 'should default tag name to lowercase class' do
       expect(@klass.tag_name).to eq('boo')
     end
 
-    it "should default tag name of class in modules to the last constant lowercase" do
+    it 'generates no tag name for anonymous class' do
+      @anon = Class.new { include HappyMapper }
+      expect(@anon.tag_name).to be_nil
+    end
+
+    it 'should default tag name of class in modules to the last constant lowercase' do
       module Bar; class Baz; include HappyMapper; end; end
       expect(Bar::Baz.tag_name).to eq('baz')
     end
 
-    it "should allow setting tag name" do
+    it 'should allow setting tag name' do
       @klass.tag('FooBar')
       expect(@klass.tag_name).to eq('FooBar')
     end
 
-    it "should allow setting a namespace" do
-      @klass.namespace(namespace = "boo")
+    it 'should allow setting a namespace' do
+      @klass.namespace(namespace = 'boo')
       expect(@klass.namespace).to eq(namespace)
     end
 
-    it "should provide #parse" do
+    it 'should provide #parse' do
       expect(@klass).to respond_to(:parse)
     end
   end
 
-  describe "#attributes" do
-    it "should only return attributes for the current class" do
+  describe '#attributes' do
+    it 'should only return attributes for the current class' do
       expect(Post.attributes.size).to eq(7)
       expect(Status.attributes.size).to eq(0)
     end
   end
 
-  describe "#elements" do
-    it "should only return elements for the current class" do
+  describe '#elements' do
+    it 'should only return elements for the current class' do
       expect(Post.elements.size).to eq(0)
       expect(Status.elements.size).to eq(10)
     end
   end
 
-  describe "#content" do
-     it "should take String as default argument for type" do
-       State.content :name
-       address = Address.parse(fixture_file('address.xml'))
-       expect(address.state.name).to eq("Lower Saxony")
-       address.state.name.class == String
-     end
+  describe '#content' do
+    it 'should take String as default argument for type' do
+      State.content :name
+      address = Address.parse(fixture_file('address.xml'))
+      expect(address.state.name).to eq('Lower Saxony')
+      address.state.name.class == String
+    end
 
-     it "should work when specific type is provided" do
-       Rate.content :value, Float
-       Product.has_one :rate, Rate
-       product = Product.parse(fixture_file('product_default_namespace.xml'), :single => true)
-       expect(product.rate.value).to eq(120.25)
-       product.rate.class == Float
-     end
+    it 'should work when specific type is provided' do
+      Rate.content :value, Float
+      Product.has_one :rate, Rate
+      product = Product.parse(fixture_file('product_default_namespace.xml'), single: true)
+      expect(product.rate.value).to eq(120.25)
+      product.rate.class == Float
+    end
   end
 
-  it "should parse xml attributes into ruby objects" do
+  it 'should parse xml attributes into ruby objects' do
     posts = Post.parse(fixture_file('posts.xml'))
     expect(posts.size).to eq(20)
     first = posts.first
@@ -695,10 +689,15 @@ describe HappyMapper do
     expect(first.tag).to eq('ruby xml gems mapping')
     expect(first.time).to eq(Time.utc(2008, 8, 9, 5, 24, 20))
     expect(first.others).to eq(56)
-    expect(first.extended).to eq('ROXML is a Ruby library designed to make it easier for Ruby developers to work with XML. Using simple annotations, it enables Ruby classes to be custom-mapped to XML. ROXML takes care of the marshalling and unmarshalling of mapped attributes so that developers can focus on building first-class Ruby classes.')
+    expect(first.extended).
+      to eq('ROXML is a Ruby library designed to make it easier for Ruby' \
+            ' developers to work with XML. Using simple annotations, it enables' \
+            ' Ruby classes to be custom-mapped to XML. ROXML takes care of the' \
+            ' marshalling and unmarshalling of mapped attributes so that developers can' \
+            ' focus on building first-class Ruby classes.')
   end
 
-  it "should parse xml elements to ruby objcts" do
+  it 'should parse xml elements to ruby objcts' do
     statuses = Status.parse(fixture_file('statuses.xml'))
     expect(statuses.size).to eq(20)
     first = statuses.first
@@ -714,14 +713,15 @@ describe HappyMapper do
     expect(first.user.screen_name).to eq('jnunemaker')
     expect(first.user.location).to eq('Mishawaka, IN, US')
     expect(first.user.description).to eq('Loves his wife, ruby, notre dame football and iu basketball')
-    expect(first.user.profile_image_url).to eq('http://s3.amazonaws.com/twitter_production/profile_images/53781608/Photo_75_normal.jpg')
+    expect(first.user.profile_image_url).
+      to eq('http://s3.amazonaws.com/twitter_production/profile_images/53781608/Photo_75_normal.jpg')
     expect(first.user.url).to eq('http://addictedtonew.com')
     expect(first.user.protected).to be_falsey
     expect(first.user.followers_count).to eq(486)
   end
 
-  it "should parse xml containing the desired element as root node" do
-    address = Address.parse(fixture_file('address.xml'), :single => true)
+  it 'should parse xml containing the desired element as root node' do
+    address = Address.parse(fixture_file('address.xml'), single: true)
     expect(address.street).to eq('Milchstrasse')
     expect(address.postcode).to eq('26131')
     expect(address.housenumber).to eq('23')
@@ -729,21 +729,21 @@ describe HappyMapper do
     expect(address.country.class).to eq(Country)
   end
 
-  it "should parse text node correctly" do
-    address = Address.parse(fixture_file('address.xml'), :single => true)
+  it 'should parse text node correctly' do
+    address = Address.parse(fixture_file('address.xml'), single: true)
     expect(address.country.name).to eq('Germany')
     expect(address.country.code).to eq('de')
   end
 
-  it "should treat Nokogiri::XML::Document as root" do
+  it 'should treat Nokogiri::XML::Document as root' do
     doc = Nokogiri::XML(fixture_file('address.xml'))
     address = Address.parse(doc)
     expect(address.class).to eq(Address)
   end
 
-  it "should parse xml with default namespace (amazon)" do
+  it 'should parse xml with default namespace (amazon)' do
     file_contents = fixture_file('pita.xml')
-    items = PITA::Items.parse(file_contents, :single => true)
+    items = PITA::Items.parse(file_contents, single: true)
     expect(items.total_results).to eq(22)
     expect(items.total_pages).to eq(3)
     first  = items.items[0]
@@ -758,7 +758,7 @@ describe HappyMapper do
     expect(second.manufacturer).to eq('Wrox')
   end
 
-  it "should parse xml that has attributes of elements" do
+  it 'should parse xml that has attributes of elements' do
     items = CurrentWeather.parse(fixture_file('current_weather.xml'))
     first = items[0]
     expect(first.temperature).to eq(51)
@@ -773,22 +773,22 @@ describe HappyMapper do
     expect(feed.link.last.href).to eq('http://www.example.com/tv_shows.atom')
   end
 
-  it "parses xml with optional elements with embedded attributes" do
-    expect { CurrentWeather.parse(fixture_file('current_weather_missing_elements.xml')) }.to_not raise_error()
+  it 'parses xml with optional elements with embedded attributes' do
+    expect { CurrentWeather.parse(fixture_file('current_weather_missing_elements.xml')) }.to_not raise_error
   end
 
-  it "returns nil rather than empty array for absent values when :single => true" do
-    address = Address.parse('<?xml version="1.0" encoding="UTF-8"?><foo/>', :single => true)
+  it 'returns nil rather than empty array for absent values when :single => true' do
+    address = Address.parse('<?xml version="1.0" encoding="UTF-8"?><foo/>', single: true)
     expect(address).to be_nil
   end
 
-  it "should return same result for absent values when :single => true, regardless of :in_groups_of" do
-    addr1 = Address.parse('<?xml version="1.0" encoding="UTF-8"?><foo/>', :single => true)
-    addr2 = Address.parse('<?xml version="1.0" encoding="UTF-8"?><foo/>', :single => true, :in_groups_of => 10)
+  it 'should return same result for absent values when :single => true, regardless of :in_groups_of' do
+    addr1 = Address.parse('<?xml version="1.0" encoding="UTF-8"?><foo/>', single: true)
+    addr2 = Address.parse('<?xml version="1.0" encoding="UTF-8"?><foo/>', single: true, in_groups_of: 10)
     expect(addr1).to eq(addr2)
   end
 
-  it "should parse xml with nested elements" do
+  it 'should parse xml with nested elements' do
     radars = Radar.parse(fixture_file('radar.xml'))
     first = radars[0]
     expect(first.places.size).to eq(1)
@@ -801,49 +801,49 @@ describe HappyMapper do
     expect(third.places[1].name).to eq('Home')
   end
 
-  it "should parse xml with element name different to class name" do
+  it 'should parse xml with element name different to class name' do
     game = QuarterTest::Game.parse(fixture_file('quarters.xml'))
     expect(game.q1.start).to eq('4:40:15 PM')
     expect(game.q2.start).to eq('5:18:53 PM')
   end
 
-  it "should parse xml that has elements with dashes" do
+  it 'should parse xml that has elements with dashes' do
     commit = GitHub::Commit.parse(fixture_file('commit.xml'))
-    expect(commit.message).to eq("move commands.rb and helpers.rb into commands/ dir")
-    expect(commit.url).to eq("http://github.com/defunkt/github-gem/commit/c26d4ce9807ecf57d3f9eefe19ae64e75bcaaa8b")
-    expect(commit.id).to eq("c26d4ce9807ecf57d3f9eefe19ae64e75bcaaa8b")
-    expect(commit.committed_date).to eq(Date.parse("2008-03-02T16:45:41-08:00"))
-    expect(commit.tree).to eq("28a1a1ca3e663d35ba8bf07d3f1781af71359b76")
+    expect(commit.message).to eq('move commands.rb and helpers.rb into commands/ dir')
+    expect(commit.url).to eq('http://github.com/defunkt/github-gem/commit/c26d4ce9807ecf57d3f9eefe19ae64e75bcaaa8b')
+    expect(commit.id).to eq('c26d4ce9807ecf57d3f9eefe19ae64e75bcaaa8b')
+    expect(commit.committed_date).to eq(Date.parse('2008-03-02T16:45:41-08:00'))
+    expect(commit.tree).to eq('28a1a1ca3e663d35ba8bf07d3f1781af71359b76')
   end
 
-  it "should parse xml with no namespace" do
-    product = Product.parse(fixture_file('product_no_namespace.xml'), :single => true)
-    expect(product.title).to eq("A Title")
+  it 'should parse xml with no namespace' do
+    product = Product.parse(fixture_file('product_no_namespace.xml'), single: true)
+    expect(product.title).to eq('A Title')
     expect(product.feature_bullets.bug).to eq('This is a bug')
     expect(product.feature_bullets.features.size).to eq(2)
     expect(product.feature_bullets.features[0].name).to eq('This is feature text 1')
     expect(product.feature_bullets.features[1].name).to eq('This is feature text 2')
   end
 
-  it "should parse xml with default namespace" do
-    product = Product.parse(fixture_file('product_default_namespace.xml'), :single => true)
-    expect(product.title).to eq("A Title")
+  it 'should parse xml with default namespace' do
+    product = Product.parse(fixture_file('product_default_namespace.xml'), single: true)
+    expect(product.title).to eq('A Title')
     expect(product.feature_bullets.bug).to eq('This is a bug')
     expect(product.feature_bullets.features.size).to eq(2)
     expect(product.feature_bullets.features[0].name).to eq('This is feature text 1')
     expect(product.feature_bullets.features[1].name).to eq('This is feature text 2')
   end
 
-  it "should parse xml with single namespace" do
-    product = Product.parse(fixture_file('product_single_namespace.xml'), :single => true)
-    expect(product.title).to eq("A Title")
+  it 'should parse xml with single namespace' do
+    product = Product.parse(fixture_file('product_single_namespace.xml'), single: true)
+    expect(product.title).to eq('A Title')
     expect(product.feature_bullets.bug).to eq('This is a bug')
     expect(product.feature_bullets.features.size).to eq(2)
     expect(product.feature_bullets.features[0].name).to eq('This is feature text 1')
     expect(product.feature_bullets.features[1].name).to eq('This is feature text 2')
   end
 
-  it "should parse xml with multiple namespaces" do
+  it 'should parse xml with multiple namespaces' do
     track = FedEx::TrackReply.parse(fixture_file('multiple_namespaces.xml'))
     expect(track.highest_severity).to eq('SUCCESS')
     expect(track.more_data).to be_falsey
@@ -885,7 +885,7 @@ describe HappyMapper do
     expect(track.tran_detail.cust_tran_id).to eq('20090102-111321')
   end
 
-  it "should be able to parse google analytics api xml" do
+  it 'should be able to parse google analytics api xml' do
     data = Analytics::Feed.parse(fixture_file('analytics.xml'))
     expect(data.id).to eq('http://www.google.com/analytics/feeds/accounts/nunemaker@gmail.com')
     expect(data.entries.size).to eq(4)
@@ -899,7 +899,7 @@ describe HappyMapper do
     expect(property.value).to eq('85301')
   end
 
-  it "should be able to parse google analytics profile xml with manually declared namespace" do
+  it 'should be able to parse google analytics profile xml with manually declared namespace' do
     data = Analytics::Profile.parse(fixture_file('analytics_profile.xml'))
     expect(data.entries.size).to eq(6)
 
@@ -909,7 +909,7 @@ describe HappyMapper do
     expect(entry.goals.size).to eq(0)
   end
 
-  it "should allow instantiating with a string" do
+  it 'should allow instantiating with a string' do
     module StringFoo
       class Bar
         include HappyMapper
@@ -922,67 +922,65 @@ describe HappyMapper do
     end
   end
 
-  it "should parse family search xml" do
+  it 'should parse family search xml' do
     tree = FamilySearch::FamilyTree.parse(fixture_file('family_tree.xml'))
     expect(tree.version).to eq('1.0.20071213.942')
     expect(tree.status_message).to eq('OK')
     expect(tree.status_code).to eq('200')
     expect(tree.persons.person.size).to eq(1)
     expect(tree.persons.person.first.version).to eq('1199378491000')
-    expect(tree.persons.person.first.modified).to eq(Time.utc(2008, 1, 3, 16, 41, 31)) # 2008-01-03T09:41:31-07:00
+    expect(tree.persons.person.first.modified).
+      to eq(Time.utc(2008, 1, 3, 16, 41, 31)) # 2008-01-03T09:41:31-07:00
     expect(tree.persons.person.first.id).to eq('KWQS-BBQ')
     expect(tree.persons.person.first.information.alternateIds.ids).not_to be_kind_of(String)
     expect(tree.persons.person.first.information.alternateIds.ids.size).to eq(8)
   end
 
-  it "should parse multiple images" do
+  it 'should parse multiple images' do
     artist = Artist.parse(fixture_file('multiple_primitives.xml'))
-    expect(artist.name).to eq("value")
+    expect(artist.name).to eq('value')
     expect(artist.images.size).to eq(2)
   end
 
-  it "should parse lastfm namespaces" do
+  it 'should parse lastfm namespaces' do
     l = Location.parse(fixture_file('lastfm.xml'))
-    expect(l.first.latitude).to eq("51.53469")
+    expect(l.first.latitude).to eq('51.53469')
   end
 
-  describe "Parse optional attributes" do
-
-    it "should parse an empty String as empty" do
+  describe 'Parse optional attributes' do
+    it 'should parse an empty String as empty' do
       a = OptionalAttribute.parse(fixture_file('optional_attributes.xml'))
-      expect(a[0].street).to eq("")
+      expect(a[0].street).to eq('')
     end
 
-    it "should parse a String with value" do
+    it 'should parse a String with value' do
       a = OptionalAttribute.parse(fixture_file('optional_attributes.xml'))
-      expect(a[1].street).to eq("Milchstrasse")
+      expect(a[1].street).to eq('Milchstrasse')
     end
 
-    it "should parse a String with value" do
+    it 'should parse a String with value' do
       a = OptionalAttribute.parse(fixture_file('optional_attributes.xml'))
       expect(a[2].street).to be_nil
     end
-
   end
 
-  describe "Default namespace combi" do
+  describe 'Default namespace combi' do
     before(:each) do
       file_contents = fixture_file('default_namespace_combi.xml')
-      @book = DefaultNamespaceCombi.parse(file_contents, :single => true)
+      @book = DefaultNamespaceCombi.parse(file_contents, single: true)
     end
 
-    it "should parse author" do
-      expect(@book.author).to eq("Frank Gilbreth")
+    it 'should parse author' do
+      expect(@book.author).to eq('Frank Gilbreth')
     end
 
-    it "should parse title" do
-      expect(@book.title).to eq("Cheaper by the Dozen")
+    it 'should parse title' do
+      expect(@book.title).to eq('Cheaper by the Dozen')
     end
 
-    it "should parse number" do
-      expect(@book.number).to eq("1568491379")
+    it 'should parse number' do
+      expect(@book.number).to eq('1568491379')
     end
-
   end
 
   describe 'Xml Content' do
@@ -991,10 +989,12 @@ describe HappyMapper do
       @records = Dictionary::Record.parse(file_contents)
     end
 
-    it "should parse XmlContent" do
-      expect(@records.first.definitions.first.text).to eq(
-        'a large common parrot, <bn>Cacatua galerita</bn>, predominantly white, with yellow on the undersides of wings and tail and a forward curving yellow crest, found in Australia, New Guinea and nearby islands.'
-      )
+    it 'should parse XmlContent' do
+      expect(@records.first.definitions.first.text).
+        to eq('a large common parrot, <bn>Cacatua galerita</bn>, predominantly' \
+              ' white, with yellow on the undersides of wings and tail and a' \
+              ' forward curving yellow crest, found in Australia, New Guinea' \
+              ' and nearby islands.')
     end
 
     it "should save object's xml content" do
@@ -1007,91 +1007,87 @@ describe HappyMapper do
     end
   end
 
-  it "should parse ambigous items" do
-    items = AmbigousItems::Item.parse(fixture_file('ambigous_items.xml'), :xpath => '/ambigous/my-items')
-    expect(items.map(&:name)).to eq(%w(first second third).map{|s| "My #{s} item" })
+  it 'should parse ambigous items' do
+    items = AmbigousItems::Item.parse(fixture_file('ambigous_items.xml'), xpath: '/ambigous/my-items')
+    expect(items.map(&:name)).to eq(%w(first second third).map { |s| "My #{s} item" })
   end
 
-
   context Article do
-    it "should parse the publish options for Article and Photo" do
+    it 'should parse the publish options for Article and Photo' do
       expect(@article.title).not_to be_nil
       expect(@article.text).not_to be_nil
       expect(@article.photos).not_to be_nil
       expect(@article.photos.first.title).not_to be_nil
     end
 
-    it "should parse the publish options for Article" do
+    it 'should parse the publish options for Article' do
       expect(@article.publish_options).not_to be_nil
     end
 
-    it "should parse the publish options for Photo" do
+    it 'should parse the publish options for Photo' do
       expect(@article.photos.first.publish_options).not_to be_nil
     end
 
-    it "should only find only items at the parent level" do
+    it 'should only find only items at the parent level' do
       expect(@article.photos.length).to eq(1)
     end
 
     before(:all) do
       @article = Article.parse(fixture_file('subclass_namespace.xml'))
     end
+  end
+
+  context 'Namespace is missing because an optional element that uses it is not present' do
+    it 'should parse successfully' do
+      @article = PartiallyBadArticle.parse(fixture_file('subclass_namespace.xml'))
+      expect(@article).not_to be_nil
+      expect(@article.title).not_to be_nil
+      expect(@article.text).not_to be_nil
+      expect(@article.photos).not_to be_nil
+      expect(@article.photos.first.title).not_to be_nil
+    end
+  end
+
+  describe 'with limit option' do
+    it 'should return results with limited size: 6' do
+      sizes = []
+      Post.parse(fixture_file('posts.xml'), in_groups_of: 6) do |a|
+        sizes << a.size
+      end
+      expect(sizes).to eq([6, 6, 6, 2])
+    end
 
+    it 'should return results with limited size: 10' do
+      sizes = []
+      Post.parse(fixture_file('posts.xml'), in_groups_of: 10) do |a|
+        sizes << a.size
+      end
+      expect(sizes).to eq([10, 10])
+    end
   end
 
-  context "Namespace is missing because an optional element that uses it is not present" do
-     it "should parse successfully" do
-       @article = PartiallyBadArticle.parse(fixture_file('subclass_namespace.xml'))
-       expect(@article).not_to be_nil
-       expect(@article.title).not_to be_nil
-       expect(@article.text).not_to be_nil
-       expect(@article.photos).not_to be_nil
-       expect(@article.photos.first.title).not_to be_nil
-     end
-   end
-
-
-   describe "with limit option" do
-     it "should return results with limited size: 6" do
-       sizes = []
-       Post.parse(fixture_file('posts.xml'), :in_groups_of => 6) do |a|
-         sizes << a.size
-       end
-       expect(sizes).to eq([6, 6, 6, 2])
-     end
-
-     it "should return results with limited size: 10" do
-       sizes = []
-       Post.parse(fixture_file('posts.xml'), :in_groups_of => 10) do |a|
-         sizes << a.size
-       end
-       expect(sizes).to eq([10, 10])
-     end
-   end
-
-  context "when letting user set Nokogiri::XML::ParseOptions" do
-    let(:default) {
+  context 'when letting user set Nokogiri::XML::ParseOptions' do
+    let(:default) do
       Class.new do
         include HappyMapper
         element :item, String
       end
-    }
-    let(:custom) {
+    end
+    let(:custom) do
       Class.new do
         include HappyMapper
         element :item, String
-        with_nokogiri_config do |config|
-          config.default_xml
-        end
+        with_nokogiri_config(&:default_xml)
       end
-    }
+    end
 
     it 'initializes @nokogiri_config_callback to nil' do
       expect(default.nokogiri_config_callback).to be_nil
     end
 
     it 'defaults to Nokogiri::XML::ParseOptions::STRICT' do
-     expect { default.parse(fixture_file('set_config_options.xml')) }.to raise_error(Nokogiri::XML::SyntaxError)
+      expect { default.parse(fixture_file('set_config_options.xml')) }.
+        to raise_error(Nokogiri::XML::SyntaxError)
     end
 
     it 'accepts .on_config callback' do
@@ -1104,7 +1100,8 @@ describe HappyMapper do
 
     it 'can clear @nokogiri_config_callback' do
       custom.with_nokogiri_config {}
-      expect { custom.parse(fixture_file('set_config_options.xml')) }.to raise_error(Nokogiri::XML::SyntaxError)
+      expect { custom.parse(fixture_file('set_config_options.xml')) }.
+        to raise_error(Nokogiri::XML::SyntaxError)
     end
   end
 
@@ -1113,7 +1110,8 @@ describe HappyMapper do
       xml = fixture_file('unformatted_address.xml')
       address = Address.parse(xml, single: true)
 
-      expect(address.xml_value).to eq %{<address><street>Milchstrasse</street><housenumber>23</housenumber></address>}
+      expect(address.xml_value).
+        to eq %(<address><street>Milchstrasse</street><housenumber>23</housenumber></address>)
     end
   end
 
@@ -1122,8 +1120,17 @@ describe HappyMapper do
       xml = fixture_file('unformatted_address.xml')
       address = Address.parse(xml)
 
-      expect(address.xml_content).to eq %{<street>Milchstrasse</street><housenumber>23</housenumber>}
+      expect(address.xml_content).to eq %(<street>Milchstrasse</street><housenumber>23</housenumber>)
     end
   end
 
+  describe '#to_xml' do
+    let(:original) { '<foo><bar>baz</bar></foo>' }
+    let(:parsed) { described_class.parse original }
+
+    it 'has UTF-8 encoding by default' do
+      expect(original.encoding).to eq Encoding::UTF_8
+      expect(parsed.to_xml.encoding).to eq Encoding::UTF_8
+    end
+  end
 end