newsletter 3.0.2 → 3.2.0

data/spec/test_app/spec/controllers/newsletter/pieces_controller_spec.rb

@@ -0,0 +1,175 @@
+require 'rails_helper'
+
+# This spec was generated by rspec-rails when you ran the scaffold generator.
+# It demonstrates how one might use RSpec to specify the controller code that
+# was generated by Rails when you ran the scaffold generator.
+#
+# It assumes that the implementation code is generated by the rails scaffold
+# generator.  If you are using any extension libraries to generate different
+# controller code, this generated spec may or may not pass.
+#
+# It only uses APIs available in rails and/or rspec-rails.  There are a number
+# of tools you can use to make these specs even more expressive, but we're
+# sticking to rails and rspec-rails APIs to keep things simple and stable.
+#
+# Compared to earlier versions of this generator, there is very limited use of
+# stubs and message expectations in this spec.  Stubs are only used when there
+# is no simpler way to get a handle on the object needed for the example.
+# Message expectations are only used when there is no simpler way to specify
+# that an instance is receiving a specific message.
+
+RSpec.describe Newsletter::PiecesController, :type => :controller do
+  render_views
+  routes {Newsletter::Engine.routes}
+  # This should return the minimal set of attributes required to create a valid
+  # Newsletter::Piece. As you add validations to Newsletter::Piece, be sure to
+  # adjust the attributes here as well.
+  before(:each) do
+    @design = import_design
+    @newsletter = FactoryGirl.create(:newsletter, design: @design)
+    @area = @newsletter.area('right_column')
+    @element = @area.elements.detect{|e| e.name.eql?('Right Column Headline')}
+    @field = @element.fields.first
+  end
+  let(:valid_attributes) {{
+    newsletter_id: @newsletter.id,
+    area_id: @area.id,
+    element_id: @element.id,
+    field_values_attributes: {
+      @field.id => {
+        text: "Extra! Extra!"
+      }
+    }
+  }}
+
+  let(:invalid_attributes) {{
+    newsletter_id: @newsletter.id,
+    element_id: @element.id,
+    field_values_attributes: {
+      @field.id => {
+        text: "Extra! Extra!"
+      }
+    }
+  }}
+
+  # This should return the minimal set of values that should be in the session
+  # in order to pass any filters (e.g. authentication) defined in
+  # Newsletter::PiecesController. Be sure to keep this updated too.
+  let(:valid_session) { {} }
+
+  describe "GET #new" do
+    it "assigns a new piece as @piece" do
+      get :new, {newsletter_id: @newsletter.id, element_id: @element.id, area_id: @area.id}, 
+        valid_session
+      expect(assigns(:piece)).to be_a_new(Newsletter::Piece)
+    end
+  end
+
+  describe "GET #edit" do
+    it "assigns the requested piece as @piece" do
+      piece = Newsletter::Piece.create! valid_attributes
+      get :edit, {:id => piece.to_param}, valid_session
+      expect(assigns(:piece)).to eq(piece)
+    end
+  end
+
+  describe "POST #create" do
+    context "with valid params" do
+      it "creates a new Newsletter::Piece" do
+        expect {
+          post :create, {:piece => valid_attributes}, valid_session
+        }.to change(Newsletter::Piece, :count).by(1)
+      end
+
+      it "assigns a newly created piece as @piece" do
+        post :create, {:piece => valid_attributes}, valid_session
+        expect(assigns(:piece)).to be_a(Newsletter::Piece)
+        expect(assigns(:piece)).to be_persisted
+      end
+
+      it "redirects to the created piece" do
+        post :create, {:piece => valid_attributes}, valid_session
+        expect(response).to redirect_to(edit_newsletter_path(@newsletter))
+      end
+    end
+
+    context "with invalid params" do
+      it "assigns a newly created but unsaved piece as @piece" do
+        pending "Currently having issues forcing a piece to be valid and save, also except for associations... there are no validations currently"
+        post :create, {:piece => invalid_attributes}, valid_session
+        expect(assigns(:piece)).to be_a_new(Newsletter::Piece)
+      end
+
+      it "re-renders the 'new' template" do
+        pending "Currently having issues forcing a piece to be valid and save, also except for associations... there are no validations currently"
+        post :create, {:piece => invalid_attributes}, valid_session
+        expect(response).to render_template("new")
+      end
+    end
+  end
+
+  describe "PUT #update" do
+    context "with valid params" do
+      let(:new_attributes) {{
+        newsletter_id: @newsletter.id,
+        area_id: @area.id,
+        element_id: @element.id,
+        field_values_attributes: {
+          @field.id => {
+            text: "Extra! Extra!"
+          }
+        }
+      }}
+
+      it "updates the requested piece" do
+        piece = Newsletter::Piece.create! valid_attributes
+        put :update, {:id => piece.to_param, :piece => new_attributes}, valid_session
+        piece.reload
+        skip("Add assertions for updated state")
+      end
+
+      it "assigns the requested piece as @piece" do
+        piece = Newsletter::Piece.create! valid_attributes
+        put :update, {:id => piece.to_param, :piece => valid_attributes}, valid_session
+        expect(assigns(:piece)).to eq(piece)
+      end
+
+      it "redirects to the newsletter edit" do
+        piece = Newsletter::Piece.create! valid_attributes
+        put :update, {:id => piece.to_param, :piece => valid_attributes}, valid_session
+        expect(response).to redirect_to(edit_newsletter_path(@newsletter))
+      end
+    end
+
+    context "with invalid params" do
+      it "assigns the piece as @piece" do
+        piece = Newsletter::Piece.create! valid_attributes
+        put :update, {:id => piece.to_param, :piece => invalid_attributes}, valid_session
+        expect(assigns(:piece)).to eq(piece)
+      end
+
+      it "re-renders the 'edit' template" do
+        pending "Currently having issues forcing a piece to be valid and save, also except for associations... there are no validations currently"
+        piece = Newsletter::Piece.create! valid_attributes
+        put :update, {:id => piece.to_param, :piece => invalid_attributes}, valid_session
+        expect(response).to render_template("edit")
+      end
+    end
+  end
+
+  describe "DELETE #destroy" do
+    it "destroys the requested piece" do
+      piece = Newsletter::Piece.create! valid_attributes
+      expect {
+        delete :destroy, {:id => piece.to_param}, valid_session
+      }.to change(Newsletter::Piece, :count).by(-1)
+    end
+
+    it "redirects to the newsletter edit" do
+      piece = Newsletter::Piece.create! valid_attributes
+      delete :destroy, {:id => piece.to_param}, valid_session
+      expect(response).to redirect_to(edit_newsletter_path(@newsletter))
+    end
+  end
+
+end

data/spec/test_app/spec/factories/_functions.rb

@@ -0,0 +1,19 @@
+def random_bool
+  Kernel.rand(2) == 1
+end
+
+def random_int(min,max)
+  count = max - min + 1
+  Kernel.rand(count) + min
+end
+
+def random_decimal(min,max,precision=2)
+  multiplier = 10 ** precision
+  count = max - min + 1
+  puts "multiplier: #{multiplier}"
+  (Kernel.rand(count * multiplier) + min * multiplier).to_f / multiplier
+end
+
+def random_value(values)
+  values[random_int(0,(values.length-1))]
+end

data/spec/test_app/spec/factories/assets.rb

@@ -0,0 +1,8 @@
+FactoryGirl.define do
+  factory :asset, class: Newsletter::Asset do
+    #association :field
+    #association :piece
+    image File.open(File.join(Newsletter::PLUGIN_ROOT,'spec','test_app',
+      'spec','support','files','iReach_logo.gif'))
+  end
+end

data/spec/test_app/spec/factories/designs.rb

@@ -1,7 +1,7 @@
 # Read about factories at https://github.com/thoughtbot/factory_girl
 def import_design(file=nil, name=nil)
   name ||= Faker::Company.bs.split(/\s+/).each(&:capitalize).join(' ')
-  file ||= File.join(Rails.root,'..','..','designs','exports','example-export.yaml')
+  file ||= File.join(Newsletter::PLUGIN_ROOT,'designs','exports','example-export.yaml')
   Newsletter::Design.import(file,name)
 end
 

data/spec/test_app/spec/factories/newsletters.rb

@@ -2,8 +2,8 @@
 
 FactoryGirl.define do
   factory :newsletter, class: Newsletter::Newsletter do
-    name {Faker::Lorem.words}
-    description {Faker::Lorem.paragraphs}
+    name {Faker::Company.name}
+    description {Faker::Lorem.paragraphs(1)[0..125]}
     association :design
     pieces do |newsletter|
       left_area = newsletter.design.areas.where(name: 'left_column').first
@@ -16,13 +16,75 @@ FactoryGirl.define do
       #right_area = newsletter.design.areas.where(name: 'right_column').first
       
       [ ::Newsletter::Piece.new(
-        area: left_area,
-        element: left_image_element,
+        area_id: left_area.id,
+        element_id: left_image_element.id,
         field_values_attributes: { image_field.id => {
-          url: 'https://encrypted-tbn0.gstatic.com/images?q=tbn:ANd9GcRwNmnMYLBp2Sw9vg-snbZ_GKONKo_WY0f3S1ETL2era2DZKKqD'
+          url: Faker::Internet.url.gsub(%r#(/[^/]*\.[^/]*)?$#,'/bobo.jpg')
         }}
       )]
     end
- end
+    factory :newsletter_with_image_asset do
+      pieces do | newsletter | 
+        left_area = newsletter.design.areas.where(name: 'left_column').first
+        left_image_element = left_area.elements.where(name: 'Left Column Image').first
+        image_field = left_image_element.fields.first
+        #article = area.elements.where(name: 'Left Column Article').first
+        #link = article.fields.where(name: 'link').first
+        #headline = article.fields.where(name: 'headline').first
+        #excerpt = article.fields.where(name: 'article_excerpt').first
+        #right_area = newsletter.design.areas.where(name: 'right_column').first
+        
+        [ ::Newsletter::Piece.new(
+          area_id: left_area.id,
+          element_id: left_image_element.id,
+          field_values_attributes: { image_field.id => {
+            uploaded_data: Rack::Test::UploadedFile.new(File.open(File.join(Rails.root, 
+              '/spec/support/files/iReach_logo.gif')))
+          }}
+        )]
+      end
+    end
+    factory :newsletter_with_pdf_asset do
+      pieces do | newsletter | 
+        left_area = newsletter.design.areas.where(name: 'left_column').first
+        left_image_element = left_area.elements.where(name: 'Left Column Image').first
+        image_field = left_image_element.fields.first
+        #article = area.elements.where(name: 'Left Column Article').first
+        #link = article.fields.where(name: 'link').first
+        #headline = article.fields.where(name: 'headline').first
+        #excerpt = article.fields.where(name: 'article_excerpt').first
+        #right_area = newsletter.design.areas.where(name: 'right_column').first
+        
+        [ ::Newsletter::Piece.new(
+          area_id: left_area.id,
+          element_id: left_image_element.id,
+          field_values_attributes: { image_field.id => {
+            uploaded_data: Rack::Test::UploadedFile.new(File.open(File.join(Rails.root, 
+              '/spec/support/files/test.pdf')))
+          }}
+        )]
+      end
+    end
+    factory :newsletter_with_pdf_url do
+      pieces do | newsletter | 
+        left_area = newsletter.design.areas.where(name: 'left_column').first
+        left_image_element = left_area.elements.where(name: 'Left Column Image').first
+        image_field = left_image_element.fields.first
+        #article = area.elements.where(name: 'Left Column Article').first
+        #link = article.fields.where(name: 'link').first
+        #headline = article.fields.where(name: 'headline').first
+        #excerpt = article.fields.where(name: 'article_excerpt').first
+        #right_area = newsletter.design.areas.where(name: 'right_column').first
+        
+        [ ::Newsletter::Piece.new(
+          area_id: left_area.id,
+          element_id: left_image_element.id,
+          field_values_attributes: { image_field.id => {
+            url: Faker::Internet.url.gsub(%r#(/[^/]*\.[^/]*)?$#,'/bobo.pdf')
+          }}
+        )]
+      end
+    end
+  end
 end
 

data/spec/test_app/spec/factories/pieces.rb

@@ -0,0 +1,8 @@
+FactoryGirl.define do
+  factory :piece, class: Newsletter::Piece do
+    #association :field
+    #association :piece
+    #image File.open(File.join(Rails.root, 
+      #'/spec/support/files/iReach_logo.gif'))
+  end
+end

data/spec/test_app/spec/factories/users.rb

@@ -0,0 +1,13 @@
+# Read about factories at https://github.com/thoughtbot/factory_girl
+begin
+  FactoryGirl.define do
+    factory :user do
+      first_name {Faker::Name.first_name}
+      last_name {Faker::Name.last_name}
+      email {Faker::Internet.email}
+      phone {Faker::PhoneNumber.phone_number}
+    end
+  end
+rescue FactoryGirl::DuplicateDefinitionError => e
+  # this is OK ... since it could blow up because of ireach
+end

data/spec/test_app/spec/features/newsletter/design_spec.rb

@@ -0,0 +1,175 @@
+require 'rails_helper'
+
+RSpec.feature Newsletter::Design do 
+  let(:left_area_only_layout) {
+    <<EOT
+  <%= render left_area %>
+EOT
+  }
+  let(:full_layout) {
+    <<EOT
+  <%= render left_area %>
+  <%= render right_area %>
+EOT
+  }
+  context "a new design" do
+    it "can be created", js: true do
+      visit "/newsletter/designs"
+      click_link "New Design"
+      fill_in "Name", with: "My Design"
+      fill_in "Description", with: "This is an awesome design!"
+      fill_in "HTML code", with: left_area_only_layout
+      click_link "Add Area"
+      find(:css, ".area input").set 'left_area'
+      click_button "Submit"
+      @design = Newsletter::Design.where(name: 'My Design').first
+      expect(Newsletter::Design.count).to eq 1
+      expect(@design.description).to eq "This is an awesome design!"
+      expect(remove_whitespace(@design.html_text)).to eq remove_whitespace(
+        left_area_only_layout)
+      expect(@design.areas.count).to eq 1
+      @left_area = @design.areas.first
+      expect(@left_area.name).to eq "left_area"
+      and_it "can be edited" do
+        click_link "Add Area"
+        find(:css, "#new_area input").set 'right_area'
+        fill_in "HTML code", with: full_layout
+        click_button "Submit"
+        @design = Newsletter::Design.first
+        expect(Newsletter::Design.count).to eq 1
+        expect(@design.areas.count).to eq 2
+        @right_area = @design.areas.detect{|a| a.name.eql?('right_area')}
+        @left_area = @design.areas.detect{|a| a.name.eql?('left_area')}
+        expect(remove_whitespace(@design.html_text)).to eq remove_whitespace(full_layout)
+      end
+      and_it "when managing elements" do
+        and_it "can create an element with a text area in the left area" do
+          click_link "Manage Elements"
+          click_link "New Newsletter Element"
+          fill_in "Name", with: "Left Area Text"
+          fill_in "Description", with: "Left Area Text description instructions"
+          fill_in "HTML code", with: "<%= filter(my_paragraph) %>"
+          click_link "Add Field"
+          within(:css, "#new_field") do
+            fill_in "Name", with: "my_paragraph"
+            fill_in "Label", with: "My Paragraph"
+            fill_in "Description", with: "My Paragraph is a text area for you!"
+            select "Textarea", from: "Type"
+          end
+          check "left_area"
+          click_button "Submit"
+          expect(Newsletter::Element.count).to eq 1
+          @left_area.reload
+          expect(@left_area.elements.count).to eq 1
+          @left_area_text = @left_area.elements.first
+          @left_area_text_field = @left_area_text.fields.first
+          expect(@left_area_text.fields.length).to eq 1
+          expect(@left_area_text.name).to eq "Left Area Text"
+          expect(@left_area_text.description).to eq \
+            "Left Area Text description instructions"
+          expect(@left_area_text.html_text).to eq "<%= filter(my_paragraph) %>"
+          expect(@left_area_text_field.class).to eq Newsletter::Field::TextArea
+          expect(@left_area_text_field.name).to eq "my_paragraph"
+          expect(@left_area_text_field.description).to eq \
+            "My Paragraph is a text area for you!"
+          expect(@left_area_text_field.label).to eq "My Paragraph"
+          click_link "Edit"
+          expect(page).to have_content "Edit Element '#{@left_area_text.name}'"
+          click_link "View All"
+          click_link "Back to Design"
+        end
+        and_it "can create an element with a text field in the right area" do
+          click_link "Manage Elements"
+          click_link "New Newsletter Element"
+          fill_in "Name", with: "Right Area Text"
+          fill_in "Description", with: "Right Area Text description instructions"
+          fill_in "HTML code", with: "<%= filter(my_paragraph) %>"
+          click_link "Add Field"
+          within(:css, "#new_field") do
+            fill_in "Name", with: "my_text"
+            fill_in "Label", with: "My Text"
+            fill_in "Description", with: "My Text is a text area for you!"
+            select "Text", from: "Type"
+          end
+          check "right_area"
+          click_button "Submit"
+          expect(Newsletter::Element.count).to eq 2
+          @right_area.reload
+          expect(@right_area.elements.count).to eq 1
+          @right_area_text = @right_area.elements.first
+          @right_area_text_field = @right_area_text.fields.first
+          expect(@right_area_text.fields.length).to eq 1
+          expect(@right_area_text.name).to eq "Right Area Text"
+          expect(@right_area_text.description).to eq \
+            "Right Area Text description instructions"
+          expect(@right_area_text.html_text).to eq "<%= filter(my_paragraph) %>"
+          expect(@right_area_text_field.class).to eq Newsletter::Field::Text
+          expect(@right_area_text_field.name).to eq "my_text"
+          expect(@right_area_text_field.description).to eq \
+            "My Text is a text area for you!"
+          expect(@right_area_text_field.label).to eq "My Text"
+          click_link "Back to Design"
+        end
+        and_it "can create an element with an inline asset" do
+          click_link "Manage Elements"
+          click_link "New Newsletter Element"
+          fill_in "Name", with: "Nice Image"
+          fill_in "Description", with: "Image description instructions"
+          fill_in "HTML code", with: "<%= image_tag nice_image.image.url %>"
+          click_link "Add Field"
+          within(:css, "#new_field") do
+            fill_in "Name", with: "nice_image"
+            fill_in "Label", with: "Nice Image"
+            fill_in "Description", with: "Nice Image is an image for you!"
+            select "Inlineasset", from: "Type"
+          end
+          check "right_area"
+          check "left_area"
+          click_button "Submit"
+          expect(Newsletter::Element.count).to eq 3
+          @right_area.reload
+          @left_area.reload
+          expect(@right_area.elements.count).to eq 2
+          expect(@right_area.elements.count).to eq 2
+          @nice_image = @left_area.elements.detect{|e| e.name.eql?('Nice Image')}
+          expect(@nice_image.fields.length).to eq 1
+          @nice_image_field = @nice_image.fields.first
+          expect(@nice_image.name).to eq "Nice Image"
+          expect(@nice_image.description).to eq \
+            "Image description instructions"
+          expect(@nice_image.html_text).to eq "<%= image_tag nice_image.image.url %>"
+          expect(@nice_image_field.class).to eq Newsletter::Field::InlineAsset
+          expect(@nice_image_field.name).to eq "nice_image"
+          expect(@nice_image_field.description).to eq \
+            "Nice Image is an image for you!"
+          expect(@nice_image_field.label).to eq "Nice Image"
+          click_link "Back to Design"
+        end
+        and_it "soft deletes designs" do
+          click_link "View All"
+          click_link "Delete"
+          expect(Newsletter::Design.count).to eq 0
+          expect(Newsletter::Design.deleted.count).to eq 1
+        end
+      end
+    end
+  end
+  it "can sort an element's fields" do
+    pending "Not tested"
+    design = import_design
+    element = design.elements.detect{|e| e.name.eql?('Left Column Article')}
+    visit "/newsletter/designs/#{design.id}/edit"
+    click_link "Manage Elements"
+    within(:css, "#element_1") do
+      click_link "Edit"
+    end
+    raise "Not Tested"
+  end
+  it "paginates when there are a lot of them" do
+    50.times{import_design(nil,Faker::Company.bs)}
+    visit "/newsletter/designs"
+    expect(page.body).to match /Next/
+    expect(page.body).to match /Previous/
+    click_link "Next"
+  end
+end